18647a532483470d9f64bc6cb1bbeeda39c2670d
The local variable ifaceId generates a compiler warning that it is used
without initialisation.
The loop, and check against the loop iterator, and the
topology.num_interfaces actually ensures that this isn't the case, and
that ifaceId can only be used when set to a valid ID.
The media_v2_interface.id field documents the ID as simply "Unique ID
for the interface" but does not specify if zero is a valid ID or not. As
such we don't further check the pre-initialised ID for validity and keep
the existing check on the iterator count to determine if the ID had been
discovered successfully.
Fixes: d4af90d729 ("libcamera: media_device: Create entities with
major and minor numbers")
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
libcamera: A complex camera support library for Linux, Android, and ChromeOS
To build and install:
meson build
cd build
ninja
ninja install
Description
Languages
C++
69.3%
C
17.8%
Python
10.4%
Meson
1.5%
Shell
0.7%
Other
0.3%