PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gstreamer: Associate libcamera::Stream with GstPad

Browse Source 
Instead of trying to figure out which libcamera::Stream, the GstPad
is configured with (from the libcamera pool), associate the Stream
with the GstPad directly. The association can be set using
gst_pad_set_element_private().

Add the gst_libcamera_pad_set_stream() helper to associate the stream
with the pad. Additionally, modify the gst_libcamera_pad_get_stream()
to use to the getter helper gst_pad_get_element_private().

Signed-off-by: Umang Jain <uajain@igalia.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Umang Jain
2025-11-03 21:30:12 +00:00
committed by Kieran Bingham
parent 79be15a5f1
commit f6f5bd28dc
3 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/gstreamer/gstlibcamerapad.cpp
View File

@@ -192,12 +192,13 @@ void gst_libcamera_pad_set_video_info(GstPad *pad, const GstVideoInfo *info)
Stream *
gst_libcamera_pad_get_stream(GstPad *pad)
{
auto *self = GST_LIBCAMERA_PAD(pad);
return static_cast<Stream *>(gst_pad_get_element_private(pad));
}
if (self->pool)
return gst_libcamera_pool_get_stream(self->pool);
return nullptr;
void
gst_libcamera_pad_set_stream(GstPad *pad, Stream *stream)
{
gst_pad_set_element_private(pad, stream);
}
void

2
src/gstreamer/gstlibcamerapad.h
View File

@@ -33,4 +33,6 @@ void gst_libcamera_pad_set_video_info(GstPad *pad, const GstVideoInfo *info);
libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);
void gst_libcamera_pad_set_stream(GstPad *pad, libcamera::Stream *stream);
void gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency);

6
src/gstreamer/gstlibcamerasrc.cpp
View File

@@ -357,7 +357,7 @@ int GstLibcameraSrcState::processRequest()
GstBuffer *buffer = wrap->detachBuffer(stream);
FrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);
const StreamConfiguration &stream_cfg = config_->at(i);
const StreamConfiguration &stream_cfg = stream->configuration();
GstBufferPool *video_pool = gst_libcamera_pad_get_video_pool(srcpad);
if (video_pool) {
@@ -692,6 +692,9 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)
gst_libcamera_pad_set_pool(srcpad, pool);
gst_libcamera_pad_set_video_pool(srcpad, video_pool);
/* Associate the configured stream with the source pad. */
gst_libcamera_pad_set_stream(srcpad, stream_cfg.stream());
/* Clear all reconfigure flags. */
gst_pad_check_reconfigure(srcpad);
}
@@ -888,6 +891,7 @@ gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,
for (GstPad *srcpad : state->srcpads_) {
gst_libcamera_pad_set_latency(srcpad, GST_CLOCK_TIME_NONE);
gst_libcamera_pad_set_pool(srcpad, nullptr);
gst_libcamera_pad_set_stream(srcpad, nullptr);
}
}