PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: ipu3: Import instead of allocate statistic buffers

Browse Source 
Statistics buffers are not yet used by the IPU3 pipeline, they are never
queued to the statistics video device or in any other way consumed. The
kernel driver will however not allow video streaming to start if buffers
are not either allocated or imported on the statistics video device.
Instead of allocating the buffers wasting memory that is never used,
import buffers.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2020-06-27 00:28:04 +02:00
parent 76332f0f8a
commit dcb3e7e2df
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcamera/pipeline/ipu3/ipu3.cpp
View File

@@ -1135,11 +1135,13 @@ int ImgUDevice::allocateBuffers(IPU3CameraData *data, unsigned int bufferCount)
}
/*
* Use for the stat's internal pool the same number of buffers as for
* the input pool.
* The kernel fails to start if buffers are not either imported or
* allocated for the statistics video device. As statistics buffers are
* not yet used by the pipeline import buffers to save memory.
*
* \todo To be revised when we'll actually use the stat node.
*/
ret = stat_.dev->allocateBuffers(bufferCount, &stat_.buffers);
ret = stat_.dev->importBuffers(bufferCount);
if (ret < 0) {
LOG(IPU3, Error) << "Failed to allocate ImgU stat buffers";
goto error;