PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: pipeline: raspberrypi: Fix initial value for scoring routine

Browse Source 
Use std::numerical_limits to initialise the best score instead of an
arbitrary value. This fixes a failure in v4l2-conformance when using
the Raspberry Pi pipeline handler and v4l2-compatibility libcamera
layer.

Reported-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Naushir Patuck
2020-07-06 14:52:54 +01:00
committed by Paul Elder
parent e37e72c61c
commit d76acac30d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
View File

@@ -69,7 +69,7 @@ double scoreFormat(double desired, double actual)
V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)
{
double bestScore = 9e9, score;
double bestScore = std::numeric_limits<double>::max(), score;
V4L2DeviceFormat bestMode = {};
#define PENALTY_AR 1500.0