PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: pipeline_handler: Do not use argument as local variable

Browse Source 
In completeRequest() the request argument is used as a local variable,
this is confusing. Add a separate local variable instead of reusing the
argument.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2019-10-27 04:49:58 +01:00
parent c360857c5d
commit bcf4299453
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcamera/pipeline_handler.cpp
View File

@@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request)
CameraData *data = cameraData(camera);
while (!data->queuedRequests_.empty()) {
request = data->queuedRequests_.front();
if (request->status() == Request::RequestPending)
Request *req = data->queuedRequests_.front();
if (req->status() == Request::RequestPending)
break;
ASSERT(!request->hasPendingBuffers());
ASSERT(!req->hasPendingBuffers());
data->queuedRequests_.pop_front();
camera->requestComplete(request);
camera->requestComplete(req);
}
}