PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: media_device: Return string references to avoid copies

Browse Source 
The MediaDevice::driver(), deviceNode() and model() functions return a
const std::string, copying the string stored internally in the class.
Return references instead to avoid copies.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Laurent Pinchart
2022-05-26 15:46:04 +03:00
parent b7ce7e1d34
commit 7d1f03e5ba
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/libcamera/internal/media_device.h
View File

@@ -38,9 +38,9 @@ public:
int populate();
bool isValid() const { return valid_; }
const std::string driver() const { return driver_; }
const std::string deviceNode() const { return deviceNode_; }
const std::string model() const { return model_; }
const std::string &driver() const { return driver_; }
const std::string &deviceNode() const { return deviceNode_; }
const std::string &model() const { return model_; }
unsigned int version() const { return version_; }
unsigned int hwRevision() const { return hwRevision_; }