PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipa: software_isp: Fix context_.configuration.agc.againMin init

Browse Source 
Currently context_.configuration.agc.againMin is not initialized
when the control reports a non 0 minimum gain value.

So far only the againMin == 0 case was handled and
context_.configuration.agc.againMin was left unset otherwise.

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
Tested-by: Milan Zamazal <mzamazal@redhat.com>
Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Hans de Goede <hansg@kernel.org>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Hans de Goede
2025-09-30 17:04:23 +02:00
committed by Kieran Bingham
parent 25b254fe61
commit 7a7935e4bc
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ipa/simple/soft_simple.cpp
View File

@@ -246,7 +246,9 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)
* other) we limit the range of the gain values used.
*/
context_.configuration.agc.againMax = againMax;
if (!againMin) {
if (againMin) {
context_.configuration.agc.againMin = againMin;
} else {
LOG(IPASoft, Warning)
<< "Minimum gain is zero, that can't be linear";
context_.configuration.agc.againMin =