PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

android: mm: cros_camera_buffer: Log failure error on cleanup

Browse Source 
Failure can still happen by CameraBufferManager during Unlock() and/or
Deregister() of camera3Buffer handles. We should be logging those
errors as well.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Umang Jain
2021-09-07 20:29:49 +05:30
parent 39c2d5dc95
commit 68fe3b058a
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/android/mm/cros_camera_buffer.cpp
View File

@@ -73,10 +73,20 @@ CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,
CameraBuffer::Private::~Private()
{
if (mapped_)
bufferManager_->Unlock(handle_);
if (registered_)
bufferManager_->Deregister(handle_);
int ret;
if (mapped_) {
ret = bufferManager_->Unlock(handle_);
if (ret != 0)
LOG(HAL, Error) << "Failed to unlock buffer: "
<< strerror(-ret);
}
if (registered_) {
ret = bufferManager_->Deregister(handle_);
if (ret != 0)
LOG(HAL, Error) << "Failed to deregister buffer: "
<< strerror(-ret);
}
}
unsigned int CameraBuffer::Private::numPlanes() const