libcamera: camera_sensor: Sort factories by priority
In order to support a default implementation for camera sensors when no better implementation matches, libcamera needs to try "specialized" implementations first and pick the default last. Make this possible by adding a priority value for factories. Newly registered factories are inserted in the factories list sorted by descending priority, and the default factory uses a negative priority to be inserted as the last element. This mechanism may be a bit overkill in the sense that there is no expected use cases for priorities other than trying the default last, but the implementation is simple and easy to understand. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
committed by
Jacopo Mondi
parent
aee7f8207e
commit
5cb45181d7
@@ -78,12 +78,13 @@ public:
|
||||
class CameraSensorFactoryBase
|
||||
{
|
||||
public:
|
||||
CameraSensorFactoryBase(const char *name);
|
||||
CameraSensorFactoryBase(const char *name, int priority);
|
||||
virtual ~CameraSensorFactoryBase() = default;
|
||||
|
||||
static std::unique_ptr<CameraSensor> create(MediaEntity *entity);
|
||||
|
||||
const std::string &name() const { return name_; }
|
||||
int priority() const { return priority_; }
|
||||
|
||||
private:
|
||||
LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorFactoryBase)
|
||||
@@ -96,14 +97,15 @@ private:
|
||||
match(MediaEntity *entity) const = 0;
|
||||
|
||||
std::string name_;
|
||||
int priority_;
|
||||
};
|
||||
|
||||
template<typename _CameraSensor>
|
||||
class CameraSensorFactory final : public CameraSensorFactoryBase
|
||||
{
|
||||
public:
|
||||
CameraSensorFactory(const char *name)
|
||||
: CameraSensorFactoryBase(name)
|
||||
CameraSensorFactory(const char *name, int priority)
|
||||
: CameraSensorFactoryBase(name, priority)
|
||||
{
|
||||
}
|
||||
|
||||
@@ -115,7 +117,7 @@ private:
|
||||
}
|
||||
};
|
||||
|
||||
#define REGISTER_CAMERA_SENSOR(sensor) \
|
||||
static CameraSensorFactory<sensor> global_##sensor##Factory{ #sensor };
|
||||
#define REGISTER_CAMERA_SENSOR(sensor, priority) \
|
||||
static CameraSensorFactory<sensor> global_##sensor##Factory{ #sensor, priority };
|
||||
|
||||
} /* namespace libcamera */
|
||||
|
||||
Reference in New Issue
Block a user