libcamera: camera: Log proposed configuration in streamConfiguration()
The IPU3 and RKISP1 pipeline handlers log the camera configuration they propose in their streamConfiguration() methods. Other pipeline handlers are expected to log similar information, move it to the Camera class. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
@@ -546,7 +546,20 @@ Camera::streamConfiguration(const std::vector<StreamUsage> &usages)
|
||||
if (disconnected_ || !usages.size() || usages.size() > streams_.size())
|
||||
return CameraConfiguration();
|
||||
|
||||
return pipe_->streamConfiguration(this, usages);
|
||||
CameraConfiguration config = pipe_->streamConfiguration(this, usages);
|
||||
|
||||
std::ostringstream msg("streams configuration:");
|
||||
unsigned int index = 0;
|
||||
|
||||
for (Stream *stream : config) {
|
||||
const StreamConfiguration &cfg = config[stream];
|
||||
msg << " (" << index << ") " << cfg.toString();
|
||||
index++;
|
||||
}
|
||||
|
||||
LOG(Camera, Debug) << msg.str();
|
||||
|
||||
return config;
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -316,10 +316,6 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,
|
||||
streamConfig.bufferCount = IPU3_BUFFER_COUNT;
|
||||
|
||||
cameraConfig[stream] = streamConfig;
|
||||
|
||||
LOG(IPU3, Debug)
|
||||
<< "Stream '" << stream->name_ << "' format set to "
|
||||
<< streamConfig.toString();
|
||||
}
|
||||
|
||||
return cameraConfig;
|
||||
|
||||
@@ -124,8 +124,6 @@ CameraConfiguration PipelineHandlerRkISP1::streamConfiguration(Camera *camera,
|
||||
|
||||
configs[&data->stream_] = config;
|
||||
|
||||
LOG(RkISP1, Debug) << "Stream format set to " << config.toString();
|
||||
|
||||
return configs;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user