PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: v4l2_videodevice: Align which type variable is used in queueBuffer()

Browse Source 
Reading V4L2VideoDevice::queueBuffer() is confusing since buf.type is
first set to bufferType_ but then both variables are used in V4L2 macros
to operate based on which type of buffer is being processed. Align on
only using buf.type since it has the most existing users.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2019-11-22 00:04:03 +01:00
parent fca1109155
commit 3f9d34f55e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libcamera/v4l2_videodevice.cpp
View File

@@ -1004,7 +1004,7 @@ int V4L2VideoDevice::queueBuffer(Buffer *buffer)
buf.m.planes = v4l2Planes;
}
if (V4L2_TYPE_IS_OUTPUT(bufferType_)) {
if (V4L2_TYPE_IS_OUTPUT(buf.type)) {
buf.bytesused = buffer->bytesused_;
buf.sequence = buffer->sequence_;
buf.timestamp.tv_sec = buffer->timestamp_ / 1000000000;