PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipa: vimc: Rename processControls() to queueRequest()

Browse Source 
Synchronise with other IPA interfaces (for e.g. IPU3, RkISP1)
that uses queueRequest() to pass in the request controls to
IPA.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Umang Jain
2022-03-31 22:23:19 +05:30
parent 08d7e66df0
commit 28a44e80f0
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/libcamera/ipa/vimc.mojom
View File

@@ -37,7 +37,7 @@ interface IPAVimcInterface {
* handle parameters at runtime.
*/
[async] fillParams(uint32 frame, uint32 bufferId);
[async] processControls(uint32 frame, libcamera.ControlList controls);
[async] queueRequest(uint32 frame, libcamera.ControlList controls);
};
interface IPAVimcEventInterface {

6
src/ipa/vimc/vimc.cpp
View File

@@ -44,7 +44,7 @@ public:
void unmapBuffers(const std::vector<unsigned int> &ids) override;
void fillParams(uint32_t frame, uint32_t bufferId) override;
void processControls(uint32_t frame, const ControlList &controls) override;
void queueRequest(uint32_t frame, const ControlList &controls) override;
private:
void initTrace();
@@ -140,8 +140,8 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
paramsFilled.emit(bufferId);
}
void IPAVimc::processControls([[maybe_unused]] uint32_t frame,
[[maybe_unused]] const ControlList &controls)
void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
[[maybe_unused]] const ControlList &controls)
{
}

2
src/libcamera/pipeline/vimc/vimc.cpp
View File

@@ -432,7 +432,7 @@ int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)
if (ret < 0)
return ret;
data->ipa_->processControls(request->sequence(), request->controls());
data->ipa_->queueRequest(request->sequence(), request->controls());
return 0;
}