PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cam: fix return type of configureStreams()

Browse Source 
The only caller of configureStreams() stores its return value as an int
and not bool. This is confusing and also prevents the (possibly)
different error codes returned by Camera::configureStreams() to be
propagated inside the cam tool. Fix this by changing the return type to
int and propagate the return value from the camera.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2019-02-21 00:13:02 +01:00
parent 0cd7602e9c
commit 2090f8fdd8
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/cam/main.cpp
View File

@@ -78,7 +78,7 @@ static int parseOptions(int argc, char *argv[])
return 0;
}
static bool configureStreams(Camera *camera, std::vector<Stream *> &streams)
static int configureStreams(Camera *camera, std::vector<Stream *> &streams)
{
KeyValueParser::Options format = options[OptFormat];
Stream *id = streams.front();
@@ -98,10 +98,7 @@ static bool configureStreams(Camera *camera, std::vector<Stream *> &streams)
config[id].pixelFormat = format["pixelformat"];
}
if (camera->configureStreams(config))
return false;
return true;
return camera->configureStreams(config);
}
static void requestComplete(Request *request, const std::map<Stream *, Buffer *> &buffers)