PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: camera: Use Request::ReuseBuffers flag

Browse Source 
Pass Request::ReuseBuffers flag to request->reuse()
where the same buffers are added to the request, as the flag
exists precisely for such use cases.

This commit also drops invalid comments about creating new requests,
since requests were already being reused for `buffer_import`
and `capture` tests since commit c753223ad6
("libcamera, android, cam, gstreamer, qcam, v4l2: Reuse Request").

Signed-off-by: Umang Jain <uajain@igalia.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Umang Jain
2025-08-07 19:27:26 +05:30
committed by Kieran Bingham
parent 16cbc826b7
commit 17ae86986e
3 changed files with 3 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/camera/buffer_import.cpp
View File

@@ -52,16 +52,9 @@ protected:
if (request->status() != Request::RequestComplete)
return;
const Request::BufferMap &buffers = request->buffers();
completeRequestsCount_++;
/* Create a new request. */
const Stream *stream = buffers.begin()->first;
FrameBuffer *buffer = buffers.begin()->second;
request->reuse();
request->addBuffer(stream, buffer);
request->reuse(Request::ReuseBuffers);
camera_->queueRequest(request);
dispatcher_->interrupt();

8
test/camera/camera_reconfigure.cpp
View File

@@ -46,14 +46,8 @@ private:
if (request->status() != Request::RequestComplete)
return;
const Request::BufferMap &buffers = request->buffers();
const Stream *stream = buffers.begin()->first;
FrameBuffer *buffer = buffers.begin()->second;
/* Reuse the request and re-queue it with the same buffers. */
request->reuse();
request->addBuffer(stream, buffer);
request->reuse(Request::ReuseBuffers);
camera_->queueRequest(request);
}

9
test/camera/capture.cpp
View File

@@ -48,16 +48,9 @@ protected:
if (request->status() != Request::RequestComplete)
return;
const Request::BufferMap &buffers = request->buffers();
completeRequestsCount_++;
/* Create a new request. */
const Stream *stream = buffers.begin()->first;
FrameBuffer *buffer = buffers.begin()->second;
request->reuse();
request->addBuffer(stream, buffer);
request->reuse(Request::ReuseBuffers);
camera_->queueRequest(request);
dispatcher_->interrupt();