Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
79b95d83fe | ||
|
|
c787e9a932 | ||
|
|
e8cb7f5b6c | ||
|
|
2a677c2453 | ||
|
|
9af44e67e6 | ||
|
|
0fb56ae592 | ||
|
|
880346893d | ||
|
|
0287d87391 | ||
|
|
f9ced0c819 | ||
|
|
50bf1e7137 | ||
|
|
8a021bb680 | ||
|
|
a8aed07597 | ||
|
|
6b30b1b2ba | ||
|
|
a23dc6d722 | ||
|
|
69724a461a | ||
|
|
1003da6c2e | ||
|
|
16109ace42 | ||
|
|
1468382f54 | ||
|
|
bf5b69343e | ||
|
|
63e4fcb119 | ||
|
|
271900671d | ||
|
|
a5159d2fd6 | ||
|
|
a48bb52d21 | ||
|
|
15d48b0614 | ||
|
|
c77fa98a16 | ||
|
|
6465669461 | ||
|
|
130b90c921 | ||
|
|
d1379887a6 | ||
|
|
bfd5fc63c2 | ||
|
|
416bb7c5cb | ||
|
|
32de090df4 | ||
|
|
31d4039f39 | ||
|
|
bc395b8bd9 | ||
|
|
41270b79c6 | ||
|
|
813bec3069 | ||
|
|
21fe58812e | ||
|
|
0cb2f33e3f | ||
|
|
d11d70028c | ||
|
|
b224fa6ab9 | ||
|
|
3d1185d594 | ||
|
|
ead22ceee7 | ||
|
|
d133d52d09 | ||
|
|
cdeda1d632 | ||
|
|
a1e722dbef | ||
|
|
8627614ac9 | ||
|
|
080634431f | ||
|
|
9b33511160 | ||
|
|
27d49f75f1 | ||
|
|
d0a7c9c0ae | ||
|
|
b947bec617 | ||
|
|
d24356fc41 | ||
|
|
50795297ae | ||
|
|
65d7b3483c | ||
|
|
c946bfccc2 | ||
|
|
90984b5000 | ||
|
|
8a4569c014 | ||
|
|
f964e2a760 | ||
|
|
3f39c33bc6 | ||
|
|
e30dd7c2d3 | ||
|
|
d19a6c6baf | ||
|
|
31e9cdbb46 | ||
|
|
1a191f7b3c | ||
|
|
a033b60f93 | ||
|
|
ad6c3e036a | ||
|
|
3171668658 | ||
|
|
5342ca5f64 | ||
|
|
da3acb5cc8 | ||
|
|
e14f3a6f11 | ||
|
|
b3c9bb99fa | ||
|
|
6ce74650ec | ||
|
|
153a54c07a | ||
|
|
7c97ec46c1 | ||
|
|
4a33091d47 | ||
|
|
ce00a93d11 | ||
|
|
52603e586c | ||
|
|
24808414a1 | ||
|
|
5ea94e4447 | ||
|
|
de48f82078 | ||
|
|
c8a1047c2a | ||
|
|
08596afae6 | ||
|
|
4e03cf9178 | ||
|
|
7ed59bd9d3 | ||
|
|
26bac9f92d | ||
|
|
2d042e369b | ||
|
|
876b263515 | ||
|
|
0b42946b0d | ||
|
|
00a870cadd | ||
|
|
eab93d000f | ||
|
|
0ae84a9ecb | ||
|
|
96b45f3e73 | ||
|
|
87ea617804 | ||
|
|
f2ac66e078 | ||
|
|
ebac364ef7 | ||
|
|
321e30c69e | ||
|
|
edd31a7ef7 | ||
|
|
be9bf4c7aa |
@@ -93,6 +93,7 @@ body:
|
||||
multiple: false
|
||||
description: What version of Android are you running?
|
||||
options:
|
||||
- Android 16
|
||||
- Android 15
|
||||
- Android 14
|
||||
- Android 13
|
||||
|
||||
@@ -148,6 +148,36 @@ jobs:
|
||||
fi
|
||||
fi
|
||||
|
||||
- name: Create issue ${{ env.VERSION }}
|
||||
if: "${{ env.NEW_VERSION != '' }}"
|
||||
shell: bash
|
||||
run: |
|
||||
GH=../../gh_2.18.1_linux_amd64/bin/gh
|
||||
wget https://github.com/cli/cli/releases/download/v2.18.1/gh_2.18.1_linux_amd64.tar.gz
|
||||
tar xfz gh_2.18.1_linux_amd64.tar.gz
|
||||
|
||||
cd cromite/tools
|
||||
echo ${{ secrets.GITHUB_TOKEN }} | $GH auth login --with-token
|
||||
|
||||
echo Custom Release $CHR_VERSION >body.txt
|
||||
|
||||
if [[ "$LATEST_WIN" == "$CHR_VERSION" ]]; then
|
||||
echo Using Windows Release >body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
curl -s 'https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Windows&num=10&offset=0' | \
|
||||
jq --arg LATEST "$LATEST_WIN" '.[] | select( .version == $LATEST )' >>body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
fi
|
||||
|
||||
if [[ "$LATEST_ANDROID" == "$CHR_VERSION" ]]; then
|
||||
echo Using Android Release >body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
curl -s 'https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Android&num=10&offset=0' | \
|
||||
jq --arg LATEST "$LATEST_ANDROID" '.[] | select( .version == $LATEST )' >>body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
fi
|
||||
$GH issue create -t "$CHR_VERSION: new chromium version" -F body.txt
|
||||
|
||||
- name: Update files under control
|
||||
shell: bash
|
||||
run: |
|
||||
@@ -196,34 +226,4 @@ jobs:
|
||||
title: '[AUTO][FILECONTROL] - version ${{ env.NEW_VERSION }}'
|
||||
body: ${{ env.MESSAGE }}
|
||||
delete-branch: true
|
||||
branch-suffix: short-commit-hash
|
||||
|
||||
- name: Create issue ${{ env.VERSION }}
|
||||
if: "${{ env.NEW_VERSION != '' }}"
|
||||
shell: bash
|
||||
run: |
|
||||
GH=../../gh_2.18.1_linux_amd64/bin/gh
|
||||
wget https://github.com/cli/cli/releases/download/v2.18.1/gh_2.18.1_linux_amd64.tar.gz
|
||||
tar xfz gh_2.18.1_linux_amd64.tar.gz
|
||||
|
||||
cd cromite/tools
|
||||
echo ${{ secrets.GITHUB_TOKEN }} | $GH auth login --with-token
|
||||
|
||||
echo Custom Release $CHR_VERSION >body.txt
|
||||
|
||||
if [[ "$LATEST_WIN" == "$CHR_VERSION" ]]; then
|
||||
echo Using Windows Release >body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
curl -s 'https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Windows&num=10&offset=0' | \
|
||||
jq --arg LATEST "$LATEST_WIN" '.[] | select( .version == $LATEST )' >>body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
fi
|
||||
|
||||
if [[ "$LATEST_ANDROID" == "$CHR_VERSION" ]]; then
|
||||
echo Using Android Release >body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
curl -s 'https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Android&num=10&offset=0' | \
|
||||
jq --arg LATEST "$LATEST_ANDROID" '.[] | select( .version == $LATEST )' >>body.txt
|
||||
echo "\`\`\`" >>body.txt
|
||||
fi
|
||||
$GH issue create -t "$CHR_VERSION: new chromium version" -F body.txt
|
||||
branch-suffix: short-commit-hash
|
||||
@@ -134,7 +134,6 @@ jobs:
|
||||
cp "/win_sdk/sdks/Win11SDK_10.0.26100.0/Windows Kits/10/Redist/D3D/x64/d3dcompiler_47.dll" chrome-win/
|
||||
cp $OUTPUTFILE_WIN/elevation_service.exe chrome-win/
|
||||
cp "$OUTPUTFILE_WIN/First Run" chrome-win/
|
||||
cp $OUTPUTFILE_WIN/headless_lib_data.pak chrome-win/
|
||||
cp $OUTPUTFILE_WIN/icudtl.dat chrome-win/
|
||||
cp $OUTPUTFILE_WIN/libEGL.dll chrome-win/
|
||||
cp $OUTPUTFILE_WIN/libGLESv2.dll chrome-win/
|
||||
@@ -156,6 +155,10 @@ jobs:
|
||||
$GH release upload $VERSION-$CROMITE_SHA chrome-win.zip
|
||||
echo "::endgroup::"
|
||||
|
||||
TIMESTAMP=$(date +%s -r chrome-win.zip)
|
||||
echo >updateurl.txt "browser=chromium;os=windows;architecture=64-bit;timestamp=$TIMESTAMP;editor=uazo;channel=stable;repository=https://github.com/uazo/cromite/releases;download=https://github.com/uazo/cromite/releases/latest/download/chrome-win.zip;version=$(cat $OUTPUTFILE_WIN/RELEASE);revision=1;commit=$CROMITE_SHA"
|
||||
$GH release upload $VERSION-$CROMITE_SHA updateurl.txt
|
||||
|
||||
## linux
|
||||
echo "::group::-------- linux x64"
|
||||
mkdir chrome-lin/
|
||||
@@ -206,10 +209,6 @@ jobs:
|
||||
$GH release upload $VERSION-$CROMITE_SHA arm64_SystemWebViewShell.apk
|
||||
echo "::endgroup::"
|
||||
|
||||
TIMESTAMP=$(date +%s -r chrome-win.zip)
|
||||
echo >updateurl.txt "browser=chromium;os=windows;architecture=64-bit;timestamp=$TIMESTAMP;editor=uazo;channel=stable;repository=https://github.com/uazo/cromite/releases;download=https://github.com/uazo/cromite/releases/latest/download/chrome-win.zip;version=$(cat $OUTPUTFILE_WIN/RELEASE);revision=1;commit=$CROMITE_SHA"
|
||||
$GH release upload $VERSION-$CROMITE_SHA updateurl.txt
|
||||
|
||||
$GH release edit $VERSION-$CROMITE_SHA -t $VERSION-$CROMITE_SHA
|
||||
|
||||
if [ $IS_DRAFT == "false" ]; then
|
||||
|
||||
+1
-1
@@ -1 +1 @@
|
||||
144.0.7559.97
|
||||
147.0.7727.102
|
||||
@@ -23,7 +23,6 @@ use_debug_fission=true
|
||||
use_errorprone_java_compiler=false
|
||||
use_official_google_api_keys=false
|
||||
use_rtti=false
|
||||
webview_includes_weblayer=false
|
||||
enable_arcore=false
|
||||
enable_openxr=false
|
||||
enable_cardboard=false
|
||||
@@ -82,9 +81,6 @@ enable_request_header_integrity = false
|
||||
# Disable precompiled headers because they are incompatible with the unsafe_buffers configuration
|
||||
enable_precompiled_headers = false
|
||||
|
||||
# Disable integration with Gemini
|
||||
enable_glic = false
|
||||
|
||||
# Disable TFLite with XNNPACK
|
||||
build_tflite_with_xnnpack = false
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
Do-not-link-with-libatomic.patch
|
||||
Force-use-vpython3-for-all-scripts.patch
|
||||
bromite-build-utils.patch
|
||||
Add-cromite-flags-support.patch
|
||||
Force-use-vpython3-for-some-scripts.patch
|
||||
Permit-PGO-for-debug-builds.patch
|
||||
Fix-chromium-vanilla.patch
|
||||
Final-patch-for-chromium-vanilla.patch
|
||||
@@ -154,7 +154,6 @@ Invalidate-components-public-key.patch
|
||||
Improve-plain-text-rendering-on-mobile.patch
|
||||
Remove-segmentation-platform.patch
|
||||
Remove-window-name-on-cross-origin-navigation.patch
|
||||
Remove-preload-of-com.google.android.gms.fonts.patch
|
||||
Partition-Blink-memory-cache.patch
|
||||
Remove-navigator.connection-info.patch
|
||||
Disable-PrivacyGuide.patch
|
||||
@@ -166,7 +165,6 @@ Remove-HTTP-referrals-in-cross-origin-navigation.patch
|
||||
Enable-third-party-storage-partitioning.patch
|
||||
Restore-adaptive-button-in-top-toolbar-customization.patch
|
||||
Add-kill-switch-for-unsupported-clangd-flags.patch
|
||||
|
||||
WIN-enable-pdf-plugin.patch
|
||||
WIN-disable-annotate-downloads.patch
|
||||
Enable-HighEfficiencyMode-by-default.patch
|
||||
@@ -176,7 +174,6 @@ WIN-Disable-updater.patch
|
||||
WIN-Disable-first-run.patch
|
||||
WIN-Add-some-prefs-to-secure-preferences.patch
|
||||
WIN-Disable-search-for-image.patch
|
||||
|
||||
AudioBuffer-AnalyserNode-fp-mitigations.patch
|
||||
add-browser-policy.patch
|
||||
Always-open-browser-controls-in-new-tab.patch
|
||||
@@ -247,7 +244,7 @@ Always-allow-inspect-fallback.patch
|
||||
Add-PartialLowEndModeOnMidRangeDevices-flag.patch
|
||||
Use-list-mode-for-tab-switcher.patch
|
||||
Chrome-web-store-protection.patch
|
||||
Enable-search-engine-settings-desktop-ui.patch
|
||||
Enables-keyword-based-site-search-on-Android-devices.patch
|
||||
Disable-Android-AppRestrictions.patch
|
||||
Customize-selection-popup.patch
|
||||
Enables-deactivation-of-the-js-debugger-statement.patch
|
||||
@@ -319,7 +316,7 @@ Block-leakage-of-urls-in-sandbox-iframes.patch
|
||||
Fix-chromium-build-bugs.patch
|
||||
Try-to-fix-2082.patch
|
||||
Temp-use-PREVIEW-for-IDCompositionDevice5.patch
|
||||
Temp-Backport-Fix-CtrlW-to-close-current-tab.patch
|
||||
Disable-integration-with-Gemini.patch
|
||||
|
||||
# adblock patches
|
||||
eyeo-133.0.6943.49-base.patch
|
||||
|
||||
@@ -28,7 +28,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
import org.chromium.printing.PrintManagerDelegateImpl;
|
||||
import org.chromium.printing.PrintingController;
|
||||
import org.chromium.printing.PrintingControllerImpl;
|
||||
@@ -1096,6 +1097,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
@@ -1134,6 +1135,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
super.onStartWithNative();
|
||||
|
||||
ChromeActivitySessionTracker.getInstance().onStartWithNative(getProfileProviderSupplier());
|
||||
@@ -40,10 +40,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
@@ -196,6 +196,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
@@ -204,6 +204,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&feed::kFeedNoViewCache,
|
||||
&feed::kFeedPerformanceStudy,
|
||||
&feed::kFeedRecyclerBinderUnmountOnDetach,
|
||||
&feed::kFeedShowSignInCommand,
|
||||
+ &kAllowUserCertificates,
|
||||
&feed::kFeedSignedOutViewDemotion,
|
||||
&feed::kInterestFeedV2,
|
||||
@@ -51,15 +51,15 @@ diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browse
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
@@ -166,6 +166,7 @@ public abstract class ChromeFeatureList {
|
||||
@@ -167,6 +167,7 @@ public abstract class ChromeFeatureList {
|
||||
"AccountForSuppressedKeyboardInsets";
|
||||
public static final String ADAPTIVE_BUTTON_IN_TOP_TOOLBAR_CUSTOMIZATION_V2 =
|
||||
"AdaptiveButtonInTopToolbarCustomizationV2";
|
||||
+ public static final String ALLOW_USER_CERTIFICATES = "AllowUserCertificates";
|
||||
public static final String ADAPTIVE_BUTTON_IN_TOP_TOOLBAR_PAGE_SUMMARY =
|
||||
"AdaptiveButtonInTopToolbarPageSummary";
|
||||
public static final String ANDROID_ANIMATED_PROGRESS_BAR_IN_BROWSER =
|
||||
@@ -820,6 +821,8 @@ public abstract class ChromeFeatureList {
|
||||
// Don't clean up this flag yet, BCIV is launched, so this needs to be enabled by
|
||||
@@ -803,6 +804,8 @@ public abstract class ChromeFeatureList {
|
||||
public static final CachedFlag sAndroidWindowPopupResizeAfterSpawn =
|
||||
newCachedFlag(ANDROID_WINDOW_POPUP_RESIZE_AFTER_SPAWN, false, true);
|
||||
public static final CachedFlag sAppSpecificHistory = newCachedFlag(APP_SPECIFIC_HISTORY, true);
|
||||
@@ -68,10 +68,10 @@ diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/f
|
||||
public static final CachedFlag sAppSpecificHistoryViewIntent =
|
||||
newCachedFlag(APP_SPECIFIC_HISTORY_VIEW_INTENT, true);
|
||||
public static final CachedFlag sAsyncNotificationManager =
|
||||
@@ -1136,6 +1139,7 @@ public abstract class ChromeFeatureList {
|
||||
@@ -1156,6 +1159,7 @@ public abstract class ChromeFeatureList {
|
||||
sAccountForSuppressedKeyboardInsets,
|
||||
sAndroidAnimatedProgressBarInBrowser,
|
||||
sAndroidAnimatedProgressBarInViz,
|
||||
sAndroidApb144Patch1,
|
||||
+ sAllowUserCertificates,
|
||||
sAndroidAppIntegrationModule,
|
||||
sAndroidAppIntegrationMultiDataSource,
|
||||
@@ -111,8 +111,8 @@ new file mode 100644
|
||||
diff --git a/net/android/java/src/org/chromium/net/X509Util.java b/net/android/java/src/org/chromium/net/X509Util.java
|
||||
--- a/net/android/java/src/org/chromium/net/X509Util.java
|
||||
+++ b/net/android/java/src/org/chromium/net/X509Util.java
|
||||
@@ -537,6 +537,8 @@ public class X509Util {
|
||||
return userRootBytes.toArray(new byte[0][]);
|
||||
@@ -472,6 +472,8 @@ public class X509Util {
|
||||
return result;
|
||||
}
|
||||
|
||||
+ public static boolean AllowUserCertificates = false;
|
||||
@@ -120,7 +120,7 @@ diff --git a/net/android/java/src/org/chromium/net/X509Util.java b/net/android/j
|
||||
public static AndroidCertVerifyResult verifyServerCertificates(
|
||||
byte[][] certChain,
|
||||
String authType,
|
||||
@@ -639,6 +641,9 @@ public class X509Util {
|
||||
@@ -649,6 +651,9 @@ public class X509Util {
|
||||
X509Certificate root = verifiedChain.get(verifiedChain.size() - 1);
|
||||
isIssuedByKnownRoot = isKnownRoot(root);
|
||||
}
|
||||
|
||||
@@ -10,7 +10,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
|
||||
@@ -904,6 +904,12 @@ public class KeyboardShortcuts {
|
||||
@@ -935,6 +935,12 @@ public class KeyboardShortcuts {
|
||||
KeyEvent.KEYCODE_ESCAPE,
|
||||
KeyEvent.META_CTRL_ON);
|
||||
}
|
||||
|
||||
@@ -44,7 +44,7 @@ new file mode 100644
|
||||
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
|
||||
--- a/net/url_request/url_request_http_job.cc
|
||||
+++ b/net/url_request/url_request_http_job.cc
|
||||
@@ -400,6 +400,11 @@ std::unique_ptr<URLRequestJob> URLRequestHttpJob::Create(URLRequest* request) {
|
||||
@@ -403,6 +403,11 @@ std::unique_ptr<URLRequestJob> URLRequestHttpJob::Create(URLRequest* request) {
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -15,7 +15,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/base/features.cc b/base/features.cc
|
||||
--- a/base/features.cc
|
||||
+++ b/base/features.cc
|
||||
@@ -200,6 +200,10 @@ bool IsReducePPMsEnabled() {
|
||||
@@ -198,6 +198,10 @@ bool IsReducePPMsEnabled() {
|
||||
return g_is_reduce_ppms_enabled.load(std::memory_order_relaxed);
|
||||
}
|
||||
|
||||
|
||||
@@ -5,34 +5,18 @@ Subject: Add a flag to disable GamePad API
|
||||
Adds restrict-gamepad-access flag (default active) to disable GamePad API.
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
chrome/browser/flag-metadata.json | 4 ++--
|
||||
content/child/runtime_features.cc | 2 ++
|
||||
.../about_flags_cc/Add-a-flag-to-disable-GamePad-API.inc | 7 +++++++
|
||||
device/gamepad/public/cpp/gamepad_features.cc | 8 ++++++++
|
||||
device/gamepad/public/cpp/gamepad_features.h | 2 ++
|
||||
.../blink/renderer/modules/gamepad/navigator_gamepad.cc | 6 ++++++
|
||||
6 files changed, 27 insertions(+), 2 deletions(-)
|
||||
5 files changed, 25 insertions(+)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Add-a-flag-to-disable-GamePad-API.inc
|
||||
|
||||
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
|
||||
--- a/chrome/browser/flag-metadata.json
|
||||
+++ b/chrome/browser/flag-metadata.json
|
||||
@@ -9195,9 +9195,9 @@
|
||||
"expiry_milestone": 150
|
||||
},
|
||||
{
|
||||
- "name": "restrict-gamepad-access",
|
||||
+ "name": "restrict-gamepad-access", // restrict-gamepad-access"
|
||||
"owners": [ "//device/gamepad/OWNERS", "jameshollyer@chromium.org" ],
|
||||
- "expiry_milestone": 96
|
||||
+ "expiry_milestone": -1
|
||||
},
|
||||
{
|
||||
"name": "rewriter-api-for-gemini-nano",
|
||||
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
|
||||
--- a/content/child/runtime_features.cc
|
||||
+++ b/content/child/runtime_features.cc
|
||||
@@ -262,6 +262,8 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
|
||||
@@ -241,6 +241,8 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
|
||||
{wf::EnablePaymentApp, raw_ref(features::kServiceWorkerPaymentApps)},
|
||||
{wf::EnablePeriodicBackgroundSync,
|
||||
raw_ref(features::kPeriodicBackgroundSync)},
|
||||
@@ -56,7 +40,7 @@ new file mode 100644
|
||||
diff --git a/device/gamepad/public/cpp/gamepad_features.cc b/device/gamepad/public/cpp/gamepad_features.cc
|
||||
--- a/device/gamepad/public/cpp/gamepad_features.cc
|
||||
+++ b/device/gamepad/public/cpp/gamepad_features.cc
|
||||
@@ -53,4 +53,12 @@ bool IsGamepadMultitouchEnabled() {
|
||||
@@ -63,4 +63,12 @@ bool IsGamepadMultitouchEnabled() {
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -80,8 +64,8 @@ diff --git a/device/gamepad/public/cpp/gamepad_features.h b/device/gamepad/publi
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
GAMEPAD_FEATURES_EXPORT BASE_DECLARE_FEATURE(kIgnorePS5GamepadsInWgi);
|
||||
@@ -27,6 +28,7 @@ GAMEPAD_FEATURES_EXPORT BASE_DECLARE_FEATURE(kAllowlistHidrawGamepads);
|
||||
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||
@@ -34,6 +35,7 @@ GAMEPAD_FEATURES_EXPORT BASE_DECLARE_FEATURE(
|
||||
#endif // BUILDFLAG(IS_APPLE)
|
||||
|
||||
GAMEPAD_FEATURES_EXPORT bool IsGamepadMultitouchEnabled();
|
||||
+GAMEPAD_FEATURES_EXPORT bool IsRestrictGamepadAccessEnabled();
|
||||
@@ -99,7 +83,7 @@ diff --git a/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc b/t
|
||||
#include "third_party/blink/public/mojom/frame/user_activation_notification_type.mojom-blink.h"
|
||||
#include "third_party/blink/public/platform/task_type.h"
|
||||
#include "third_party/blink/renderer/bindings/modules/v8/v8_gamepad_mapping_type.h"
|
||||
@@ -86,6 +87,9 @@ NavigatorGamepad& NavigatorGamepad::From(Navigator& navigator) {
|
||||
@@ -88,6 +89,9 @@ NavigatorGamepad& NavigatorGamepad::From(Navigator& navigator) {
|
||||
HeapVector<Member<Gamepad>> NavigatorGamepad::getGamepads(
|
||||
Navigator& navigator,
|
||||
ExceptionState& exception_state) {
|
||||
@@ -109,7 +93,7 @@ diff --git a/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc b/t
|
||||
if (!navigator.DomWindow()) {
|
||||
// Using an existing NavigatorGamepad if one exists, but don't create one
|
||||
// for a detached window, as its subclasses depend on a non-null window.
|
||||
@@ -428,6 +432,8 @@ void NavigatorGamepad::MaybeDispatchGamepadEvents(
|
||||
@@ -433,6 +437,8 @@ void NavigatorGamepad::MaybeDispatchGamepadEvents(
|
||||
void NavigatorGamepad::DispatchGamepadConnectionChangedEvent(
|
||||
const AtomicString& event_name,
|
||||
Gamepad* gamepad) {
|
||||
|
||||
@@ -33,7 +33,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../browser/ui/webui/chrome_web_ui_configs.cc | 5 +-
|
||||
chrome/browser/ui/webui/proxy_config_ui.cc | 389 ++++++++++++++++++
|
||||
chrome/browser/ui/webui/proxy_config_ui.h | 41 ++
|
||||
chrome/common/webui_url_constants.cc | 2 +
|
||||
chrome/common/webui_url_constants.cc | 1 +
|
||||
chrome/common/webui_url_constants.h | 2 +
|
||||
.../pref_proxy_config_tracker_impl.cc | 5 +-
|
||||
.../proxy_config/proxy_config_dictionary.cc | 30 +-
|
||||
@@ -43,7 +43,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
net/proxy_resolution/pac_file_fetcher_impl.cc | 8 -
|
||||
net/proxy_resolution/proxy_config.cc | 53 ++-
|
||||
net/proxy_resolution/proxy_config.h | 3 +
|
||||
27 files changed, 987 insertions(+), 27 deletions(-)
|
||||
27 files changed, 986 insertions(+), 27 deletions(-)
|
||||
create mode 100644 chrome/browser/resources/proxy_config.css
|
||||
create mode 100644 chrome/browser/resources/proxy_config.html
|
||||
create mode 100644 chrome/browser/resources/proxy_config.js
|
||||
@@ -80,7 +80,7 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -102,6 +102,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -108,6 +108,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
private static final String PREF_PASSWORD_LEAK_DETECTION = "password_leak_detection";
|
||||
private static final String PREF_SYNC_AND_SERVICES_LINK = "sync_and_services_link";
|
||||
private static final String PREF_PRIVACY_SANDBOX = "privacy_sandbox";
|
||||
@@ -91,7 +91,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
diff --git a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
|
||||
--- a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
|
||||
+++ b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
|
||||
@@ -411,6 +411,7 @@ ChromeAutocompleteProviderClient::GetBuiltinsToProvideAsUserTypes() {
|
||||
@@ -424,6 +424,7 @@ ChromeAutocompleteProviderClient::GetBuiltinsToProvideAsUserTypes() {
|
||||
builtins_to_provide.push_back(chrome::kChromeUISettingsURL16);
|
||||
#endif
|
||||
builtins_to_provide.push_back(chrome::kChromeUIVersionURL16);
|
||||
@@ -102,7 +102,7 @@ diff --git a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
|
||||
diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd
|
||||
--- a/chrome/browser/browser_resources.grd
|
||||
+++ b/chrome/browser/browser_resources.grd
|
||||
@@ -239,6 +239,9 @@
|
||||
@@ -225,6 +225,9 @@
|
||||
<if expr="_google_chrome">
|
||||
<include name="IDR_PREF_HASH_SEED_BIN" file="resources\settings\internal\pref_hash_seed.bin" type="BINDATA" />
|
||||
</if>
|
||||
@@ -115,7 +115,7 @@ diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resou
|
||||
diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc b/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
|
||||
--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
|
||||
+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
|
||||
@@ -375,7 +375,7 @@ std::optional<base::Value::Dict> CreateProxyConfigDict(
|
||||
@@ -383,7 +383,7 @@ std::optional<base::DictValue> CreateProxyConfigDict(
|
||||
return std::nullopt;
|
||||
}
|
||||
return ProxyConfigDictionary::CreateFixedServers(proxy_rules_string,
|
||||
@@ -152,7 +152,7 @@ diff --git a/chrome/browser/net/proxy_service_factory.cc b/chrome/browser/net/pr
|
||||
- return std::make_unique<PrefProxyConfigTrackerImpl>(profile_prefs, nullptr);
|
||||
+ // Migrate from profile_prefs to local_state_prefs
|
||||
+ if (local_state_prefs->GetBoolean("proxy_migrated") == false) {
|
||||
+ const base::Value::Dict& dict =
|
||||
+ const base::DictValue& dict =
|
||||
+ profile_prefs->GetDict(proxy_config::prefs::kProxy);
|
||||
+
|
||||
+ LOG(INFO) << "CreatePrefProxyConfigTrackerOfProfile: Migration from profile to local state";
|
||||
@@ -208,7 +208,7 @@ diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browse
|
||||
#if BUILDFLAG(ENABLE_BACKGROUND_MODE)
|
||||
#include "chrome/browser/background/extensions/background_mode_manager.h"
|
||||
#endif
|
||||
@@ -1314,6 +1316,8 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
|
||||
@@ -1438,6 +1440,8 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
|
||||
component_updater::RegisterPrefs(registry);
|
||||
domain_reliability::RegisterPrefs(registry);
|
||||
embedder_support::OriginTrialPrefs::RegisterPrefs(registry);
|
||||
@@ -220,7 +220,7 @@ diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browse
|
||||
diff --git a/chrome/browser/prefs/chrome_command_line_pref_store.cc b/chrome/browser/prefs/chrome_command_line_pref_store.cc
|
||||
--- a/chrome/browser/prefs/chrome_command_line_pref_store.cc
|
||||
+++ b/chrome/browser/prefs/chrome_command_line_pref_store.cc
|
||||
@@ -163,7 +163,7 @@ void ChromeCommandLinePrefStore::ApplyProxyMode() {
|
||||
@@ -161,7 +161,7 @@ void ChromeCommandLinePrefStore::ApplyProxyMode() {
|
||||
command_line()->GetSwitchValueASCII(switches::kProxyBypassList);
|
||||
SetValue(proxy_config::prefs::kProxy,
|
||||
base::Value(ProxyConfigDictionary::CreateFixedServers(
|
||||
@@ -675,7 +675,7 @@ diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
|
||||
diff --git a/chrome/browser/ui/webui/chrome_web_ui_configs.cc b/chrome/browser/ui/webui/chrome_web_ui_configs.cc
|
||||
--- a/chrome/browser/ui/webui/chrome_web_ui_configs.cc
|
||||
+++ b/chrome/browser/ui/webui/chrome_web_ui_configs.cc
|
||||
@@ -59,6 +59,9 @@
|
||||
@@ -64,6 +64,9 @@
|
||||
#include "extensions/buildflags/buildflags.h"
|
||||
#include "printing/buildflags/buildflags.h"
|
||||
|
||||
@@ -685,10 +685,10 @@ diff --git a/chrome/browser/ui/webui/chrome_web_ui_configs.cc b/chrome/browser/u
|
||||
#if BUILDFLAG(ENABLE_WEBUI_CERTIFICATE_VIEWER)
|
||||
#include "chrome/browser/ui/webui/certificate_viewer/certificate_viewer_ui.h"
|
||||
#endif
|
||||
@@ -438,7 +441,7 @@ void RegisterChromeWebUIConfigs() {
|
||||
map.AddWebUIConfig(std::make_unique<glic::GlicUIConfig>());
|
||||
map.AddWebUIConfig(std::make_unique<glic::GlicFreUIConfig>());
|
||||
#endif
|
||||
@@ -449,7 +452,7 @@ void RegisterChromeWebUIConfigs() {
|
||||
map.AddWebUIConfig(std::make_unique<SigninErrorUIConfig>());
|
||||
map.AddWebUIConfig(std::make_unique<SigninEmailConfirmationUIConfig>());
|
||||
#endif // !BUILDFLAG(IS_CHROMEOS) && !BUILDFLAG(IS_ANDROID)
|
||||
-
|
||||
+ map.AddWebUIConfig(std::make_unique<ProxyConfigUIConfig>());
|
||||
#if BUILDFLAG(SAFE_BROWSING_AVAILABLE)
|
||||
@@ -774,9 +774,9 @@ new file mode 100644
|
||||
+ void RegisterMessages() override;
|
||||
+
|
||||
+ // Messages
|
||||
+ void OnEnableNotifyUIWithState(const base::Value::List& args);
|
||||
+ void OnApply(const base::Value::List& args);
|
||||
+ void OnClear(const base::Value::List& args);
|
||||
+ void OnEnableNotifyUIWithState(const base::ListValue& args);
|
||||
+ void OnApply(const base::ListValue& args);
|
||||
+ void OnClear(const base::ListValue& args);
|
||||
+
|
||||
+ // net::ProxyConfigService::Observer implementation:
|
||||
+ // Calls ProxyConfigView.onProxyConfigChanged JavaScript function in the
|
||||
@@ -793,7 +793,7 @@ new file mode 100644
|
||||
+ std::unique_ptr<PrefProxyConfigTracker> pref_proxy_config_tracker_;
|
||||
+ bool is_observing_;
|
||||
+
|
||||
+ void encodeConfig(const net::ProxyConfig& config, base::Value::Dict& state);
|
||||
+ void encodeConfig(const net::ProxyConfig& config, base::DictValue& state);
|
||||
+
|
||||
+ void apply(const net::ProxyConfig& config);
|
||||
+
|
||||
@@ -833,7 +833,7 @@ new file mode 100644
|
||||
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI) ||
|
||||
+ !BrowserThread::IsThreadInitialized(BrowserThread::UI));
|
||||
+
|
||||
+ base::Value::Dict state;
|
||||
+ base::DictValue state;
|
||||
+ bool pending = false;
|
||||
+ switch (availability) {
|
||||
+ case net::ProxyConfigService::CONFIG_VALID:
|
||||
@@ -861,7 +861,7 @@ new file mode 100644
|
||||
+ return pacString;
|
||||
+}
|
||||
+
|
||||
+void ProxyConfigMessageHandler::encodeConfig(const net::ProxyConfig& config, base::Value::Dict& state) {
|
||||
+void ProxyConfigMessageHandler::encodeConfig(const net::ProxyConfig& config, base::DictValue& state) {
|
||||
+ // when automatic settings are enabled they take precedence over manual settings
|
||||
+ // automatic settings are either the "auto-detect" flag or the existance of a PAC URL
|
||||
+
|
||||
@@ -932,7 +932,7 @@ new file mode 100644
|
||||
+// The proxy configuration UI is not notified of state changes until this function runs.
|
||||
+// After this function, OnProxyConfigChanged() will be called on all proxy state changes.
|
||||
+void ProxyConfigMessageHandler::OnEnableNotifyUIWithState(
|
||||
+ const base::Value::List& list) {
|
||||
+ const base::ListValue& list) {
|
||||
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
|
||||
+
|
||||
+ if (!is_observing_) {
|
||||
@@ -954,23 +954,23 @@ new file mode 100644
|
||||
+ OnProxyConfigChanged(config, availability);
|
||||
+}
|
||||
+
|
||||
+void ProxyConfigMessageHandler::OnClear(const base::Value::List& list) {
|
||||
+void ProxyConfigMessageHandler::OnClear(const base::ListValue& list) {
|
||||
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
|
||||
+
|
||||
+ const base::Value::Dict cfg = ProxyConfigDictionary::CreateSystem();
|
||||
+ const base::DictValue cfg = ProxyConfigDictionary::CreateSystem();
|
||||
+ pref_service_->SetDict(proxy_config::prefs::kProxy, cfg.Clone());
|
||||
+ pref_service_->CommitPendingWrite();
|
||||
+ OnEnableNotifyUIWithState(list);
|
||||
+}
|
||||
+
|
||||
+void ProxyConfigMessageHandler::OnApply(const base::Value::List& list) {
|
||||
+void ProxyConfigMessageHandler::OnApply(const base::ListValue& list) {
|
||||
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
|
||||
+
|
||||
+ if ((list.size() != 1) || !list[0].is_dict()) {
|
||||
+ return;
|
||||
+ }
|
||||
+
|
||||
+ const base::Value::Dict& config = list[0].GetDict();
|
||||
+ const base::DictValue& config = list[0].GetDict();
|
||||
+
|
||||
+ if (config.FindBool("auto_detect").value_or(false)) {
|
||||
+ apply(net::ProxyConfig::CreateAutoDetect());
|
||||
@@ -986,7 +986,7 @@ new file mode 100644
|
||||
+ return;
|
||||
+ }
|
||||
+
|
||||
+ const base::Value::Dict* rules = config.FindDict("rules");
|
||||
+ const base::DictValue* rules = config.FindDict("rules");
|
||||
+ if (rules == nullptr)
|
||||
+ return;
|
||||
+
|
||||
@@ -1023,7 +1023,7 @@ new file mode 100644
|
||||
+ } else if (*type == "direct") {
|
||||
+ proxyConfig.proxy_rules().type = net::ProxyConfig::ProxyRules::Type::EMPTY;
|
||||
+ } else if (*type == "none") {
|
||||
+ base::Value::List empty;
|
||||
+ base::ListValue empty;
|
||||
+ OnClear(empty);
|
||||
+ return;
|
||||
+ } else {
|
||||
@@ -1049,26 +1049,26 @@ new file mode 100644
|
||||
+
|
||||
+void ProxyConfigMessageHandler::apply(const net::ProxyConfig& proxyConfig) {
|
||||
+ if (proxyConfig.auto_detect()) {
|
||||
+ const base::Value::Dict cfg = ProxyConfigDictionary::CreateAutoDetect();
|
||||
+ const base::DictValue cfg = ProxyConfigDictionary::CreateAutoDetect();
|
||||
+ pref_service_->SetDict(proxy_config::prefs::kProxy, cfg.Clone());
|
||||
+ } else if (proxyConfig.has_pac_url()) {
|
||||
+ const base::Value::Dict cfg = ProxyConfigDictionary::CreatePacScript(proxyConfig.pac_url().spec(), proxyConfig.pac_mandatory());
|
||||
+ const base::DictValue cfg = ProxyConfigDictionary::CreatePacScript(proxyConfig.pac_url().spec(), proxyConfig.pac_mandatory());
|
||||
+ pref_service_->SetDict(proxy_config::prefs::kProxy, cfg.Clone());
|
||||
+ } else if (proxyConfig.proxy_rules().type == net::ProxyConfig::ProxyRules::Type::EMPTY) {
|
||||
+ const base::Value::Dict cfg = ProxyConfigDictionary::CreateDirect();
|
||||
+ const base::DictValue cfg = ProxyConfigDictionary::CreateDirect();
|
||||
+ pref_service_->SetDict(proxy_config::prefs::kProxy, cfg.Clone());
|
||||
+ } else {
|
||||
+ auto proxyRulesAsString = proxyConfig.proxy_rules().ToString();
|
||||
+ auto bypassRulesAsString = proxyConfig.proxy_rules().bypass_rules.ToString();
|
||||
+
|
||||
+ // fixed servers
|
||||
+ const base::Value::Dict cfg = ProxyConfigDictionary::CreateFixedServers(proxyRulesAsString,
|
||||
+ const base::DictValue cfg = ProxyConfigDictionary::CreateFixedServers(proxyRulesAsString,
|
||||
+ bypassRulesAsString, proxyConfig.proxy_rules().reverse_bypass);
|
||||
+ pref_service_->SetDict(proxy_config::prefs::kProxy, cfg.Clone());
|
||||
+ }
|
||||
+ pref_service_->CommitPendingWrite();
|
||||
+
|
||||
+ base::Value::List empty;
|
||||
+ base::ListValue empty;
|
||||
+ OnEnableNotifyUIWithState(empty);
|
||||
+}
|
||||
+
|
||||
@@ -1137,15 +1137,7 @@ new file mode 100644
|
||||
diff --git a/chrome/common/webui_url_constants.cc b/chrome/common/webui_url_constants.cc
|
||||
--- a/chrome/common/webui_url_constants.cc
|
||||
+++ b/chrome/common/webui_url_constants.cc
|
||||
@@ -53,6 +53,7 @@ bool IsSystemWebUIHost(std::string_view host) {
|
||||
kChromeUILockScreenNetworkHost,
|
||||
kChromeUILockScreenStartReauthHost,
|
||||
kChromeUIMobileSetupHost,
|
||||
+ kChromeUIProxyConfigHost,
|
||||
kChromeUIMultiDeviceSetupHost,
|
||||
kChromeUINetworkHost,
|
||||
kChromeUINotificationTesterHost,
|
||||
@@ -74,6 +75,7 @@ bool IsSystemWebUIHost(std::string_view host) {
|
||||
@@ -120,6 +120,7 @@ bool IsSystemWebUIHost(std::string_view host) {
|
||||
// These hosts will also be suggested by BuiltinProvider.
|
||||
base::span<const base::cstring_view> ChromeURLHosts() {
|
||||
static constexpr auto kChromeURLHosts = std::to_array<base::cstring_view>({
|
||||
@@ -1156,7 +1148,7 @@ diff --git a/chrome/common/webui_url_constants.cc b/chrome/common/webui_url_cons
|
||||
diff --git a/chrome/common/webui_url_constants.h b/chrome/common/webui_url_constants.h
|
||||
--- a/chrome/common/webui_url_constants.h
|
||||
+++ b/chrome/common/webui_url_constants.h
|
||||
@@ -197,6 +197,8 @@ inline constexpr char kChromeUINetInternalsHost[] = "net-internals";
|
||||
@@ -206,6 +206,8 @@ inline constexpr char kChromeUINetInternalsHost[] = "net-internals";
|
||||
inline constexpr char kChromeUINetInternalsURL[] = "chrome://net-internals/";
|
||||
inline constexpr char kChromeUINewTabHost[] = "newtab";
|
||||
inline constexpr char kChromeUINewTabFooterHost[] = "newtab-footer";
|
||||
@@ -1168,7 +1160,7 @@ diff --git a/chrome/common/webui_url_constants.h b/chrome/common/webui_url_const
|
||||
diff --git a/components/proxy_config/pref_proxy_config_tracker_impl.cc b/components/proxy_config/pref_proxy_config_tracker_impl.cc
|
||||
--- a/components/proxy_config/pref_proxy_config_tracker_impl.cc
|
||||
+++ b/components/proxy_config/pref_proxy_config_tracker_impl.cc
|
||||
@@ -550,7 +550,7 @@ PrefProxyConfigTrackerImpl::GetEffectiveProxyConfig(
|
||||
@@ -525,7 +525,7 @@ PrefProxyConfigTrackerImpl::GetEffectiveProxyConfig(
|
||||
// static
|
||||
void PrefProxyConfigTrackerImpl::RegisterPrefs(PrefRegistrySimple* registry) {
|
||||
registry->RegisterDictionaryPref(proxy_config::prefs::kProxy,
|
||||
@@ -1177,7 +1169,7 @@ diff --git a/components/proxy_config/pref_proxy_config_tracker_impl.cc b/compone
|
||||
registry->RegisterListPref(proxy_config::prefs::kProxyOverrideRules);
|
||||
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN)
|
||||
registry->RegisterIntegerPref(
|
||||
@@ -562,7 +562,7 @@ void PrefProxyConfigTrackerImpl::RegisterPrefs(PrefRegistrySimple* registry) {
|
||||
@@ -541,7 +541,7 @@ void PrefProxyConfigTrackerImpl::RegisterPrefs(PrefRegistrySimple* registry) {
|
||||
void PrefProxyConfigTrackerImpl::RegisterProfilePrefs(
|
||||
PrefRegistrySimple* registry) {
|
||||
registry->RegisterDictionaryPref(proxy_config::prefs::kProxy,
|
||||
@@ -1185,8 +1177,8 @@ diff --git a/components/proxy_config/pref_proxy_config_tracker_impl.cc b/compone
|
||||
+ ProxyConfigDictionary::CreateDirect());
|
||||
registry->RegisterBooleanPref(proxy_config::prefs::kUseSharedProxies, false);
|
||||
registry->RegisterListPref(proxy_config::prefs::kProxyOverrideRules);
|
||||
#if !BUILDFLAG(IS_CHROMEOS)
|
||||
@@ -716,6 +716,7 @@ bool PrefProxyConfigTrackerImpl::PrefConfigToNetConfig(
|
||||
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN)
|
||||
@@ -705,6 +705,7 @@ bool PrefProxyConfigTrackerImpl::PrefConfigToNetConfig(
|
||||
if (proxy_dict.GetBypassList(&proxy_bypass)) {
|
||||
proxy_config.proxy_rules().bypass_rules.ParseFromString(proxy_bypass);
|
||||
}
|
||||
@@ -1218,26 +1210,26 @@ diff --git a/components/proxy_config/proxy_config_dictionary.cc b/components/pro
|
||||
+ return value->GetBool();
|
||||
+}
|
||||
+
|
||||
const base::Value::Dict& ProxyConfigDictionary::GetDictionary() const {
|
||||
const base::DictValue& ProxyConfigDictionary::GetDictionary() const {
|
||||
return dict_;
|
||||
}
|
||||
@@ -83,13 +93,13 @@ const base::Value::Dict& ProxyConfigDictionary::GetDictionary() const {
|
||||
@@ -83,13 +93,13 @@ const base::DictValue& ProxyConfigDictionary::GetDictionary() const {
|
||||
// static
|
||||
base::Value::Dict ProxyConfigDictionary::CreateDirect() {
|
||||
base::DictValue ProxyConfigDictionary::CreateDirect() {
|
||||
return CreateDictionary(ProxyPrefs::MODE_DIRECT, std::string(), false,
|
||||
- std::string(), std::string());
|
||||
+ std::string(), std::string(), false);
|
||||
}
|
||||
|
||||
// static
|
||||
base::Value::Dict ProxyConfigDictionary::CreateAutoDetect() {
|
||||
base::DictValue ProxyConfigDictionary::CreateAutoDetect() {
|
||||
return CreateDictionary(ProxyPrefs::MODE_AUTO_DETECT, std::string(), false,
|
||||
- std::string(), std::string());
|
||||
+ std::string(), std::string(), false);
|
||||
}
|
||||
|
||||
// static
|
||||
@@ -97,16 +107,17 @@ base::Value::Dict ProxyConfigDictionary::CreatePacScript(
|
||||
@@ -97,16 +107,17 @@ base::DictValue ProxyConfigDictionary::CreatePacScript(
|
||||
const std::string& pac_url,
|
||||
bool pac_mandatory) {
|
||||
return CreateDictionary(ProxyPrefs::MODE_PAC_SCRIPT, pac_url, pac_mandatory,
|
||||
@@ -1246,7 +1238,7 @@ diff --git a/components/proxy_config/proxy_config_dictionary.cc b/components/pro
|
||||
}
|
||||
|
||||
// static
|
||||
base::Value::Dict ProxyConfigDictionary::CreateFixedServers(
|
||||
base::DictValue ProxyConfigDictionary::CreateFixedServers(
|
||||
const std::string& proxy_server,
|
||||
- const std::string& bypass_list) {
|
||||
+ const std::string& bypass_list,
|
||||
@@ -1258,26 +1250,26 @@ diff --git a/components/proxy_config/proxy_config_dictionary.cc b/components/pro
|
||||
} else {
|
||||
return CreateDirect();
|
||||
}
|
||||
@@ -115,7 +126,7 @@ base::Value::Dict ProxyConfigDictionary::CreateFixedServers(
|
||||
@@ -115,7 +126,7 @@ base::DictValue ProxyConfigDictionary::CreateFixedServers(
|
||||
// static
|
||||
base::Value::Dict ProxyConfigDictionary::CreateSystem() {
|
||||
base::DictValue ProxyConfigDictionary::CreateSystem() {
|
||||
return CreateDictionary(ProxyPrefs::MODE_SYSTEM, std::string(), false,
|
||||
- std::string(), std::string());
|
||||
+ std::string(), std::string(), false);
|
||||
}
|
||||
|
||||
// static
|
||||
@@ -124,7 +135,8 @@ base::Value::Dict ProxyConfigDictionary::CreateDictionary(
|
||||
@@ -124,7 +135,8 @@ base::DictValue ProxyConfigDictionary::CreateDictionary(
|
||||
const std::string& pac_url,
|
||||
bool pac_mandatory,
|
||||
const std::string& proxy_server,
|
||||
- const std::string& bypass_list) {
|
||||
+ const std::string& bypass_list,
|
||||
+ bool reverse_bypass) {
|
||||
base::Value::Dict dict;
|
||||
base::DictValue dict;
|
||||
dict.Set(kProxyMode, base::Value(ProxyModeToString(mode)));
|
||||
if (!pac_url.empty()) {
|
||||
@@ -133,8 +145,10 @@ base::Value::Dict ProxyConfigDictionary::CreateDictionary(
|
||||
@@ -133,8 +145,10 @@ base::DictValue ProxyConfigDictionary::CreateDictionary(
|
||||
}
|
||||
if (!proxy_server.empty())
|
||||
dict.Set(kProxyServer, base::Value(proxy_server));
|
||||
@@ -1298,27 +1290,27 @@ diff --git a/components/proxy_config/proxy_config_dictionary.h b/components/prox
|
||||
bool HasBypassList() const;
|
||||
+ bool HasReverseBypass() const;
|
||||
|
||||
const base::Value::Dict& GetDictionary() const;
|
||||
const base::DictValue& GetDictionary() const;
|
||||
|
||||
@@ -50,7 +51,8 @@ class PROXY_CONFIG_EXPORT ProxyConfigDictionary {
|
||||
static base::Value::Dict CreatePacScript(const std::string& pac_url,
|
||||
bool pac_mandatory);
|
||||
static base::Value::Dict CreateFixedServers(const std::string& proxy_server,
|
||||
- const std::string& bypass_list);
|
||||
+ const std::string& bypass_list,
|
||||
static base::DictValue CreatePacScript(const std::string& pac_url,
|
||||
bool pac_mandatory);
|
||||
static base::DictValue CreateFixedServers(const std::string& proxy_server,
|
||||
- const std::string& bypass_list);
|
||||
+ const std::string& bypass_list,
|
||||
+ bool reverse_bypass);
|
||||
static base::Value::Dict CreateSystem();
|
||||
static base::DictValue CreateSystem();
|
||||
|
||||
// Encodes the proxy server as "<url-scheme>=<proxy-scheme>://<proxy>".
|
||||
@@ -66,7 +68,8 @@ class PROXY_CONFIG_EXPORT ProxyConfigDictionary {
|
||||
const std::string& pac_url,
|
||||
bool pac_mandatory,
|
||||
const std::string& proxy_server,
|
||||
- const std::string& bypass_list);
|
||||
+ const std::string& bypass_list,
|
||||
const std::string& pac_url,
|
||||
bool pac_mandatory,
|
||||
const std::string& proxy_server,
|
||||
- const std::string& bypass_list);
|
||||
+ const std::string& bypass_list,
|
||||
+ bool reverse_bypass);
|
||||
|
||||
base::Value::Dict dict_;
|
||||
base::DictValue dict_;
|
||||
};
|
||||
diff --git a/components/proxy_config/proxy_policy_handler.cc b/components/proxy_config/proxy_policy_handler.cc
|
||||
--- a/components/proxy_config/proxy_policy_handler.cc
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -279,7 +279,7 @@ new file mode 100644
|
||||
diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
--- a/components/content_settings/core/browser/content_settings_registry.cc
|
||||
+++ b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
@@ -255,7 +255,7 @@ void ContentSettingsRegistry::Init() {
|
||||
@@ -254,7 +254,7 @@ void ContentSettingsRegistry::Init() {
|
||||
ContentSettingsInfo::INHERIT_IN_INCOGNITO,
|
||||
PermissionSettingsInfo::EXCEPTIONS_ON_SECURE_ORIGINS_ONLY);
|
||||
|
||||
|
||||
@@ -14,16 +14,16 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
chrome/android/java/AndroidManifest.xml | 1 -
|
||||
.../menu/bookmark_toolbar_menu_improved.xml | 14 +
|
||||
.../browser/TabbedModeTabDelegateFactory.java | 5 +-
|
||||
.../app/bookmarks/BookmarkActivity.java | 32 ++
|
||||
.../native_page/NativePageFactory.java | 9 +-
|
||||
chrome/browser/BUILD.gn | 11 +-
|
||||
.../app/bookmarks/BookmarkActivity.java | 20 ++
|
||||
.../native_page/NativePageFactory.java | 7 +-
|
||||
chrome/browser/BUILD.gn | 7 +
|
||||
.../bookmarks/android/bookmark_bridge.cc | 193 ++++++++++++
|
||||
.../bookmarks/android/bookmark_bridge.h | 30 +-
|
||||
.../browser/bookmarks/BookmarkBridge.java | 39 +++
|
||||
.../browser/bookmarks/BookmarkDelegate.java | 10 +
|
||||
.../bookmarks/BookmarkManagerCoordinator.java | 9 +
|
||||
.../bookmarks/BookmarkManagerMediator.java | 283 ++++++++++++++++++
|
||||
.../browser/bookmarks/BookmarkPage.java | 9 +-
|
||||
.../browser/bookmarks/BookmarkPage.java | 8 +-
|
||||
.../browser/bookmarks/BookmarkToolbar.java | 27 ++
|
||||
.../bookmarks/BookmarkToolbarMediator.java | 4 +
|
||||
.../bookmarks/BookmarkToolbarProperties.java | 8 +-
|
||||
@@ -51,7 +51,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
ui/shell_dialogs/select_file_dialog_linux.cc | 4 +
|
||||
ui/shell_dialogs/select_file_dialog_linux.h | 2 +
|
||||
ui/shell_dialogs/select_file_dialog_win.cc | 5 +
|
||||
40 files changed, 806 insertions(+), 24 deletions(-)
|
||||
40 files changed, 790 insertions(+), 21 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/add-bookmark-import-export-actions.inc
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/add-bookmark-import-export-actions.inc
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_h/add-bookmark-import-export-actions.inc
|
||||
@@ -94,7 +94,7 @@ diff --git a/chrome/android/java/res/menu/bookmark_toolbar_menu_improved.xml b/c
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDelegateFactory.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDelegateFactory.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDelegateFactory.java
|
||||
@@ -10,6 +10,7 @@ import org.chromium.base.supplier.ObservableSupplier;
|
||||
@@ -11,6 +11,7 @@ import org.chromium.base.supplier.NonNullObservableSupplier;
|
||||
import org.chromium.base.supplier.OneshotSupplier;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
@@ -102,24 +102,24 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDe
|
||||
import org.chromium.chrome.browser.app.tab_activity_glue.ActivityTabWebContentsDelegateAndroid;
|
||||
import org.chromium.chrome.browser.back_press.BackPressManager;
|
||||
import org.chromium.chrome.browser.browser_controls.BrowserControlsStateProvider;
|
||||
@@ -61,7 +62,7 @@ import java.util.function.Supplier;
|
||||
@@ -63,7 +64,7 @@ import java.util.function.Supplier;
|
||||
*/
|
||||
@NullMarked
|
||||
public class TabbedModeTabDelegateFactory implements TabDelegateFactory {
|
||||
- private final Activity mActivity;
|
||||
+ private final ChromeActivity mActivity;
|
||||
private final BrowserControlsVisibilityDelegate mAppBrowserControlsVisibilityDelegate;
|
||||
private final Supplier<ShareDelegate> mShareDelegateSupplier;
|
||||
private final Supplier<EphemeralTabCoordinator> mEphemeralTabCoordinatorSupplier;
|
||||
@@ -93,7 +94,7 @@ public class TabbedModeTabDelegateFactory implements TabDelegateFactory {
|
||||
private final MultiInstanceManager mMultiInstanceManager;
|
||||
private final Supplier<@Nullable ShareDelegate> mShareDelegateSupplier;
|
||||
private final Supplier<@Nullable EphemeralTabCoordinator> mEphemeralTabCoordinatorSupplier;
|
||||
@@ -97,7 +98,7 @@ public class TabbedModeTabDelegateFactory implements TabDelegateFactory {
|
||||
private final RecentlyClosedEntriesManager mRecentlyClosedEntriesManager;
|
||||
|
||||
public TabbedModeTabDelegateFactory(
|
||||
- Activity activity,
|
||||
+ ChromeActivity activity,
|
||||
BrowserControlsVisibilityDelegate appBrowserControlsVisibilityDelegate,
|
||||
Supplier<ShareDelegate> shareDelegateSupplier,
|
||||
Supplier<EphemeralTabCoordinator> ephemeralTabCoordinatorSupplier,
|
||||
Supplier<@Nullable ShareDelegate> shareDelegateSupplier,
|
||||
Supplier<@Nullable EphemeralTabCoordinator> ephemeralTabCoordinatorSupplier,
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/BookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/BookmarkActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/BookmarkActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/BookmarkActivity.java
|
||||
@@ -132,50 +132,17 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/B
|
||||
import android.content.ComponentName;
|
||||
import android.content.Intent;
|
||||
import android.text.TextUtils;
|
||||
@@ -35,6 +37,9 @@ import org.chromium.components.embedder_support.util.UrlConstants;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager.ModalDialogType;
|
||||
|
||||
+import org.chromium.ui.base.ActivityWindowAndroid;
|
||||
+import org.chromium.ui.base.IntentRequestTracker;
|
||||
+
|
||||
/**
|
||||
* The activity that displays the bookmark UI on the phone. It keeps a {@link
|
||||
* BookmarkManagerCoordinator} inside of it and creates a snackbar manager. This activity should
|
||||
@@ -50,6 +55,9 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
private @Nullable BookmarkOpener mBookmarkOpener;
|
||||
private @Nullable OnKeyDownHandler mOnKeyDownHandler;
|
||||
|
||||
+ private ActivityWindowAndroid mWindowAndroid;
|
||||
+ private IntentRequestTracker mIntentRequestTracker;
|
||||
+
|
||||
@Override
|
||||
protected void onProfileAvailable(Profile profile) {
|
||||
super.onProfileAvailable(profile);
|
||||
@@ -82,6 +90,14 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
@@ -133,6 +135,9 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
mOnKeyDownHandler =
|
||||
BackPressHelper.create(
|
||||
this, getOnBackPressedDispatcher(), mBookmarkManagerCoordinator);
|
||||
+
|
||||
+ final boolean listenToActivityState = true;
|
||||
+ mIntentRequestTracker = IntentRequestTracker.createFromActivity(this);
|
||||
+ mWindowAndroid = new ActivityWindowAndroid(this, listenToActivityState,
|
||||
+ mIntentRequestTracker, /*InsetObserver*/ null,
|
||||
+ /* trackOcclusion= */ true);
|
||||
+ mBookmarkManagerCoordinator.setWindow(mWindowAndroid,
|
||||
+ getModalDialogManagerSupplier().get());
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -109,6 +125,7 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
@Override
|
||||
protected void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
|
||||
super.onActivityResult(requestCode, resultCode, data);
|
||||
+ mWindowAndroid.getIntentRequestTracker().onActivityResult(requestCode, resultCode, data);
|
||||
if (requestCode == EDIT_BOOKMARK_REQUEST_CODE && resultCode == RESULT_OK) {
|
||||
assumeNonNull(data);
|
||||
BookmarkId bookmarkId =
|
||||
@@ -118,6 +135,21 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
@@ -179,6 +184,21 @@ public class BookmarkActivity extends SnackbarActivity {
|
||||
}
|
||||
}
|
||||
|
||||
@@ -200,15 +167,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/bookmarks/B
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageFactory.java
|
||||
@@ -26,6 +26,7 @@ import org.chromium.base.supplier.OneshotSupplier;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
@@ -28,6 +28,7 @@ import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.chrome.R;
|
||||
import org.chromium.chrome.browser.RecentlyClosedEntriesManager;
|
||||
+import org.chromium.chrome.browser.app.ChromeActivity;
|
||||
import org.chromium.chrome.browser.app.download.home.DownloadPage;
|
||||
import org.chromium.chrome.browser.back_press.BackPressManager;
|
||||
import org.chromium.chrome.browser.bookmarks.BookmarkPage;
|
||||
@@ -79,7 +80,7 @@ import java.util.function.Supplier;
|
||||
@@ -83,7 +84,7 @@ import java.util.function.Supplier;
|
||||
*/
|
||||
@NullMarked
|
||||
public class NativePageFactory {
|
||||
@@ -217,8 +184,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/native_page/Nat
|
||||
private final BottomSheetController mBottomSheetController;
|
||||
private final BrowserControlsManager mBrowserControlsManager;
|
||||
private final Supplier<@Nullable Tab> mCurrentTabSupplier;
|
||||
@@ -104,7 +105,7 @@ public class NativePageFactory {
|
||||
private final MultiInstanceManager mMultiInstanceManager;
|
||||
@@ -111,7 +112,7 @@ public class NativePageFactory {
|
||||
private final RecentlyClosedEntriesManager mRecentlyClosedEntriesManager;
|
||||
|
||||
public NativePageFactory(
|
||||
- Activity activity,
|
||||
@@ -226,7 +193,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/native_page/Nat
|
||||
BottomSheetController sheetController,
|
||||
BrowserControlsManager browserControlsManager,
|
||||
Supplier<@Nullable Tab> currentTabSupplier,
|
||||
@@ -182,7 +183,7 @@ public class NativePageFactory {
|
||||
@@ -198,7 +199,7 @@ public class NativePageFactory {
|
||||
|
||||
@VisibleForTesting
|
||||
static class NativePageBuilder {
|
||||
@@ -235,29 +202,11 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/native_page/Nat
|
||||
private final BottomSheetController mBottomSheetController;
|
||||
private final Supplier<NewTabPageCreationTracker> mNewTabPageCreationTracker;
|
||||
private final BrowserControlsManager mBrowserControlsManager;
|
||||
@@ -299,7 +300,7 @@ public class NativePageFactory {
|
||||
mTabModelSelector,
|
||||
mEdgeToEdgeControllerSupplier),
|
||||
mActivity.getComponentName(),
|
||||
- mBackPressManager);
|
||||
+ mBackPressManager, mActivity);
|
||||
}
|
||||
|
||||
protected NativePage buildDownloadsPage(Tab tab) {
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -207,6 +207,8 @@ static_library("browser") {
|
||||
"bad_message.h",
|
||||
"bookmarks/bookmark_model_factory.cc",
|
||||
"bookmarks/bookmark_model_factory.h",
|
||||
+ "bookmarks/bookmark_html_writer.cc",
|
||||
+ "bookmarks/bookmark_html_writer.h",
|
||||
"bookmarks/chrome_bookmark_client.cc",
|
||||
"bookmarks/chrome_bookmark_client.h",
|
||||
"bookmarks/managed_bookmark_service_factory.cc",
|
||||
@@ -1573,6 +1575,13 @@ static_library("browser") {
|
||||
"webdata_services/web_data_service_factory.cc",
|
||||
@@ -1327,6 +1327,13 @@ static_library("browser") {
|
||||
"webauthn/webauthn_switches.cc",
|
||||
]
|
||||
|
||||
+ if (is_android) {
|
||||
@@ -270,15 +219,6 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
configs += [
|
||||
"//build/config/compiler:wexit_time_destructors",
|
||||
"//build/config:precompiled_headers",
|
||||
@@ -3733,8 +3742,6 @@ static_library("browser") {
|
||||
"bookmarks/bookmark_expanded_state_tracker.h",
|
||||
"bookmarks/bookmark_expanded_state_tracker_factory.cc",
|
||||
"bookmarks/bookmark_expanded_state_tracker_factory.h",
|
||||
- "bookmarks/bookmark_html_writer.cc",
|
||||
- "bookmarks/bookmark_html_writer.h",
|
||||
"bookmarks/bookmark_merged_surface_ordering_storage.cc",
|
||||
"bookmarks/bookmark_merged_surface_ordering_storage.h",
|
||||
"bookmarks/bookmark_merged_surface_service.cc",
|
||||
diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
--- a/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
+++ b/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
@@ -311,7 +251,7 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
// Must come after all headers that specialize FromJniType() / ToJniType().
|
||||
#include "chrome/browser/bookmarks/android/jni_headers/BookmarkBridge_jni.h"
|
||||
|
||||
@@ -292,6 +314,10 @@ BookmarkBridge::~BookmarkBridge() {
|
||||
@@ -293,6 +315,10 @@ BookmarkBridge::~BookmarkBridge() {
|
||||
partner_bookmarks_shim_observation_.Reset();
|
||||
bookmark_model_observation_.Reset();
|
||||
profile_observation_.Reset();
|
||||
@@ -322,13 +262,13 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
}
|
||||
|
||||
void BookmarkBridge::Destroy(JNIEnv* env) {
|
||||
@@ -843,6 +869,173 @@ jint BookmarkBridge::GetTotalBookmarkCount(
|
||||
@@ -841,6 +867,173 @@ int32_t BookmarkBridge::GetTotalBookmarkCount(JNIEnv* env,
|
||||
return count;
|
||||
}
|
||||
|
||||
+void BookmarkBridge::ImportBookmarks(JNIEnv* env,
|
||||
+ const JavaParamRef<jobject>& obj,
|
||||
+ const JavaParamRef<jobject>& java_window) {
|
||||
+ const JavaRef<jobject>& obj,
|
||||
+ const JavaRef<jobject>& java_window) {
|
||||
+ DCHECK(IsLoaded());
|
||||
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
||||
+
|
||||
@@ -357,9 +297,9 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
+}
|
||||
+
|
||||
+void BookmarkBridge::ExportBookmarks(JNIEnv* env,
|
||||
+ const JavaParamRef<jobject>& obj,
|
||||
+ const JavaParamRef<jobject>& java_window,
|
||||
+ const JavaParamRef<jstring>& j_export_path) {
|
||||
+ const JavaRef<jobject>& obj,
|
||||
+ const JavaRef<jobject>& java_window,
|
||||
+ const JavaRef<jstring>& j_export_path) {
|
||||
+ DCHECK(IsLoaded());
|
||||
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
||||
+
|
||||
@@ -494,12 +434,12 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
+void BookmarkBridge::FileSelectionCanceled() {}
|
||||
+
|
||||
void BookmarkBridge::SetBookmarkTitle(JNIEnv* env,
|
||||
jlong id,
|
||||
jint type,
|
||||
int64_t id,
|
||||
int32_t type,
|
||||
diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
--- a/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
+++ b/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
@@ -20,6 +20,7 @@
|
||||
@@ -19,6 +19,7 @@
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "base/supports_user_data.h"
|
||||
#include "chrome/browser/partnerbookmarks/partner_bookmarks_shim.h"
|
||||
@@ -507,7 +447,7 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
#include "chrome/browser/profiles/profile.h"
|
||||
#include "chrome/browser/profiles/profile_observer.h"
|
||||
#include "chrome/browser/reading_list/android/reading_list_manager.h"
|
||||
@@ -37,6 +38,9 @@
|
||||
@@ -36,6 +37,9 @@
|
||||
#include "components/signin/public/identity_manager/identity_manager.h"
|
||||
#include "url/android/gurl_android.h"
|
||||
|
||||
@@ -517,8 +457,8 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
class BookmarkBridgeTest;
|
||||
|
||||
// Values for a bitmask used to refer to a collection of bookmark nodes.
|
||||
@@ -77,7 +81,8 @@ class BookmarkBridge : public ProfileObserver,
|
||||
public ReadingListManager::Observer,
|
||||
@@ -76,7 +80,8 @@ class BookmarkBridge : public ProfileObserver,
|
||||
public reading_list::ReadingListManager::Observer,
|
||||
public ReadingListModelObserver,
|
||||
public signin::IdentityManager::Observer,
|
||||
- public base::SupportsUserData::Data {
|
||||
@@ -527,7 +467,7 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
public:
|
||||
// All of the injected pointers must be non-null and must outlive `this`.
|
||||
BookmarkBridge(Profile* profile,
|
||||
@@ -108,6 +113,11 @@ class BookmarkBridge : public ProfileObserver,
|
||||
@@ -107,6 +112,11 @@ class BookmarkBridge : public ProfileObserver,
|
||||
|
||||
bool IsDoingExtensiveChanges(JNIEnv* env);
|
||||
|
||||
@@ -536,28 +476,28 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
+ int index) override;
|
||||
+ void FileSelectionCanceled() override;
|
||||
+
|
||||
jboolean IsEditBookmarksEnabled(JNIEnv* env);
|
||||
bool IsEditBookmarksEnabled(JNIEnv* env);
|
||||
|
||||
void LoadEmptyPartnerBookmarkShimForTesting(JNIEnv* env);
|
||||
@@ -120,6 +130,17 @@ class BookmarkBridge : public ProfileObserver,
|
||||
jlong id,
|
||||
jint type);
|
||||
@@ -119,6 +129,17 @@ class BookmarkBridge : public ProfileObserver,
|
||||
int64_t id,
|
||||
int32_t type);
|
||||
|
||||
+ void ImportBookmarks(JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& obj,
|
||||
+ const base::android::JavaParamRef<jobject>& java_window);
|
||||
+ const base::android::JavaRef<jobject>& obj,
|
||||
+ const base::android::JavaRef<jobject>& java_window);
|
||||
+
|
||||
+ void ExportBookmarks(JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& obj,
|
||||
+ const base::android::JavaParamRef<jobject>& java_window,
|
||||
+ const base::android::JavaParamRef<jstring>& j_export_path);
|
||||
+ const base::android::JavaRef<jobject>& obj,
|
||||
+ const base::android::JavaRef<jobject>& java_window,
|
||||
+ const base::android::JavaRef<jstring>& j_export_path);
|
||||
+ void ExportBookmarksEnd(const base::android::ScopedJavaGlobalRef<jobject>& obj,
|
||||
+ ui::WindowAndroid* window, bookmark_html_writer::Result result) const;
|
||||
+
|
||||
void GetAllFoldersWithDepths(
|
||||
JNIEnv* env,
|
||||
const base::android::JavaParamRef<jobject>& j_folders_obj,
|
||||
@@ -385,6 +406,8 @@ class BookmarkBridge : public ProfileObserver,
|
||||
const base::android::JavaRef<jobject>& j_folders_obj,
|
||||
@@ -372,6 +393,8 @@ class BookmarkBridge : public ProfileObserver,
|
||||
void CreateOrDestroyAccountReadingListManagerIfNeeded();
|
||||
|
||||
const raw_ptr<Profile> profile_; // weak
|
||||
@@ -566,7 +506,7 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
base::android::ScopedJavaGlobalRef<jobject> java_bookmark_model_;
|
||||
const raw_ptr<bookmarks::BookmarkModel> bookmark_model_; // weak
|
||||
const raw_ptr<bookmarks::ManagedBookmarkService>
|
||||
@@ -399,6 +422,7 @@ class BookmarkBridge : public ProfileObserver,
|
||||
@@ -386,6 +409,7 @@ class BookmarkBridge : public ProfileObserver,
|
||||
std::unique_ptr<bookmarks::ScopedGroupBookmarkActions>
|
||||
grouped_bookmark_actions_;
|
||||
PrefChangeRegistrar pref_change_registrar_;
|
||||
@@ -574,7 +514,7 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser
|
||||
|
||||
// Information about the Partner bookmarks (must check for IsLoaded()).
|
||||
// This is owned by profile.
|
||||
@@ -432,6 +456,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
@@ -420,6 +444,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
base::TimeTicks load_start_time_;
|
||||
bool loading_notification_sent_ = false;
|
||||
|
||||
@@ -678,16 +618,16 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java
|
||||
@@ -57,6 +57,8 @@ import org.chromium.components.image_fetcher.ImageFetcherConfig;
|
||||
import org.chromium.components.image_fetcher.ImageFetcherFactory;
|
||||
import org.chromium.ui.KeyboardVisibilityDelegate;
|
||||
@@ -66,6 +66,8 @@ import org.chromium.ui.base.ActivityResultTracker;
|
||||
import org.chromium.ui.base.Clipboard;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
import org.chromium.ui.edge_to_edge.EdgeToEdgePadAdjuster;
|
||||
+import org.chromium.ui.base.ActivityWindowAndroid;
|
||||
+import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager.ModalDialogType;
|
||||
import org.chromium.ui.modelutil.MVCListAdapter.ListItem;
|
||||
@@ -344,6 +346,13 @@ public class BookmarkManagerCoordinator
|
||||
@@ -369,6 +371,13 @@ public class BookmarkManagerCoordinator
|
||||
|
||||
// Public API implementation.
|
||||
|
||||
@@ -704,16 +644,16 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerMediator.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerMediator.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerMediator.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerMediator.java
|
||||
@@ -63,6 +63,8 @@ import org.chromium.components.commerce.core.SubscriptionsObserver;
|
||||
import org.chromium.components.embedder_support.util.UrlConstants;
|
||||
@@ -68,6 +68,8 @@ import org.chromium.components.commerce.core.ShoppingService;
|
||||
import org.chromium.components.commerce.core.SubscriptionsObserver;
|
||||
import org.chromium.components.power_bookmarks.PowerBookmarkMeta;
|
||||
import org.chromium.components.power_bookmarks.PowerBookmarkType;
|
||||
+import org.chromium.ui.base.ActivityWindowAndroid;
|
||||
+import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
import org.chromium.ui.accessibility.AccessibilityState;
|
||||
import org.chromium.ui.base.Clipboard;
|
||||
import org.chromium.ui.base.DeviceFormFactor;
|
||||
import org.chromium.ui.base.DeviceInput;
|
||||
@@ -84,6 +86,47 @@ import java.util.function.BooleanSupplier;
|
||||
@@ -91,6 +93,47 @@ import java.util.function.BooleanSupplier;
|
||||
import java.util.function.Consumer;
|
||||
import java.util.function.Predicate;
|
||||
|
||||
@@ -761,7 +701,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
/** Responsible for BookmarkManager business logic. */
|
||||
// TODO(crbug.com/40256938): Remove BookmarkDelegate if possible.
|
||||
@NullMarked
|
||||
@@ -94,6 +137,9 @@ class BookmarkManagerMediator
|
||||
@@ -101,6 +144,9 @@ class BookmarkManagerMediator
|
||||
|
||||
private static boolean sPreventLoadingForTesting;
|
||||
|
||||
@@ -771,7 +711,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
/** Keeps track of whether drag is enabled / active for bookmark lists. */
|
||||
private class BookmarkDragStateDelegate implements DragStateDelegate {
|
||||
private BookmarkDelegate mBookmarkDelegate;
|
||||
@@ -646,6 +692,14 @@ class BookmarkManagerMediator
|
||||
@@ -643,6 +689,14 @@ class BookmarkManagerMediator
|
||||
mNativePage = nativePage;
|
||||
}
|
||||
|
||||
@@ -786,7 +726,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
/** See BookmarkManager(Coordinator)#updateForUrl */
|
||||
void updateForUrl(String url) {
|
||||
// Bookmark model is null if the manager has been destroyed.
|
||||
@@ -818,6 +872,235 @@ class BookmarkManagerMediator
|
||||
@@ -811,6 +865,235 @@ class BookmarkManagerMediator
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1025,27 +965,26 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
||||
@@ -16,6 +16,9 @@ import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
import org.chromium.chrome.browser.ui.native_page.BasicNativePage;
|
||||
import org.chromium.chrome.browser.ui.native_page.NativePageHost;
|
||||
import org.chromium.components.embedder_support.util.UrlConstants;
|
||||
@@ -22,6 +22,9 @@ import org.chromium.ui.base.ActivityResultTracker;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
|
||||
import java.util.function.Supplier;
|
||||
+import org.chromium.chrome.browser.app.ChromeActivity;
|
||||
+import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
+import org.chromium.components.browser_ui.modaldialog.AppModalPresenter;
|
||||
|
||||
/** A native page holding a {@link BookmarkManagerCoordinator} on _tablet_. */
|
||||
@NullMarked
|
||||
@@ -37,7 +40,8 @@ public class BookmarkPage extends BasicNativePage {
|
||||
Profile profile,
|
||||
NativePageHost host,
|
||||
@Nullable ComponentName componentName,
|
||||
- BackPressManager backPressManager) {
|
||||
+ BackPressManager backPressManager,
|
||||
+ ChromeActivity activity) {
|
||||
super(host);
|
||||
|
||||
mTitle = host.getContext().getString(R.string.bookmarks);
|
||||
@@ -65,6 +69,9 @@ public class BookmarkPage extends BasicNativePage {
|
||||
@@ -45,7 +48,7 @@ public class BookmarkPage extends BasicNativePage {
|
||||
*/
|
||||
public BookmarkPage(
|
||||
WindowAndroid windowAndroid,
|
||||
- Activity activity,
|
||||
+ ChromeActivity activity,
|
||||
SnackbarManager snackbarManager,
|
||||
Supplier<BottomSheetController> bottomSheetControllerSupplier,
|
||||
ActivityResultTracker activityResultTracker,
|
||||
@@ -83,6 +86,9 @@ public class BookmarkPage extends BasicNativePage {
|
||||
backPressManager);
|
||||
|
||||
mBookmarkManagerCoordinator.setBasicNativePage(this);
|
||||
@@ -1058,7 +997,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbar.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbar.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbar.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbar.java
|
||||
@@ -102,6 +102,17 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -103,6 +103,17 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
setOnMenuItemClickListener(dragEnabled ? null : this);
|
||||
}
|
||||
|
||||
@@ -1076,7 +1015,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
void setEditButtonVisible(boolean visible) {
|
||||
mEditButtonVisible = visible;
|
||||
getMenu().findItem(R.id.edit_menu_id).setVisible(visible);
|
||||
@@ -178,6 +189,12 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -185,6 +196,12 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
|
||||
void setCurrentFolder(BookmarkId folder) {
|
||||
mCurrentFolder = mBookmarkModel.getBookmarkById(folder);
|
||||
@@ -1089,7 +1028,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
}
|
||||
|
||||
void setNavigateBackRunnable(Runnable navigateBackRunnable) {
|
||||
@@ -202,6 +219,13 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -209,6 +226,13 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@Override
|
||||
public boolean onMenuItemClick(MenuItem menuItem) {
|
||||
hideOverflowMenu();
|
||||
@@ -1103,7 +1042,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
return assumeNonNull(mMenuIdClickedFunction).apply(menuItem.getItemId());
|
||||
}
|
||||
|
||||
@@ -222,6 +246,9 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -229,6 +253,9 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
protected void showNormalView() {
|
||||
super.showNormalView();
|
||||
|
||||
@@ -1116,7 +1055,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarMediator.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarMediator.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarMediator.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarMediator.java
|
||||
@@ -139,6 +139,10 @@ class BookmarkToolbarMediator
|
||||
@@ -148,6 +148,10 @@ class BookmarkToolbarMediator
|
||||
mBookmarkDelegate = bookmarkDelegate;
|
||||
mModel.set(
|
||||
BookmarkToolbarProperties.NAVIGATE_BACK_RUNNABLE, this::onNavigateBack);
|
||||
@@ -1130,7 +1069,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarProperties.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarProperties.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarProperties.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarProperties.java
|
||||
@@ -86,6 +86,10 @@ class BookmarkToolbarProperties {
|
||||
@@ -88,6 +88,10 @@ class BookmarkToolbarProperties {
|
||||
|
||||
static final WritableObjectPropertyKey<View> NEXT_FOCUSABLE_VIEW =
|
||||
new WritableObjectPropertyKey<>();
|
||||
@@ -1141,8 +1080,8 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
|
||||
static final PropertyKey[] ALL_KEYS = {
|
||||
SELECTION_DELEGATE,
|
||||
@@ -114,6 +118,8 @@ class BookmarkToolbarProperties {
|
||||
SELECTION_MODE_SHOW_MOVE,
|
||||
@@ -117,6 +121,8 @@ class BookmarkToolbarProperties {
|
||||
SELECTION_MODE_SHOW_COPY_LINK,
|
||||
SELECTION_MODE_SHOW_MARK_READ,
|
||||
SELECTION_MODE_SHOW_MARK_UNREAD,
|
||||
- NEXT_FOCUSABLE_VIEW
|
||||
@@ -1247,18 +1186,18 @@ diff --git a/chrome/browser/download/android/java/src/org/chromium/chrome/browse
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
@@ -264,6 +264,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kAuxiliarySearchHistoryDonation,
|
||||
@@ -265,6 +265,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kBlockIntentsWhileLocked,
|
||||
&kBookmarkPaneAndroid,
|
||||
&kBottomSheetAsBrowserControls,
|
||||
+ &kBookmarksExportUseSaf,
|
||||
&kBrowserControlsDebugging,
|
||||
&kBrowserControlsEarlyResize,
|
||||
&kBrowserControlsRenderDrivenShowConstraint,
|
||||
&kBrowserControlsPersistsOnCvh,
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
@@ -713,6 +713,7 @@ public abstract class ChromeFeatureList {
|
||||
@@ -709,6 +709,7 @@ public abstract class ChromeFeatureList {
|
||||
"UseLibunwindstackNativeUnwinderAndroid";
|
||||
public static final String VERIFY_QWACS = "VerifyQWACs";
|
||||
public static final String VISITED_URL_RANKING_SERVICE = "VisitedURLRankingService";
|
||||
@@ -1321,7 +1260,7 @@ diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/bro
|
||||
|
||||
/** Whether Chrome is set as the default browser. Default value is false. */
|
||||
public static final String CHROME_DEFAULT_BROWSER = "applink.chrome_default_browser";
|
||||
@@ -1125,6 +1127,7 @@ public final class ChromePreferenceKeys {
|
||||
@@ -1208,6 +1210,7 @@ public final class ChromePreferenceKeys {
|
||||
AUXILIARY_SEARCH_SCHEMA_VERSION,
|
||||
APP_LAUNCH_LAST_KNOWN_ACTIVE_TAB_STATE,
|
||||
APP_LAUNCH_SEARCH_ENGINE_HAD_LOGO,
|
||||
@@ -1332,7 +1271,7 @@ diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -264,6 +264,24 @@ CHAR_LIMIT guidelines:
|
||||
@@ -271,6 +271,24 @@ CHAR_LIMIT guidelines:
|
||||
<message name="IDS_NOTIFICATION_CATEGORY_SITES" desc="Label for notifications from websites, within a list of notification categories. [CHAR_LIMIT=32]">
|
||||
Sites
|
||||
</message>
|
||||
@@ -1360,7 +1299,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
|
||||
--- a/chrome/utility/BUILD.gn
|
||||
+++ b/chrome/utility/BUILD.gn
|
||||
@@ -211,6 +211,13 @@ static_library("utility") {
|
||||
@@ -215,6 +215,13 @@ static_library("utility") {
|
||||
deps += [ "//chrome/services/pdf:lib" ]
|
||||
}
|
||||
|
||||
@@ -1462,7 +1401,7 @@ new file mode 100644
|
||||
diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
||||
--- a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
||||
+++ b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
||||
@@ -51,6 +51,7 @@ import org.chromium.build.annotations.Initializer;
|
||||
@@ -52,6 +52,7 @@ import org.chromium.build.annotations.Initializer;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.ui.R;
|
||||
@@ -1470,7 +1409,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
import org.chromium.ui.UiUtils;
|
||||
|
||||
import java.io.File;
|
||||
@@ -74,6 +75,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -75,6 +76,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
private static final String TAG = "SelectFileDialog";
|
||||
private static final String IMAGE_TYPE = "image";
|
||||
private static final String VIDEO_TYPE = "video";
|
||||
@@ -1478,7 +1417,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
private static final String AUDIO_TYPE = "audio";
|
||||
private static final String ALL_TYPES = "*/*";
|
||||
private static final String GENERIC_TYPE = "application/octet-stream";
|
||||
@@ -323,6 +325,17 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -324,6 +326,17 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
mMimeTypes = convertToSupportedMimeTypes(mFileTypes);
|
||||
}
|
||||
|
||||
@@ -1496,7 +1435,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
/**
|
||||
* Creates and starts an intent based on the passed fileTypes and capture value.
|
||||
*
|
||||
@@ -407,7 +420,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -408,7 +421,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
List<String> missingPermissions = new ArrayList<>();
|
||||
String storagePermission = Manifest.permission.READ_EXTERNAL_STORAGE;
|
||||
boolean shouldUsePhotoPicker = shouldUsePhotoPicker();
|
||||
@@ -1505,7 +1444,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
// The permission scenario for accessing media has evolved a bit over the years:
|
||||
// Early on, READ_EXTERNAL_STORAGE was required to access media, but that permission was
|
||||
// later deprecated. In its place (starting with Android T) READ_MEDIA_IMAGES and
|
||||
@@ -460,7 +473,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -461,7 +474,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
|
||||
// TODO(finnur): Remove once we figure out the cause of
|
||||
// crbug.com/950024.
|
||||
@@ -1514,7 +1453,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
if (permissions.length != requestPermissions.length) {
|
||||
throw new RuntimeException(
|
||||
String.format(
|
||||
@@ -477,7 +490,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -478,7 +491,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1523,7 +1462,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
if (permissions[i].equals(storagePermission)
|
||||
|| permissions[i].equals(
|
||||
Manifest.permission.READ_MEDIA_IMAGES)
|
||||
@@ -783,6 +796,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -789,6 +802,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
mimeTypes.add(mimeType);
|
||||
}
|
||||
}
|
||||
@@ -1531,7 +1470,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
||||
return mimeTypes;
|
||||
}
|
||||
|
||||
@@ -1168,6 +1182,10 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
@@ -1174,6 +1188,10 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
||||
return countAcceptTypesFor(superType) == mMimeTypes.size();
|
||||
}
|
||||
|
||||
@@ -1570,8 +1509,8 @@ diff --git a/ui/shell_dialogs/select_file_dialog.h b/ui/shell_dialogs/select_fil
|
||||
diff --git a/ui/shell_dialogs/select_file_dialog_android.cc b/ui/shell_dialogs/select_file_dialog_android.cc
|
||||
--- a/ui/shell_dialogs/select_file_dialog_android.cc
|
||||
+++ b/ui/shell_dialogs/select_file_dialog_android.cc
|
||||
@@ -196,6 +196,12 @@ void SelectFileDialogImpl::SelectFileImpl(Type type,
|
||||
suggested_name.value(), owning_window->GetJavaObject());
|
||||
@@ -171,6 +171,12 @@ void SelectFileDialogImpl::SelectFileImpl(Type type,
|
||||
owning_window->GetJavaObject());
|
||||
}
|
||||
|
||||
+void SelectFileDialogImpl::ShowToast(const std::string& message) {
|
||||
|
||||
@@ -13,8 +13,10 @@ in the setting ui.
|
||||
Need: bromite-build-utils.patch
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
base/BUILD.gn | 4 +-
|
||||
base/BUILD.gn | 5 +-
|
||||
base/android/feature_map.cc | 5 +
|
||||
.../src/org/chromium/base/FeatureMap.java | 5 +
|
||||
.../base/ImmutableFlagWithDefault.java | 25 +++
|
||||
.../base/cached_flags/ValuesReturned.java | 2 +-
|
||||
base/feature_list.cc | 76 ++++++++
|
||||
base/feature_list.h | 98 +++++++++-
|
||||
@@ -41,7 +43,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../placeholder.txt | 1 +
|
||||
chrome/browser/ui/ui_features.cc | 1 +
|
||||
chrome/browser/unexpire_flags.cc | 15 +-
|
||||
chrome/common/chrome_features.cc | 2 +-
|
||||
chrome/common/chrome_features.cc | 1 +
|
||||
.../browser_ui/accessibility/android/BUILD.gn | 1 +
|
||||
.../res/xml/accessibility_preferences.xml | 3 +-
|
||||
.../accessibility/AccessibilitySettings.java | 6 +-
|
||||
@@ -58,7 +60,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
...nthetic_trials_active_group_id_provider.cc | 4 +-
|
||||
...ynthetic_trials_active_group_id_provider.h | 4 +-
|
||||
components/webui/flags/flags_state.cc | 59 ++++++
|
||||
components/webui/flags/resources/app.css | 24 +++
|
||||
components/webui/flags/resources/app.css | 32 ++++
|
||||
components/webui/flags/resources/app.html.ts | 28 +++
|
||||
components/webui/flags/resources/app.ts | 24 +++
|
||||
.../webui/flags/resources/experiment.css | 9 +-
|
||||
@@ -106,7 +108,8 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
third_party/blink/public/common/features.h | 1 +
|
||||
ui/base/ui_base_features.cc | 1 +
|
||||
ui/base/ui_base_features.h | 1 +
|
||||
93 files changed, 846 insertions(+), 32 deletions(-)
|
||||
95 files changed, 885 insertions(+), 31 deletions(-)
|
||||
create mode 100644 base/android/java/src/org/chromium/base/ImmutableFlagWithDefault.java
|
||||
create mode 100644 chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/include_all_directory.java
|
||||
create mode 100644 chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/java_template/CromiteCachedFlag.java.tmpl
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Add-cromite-flags-support.grdp
|
||||
@@ -143,7 +146,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/base/BUILD.gn b/base/BUILD.gn
|
||||
--- a/base/BUILD.gn
|
||||
+++ b/base/BUILD.gn
|
||||
@@ -174,6 +174,8 @@ use_epoll = is_linux || is_chromeos || is_android
|
||||
@@ -190,6 +190,8 @@ generate_allowlist_from_histograms_file("memory_dump_provider_name_variants") {
|
||||
# This does not include test code (test support and anything in the test
|
||||
# directory) which should use source_set as is recommended for GN targets).
|
||||
component("base") {
|
||||
@@ -152,22 +155,30 @@ diff --git a/base/BUILD.gn b/base/BUILD.gn
|
||||
sources = [
|
||||
"allocator/allocator_check.cc",
|
||||
"allocator/allocator_check.h",
|
||||
@@ -1061,7 +1063,7 @@ component("base") {
|
||||
@@ -1069,7 +1071,7 @@ component("base") {
|
||||
"//build/config/compiler:wglobal_constructors",
|
||||
]
|
||||
|
||||
- deps = [
|
||||
+ deps += [
|
||||
":check_version_internal",
|
||||
":simdutf_shim",
|
||||
"//base/allocator:buildflags",
|
||||
"//base/third_party/cityhash",
|
||||
@@ -4959,6 +4961,7 @@ if (is_android) {
|
||||
"android/java/src/org/chromium/base/Flag.java",
|
||||
"android/java/src/org/chromium/base/MutableBooleanParamWithSafeDefault.java",
|
||||
"android/java/src/org/chromium/base/MutableFlagWithSafeDefault.java",
|
||||
+ "android/java/src/org/chromium/base/ImmutableFlagWithDefault.java",
|
||||
"android/java/src/org/chromium/base/MutableIntParamWithSafeDefault.java",
|
||||
"android/java/src/org/chromium/base/MutableParamWithSafeDefault.java",
|
||||
]
|
||||
diff --git a/base/android/feature_map.cc b/base/android/feature_map.cc
|
||||
--- a/base/android/feature_map.cc
|
||||
+++ b/base/android/feature_map.cc
|
||||
@@ -47,6 +47,11 @@ const Feature* FeatureMap::FindFeatureExposedToJava(
|
||||
static jboolean JNI_FeatureMap_IsEnabled(JNIEnv* env,
|
||||
jlong jfeature_map,
|
||||
std::string& feature_name) {
|
||||
@@ -46,6 +46,11 @@ const Feature* FeatureMap::FindFeatureExposedToJava(
|
||||
|
||||
static bool JNI_FeatureMap_IsEnabled(int64_t jfeature_map,
|
||||
const std::string& feature_name) {
|
||||
+ if (base::FeatureList::IsCromiteFlag(feature_name)) {
|
||||
+ const base::Feature* cromite_feature =
|
||||
+ base::FeatureList::GetCromiteFlag(feature_name);
|
||||
@@ -176,6 +187,51 @@ diff --git a/base/android/feature_map.cc b/base/android/feature_map.cc
|
||||
FeatureMap* feature_map = reinterpret_cast<FeatureMap*>(jfeature_map);
|
||||
const base::Feature* feature =
|
||||
feature_map->FindFeatureExposedToJava(feature_name);
|
||||
diff --git a/base/android/java/src/org/chromium/base/FeatureMap.java b/base/android/java/src/org/chromium/base/FeatureMap.java
|
||||
--- a/base/android/java/src/org/chromium/base/FeatureMap.java
|
||||
+++ b/base/android/java/src/org/chromium/base/FeatureMap.java
|
||||
@@ -159,6 +159,11 @@ public abstract class FeatureMap {
|
||||
return new MutableFlagWithSafeDefault(this, featureName, defaultValue);
|
||||
}
|
||||
|
||||
+ public ImmutableFlagWithDefault immutableFlagWithDefault(
|
||||
+ String featureName, boolean defaultValue) {
|
||||
+ return new ImmutableFlagWithDefault(this, featureName, defaultValue);
|
||||
+ }
|
||||
+
|
||||
private void ensureNativeMapInit() {
|
||||
assert FeatureList.isNativeInitialized();
|
||||
|
||||
diff --git a/base/android/java/src/org/chromium/base/ImmutableFlagWithDefault.java b/base/android/java/src/org/chromium/base/ImmutableFlagWithDefault.java
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/base/android/java/src/org/chromium/base/ImmutableFlagWithDefault.java
|
||||
@@ -0,0 +1,25 @@
|
||||
+// Copyright 2022 The Chromium Authors
|
||||
+// Use of this source code is governed by a BSD-style license that can be
|
||||
+// found in the LICENSE file.
|
||||
+
|
||||
+package org.chromium.base;
|
||||
+
|
||||
+import org.chromium.build.annotations.NullMarked;
|
||||
+import org.chromium.build.annotations.Nullable;
|
||||
+
|
||||
+@NullMarked
|
||||
+public class ImmutableFlagWithDefault extends MutableFlagWithSafeDefault {
|
||||
+ private final boolean mDefaultValue;
|
||||
+ private @Nullable Boolean mInMemoryCachedValue;
|
||||
+
|
||||
+ public ImmutableFlagWithDefault(
|
||||
+ FeatureMap featureMap, String featureName, boolean defaultValue) {
|
||||
+ super(featureMap, featureName, defaultValue);
|
||||
+ mDefaultValue = defaultValue;
|
||||
+ }
|
||||
+
|
||||
+ @Override
|
||||
+ public boolean isEnabled() {
|
||||
+ return mDefaultValue;
|
||||
+ }
|
||||
+}
|
||||
diff --git a/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned.java b/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned.java
|
||||
--- a/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned.java
|
||||
+++ b/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned.java
|
||||
@@ -191,7 +247,7 @@ diff --git a/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned
|
||||
diff --git a/base/feature_list.cc b/base/feature_list.cc
|
||||
--- a/base/feature_list.cc
|
||||
+++ b/base/feature_list.cc
|
||||
@@ -43,6 +43,31 @@
|
||||
@@ -39,6 +39,31 @@
|
||||
|
||||
namespace base {
|
||||
|
||||
@@ -223,7 +279,7 @@ diff --git a/base/feature_list.cc b/base/feature_list.cc
|
||||
namespace {
|
||||
|
||||
// Pointer to the FeatureList instance singleton that was set via
|
||||
@@ -472,6 +497,46 @@ bool FeatureList::IsEnabled(const Feature& feature) {
|
||||
@@ -501,6 +526,46 @@ bool FeatureList::IsEnabled(const Feature& feature) {
|
||||
return g_feature_list_instance->IsFeatureEnabled(feature);
|
||||
}
|
||||
|
||||
@@ -270,7 +326,7 @@ diff --git a/base/feature_list.cc b/base/feature_list.cc
|
||||
// static
|
||||
bool FeatureList::IsValidFeatureOrFieldTrialName(std::string_view name) {
|
||||
return IsStringASCII(name) && name.find_first_of(",<*") == std::string::npos;
|
||||
@@ -739,6 +804,17 @@ void FeatureList::VisitFeaturesAndParams(FeatureVisitor& visitor,
|
||||
@@ -768,6 +833,17 @@ void FeatureList::VisitFeaturesAndParams(FeatureVisitor& visitor,
|
||||
|
||||
void FeatureList::FinalizeInitialization() {
|
||||
DCHECK(!initialized_);
|
||||
@@ -291,7 +347,7 @@ diff --git a/base/feature_list.cc b/base/feature_list.cc
|
||||
diff --git a/base/feature_list.h b/base/feature_list.h
|
||||
--- a/base/feature_list.h
|
||||
+++ b/base/feature_list.h
|
||||
@@ -233,8 +233,10 @@ StringStorage(const char (&feature)[N]) -> StringStorage<N - 1>;
|
||||
@@ -231,8 +231,10 @@ StringStorage(const char (&feature)[N]) -> StringStorage<N - 1>;
|
||||
struct BASE_EXPORT LOGICALLY_CONST Feature {
|
||||
constexpr Feature(const char* name,
|
||||
FeatureState default_state,
|
||||
@@ -304,7 +360,7 @@ diff --git a/base/feature_list.h b/base/feature_list.h
|
||||
#if BUILDFLAG(ENABLE_BANNED_BASE_FEATURE_PREFIX)
|
||||
if (std::string_view(name).find(BUILDFLAG(BANNED_BASE_FEATURE_PREFIX)) ==
|
||||
0) {
|
||||
@@ -261,6 +263,9 @@ struct BASE_EXPORT LOGICALLY_CONST Feature {
|
||||
@@ -259,6 +261,9 @@ struct BASE_EXPORT LOGICALLY_CONST Feature {
|
||||
// command line switch.
|
||||
const FeatureState default_state;
|
||||
|
||||
@@ -314,7 +370,7 @@ diff --git a/base/feature_list.h b/base/feature_list.h
|
||||
private:
|
||||
friend class FeatureList;
|
||||
|
||||
@@ -541,6 +546,11 @@ class BASE_EXPORT FeatureList {
|
||||
@@ -539,6 +544,11 @@ class BASE_EXPORT FeatureList {
|
||||
// instance, which is checked in builds with DCHECKs enabled.
|
||||
static bool IsEnabled(const Feature& feature);
|
||||
|
||||
@@ -326,7 +382,7 @@ diff --git a/base/feature_list.h b/base/feature_list.h
|
||||
// Some characters are not allowed to appear in feature names or the
|
||||
// associated field trial names, as they are used as special characters for
|
||||
// command-line serialization. This function checks that the strings are ASCII
|
||||
@@ -810,4 +820,88 @@ class BASE_EXPORT FeatureList {
|
||||
@@ -808,4 +818,88 @@ class BASE_EXPORT FeatureList {
|
||||
|
||||
} // namespace base
|
||||
|
||||
@@ -463,7 +519,7 @@ diff --git a/chrome/android/java/res/values/values.xml b/chrome/android/java/res
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -38,6 +38,10 @@ found in the LICENSE file.
|
||||
@@ -32,6 +32,10 @@ found in the LICENSE file.
|
||||
android:key="do_not_track"
|
||||
android:title="@string/do_not_track_title"
|
||||
android:fragment="org.chromium.chrome.browser.privacy.settings.DoNotTrackSettings" />
|
||||
@@ -477,8 +533,8 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
@@ -41,7 +41,7 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
private final ObservableSupplierImpl<String> mPageTitle = new ObservableSupplierImpl<>();
|
||||
@@ -43,7 +43,7 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
ObservableSuppliers.createMonotonic();
|
||||
|
||||
@Override
|
||||
- public void onCreatePreferences(@Nullable Bundle savedInstanceState, @Nullable String rootKey) {
|
||||
@@ -489,7 +545,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settin
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -127,7 +127,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -134,7 +134,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -501,33 +557,36 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/FragmentDependencyProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/FragmentDependencyProvider.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/FragmentDependencyProvider.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/FragmentDependencyProvider.java
|
||||
@@ -10,6 +10,7 @@ import android.os.Bundle;
|
||||
@@ -13,6 +13,7 @@ import android.os.Bundle;
|
||||
import androidx.fragment.app.Fragment;
|
||||
import androidx.fragment.app.FragmentManager;
|
||||
|
||||
+import java.util.function.Supplier;
|
||||
import org.chromium.base.supplier.ObservableSupplier;
|
||||
import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
import org.chromium.base.supplier.OneshotSupplier;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
@@ -68,24 +69,31 @@ public class FragmentDependencyProvider extends FragmentManager.FragmentLifecycl
|
||||
private final OneshotSupplier<SnackbarManager> mSnackbarManagerSupplier;
|
||||
private final OneshotSupplier<BottomSheetController> mBottomSheetControllerSupplier;
|
||||
private final ObservableSupplier<@Nullable ModalDialogManager> mModalDialogManagerSupplier;
|
||||
@@ -82,6 +83,7 @@ public class FragmentDependencyProvider extends FragmentManager.FragmentLifecycl
|
||||
// TODO(crbug.com/469772349): Simplify to Supplier<@Nullable ModalDialogManagerSupplier>
|
||||
private final MonotonicObservableSupplier<ModalDialogManager> mModalDialogManagerSupplier;
|
||||
private final Supplier<@Nullable SettingsSearchCoordinator> mSearchCoordinatorSupplier;
|
||||
+ private final Supplier<ChromeBaseSettingsFragment.RequireRestartDelegate> mRequireRestartDelegateSupplier;
|
||||
|
||||
public FragmentDependencyProvider(
|
||||
Context context,
|
||||
Profile profile,
|
||||
Activity activity,
|
||||
@@ -91,7 +93,8 @@ public class FragmentDependencyProvider extends FragmentManager.FragmentLifecycl
|
||||
OneshotSupplier<SnackbarManager> snackbarManagerSupplier,
|
||||
OneshotSupplier<BottomSheetController> bottomSheetControllerSupplier,
|
||||
- ObservableSupplier<@Nullable ModalDialogManager> modalDialogManagerSupplier) {
|
||||
+ ObservableSupplier<@Nullable ModalDialogManager> modalDialogManagerSupplier,
|
||||
MonotonicObservableSupplier<ModalDialogManager> modalDialogManagerSupplier,
|
||||
- Supplier<@Nullable SettingsSearchCoordinator> searchCoordinatorSupplier) {
|
||||
+ Supplier<@Nullable SettingsSearchCoordinator> searchCoordinatorSupplier,
|
||||
+ Supplier<ChromeBaseSettingsFragment.RequireRestartDelegate> requireRestartDelegateSupplier) {
|
||||
mContext = context;
|
||||
mActivity = activity;
|
||||
mProfile = profile;
|
||||
mSnackbarManagerSupplier = snackbarManagerSupplier;
|
||||
mWindowAndroidSupplier = windowAndroidSupplier;
|
||||
@@ -100,12 +103,17 @@ public class FragmentDependencyProvider extends FragmentManager.FragmentLifecycl
|
||||
mBottomSheetControllerSupplier = bottomSheetControllerSupplier;
|
||||
mModalDialogManagerSupplier = modalDialogManagerSupplier;
|
||||
mSearchCoordinatorSupplier = searchCoordinatorSupplier;
|
||||
+ mRequireRestartDelegateSupplier = requireRestartDelegateSupplier;
|
||||
}
|
||||
|
||||
@@ -545,41 +604,40 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/Fragme
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.settings;
|
||||
|
||||
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.settings;
|
||||
import static org.chromium.build.NullUtil.assertNonNull;
|
||||
import static org.chromium.build.NullUtil.assumeNonNull;
|
||||
|
||||
+import android.app.Activity;
|
||||
import android.annotation.SuppressLint;
|
||||
import android.app.ActivityManager;
|
||||
import android.content.Context;
|
||||
@@ -43,6 +44,7 @@ import org.chromium.base.Log;
|
||||
import org.chromium.base.metrics.RecordHistogram;
|
||||
@@ -45,6 +46,7 @@ import org.chromium.base.metrics.RecordHistogram;
|
||||
import org.chromium.base.metrics.RecordUserAction;
|
||||
import org.chromium.base.supplier.ObservableSupplier;
|
||||
import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
import org.chromium.base.supplier.ObservableSuppliers;
|
||||
+import org.chromium.base.supplier.OneshotSupplier;
|
||||
import org.chromium.base.supplier.OneshotSupplierImpl;
|
||||
import org.chromium.base.supplier.SettableMonotonicObservableSupplier;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
@@ -54,6 +56,7 @@ import org.chromium.chrome.browser.back_press.BackPressHelper.OnKeyDownHandler;
|
||||
import org.chromium.chrome.browser.feedback.HelpAndFeedbackLauncherImpl;
|
||||
@@ -59,12 +61,14 @@ import org.chromium.chrome.browser.feedback.HelpAndFeedbackLauncherImpl;
|
||||
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
||||
import org.chromium.chrome.browser.init.ActivityLifecycleDispatcherImpl;
|
||||
import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
|
||||
+import org.chromium.chrome.browser.lifetime.ApplicationLifetime;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
import org.chromium.chrome.browser.profiles.ProfileManager;
|
||||
import org.chromium.chrome.browser.profiles.ProfileManagerUtils;
|
||||
@@ -61,6 +64,7 @@ import org.chromium.chrome.browser.settings.search.SettingsSearchCoordinator;
|
||||
import org.chromium.chrome.browser.settings.search.SettingsSearchCoordinator;
|
||||
import org.chromium.chrome.browser.ui.desktop_windowing.AppHeaderCoordinator;
|
||||
import org.chromium.chrome.browser.ui.device_lock.MissingDeviceLockLauncher;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.Snackbar;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager.SnackbarManageable;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.Snackbar;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetControllerFactory;
|
||||
import org.chromium.components.browser_ui.bottomsheet.ManagedBottomSheetController;
|
||||
@@ -115,6 +119,40 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
PreferenceUpdateObserver {
|
||||
private static final String TAG = "SettingsActivity";
|
||||
import org.chromium.chrome.browser.util.DefaultBrowserInfo;
|
||||
@@ -131,6 +135,40 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
// Key used to store activity start time in the Bundle to have it survive activity re-creation.
|
||||
private static final String KEY_START_TIME = "start_time";
|
||||
|
||||
+ private static class RequestRestartDelegate implements ChromeBaseSettingsFragment.RequireRestartDelegate {
|
||||
+ private OneshotSupplier<SnackbarManager> mSnackbarManagerSupplier;
|
||||
@@ -618,12 +676,12 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/Settin
|
||||
@VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)
|
||||
public static final String EXTRA_SHOW_FRAGMENT = "show_fragment";
|
||||
|
||||
@@ -205,7 +243,8 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
mProfile,
|
||||
@@ -239,7 +277,8 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
mSnackbarManagerSupplier,
|
||||
mBottomSheetControllerSupplier,
|
||||
- getModalDialogManagerSupplier()),
|
||||
+ getModalDialogManagerSupplier(),
|
||||
getModalDialogManagerSupplier(),
|
||||
- () -> mSearchCoordinator),
|
||||
+ () -> mSearchCoordinator,
|
||||
+ () -> new RequestRestartDelegate(mSnackbarManagerSupplier, this)),
|
||||
/* recursive= */ true);
|
||||
fragmentManager.registerFragmentLifecycleCallbacks(
|
||||
@@ -631,7 +689,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/Settin
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
@@ -23,8 +23,7 @@ import org.chromium.components.browser_ui.settings.SettingsUtils;
|
||||
@@ -27,8 +27,7 @@ import org.chromium.components.browser_ui.settings.search.SettingsIndexData;
|
||||
|
||||
/** Settings fragment containing preferences aimed at Chrome and web developers. */
|
||||
@NullMarked
|
||||
@@ -641,7 +699,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/setting
|
||||
private static final String UI_PREF_BETA_STABLE_HINT = "beta_stable_hint";
|
||||
|
||||
// Non-translated strings:
|
||||
@@ -55,7 +54,7 @@ public class DeveloperSettings extends ChromeBaseSettingsFragment
|
||||
@@ -59,7 +58,7 @@ public class DeveloperSettings extends ChromeBaseSettingsFragment
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -649,11 +707,11 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/setting
|
||||
+ public void onCreatePreferencesCromite(@Nullable Bundle savedInstanceState, @Nullable String s) {
|
||||
SettingsUtils.addPreferencesFromResource(this, R.xml.developer_preferences);
|
||||
|
||||
if (VersionInfo.isBetaBuild() || VersionInfo.isStableBuild()) {
|
||||
if (shouldRemoveBetaStableHint()) {
|
||||
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
--- a/chrome/browser/about_flags.cc
|
||||
+++ b/chrome/browser/about_flags.cc
|
||||
@@ -389,6 +389,10 @@ using flags_ui::kOsLinux;
|
||||
@@ -405,6 +405,10 @@ using flags_ui::kOsLinux;
|
||||
using flags_ui::kOsMac;
|
||||
using flags_ui::kOsWin;
|
||||
|
||||
@@ -664,9 +722,9 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
namespace about_flags {
|
||||
|
||||
namespace {
|
||||
@@ -5291,6 +5295,10 @@ const FeatureEntry::Choice kOmniboxAutofocusOnIncognitoNtpChoices[] = {
|
||||
@@ -4800,6 +4804,10 @@ const FeatureEntry::FeatureVariation kSigninPromoOnAvatarPillVariation[] = {
|
||||
};
|
||||
#endif // !BUILDFLAG(IS_ANDROID)
|
||||
#endif // BUILDFLAG(ENABLE_DICE_SUPPORT)
|
||||
|
||||
+#define FEATURE_PARAM_SECTION
|
||||
+#include "cromite_flags/chrome_browser_about_flags_cc.inc"
|
||||
@@ -675,7 +733,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
// RECORDING USER METRICS FOR FLAGS:
|
||||
// -----------------------------------------------------------------------------
|
||||
// The first line of the entry is the internal name.
|
||||
@@ -5317,6 +5325,9 @@ const FeatureEntry::Choice kOmniboxAutofocusOnIncognitoNtpChoices[] = {
|
||||
@@ -4826,6 +4834,9 @@ const FeatureEntry::FeatureVariation kSigninPromoOnAvatarPillVariation[] = {
|
||||
const FeatureEntry kFeatureEntries[] = {
|
||||
// Include generated flags for flag unexpiry; see //docs/flag_expiry.md and
|
||||
// //tools/flags/generate_unexpire_flags.py.
|
||||
@@ -684,11 +742,11 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
+#undef FLAG_SECTION
|
||||
#include "build/chromeos_buildflags.h"
|
||||
#include "chrome/browser/unexpire_flags_gen.inc"
|
||||
{variations::switches::kEnableBenchmarking,
|
||||
{switches::kEnableBenchmarking, flag_descriptions::kEnableBenchmarkingName,
|
||||
diff --git a/chrome/browser/browser_features.cc b/chrome/browser/browser_features.cc
|
||||
--- a/chrome/browser/browser_features.cc
|
||||
+++ b/chrome/browser/browser_features.cc
|
||||
@@ -284,4 +284,5 @@ BASE_FEATURE(kReportPakFileIntegrity,
|
||||
@@ -265,4 +265,5 @@ BASE_FEATURE(kReportPakFileIntegrity,
|
||||
// show both in Chrome Tabs and Windows.
|
||||
BASE_FEATURE(kRemovalOfIWAsFromTabCapture, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
@@ -697,7 +755,7 @@ diff --git a/chrome/browser/browser_features.cc b/chrome/browser/browser_feature
|
||||
diff --git a/chrome/browser/browser_features.h b/chrome/browser/browser_features.h
|
||||
--- a/chrome/browser/browser_features.h
|
||||
+++ b/chrome/browser/browser_features.h
|
||||
@@ -118,6 +118,7 @@ BASE_DECLARE_FEATURE(kRemovalOfIWAsFromTabCapture);
|
||||
@@ -115,6 +115,7 @@ BASE_DECLARE_FEATURE(kRemovalOfIWAsFromTabCapture);
|
||||
// module, e.g.
|
||||
// //chrome/browser/<foo_module>/features.h
|
||||
//
|
||||
@@ -747,7 +805,7 @@ diff --git a/chrome/browser/flags/BUILD.gn b/chrome/browser/flags/BUILD.gn
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
@@ -840,6 +840,7 @@ BASE_FEATURE(kXplatSyncedSetup, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -826,6 +826,7 @@ BASE_FEATURE(kYourSavedInfoSettingsPageAndroid, base::FEATURE_DISABLED_BY_DEFAUL
|
||||
|
||||
// clang-format on
|
||||
|
||||
@@ -758,7 +816,7 @@ diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browse
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.h b/chrome/browser/flags/android/chrome_feature_list.h
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.h
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.h
|
||||
@@ -375,6 +375,7 @@ inline constexpr base::FeatureParam<bool>
|
||||
@@ -381,6 +381,7 @@ inline constexpr base::FeatureParam<bool>
|
||||
"snippet_as_subtitle",
|
||||
/*default_value=*/false);
|
||||
|
||||
@@ -780,7 +838,7 @@ diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/f
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
|
||||
@@ -1118,7 +1122,7 @@ public abstract class ChromeFeatureList {
|
||||
@@ -1138,7 +1142,7 @@ public abstract class ChromeFeatureList {
|
||||
newCachedFlag(WEB_APK_MIN_SHELL_APK_VERSION, true);
|
||||
// keep-sorted end
|
||||
|
||||
@@ -789,7 +847,7 @@ diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/f
|
||||
List.of(
|
||||
// keep-sorted start
|
||||
sAccountForSuppressedKeyboardInsets,
|
||||
@@ -1282,6 +1286,13 @@ public abstract class ChromeFeatureList {
|
||||
@@ -1304,6 +1308,13 @@ public abstract class ChromeFeatureList {
|
||||
// keep-sorted end
|
||||
);
|
||||
|
||||
@@ -969,16 +1027,16 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/ui/ui_features.cc b/chrome/browser/ui/ui_features.cc
|
||||
--- a/chrome/browser/ui/ui_features.cc
|
||||
+++ b/chrome/browser/ui/ui_features.cc
|
||||
@@ -788,4 +788,5 @@ BASE_FEATURE(kWhatsNewDesktopRefresh, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kTabGroupsFocusing, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -534,4 +534,5 @@ BASE_FEATURE_PARAM(bool,
|
||||
BASE_FEATURE(kUpdaterUI, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
#endif
|
||||
|
||||
+#include "cromite_flags/chrome_browser_ui_ui_features_cc.inc"
|
||||
} // namespace features
|
||||
diff --git a/chrome/browser/unexpire_flags.cc b/chrome/browser/unexpire_flags.cc
|
||||
--- a/chrome/browser/unexpire_flags.cc
|
||||
+++ b/chrome/browser/unexpire_flags.cc
|
||||
@@ -11,6 +11,7 @@
|
||||
@@ -10,6 +10,7 @@
|
||||
#include "base/containers/flat_map.h"
|
||||
#include "base/feature_list.h"
|
||||
#include "base/no_destructor.h"
|
||||
@@ -986,7 +1044,7 @@ diff --git a/chrome/browser/unexpire_flags.cc b/chrome/browser/unexpire_flags.cc
|
||||
#include "chrome/browser/expired_flags_list.h"
|
||||
#include "chrome/browser/unexpire_flags_gen.h"
|
||||
#include "chrome/common/chrome_version.h"
|
||||
@@ -117,7 +118,19 @@ bool IsFlagExpired(const flags_ui::FlagsStorage* storage,
|
||||
@@ -116,7 +117,19 @@ bool IsFlagExpired(const flags_ui::FlagsStorage* storage,
|
||||
|
||||
// Otherwise, the flag is expired if its expiration mstone is less than the
|
||||
// mstone of this copy of Chromium.
|
||||
@@ -1010,11 +1068,10 @@ diff --git a/chrome/browser/unexpire_flags.cc b/chrome/browser/unexpire_flags.cc
|
||||
diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc
|
||||
--- a/chrome/common/chrome_features.cc
|
||||
+++ b/chrome/common/chrome_features.cc
|
||||
@@ -1906,5 +1906,5 @@ BASE_FEATURE(kDisableShortcutsEnableDiy, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
// happen silently without prompting an updating dialog.
|
||||
BASE_FEATURE(kSilentPolicyAndDefaultAppUpdating,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
-
|
||||
@@ -2030,4 +2030,5 @@ BASE_FEATURE(kUnicornChromeActivityReporting,
|
||||
BASE_FEATURE(kSmartRestartMetrics, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
#endif // BUILDFLAG(IS_ANDROID)
|
||||
|
||||
+#include "cromite_flags/chrome_common_chrome_features_cc.inc"
|
||||
} // namespace features
|
||||
diff --git a/components/browser_ui/accessibility/android/BUILD.gn b/components/browser_ui/accessibility/android/BUILD.gn
|
||||
@@ -1044,7 +1101,7 @@ diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibil
|
||||
diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
--- a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
+++ b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
@@ -30,9 +30,11 @@ import org.chromium.content_public.browser.ContentFeatureList;
|
||||
@@ -38,9 +38,11 @@ import org.chromium.content_public.browser.ContentFeatureList;
|
||||
import org.chromium.content_public.browser.ContentFeatureMap;
|
||||
import org.chromium.ui.base.UiAndroidFeatureList;
|
||||
|
||||
@@ -1057,7 +1114,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
implements EmbeddableSettingsPage,
|
||||
Preference.OnPreferenceChangeListener,
|
||||
CustomDividerFragment {
|
||||
@@ -78,7 +80,7 @@ public class AccessibilitySettings extends PreferenceFragmentCompat
|
||||
@@ -109,7 +111,7 @@ public class AccessibilitySettings extends PreferenceFragmentCompat
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -1083,7 +1140,7 @@ diff --git a/components/browser_ui/settings/android/java/res/values/attrs.xml b/
|
||||
diff --git a/components/browser_ui/settings/android/widget/java/src/org/chromium/components/browser_ui/settings/ChromeSwitchPreference.java b/components/browser_ui/settings/android/widget/java/src/org/chromium/components/browser_ui/settings/ChromeSwitchPreference.java
|
||||
--- a/components/browser_ui/settings/android/widget/java/src/org/chromium/components/browser_ui/settings/ChromeSwitchPreference.java
|
||||
+++ b/components/browser_ui/settings/android/widget/java/src/org/chromium/components/browser_ui/settings/ChromeSwitchPreference.java
|
||||
@@ -15,6 +15,8 @@ import android.view.accessibility.AccessibilityEvent;
|
||||
@@ -14,6 +14,8 @@ import android.view.accessibility.AccessibilityEvent;
|
||||
import android.view.accessibility.AccessibilityNodeInfo;
|
||||
import android.widget.TextView;
|
||||
|
||||
@@ -1092,7 +1149,7 @@ diff --git a/components/browser_ui/settings/android/widget/java/src/org/chromium
|
||||
import androidx.annotation.ColorInt;
|
||||
import androidx.annotation.VisibleForTesting;
|
||||
import androidx.preference.PreferenceViewHolder;
|
||||
@@ -42,6 +44,11 @@ public class ChromeSwitchPreference extends SwitchPreferenceCompat implements Co
|
||||
@@ -38,6 +40,11 @@ public class ChromeSwitchPreference extends SwitchPreferenceCompat implements Co
|
||||
/** Indicates if the preference uses a custom layout. */
|
||||
private final boolean mHasCustomLayout;
|
||||
|
||||
@@ -1104,7 +1161,7 @@ diff --git a/components/browser_ui/settings/android/widget/java/src/org/chromium
|
||||
// TOOD(crbug.com/1451550): This is an interim solution. In the long-term, we should migrate
|
||||
// away from a switch with dynamically changing summaries onto a radio group.
|
||||
/**
|
||||
@@ -66,6 +73,18 @@ public class ChromeSwitchPreference extends SwitchPreferenceCompat implements Co
|
||||
@@ -62,6 +69,18 @@ public class ChromeSwitchPreference extends SwitchPreferenceCompat implements Co
|
||||
|
||||
mHasCustomLayout = ManagedPreferencesUtils.isCustomLayoutApplied(context, attrs);
|
||||
mUseSummaryAsTitle = true;
|
||||
@@ -1126,7 +1183,7 @@ diff --git a/components/browser_ui/settings/android/widget/java/src/org/chromium
|
||||
diff --git a/components/cached_flags/android/java/src/org/chromium/components/cached_flags/CachedFlag.java b/components/cached_flags/android/java/src/org/chromium/components/cached_flags/CachedFlag.java
|
||||
--- a/components/cached_flags/android/java/src/org/chromium/components/cached_flags/CachedFlag.java
|
||||
+++ b/components/cached_flags/android/java/src/org/chromium/components/cached_flags/CachedFlag.java
|
||||
@@ -159,7 +159,7 @@ public class CachedFlag extends Flag {
|
||||
@@ -162,7 +162,7 @@ public class CachedFlag extends Flag {
|
||||
editor.putBoolean(getSharedPreferenceKey(), featureValue);
|
||||
}
|
||||
|
||||
@@ -1135,7 +1192,7 @@ diff --git a/components/cached_flags/android/java/src/org/chromium/components/ca
|
||||
// Create the key only once to avoid String concatenation every flag check.
|
||||
if (mPreferenceKey == null) {
|
||||
mPreferenceKey = CachedFlagsSharedPreferences.FLAGS_CACHED.createKey(mFeatureName);
|
||||
@@ -167,6 +167,12 @@ public class CachedFlag extends Flag {
|
||||
@@ -170,6 +170,12 @@ public class CachedFlag extends Flag {
|
||||
return mPreferenceKey;
|
||||
}
|
||||
|
||||
@@ -1162,7 +1219,7 @@ diff --git a/components/components_strings.grd b/components/components_strings.g
|
||||
diff --git a/components/content_settings/core/common/features.cc b/components/content_settings/core/common/features.cc
|
||||
--- a/components/content_settings/core/common/features.cc
|
||||
+++ b/components/content_settings/core/common/features.cc
|
||||
@@ -143,5 +143,6 @@ const base::FeatureParam<EnableForIframeTypes>
|
||||
@@ -137,5 +137,6 @@ const base::FeatureParam<EnableForIframeTypes>
|
||||
|
||||
BASE_FEATURE(kForceAllowStorageAccess, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
@@ -1198,17 +1255,17 @@ diff --git a/components/offline_pages/core/offline_page_feature.h b/components/o
|
||||
diff --git a/components/password_manager/core/browser/features/password_features.cc b/components/password_manager/core/browser/features/password_features.cc
|
||||
--- a/components/password_manager/core/browser/features/password_features.cc
|
||||
+++ b/components/password_manager/core/browser/features/password_features.cc
|
||||
@@ -201,4 +201,5 @@ BASE_FEATURE(kRetrieveTrustedVaultKeyKeyboardAccessoryAction,
|
||||
BASE_FEATURE(kUseActionablesForImprovedPasswordChange,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -200,4 +200,5 @@ BASE_FEATURE(kWebAuthnUsePasskeyFromAnotherDeviceInContextMenu,
|
||||
|
||||
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
|
||||
|
||||
+#include "cromite_flags/components_password_manager_core_browser_features_password_features_cc.inc"
|
||||
} // namespace password_manager::features
|
||||
diff --git a/components/permissions/features.cc b/components/permissions/features.cc
|
||||
--- a/components/permissions/features.cc
|
||||
+++ b/components/permissions/features.cc
|
||||
@@ -120,6 +120,7 @@ BASE_FEATURE(kReturnDeniedForNotificationsWhenNoAppLevelSettings,
|
||||
BASE_FEATURE(kPermissionPredictionsGeolocationAccuracy,
|
||||
@@ -117,6 +117,7 @@ BASE_FEATURE(kPermissionPredictionsGeolocationAccuracy,
|
||||
BASE_FEATURE(kPermissionsGestureGatedPrompts,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
+#include "cromite_flags/components_permissions_features_cc.inc"
|
||||
@@ -1260,7 +1317,7 @@ diff --git a/components/variations/synthetic_trials_active_group_id_provider.h b
|
||||
diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flags_state.cc
|
||||
--- a/components/webui/flags/flags_state.cc
|
||||
+++ b/components/webui/flags/flags_state.cc
|
||||
@@ -377,6 +377,21 @@ void FlagsState::GetSwitchesAndFeaturesFromFlags(
|
||||
@@ -373,6 +373,21 @@ void FlagsState::GetSwitchesAndFeaturesFromFlags(
|
||||
|
||||
for (const std::string& entry_name : enabled_entries) {
|
||||
const auto& entry_it = name_to_switch_map.find(entry_name);
|
||||
@@ -1282,7 +1339,7 @@ diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flag
|
||||
CHECK(entry_it != name_to_switch_map.end());
|
||||
|
||||
const SwitchEntry& entry = entry_it->second;
|
||||
@@ -710,6 +725,27 @@ void FlagsState::GetFlagFeatureEntries(
|
||||
@@ -704,6 +719,27 @@ void FlagsState::GetFlagFeatureEntries(
|
||||
data.Set("links", std::move(links));
|
||||
}
|
||||
|
||||
@@ -1310,7 +1367,7 @@ diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flag
|
||||
switch (entry.type) {
|
||||
case FeatureEntry::SINGLE_VALUE:
|
||||
case FeatureEntry::SINGLE_DISABLE_VALUE:
|
||||
@@ -837,6 +873,16 @@ void FlagsState::AddSwitchesToCommandLine(
|
||||
@@ -831,6 +867,16 @@ void FlagsState::AddSwitchesToCommandLine(
|
||||
for (const std::string& entry_name : enabled_entries) {
|
||||
const auto& entry_it = name_to_switch_map.find(entry_name);
|
||||
if (entry_it == name_to_switch_map.end()) {
|
||||
@@ -1327,7 +1384,7 @@ diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flag
|
||||
NOTREACHED();
|
||||
}
|
||||
|
||||
@@ -1093,6 +1139,14 @@ const FeatureEntry* FlagsState::FindFeatureEntryByName(
|
||||
@@ -1102,6 +1148,14 @@ const FeatureEntry* FlagsState::FindFeatureEntryByName(
|
||||
bool FlagsState::IsSupportedFeature(const FlagsStorage* storage,
|
||||
const std::string& name,
|
||||
int platform_mask) const {
|
||||
@@ -1342,7 +1399,7 @@ diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flag
|
||||
for (const auto& entry : feature_entries_) {
|
||||
DCHECK(entry.IsValid());
|
||||
if (!(entry.supported_platforms & platform_mask)) {
|
||||
@@ -1131,6 +1185,11 @@ void FlagsState::SetFlags(
|
||||
@@ -1140,6 +1194,11 @@ void FlagsState::SetFlags(
|
||||
FindFeatureEntryByName(feature_internal_name);
|
||||
// Since this flag is currently enabled, we know for sure that we can find
|
||||
// its feature entry using its internal name.
|
||||
@@ -1357,31 +1414,39 @@ diff --git a/components/webui/flags/flags_state.cc b/components/webui/flags/flag
|
||||
diff --git a/components/webui/flags/resources/app.css b/components/webui/flags/resources/app.css
|
||||
--- a/components/webui/flags/resources/app.css
|
||||
+++ b/components/webui/flags/resources/app.css
|
||||
@@ -391,3 +391,27 @@ cr-tabs {
|
||||
@@ -391,3 +391,35 @@ cr-tabs {
|
||||
padding-top: 1.5rem;
|
||||
}
|
||||
}
|
||||
+
|
||||
+#appcontainer {
|
||||
+ overflow-y: scroll;
|
||||
+}
|
||||
+
|
||||
+.cromite #header {
|
||||
+ display: none;
|
||||
+}
|
||||
+
|
||||
+.cromite .blurb-container {
|
||||
+ display: none;
|
||||
+}
|
||||
+
|
||||
+.cromite #tabs {
|
||||
+ display: none;
|
||||
+}
|
||||
+
|
||||
+.cromite #tab-content-available {
|
||||
+ display: none;
|
||||
+}
|
||||
+
|
||||
+.cromite #tab-content-unavailable {
|
||||
+ display: none;
|
||||
+}
|
||||
+
|
||||
+.cromite #tab-content-cromite {
|
||||
+ display: block !important;
|
||||
+}
|
||||
+
|
||||
+.cromite .section-header-title {
|
||||
+ display: none;
|
||||
+}
|
||||
@@ -1461,7 +1526,19 @@ diff --git a/components/webui/flags/resources/app.ts b/components/webui/flags/re
|
||||
private announceStatusDelayMs: number = 100;
|
||||
private featuresResolver: PromiseResolver<void> = new PromiseResolver();
|
||||
private flagSearch: FlagSearch|null = null;
|
||||
@@ -186,10 +190,25 @@ export class FlagsAppElement extends CrLitElement {
|
||||
@@ -180,6 +184,11 @@ export class FlagsAppElement extends CrLitElement {
|
||||
override connectedCallback() {
|
||||
super.connectedCallback();
|
||||
|
||||
+ if (location.pathname == '/cromite') {
|
||||
+ this.onlyCromiteFlags = true;
|
||||
+ this.getRequiredElement("#appcontainer").classList.add('cromite');
|
||||
+ document.title = "Cromite Flags List";
|
||||
+ }
|
||||
// <if expr="not is_ios">
|
||||
const pathname = new URL(window.location.href).pathname;
|
||||
this.isFlagsDeprecatedUrl_ =
|
||||
@@ -252,10 +261,25 @@ export class FlagsAppElement extends CrLitElement {
|
||||
if (changedPrivateProperties.has('data')) {
|
||||
const defaultFeatures: Feature[] = [];
|
||||
const nonDefaultFeatures: Feature[] = [];
|
||||
@@ -1487,18 +1564,6 @@ diff --git a/components/webui/flags/resources/app.ts b/components/webui/flags/re
|
||||
this.defaultFeatures = defaultFeatures;
|
||||
this.nonDefaultFeatures = nonDefaultFeatures;
|
||||
|
||||
@@ -233,6 +252,11 @@ export class FlagsAppElement extends CrLitElement {
|
||||
override connectedCallback() {
|
||||
super.connectedCallback();
|
||||
|
||||
+ if (location.pathname == '/cromite') {
|
||||
+ this.onlyCromiteFlags = true;
|
||||
+ this.getRequiredElement("#appcontainer").classList.add('cromite');
|
||||
+ document.title = "Cromite Flags List";
|
||||
+ }
|
||||
// <if expr="not is_ios">
|
||||
const pathname = new URL(window.location.href).pathname;
|
||||
this.isFlagsDeprecatedUrl_ =
|
||||
diff --git a/components/webui/flags/resources/experiment.css b/components/webui/flags/resources/experiment.css
|
||||
--- a/components/webui/flags/resources/experiment.css
|
||||
+++ b/components/webui/flags/resources/experiment.css
|
||||
@@ -1515,7 +1580,7 @@ diff --git a/components/webui/flags/resources/experiment.css b/components/webui/
|
||||
}
|
||||
|
||||
+.experiment-on select {
|
||||
+ background: #dddddd;
|
||||
+ background: #ddd;
|
||||
+ color: var(--link-color);
|
||||
+}
|
||||
+
|
||||
@@ -1573,7 +1638,7 @@ diff --git a/components/webui/flags/resources/experiment.html.ts b/components/we
|
||||
diff --git a/components/webui/flags/resources/experiment.ts b/components/webui/flags/resources/experiment.ts
|
||||
--- a/components/webui/flags/resources/experiment.ts
|
||||
+++ b/components/webui/flags/resources/experiment.ts
|
||||
@@ -81,6 +81,11 @@ export class ExperimentElement extends CrLitElement {
|
||||
@@ -85,6 +85,11 @@ export class ExperimentElement extends CrLitElement {
|
||||
enabled: false,
|
||||
is_default: false,
|
||||
supported_platforms: [],
|
||||
@@ -1585,7 +1650,7 @@ diff --git a/components/webui/flags/resources/experiment.ts b/components/webui/f
|
||||
};
|
||||
|
||||
// Whether the controls to change the experiment state should be hidden.
|
||||
@@ -121,9 +126,12 @@ export class ExperimentElement extends CrLitElement {
|
||||
@@ -125,9 +130,12 @@ export class ExperimentElement extends CrLitElement {
|
||||
}
|
||||
|
||||
protected getExperimentTitle_(): string {
|
||||
@@ -1627,7 +1692,7 @@ diff --git a/components/webui/version/version_handler_helper.cc b/components/web
|
||||
std::string GetActiveGroupNameAsString(
|
||||
const base::FieldTrial::ActiveGroup& group) {
|
||||
static const unsigned char kNonBreakingHyphenUTF8[] = {0xE2, 0x80, 0x91,
|
||||
@@ -56,7 +56,7 @@ base::Value::List GetVariationsList() {
|
||||
@@ -56,7 +56,7 @@ base::ListValue GetVariationsList() {
|
||||
base::FieldTrialListIncludingLowAnonymity::GetActiveFieldTrialGroups(
|
||||
&active_groups);
|
||||
|
||||
@@ -1639,7 +1704,7 @@ diff --git a/components/webui/version/version_handler_helper.cc b/components/web
|
||||
diff --git a/content/common/features.cc b/content/common/features.cc
|
||||
--- a/content/common/features.cc
|
||||
+++ b/content/common/features.cc
|
||||
@@ -750,4 +750,5 @@ bool IsEnforceSameDocumentOriginInvariantsEnabled() {
|
||||
@@ -763,4 +763,5 @@ bool IsEnforceSameDocumentOriginInvariantsEnabled() {
|
||||
blink::features::kTreatMhtmlInitialDocumentLoadsAsCrossDocument);
|
||||
}
|
||||
|
||||
@@ -1648,18 +1713,18 @@ diff --git a/content/common/features.cc b/content/common/features.cc
|
||||
diff --git a/content/public/common/content_features.cc b/content/public/common/content_features.cc
|
||||
--- a/content/public/common/content_features.cc
|
||||
+++ b/content/public/common/content_features.cc
|
||||
@@ -1438,4 +1438,5 @@ bool IsPushSubscriptionChangeEventEnabled() {
|
||||
features::kPushSubscriptionChangeEventOnResubscribe);
|
||||
@@ -1494,4 +1494,5 @@ bool IsFluidResizeEnabled() {
|
||||
}
|
||||
#endif
|
||||
|
||||
+#include "cromite_flags/content_public_common_content_features_cc.inc"
|
||||
} // namespace features
|
||||
diff --git a/content/public/common/content_features.h b/content/public/common/content_features.h
|
||||
--- a/content/public/common/content_features.h
|
||||
+++ b/content/public/common/content_features.h
|
||||
@@ -420,6 +420,7 @@ CONTENT_EXPORT bool IsVideoCaptureServiceEnabledForOutOfProcess();
|
||||
CONTENT_EXPORT bool IsVideoCaptureServiceEnabledForBrowserProcess();
|
||||
CONTENT_EXPORT bool IsPushSubscriptionChangeEventEnabled();
|
||||
@@ -440,6 +440,7 @@ CONTENT_EXPORT bool IsPushSubscriptionChangeEventEnabled();
|
||||
CONTENT_EXPORT bool IsFluidResizeEnabled();
|
||||
#endif
|
||||
|
||||
+#include "cromite_flags/content_public_common_content_features_h.inc"
|
||||
} // namespace features
|
||||
@@ -2003,7 +2068,7 @@ new file mode 100755
|
||||
diff --git a/media/base/media_switches.cc b/media/base/media_switches.cc
|
||||
--- a/media/base/media_switches.cc
|
||||
+++ b/media/base/media_switches.cc
|
||||
@@ -1750,5 +1750,5 @@ uint32_t GetPassthroughAudioFormats() {
|
||||
@@ -1850,5 +1850,5 @@ uint32_t GetPassthroughAudioFormats() {
|
||||
return 0;
|
||||
#endif // BUILDFLAG(ENABLE_PASSTHROUGH_AUDIO_CODECS)
|
||||
}
|
||||
@@ -2013,7 +2078,7 @@ diff --git a/media/base/media_switches.cc b/media/base/media_switches.cc
|
||||
diff --git a/media/base/media_switches.h b/media/base/media_switches.h
|
||||
--- a/media/base/media_switches.h
|
||||
+++ b/media/base/media_switches.h
|
||||
@@ -556,5 +556,5 @@ MEDIA_EXPORT bool IsOutOfProcessVideoDecodingEnabled();
|
||||
@@ -590,5 +590,5 @@ MEDIA_EXPORT bool IsOutOfProcessVideoDecodingEnabled();
|
||||
MEDIA_EXPORT uint32_t GetPassthroughAudioFormats();
|
||||
|
||||
} // namespace media
|
||||
@@ -2023,18 +2088,18 @@ diff --git a/media/base/media_switches.h b/media/base/media_switches.h
|
||||
diff --git a/net/base/features.cc b/net/base/features.cc
|
||||
--- a/net/base/features.cc
|
||||
+++ b/net/base/features.cc
|
||||
@@ -846,4 +846,5 @@ BASE_FEATURE(kAddAutomaticWithDohFallbackMode,
|
||||
BASE_FEATURE(kUseQuicProxiesWithoutWaitingForConnectResponse,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -777,4 +777,5 @@ BASE_FEATURE(kDrainSpdySessionSynchronouslyOnRemoteEndpointDisconnect,
|
||||
|
||||
BASE_FEATURE(kLogicalClearHttpCache, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
+#include "cromite_flags/net_base_features_cc.inc"
|
||||
} // namespace net::features
|
||||
diff --git a/net/base/features.h b/net/base/features.h
|
||||
--- a/net/base/features.h
|
||||
+++ b/net/base/features.h
|
||||
@@ -911,6 +911,7 @@ NET_EXPORT BASE_DECLARE_FEATURE(kAddAutomaticWithDohFallbackMode);
|
||||
@@ -807,6 +807,7 @@ NET_EXPORT BASE_DECLARE_FEATURE(kLogicalClearHttpCache);
|
||||
NET_EXPORT BASE_DECLARE_FEATURE(
|
||||
kUseQuicProxiesWithoutWaitingForConnectResponse);
|
||||
kDrainSpdySessionSynchronouslyOnRemoteEndpointDisconnect);
|
||||
|
||||
+#include "cromite_flags/net_base_features_h.inc"
|
||||
} // namespace net::features
|
||||
@@ -2043,18 +2108,18 @@ diff --git a/net/base/features.h b/net/base/features.h
|
||||
diff --git a/services/network/public/cpp/features.cc b/services/network/public/cpp/features.cc
|
||||
--- a/services/network/public/cpp/features.cc
|
||||
+++ b/services/network/public/cpp/features.cc
|
||||
@@ -611,4 +611,5 @@ BASE_FEATURE(kNetworkServicePerPriorityTaskQueues,
|
||||
BASE_FEATURE(kUseUnexportableKeyServiceInBrowserProcess,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -662,4 +662,5 @@ BASE_FEATURE_PARAM(int,
|
||||
/*name=*/"max_global_buffer_size",
|
||||
/*default_value=*/0);
|
||||
|
||||
+#include "cromite_flags/services_network_public_cpp_features_cc.inc"
|
||||
} // namespace network::features
|
||||
diff --git a/services/network/public/cpp/features.h b/services/network/public/cpp/features.h
|
||||
--- a/services/network/public/cpp/features.h
|
||||
+++ b/services/network/public/cpp/features.h
|
||||
@@ -383,6 +383,7 @@ BASE_DECLARE_FEATURE(kNetworkServicePerPriorityTaskQueues);
|
||||
@@ -434,6 +434,7 @@ BASE_DECLARE_FEATURE_PARAM(int, kDurableMessagesGlobalBufferSize);
|
||||
COMPONENT_EXPORT(NETWORK_CPP_FLAGS_AND_SWITCHES)
|
||||
BASE_DECLARE_FEATURE(kUseUnexportableKeyServiceInBrowserProcess);
|
||||
BASE_DECLARE_FEATURE(kBypassRequestForbiddenHeadersCheck);
|
||||
|
||||
+#include "cromite_flags/services_network_public_cpp_features_h.inc"
|
||||
} // namespace network::features
|
||||
@@ -2063,7 +2128,7 @@ diff --git a/services/network/public/cpp/features.h b/services/network/public/cp
|
||||
diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
|
||||
--- a/third_party/blink/common/features.cc
|
||||
+++ b/third_party/blink/common/features.cc
|
||||
@@ -2647,4 +2647,5 @@ bool IsXrDevice() {
|
||||
@@ -2773,4 +2773,5 @@ bool IsXrDevice() {
|
||||
//
|
||||
// DO NOT ADD NEW FEATURES HERE.
|
||||
|
||||
@@ -2072,7 +2137,7 @@ diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/fea
|
||||
diff --git a/third_party/blink/public/common/features.h b/third_party/blink/public/common/features.h
|
||||
--- a/third_party/blink/public/common/features.h
|
||||
+++ b/third_party/blink/public/common/features.h
|
||||
@@ -1960,6 +1960,7 @@ BLINK_COMMON_EXPORT bool IsXrDevice();
|
||||
@@ -2018,6 +2018,7 @@ BLINK_COMMON_EXPORT bool IsXrDevice();
|
||||
//
|
||||
// DO NOT ADD NEW FEATURES HERE.
|
||||
|
||||
@@ -2083,18 +2148,18 @@ diff --git a/third_party/blink/public/common/features.h b/third_party/blink/publ
|
||||
diff --git a/ui/base/ui_base_features.cc b/ui/base/ui_base_features.cc
|
||||
--- a/ui/base/ui_base_features.cc
|
||||
+++ b/ui/base/ui_base_features.cc
|
||||
@@ -449,4 +449,5 @@ BASE_FEATURE(kUseSystemDefaultAccentColors, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kStringWidthCache, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -456,4 +456,5 @@ BASE_FEATURE_PARAM(int,
|
||||
"acceptable_latency_ms",
|
||||
50);
|
||||
|
||||
+#include "cromite_flags/ui_base_features_cc.inc"
|
||||
} // namespace features
|
||||
diff --git a/ui/base/ui_base_features.h b/ui/base/ui_base_features.h
|
||||
--- a/ui/base/ui_base_features.h
|
||||
+++ b/ui/base/ui_base_features.h
|
||||
@@ -270,6 +270,7 @@ BASE_DECLARE_FEATURE(kUseSystemDefaultAccentColors);
|
||||
@@ -294,6 +294,7 @@ BASE_DECLARE_FEATURE_PARAM(int, kCompensationExpectedLatencyMs);
|
||||
COMPONENT_EXPORT(UI_BASE_FEATURES)
|
||||
BASE_DECLARE_FEATURE(kStringWidthCache);
|
||||
BASE_DECLARE_FEATURE_PARAM(int, kCompensationAcceptableLatencyMs);
|
||||
|
||||
+#include "cromite_flags/ui_base_features_h.inc"
|
||||
} // namespace features
|
||||
|
||||
@@ -73,7 +73,7 @@ diff --git a/chrome/android/java/res/xml/developer_preferences.xml b/chrome/andr
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
|
||||
@@ -149,6 +149,7 @@ import org.chromium.ui.base.SelectFileDialog;
|
||||
@@ -146,6 +146,7 @@ import org.chromium.ui.base.SelectFileDialog;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
import org.chromium.ui.edge_to_edge.EdgeToEdgeStateProvider;
|
||||
import org.chromium.url.GURL;
|
||||
@@ -81,7 +81,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessIni
|
||||
|
||||
import java.io.File;
|
||||
import java.nio.charset.StandardCharsets;
|
||||
@@ -729,7 +730,10 @@ public class ProcessInitializationHandler {
|
||||
@@ -699,7 +700,10 @@ public class ProcessInitializationHandler {
|
||||
|
||||
tasks.add(
|
||||
() -> {
|
||||
@@ -96,9 +96,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessIni
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
|
||||
@@ -35,7 +35,7 @@ public class DeveloperSettings extends ChromeBaseSettingsFragment implements Emb
|
||||
private final ObservableSupplier<String> mPageTitle =
|
||||
new ObservableSupplierImpl<>(MSG_DEVELOPER_OPTIONS_TITLE);
|
||||
@@ -39,7 +39,7 @@ public class DeveloperSettings extends ChromeBaseSettingsFragment implements Emb
|
||||
private final NonNullObservableSupplier<String> mPageTitle =
|
||||
ObservableSuppliers.createNonNull(MSG_DEVELOPER_OPTIONS_TITLE);
|
||||
|
||||
- private static @Nullable Boolean sIsEnabledForTests;
|
||||
+ private static @Nullable Boolean sIsEnabledForTests = true;
|
||||
@@ -108,7 +108,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/setting
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -190,6 +190,11 @@ source_set("shell_integration") {
|
||||
@@ -193,6 +193,11 @@ source_set("shell_integration") {
|
||||
# require many files from it. This makes linking more efficient.
|
||||
static_library("browser") {
|
||||
sources = [
|
||||
@@ -179,7 +179,7 @@ diff --git a/chrome/browser/chrome_content_browser_client_receiver_bindings.cc b
|
||||
#include "chrome/browser/chrome_browser_interface_binders_webui.h"
|
||||
#include "chrome/browser/chrome_content_browser_client.h"
|
||||
#include "chrome/browser/chrome_content_browser_client_parts.h"
|
||||
@@ -492,6 +493,15 @@ void ChromeContentBrowserClient::
|
||||
@@ -488,6 +489,15 @@ void ChromeContentBrowserClient::
|
||||
render_frame_host);
|
||||
},
|
||||
&render_frame_host));
|
||||
@@ -237,7 +237,7 @@ new file mode 100644
|
||||
+
|
||||
+ update_client::CrxUpdateItem item;
|
||||
+ if (component_updater->GetComponentDetails(id, &item) && item.component) {
|
||||
+ base::Value::Dict dict;
|
||||
+ base::DictValue dict;
|
||||
+ dict.Set("id", id);
|
||||
+ dict.Set("version", item.component->version.GetString());
|
||||
+ dict.Set("status", (int)item.state);
|
||||
@@ -412,7 +412,7 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/permissions/NotificationPermissionController.java b/chrome/browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/permissions/NotificationPermissionController.java
|
||||
--- a/chrome/browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/permissions/NotificationPermissionController.java
|
||||
+++ b/chrome/browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/permissions/NotificationPermissionController.java
|
||||
@@ -181,6 +181,7 @@ public class NotificationPermissionController {
|
||||
@@ -175,6 +175,7 @@ public class NotificationPermissionController {
|
||||
* @return True if any UI was shown (either rationale dialog or OS prompt), false otherwise.
|
||||
*/
|
||||
public boolean requestPermissionIfNeeded(boolean contextual) {
|
||||
@@ -423,7 +423,7 @@ diff --git a/chrome/browser/notifications/android/java/src/org/chromium/chrome/b
|
||||
diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc b/chrome/browser/ui/startup/bad_flags_prompt.cc
|
||||
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
|
||||
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
|
||||
@@ -220,6 +220,7 @@ static const std::variant<const base::Feature*, const char*>
|
||||
@@ -221,6 +221,7 @@ static const std::variant<const base::Feature*, const char*>
|
||||
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
&chrome::android::kCommandLineOnNonRooted,
|
||||
@@ -435,7 +435,7 @@ diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
|
||||
--- a/chrome/common/BUILD.gn
|
||||
+++ b/chrome/common/BUILD.gn
|
||||
@@ -666,6 +666,7 @@ mojom("mojo_bindings") {
|
||||
sources = [
|
||||
"actor.mojom",
|
||||
"chrome_render_frame.mojom",
|
||||
"google_accounts_private_api_extension.mojom",
|
||||
+ "cromite_private_api_extension.mojom",
|
||||
@@ -457,7 +457,7 @@ new file mode 100644
|
||||
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
|
||||
--- a/chrome/renderer/BUILD.gn
|
||||
+++ b/chrome/renderer/BUILD.gn
|
||||
@@ -79,6 +79,8 @@ static_library("renderer") {
|
||||
@@ -81,6 +81,8 @@ static_library("renderer") {
|
||||
"chrome_render_thread_observer.cc",
|
||||
"chrome_render_thread_observer.h",
|
||||
"custom_menu_commands.h",
|
||||
@@ -477,7 +477,7 @@ diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer
|
||||
#include "chrome/renderer/google_accounts_private_api_extension.h"
|
||||
#include "chrome/renderer/loadtimes_extension_bindings.h"
|
||||
#include "chrome/renderer/media/flash_embed_rewrite.h"
|
||||
@@ -650,6 +651,7 @@ void ChromeContentRendererClient::RenderFrameCreated(
|
||||
@@ -662,6 +663,7 @@ void ChromeContentRendererClient::RenderFrameCreated(
|
||||
|
||||
TrustedVaultEncryptionKeysExtension::Create(render_frame);
|
||||
GoogleAccountsPrivateApiExtension::Create(render_frame);
|
||||
@@ -766,7 +766,7 @@ new file mode 100644
|
||||
diff --git a/components/component_updater/component_updater_service.h b/components/component_updater/component_updater_service.h
|
||||
--- a/components/component_updater/component_updater_service.h
|
||||
+++ b/components/component_updater/component_updater_service.h
|
||||
@@ -242,6 +242,7 @@ class OnDemandUpdater {
|
||||
@@ -243,6 +243,7 @@ class OnDemandUpdater {
|
||||
// the update will be applied. The caller can subscribe to component update
|
||||
// service notifications and provide an optional callback to get the result
|
||||
// of the call. The function does not implement any cooldown interval.
|
||||
@@ -793,15 +793,15 @@ diff --git a/content/browser/devtools/devtools_http_handler.cc b/content/browser
|
||||
#include "content/public/common/content_switches.h"
|
||||
#include "content/public/common/url_constants.h"
|
||||
#include "net/base/io_buffer.h"
|
||||
@@ -602,9 +604,12 @@ void DevToolsHttpHandler::OnJsonRequest(
|
||||
@@ -610,9 +612,12 @@ void DevToolsHttpHandler::OnJsonRequest(
|
||||
|
||||
if (command == "version") {
|
||||
base::Value::Dict version;
|
||||
base::DictValue version;
|
||||
+ auto browser = GetContentClient()->browser()->GetProduct();
|
||||
+ if (base::FeatureList::IsEnabled(features::kEnableCromiteTestSupport))
|
||||
+ browser = "Chrome/0.0.0.0";
|
||||
version.Set("Protocol-Version", DevToolsAgentHost::GetProtocolVersion());
|
||||
version.Set("WebKit-Version", embedder_support::GetWebKitVersion());
|
||||
version.Set("WebKit-Version", GetWebKitVersion());
|
||||
- version.Set("Browser", GetContentClient()->browser()->GetProduct());
|
||||
+ version.Set("Browser", browser);
|
||||
version.Set("User-Agent", GetContentClient()->browser()->GetUserAgent());
|
||||
@@ -851,16 +851,16 @@ diff --git a/content/browser/log_console_message.h b/content/browser/log_console
|
||||
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
@@ -316,6 +316,8 @@
|
||||
@@ -327,6 +327,8 @@
|
||||
#include "url/origin.h"
|
||||
#include "url/url_constants.h"
|
||||
|
||||
+//#include "chrome/browser/cromite/cromite_private_api_host.h"
|
||||
+
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
#include "base/android/scoped_service_binding_batch.h"
|
||||
#include "content/browser/accessibility/browser_accessibility_manager_android.h"
|
||||
#include "content/browser/android/content_url_loader_factory.h"
|
||||
@@ -4786,7 +4788,8 @@ void RenderFrameHostImpl::DidAddMessageToConsole(
|
||||
@@ -4997,7 +4999,8 @@ void RenderFrameHostImpl::DidAddMessageToConsole(
|
||||
if (delegate_->DidAddMessageToConsole(this, log_level, message, line_no,
|
||||
updated_source_id,
|
||||
untrusted_stack_trace)) {
|
||||
@@ -870,7 +870,7 @@ diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/b
|
||||
}
|
||||
|
||||
// Pass through log severity only on builtin components pages to limit console
|
||||
@@ -4803,8 +4806,14 @@ void RenderFrameHostImpl::DidAddMessageToConsole(
|
||||
@@ -5014,8 +5017,14 @@ void RenderFrameHostImpl::DidAddMessageToConsole(
|
||||
const bool is_off_the_record =
|
||||
GetSiteInstance()->GetBrowserContext()->IsOffTheRecord();
|
||||
|
||||
|
||||
@@ -13,7 +13,7 @@ See also: https://github.com/bromite/bromite/issues/1474
|
||||
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
---
|
||||
.../java/res/xml/privacy_preferences.xml | 15 ++++++
|
||||
.../browser/LaunchIntentDispatcher.java | 21 ++++++++
|
||||
.../browser/LaunchIntentDispatcher.java | 22 ++++++++
|
||||
.../CustomTabIntentDataProvider.java | 22 ++++----
|
||||
.../customtabs/CustomTabsConnection.java | 3 +-
|
||||
.../IncognitoCustomTabIntentDataProvider.java | 14 +++++
|
||||
@@ -25,14 +25,14 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../OriginVerifier.java | 5 ++
|
||||
.../core/common/language_experiments.cc | 1 +
|
||||
.../add-custom-tab-intents-privacy-option.inc | 1 +
|
||||
13 files changed, 158 insertions(+), 13 deletions(-)
|
||||
13 files changed, 159 insertions(+), 13 deletions(-)
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Add-custom-tab-intents-privacy-option.grdp
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/add-custom-tab-intents-privacy-option.inc
|
||||
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -46,6 +46,21 @@ found in the LICENSE file.
|
||||
@@ -40,6 +40,21 @@ found in the LICENSE file.
|
||||
android:key="cromite_flags"
|
||||
android:title="@string/cromite_flags_title"
|
||||
app:url="@string/cromite_flags_url" />
|
||||
@@ -57,7 +57,15 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java b/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
|
||||
@@ -65,6 +65,9 @@ import java.lang.annotation.Retention;
|
||||
@@ -23,6 +23,7 @@ import androidx.core.os.BuildCompat;
|
||||
import org.chromium.base.ApiCompatibilityUtils;
|
||||
import org.chromium.base.ApplicationStatus;
|
||||
import org.chromium.base.CommandLine;
|
||||
+import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.IntentUtils;
|
||||
import org.chromium.base.Log;
|
||||
import org.chromium.base.metrics.RecordHistogram;
|
||||
@@ -53,6 +54,9 @@ import java.lang.annotation.Retention;
|
||||
import java.lang.annotation.RetentionPolicy;
|
||||
import java.util.Set;
|
||||
|
||||
@@ -67,7 +75,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDis
|
||||
/**
|
||||
* Dispatches incoming intents to the appropriate activity based on the current configuration and
|
||||
* Intent fired.
|
||||
@@ -262,6 +265,9 @@ public class LaunchIntentDispatcher {
|
||||
@@ -139,6 +143,9 @@ public class LaunchIntentDispatcher {
|
||||
*/
|
||||
public static boolean isCustomTabIntent(Intent intent) {
|
||||
if (intent == null) return false;
|
||||
@@ -77,7 +85,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDis
|
||||
Log.w(
|
||||
TAG,
|
||||
"CustomTabsIntent#shouldAlwaysUseBrowserUI() = "
|
||||
@@ -290,6 +296,10 @@ public class LaunchIntentDispatcher {
|
||||
@@ -165,6 +172,10 @@ public class LaunchIntentDispatcher {
|
||||
// Make sure the result of the CustomTabActivity is forwarded to the client.
|
||||
newIntent.addFlags(Intent.FLAG_ACTIVITY_FORWARD_RESULT);
|
||||
|
||||
@@ -88,7 +96,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDis
|
||||
// Since configureIntentForResizableCustomTab() might change the componenet/class
|
||||
// associated with the passed intent, it needs to be called after #setClassName(context,
|
||||
// CustomTabActivity.class.getName());
|
||||
@@ -486,6 +496,17 @@ public class LaunchIntentDispatcher {
|
||||
@@ -342,6 +353,17 @@ public class LaunchIntentDispatcher {
|
||||
|
||||
if (Intent.ACTION_VIEW.equals(newIntent.getAction())
|
||||
&& !IntentHandler.wasIntentSenderChrome(newIntent)) {
|
||||
@@ -132,7 +140,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
|
||||
/**
|
||||
* Extra that, if set, makes the Custom Tab Activity's height to be x pixels, the Custom Tab
|
||||
@@ -697,7 +697,7 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
@@ -696,7 +696,7 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
TrustedWebActivityIntentBuilder.EXTRA_SCREEN_ORIENTATION,
|
||||
ScreenOrientation.DEFAULT));
|
||||
|
||||
@@ -141,7 +149,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
|
||||
mBreakPointDp = getActivityBreakPointFromIntent(intent);
|
||||
mInitialActivityHeight = getInitialActivityHeightFromIntent(intent);
|
||||
@@ -710,8 +710,8 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
@@ -709,8 +709,8 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
intent, EXTRA_ACTIVITY_HEIGHT_RESIZE_BEHAVIOR, ACTIVITY_HEIGHT_DEFAULT);
|
||||
mIsPartialCustomTabFixedHeight = activityHeightResizeBehavior == ACTIVITY_HEIGHT_FIXED;
|
||||
|
||||
@@ -152,7 +160,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
@BackgroundInteractBehavior
|
||||
int backgroundInteractBehavior =
|
||||
IntentUtils.safeGetIntExtra(
|
||||
@@ -1369,7 +1369,9 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
@@ -1379,7 +1379,9 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
|
||||
public @CustomTabProfileType int getCustomTabMode() {
|
||||
return AlwaysIncognitoLinkInterceptor.isAlwaysIncognito()
|
||||
? CustomTabProfileType.INCOGNITO
|
||||
@@ -186,7 +194,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/IncognitoCustomTabIntentDataProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/IncognitoCustomTabIntentDataProvider.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/IncognitoCustomTabIntentDataProvider.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/IncognitoCustomTabIntentDataProvider.java
|
||||
@@ -44,6 +44,9 @@ import org.chromium.components.browser_ui.widget.TintedDrawable;
|
||||
@@ -45,6 +45,9 @@ import org.chromium.components.browser_ui.widget.TintedDrawable;
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
@@ -196,7 +204,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Inco
|
||||
/**
|
||||
* A model class that parses the incoming intent for incognito Custom Tabs specific customization
|
||||
* data.
|
||||
@@ -133,6 +136,9 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
@@ -134,6 +137,9 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
}
|
||||
|
||||
private static boolean isIntentFromThirdPartyAllowed() {
|
||||
@@ -206,7 +214,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Inco
|
||||
return ChromeFeatureList.sCctIncognitoAvailableToThirdParty.isEnabled();
|
||||
}
|
||||
|
||||
@@ -230,6 +236,10 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
@@ -231,6 +237,10 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
}
|
||||
|
||||
public static boolean isValidIncognitoIntent(Intent intent, boolean recordMetrics) {
|
||||
@@ -217,7 +225,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Inco
|
||||
if (!isIncognitoRequested(intent)) return false;
|
||||
var session = SessionHolder.getSessionHolderFromIntent(intent);
|
||||
if (isIntentFromThirdPartyAllowed()
|
||||
@@ -340,6 +350,10 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
@@ -341,6 +351,10 @@ public class IncognitoCustomTabIntentDataProvider extends BrowserServicesIntentD
|
||||
|
||||
@Override
|
||||
public @CustomTabProfileType int getCustomTabMode() {
|
||||
@@ -231,7 +239,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Inco
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -11,6 +11,7 @@ import android.content.Context;
|
||||
@@ -12,6 +12,7 @@ import android.content.Context;
|
||||
import android.content.Intent;
|
||||
import android.content.SharedPreferences;
|
||||
import android.graphics.drawable.Drawable;
|
||||
@@ -239,7 +247,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
import android.os.Bundle;
|
||||
import android.text.SpannableString;
|
||||
import android.text.style.ClickableSpan;
|
||||
@@ -80,6 +81,15 @@ import org.chromium.ui.text.SpanApplier;
|
||||
@@ -86,6 +87,15 @@ import org.chromium.ui.text.SpanApplier;
|
||||
import java.util.concurrent.TimeUnit;
|
||||
import java.util.function.Consumer;
|
||||
|
||||
@@ -255,7 +263,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
import androidx.preference.PreferenceCategory;
|
||||
import org.chromium.chrome.browser.contextualsearch.ContextualSearchManager;
|
||||
import org.chromium.base.shared_preferences.SharedPreferencesManager;
|
||||
@@ -148,6 +158,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -155,6 +165,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
startTag, endTag, new ChromeClickableSpan(context, onClickCallback));
|
||||
}
|
||||
|
||||
@@ -265,7 +273,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
@Override
|
||||
public void onCreatePreferencesCromite(@Nullable Bundle savedInstanceState, @Nullable String rootKey) {
|
||||
mPageTitle.set(getString(R.string.prefs_privacy_security));
|
||||
@@ -376,6 +389,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -405,6 +418,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
new SpanApplier.SpanInfo("<link2>", "</link2>", servicesLink));
|
||||
}
|
||||
|
||||
@@ -275,7 +283,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
@Override
|
||||
public boolean onPreferenceChange(Preference preference, Object newValue) {
|
||||
String key = preference.getKey();
|
||||
@@ -396,6 +412,31 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -425,6 +441,31 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
} else if (PREF_SEARCH_SUGGESTIONS.equals(key)) {
|
||||
UserPrefs.get(getProfile())
|
||||
.setBoolean(Pref.SEARCH_SUGGEST_ENABLED, (boolean) newValue);
|
||||
@@ -307,7 +315,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
}
|
||||
return true;
|
||||
}
|
||||
@@ -428,6 +469,16 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -457,6 +498,16 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
UserPrefs.get(getProfile()).getBoolean(Pref.CAN_MAKE_PAYMENT_ENABLED));
|
||||
}
|
||||
|
||||
@@ -336,12 +344,12 @@ diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browse
|
||||
+ "MayLaunchUrlUsesSeparateStoragePartition",
|
||||
+ base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kMediaIndicatorsAndroid, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kMiniOriginBar, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kMostVisitedTilesCustomization, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kMostVisitedTilesReselect, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
@@ -989,6 +989,8 @@ public abstract class ChromeFeatureList {
|
||||
@@ -997,6 +997,8 @@ public abstract class ChromeFeatureList {
|
||||
MOST_VISITED_TILES_CUSTOMIZATION,
|
||||
/* defaultValue= */ true,
|
||||
/* defaultValueInTests= */ true);
|
||||
@@ -349,19 +357,19 @@ diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/f
|
||||
+ newCachedFlag(MAYLAUNCHURL_USES_SEPARATE_STORAGE_PARTITION, false);
|
||||
public static final CachedFlag sMostVisitedTilesReselect =
|
||||
newCachedFlag(MOST_VISITED_TILES_RESELECT, false);
|
||||
public static final CachedFlag sMultiInstanceApplicationStatusCleanup =
|
||||
@@ -1236,6 +1238,7 @@ public abstract class ChromeFeatureList {
|
||||
public static final CachedFlag sMoveToFrontInLaunchIntentDispatcher =
|
||||
@@ -1257,6 +1259,7 @@ public abstract class ChromeFeatureList {
|
||||
sMaliciousApkDownloadCheck,
|
||||
sMiniOriginBar,
|
||||
sMostVisitedTilesCustomization,
|
||||
+ sMayLaunchurlUsesSeparateStoragePartition,
|
||||
sMostVisitedTilesReselect,
|
||||
sMultiInstanceApplicationStatusCleanup,
|
||||
+ sMayLaunchurlUsesSeparateStoragePartition,
|
||||
sMoveToFrontInLaunchIntentDispatcher,
|
||||
sMultiInstanceSharedPrefsMigration,
|
||||
sMvcUpdateViewWhenModelChanged,
|
||||
diff --git a/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/TabAssociatedApp.java b/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/TabAssociatedApp.java
|
||||
--- a/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/TabAssociatedApp.java
|
||||
+++ b/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/TabAssociatedApp.java
|
||||
@@ -88,7 +88,11 @@ public final class TabAssociatedApp extends TabWebContentsUserData implements Im
|
||||
@@ -90,7 +90,11 @@ public final class TabAssociatedApp extends TabWebContentsUserData implements Im
|
||||
public static boolean isOpenedFromExternalApp(Tab tab) {
|
||||
TabAssociatedApp app = get(tab);
|
||||
if (app == null) return false;
|
||||
|
||||
@@ -28,7 +28,7 @@ diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/va
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -363,6 +363,8 @@ import java.util.Set;
|
||||
@@ -395,6 +395,8 @@ import java.util.Set;
|
||||
import java.util.concurrent.atomic.AtomicBoolean;
|
||||
import java.util.function.Supplier;
|
||||
|
||||
@@ -37,7 +37,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
/**
|
||||
* This is the main activity for ChromeMobile when not running in document mode. All the tabs are
|
||||
* accessible via a chrome specific tab switching UI.
|
||||
@@ -3901,6 +3903,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@@ -4132,6 +4134,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
.closeTabs(
|
||||
TabClosureParams.closeTab(currentTab).build(), /* allowDialog= */ true);
|
||||
RecordUserAction.record("MobileTabClosed");
|
||||
@@ -49,7 +49,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
@@ -68,6 +68,7 @@ import org.chromium.base.supplier.UnownedUserDataSupplier;
|
||||
@@ -69,6 +69,7 @@ import org.chromium.base.supplier.SettableNullableObservableSupplier;
|
||||
import org.chromium.chrome.R;
|
||||
import org.chromium.chrome.browser.ActivityTabProvider;
|
||||
import org.chromium.chrome.browser.ActivityUtils;
|
||||
@@ -57,7 +57,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
import org.chromium.chrome.browser.ChromeActivitySessionTracker;
|
||||
import org.chromium.chrome.browser.ChromeApplicationImpl;
|
||||
import org.chromium.chrome.browser.ChromeKeyboardVisibilityDelegate;
|
||||
@@ -2633,6 +2634,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
@@ -2724,6 +2725,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -91,26 +91,26 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLife
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
@@ -422,6 +422,13 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
maybeAddDividerLine(modelList, R.id.menu_item_content_filter_divider_line_id);
|
||||
@@ -478,6 +478,13 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
modelList.add(buildContentFilterHelpCenterMenuItem(currentTab));
|
||||
}
|
||||
+
|
||||
|
||||
+ modelList.add(new MVCListAdapter.ListItem(
|
||||
+ AppMenuHandler.AppMenuItemType.STANDARD,
|
||||
+ buildModelForStandardMenuItem(
|
||||
+ R.id.exit_id,
|
||||
+ R.string.menu_exit,
|
||||
+ shouldShowIconBeforeItem() ? R.drawable.ic_exit_to_app_white_24dp : 0)));
|
||||
}
|
||||
|
||||
private Runnable buildUpdateStateChangedObserver() {
|
||||
+
|
||||
// Default browser promo menu item (entry point).
|
||||
if (shouldShowDefaultBrowserPromo()) {
|
||||
maybeAddDividerLine(modelList, R.id.divider_line_id);
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -4437,6 +4437,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_MENU_AUTO_DARK_WEB_CONTENTS" desc="Menu item in Chrome's overflow/options menu. When Chrome's browser UI is set to dark theme and this option is checked, sites will have a dark theme automatically applied as well. [CHAR_LIMIT=24]">
|
||||
Dark theme
|
||||
@@ -4563,6 +4563,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_MENU_MORE_TOOLS" desc="Menu item to more tools. [CHAR_LIMIT=27]">
|
||||
More tools
|
||||
</message>
|
||||
+ <message name="IDS_MENU_EXIT" desc="Menu item for exit browser. [CHAR-LIMIT=27]">
|
||||
+ Exit
|
||||
|
||||
@@ -10,23 +10,23 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../browser/autocomplete_controller.cc | 10 ++++++
|
||||
.../omnibox/browser/history_url_provider.cc | 3 ++
|
||||
components/omnibox/browser/search_provider.cc | 4 +++
|
||||
components/url_formatter/url_fixer.cc | 4 +++
|
||||
components/url_formatter/url_fixer.cc | 3 ++
|
||||
...lag-for-omnibox-autocomplete-filtering.inc | 32 +++++++++++++++++++
|
||||
5 files changed, 53 insertions(+)
|
||||
5 files changed, 52 insertions(+)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Add-flag-for-omnibox-autocomplete-filtering.inc
|
||||
|
||||
diff --git a/components/omnibox/browser/autocomplete_controller.cc b/components/omnibox/browser/autocomplete_controller.cc
|
||||
--- a/components/omnibox/browser/autocomplete_controller.cc
|
||||
+++ b/components/omnibox/browser/autocomplete_controller.cc
|
||||
@@ -23,6 +23,7 @@
|
||||
@@ -22,6 +22,7 @@
|
||||
#include <utility>
|
||||
|
||||
#include "base/check_op.h"
|
||||
#include "base/containers/contains.h"
|
||||
+#include "base/command_line.h"
|
||||
#include "base/feature_list.h"
|
||||
#include "base/format_macros.h"
|
||||
#include "base/functional/bind.h"
|
||||
@@ -553,6 +554,15 @@ AutocompleteController::AutocompleteController(
|
||||
@@ -547,6 +548,15 @@ AutocompleteController::AutocompleteController(
|
||||
steady_state_omnibox_position_(
|
||||
metrics::OmniboxEventProto::UNKNOWN_POSITION),
|
||||
config_(config) {
|
||||
@@ -34,9 +34,9 @@ diff --git a/components/omnibox/browser/autocomplete_controller.cc b/components/
|
||||
+ const std::string flag_value = base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII("omnibox-autocomplete-filtering");
|
||||
+ config_.provider_types &= AutocompleteProvider::TYPE_KEYWORD | AutocompleteProvider::TYPE_SEARCH |
|
||||
+ AutocompleteProvider::TYPE_HISTORY_URL | AutocompleteProvider::TYPE_BOOKMARK | AutocompleteProvider::TYPE_BUILTIN;
|
||||
+ if (!base::Contains(flag_value, "bookmarks"))
|
||||
+ if (!flag_value.contains("bookmarks"))
|
||||
+ config_.provider_types &= ~AutocompleteProvider::TYPE_BOOKMARK;
|
||||
+ if (!base::Contains(flag_value, "chrome"))
|
||||
+ if (!flag_value.contains("chrome"))
|
||||
+ config_.provider_types &= ~AutocompleteProvider::TYPE_BUILTIN;
|
||||
+ }
|
||||
config_.provider_types &= ~OmniboxFieldTrial::GetDisabledProviderTypes();
|
||||
@@ -66,7 +66,7 @@ diff --git a/components/omnibox/browser/search_provider.cc b/components/omnibox/
|
||||
#include "base/functional/callback.h"
|
||||
#include "base/i18n/break_iterator.h"
|
||||
#include "base/i18n/case_conversion.h"
|
||||
@@ -659,6 +660,9 @@ void SearchProvider::Run(bool query_is_private) {
|
||||
@@ -662,6 +663,9 @@ void SearchProvider::Run(bool query_is_private) {
|
||||
}
|
||||
|
||||
void SearchProvider::DoHistoryQuery(bool minimal_changes) {
|
||||
@@ -79,21 +79,20 @@ diff --git a/components/omnibox/browser/search_provider.cc b/components/omnibox/
|
||||
diff --git a/components/url_formatter/url_fixer.cc b/components/url_formatter/url_fixer.cc
|
||||
--- a/components/url_formatter/url_fixer.cc
|
||||
+++ b/components/url_formatter/url_fixer.cc
|
||||
@@ -11,6 +11,8 @@
|
||||
@@ -11,6 +11,7 @@
|
||||
|
||||
#include "base/check_op.h"
|
||||
#include "base/compiler_specific.h"
|
||||
+#include "base/containers/contains.h"
|
||||
+#include "base/command_line.h"
|
||||
#include "base/files/file_path.h"
|
||||
#include "base/files/file_util.h"
|
||||
#include "base/i18n/char_iterator.h"
|
||||
@@ -640,6 +642,8 @@ GURL FixupURLInternal(const std::string& text,
|
||||
@@ -639,6 +640,8 @@ GURL FixupURLInternal(const std::string& text,
|
||||
|
||||
FixupHost(trimmed, parts.host, parts.scheme.is_valid(), desired_tld, &url);
|
||||
if (chrome_url && !parts.host.is_valid()) {
|
||||
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch("omnibox-autocomplete-filtering") ||
|
||||
+ base::Contains(base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII("omnibox-autocomplete-filtering"), "chrome"))
|
||||
+ base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII("omnibox-autocomplete-filtering").contains("chrome"))
|
||||
url.append(kChromeUIDefaultHost);
|
||||
}
|
||||
FixupPort(trimmed, parts.port, &url);
|
||||
|
||||
@@ -76,7 +76,7 @@ diff --git a/net/socket/client_socket_pool_manager.cc b/net/socket/client_socket
|
||||
#include "net/ssl/ssl_config.h"
|
||||
#include "url/gurl.h"
|
||||
#include "url/scheme_host_port.h"
|
||||
@@ -165,6 +169,19 @@ void ClientSocketPoolManager::set_socket_soft_cap_per_pool_for_test(
|
||||
@@ -162,6 +166,19 @@ void ClientSocketPoolManager::set_socket_soft_cap_per_pool_for_test(
|
||||
size_t ClientSocketPoolManager::max_sockets_per_group(
|
||||
HttpNetworkSession::SocketPoolType pool_type) {
|
||||
DCHECK_LT(pool_type, HttpNetworkSession::NUM_SOCKET_POOL_TYPES);
|
||||
|
||||
@@ -45,7 +45,7 @@ new file mode 100644
|
||||
diff --git a/net/BUILD.gn b/net/BUILD.gn
|
||||
--- a/net/BUILD.gn
|
||||
+++ b/net/BUILD.gn
|
||||
@@ -1182,6 +1182,7 @@ component("net") {
|
||||
@@ -1215,6 +1215,7 @@ component("net") {
|
||||
":net_deps",
|
||||
"//components/network_time/time_tracker",
|
||||
"//components/unexportable_keys",
|
||||
@@ -64,7 +64,7 @@ diff --git a/net/dns/host_resolver_manager.cc b/net/dns/host_resolver_manager.cc
|
||||
#include "net/log/net_log_with_source.h"
|
||||
#include "net/socket/client_socket_factory.h"
|
||||
#include "net/url_request/url_request_context.h"
|
||||
@@ -1493,6 +1494,13 @@ int HostResolverManager::StartIPv6ReachabilityCheck(
|
||||
@@ -1506,6 +1507,13 @@ int HostResolverManager::StartIPv6ReachabilityCheck(
|
||||
return OK;
|
||||
}
|
||||
|
||||
|
||||
@@ -12,7 +12,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
---
|
||||
.../java/res/xml/privacy_preferences.xml | 7 +++-
|
||||
.../customtabs/CustomTabDelegateFactory.java | 2 ++
|
||||
.../ExternalNavigationDelegateImpl.java | 4 ++-
|
||||
.../ExternalNavigationDelegateImpl.java | 6 ++--
|
||||
.../cromite/sAllowExternalIntentRequests.java | 33 +++++++++++++++++++
|
||||
...g-to-disable-external-intent-requests.grdp | 9 +++++
|
||||
.../android/external_intents_features.cc | 6 ++++
|
||||
@@ -22,7 +22,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
...ag-to-disable-external-intent-requests.inc | 13 ++++++++
|
||||
...t-Delete-block-external-form-redirects.inc | 15 +++++++++
|
||||
...ag-to-disable-external-intent-requests.inc | 3 ++
|
||||
12 files changed, 118 insertions(+), 2 deletions(-)
|
||||
12 files changed, 119 insertions(+), 3 deletions(-)
|
||||
create mode 100644 chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/sAllowExternalIntentRequests.java
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Add-flag-to-disable-external-intent-requests.grdp
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Add-flag-to-disable-external-intent-requests.inc
|
||||
@@ -32,7 +32,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -71,7 +71,12 @@ found in the LICENSE file.
|
||||
@@ -65,7 +65,12 @@ found in the LICENSE file.
|
||||
android:title="@string/settings_incognito_tab_lock_title"
|
||||
android:summary="@string/settings_incognito_tab_lock_summary_android_setting_off"
|
||||
android:persistent="false" />
|
||||
@@ -49,7 +49,7 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
|
||||
@@ -38,6 +38,7 @@ import org.chromium.chrome.browser.ephemeraltab.EphemeralTabCoordinator;
|
||||
@@ -39,6 +39,7 @@ import org.chromium.chrome.browser.ephemeraltab.EphemeralTabCoordinator;
|
||||
import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
|
||||
import org.chromium.chrome.browser.flags.ActivityType;
|
||||
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
||||
@@ -57,7 +57,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
import org.chromium.chrome.browser.fullscreen.BrowserControlsManager;
|
||||
import org.chromium.chrome.browser.fullscreen.FullscreenManager;
|
||||
import org.chromium.chrome.browser.init.ChromeActivityNativeDelegate;
|
||||
@@ -155,6 +156,7 @@ public class CustomTabDelegateFactory implements TabDelegateFactory {
|
||||
@@ -167,6 +168,7 @@ public class CustomTabDelegateFactory implements TabDelegateFactory {
|
||||
|
||||
@Override
|
||||
public boolean shouldDisableAllExternalIntents() {
|
||||
@@ -68,7 +68,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
|
||||
@@ -26,6 +26,7 @@ import org.chromium.base.ResettersForTesting;
|
||||
@@ -27,6 +27,7 @@ import org.chromium.base.ResettersForTesting;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.chrome.browser.ChromeTabbedActivity2;
|
||||
@@ -76,7 +76,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/Ext
|
||||
import org.chromium.chrome.browser.IntentHandler;
|
||||
import org.chromium.chrome.browser.browserservices.intents.WebappConstants;
|
||||
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
|
||||
@@ -134,7 +135,8 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
|
||||
@@ -139,7 +140,8 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
|
||||
@Override
|
||||
public boolean shouldDisableExternalIntentRequestsForUrl(
|
||||
ExternalNavigationParams params, Intent intent) {
|
||||
@@ -85,6 +85,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/Ext
|
||||
+ return !sAllowExternalIntentRequests.getInstance().isEnabled();
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -320,7 +322,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
|
||||
&& params.isInitialNavigationInFrame()
|
||||
// TODO(crbug.com/452537438): Figure out a better way to check whether we are in
|
||||
// desktop windowing mode or if the device can enter desktop windowing mode.
|
||||
- && (DeviceInfo.isDesktop() || params.isInDesktopWindowingMode());
|
||||
+ && (params.isInDesktopWindowingMode());
|
||||
}
|
||||
|
||||
@Override
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/sAllowExternalIntentRequests.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/sAllowExternalIntentRequests.java
|
||||
new file mode 100644
|
||||
@@ -141,7 +150,7 @@ new file mode 100644
|
||||
diff --git a/components/external_intents/android/external_intents_features.cc b/components/external_intents/android/external_intents_features.cc
|
||||
--- a/components/external_intents/android/external_intents_features.cc
|
||||
+++ b/components/external_intents/android/external_intents_features.cc
|
||||
@@ -35,7 +35,13 @@ BASE_FEATURE(kExternalNavigationDebugLogs, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -32,8 +32,14 @@ BASE_FEATURE(kExternalNavigationDebugLogs, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kNavigationCaptureRefactorAndroid,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
@@ -149,12 +158,13 @@ diff --git a/components/external_intents/android/external_intents_features.cc b/
|
||||
+ "IntentBlockExternalFormRedirectsNoGesture",
|
||||
+ base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
+
|
||||
static jlong JNI_ExternalIntentsFeatures_GetFeature(JNIEnv* env, jint ordinal) {
|
||||
static int64_t JNI_ExternalIntentsFeatures_GetFeature(JNIEnv* env,
|
||||
int32_t ordinal) {
|
||||
+ if (ordinal == -1)
|
||||
+ return reinterpret_cast<jlong>(&kIntentBlockExternalFormRedirectsNoGesture);
|
||||
return reinterpret_cast<jlong>(kFeaturesExposedToJava[ordinal]);
|
||||
+ return reinterpret_cast<int64_t>(&kIntentBlockExternalFormRedirectsNoGesture);
|
||||
return reinterpret_cast<int64_t>(
|
||||
UNSAFE_TODO(kFeaturesExposedToJava[ordinal]));
|
||||
}
|
||||
|
||||
diff --git a/components/external_intents/android/external_intents_features.h b/components/external_intents/android/external_intents_features.h
|
||||
--- a/components/external_intents/android/external_intents_features.h
|
||||
+++ b/components/external_intents/android/external_intents_features.h
|
||||
@@ -185,7 +195,7 @@ diff --git a/components/external_intents/android/java/src/org/chromium/component
|
||||
diff --git a/components/external_intents/android/java/src/org/chromium/components/external_intents/ExternalNavigationHandler.java b/components/external_intents/android/java/src/org/chromium/components/external_intents/ExternalNavigationHandler.java
|
||||
--- a/components/external_intents/android/java/src/org/chromium/components/external_intents/ExternalNavigationHandler.java
|
||||
+++ b/components/external_intents/android/java/src/org/chromium/components/external_intents/ExternalNavigationHandler.java
|
||||
@@ -1726,6 +1726,12 @@ public class ExternalNavigationHandler {
|
||||
@@ -1796,6 +1796,12 @@ public class ExternalNavigationHandler implements ExternalNavigationHelper {
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -198,7 +208,7 @@ diff --git a/components/external_intents/android/java/src/org/chromium/component
|
||||
private OverrideUrlLoadingResult shouldOverrideUrlLoadingInternal(
|
||||
ExternalNavigationParams params,
|
||||
Intent targetIntent,
|
||||
@@ -1811,6 +1817,21 @@ public class ExternalNavigationHandler {
|
||||
@@ -1883,6 +1889,21 @@ public class ExternalNavigationHandler implements ExternalNavigationHelper {
|
||||
return OverrideUrlLoadingResult.forNoOverride();
|
||||
}
|
||||
|
||||
|
||||
@@ -20,7 +20,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
|
||||
--- a/content/child/runtime_features.cc
|
||||
+++ b/content/child/runtime_features.cc
|
||||
@@ -106,6 +106,7 @@ void SetRuntimeFeatureDefaultsForPlatform(
|
||||
@@ -81,6 +81,7 @@ void SetRuntimeFeatureDefaultsForPlatform(
|
||||
if (command_line.HasSwitch(switches::kDisableMediaSessionAPI)) {
|
||||
WebRuntimeFeatures::EnableMediaSession(false);
|
||||
}
|
||||
@@ -62,7 +62,7 @@ diff --git a/third_party/blink/public/platform/web_runtime_features.h b/third_pa
|
||||
@@ -70,6 +70,7 @@ class BLINK_PLATFORM_EXPORT WebRuntimeFeatures : public WebRuntimeFeaturesBase {
|
||||
static void EnableFingerprintingCanvasImageDataNoise(bool);
|
||||
static void EnableFluentScrollbars(bool);
|
||||
static void EnableFluentOverlayScrollbars(bool);
|
||||
static void EnableDesktopAndroidScrollbars(bool);
|
||||
+ static void EnableVibration(bool);
|
||||
|
||||
static void EnableLocalNetworkAccessWebRTC(bool);
|
||||
@@ -78,7 +78,7 @@ diff --git a/third_party/blink/renderer/modules/vibration/vibration_controller.c
|
||||
|
||||
// Maximum number of entries in a vibration pattern.
|
||||
const unsigned kVibrationPatternLengthMax = 99;
|
||||
@@ -105,6 +106,8 @@ bool VibrationController::vibrate(Navigator& navigator,
|
||||
@@ -108,6 +109,8 @@ bool VibrationController::vibrate(Navigator& navigator,
|
||||
// reference to |window| or |navigator| was retained in another window.
|
||||
if (!navigator.DomWindow())
|
||||
return false;
|
||||
@@ -104,7 +104,7 @@ diff --git a/third_party/blink/renderer/platform/exported/web_runtime_features.c
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -1138,6 +1138,10 @@
|
||||
@@ -1216,6 +1216,10 @@
|
||||
{
|
||||
name: "CompositingDecisionAtAnimationPhaseBoundaries"
|
||||
},
|
||||
|
||||
@@ -14,7 +14,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
|
||||
--- a/build/config/compiler/BUILD.gn
|
||||
+++ b/build/config/compiler/BUILD.gn
|
||||
@@ -734,7 +734,7 @@ config("compiler") {
|
||||
@@ -669,7 +669,7 @@ config("compiler") {
|
||||
# TODO(crbug.com/376278218): This causes segfault on Linux ARM builds.
|
||||
# It also causes segfault on Linux s390x:
|
||||
# https://github.com/llvm/llvm-project/issues/149511
|
||||
@@ -23,7 +23,7 @@ diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
|
||||
cflags += [ "-Wa,--crel,--allow-experimental-crel" ]
|
||||
}
|
||||
}
|
||||
@@ -1830,7 +1830,7 @@ config("clang_revision") {
|
||||
@@ -1861,7 +1861,7 @@ config("clang_revision") {
|
||||
# e.g. by setting in the the project's .gn file.
|
||||
config("clang_warning_suppression") {
|
||||
# Some build configs use older versions of clang that don't support WSMs
|
||||
@@ -32,7 +32,7 @@ diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
|
||||
from_build_root =
|
||||
rebase_path(clang_warning_suppression_file, root_build_dir)
|
||||
inputs = [ clang_warning_suppression_file ]
|
||||
@@ -2192,7 +2192,9 @@ config("default_warnings") {
|
||||
@@ -2236,7 +2236,9 @@ config("default_warnings") {
|
||||
# TODO(crbug.com/432275627): Fix and re-enable.
|
||||
"-Wno-uninitialized-const-pointer",
|
||||
]
|
||||
@@ -43,7 +43,7 @@ diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
|
||||
cflags_cc += [
|
||||
# TODO(crbug.com/328490295): Fix and re-enable for C flags.
|
||||
"-Wenum-compare-conditional",
|
||||
@@ -2246,6 +2248,15 @@ config("default_warnings") {
|
||||
@@ -2290,6 +2292,15 @@ config("default_warnings") {
|
||||
ldflags += [ "-Wno-version-check" ]
|
||||
}
|
||||
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -14,7 +14,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../bookmarks/bookmark_parent_folder.cc | 1 +
|
||||
.../permanent_folder_ordering_tracker.cc | 2 +
|
||||
.../dialogs/DownloadLocationCustomView.java | 4 +-
|
||||
.../strings/android_chrome_strings.grd | 3 ++
|
||||
.../strings/android_chrome_strings.grd | 6 +--
|
||||
.../bookmark_ui_operations_helper.cc | 2 +
|
||||
.../bookmark_bar_page_handler.cc | 2 +
|
||||
components/bookmark_bar_strings.grdp | 6 +++
|
||||
@@ -23,7 +23,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../browser/bookmark_load_details.cc | 15 +++++--
|
||||
.../bookmarks/browser/bookmark_load_details.h | 2 +
|
||||
.../bookmarks/browser/bookmark_model.cc | 3 +-
|
||||
components/bookmarks/browser/bookmark_model.h | 7 +++
|
||||
components/bookmarks/browser/bookmark_model.h | 8 ++++
|
||||
components/bookmarks/browser/bookmark_node.cc | 13 ++++++
|
||||
components/bookmarks/browser/bookmark_node.h | 4 ++
|
||||
.../bookmarks/browser/bookmark_storage.cc | 2 +
|
||||
@@ -31,15 +31,15 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
components/bookmarks/browser/bookmark_uuids.h | 1 +
|
||||
components/bookmarks/browser/model_loader.cc | 9 +++-
|
||||
.../bookmark_specifics_conversions.cc | 1 +
|
||||
27 files changed, 251 insertions(+), 11 deletions(-)
|
||||
27 files changed, 252 insertions(+), 14 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/values/ids.xml
|
||||
--- a/chrome/android/java/res/values/ids.xml
|
||||
+++ b/chrome/android/java/res/values/ids.xml
|
||||
@@ -197,6 +197,7 @@ found in the LICENSE file.
|
||||
<item type="id" name="menu_item_content_filter_divider_line_id" />
|
||||
<item type="id" name="menu_item_content_filter_help_center_id" />
|
||||
@@ -203,6 +203,7 @@ found in the LICENSE file.
|
||||
<item type="id" name="duplicate_tab_menu_id" />
|
||||
<item type="id" name="glic_menu_id" />
|
||||
<item type="id" name="open_in_app_menu_id" />
|
||||
+ <item type="id" name="bookmark_all_tabs_menu_id" />
|
||||
|
||||
<!-- Custom Tabs -->
|
||||
@@ -47,7 +47,7 @@ diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/va
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -100,6 +100,7 @@ import org.chromium.chrome.browser.bookmarks.BookmarkPane;
|
||||
@@ -114,6 +114,7 @@ import org.chromium.chrome.browser.bookmarks.BookmarkPane;
|
||||
import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
|
||||
import org.chromium.chrome.browser.browserservices.intents.WebappConstants;
|
||||
import org.chromium.chrome.browser.compositor.CompositorViewHolder;
|
||||
@@ -55,26 +55,26 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
import org.chromium.chrome.browser.compositor.layouts.Layout;
|
||||
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerChrome;
|
||||
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerChromePhone;
|
||||
@@ -299,6 +300,9 @@ import org.chromium.chrome.browser.ui.appmenu.AppMenuPropertiesDelegate;
|
||||
import org.chromium.chrome.browser.ui.browser_window.BrowserWindowType;
|
||||
@@ -327,6 +328,9 @@ import org.chromium.chrome.browser.ui.default_browser_promo.DefaultBrowserPromoU
|
||||
import org.chromium.chrome.browser.ui.desktop_windowing.AppHeaderUtils;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeUtils;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.TransitiveTopInsetProvider;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.Snackbar;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager.SnackbarController;
|
||||
import org.chromium.chrome.browser.ui.searchactivityutils.SearchActivityClient;
|
||||
import org.chromium.chrome.browser.ui.searchactivityutils.SearchActivityExtras.IntentOrigin;
|
||||
import org.chromium.chrome.browser.ui.signin.BottomSheetSigninAndHistorySyncConfig;
|
||||
@@ -314,6 +318,8 @@ import org.chromium.chrome.browser.util.ChromeAccessibilityUtil;
|
||||
import org.chromium.chrome.browser.xr.scenecore.XrSceneCoreSessionInitializerImpl;
|
||||
import org.chromium.chrome.browser.xr.scenecore.XrSceneCoreSessionManagerImpl;
|
||||
@@ -344,6 +348,8 @@ import org.chromium.chrome.browser.util.ChromeAccessibilityUtil;
|
||||
import org.chromium.chrome.browser.util.DefaultBrowserInfo;
|
||||
import org.chromium.chrome.browser.xr.scenecore.XrModule;
|
||||
import org.chromium.components.browser_ui.accessibility.AccessibilityFeatureMap;
|
||||
+import org.chromium.components.bookmarks.BookmarkId;
|
||||
+import org.chromium.components.bookmarks.BookmarkItem;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
|
||||
import org.chromium.components.browser_ui.share.ShareParams;
|
||||
import org.chromium.components.browser_ui.util.BrowserControlsVisibilityDelegate;
|
||||
@@ -3929,6 +3935,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@@ -4160,6 +4166,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
CloseAllTabsDialog.show(
|
||||
this, getModalDialogManagerSupplier(), tabModelSelector, closeAllTabsRunnable);
|
||||
RecordUserAction.record("MobileMenuCloseAllTabs");
|
||||
@@ -83,7 +83,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
} else if (id == R.id.close_all_incognito_tabs_menu_id) {
|
||||
boolean allowUndo = TabClosureParamsUtils.shouldAllowUndo(triggeringMotion);
|
||||
|
||||
@@ -4058,6 +4066,41 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@@ -4295,6 +4303,41 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
getTabModalLifetimeHandler().onOmniboxFocusChanged(hasFocus);
|
||||
}
|
||||
|
||||
@@ -128,7 +128,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
@@ -292,6 +292,14 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
@@ -314,6 +314,14 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
// Bookmarks
|
||||
modelList.add(buildBookmarksItem());
|
||||
|
||||
@@ -141,10 +141,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
+ shouldShowIconBeforeItem() ? R.drawable.ic_folder_blue_24dp : 0)));
|
||||
+
|
||||
// Recent Tabs
|
||||
if (shouldShowRecentTabsItem()) modelList.add(buildRecentTabsItem());
|
||||
|
||||
@@ -478,6 +486,13 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
}
|
||||
if (!ChromeFeatureList.isEnabled(ChromeFeatureList.SUBMENUS_IN_APP_MENU)
|
||||
&& shouldShowRecentTabsItem()) {
|
||||
@@ -537,6 +545,13 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
modelList.add(buildNewTabGroupItem());
|
||||
modelList.add(buildCloseAllTabsItem());
|
||||
if (shouldShowTinkerTank()) modelList.add(buildTinkerTankItem());
|
||||
+ // Add bookmark all item
|
||||
@@ -160,14 +160,14 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
--- a/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
+++ b/chrome/browser/bookmarks/android/bookmark_bridge.cc
|
||||
@@ -336,6 +336,33 @@ jboolean BookmarkBridge::AreAccountBookmarkFoldersActive(JNIEnv* env) {
|
||||
@@ -337,6 +337,33 @@ bool BookmarkBridge::AreAccountBookmarkFoldersActive(JNIEnv* env) {
|
||||
return bookmark_model_->account_mobile_node() != nullptr;
|
||||
}
|
||||
|
||||
+base::android::ScopedJavaLocalRef<jobject>
|
||||
+BookmarkBridge::GetBookmarkIdForTabsCollection(
|
||||
+ JNIEnv* env,
|
||||
+ const JavaParamRef<jobject>& url) {
|
||||
+ const JavaRef<jobject>& url) {
|
||||
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
|
||||
+
|
||||
+ GURL gurl = url::GURLAndroid::ToNativeGURL(env, url);
|
||||
@@ -212,13 +212,13 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
const BookmarkNode* reading_list_node =
|
||||
local_or_syncable_reading_list_manager_->GetRoot();
|
||||
if (IsPermanentFolderVisible(
|
||||
@@ -1229,6 +1260,17 @@ void BookmarkBridge::GetBookmarksOfType(
|
||||
@@ -1223,6 +1254,17 @@ void BookmarkBridge::GetBookmarksOfType(
|
||||
AddBookmarkNodesToBookmarkIdList(env, j_list, results);
|
||||
}
|
||||
|
||||
+ScopedJavaLocalRef<jobject> BookmarkBridge::GetTabsCollectionFolderId(
|
||||
+ JNIEnv* env,
|
||||
+ const JavaParamRef<jobject>& obj) {
|
||||
+ const JavaRef<jobject>& obj) {
|
||||
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
|
||||
+ const BookmarkNode* tabs_collection_node = bookmark_model_->tabs_collection_node();
|
||||
+ ScopedJavaLocalRef<jobject> folder_id_obj =
|
||||
@@ -229,32 +229,32 @@ diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.cc b/chrome/browse
|
||||
+
|
||||
ScopedJavaLocalRef<jobject> BookmarkBridge::AddFolder(
|
||||
JNIEnv* env,
|
||||
const JavaParamRef<jobject>& j_parent_id_obj,
|
||||
const JavaRef<jobject>& j_parent_id_obj,
|
||||
diff --git a/chrome/browser/bookmarks/android/bookmark_bridge.h b/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
--- a/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
+++ b/chrome/browser/bookmarks/android/bookmark_bridge.h
|
||||
@@ -106,6 +106,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
@@ -105,6 +105,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
|
||||
jboolean AreAccountBookmarkFoldersActive(JNIEnv* env);
|
||||
bool AreAccountBookmarkFoldersActive(JNIEnv* env);
|
||||
|
||||
+ base::android::ScopedJavaLocalRef<jobject> GetBookmarkIdForTabsCollection(
|
||||
+ JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& url);
|
||||
+ const base::android::JavaRef<jobject>& url);
|
||||
+
|
||||
base::android::ScopedJavaLocalRef<jobject>
|
||||
GetMostRecentlyAddedUserBookmarkIdForUrl(JNIEnv* env, const GURL& url);
|
||||
const bookmarks::BookmarkNode* GetMostRecentlyAddedUserBookmarkIdForUrlImpl(
|
||||
@@ -245,6 +249,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
const base::android::JavaParamRef<jobject>& j_list,
|
||||
jint type);
|
||||
@@ -232,6 +236,10 @@ class BookmarkBridge : public ProfileObserver,
|
||||
const base::android::JavaRef<jobject>& j_list,
|
||||
int32_t type);
|
||||
|
||||
+ base::android::ScopedJavaLocalRef<jobject> GetTabsCollectionFolderId(
|
||||
+ JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& obj);
|
||||
+ const base::android::JavaRef<jobject>& obj);
|
||||
+
|
||||
base::android::ScopedJavaLocalRef<jobject> AddFolder(
|
||||
JNIEnv* env,
|
||||
const base::android::JavaParamRef<jobject>& j_parent_id_obj,
|
||||
const base::android::JavaRef<jobject>& j_parent_id_obj,
|
||||
diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java
|
||||
--- a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java
|
||||
+++ b/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java
|
||||
@@ -370,14 +370,14 @@ diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/b
|
||||
CHECK(!model->account_other_node());
|
||||
CHECK(!model->account_mobile_node());
|
||||
@@ -210,6 +211,9 @@ class Writer : public base::RefCountedThreadSafe<Writer> {
|
||||
base::Value::Dict* mobile_folder_value = local_permanent_folders->FindDict(
|
||||
base::DictValue* mobile_folder_value = local_permanent_folders->FindDict(
|
||||
BookmarkCodec::kMobileBookmarkFolderNameKey);
|
||||
CHECK(mobile_folder_value);
|
||||
+ base::Value::Dict* tabs_collection_value =
|
||||
+ base::DictValue* tabs_collection_value =
|
||||
+ local_permanent_folders->FindDict(BookmarkCodec::kTabsBookmarkFolderNameKey);
|
||||
+ CHECK(tabs_collection_value);
|
||||
|
||||
base::Value::Dict* account_permanent_folders =
|
||||
base::DictValue* account_permanent_folders =
|
||||
account_bookmarks_.FindDict(BookmarkCodec::kRootsKey);
|
||||
@@ -285,6 +289,10 @@ class Writer : public base::RefCountedThreadSafe<Writer> {
|
||||
return bookmark_html_writer::Result::kCouldNotWriteNodes;
|
||||
@@ -460,7 +460,7 @@ diff --git a/chrome/browser/download/android/java/src/org/chromium/chrome/browse
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -4562,6 +4562,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -4694,6 +4694,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_MENU_SELECT_TABS" desc="Menu item for bulk editing tabs. [CHAR_LIMIT=27]">
|
||||
Select tabs
|
||||
</message>
|
||||
@@ -470,10 +470,20 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
<message name="IDS_MENU_GET_IMAGE_DESCRIPTIONS" desc="Menu item to start getting alt text accessibility image labels/descriptions [CHAR_LIMIT=27]">
|
||||
Get image descriptions
|
||||
</message>
|
||||
@@ -4733,9 +4736,6 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_MENU_REOPEN_CLOSED_GROUP" desc="Menu item for reopening the last closed tab group.">
|
||||
Reopen closed group
|
||||
</message>
|
||||
- <message name="IDS_MENU_BOOKMARK_ALL_TABS" desc="Menu item for bookmarking all tabs.">
|
||||
- Bookmark all tabs
|
||||
- </message>
|
||||
<message name="IDS_MENU_UNPIN_GLIC_BUTTON" desc="Menu item for unpinning the tab strip Glic button.">
|
||||
Unpin
|
||||
</message>
|
||||
diff --git a/chrome/browser/ui/bookmarks/bookmark_ui_operations_helper.cc b/chrome/browser/ui/bookmarks/bookmark_ui_operations_helper.cc
|
||||
--- a/chrome/browser/ui/bookmarks/bookmark_ui_operations_helper.cc
|
||||
+++ b/chrome/browser/ui/bookmarks/bookmark_ui_operations_helper.cc
|
||||
@@ -105,6 +105,8 @@ ui::mojom::DragOperation BookmarkUIOperationsHelper::DropBookmarks(
|
||||
@@ -113,6 +113,8 @@ ui::mojom::DragOperation BookmarkUIOperationsHelper::DropBookmarks(
|
||||
if (is_reorder) {
|
||||
base::UmaHistogramEnumeration("Bookmarks.ReorderDropTarget", target);
|
||||
switch (target_parent()->GetType()) {
|
||||
@@ -520,7 +530,7 @@ diff --git a/components/bookmark_bar_strings.grdp b/components/bookmark_bar_stri
|
||||
diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmarks/browser/bookmark_codec.cc
|
||||
--- a/components/bookmarks/browser/bookmark_codec.cc
|
||||
+++ b/components/bookmarks/browser/bookmark_codec.cc
|
||||
@@ -39,6 +39,7 @@ const char BookmarkCodec::kBookmarkBarFolderNameKey[] = "bookmark_bar";
|
||||
@@ -38,6 +38,7 @@ const char BookmarkCodec::kBookmarkBarFolderNameKey[] = "bookmark_bar";
|
||||
const char BookmarkCodec::kOtherBookmarkFolderNameKey[] = "other";
|
||||
// The value is left as 'synced' for historical reasons.
|
||||
const char BookmarkCodec::kMobileBookmarkFolderNameKey[] = "synced";
|
||||
@@ -528,15 +538,15 @@ diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmar
|
||||
const char BookmarkCodec::kVersionKey[] = "version";
|
||||
const char BookmarkCodec::kChecksumKey[] = "checksum";
|
||||
const char BookmarkCodec::kChecksumSHA256Key[] = "checksum_sha256";
|
||||
@@ -99,6 +100,7 @@ base::Value::Dict BookmarkCodec::Encode(
|
||||
const BookmarkNode* bookmark_bar_node,
|
||||
const BookmarkNode* other_folder_node,
|
||||
const BookmarkNode* mobile_folder_node,
|
||||
+ const BookmarkNode* tabs_folder_node,
|
||||
std::string sync_metadata_str) {
|
||||
@@ -97,6 +98,7 @@ BookmarkCodec::~BookmarkCodec() = default;
|
||||
base::DictValue BookmarkCodec::Encode(const BookmarkNode* bookmark_bar_node,
|
||||
const BookmarkNode* other_folder_node,
|
||||
const BookmarkNode* mobile_folder_node,
|
||||
+ const BookmarkNode* tabs_folder_node,
|
||||
std::string sync_metadata_str) {
|
||||
ids_reassigned_ = false;
|
||||
uuids_reassigned_ = false;
|
||||
@@ -124,6 +126,8 @@ base::Value::Dict BookmarkCodec::Encode(
|
||||
@@ -122,6 +124,8 @@ base::DictValue BookmarkCodec::Encode(const BookmarkNode* bookmark_bar_node,
|
||||
roots.Set(kBookmarkBarFolderNameKey, EncodeNode(bookmark_bar_node));
|
||||
roots.Set(kOtherBookmarkFolderNameKey, EncodeNode(other_folder_node));
|
||||
roots.Set(kMobileBookmarkFolderNameKey, EncodeNode(mobile_folder_node));
|
||||
@@ -545,7 +555,7 @@ diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmar
|
||||
} else {
|
||||
// No permanent node should have been provided.
|
||||
CHECK(!other_folder_node);
|
||||
@@ -144,6 +148,7 @@ bool BookmarkCodec::Decode(const base::Value::Dict& value,
|
||||
@@ -142,6 +146,7 @@ bool BookmarkCodec::Decode(const base::DictValue& value,
|
||||
BookmarkNode* bb_node,
|
||||
BookmarkNode* other_folder_node,
|
||||
BookmarkNode* mobile_folder_node,
|
||||
@@ -553,7 +563,7 @@ diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmar
|
||||
int64_t* max_id,
|
||||
std::string* sync_metadata_str) {
|
||||
if (sync_metadata_str) {
|
||||
@@ -156,13 +161,15 @@ bool BookmarkCodec::Decode(const base::Value::Dict& value,
|
||||
@@ -154,13 +159,15 @@ bool BookmarkCodec::Decode(const base::DictValue& value,
|
||||
base::Uuid::ParseLowercase(kBookmarkBarNodeUuid),
|
||||
base::Uuid::ParseLowercase(kOtherBookmarksNodeUuid),
|
||||
base::Uuid::ParseLowercase(kMobileBookmarksNodeUuid),
|
||||
@@ -570,24 +580,24 @@ diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmar
|
||||
value, sync_metadata_str);
|
||||
ReassignIDsIfRequired();
|
||||
|
||||
@@ -220,6 +227,7 @@ base::Value::Dict BookmarkCodec::EncodeMetaInfo(
|
||||
@@ -218,6 +225,7 @@ base::DictValue BookmarkCodec::EncodeMetaInfo(
|
||||
bool BookmarkCodec::DecodeHelper(BookmarkNode* bb_node,
|
||||
BookmarkNode* other_folder_node,
|
||||
BookmarkNode* mobile_folder_node,
|
||||
+ BookmarkNode* tabs_folder_node,
|
||||
const base::Value::Dict& value,
|
||||
const base::DictValue& value,
|
||||
std::string* sync_metadata_str) {
|
||||
std::optional<int> version = value.FindInt(kVersionKey);
|
||||
@@ -243,6 +251,8 @@ bool BookmarkCodec::DecodeHelper(BookmarkNode* bb_node,
|
||||
@@ -240,6 +248,8 @@ bool BookmarkCodec::DecodeHelper(BookmarkNode* bb_node,
|
||||
roots->FindDict(kOtherBookmarkFolderNameKey);
|
||||
const base::Value::Dict* mobile_folder_value =
|
||||
const base::DictValue* mobile_folder_value =
|
||||
roots->FindDict(kMobileBookmarkFolderNameKey);
|
||||
+ const base::Value::Dict* tabs_folder_value =
|
||||
+ const base::DictValue* tabs_folder_value =
|
||||
+ roots->FindDict(kTabsBookmarkFolderNameKey);
|
||||
|
||||
if (!bb_value || !other_folder_value || !mobile_folder_value)
|
||||
return false;
|
||||
@@ -250,6 +260,8 @@ bool BookmarkCodec::DecodeHelper(BookmarkNode* bb_node,
|
||||
@@ -247,6 +257,8 @@ bool BookmarkCodec::DecodeHelper(BookmarkNode* bb_node,
|
||||
DecodeNode(*bb_value, nullptr, bb_node);
|
||||
DecodeNode(*other_folder_value, nullptr, other_folder_node);
|
||||
DecodeNode(*mobile_folder_value, nullptr, mobile_folder_node);
|
||||
@@ -599,15 +609,15 @@ diff --git a/components/bookmarks/browser/bookmark_codec.cc b/components/bookmar
|
||||
diff --git a/components/bookmarks/browser/bookmark_codec.h b/components/bookmarks/browser/bookmark_codec.h
|
||||
--- a/components/bookmarks/browser/bookmark_codec.h
|
||||
+++ b/components/bookmarks/browser/bookmark_codec.h
|
||||
@@ -44,6 +44,7 @@ class BookmarkCodec {
|
||||
const BookmarkNode* bookmark_bar_node,
|
||||
const BookmarkNode* other_folder_node,
|
||||
const BookmarkNode* mobile_folder_node,
|
||||
+ const BookmarkNode* tabs_folder_node,
|
||||
std::string sync_metadata_str);
|
||||
@@ -43,6 +43,7 @@ class BookmarkCodec {
|
||||
base::DictValue Encode(const BookmarkNode* bookmark_bar_node,
|
||||
const BookmarkNode* other_folder_node,
|
||||
const BookmarkNode* mobile_folder_node,
|
||||
+ const BookmarkNode* tabs_folder_node,
|
||||
std::string sync_metadata_str);
|
||||
|
||||
// Decodes the previously encoded value to the specified nodes as well as
|
||||
@@ -62,6 +63,7 @@ class BookmarkCodec {
|
||||
@@ -61,6 +62,7 @@ class BookmarkCodec {
|
||||
BookmarkNode* bb_node,
|
||||
BookmarkNode* other_folder_node,
|
||||
BookmarkNode* mobile_folder_node,
|
||||
@@ -615,7 +625,7 @@ diff --git a/components/bookmarks/browser/bookmark_codec.h b/components/bookmark
|
||||
int64_t* max_node_id,
|
||||
std::string* sync_metadata_str);
|
||||
|
||||
@@ -95,6 +97,7 @@ class BookmarkCodec {
|
||||
@@ -94,6 +96,7 @@ class BookmarkCodec {
|
||||
static const char kBookmarkBarFolderNameKey[];
|
||||
static const char kOtherBookmarkFolderNameKey[];
|
||||
static const char kMobileBookmarkFolderNameKey[];
|
||||
@@ -623,18 +633,18 @@ diff --git a/components/bookmarks/browser/bookmark_codec.h b/components/bookmark
|
||||
static const char kVersionKey[];
|
||||
static const char kChecksumKey[];
|
||||
static const char kChecksumSHA256Key[];
|
||||
@@ -128,6 +131,7 @@ class BookmarkCodec {
|
||||
@@ -127,6 +130,7 @@ class BookmarkCodec {
|
||||
bool DecodeHelper(BookmarkNode* bb_node,
|
||||
BookmarkNode* other_folder_node,
|
||||
BookmarkNode* mobile_folder_node,
|
||||
+ BookmarkNode* tabs_folder_node,
|
||||
const base::Value::Dict& value,
|
||||
const base::DictValue& value,
|
||||
std::string* sync_metadata_str);
|
||||
|
||||
diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/bookmarks/browser/bookmark_load_details.cc
|
||||
--- a/components/bookmarks/browser/bookmark_load_details.cc
|
||||
+++ b/components/bookmarks/browser/bookmark_load_details.cc
|
||||
@@ -16,7 +16,7 @@ namespace {
|
||||
@@ -17,7 +17,7 @@ namespace {
|
||||
|
||||
// Number of top-level permanent folders excluding the managed node and account
|
||||
// bookmarks.
|
||||
@@ -643,7 +653,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/
|
||||
|
||||
void UpdateUserFolderStatsRecursively(const BookmarkNode& node,
|
||||
bool top_level,
|
||||
@@ -63,6 +63,9 @@ BookmarkLoadDetails::BookmarkLoadDetails()
|
||||
@@ -64,6 +64,9 @@ BookmarkLoadDetails::BookmarkLoadDetails()
|
||||
mobile_folder_node_ = static_cast<BookmarkPermanentNode*>(
|
||||
root_node_->Add(BookmarkPermanentNode::CreateMobileBookmarks(
|
||||
/*id=*/0, /*is_account_node=*/false)));
|
||||
@@ -653,7 +663,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/
|
||||
|
||||
// Set the nodes' `date_added` to the same time so that there is no inherent
|
||||
// hierarchy in terms of their added time between them. This is relevant for
|
||||
@@ -119,6 +122,10 @@ void BookmarkLoadDetails::PopulateNodeIdsForLocalOrSyncablePermanentNodes() {
|
||||
@@ -120,6 +123,10 @@ void BookmarkLoadDetails::PopulateNodeIdsForLocalOrSyncablePermanentNodes() {
|
||||
if (mobile_folder_node_->id() == 0) {
|
||||
mobile_folder_node_->set_id(max_id_++);
|
||||
}
|
||||
@@ -664,7 +674,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/
|
||||
}
|
||||
|
||||
void BookmarkLoadDetails::AddManagedNode(
|
||||
@@ -131,6 +138,7 @@ void BookmarkLoadDetails::AddManagedNode(
|
||||
@@ -132,6 +139,7 @@ void BookmarkLoadDetails::AddManagedNode(
|
||||
CHECK_NE(bb_node_->id(), 0);
|
||||
CHECK_NE(other_folder_node_->id(), 0);
|
||||
CHECK_NE(mobile_folder_node_->id(), 0);
|
||||
@@ -672,7 +682,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/
|
||||
|
||||
has_managed_node_ = true;
|
||||
root_node_->Add(std::move(managed_node));
|
||||
@@ -138,8 +146,8 @@ void BookmarkLoadDetails::AddManagedNode(
|
||||
@@ -139,8 +147,8 @@ void BookmarkLoadDetails::AddManagedNode(
|
||||
|
||||
void BookmarkLoadDetails::CreateIndices() {
|
||||
local_or_syncable_uuid_index_.insert(root_node_.get());
|
||||
@@ -683,7 +693,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.cc b/components/
|
||||
for (const auto& child : root_node_->children()) {
|
||||
if (child.get() == account_bb_node_ ||
|
||||
child.get() == account_other_folder_node_ ||
|
||||
@@ -158,6 +166,7 @@ void BookmarkLoadDetails::ResetPermanentNodePointers() {
|
||||
@@ -159,6 +167,7 @@ void BookmarkLoadDetails::ResetPermanentNodePointers() {
|
||||
bb_node_ = nullptr;
|
||||
other_folder_node_ = nullptr;
|
||||
mobile_folder_node_ = nullptr;
|
||||
@@ -713,7 +723,7 @@ diff --git a/components/bookmarks/browser/bookmark_load_details.h b/components/b
|
||||
diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc
|
||||
--- a/components/bookmarks/browser/bookmark_model.cc
|
||||
+++ b/components/bookmarks/browser/bookmark_model.cc
|
||||
@@ -908,7 +908,7 @@ bool BookmarkModel::HasUserCreatedBookmarksOrFolders() const {
|
||||
@@ -957,7 +957,7 @@ bool BookmarkModel::HasUserCreatedBookmarksOrFolders() const {
|
||||
(account_bookmark_bar_node_ &&
|
||||
!account_bookmark_bar_node_->children().empty()) ||
|
||||
(account_other_node_ && !account_other_node_->children().empty()) ||
|
||||
@@ -722,7 +732,7 @@ diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmar
|
||||
}
|
||||
|
||||
bool BookmarkModel::IsBookmarked(const GURL& url) const {
|
||||
@@ -1240,6 +1240,7 @@ void BookmarkModel::DoneLoading(std::unique_ptr<BookmarkLoadDetails> details) {
|
||||
@@ -1289,6 +1289,7 @@ void BookmarkModel::DoneLoading(std::unique_ptr<BookmarkLoadDetails> details) {
|
||||
bookmark_bar_node_ = details->bb_node();
|
||||
other_node_ = details->other_folder_node();
|
||||
mobile_node_ = details->mobile_folder_node();
|
||||
@@ -733,7 +743,7 @@ diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmar
|
||||
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
|
||||
--- a/components/bookmarks/browser/bookmark_model.h
|
||||
+++ b/components/bookmarks/browser/bookmark_model.h
|
||||
@@ -150,6 +150,12 @@ class BookmarkModel : public BookmarkUndoProvider,
|
||||
@@ -149,6 +149,12 @@ class BookmarkModel : public BookmarkUndoProvider,
|
||||
// bookmarks in the account storage).
|
||||
const BookmarkPermanentNode* account_mobile_node() const;
|
||||
|
||||
@@ -746,14 +756,15 @@ diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmark
|
||||
bool is_root_node(const BookmarkNode* node) const {
|
||||
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
|
||||
return node == root_;
|
||||
@@ -628,6 +634,7 @@ class BookmarkModel : public BookmarkUndoProvider,
|
||||
raw_ptr<BookmarkPermanentNode> account_bookmark_bar_node_ = nullptr;
|
||||
raw_ptr<BookmarkPermanentNode> account_other_node_ = nullptr;
|
||||
raw_ptr<BookmarkPermanentNode> account_mobile_node_ = nullptr;
|
||||
+ raw_ptr<BookmarkPermanentNode> tabs_collection_node_ = nullptr;
|
||||
@@ -633,6 +639,8 @@ class BookmarkModel : public BookmarkUndoProvider,
|
||||
nullptr;
|
||||
raw_ptr<BookmarkPermanentNode, AcrossTasksDanglingUntriaged> mobile_node_ =
|
||||
nullptr;
|
||||
+ raw_ptr<BookmarkPermanentNode, AcrossTasksDanglingUntriaged> tabs_collection_node_ =
|
||||
+ nullptr;
|
||||
|
||||
// The maximum ID assigned to the bookmark nodes in the model.
|
||||
int64_t next_node_id_ = 1;
|
||||
// Permanent nodes for account storage.
|
||||
raw_ptr<BookmarkPermanentNode> account_bookmark_bar_node_ = nullptr;
|
||||
diff --git a/components/bookmarks/browser/bookmark_node.cc b/components/bookmarks/browser/bookmark_node.cc
|
||||
--- a/components/bookmarks/browser/bookmark_node.cc
|
||||
+++ b/components/bookmarks/browser/bookmark_node.cc
|
||||
@@ -808,7 +819,7 @@ diff --git a/components/bookmarks/browser/bookmark_node.h b/components/bookmarks
|
||||
diff --git a/components/bookmarks/browser/bookmark_storage.cc b/components/bookmarks/browser/bookmark_storage.cc
|
||||
--- a/components/bookmarks/browser/bookmark_storage.cc
|
||||
+++ b/components/bookmarks/browser/bookmark_storage.cc
|
||||
@@ -45,6 +45,7 @@ base::Value::Dict EncodeModelToDict(
|
||||
@@ -57,6 +57,7 @@ base::DictValue EncodeModelToDict(
|
||||
case BookmarkStorage::kSelectLocalOrSyncableNodes:
|
||||
return codec.Encode(
|
||||
model->bookmark_bar_node(), model->other_node(), model->mobile_node(),
|
||||
@@ -816,7 +827,7 @@ diff --git a/components/bookmarks/browser/bookmark_storage.cc b/components/bookm
|
||||
model->client()->EncodeLocalOrSyncableBookmarkSyncMetadata());
|
||||
case BookmarkStorage::kSelectAccountNodes:
|
||||
// Either all permanent folders or none should exist.
|
||||
@@ -61,6 +62,7 @@ base::Value::Dict EncodeModelToDict(
|
||||
@@ -73,6 +74,7 @@ base::DictValue EncodeModelToDict(
|
||||
return codec.Encode(model->account_bookmark_bar_node(),
|
||||
model->account_other_node(),
|
||||
model->account_mobile_node(),
|
||||
@@ -851,34 +862,34 @@ diff --git a/components/bookmarks/browser/bookmark_uuids.h b/components/bookmark
|
||||
diff --git a/components/bookmarks/browser/model_loader.cc b/components/bookmarks/browser/model_loader.cc
|
||||
--- a/components/bookmarks/browser/model_loader.cc
|
||||
+++ b/components/bookmarks/browser/model_loader.cc
|
||||
@@ -74,6 +74,9 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
@@ -172,6 +172,9 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
std::unique_ptr<BookmarkPermanentNode> account_mobile_folder_node =
|
||||
BookmarkPermanentNode::CreateMobileBookmarks(
|
||||
0, /*is_account_node=*/true);
|
||||
BookmarkPermanentNode::CreateMobileBookmarks(0,
|
||||
/*is_account_node=*/true);
|
||||
+ std::unique_ptr<BookmarkPermanentNode> tabs_collection_folder_node =
|
||||
+ BookmarkPermanentNode::CreateTabsCollectionBookmarks(
|
||||
+ 0, /*is_account_node=*/true);
|
||||
|
||||
std::optional<base::Value::Dict> root_dict =
|
||||
LoadFileToDict(account_file_path);
|
||||
@@ -81,7 +84,8 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
if (root_dict.has_value() &&
|
||||
codec.Decode(*root_dict, /*already_assigned_ids=*/{},
|
||||
account_bb_node.get(), account_other_folder_node.get(),
|
||||
- account_mobile_folder_node.get(), &max_node_id,
|
||||
+ account_mobile_folder_node.get(),
|
||||
+ tabs_collection_folder_node.get(), &max_node_id,
|
||||
&sync_metadata_str)) {
|
||||
const base::expected<std::string, metrics::BookmarksFileLoadResult>
|
||||
json_string = ReadFile(/*encryptor=*/nullptr, account_file_path,
|
||||
@@ -186,7 +189,8 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
} else if (codec.Decode(*root_dict, /*already_assigned_ids=*/{},
|
||||
account_bb_node.get(),
|
||||
account_other_folder_node.get(),
|
||||
- account_mobile_folder_node.get(), &max_node_id,
|
||||
+ account_mobile_folder_node.get(),
|
||||
+ tabs_collection_folder_node.get(), &max_node_id,
|
||||
&sync_metadata_str)) {
|
||||
ids_assigned_to_account_nodes = codec.release_assigned_ids();
|
||||
|
||||
@@ -123,7 +127,8 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
if (root_dict.has_value() &&
|
||||
codec.Decode(*root_dict, std::move(ids_assigned_to_account_nodes),
|
||||
details->bb_node(), details->other_folder_node(),
|
||||
- details->mobile_folder_node(), &max_node_id,
|
||||
+ details->mobile_folder_node(),
|
||||
+ details->tabs_collection_folder_node(), &max_node_id,
|
||||
&sync_metadata_str)) {
|
||||
@@ -248,7 +252,8 @@ std::unique_ptr<BookmarkLoadDetails> LoadBookmarks(
|
||||
} else if (codec.Decode(*root_dict,
|
||||
std::move(ids_assigned_to_account_nodes),
|
||||
details->bb_node(), details->other_folder_node(),
|
||||
- details->mobile_folder_node(), &max_node_id,
|
||||
+ details->mobile_folder_node(),
|
||||
+ details->tabs_collection_folder_node(), &max_node_id,
|
||||
&sync_metadata_str)) {
|
||||
details->set_local_or_syncable_sync_metadata_str(
|
||||
std::move(sync_metadata_str));
|
||||
diff --git a/components/sync_bookmarks/bookmark_specifics_conversions.cc b/components/sync_bookmarks/bookmark_specifics_conversions.cc
|
||||
|
||||
@@ -27,7 +27,7 @@ diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/va
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -3965,6 +3965,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@@ -4196,6 +4196,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_DOWNLOADS_MANAGER);
|
||||
}
|
||||
RecordUserAction.record("MobileMenuDownloadManager");
|
||||
@@ -35,12 +35,12 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
+ currentTab.getWebContents().getNavigationController().loadUrl(new LoadUrlParams("view-source:"+currentTab.getUrl().getSpec()));
|
||||
} else if (id == R.id.open_recently_closed_tab) {
|
||||
TabModel currentModel = mTabModelSelector.getCurrentModel();
|
||||
if (!currentModel.isIncognito()) currentModel.openMostRecentlyClosedEntry();
|
||||
if (!currentModel.isIncognito()) {
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
@@ -2797,6 +2797,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
return doOpenWebApk(currentTab);
|
||||
@@ -2888,6 +2888,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
return AppInstallMenuHandler.doOpenWebApk(this, currentTab);
|
||||
}
|
||||
|
||||
+ if (id == R.id.view_source_id) {
|
||||
@@ -54,7 +54,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
@@ -1024,6 +1024,30 @@ public abstract class AppMenuPropertiesDelegateImpl implements AppMenuProperties
|
||||
@@ -1057,6 +1057,30 @@ public abstract class AppMenuPropertiesDelegateImpl implements AppMenuProperties
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -88,8 +88,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/App
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
|
||||
@@ -406,6 +406,9 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
|
||||
modelList.add(buildAddToHomescreenListItem(currentTab, false));
|
||||
@@ -407,6 +407,9 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
|
||||
modelList.add(buildOpenInAppItem());
|
||||
}
|
||||
|
||||
+ // Add view source item
|
||||
@@ -101,8 +101,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/Cust
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
@@ -370,6 +370,9 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
modelList.add(buildAddToHomescreenListItem(currentTab, shouldShowIconBeforeItem()));
|
||||
@@ -424,6 +424,9 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
modelList.add(buildOpenInAppItem());
|
||||
}
|
||||
|
||||
+ // Add view source item
|
||||
@@ -114,7 +114,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -339,6 +339,10 @@ CHAR_LIMIT guidelines:
|
||||
@@ -346,6 +346,10 @@ CHAR_LIMIT guidelines:
|
||||
Chrome Tips
|
||||
</message>
|
||||
|
||||
|
||||
@@ -15,10 +15,10 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java
|
||||
--- a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java
|
||||
+++ b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java
|
||||
@@ -512,7 +512,12 @@ class TabGridViewBinder {
|
||||
if (result != null) {
|
||||
@@ -536,7 +536,12 @@ class TabGridViewBinder {
|
||||
TabUtils.setDrawableAndUpdateImageMatrix(thumbnail, result, thumbnailSize);
|
||||
} else {
|
||||
thumbnail.setThumbnailViewState(ThumbnailViewState.PLACEHOLDER_LOADED);
|
||||
- thumbnail.setImageDrawable(null);
|
||||
+ TabFavicon tabFavicon = model.get(TabProperties.FAVICON);
|
||||
+ if (tabFavicon != null) {
|
||||
@@ -29,7 +29,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
}
|
||||
};
|
||||
if (sThumbnailFetcherForTesting != null) {
|
||||
@@ -550,6 +555,7 @@ class TabGridViewBinder {
|
||||
@@ -574,6 +579,7 @@ class TabGridViewBinder {
|
||||
*/
|
||||
private static void setFavicon(
|
||||
ImageView faviconView, PropertyModel model, @Nullable TabFavicon favicon) {
|
||||
@@ -40,7 +40,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabProperties.java b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabProperties.java
|
||||
--- a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabProperties.java
|
||||
+++ b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabProperties.java
|
||||
@@ -130,6 +130,9 @@ public class TabProperties {
|
||||
@@ -131,6 +131,9 @@ public class TabProperties {
|
||||
public static final WritableBooleanPropertyKey FAVICON_FETCHED =
|
||||
new WritableBooleanPropertyKey();
|
||||
|
||||
@@ -50,7 +50,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
/** Property for lazily fetching favicons when required by an item in a UI. */
|
||||
public static final WritableObjectPropertyKey<TabListFaviconProvider.TabFaviconFetcher>
|
||||
FAVICON_FETCHER = new WritableObjectPropertyKey<>();
|
||||
@@ -224,6 +227,7 @@ public class TabProperties {
|
||||
@@ -233,6 +236,7 @@ public class TabProperties {
|
||||
CARD_TYPE,
|
||||
CONTENT_DESCRIPTION_TEXT_RESOLVER,
|
||||
ACTION_BUTTON_DESCRIPTION_TEXT_RESOLVER,
|
||||
@@ -58,7 +58,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
QUICK_DELETE_ANIMATION_STATUS,
|
||||
TAB_GROUP_COLOR_VIEW_PROVIDER,
|
||||
TAB_GROUP_CARD_COLOR,
|
||||
@@ -264,6 +268,7 @@ public class TabProperties {
|
||||
@@ -274,6 +278,7 @@ public class TabProperties {
|
||||
TAB_ACTION_BUTTON_DATA,
|
||||
FAVICON_FETCHED,
|
||||
FAVICON_FETCHER,
|
||||
@@ -69,7 +69,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -67,6 +67,11 @@ found in the LICENSE file.
|
||||
@@ -61,6 +61,11 @@ found in the LICENSE file.
|
||||
android:title="@string/open_external_links_incognito_title"
|
||||
android:summary="@string/open_external_links_incognito_summary"
|
||||
android:defaultValue="false" />
|
||||
@@ -84,7 +84,7 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
@@ -158,6 +158,7 @@ import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
@@ -160,6 +160,7 @@ import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
import org.chromium.chrome.browser.preferences.Pref;
|
||||
import org.chromium.chrome.browser.price_tracking.PriceDropNotificationManagerFactory;
|
||||
import org.chromium.chrome.browser.printing.TabPrinter;
|
||||
@@ -92,7 +92,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
import org.chromium.chrome.browser.profiles.ProfileManager;
|
||||
import org.chromium.chrome.browser.profiles.ProfileManagerUtils;
|
||||
@@ -679,7 +680,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
@@ -694,7 +695,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
new TabContentManager(
|
||||
this,
|
||||
mBrowserControlsManagerSupplier.get(),
|
||||
@@ -105,15 +105,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -28,6 +28,7 @@ import org.chromium.base.ContextUtils;
|
||||
@@ -30,6 +30,7 @@ import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.IntentUtils;
|
||||
import org.chromium.base.metrics.RecordHistogram;
|
||||
import org.chromium.base.metrics.RecordUserAction;
|
||||
+import java.util.function.Supplier;
|
||||
import org.chromium.base.supplier.ObservableSupplier;
|
||||
import org.chromium.base.supplier.ObservableSupplierImpl;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
@@ -99,13 +100,27 @@ import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
import org.chromium.base.supplier.ObservableSuppliers;
|
||||
import org.chromium.base.supplier.SettableMonotonicObservableSupplier;
|
||||
@@ -105,13 +106,27 @@ import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
import org.chromium.components.browser_ui.settings.ChromeSwitchPreference;
|
||||
import org.chromium.components.browser_ui.settings.ManagedPreferenceDelegate;
|
||||
|
||||
@@ -142,10 +142,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
private static final String PREF_CAN_MAKE_PAYMENT = "can_make_payment";
|
||||
private static final String PREF_PRELOAD_PAGES = "preload_pages";
|
||||
private static final String PREF_HTTPS_FIRST_MODE = "https_first_mode";
|
||||
@@ -201,6 +216,21 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
}
|
||||
@@ -198,6 +213,21 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
if (shouldHideSandboxPref(privacySandboxBridge)) {
|
||||
getPreferenceScreen().removePreference(sandboxPreference);
|
||||
}
|
||||
|
||||
+ mSnackbar = Snackbar.make(getActivity().getString(R.string.ui_relaunch_notice),
|
||||
+ new SnackbarManager.SnackbarController() {
|
||||
+ @Override
|
||||
@@ -164,7 +164,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
Preference privacyGuidePreference = findPreference(PREF_PRIVACY_GUIDE);
|
||||
// Record the launch of PG from the S&P link-row entry point
|
||||
privacyGuidePreference.setOnPreferenceClickListener(
|
||||
@@ -433,6 +463,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -462,6 +492,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
|
||||
public static final String PREF_ALLOW_CUSTOM_TAB_INTENTS = "allow_custom_tab_intents";
|
||||
public static final String PREF_OPEN_EXTERNAL_LINKS_INCOGNITO = "open_external_links_incognito";
|
||||
@@ -172,7 +172,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
|
||||
@Override
|
||||
public boolean onPreferenceChange(Preference preference, Object newValue) {
|
||||
@@ -479,6 +510,13 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -508,6 +539,13 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
SharedPreferences.Editor sharedPreferencesEditor = ContextUtils.getAppSharedPreferences().edit();
|
||||
sharedPreferencesEditor.putBoolean(PREF_OPEN_EXTERNAL_LINKS_INCOGNITO, (boolean)newValue);
|
||||
sharedPreferencesEditor.apply();
|
||||
@@ -186,7 +186,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
}
|
||||
return true;
|
||||
}
|
||||
@@ -529,6 +567,10 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -558,6 +596,10 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
: R.string.text_off);
|
||||
}
|
||||
|
||||
@@ -200,7 +200,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -6506,6 +6506,14 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -6706,6 +6706,14 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
Your <ph name="FQDN">%1$s<ex>www.amazon.com</ex></ph> timer ran out. It'll start again tomorrow.
|
||||
</message>
|
||||
|
||||
|
||||
@@ -6,13 +6,13 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../layout/custom_tabs_control_container.xml | 2 +-
|
||||
.../java/res/layout/recent_tabs_page.xml | 2 +-
|
||||
.../java/res/values-sw600dp/dimens.xml | 4 ++--
|
||||
chrome/android/java/res/values/dimens.xml | 6 +++++-
|
||||
.../java/res/values-sw600dp/dimens.xml | 3 ++-
|
||||
chrome/android/java/res/values/dimens.xml | 3 ++-
|
||||
.../browser/ChromeBaseAppCompatActivity.java | 3 +++
|
||||
.../chrome/browser/WarmupManager.java | 7 +++++--
|
||||
.../ChromeAccessibilitySettingsDelegate.java | 19 +++++++++++++++++++
|
||||
.../chrome/browser/app/ChromeActivity.java | 5 ++++-
|
||||
.../overlays/strip/StripLayoutHelper.java | 10 ++++++++--
|
||||
.../overlays/strip/StripLayoutHelper.java | 1 +
|
||||
.../strip/StripLayoutHelperManager.java | 6 +++++-
|
||||
.../scene_layer/TabStripSceneLayer.java | 8 ++++++++
|
||||
.../init/ChromeBrowserInitializer.java | 2 ++
|
||||
@@ -29,7 +29,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../java/res/layout/toolbar_tablet.xml | 2 +-
|
||||
.../java/res/values-sw600dp/dimens.xml | 5 +++--
|
||||
.../toolbar/java/res/values/dimens.xml | 6 ++++--
|
||||
.../toolbar/top/ToolbarControlContainer.java | 19 +++++++++++++++++++
|
||||
.../toolbar/top/ToolbarControlContainer.java | 6 ++++++
|
||||
.../browser/toolbar/top/ToolbarLayout.java | 5 ++++-
|
||||
.../tab_strip/HeightTransitionHandler.java | 2 ++
|
||||
.../TabStripTransitionCoordinator.java | 6 +++++-
|
||||
@@ -37,7 +37,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../accessibility/AccessibilitySettings.java | 13 +++++++++++++
|
||||
.../AccessibilitySettingsDelegate.java | 2 ++
|
||||
.../chromium/ui/base/DeviceFormFactor.java | 14 ++++++++++++++
|
||||
33 files changed, 172 insertions(+), 25 deletions(-)
|
||||
33 files changed, 149 insertions(+), 22 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/java/res/layout/custom_tabs_control_container.xml b/chrome/android/java/res/layout/custom_tabs_control_container.xml
|
||||
--- a/chrome/android/java/res/layout/custom_tabs_control_container.xml
|
||||
@@ -66,39 +66,33 @@ diff --git a/chrome/android/java/res/layout/recent_tabs_page.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/res/values-sw600dp/dimens.xml b/chrome/android/java/res/values-sw600dp/dimens.xml
|
||||
--- a/chrome/android/java/res/values-sw600dp/dimens.xml
|
||||
+++ b/chrome/android/java/res/values-sw600dp/dimens.xml
|
||||
@@ -14,8 +14,8 @@ found in the LICENSE file.
|
||||
@@ -14,7 +14,8 @@ found in the LICENSE file.
|
||||
<dimen name="compositor_tab_title_text_size">14sp</dimen>
|
||||
|
||||
<!-- Full Screen Dimensions -->
|
||||
- <dimen name="control_container_height">96dp</dimen>
|
||||
- <dimen name="custom_tabs_control_container_height">64dp</dimen>
|
||||
+ <dimen name="control_container_height_cromite">96dp</dimen>
|
||||
+ <dimen name="control_container_height_tabletui">96dp</dimen>
|
||||
+ <dimen name="control_container_height_tabletui">56dp</dimen>
|
||||
|
||||
<!-- NTP dimensions -->
|
||||
<dimen name="ntp_search_box_transition_start_offset">60dp</dimen>
|
||||
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
|
||||
--- a/chrome/android/java/res/values/dimens.xml
|
||||
+++ b/chrome/android/java/res/values/dimens.xml
|
||||
@@ -116,9 +116,13 @@ found in the LICENSE file.
|
||||
@@ -116,7 +116,8 @@ found in the LICENSE file.
|
||||
<dimen name="signin_screen_top_padding">50dp</dimen>
|
||||
|
||||
<!-- Should match toolbar_height_no_shadow -->
|
||||
- <dimen name="control_container_height">@dimen/default_action_bar_height</dimen>
|
||||
+ <dimen name="control_container_height_cromite">@dimen/default_action_bar_height</dimen>
|
||||
+ <dimen name="control_container_height_tabletui">96dp</dimen>
|
||||
+ <dimen name="control_container_height_tabletui">56dp</dimen>
|
||||
<dimen name="custom_tabs_control_container_height">@dimen/default_action_bar_height</dimen>
|
||||
|
||||
+ <!-- The combined height of the tab strip and toolbar. -->
|
||||
+ <dimen name="tab_strip_and_toolbar_height_cromite">56dp</dimen>
|
||||
+
|
||||
<!-- Find in Page dimensions -->
|
||||
<dimen name="find_in_page_popup_width">375dp</dimen>
|
||||
<dimen name="find_in_page_popup_height">64dp</dimen>
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCompatActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCompatActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCompatActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCompatActivity.java
|
||||
@@ -63,6 +63,7 @@ import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
|
||||
@@ -65,6 +65,7 @@ import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeControllerCreator;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeFieldTrialImpl;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeUtils;
|
||||
@@ -106,7 +100,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCo
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.SimpleEdgeToEdgeController;
|
||||
import org.chromium.components.browser_ui.styles.SemanticColorUtils;
|
||||
import org.chromium.components.browser_ui.util.AutomotiveUtils;
|
||||
@@ -145,6 +146,8 @@ public class ChromeBaseAppCompatActivity extends AppCompatActivity
|
||||
@@ -154,6 +155,8 @@ public class ChromeBaseAppCompatActivity extends AppCompatActivity
|
||||
protected void attachBaseContext(Context newBase) {
|
||||
super.attachBaseContext(newBase);
|
||||
|
||||
@@ -118,7 +112,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBaseAppCo
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java b/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
|
||||
@@ -63,6 +63,7 @@ import org.chromium.chrome.browser.toolbar.ControlContainer;
|
||||
@@ -64,6 +64,7 @@ import org.chromium.chrome.browser.toolbar.ControlContainer;
|
||||
import org.chromium.components.embedder_support.util.UrlConstants;
|
||||
import org.chromium.content_public.browser.WebContents;
|
||||
import org.chromium.ui.LayoutInflaterUtils;
|
||||
@@ -126,7 +120,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.j
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
import org.chromium.ui.display.DisplayUtil;
|
||||
import org.chromium.url.GURL;
|
||||
@@ -472,8 +473,10 @@ public class WarmupManager {
|
||||
@@ -475,8 +476,10 @@ public class WarmupManager {
|
||||
ControlContainer controlContainer = mainView.findViewById(R.id.control_container);
|
||||
|
||||
if (toolbarId != ActivityUtils.NO_RESOURCE_ID && controlContainer != null) {
|
||||
@@ -142,7 +136,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.j
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
@@ -65,6 +65,25 @@ public class ChromeAccessibilitySettingsDelegate implements AccessibilitySetting
|
||||
@@ -67,6 +67,25 @@ public class ChromeAccessibilitySettingsDelegate implements AccessibilitySetting
|
||||
}
|
||||
}
|
||||
|
||||
@@ -171,7 +165,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/accessibility/s
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
|
||||
@@ -830,7 +830,10 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
@@ -845,7 +845,10 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
|
||||
// Inflate the correct toolbar layout for the device.
|
||||
int toolbarLayoutId = getToolbarLayoutId();
|
||||
if (toolbarLayoutId != ActivityUtils.NO_RESOURCE_ID && controlContainer != null) {
|
||||
@@ -186,7 +180,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActiv
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
|
||||
@@ -137,6 +137,7 @@ import org.chromium.components.tab_group_sync.TabGroupSyncService;
|
||||
@@ -147,6 +147,7 @@ import org.chromium.components.tab_group_sync.TabGroupSyncService;
|
||||
import org.chromium.components.tab_group_sync.TriggerSource;
|
||||
import org.chromium.components.tab_groups.TabGroupColorId;
|
||||
import org.chromium.ui.accessibility.AccessibilityState;
|
||||
@@ -194,34 +188,18 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/over
|
||||
import org.chromium.ui.base.LocalizationUtils;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
import org.chromium.ui.util.ColorUtils;
|
||||
@@ -5317,8 +5318,13 @@ public class StripLayoutHelper
|
||||
mCloseButtonMenu.setAnchorView(tabView);
|
||||
// 3. Set the vertical offset to align the close button menu with bottom of the tab strip
|
||||
int tabHeight = mManagerHost.getHeight();
|
||||
- int verticalOffset =
|
||||
- -(tabHeight - (int) mContext.getResources().getDimension(R.dimen.tab_strip_height));
|
||||
+ int tab_strip_height =
|
||||
+ (int) mContext.getResources().getDimension(R.dimen.tab_strip_height_cromite);
|
||||
+ if (DeviceFormFactor.isForceTabletUI()) {
|
||||
+ tab_strip_height =
|
||||
+ (int) mContext.getResources().getDimension(R.dimen.tab_strip_height_tabletui);
|
||||
+ }
|
||||
+ int verticalOffset = -(tabHeight - tab_strip_height);
|
||||
mCloseButtonMenu.setVerticalOffset(verticalOffset);
|
||||
|
||||
// 4. Set the horizontal offset to align the close button menu with the right side of the
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
|
||||
@@ -105,6 +105,7 @@ import org.chromium.components.browser_ui.desktop_windowing.DesktopWindowStateMa
|
||||
@@ -116,6 +116,7 @@ import org.chromium.components.browser_ui.desktop_windowing.DesktopWindowStateMa
|
||||
import org.chromium.components.browser_ui.styles.SemanticColorUtils;
|
||||
import org.chromium.components.browser_ui.widget.scrim.ScrimProperties;
|
||||
import org.chromium.components.browser_ui.widget.gesture.BackPressHandler;
|
||||
import org.chromium.content_public.browser.LoadUrlParams;
|
||||
+import org.chromium.ui.base.DeviceFormFactor;
|
||||
import org.chromium.ui.base.LocalizationUtils;
|
||||
import org.chromium.ui.base.PageTransition;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
@@ -498,7 +499,10 @@ public class StripLayoutHelperManager
|
||||
@@ -576,7 +577,10 @@ public class StripLayoutHelperManager
|
||||
mIsHeaderCustomizationSupported =
|
||||
ToolbarFeatures.isAppHeaderCustomizationSupported(
|
||||
/* isTablet= */ true, DisplayUtil.isContextInDefaultDisplay(mContext));
|
||||
@@ -273,7 +251,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrow
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
@@ -807,7 +807,9 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
@@ -893,7 +893,9 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
|
||||
@Override
|
||||
public int getControlContainerHeightResource() {
|
||||
@@ -287,7 +265,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
@@ -120,6 +120,8 @@ import org.chromium.chrome.browser.paint_preview.DemoPaintPreview;
|
||||
@@ -131,6 +131,8 @@ import org.chromium.chrome.browser.paint_preview.DemoPaintPreview;
|
||||
import org.chromium.chrome.browser.password_manager.ManagePasswordsReferrer;
|
||||
import org.chromium.chrome.browser.password_manager.PasswordManagerLauncher;
|
||||
import org.chromium.chrome.browser.pdf.PdfPage;
|
||||
@@ -296,7 +274,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordi
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
import org.chromium.chrome.browser.quick_delete.QuickDeleteController;
|
||||
import org.chromium.chrome.browser.quick_delete.QuickDeleteDelegateImpl;
|
||||
@@ -1947,7 +1949,9 @@ public class RootUiCoordinator
|
||||
@@ -2058,7 +2060,9 @@ public class RootUiCoordinator
|
||||
|
||||
protected int getFindToolbarStub() {
|
||||
int stubId = R.id.find_toolbar_stub;
|
||||
@@ -321,7 +299,7 @@ diff --git a/chrome/browser/preferences/BUILD.gn b/chrome/browser/preferences/BU
|
||||
diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
--- a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
+++ b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
@@ -358,6 +358,7 @@ public final class ChromePreferenceKeys {
|
||||
@@ -417,6 +417,7 @@ public final class ChromePreferenceKeys {
|
||||
/** Whether the app-specific history info text was already seen by users. */
|
||||
public static final String HISTORY_APP_SPECIFIC_INFO_SEEN =
|
||||
"Chrome.History.AppSpecificInfoSeen";
|
||||
@@ -372,15 +350,15 @@ diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/chrome/browser/ui/desktop_windowing/AppHeaderUtils.java b/chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/chrome/browser/ui/desktop_windowing/AppHeaderUtils.java
|
||||
--- a/chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/chrome/browser/ui/desktop_windowing/AppHeaderUtils.java
|
||||
+++ b/chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/chrome/browser/ui/desktop_windowing/AppHeaderUtils.java
|
||||
@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher.Activit
|
||||
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
|
||||
import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
@@ -20,6 +20,7 @@ import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
|
||||
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher.ActivityState;
|
||||
import org.chromium.components.browser_ui.desktop_windowing.DesktopWindowStateManager;
|
||||
+import org.chromium.ui.base.DeviceFormFactor;
|
||||
import org.chromium.ui.display.DisplayUtil;
|
||||
import org.chromium.ui.insets.InsetsRectProvider;
|
||||
|
||||
@@ -245,6 +246,7 @@ public class AppHeaderUtils {
|
||||
@@ -169,6 +170,7 @@ public class AppHeaderUtils {
|
||||
*/
|
||||
static @DesktopWindowHeuristicResult int checkIsInDesktopWindow(
|
||||
InsetsRectProvider insetsRectProvider, Context context) {
|
||||
@@ -391,7 +369,7 @@ diff --git a/chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/c
|
||||
diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarCoordinator.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarCoordinator.java
|
||||
--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarCoordinator.java
|
||||
+++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarCoordinator.java
|
||||
@@ -1008,7 +1008,7 @@ public class LocationBarCoordinator
|
||||
@@ -1061,7 +1061,7 @@ public class LocationBarCoordinator
|
||||
}
|
||||
|
||||
private boolean isTabletWindow() {
|
||||
@@ -403,7 +381,7 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -1507,6 +1507,13 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -1592,6 +1592,13 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
Privacy guide explanation closed
|
||||
</message>
|
||||
|
||||
@@ -457,14 +435,14 @@ diff --git a/chrome/browser/ui/android/toolbar/java/res/layout/control_container
|
||||
diff --git a/chrome/browser/ui/android/toolbar/java/res/layout/toolbar_tablet.xml b/chrome/browser/ui/android/toolbar/java/res/layout/toolbar_tablet.xml
|
||||
--- a/chrome/browser/ui/android/toolbar/java/res/layout/toolbar_tablet.xml
|
||||
+++ b/chrome/browser/ui/android/toolbar/java/res/layout/toolbar_tablet.xml
|
||||
@@ -15,7 +15,7 @@ found in the LICENSE file.
|
||||
@@ -14,7 +14,7 @@ found in the LICENSE file.
|
||||
android:id="@+id/toolbar"
|
||||
android:layout_width="match_parent"
|
||||
android:layout_height="@dimen/toolbar_height_no_shadow"
|
||||
- android:layout_marginTop="@dimen/tab_strip_height"
|
||||
+ android:layout_marginTop="@dimen/tab_strip_height_tabletui"
|
||||
android:background="@macro/default_bg_color"
|
||||
>
|
||||
>
|
||||
|
||||
diff --git a/chrome/browser/ui/android/toolbar/java/res/values-sw600dp/dimens.xml b/chrome/browser/ui/android/toolbar/java/res/values-sw600dp/dimens.xml
|
||||
--- a/chrome/browser/ui/android/toolbar/java/res/values-sw600dp/dimens.xml
|
||||
@@ -506,27 +484,14 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
import android.graphics.Canvas;
|
||||
import android.graphics.Color;
|
||||
import android.graphics.PorterDuff;
|
||||
@@ -172,6 +173,24 @@ public class ToolbarControlContainer extends OptimizedFrameLayout
|
||||
@@ -174,6 +175,11 @@ public class ToolbarControlContainer extends OptimizedFrameLayout
|
||||
@Initializer
|
||||
public void initWithToolbar(int toolbarLayoutId, int toolbarLayoutHeightResId) {
|
||||
try (TraceEvent te = TraceEvent.scoped("ToolbarControlContainer.initWithToolbar")) {
|
||||
+ if (DeviceFormFactor.isForceTabletUI() && toolbarLayoutHeightResId != 0) {
|
||||
+ toolbarLayoutHeightResId = R.dimen.tab_strip_height_tabletui;
|
||||
+ toolbarLayoutHeightResId = R.dimen.control_container_height_tabletui;
|
||||
+ Resources res = getContext().getResources();
|
||||
+ setMinimumHeight((int) res.getDimension(toolbarLayoutHeightResId));
|
||||
+ int tab_strip_height =
|
||||
+ (int) res.getDimension(R.dimen.tab_strip_height_tabletui);
|
||||
+
|
||||
+ View view = findViewById(R.id.toolbar_stub);
|
||||
+ if (view != null)
|
||||
+ ((MarginLayoutParams)view.getLayoutParams()).topMargin = tab_strip_height;
|
||||
+
|
||||
+ view = findViewById(R.id.toolbar_hairline);
|
||||
+ if (view != null) view.setVisibility(View.GONE);
|
||||
+
|
||||
+ view = findViewById(R.id.find_toolbar_stub);
|
||||
+ if (view != null)
|
||||
+ ((MarginLayoutParams)view.getLayoutParams()).topMargin = tab_strip_height;
|
||||
+ }
|
||||
mToolbarContainer = findViewById(R.id.toolbar_container);
|
||||
mToolbarLayoutHeight = getResources().getDimensionPixelSize(toolbarLayoutHeightResId);
|
||||
@@ -534,7 +499,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java
|
||||
--- a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java
|
||||
+++ b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java
|
||||
@@ -65,6 +65,7 @@ import org.chromium.chrome.browser.util.BrowserUiUtils.ModuleTypeOnStartAndNtp;
|
||||
@@ -66,6 +66,7 @@ import org.chromium.chrome.browser.util.BrowserUiUtils.ModuleTypeOnStartAndNtp;
|
||||
import org.chromium.components.feature_engagement.Tracker;
|
||||
import org.chromium.ui.base.ViewUtils;
|
||||
import org.chromium.ui.util.MotionEventUtils;
|
||||
@@ -542,10 +507,10 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
import org.chromium.ui.util.TokenHolder;
|
||||
import org.chromium.url.GURL;
|
||||
|
||||
@@ -588,7 +589,9 @@ public abstract class ToolbarLayout extends FrameLayout
|
||||
* not have a tab strip.
|
||||
@@ -591,7 +592,9 @@ public abstract class ToolbarLayout extends FrameLayout
|
||||
* @see Toolbar#getTabStripHeight()
|
||||
*/
|
||||
protected int getTabStripHeightFromResource() {
|
||||
public int getTabStripHeightFromResource() {
|
||||
- return getResources().getDimensionPixelSize(R.dimen.tab_strip_height);
|
||||
+ if (DeviceFormFactor.isForceTabletUI())
|
||||
+ return getResources().getDimensionPixelSize(R.dimen.tab_strip_height_tabletui);
|
||||
@@ -556,7 +521,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/HeightTransitionHandler.java b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/HeightTransitionHandler.java
|
||||
--- a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/HeightTransitionHandler.java
|
||||
+++ b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/HeightTransitionHandler.java
|
||||
@@ -27,6 +27,7 @@ import org.chromium.chrome.browser.toolbar.ControlContainer;
|
||||
@@ -29,6 +29,7 @@ import org.chromium.chrome.browser.toolbar.ControlContainer;
|
||||
import org.chromium.chrome.browser.toolbar.top.tab_strip.TabStripTransitionCoordinator.TabStripTransitionDelegate;
|
||||
import org.chromium.chrome.browser.toolbar.top.tab_strip.TabStripTransitionCoordinator.TabStripTransitionHandler;
|
||||
import org.chromium.ui.base.ViewUtils;
|
||||
@@ -564,7 +529,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
import org.chromium.ui.resources.dynamics.DynamicResourceReadyOnceCallback;
|
||||
import org.chromium.ui.util.TokenHolder;
|
||||
|
||||
@@ -492,6 +493,7 @@ class HeightTransitionHandler {
|
||||
@@ -514,6 +515,7 @@ class HeightTransitionHandler {
|
||||
|
||||
/** Get the min screen width (in dp) required for the tab strip to become visible. */
|
||||
private static int getScreenWidthThresholdDp() {
|
||||
@@ -575,7 +540,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/TabStripTransitionCoordinator.java b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/TabStripTransitionCoordinator.java
|
||||
--- a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/TabStripTransitionCoordinator.java
|
||||
+++ b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/TabStripTransitionCoordinator.java
|
||||
@@ -24,6 +24,7 @@ import org.chromium.chrome.browser.ui.desktop_windowing.AppHeaderUtils;
|
||||
@@ -25,6 +25,7 @@ import org.chromium.chrome.browser.ui.desktop_windowing.AppHeaderUtils;
|
||||
import org.chromium.components.browser_ui.desktop_windowing.AppHeaderState;
|
||||
import org.chromium.components.browser_ui.desktop_windowing.DesktopWindowStateManager;
|
||||
import org.chromium.components.browser_ui.desktop_windowing.DesktopWindowStateManager.AppHeaderObserver;
|
||||
@@ -583,7 +548,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
|
||||
/**
|
||||
* Class used to manage tab strip visibility and height updates.
|
||||
@@ -170,7 +171,10 @@ public class TabStripTransitionCoordinator implements ComponentCallbacks, AppHea
|
||||
@@ -171,7 +172,10 @@ public class TabStripTransitionCoordinator implements ComponentCallbacks, AppHea
|
||||
mTabStripReservedTopPadding =
|
||||
controlContainerView()
|
||||
.getResources()
|
||||
@@ -598,7 +563,7 @@ diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/brow
|
||||
diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
--- a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
+++ b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
@@ -41,6 +41,11 @@ found in the LICENSE file.
|
||||
@@ -46,6 +46,11 @@ found in the LICENSE file.
|
||||
android:summary="@string/caret_browsing_summary"
|
||||
android:title="@string/caret_browsing_title" />
|
||||
|
||||
@@ -613,7 +578,7 @@ diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibil
|
||||
diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
--- a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
+++ b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
@@ -31,6 +31,7 @@ import org.chromium.content_public.browser.ContentFeatureMap;
|
||||
@@ -39,6 +39,7 @@ import org.chromium.content_public.browser.ContentFeatureMap;
|
||||
import org.chromium.ui.base.UiAndroidFeatureList;
|
||||
|
||||
import org.chromium.chrome.browser.settings.ChromeBaseSettingsFragment;
|
||||
@@ -621,9 +586,9 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
|
||||
/** Fragment to keep track of all the accessibility related preferences. */
|
||||
@NullMarked
|
||||
@@ -51,6 +52,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
public static final String PREF_TOUCHPAD_OVERSCROLL_HISTORY_NAVIGATION =
|
||||
"touchpad_overscroll_history_navigation";
|
||||
@@ -80,6 +81,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
}
|
||||
};
|
||||
|
||||
+ private BooleanPreferenceDelegate mForceTabletUIDelegate;
|
||||
+ static final String PREF_FORCE_TABLET_UI = "force_tablet_ui";
|
||||
@@ -631,9 +596,9 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
private PageZoomPreference mPageZoomDefaultZoomPref;
|
||||
private ChromeSwitchPreference mPageZoomIncludeOSAdjustment;
|
||||
private ChromeSwitchPreference mPageZoomAlwaysShowPref;
|
||||
@@ -126,6 +130,12 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
mDelegate.getReaderAccessibilityDelegate().getValue());
|
||||
readerForAccessibilityPref.setOnPreferenceChangeListener(this);
|
||||
@@ -167,6 +171,12 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
readerEnableLinks.setOnPreferenceChangeListener(this);
|
||||
}
|
||||
|
||||
+ ChromeSwitchPreference forceTabletUiPref =
|
||||
+ (ChromeSwitchPreference) findPreference(PREF_FORCE_TABLET_UI);
|
||||
@@ -644,7 +609,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
Preference captions = findPreference(PREF_CAPTIONS);
|
||||
captions.setOnPreferenceClickListener(
|
||||
preference -> {
|
||||
@@ -212,6 +222,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
@@ -262,6 +272,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
public boolean onPreferenceChange(Preference preference, Object newValue) {
|
||||
if (PREF_FORCE_ENABLE_ZOOM.equals(preference.getKey())) {
|
||||
mDelegate.getForceEnableZoomAccessibilityDelegate().setValue((Boolean) newValue);
|
||||
@@ -657,7 +622,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettingsDelegate.java b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettingsDelegate.java
|
||||
--- a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettingsDelegate.java
|
||||
+++ b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettingsDelegate.java
|
||||
@@ -41,6 +41,8 @@ public interface AccessibilitySettingsDelegate {
|
||||
@@ -42,6 +42,8 @@ public interface AccessibilitySettingsDelegate {
|
||||
*/
|
||||
BrowserContextHandle getBrowserContextHandle();
|
||||
|
||||
|
||||
@@ -14,7 +14,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -89,6 +89,11 @@ found in the LICENSE file.
|
||||
@@ -82,6 +82,11 @@ found in the LICENSE file.
|
||||
android:title="@string/incognito_settings_title"
|
||||
android:summary="@string/incognito_settings_summary"
|
||||
android:fragment="org.chromium.chrome.browser.privacy.settings.IncognitoSettings"/>
|
||||
@@ -29,7 +29,7 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -47,6 +47,7 @@ import org.chromium.base.ApplicationStatus;
|
||||
@@ -58,6 +58,7 @@ import org.chromium.base.ApplicationStatus;
|
||||
import org.chromium.base.Callback;
|
||||
import org.chromium.base.CallbackController;
|
||||
import org.chromium.base.CallbackUtils;
|
||||
@@ -37,9 +37,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
import org.chromium.base.CommandLine;
|
||||
import org.chromium.base.DeviceInfo;
|
||||
import org.chromium.base.IntentUtils;
|
||||
@@ -2175,8 +2176,10 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
boolean hadCipherData =
|
||||
CipherLazyHolder.sCipherInstance.restoreFromBundle(getSavedInstanceState());
|
||||
@@ -2291,8 +2292,10 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
ActivityRestoreState.NUM_ENTRIES);
|
||||
}
|
||||
|
||||
+ String PREF_CLOSE_TABS_ON_EXIT = "close_tabs_on_exit";
|
||||
boolean noRestoreState =
|
||||
@@ -52,7 +52,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -9,6 +9,7 @@ import static org.chromium.components.content_settings.PrefNames.COOKIE_CONTROLS
|
||||
@@ -10,6 +10,7 @@ import static org.chromium.ui.R.drawable.gshield_colorful;
|
||||
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
@@ -60,15 +60,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
import android.graphics.drawable.Drawable;
|
||||
import android.os.Bundle;
|
||||
import android.text.SpannableString;
|
||||
@@ -22,6 +23,7 @@ import androidx.annotation.VisibleForTesting;
|
||||
import androidx.preference.Preference;
|
||||
@@ -24,6 +25,7 @@ import androidx.preference.Preference;
|
||||
|
||||
import org.chromium.base.ApiCompatibilityUtils;
|
||||
import org.chromium.base.Callback;
|
||||
+import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.IntentUtils;
|
||||
import org.chromium.base.metrics.RecordHistogram;
|
||||
import org.chromium.base.metrics.RecordUserAction;
|
||||
@@ -113,6 +115,8 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -119,6 +121,8 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
private final SharedPreferencesManager mSharedPreferencesManager =
|
||||
ChromeSharedPreferences.getInstance();
|
||||
|
||||
@@ -76,8 +76,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
+
|
||||
private ManagedPreferenceDelegate mManagedPreferenceDelegate;
|
||||
@VisibleForTesting static final String PREF_THIRD_PARTY_COOKIES = "third_party_cookies";
|
||||
@VisibleForTesting static final String PREF_TRACKING_PROTECTION = "tracking_protection";
|
||||
@@ -374,7 +378,11 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
private static final String PREF_ADVANCED_PROTECTION_INFO = "advanced_protection_info";
|
||||
@@ -403,7 +407,11 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@Override
|
||||
public boolean onPreferenceChange(Preference preference, Object newValue) {
|
||||
String key = preference.getKey();
|
||||
@@ -90,7 +90,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
UserPrefs.get(getProfile())
|
||||
.setBoolean(Pref.CAN_MAKE_PAYMENT_ENABLED, (boolean) newValue);
|
||||
} else if (PREF_HTTPS_FIRST_MODE_LEGACY.equals(key)) {
|
||||
@@ -434,6 +442,11 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -463,6 +471,11 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
getContext(), getProfile()));
|
||||
}
|
||||
|
||||
@@ -128,7 +128,7 @@ diff --git a/chrome/browser/tab_group_sync/android/java/src/org/chromium/chrome/
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -2898,6 +2898,12 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -2978,6 +2978,12 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_ACCESSIBILITY_TAB_SWITCHER_TITLE" desc="Accessibility label of the current window when Grid Tab Switcher is shown.">
|
||||
All tabs
|
||||
</message>
|
||||
|
||||
@@ -9,7 +9,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../tab_management/TabGridDialogMediator.java | 12 +++++++++++-
|
||||
.../tasks/tab_management/TabGroupUiMediator.java | 8 +++++++-
|
||||
.../java/res/xml/homepage_preferences.xml | 5 +++++
|
||||
.../strip/TabGroupContextMenuCoordinator.java | 11 ++++++++++-
|
||||
.../strip/TabGroupContextMenuCoordinator.java | 10 +++++++++-
|
||||
.../chrome/browser/homepage/HomepageManager.java | 16 ++++++++++++++++
|
||||
.../homepage/settings/HomepageSettings.java | 12 ++++++++++++
|
||||
.../chrome/browser/metrics/LaunchMetrics.java | 1 -
|
||||
@@ -19,12 +19,12 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../android/strings/android_chrome_strings.grd | 3 +++
|
||||
chrome/browser/ui/browser_ui_prefs.cc | 2 ++
|
||||
chrome/common/pref_names.h | 4 ++++
|
||||
13 files changed, 80 insertions(+), 4 deletions(-)
|
||||
13 files changed, 79 insertions(+), 4 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediator.java b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediator.java
|
||||
--- a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediator.java
|
||||
+++ b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediator.java
|
||||
@@ -101,6 +101,7 @@ import org.chromium.components.collaboration.messaging.PersistentNotificationTyp
|
||||
@@ -103,6 +103,7 @@ import org.chromium.components.collaboration.messaging.PersistentNotificationTyp
|
||||
import org.chromium.components.data_sharing.DataSharingService;
|
||||
import org.chromium.components.data_sharing.GroupMember;
|
||||
import org.chromium.components.data_sharing.member_role.MemberRole;
|
||||
@@ -32,7 +32,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
import org.chromium.components.tab_group_sync.EitherId.EitherGroupId;
|
||||
import org.chromium.components.tab_group_sync.LocalTabGroupId;
|
||||
import org.chromium.components.tab_group_sync.TabGroupSyncService;
|
||||
@@ -121,6 +122,9 @@ import java.util.Objects;
|
||||
@@ -123,6 +124,9 @@ import java.util.Objects;
|
||||
import java.util.Set;
|
||||
import java.util.function.Supplier;
|
||||
|
||||
@@ -42,7 +42,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
/**
|
||||
* A mediator for the TabGridDialog component, responsible for communicating with the components'
|
||||
* coordinator as well as managing the business logic for dialog show/hide.
|
||||
@@ -1034,9 +1038,15 @@ public class TabGridDialogMediator
|
||||
@@ -1026,9 +1030,15 @@ public class TabGridDialogMediator
|
||||
UrlConstantResolver urlConstantResolver =
|
||||
UrlConstantResolverFactory.getForProfile(profile);
|
||||
|
||||
@@ -62,7 +62,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java
|
||||
--- a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java
|
||||
+++ b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java
|
||||
@@ -35,6 +35,7 @@ import org.chromium.chrome.browser.data_sharing.DataSharingServiceFactory;
|
||||
@@ -37,6 +37,7 @@ import org.chromium.chrome.browser.data_sharing.DataSharingServiceFactory;
|
||||
import org.chromium.chrome.browser.data_sharing.ui.shared_image_tiles.SharedImageTilesConfig;
|
||||
import org.chromium.chrome.browser.data_sharing.ui.shared_image_tiles.SharedImageTilesCoordinator;
|
||||
import org.chromium.chrome.browser.layouts.LayoutStateProvider;
|
||||
@@ -70,7 +70,7 @@ diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser
|
||||
import org.chromium.chrome.browser.layouts.LayoutStateProvider.LayoutStateObserver;
|
||||
import org.chromium.chrome.browser.layouts.LayoutType;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
@@ -425,10 +426,15 @@ public class TabGroupUiMediator implements BackPressHandler {
|
||||
@@ -428,10 +429,15 @@ public class TabGroupUiMediator implements BackPressHandler {
|
||||
UrlConstantResolverFactory.getForProfile(currentTabProfile);
|
||||
|
||||
Tab parentTabToAttach = relatedTabs.get(relatedTabs.size() - 1);
|
||||
@@ -105,7 +105,7 @@ diff --git a/chrome/android/java/res/xml/homepage_preferences.xml b/chrome/andro
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/TabGroupContextMenuCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/TabGroupContextMenuCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/TabGroupContextMenuCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/TabGroupContextMenuCoordinator.java
|
||||
@@ -89,6 +89,9 @@ import java.util.List;
|
||||
@@ -93,6 +93,9 @@ import java.util.List;
|
||||
import java.util.function.BiConsumer;
|
||||
import java.util.function.Supplier;
|
||||
|
||||
@@ -115,19 +115,18 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/over
|
||||
/**
|
||||
* A coordinator for the context menu on the tab strip by long-pressing on the group titles. It is
|
||||
* responsible for creating a list of menu items, setting up the menu and displaying the menu.
|
||||
@@ -239,9 +242,15 @@ public class TabGroupContextMenuCoordinator extends TabStripReorderingHelper<Tok
|
||||
/* didCloseCallback= */ null);
|
||||
RecordUserAction.record("MobileToolbarTabGroupMenu.DeleteGroup");
|
||||
} else if (menuId == R.id.open_new_tab_in_group) {
|
||||
+ String url = UrlConstants.NTP_URL;
|
||||
+ if (UrlConstants.NTP_URL.equals(url)
|
||||
+ && HomepageManager.getInstance().getPrefNTPIsHomepageEnabled()) {
|
||||
@@ -246,9 +249,14 @@ public class TabGroupContextMenuCoordinator extends TabStripReorderingHelper<Tok
|
||||
UrlConstantResolver resolver =
|
||||
UrlConstantResolverFactory.getForProfile(
|
||||
tabGroupModelFilter.getTabModel().getProfile());
|
||||
+ String url = resolver.getNtpUrl();
|
||||
+ if (HomepageManager.getInstance().getPrefNTPIsHomepageEnabled()) {
|
||||
+ GURL gurl = HomepageManager.getInstance().getHomepageGurl(tabModelSupplier.get().isIncognitoBranded());
|
||||
+ url = gurl != null ? gurl.getSpec() : url;
|
||||
+ }
|
||||
TabGroupUtils.openUrlInGroup(
|
||||
tabGroupModelFilter,
|
||||
- UrlConstants.NTP_URL,
|
||||
- resolver.getNtpUrl(),
|
||||
+ url,
|
||||
tabId,
|
||||
TabLaunchType.FROM_TAB_GROUP_UI);
|
||||
@@ -161,7 +160,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/Homepa
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/homepage/settings/HomepageSettings.java
|
||||
@@ -27,6 +27,7 @@ import org.chromium.components.browser_ui.settings.SettingsUtils;
|
||||
@@ -28,6 +28,7 @@ import org.chromium.components.browser_ui.settings.SettingsUtils;
|
||||
import org.chromium.components.embedder_support.util.UrlUtilities;
|
||||
import org.chromium.components.url_formatter.UrlFormatter;
|
||||
import org.chromium.url.GURL;
|
||||
@@ -169,7 +168,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settin
|
||||
|
||||
/** Fragment that allows the user to configure homepage related preferences. */
|
||||
@NullMarked
|
||||
@@ -36,6 +37,8 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
@@ -37,6 +38,8 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
@VisibleForTesting
|
||||
public static final String PREF_HOMEPAGE_RADIO_GROUP = "homepage_radio_group";
|
||||
|
||||
@@ -177,8 +176,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/settin
|
||||
+
|
||||
private HomepageManager mHomepageManager;
|
||||
private RadioButtonGroupHomepagePreference mRadioButtons;
|
||||
private final ObservableSupplierImpl<String> mPageTitle = new ObservableSupplierImpl<>();
|
||||
@@ -103,6 +106,15 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
private final SettableMonotonicObservableSupplier<String> mPageTitle =
|
||||
@@ -105,6 +108,15 @@ public class HomepageSettings extends ChromeBaseSettingsFragment {
|
||||
mRadioButtons.setOnHomepagePreferenceChangeListener(this::onRadioButtonGroupChanged);
|
||||
mRadioButtons.setupPreferenceValues(createPreferenceValuesForRadioGroup());
|
||||
|
||||
@@ -213,10 +212,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/Chrome
|
||||
import org.chromium.chrome.browser.compositor.CompositorViewHolder;
|
||||
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
||||
+import org.chromium.chrome.browser.homepage.HomepageManager;
|
||||
import org.chromium.chrome.browser.multiwindow.MultiInstanceManager;
|
||||
import org.chromium.chrome.browser.multiwindow.MultiInstanceManager.NewWindowAppSource;
|
||||
import org.chromium.chrome.browser.prefetch.settings.PreloadPagesSettingsBridge;
|
||||
@@ -583,6 +584,13 @@ public class ChromeTabCreator implements TabCreator, NeedsTabModel, NeedsTabMode
|
||||
import org.chromium.chrome.browser.prefetch.settings.PreloadPagesState;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
@@ -576,6 +577,13 @@ public class ChromeTabCreator implements TabCreator, NeedsTabModel, NeedsTabMode
|
||||
*/
|
||||
public @Nullable Tab launchUrl(
|
||||
String url, @TabLaunchType int type, @Nullable Intent intent, long intentTimestamp) {
|
||||
@@ -233,7 +232,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/Chrome
|
||||
diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
--- a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
+++ b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
|
||||
@@ -371,6 +371,7 @@ public final class ChromePreferenceKeys {
|
||||
@@ -430,6 +430,7 @@ public final class ChromePreferenceKeys {
|
||||
public static final String HOMEPAGE_USE_CHROME_NTP = "Chrome.Homepage.UseNTP";
|
||||
public static final String HOMEPAGE_USE_DEFAULT_URI = "homepage_partner_enabled";
|
||||
|
||||
@@ -255,7 +254,7 @@ diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -1348,6 +1348,9 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -1422,6 +1422,9 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
<message name="IDS_CLEAR_BROWSING_DATA_TAB_PERIOD_HOUR" desc="The option to delete browsing data from the last hour.">
|
||||
Last hour
|
||||
</message>
|
||||
@@ -268,19 +267,19 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
diff --git a/chrome/browser/ui/browser_ui_prefs.cc b/chrome/browser/ui/browser_ui_prefs.cc
|
||||
--- a/chrome/browser/ui/browser_ui_prefs.cc
|
||||
+++ b/chrome/browser/ui/browser_ui_prefs.cc
|
||||
@@ -123,6 +123,8 @@ void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
|
||||
@@ -126,6 +126,8 @@ void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
|
||||
pref_registration_flags);
|
||||
registry->RegisterBooleanPref(prefs::kPinSplitTabButton, false,
|
||||
pref_registration_flags);
|
||||
+ registry->RegisterBooleanPref(prefs::kNewTabPageIsHomePage, false,
|
||||
+ PrefRegistry::NO_REGISTRATION_FLAGS);
|
||||
|
||||
registry->RegisterInt64Pref(prefs::kDefaultBrowserLastDeclined, 0);
|
||||
registry->RegisterInt64Pref(prefs::kDefaultBrowserInfobarLastDeclined, 0);
|
||||
registry->RegisterBooleanPref(prefs::kWebAppCreateOnDesktop, true);
|
||||
diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
|
||||
--- a/chrome/common/pref_names.h
|
||||
+++ b/chrome/common/pref_names.h
|
||||
@@ -1347,6 +1347,10 @@ inline constexpr char kSplitViewDragAndDropNudgeUsedCount[] =
|
||||
@@ -1265,6 +1265,10 @@ inline constexpr char kSplitViewDragAndDropNudgeUsedCount[] =
|
||||
// by enterprise policy.
|
||||
inline constexpr char kGeminiSettings[] = "browser.gemini_settings";
|
||||
|
||||
|
||||
@@ -55,7 +55,7 @@ HcmV?d00001
|
||||
diff --git a/components/search_engines/BUILD.gn b/components/search_engines/BUILD.gn
|
||||
--- a/components/search_engines/BUILD.gn
|
||||
+++ b/components/search_engines/BUILD.gn
|
||||
@@ -72,6 +72,7 @@ static_library("search_engines") {
|
||||
@@ -74,6 +74,7 @@ static_library("search_engines") {
|
||||
"//third_party/metrics_proto",
|
||||
"//third_party/omnibox_proto",
|
||||
"//third_party/search_engines_data:prepopulated_engines",
|
||||
@@ -63,18 +63,18 @@ diff --git a/components/search_engines/BUILD.gn b/components/search_engines/BUIL
|
||||
]
|
||||
|
||||
deps = [
|
||||
@@ -161,6 +162,7 @@ source_set("search_engine_utils") {
|
||||
":search_engine_type",
|
||||
"//components/google/core/common",
|
||||
@@ -165,6 +166,7 @@ source_set("search_engine_utils") {
|
||||
"//components/regional_capabilities",
|
||||
"//components/regional_capabilities:switches",
|
||||
"//third_party/search_engines_data:prepopulated_engines",
|
||||
+ "cromite:cromite_prepopulated_engines",
|
||||
]
|
||||
|
||||
deps = [ "//url" ]
|
||||
@@ -256,6 +258,7 @@ source_set("unit_tests") {
|
||||
"//testing/gmock",
|
||||
@@ -263,6 +265,7 @@ source_set("unit_tests") {
|
||||
"//testing/gtest",
|
||||
"//third_party/search_engines_data:prepopulated_engines",
|
||||
"//third_party/search_engines_data:regional_settings",
|
||||
+ "cromite:cromite_prepopulated_engines",
|
||||
"//ui/base",
|
||||
"//url",
|
||||
@@ -160,12 +160,12 @@ diff --git a/components/search_engines/search_engine_choice/search_engine_choice
|
||||
diff --git a/components/search_engines/search_engine_type.h b/components/search_engines/search_engine_type.h
|
||||
--- a/components/search_engines/search_engine_type.h
|
||||
+++ b/components/search_engines/search_engine_type.h
|
||||
@@ -98,11 +98,16 @@ enum SearchEngineType {
|
||||
SEARCH_ENGINE_FREESPOKE = 78,
|
||||
@@ -99,11 +99,16 @@ enum SearchEngineType {
|
||||
SEARCH_ENGINE_KAGI = 79,
|
||||
SEARCH_ENGINE_STARTER_PACK_AI_MODE = 80,
|
||||
+ SEARCH_ENGINE_GOOGLE_EN = 81,
|
||||
+ SEARCH_ENGINE_DUCKDUCKGOLIGHT = 82,
|
||||
SEARCH_ENGINE_YAHOO_JP = 81,
|
||||
+ SEARCH_ENGINE_GOOGLE_EN = 82,
|
||||
+ SEARCH_ENGINE_DUCKDUCKGOLIGHT = 83,
|
||||
|
||||
SEARCH_ENGINE_MAX // Bounding value needed for UMA histogram macro.
|
||||
};
|
||||
@@ -180,7 +180,7 @@ diff --git a/components/search_engines/search_engine_type.h b/components/search_
|
||||
diff --git a/components/search_engines/template_url_prepopulate_data.cc b/components/search_engines/template_url_prepopulate_data.cc
|
||||
--- a/components/search_engines/template_url_prepopulate_data.cc
|
||||
+++ b/components/search_engines/template_url_prepopulate_data.cc
|
||||
@@ -28,6 +28,8 @@
|
||||
@@ -27,6 +27,8 @@
|
||||
#include "components/search_engines/template_url_data_util.h"
|
||||
#include "third_party/search_engines_data/resources/definitions/prepopulated_engines.h"
|
||||
|
||||
@@ -189,7 +189,7 @@ diff --git a/components/search_engines/template_url_prepopulate_data.cc b/compon
|
||||
namespace TemplateURLPrepopulateData {
|
||||
|
||||
// Helpers --------------------------------------------------------------------
|
||||
@@ -154,7 +156,7 @@ int GetDataVersion(PrefService* prefs) {
|
||||
@@ -152,7 +154,7 @@ int GetDataVersion(PrefService* prefs) {
|
||||
kCurrentDataVersion;
|
||||
}
|
||||
|
||||
@@ -198,7 +198,7 @@ diff --git a/components/search_engines/template_url_prepopulate_data.cc b/compon
|
||||
PrefService& prefs,
|
||||
const std::vector<const PrepopulatedEngine*>&
|
||||
regional_prepopulated_engines) {
|
||||
@@ -170,6 +172,17 @@ std::vector<std::unique_ptr<TemplateURLData>> GetPrepopulatedEngines(
|
||||
@@ -168,6 +170,17 @@ std::vector<std::unique_ptr<TemplateURLData>> GetPrepopulatedEngines(
|
||||
&PrepopulatedEngineToTemplateURLData);
|
||||
}
|
||||
|
||||
@@ -216,7 +216,7 @@ diff --git a/components/search_engines/template_url_prepopulate_data.cc b/compon
|
||||
std::unique_ptr<TemplateURLData> GetPrepopulatedEngine(
|
||||
PrefService& prefs,
|
||||
const std::vector<const PrepopulatedEngine*>& regional_prepopulated_engines,
|
||||
@@ -190,10 +203,14 @@ std::vector<std::unique_ptr<TemplateURLData>> GetLocalPrepopulatedEngines(
|
||||
@@ -188,10 +201,14 @@ std::vector<std::unique_ptr<TemplateURLData>> GetLocalPrepopulatedEngines(
|
||||
return std::vector<std::unique_ptr<TemplateURLData>>();
|
||||
}
|
||||
|
||||
@@ -265,8 +265,8 @@ diff --git a/tools/json_to_struct/json_to_struct.gni b/tools/json_to_struct/json
|
||||
+
|
||||
action(action_name) {
|
||||
visibility = [ ":$source_set_name" ]
|
||||
script = "//build/gn_run_binary.py"
|
||||
@@ -63,6 +68,10 @@ template("json_to_struct") {
|
||||
script = "//tools/json_to_struct/json_to_struct.py"
|
||||
@@ -61,6 +66,10 @@ template("json_to_struct") {
|
||||
"--namespace=" + invoker.namespace,
|
||||
"--schema=" + rebase_path(invoker.schema_file, root_build_dir),
|
||||
]
|
||||
@@ -402,7 +402,7 @@ diff --git a/tools/json_to_struct/struct_generator.py b/tools/json_to_struct/str
|
||||
diff --git a/tools/variations/fieldtrial_to_struct.py b/tools/variations/fieldtrial_to_struct.py
|
||||
--- a/tools/variations/fieldtrial_to_struct.py
|
||||
+++ b/tools/variations/fieldtrial_to_struct.py
|
||||
@@ -235,14 +235,14 @@ def main(arguments):
|
||||
@@ -210,14 +210,14 @@ def main(arguments):
|
||||
json_to_struct.GenerateStruct(
|
||||
basepath, output_root, opts.namespace, schema, description,
|
||||
os.path.split(description_filename)[1], os.path.split(opts.schema)[1],
|
||||
|
||||
@@ -8,9 +8,9 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../java/res/xml/privacy_preferences.xml | 5 ++
|
||||
.../chrome/browser/ChromeTabbedActivity.java | 7 +-
|
||||
.../browsing_data/BrowsingDataBridge.java | 12 +--
|
||||
.../ClearBrowsingDataFragment.java | 31 ++++++--
|
||||
.../ClearBrowsingDataFragment.java | 37 +++++++--
|
||||
.../ClearBrowsingDataFragmentAtStart.java | 79 +++++++++++++++++++
|
||||
chrome/app/settings_strings.grdp | 10 +++
|
||||
chrome/app/settings_strings.grdp | 8 ++
|
||||
chrome/browser/about_flags.cc | 1 +
|
||||
.../browsing_data/browsing_data_bridge.cc | 17 +++-
|
||||
.../chrome_browsing_data_lifetime_manager.cc | 22 +++++-
|
||||
@@ -20,18 +20,24 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../profiles/android/profile_manager_utils.cc | 5 ++
|
||||
chrome/browser/profiles/profile_manager.cc | 17 +++-
|
||||
chrome/browser/profiles/profile_manager.h | 2 +
|
||||
.../clear_browsing_data_dialog.html | 44 +++++++++++
|
||||
.../clear_browsing_data_dialog.ts | 2 +
|
||||
.../clear_browsing_data_browser_proxy.ts | 1 +
|
||||
.../clear_browsing_data_dialog_v2.html | 20 ++++-
|
||||
.../clear_browsing_data_dialog_v2.ts | 62 ++++++++++++++-
|
||||
.../clear_browsing_data_time_picker.ts | 6 +-
|
||||
.../settings/privacy_page/privacy_page.html | 12 +++
|
||||
.../settings/privacy_page/privacy_page.ts | 10 +++
|
||||
.../privacy_page/privacy_page_index.ts | 2 +-
|
||||
chrome/browser/resources/settings/route.ts | 2 +
|
||||
chrome/browser/resources/settings/router.ts | 1 +
|
||||
.../strings/android_chrome_strings.grd | 3 +
|
||||
.../Add-setting-to-clear-data-on-exit.grdp | 9 +++
|
||||
.../settings_localized_strings_provider.cc | 1 +
|
||||
.../settings_localized_strings_provider.cc | 4 +
|
||||
.../content/browsing_data_helper.cc | 9 ++-
|
||||
components/browsing_data/core/BUILD.gn | 5 ++
|
||||
.../core/browsing_data_policies_utils.cc | 20 ++---
|
||||
.../core/browsing_data_policies_utils.h | 11 +++
|
||||
.../browsing_data/core/browsing_data_utils.cc | 31 ++++++++
|
||||
.../core/clear_browsing_data_tab.h | 3 +-
|
||||
components/browsing_data/core/features.h | 1 +
|
||||
components/browsing_data/core/pref_names.cc | 17 ++++
|
||||
components/browsing_data/core/pref_names.h | 10 +++
|
||||
components/favicon/core/favicon_database.cc | 9 +++
|
||||
@@ -41,7 +47,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
content/browser/storage_partition_impl.cc | 2 +
|
||||
.../public/browser/browsing_data_remover.h | 7 +-
|
||||
.../Add-setting-to-clear-data-on-exit.inc | 8 ++
|
||||
37 files changed, 410 insertions(+), 34 deletions(-)
|
||||
43 files changed, 473 insertions(+), 47 deletions(-)
|
||||
create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragmentAtStart.java
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Add-setting-to-clear-data-on-exit.grdp
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Add-setting-to-clear-data-on-exit.inc
|
||||
@@ -49,7 +55,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
|
||||
--- a/chrome/android/chrome_java_sources.gni
|
||||
+++ b/chrome/android/chrome_java_sources.gni
|
||||
@@ -270,6 +270,7 @@ chrome_java_sources = [
|
||||
@@ -285,6 +285,7 @@ chrome_java_sources = [
|
||||
"java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataCheckBoxPreference.java",
|
||||
"java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFetcher.java",
|
||||
"java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragment.java",
|
||||
@@ -75,7 +81,7 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -208,6 +208,7 @@ import org.chromium.chrome.browser.profiles.ProfileProvider;
|
||||
@@ -228,6 +228,7 @@ import org.chromium.chrome.browser.profiles.ProfileProvider;
|
||||
import org.chromium.chrome.browser.quick_delete.QuickDeleteController;
|
||||
import org.chromium.chrome.browser.quick_delete.QuickDeleteDelegateImpl;
|
||||
import org.chromium.chrome.browser.quick_delete.QuickDeleteMetricsDelegate;
|
||||
@@ -83,19 +89,19 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
import org.chromium.chrome.browser.read_later.ReadingListBackPressHandler;
|
||||
import org.chromium.chrome.browser.recent_tabs.CrossDevicePaneFactory;
|
||||
import org.chromium.chrome.browser.reengagement.ReengagementNotificationController;
|
||||
@@ -2181,7 +2182,11 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
Intent intent = getIntent();
|
||||
@@ -2275,7 +2276,11 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
}
|
||||
if (!hadCipherData) {
|
||||
hadCipherData =
|
||||
- CipherLazyHolder.sCipherInstance.restoreFromBundle(getSavedInstanceState());
|
||||
+ CipherLazyHolder.sCipherInstance.restoreFromBundle(getSavedInstanceState()); //
|
||||
+ if (!hadCipherData) {
|
||||
+ Log.i(TAG, "Removing browsing data");
|
||||
+ ProfileManagerUtils.removeBrowsingDataAtStart();
|
||||
+ }
|
||||
}
|
||||
|
||||
boolean hadCipherData =
|
||||
- CipherLazyHolder.sCipherInstance.restoreFromBundle(getSavedInstanceState());
|
||||
+ CipherLazyHolder.sCipherInstance.restoreFromBundle(getSavedInstanceState()); //
|
||||
+ if (!hadCipherData) {
|
||||
+ Log.i(TAG, "Removing browsing data");
|
||||
+ ProfileManagerUtils.removeBrowsingDataAtStart();
|
||||
+ }
|
||||
|
||||
String PREF_CLOSE_TABS_ON_EXIT = "close_tabs_on_exit";
|
||||
boolean noRestoreState =
|
||||
boolean hasSavedOrPersistentInstanceState =
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/BrowsingDataBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/BrowsingDataBridge.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/BrowsingDataBridge.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/BrowsingDataBridge.java
|
||||
@@ -137,7 +143,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/B
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragment.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragment.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragment.java
|
||||
@@ -164,6 +164,12 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -169,6 +169,12 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
assert mCheckbox == preference;
|
||||
|
||||
mParent.updateButtonState();
|
||||
@@ -150,16 +156,16 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -245,7 +251,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -250,7 +256,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
private @TimePeriod int mLastSelectedTimePeriod;
|
||||
private boolean mShouldShowPostDeleteFeedback;
|
||||
|
||||
- private final ObservableSupplierImpl<String> mPageTitle = new ObservableSupplierImpl<>();
|
||||
+ protected final ObservableSupplierImpl<String> mPageTitle = new ObservableSupplierImpl<>();
|
||||
- private final SettableMonotonicObservableSupplier<String> mPageTitle =
|
||||
+ protected final SettableMonotonicObservableSupplier<String> mPageTitle =
|
||||
ObservableSuppliers.createMonotonic();
|
||||
|
||||
/**
|
||||
* @return All available {@link DialogOption} entries.
|
||||
@@ -351,7 +357,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -357,7 +363,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
}
|
||||
|
||||
/** Called when browsing data is about to be cleared. */
|
||||
@@ -168,7 +174,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
RecordUserAction.record("ClearBrowsingData_AdvancedTab");
|
||||
}
|
||||
|
||||
@@ -437,6 +443,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -443,6 +449,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
BrowsingDataBridge.getForProfile(getProfile())
|
||||
.setBrowsingDataDeletionPreference(
|
||||
ClearBrowsingDataFragment.getDataType(item.getOption()),
|
||||
@@ -176,7 +182,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
item.isSelected());
|
||||
}
|
||||
|
||||
@@ -444,8 +451,12 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -450,8 +457,16 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
.setBrowsingDataDeletionTimePeriod(mLastSelectedTimePeriod);
|
||||
}
|
||||
|
||||
@@ -185,12 +191,16 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
+ }
|
||||
+
|
||||
/** Returns the list of supported {@link DialogOption}. */
|
||||
- private List<Integer> getDialogOptions(Bundle fragmentArgs) {
|
||||
- private static List<Integer> getDialogOptions(Bundle fragmentArgs) {
|
||||
+ protected List<Integer> getDialogOptions(Bundle fragmentArgs) {
|
||||
+ return getDialogOptionsStatic(fragmentArgs);
|
||||
+ }
|
||||
+
|
||||
+ private static List<Integer> getDialogOptionsStatic(Bundle fragmentArgs) {
|
||||
String referrer =
|
||||
fragmentArgs.getString(
|
||||
ClearBrowsingDataFragment.CLEAR_BROWSING_DATA_REFERRER, null);
|
||||
@@ -471,6 +482,10 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -477,6 +492,10 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
DialogOption.CLEAR_SITE_SETTINGS);
|
||||
}
|
||||
|
||||
@@ -201,7 +211,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
/**
|
||||
* Decides whether a given dialog option should be selected when the dialog is initialized.
|
||||
*
|
||||
@@ -479,7 +494,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -485,7 +504,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
*/
|
||||
private boolean isOptionSelectedByDefault(@DialogOption int option) {
|
||||
return BrowsingDataBridge.getForProfile(getProfile())
|
||||
@@ -210,7 +220,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -547,6 +562,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -553,6 +572,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
* options.
|
||||
*/
|
||||
private void onClearButtonClicked() {
|
||||
@@ -218,7 +228,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
if (shouldShowImportantSitesDialog()) {
|
||||
showImportantDialogThenClear();
|
||||
return;
|
||||
@@ -576,6 +592,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -582,6 +602,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
Button clearButton = (Button) assumeNonNull(getView()).findViewById(R.id.clear_button);
|
||||
boolean isEnabled = !getSelectedOptions().isEmpty();
|
||||
clearButton.setEnabled(isEnabled);
|
||||
@@ -226,7 +236,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
}
|
||||
|
||||
private int getSpinnerIndex(
|
||||
@@ -653,7 +670,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -659,7 +680,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
.getBoolean(Pref.ALLOW_DELETING_BROWSER_HISTORY)) {
|
||||
enabled = false;
|
||||
browsingDataBridge.setBrowsingDataDeletionPreference(
|
||||
@@ -235,7 +245,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
}
|
||||
|
||||
// Disable tabs closure if the user is in multi-window mode.
|
||||
@@ -683,8 +700,12 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
@@ -689,8 +710,12 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
mSigninManager.addSignInStateObserver(this);
|
||||
|
||||
setHasOptionsMenu(true);
|
||||
@@ -246,8 +256,17 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/C
|
||||
+ protected void onCustomizePreferences(Bundle savedInstanceState, String rootKey) {}
|
||||
+
|
||||
@Override
|
||||
public ObservableSupplier<String> getPageTitle() {
|
||||
public MonotonicObservableSupplier<String> getPageTitle() {
|
||||
return mPageTitle;
|
||||
@@ -992,7 +1017,7 @@ public class ClearBrowsingDataFragment extends ChromeBaseSettingsFragment
|
||||
public void updateDynamicPreferences(
|
||||
Context context, SettingsIndexData indexData, Profile profile) {
|
||||
Bundle args = createFragmentArgs(context.getClass().getName());
|
||||
- List<Integer> options = getDialogOptions(args);
|
||||
+ List<Integer> options = getDialogOptionsStatic(args);
|
||||
// Not all checkboxes defined in the layout are necessarily handled by this
|
||||
// class or a particular subclass. Hide those that are not.
|
||||
Set<Integer> unboundOptions = getAllOptions();
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragmentAtStart.java b/chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataFragmentAtStart.java
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
@@ -335,18 +354,16 @@ new file mode 100644
|
||||
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
|
||||
--- a/chrome/app/settings_strings.grdp
|
||||
+++ b/chrome/app/settings_strings.grdp
|
||||
@@ -2148,6 +2148,16 @@
|
||||
@@ -2222,6 +2222,14 @@
|
||||
<message name="IDS_SETTINGS_CLEAR_BROWSING_DATA" desc="Text for delete browsing data button in Privacy options">
|
||||
Delete browsing data
|
||||
</message>
|
||||
+ <if expr="is_win or is_linux">
|
||||
+ <message name="IDS_CLEAR_BROWSING_DATA_ATSTART_TAB_TITLE" desc="The title of the tab showing the at start clear browsing data options.">
|
||||
+ At Close
|
||||
+ <message name="IDS_SETTINGS_CLEAR_BROWSING_DATA_AT_CLOSE" desc="The title of the tab showing the at close clear browsing data options.">
|
||||
+ Clear browsing data when closing Cromite
|
||||
+ </message>
|
||||
+ </if>
|
||||
+ <if expr="is_android">
|
||||
+ <message name="IDS_CLEAR_BROWSING_DATA_ATSTART_TAB_TITLE" desc="The title of the tab showing the at start clear browsing data options.">
|
||||
+ At Startup
|
||||
+ <message name="IDS_SETTINGS_CLEAR_DATA_AT_CLOSE_DESCRIPTION" desc="Description for delete browsing data button at close in Privacy options. 'History' refers to browsing history. 'Cookies' refers to the technical meaning of a cookie, i.e. data saved by a website on the user's computer, as in when a website saves your preferences.">
|
||||
+ Choose what to automatically delete when you close Cromite
|
||||
+ </message>
|
||||
+ </if>
|
||||
<message name="IDS_SETTINGS_CLEAR_DATA_DESCRIPTION" desc="Description for delete browsing data button in Privacy options. 'History' refers to browsing history. 'Cookies' refers to the technical meaning of a cookie, i.e. data saved by a website on the user's computer, as in when a website saves your preferences.">
|
||||
@@ -355,7 +372,7 @@ diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
|
||||
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
--- a/chrome/browser/about_flags.cc
|
||||
+++ b/chrome/browser/about_flags.cc
|
||||
@@ -109,6 +109,7 @@
|
||||
@@ -108,6 +108,7 @@
|
||||
#include "components/enterprise/client_certificates/core/features.h"
|
||||
#include "components/enterprise/data_controls/core/browser/features.h"
|
||||
#include "components/error_page/common/error_page_switches.h"
|
||||
@@ -366,7 +383,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
diff --git a/chrome/browser/android/browsing_data/browsing_data_bridge.cc b/chrome/browser/android/browsing_data/browsing_data_bridge.cc
|
||||
--- a/chrome/browser/android/browsing_data/browsing_data_bridge.cc
|
||||
+++ b/chrome/browser/android/browsing_data/browsing_data_bridge.cc
|
||||
@@ -67,6 +67,15 @@ PrefService* GetPrefService(Profile* profile) {
|
||||
@@ -66,6 +66,15 @@ PrefService* GetPrefService(Profile* profile) {
|
||||
return profile->GetOriginalProfile()->GetPrefs();
|
||||
}
|
||||
|
||||
@@ -382,17 +399,17 @@ diff --git a/chrome/browser/android/browsing_data/browsing_data_bridge.cc b/chro
|
||||
void OnBrowsingDataModelBuilt(JNIEnv* env,
|
||||
const ScopedJavaGlobalRef<jobject>& java_callback,
|
||||
std::unique_ptr<BrowsingDataModel> model) {
|
||||
@@ -219,7 +228,8 @@ static void JNI_BrowsingDataBridge_MarkOriginAsImportantForTesting(
|
||||
static jboolean JNI_BrowsingDataBridge_GetBrowsingDataDeletionPreference(
|
||||
@@ -218,7 +227,8 @@ static void JNI_BrowsingDataBridge_MarkOriginAsImportantForTesting(
|
||||
static bool JNI_BrowsingDataBridge_GetBrowsingDataDeletionPreference(
|
||||
JNIEnv* env,
|
||||
Profile* profile,
|
||||
- jint data_type) {
|
||||
+ jint data_type,
|
||||
- int32_t data_type) {
|
||||
+ int32_t data_type,
|
||||
+ jint clear_browsing_data_tab) {
|
||||
DCHECK_GE(data_type, 0);
|
||||
DCHECK_LE(data_type,
|
||||
static_cast<int>(browsing_data::BrowsingDataType::MAX_VALUE));
|
||||
@@ -231,7 +241,7 @@ static jboolean JNI_BrowsingDataBridge_GetBrowsingDataDeletionPreference(
|
||||
@@ -230,7 +240,7 @@ static bool JNI_BrowsingDataBridge_GetBrowsingDataDeletionPreference(
|
||||
std::string pref;
|
||||
if (!browsing_data::GetDeletionPreferenceFromDataType(
|
||||
static_cast<browsing_data::BrowsingDataType>(data_type),
|
||||
@@ -401,15 +418,15 @@ diff --git a/chrome/browser/android/browsing_data/browsing_data_bridge.cc b/chro
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -242,6 +252,7 @@ static void JNI_BrowsingDataBridge_SetBrowsingDataDeletionPreference(
|
||||
@@ -241,6 +251,7 @@ static void JNI_BrowsingDataBridge_SetBrowsingDataDeletionPreference(
|
||||
JNIEnv* env,
|
||||
Profile* profile,
|
||||
jint data_type,
|
||||
int32_t data_type,
|
||||
+ jint clear_browsing_data_tab,
|
||||
jboolean value) {
|
||||
bool value) {
|
||||
DCHECK_GE(data_type, 0);
|
||||
DCHECK_LE(data_type,
|
||||
@@ -250,7 +261,7 @@ static void JNI_BrowsingDataBridge_SetBrowsingDataDeletionPreference(
|
||||
@@ -249,7 +260,7 @@ static void JNI_BrowsingDataBridge_SetBrowsingDataDeletionPreference(
|
||||
std::string pref;
|
||||
if (!browsing_data::GetDeletionPreferenceFromDataType(
|
||||
static_cast<browsing_data::BrowsingDataType>(data_type),
|
||||
@@ -425,9 +442,9 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_lifetime_manager.
|
||||
|
||||
void ChromeBrowsingDataLifetimeManager::ClearBrowsingDataForOnExitPolicy(
|
||||
bool keep_browser_alive) {
|
||||
- const base::Value::List& data_types = profile_->GetPrefs()->GetList(
|
||||
- const base::ListValue& data_types = profile_->GetPrefs()->GetList(
|
||||
- browsing_data::prefs::kClearBrowsingDataOnExitList);
|
||||
+ base::Value::List data_types = profile_->GetPrefs()->GetList(
|
||||
+ base::ListValue data_types = profile_->GetPrefs()->GetList(
|
||||
+ browsing_data::prefs::kClearBrowsingDataOnExitList).Clone();
|
||||
+
|
||||
+ if (profile_->GetPrefs()->GetBoolean(browsing_data::prefs::kDeleteBrowsingHistoryAtStart))
|
||||
@@ -460,7 +477,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_lifetime_manager.
|
||||
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
|
||||
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
|
||||
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
|
||||
@@ -352,6 +352,7 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
@@ -321,6 +321,7 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
uint64_t origin_type_mask,
|
||||
base::OnceCallback<void(uint64_t)> callback) {
|
||||
CHECK(((remove_mask &
|
||||
@@ -468,7 +485,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
|
||||
~content::BrowsingDataRemover::DATA_TYPE_AVOID_CLOSING_CONNECTIONS &
|
||||
~constants::FILTERABLE_DATA_TYPES) == 0) ||
|
||||
filter_builder->MatchesAllOriginsAndDomains());
|
||||
@@ -455,6 +456,9 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
@@ -424,6 +425,9 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
CreateTaskCompletionClosure(TracingDataType::kHistory),
|
||||
&history_task_tracker_);
|
||||
}
|
||||
@@ -478,7 +495,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
|
||||
if (ClipboardRecentContent::GetInstance())
|
||||
ClipboardRecentContent::GetInstance()->SuppressClipboardContent();
|
||||
|
||||
@@ -563,6 +567,11 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
@@ -531,6 +535,11 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
// and SSL host state are scoped to hosts and represent them as std::string.
|
||||
// Rename the method to indicate its more general usage.
|
||||
if (profile_->GetSSLHostStateDelegate()) {
|
||||
@@ -490,7 +507,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
|
||||
profile_->GetSSLHostStateDelegate()->Clear(
|
||||
filter_builder->MatchesAllOriginsAndDomains()
|
||||
? base::RepeatingCallback<bool(const std::string&)>()
|
||||
@@ -591,9 +600,13 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
@@ -559,9 +568,13 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
}
|
||||
|
||||
device_event_log::Clear(delete_begin_, delete_end_);
|
||||
@@ -504,7 +521,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
|
||||
content::BackgroundTracingManager::GetInstance().DeleteTracesInDateRange(
|
||||
delete_begin_, delete_end_);
|
||||
|
||||
@@ -1320,6 +1333,8 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
@@ -1285,6 +1298,8 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
|
||||
|
||||
if (should_clear_zero_suggest_and_session_token && template_url_service)
|
||||
template_url_service->ClearSessionToken();
|
||||
@@ -516,7 +533,7 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
|
||||
diff --git a/chrome/browser/extensions/api/settings_private/prefs_util.cc b/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
||||
--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
||||
+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
||||
@@ -564,6 +564,23 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetAllowlistedKeys() {
|
||||
@@ -588,6 +588,23 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetAllowlistedKeys() {
|
||||
(*s_allowlist)[browsing_data::prefs::kLastClearBrowsingDataTab] =
|
||||
settings_api::PrefType::kNumber;
|
||||
|
||||
@@ -543,7 +560,7 @@ diff --git a/chrome/browser/extensions/api/settings_private/prefs_util.cc b/chro
|
||||
diff --git a/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/profiles/ProfileManagerUtils.java b/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/profiles/ProfileManagerUtils.java
|
||||
--- a/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/profiles/ProfileManagerUtils.java
|
||||
+++ b/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/profiles/ProfileManagerUtils.java
|
||||
@@ -56,11 +56,16 @@ public class ProfileManagerUtils {
|
||||
@@ -69,11 +69,16 @@ public class ProfileManagerUtils {
|
||||
}
|
||||
}
|
||||
|
||||
@@ -576,7 +593,7 @@ diff --git a/chrome/browser/profiles/android/profile_manager_utils.cc b/chrome/b
|
||||
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
|
||||
--- a/chrome/browser/profiles/profile_manager.cc
|
||||
+++ b/chrome/browser/profiles/profile_manager.cc
|
||||
@@ -1516,6 +1516,19 @@ void ProfileManager::DoFinalInit(ProfileInfo* profile_info,
|
||||
@@ -1534,6 +1534,19 @@ void ProfileManager::DoFinalInit(ProfileInfo* profile_info,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -596,7 +613,7 @@ diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profile
|
||||
void ProfileManager::DoFinalInitForServices(Profile* profile,
|
||||
bool go_off_the_record) {
|
||||
if (!do_final_services_init_ ||
|
||||
@@ -2185,9 +2198,9 @@ void ProfileManager::OnBrowserClosed(Browser* browser) {
|
||||
@@ -2229,9 +2242,9 @@ void ProfileManager::OnBrowserClosed(Browser* browser) {
|
||||
// Do nothing if the closed window is not the last window of the same profile.
|
||||
bool has_other_window = false;
|
||||
ForEachCurrentBrowserWindowInterfaceOrderedByActivation(
|
||||
@@ -611,7 +628,7 @@ diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profile
|
||||
diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles/profile_manager.h
|
||||
--- a/chrome/browser/profiles/profile_manager.h
|
||||
+++ b/chrome/browser/profiles/profile_manager.h
|
||||
@@ -231,6 +231,8 @@ class ProfileManager : public Profile::Delegate {
|
||||
@@ -242,6 +242,8 @@ class ProfileManager : public Profile::Delegate {
|
||||
// profiles.
|
||||
std::vector<Profile*> GetLoadedProfiles() const;
|
||||
|
||||
@@ -620,83 +637,356 @@ diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles
|
||||
// If a profile with the given path is currently managed by this object and
|
||||
// fully initialized, return a pointer to the corresponding Profile object;
|
||||
// otherwise return null.
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
|
||||
@@ -297,6 +297,50 @@
|
||||
disabled="[[clearingInProgress_]]" no-set-pref>
|
||||
</settings-checkbox>
|
||||
</div>
|
||||
+ <div id="atstart-tab">
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.browsing_history_at_start}}"
|
||||
+ label="$i18n{clearBrowsingHistory}"
|
||||
+ sub-label="[[counters_.browsing_history]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.download_history_at_start}}"
|
||||
+ label="$i18n{clearDownloadHistory}"
|
||||
+ sub-label="[[counters_.download_history]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ class="cookies-checkbox"
|
||||
+ pref="{{prefs.browser.clear_data.cookies_at_start}}"
|
||||
+ label="$i18n{clearCookies}"
|
||||
+ sub-label="[[counters_.cookies]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ class="cache-checkbox"
|
||||
+ pref="{{prefs.browser.clear_data.cache_at_start}}"
|
||||
+ label="$i18n{clearCache}"
|
||||
+ sub-label="[[counters_.cache]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.passwords_at_start}}"
|
||||
+ label="$i18n{clearPasswords}"
|
||||
+ sub-label="[[counters_.passwords]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.form_data_at_start}}"
|
||||
+ label="$i18n{clearFormData}"
|
||||
+ sub-label="[[counters_.form_data]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.site_settings_at_start}}"
|
||||
+ label="$i18nPolymer{siteSettings}"
|
||||
+ sub-label="[[counters_.site_settings]]">
|
||||
+ </settings-checkbox>
|
||||
+ <settings-checkbox
|
||||
+ pref="{{prefs.browser.clear_data.hosted_apps_data_at_start}}"
|
||||
+ label="$i18n{clearHostedAppData}"
|
||||
+ sub-label="[[counters_.hosted_apps_data]]">
|
||||
+ </settings-checkbox>
|
||||
+ </div>
|
||||
</cr-page-selector>
|
||||
</div>
|
||||
<div slot="button-container">
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.ts b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.ts
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.ts
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.ts
|
||||
@@ -216,6 +216,7 @@ export class SettingsClearBrowsingDataDialogElement extends
|
||||
value: () =>
|
||||
[loadTimeData.getString('basicPageTitle'),
|
||||
loadTimeData.getString('advancedPageTitle'),
|
||||
+ loadTimeData.getString('atStartPageTitle'),
|
||||
],
|
||||
},
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.ts b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.ts
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.ts
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.ts
|
||||
@@ -42,6 +42,7 @@ export enum BrowsingDataType {
|
||||
SITE_SETTINGS = 5,
|
||||
DOWNLOADS = 6,
|
||||
HOSTED_APPS_DATA = 7,
|
||||
+ PASSWORDS = 8,
|
||||
// TABS = 8, Not used on Desktop.
|
||||
}
|
||||
// LINT.ThenChange(/components/browsing_data/core/browsing_data_utils.h:BrowsingDataType)
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.html
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.html
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.html
|
||||
@@ -40,6 +40,8 @@
|
||||
|
||||
@@ -344,6 +345,7 @@ export class SettingsClearBrowsingDataDialogElement extends
|
||||
}
|
||||
this.clearButtonDisabled_ =
|
||||
this.getSelectedDataTypes_(page as HTMLElement).length === 0;
|
||||
+ if ((page as HTMLElement).id == "atstart-tab") this.clearButtonDisabled_ = true;
|
||||
#deleteBrowsingDataDialog::part(dialog) {
|
||||
max-height: var(--dbd-dialog-max-height);
|
||||
+ top: 300px;
|
||||
+ width: 590px;
|
||||
}
|
||||
|
||||
/**
|
||||
#deletingDataAlert {
|
||||
@@ -99,18 +101,25 @@
|
||||
<cr-dialog id="deleteBrowsingDataDialog" close-text="$i18n{close}"
|
||||
show-on-attach ignore-popstate ignore-enter-key
|
||||
hidden="[[showOtherGoogleDataDialog_]]">
|
||||
+<template is="dom-if" if="[[!clearBrowsingDialogAtClose]]">
|
||||
<div slot="title" class="dialog-title">$i18n{clearBrowsingData}</div>
|
||||
+</template>
|
||||
+<template is="dom-if" if="[[clearBrowsingDialogAtClose]]">
|
||||
+ <div slot="title" class="dialog-title">$i18n{clearBrowsingDataAtClose}</div>
|
||||
+</template>
|
||||
<div slot="header">
|
||||
+<template is="dom-if" if="[[!clearBrowsingDialogAtClose]]">
|
||||
<settings-clear-browsing-data-time-picker id="timePicker" prefs="{{prefs}}"
|
||||
on-selected-time-period-change="onTimePeriodChanged_">
|
||||
</settings-clear-browsing-data-time-picker>
|
||||
+</template>
|
||||
</div>
|
||||
<div slot="body">
|
||||
<div id="checkboxContainer">
|
||||
<template is="dom-repeat"
|
||||
items="[[expandedBrowsingDataTypeOptionsList_]]">
|
||||
- <settings-checkbox pref="{{item.pref}}" no-set-pref
|
||||
- sub-label-html="[[item.subLabel]]"
|
||||
+ <settings-checkbox pref="{{item.pref}}" no-set-pref="[[!clearBrowsingDialogAtClose]]"
|
||||
+ sub-label-html="[[shouldShowSubLabel_(item.subLabel)]]"
|
||||
disabled="[[isDeletionInProgress_]]"
|
||||
on-sub-label-link-clicked="onCheckboxSubLabelLinkClick_">
|
||||
<div class="checkbox-title">[[item.label]]</div>
|
||||
@@ -137,12 +146,14 @@
|
||||
<cr-icon icon="cr:expand-more" aria-hidden="true" role="presentation">
|
||||
</cr-icon>
|
||||
</cr-button>
|
||||
+<template is="dom-if" if="[[!clearBrowsingDialogAtClose]]">
|
||||
<cr-link-row id="manageOtherGoogleDataRow"
|
||||
label="[[otherGoogleDataRowLabel_]]"
|
||||
sub-label="[[otherGoogleDataRowSubLabel_]]"
|
||||
on-click="onManageOtherGoogleDataRowClick_"
|
||||
role-description="$i18n{subpageArrowRoleDescription}">
|
||||
</cr-link-row>
|
||||
+</template>
|
||||
</div>
|
||||
<div slot="button-container" class="row-aligned">
|
||||
<if expr="not is_chromeos">
|
||||
@@ -152,9 +163,10 @@
|
||||
<div id="spinner" class="spinner" hidden="[[!isDeletionInProgress_]]"></div>
|
||||
<cr-button id="cancelButton" class="cancel-button" on-click="onCancelClick_"
|
||||
disabled="[[isDeletionInProgress_]]" autofocus>
|
||||
- $i18n{cancel}
|
||||
+ $i18n{close}
|
||||
</cr-button>
|
||||
<cr-button id="deleteButton" class="action-button"
|
||||
+ hidden="[[clearBrowsingDialogAtClose]]"
|
||||
on-click="onDeleteBrowsingDataClick_"
|
||||
disabled="[[shouldDisableDeleteButton_(
|
||||
isDeletionInProgress_, isNoDatatypeSelected_)]]">
|
||||
@@ -177,4 +189,4 @@
|
||||
<template is="dom-if" if="[[showOtherGoogleDataDialog_]]" restamp>
|
||||
<settings-other-google-data-dialog on-cancel="onOtherGoogleDataDialogClose_">
|
||||
</settings-other-google-data-dialog>
|
||||
-</template>
|
||||
\ No newline at end of file
|
||||
+</template>
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.ts b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.ts
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.ts
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_v2.ts
|
||||
@@ -91,6 +91,17 @@ const ALL_BROWSING_DATATYPES_LIST: BrowsingDataType[] = [
|
||||
BrowsingDataType.HOSTED_APPS_DATA,
|
||||
];
|
||||
|
||||
+const ALL_BROWSING_DATATYPES_LIST_AT_CLOSE: BrowsingDataType[] = [
|
||||
+ BrowsingDataType.HISTORY,
|
||||
+ BrowsingDataType.SITE_DATA,
|
||||
+ BrowsingDataType.CACHE,
|
||||
+ BrowsingDataType.DOWNLOADS,
|
||||
+ BrowsingDataType.FORM_DATA,
|
||||
+ BrowsingDataType.SITE_SETTINGS,
|
||||
+ BrowsingDataType.PASSWORDS,
|
||||
+ BrowsingDataType.HOSTED_APPS_DATA,
|
||||
+];
|
||||
+
|
||||
/** The list of Browsing Data types that should be expanded by default. */
|
||||
const DEFAULT_BROWSING_DATATYPES_LIST: BrowsingDataType[] = [
|
||||
BrowsingDataType.HISTORY,
|
||||
@@ -120,12 +131,36 @@ function getDataTypeLabel(datatypes: BrowsingDataType) {
|
||||
return loadTimeData.getString('clearDownloadHistory');
|
||||
case BrowsingDataType.HOSTED_APPS_DATA:
|
||||
return loadTimeData.getString('clearHostedAppData');
|
||||
+ case BrowsingDataType.PASSWORDS:
|
||||
+ return loadTimeData.getString('clearPasswords');
|
||||
default:
|
||||
assertNotReachedCase(datatypes);
|
||||
}
|
||||
}
|
||||
|
||||
-export function getDataTypePrefName(datatypes: BrowsingDataType) {
|
||||
+export function getDataTypePrefName(datatypes: BrowsingDataType, atclose: boolean) {
|
||||
+ if (atclose) {
|
||||
+ switch (datatypes) {
|
||||
+ case BrowsingDataType.HISTORY:
|
||||
+ return 'browser.clear_data.browsing_history_at_start';
|
||||
+ case BrowsingDataType.CACHE:
|
||||
+ return 'browser.clear_data.cache_at_start';
|
||||
+ case BrowsingDataType.SITE_DATA:
|
||||
+ return 'browser.clear_data.cookies_at_start';
|
||||
+ case BrowsingDataType.FORM_DATA:
|
||||
+ return 'browser.clear_data.form_data_at_start';
|
||||
+ case BrowsingDataType.SITE_SETTINGS:
|
||||
+ return 'browser.clear_data.site_settings_at_start';
|
||||
+ case BrowsingDataType.DOWNLOADS:
|
||||
+ return 'browser.clear_data.download_history_at_start';
|
||||
+ case BrowsingDataType.HOSTED_APPS_DATA:
|
||||
+ return 'browser.clear_data.hosted_apps_data_at_start';
|
||||
+ case BrowsingDataType.PASSWORDS:
|
||||
+ return 'browser.clear_data.passwords_at_start';
|
||||
+ default:
|
||||
+ assertNotReachedCase(datatypes);
|
||||
+ }
|
||||
+ }
|
||||
switch (datatypes) {
|
||||
case BrowsingDataType.HISTORY:
|
||||
return 'browser.clear_data.browsing_history';
|
||||
@@ -141,6 +176,8 @@ export function getDataTypePrefName(datatypes: BrowsingDataType) {
|
||||
return 'browser.clear_data.download_history';
|
||||
case BrowsingDataType.HOSTED_APPS_DATA:
|
||||
return 'browser.clear_data.hosted_apps_data';
|
||||
+ case BrowsingDataType.PASSWORDS:
|
||||
+ return 'browser.clear_data.passwords';
|
||||
default:
|
||||
assertNotReachedCase(datatypes);
|
||||
}
|
||||
@@ -161,6 +198,12 @@ export class SettingsClearBrowsingDataDialogV2Element extends
|
||||
|
||||
static get properties() {
|
||||
return {
|
||||
+ clearBrowsingDialogAtClose: {
|
||||
+ type: Boolean,
|
||||
+ value: '',
|
||||
+ reflectToAttribute: true,
|
||||
+ },
|
||||
+
|
||||
dataTypesExpanded_: {
|
||||
type: Boolean,
|
||||
value: false,
|
||||
@@ -224,6 +267,8 @@ export class SettingsClearBrowsingDataDialogV2Element extends
|
||||
};
|
||||
}
|
||||
|
||||
+ declare private clearBrowsingDialogAtClose: boolean;
|
||||
+
|
||||
declare private dataTypesExpanded_: boolean;
|
||||
declare private deleteButtonLabel_: string;
|
||||
declare private deletingDataAlertString_: string;
|
||||
@@ -310,10 +355,14 @@ export class SettingsClearBrowsingDataDialogV2Element extends
|
||||
const expandedOptionsList: BrowsingDataTypeOption[] = [];
|
||||
const moreOptionsList: BrowsingDataTypeOption[] = [];
|
||||
|
||||
- ALL_BROWSING_DATATYPES_LIST.forEach((datatype) => {
|
||||
+ var list = ALL_BROWSING_DATATYPES_LIST;
|
||||
+ if (this.clearBrowsingDialogAtClose)
|
||||
+ list = ALL_BROWSING_DATATYPES_LIST_AT_CLOSE;
|
||||
+
|
||||
+ list.forEach((datatype) => {
|
||||
const datatypeOption = {
|
||||
label: getDataTypeLabel(datatype),
|
||||
- pref: this.getPref(getDataTypePrefName(datatype)),
|
||||
+ pref: this.getPref(getDataTypePrefName(datatype, this.clearBrowsingDialogAtClose)),
|
||||
};
|
||||
|
||||
if (this.shouldDataTypeBeExpanded_(datatype)) {
|
||||
@@ -362,7 +411,12 @@ export class SettingsClearBrowsingDataDialogV2Element extends
|
||||
|
||||
private shouldDataTypeBeExpanded_(datatype: BrowsingDataType) {
|
||||
return DEFAULT_BROWSING_DATATYPES_LIST.includes(datatype) ||
|
||||
- this.getPref(getDataTypePrefName(datatype)).value;
|
||||
+ this.getPref(getDataTypePrefName(datatype, this.clearBrowsingDialogAtClose)).value ||
|
||||
+ this.clearBrowsingDialogAtClose;
|
||||
+ }
|
||||
+
|
||||
+ private shouldShowSubLabel_(value: string) {
|
||||
+ return this.clearBrowsingDialogAtClose ? '' : value;
|
||||
}
|
||||
|
||||
private computeDeleteButtonLabel_() {
|
||||
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_time_picker.ts b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_time_picker.ts
|
||||
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_time_picker.ts
|
||||
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_time_picker.ts
|
||||
@@ -80,7 +80,7 @@ export class SettingsClearBrowsingDataTimePicker extends
|
||||
selectedTimePeriod_: {
|
||||
type: Number,
|
||||
observer: 'onTimePeriodSelectionChanged_',
|
||||
- value: TimePeriod.LAST_HOUR,
|
||||
+ value: TimePeriod.ALL_TIME,
|
||||
},
|
||||
|
||||
/**
|
||||
@@ -91,12 +91,12 @@ export class SettingsClearBrowsingDataTimePicker extends
|
||||
readOnly: true,
|
||||
type: Array,
|
||||
value: [
|
||||
+ TimePeriod.ALL_TIME,
|
||||
TimePeriod.LAST_15_MINUTES,
|
||||
TimePeriod.LAST_HOUR,
|
||||
TimePeriod.LAST_DAY,
|
||||
TimePeriod.LAST_WEEK,
|
||||
TimePeriod.FOUR_WEEKS,
|
||||
- TimePeriod.ALL_TIME,
|
||||
],
|
||||
},
|
||||
|
||||
@@ -125,7 +125,7 @@ export class SettingsClearBrowsingDataTimePicker extends
|
||||
*/
|
||||
maxChipsShown_: {
|
||||
type: Number,
|
||||
- value: 4,
|
||||
+ value: 6,
|
||||
},
|
||||
};
|
||||
}
|
||||
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
||||
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
||||
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
||||
@@ -6,6 +6,13 @@
|
||||
on-browsing-data-deleted="onBrowsingDataDeleted_">
|
||||
</settings-clear-browsing-data-dialog-v2>
|
||||
</template>
|
||||
+ <template is="dom-if" if="[[showClearBrowsingAtCloseDataDialog_]]" restamp>
|
||||
+ <settings-clear-browsing-data-dialog-v2 prefs="{{prefs}}"
|
||||
+ clear-browsing-dialog-at-close="true"
|
||||
+ on-close="onCbdDialogClosed_"
|
||||
+ on-browsing-data-deleted="onBrowsingDataDeleted_">
|
||||
+ </settings-clear-browsing-data-dialog-v2>
|
||||
+ </template>
|
||||
<template is="dom-if" if="[[showPrivacyGuideDialog_]]" restamp>
|
||||
<settings-privacy-guide-dialog id="privacyGuideDialog" prefs="{{prefs}}"
|
||||
on-close="onPrivacyGuideDialogClosed_">
|
||||
@@ -16,6 +23,11 @@
|
||||
label="$i18n{clearBrowsingData}"
|
||||
sub-label="$i18n{clearBrowsingDataDescription}"
|
||||
on-click="onClearBrowsingDataClick_"></cr-link-row>
|
||||
+ <cr-link-row id="clearBrowsingDataAtClose"
|
||||
+ start-icon="cr:delete"
|
||||
+ label="$i18n{clearBrowsingDataAtClose}"
|
||||
+ sub-label="$i18n{clearBrowsingDataAtCloseDescription}"
|
||||
+ on-click="onClearBrowsingDataAtCloseClick_"></cr-link-row>
|
||||
<template is="dom-if" if="[[isPrivacyGuideAvailable]]">
|
||||
<cr-link-row id="privacyGuideLinkRow" class="hr"
|
||||
start-icon="privacy20:signpost"
|
||||
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.ts b/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
||||
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
||||
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
||||
@@ -81,6 +81,7 @@ export class SettingsPrivacyPageElement extends SettingsPrivacyPageElementBase {
|
||||
},
|
||||
|
||||
showClearBrowsingDataDialog_: Boolean,
|
||||
+ showClearBrowsingAtCloseDataDialog_: Boolean,
|
||||
showPrivacyGuideDialog_: Boolean,
|
||||
|
||||
isPrivacySandboxRestricted_: {
|
||||
@@ -121,6 +122,7 @@ export class SettingsPrivacyPageElement extends SettingsPrivacyPageElementBase {
|
||||
|
||||
declare private historyExpireDaysThresholdOptions_: object[];
|
||||
declare private showClearBrowsingDataDialog_: boolean;
|
||||
+ declare private showClearBrowsingAtCloseDataDialog_: boolean;
|
||||
declare private showPrivacyGuideDialog_: boolean;
|
||||
declare private referersPolicyOptions_: object[];
|
||||
declare private isPrivacySandboxRestricted_: boolean;
|
||||
@@ -136,6 +138,8 @@ export class SettingsPrivacyPageElement extends SettingsPrivacyPageElementBase {
|
||||
|
||||
this.showClearBrowsingDataDialog_ =
|
||||
Router.getInstance().getCurrentRoute() === routes.CLEAR_BROWSER_DATA;
|
||||
+ this.showClearBrowsingAtCloseDataDialog_ =
|
||||
+ Router.getInstance().getCurrentRoute() === routes.CLEAR_BROWSER_DATA_AT_CLOSE;
|
||||
this.showPrivacyGuideDialog_ =
|
||||
Router.getInstance().getCurrentRoute() === routes.PRIVACY_GUIDE &&
|
||||
this.isPrivacyGuideAvailable;
|
||||
@@ -147,6 +151,12 @@ export class SettingsPrivacyPageElement extends SettingsPrivacyPageElementBase {
|
||||
Router.getInstance().navigateTo(routes.CLEAR_BROWSER_DATA);
|
||||
}
|
||||
|
||||
+ private onClearBrowsingDataAtCloseClick_() {
|
||||
+ this.interactedWithPage_();
|
||||
+
|
||||
+ Router.getInstance().navigateTo(routes.CLEAR_BROWSER_DATA_AT_CLOSE);
|
||||
+ }
|
||||
+
|
||||
private onCookiesClick_() {
|
||||
this.interactedWithPage_();
|
||||
|
||||
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page_index.ts b/chrome/browser/resources/settings/privacy_page/privacy_page_index.ts
|
||||
--- a/chrome/browser/resources/settings/privacy_page/privacy_page_index.ts
|
||||
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page_index.ts
|
||||
@@ -253,7 +253,7 @@ export class SettingsPrivacyPageIndexElement extends
|
||||
}
|
||||
|
||||
private isRouteHostedWithinPrivacyView_(route: Route): boolean {
|
||||
- const nestedRoutes = [routes.CLEAR_BROWSER_DATA];
|
||||
+ const nestedRoutes = [routes.CLEAR_BROWSER_DATA, routes.CLEAR_BROWSER_DATA_AT_CLOSE];
|
||||
if (loadTimeData.getBoolean('showPrivacyGuide')) {
|
||||
nestedRoutes.push(routes.PRIVACY_GUIDE);
|
||||
}
|
||||
diff --git a/chrome/browser/resources/settings/route.ts b/chrome/browser/resources/settings/route.ts
|
||||
--- a/chrome/browser/resources/settings/route.ts
|
||||
+++ b/chrome/browser/resources/settings/route.ts
|
||||
@@ -17,6 +17,8 @@ function addPrivacyChildRoutes(r: Partial<SettingsRoutes>) {
|
||||
assert(r.PRIVACY);
|
||||
r.CLEAR_BROWSER_DATA = r.PRIVACY.createChild('/clearBrowserData');
|
||||
r.CLEAR_BROWSER_DATA.isNavigableDialog = true;
|
||||
+ r.CLEAR_BROWSER_DATA_AT_CLOSE = r.PRIVACY.createChild('/clearBrowserDataAtClose');
|
||||
+ r.CLEAR_BROWSER_DATA_AT_CLOSE.isNavigableDialog = true;
|
||||
|
||||
const visibility = pageVisibility || {};
|
||||
|
||||
diff --git a/chrome/browser/resources/settings/router.ts b/chrome/browser/resources/settings/router.ts
|
||||
--- a/chrome/browser/resources/settings/router.ts
|
||||
+++ b/chrome/browser/resources/settings/router.ts
|
||||
@@ -24,6 +24,7 @@ export interface SettingsRoutes {
|
||||
BASIC: Route;
|
||||
CAPTIONS: Route;
|
||||
CLEAR_BROWSER_DATA: Route;
|
||||
+ CLEAR_BROWSER_DATA_AT_CLOSE: Route;
|
||||
COMPARE: Route;
|
||||
COOKIES: Route;
|
||||
DEFAULT_BROWSER: Route;
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -1443,6 +1443,9 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -1517,6 +1517,9 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
<message name="IDS_ANDROID_APP_HISTORY_OPEN_FULL_OTHER_FORMS" desc="The informational message at the top of the history page letting users know that app-specific history may be missing some entries, followed by the info on the other forms of browing history.">
|
||||
Some of your history might not show up here. To see all your Chrome history, open full Chrome history. Also, your Google Account may have other forms of browsing history at <ph name="BEGIN_LINK"><link></ph>myactivity.google.com<ph name="END_LINK"></link></ph>.
|
||||
</message>
|
||||
@@ -723,11 +1013,14 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
||||
--- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
||||
+++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
||||
@@ -2218,6 +2218,7 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,
|
||||
@@ -2303,6 +2303,10 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,
|
||||
{"clearedData", IDS_SETTINGS_CLEARED_DATA},
|
||||
{"clearBrowsingData", IDS_SETTINGS_CLEAR_BROWSING_DATA},
|
||||
{"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
|
||||
+ {"atStartPageTitle", IDS_CLEAR_BROWSING_DATA_ATSTART_TAB_TITLE},
|
||||
+#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_LINUX)
|
||||
+ {"clearBrowsingDataAtClose", IDS_SETTINGS_CLEAR_BROWSING_DATA_AT_CLOSE},
|
||||
+ {"clearBrowsingDataAtCloseDescription", IDS_SETTINGS_CLEAR_DATA_AT_CLOSE_DESCRIPTION},
|
||||
+#endif
|
||||
{"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
|
||||
{"safeBrowsingEnableExtendedReportingDesc",
|
||||
IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING_DESC},
|
||||
@@ -775,7 +1068,7 @@ diff --git a/components/browsing_data/core/BUILD.gn b/components/browsing_data/c
|
||||
diff --git a/components/browsing_data/core/browsing_data_policies_utils.cc b/components/browsing_data/core/browsing_data_policies_utils.cc
|
||||
--- a/components/browsing_data/core/browsing_data_policies_utils.cc
|
||||
+++ b/components/browsing_data/core/browsing_data_policies_utils.cc
|
||||
@@ -18,21 +18,21 @@
|
||||
@@ -17,21 +17,21 @@
|
||||
|
||||
namespace browsing_data {
|
||||
|
||||
@@ -882,17 +1175,6 @@ diff --git a/components/browsing_data/core/clear_browsing_data_tab.h b/component
|
||||
|
||||
} // namespace browsing_data
|
||||
|
||||
diff --git a/components/browsing_data/core/features.h b/components/browsing_data/core/features.h
|
||||
--- a/components/browsing_data/core/features.h
|
||||
+++ b/components/browsing_data/core/features.h
|
||||
@@ -19,6 +19,7 @@ BASE_DECLARE_FEATURE(kBrowsingDataModel);
|
||||
// updates to history counter logic and removal of the bulk password deletion
|
||||
// option from the dialog.
|
||||
BASE_DECLARE_FEATURE(kDbdRevampDesktop);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kDbdRevampDesktop);
|
||||
|
||||
// When enabled, calls to browsingData.removePasswords extension API would
|
||||
// result in an error response instead of a console warning.
|
||||
diff --git a/components/browsing_data/core/pref_names.cc b/components/browsing_data/core/pref_names.cc
|
||||
--- a/components/browsing_data/core/pref_names.cc
|
||||
+++ b/components/browsing_data/core/pref_names.cc
|
||||
@@ -954,7 +1236,7 @@ diff --git a/components/favicon/core/favicon_database.cc b/components/favicon/co
|
||||
// Description of database tables:
|
||||
//
|
||||
// icon_mapping
|
||||
@@ -505,6 +509,11 @@ bool FaviconDatabase::SetFaviconBitmapLastUpdateTime(FaviconBitmapID bitmap_id,
|
||||
@@ -501,6 +505,11 @@ bool FaviconDatabase::SetFaviconBitmapLastUpdateTime(FaviconBitmapID bitmap_id,
|
||||
|
||||
bool FaviconDatabase::SetFaviconsOutOfDateBetween(base::Time begin,
|
||||
base::Time end) {
|
||||
@@ -989,18 +1271,18 @@ diff --git a/components/favicon/core/favicon_database.h b/components/favicon/cor
|
||||
diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc
|
||||
--- a/components/search_engines/template_url_service.cc
|
||||
+++ b/components/search_engines/template_url_service.cc
|
||||
@@ -924,6 +924,7 @@ void TemplateURLService::RemoveAutoGeneratedForUrlsBetween(
|
||||
@@ -920,6 +920,7 @@ void TemplateURLService::RemoveAutoGeneratedForUrlsBetween(
|
||||
if (turl->date_created() >= created_after &&
|
||||
(created_before.is_null() || turl->date_created() < created_before) &&
|
||||
turl->safe_for_autoreplace() && turl->prepopulate_id() == 0 &&
|
||||
+ turl->is_active() != TemplateURLData::ActiveStatus::kTrue &&
|
||||
turl->starter_pack_id() == 0 && !MatchesDefaultSearchProvider(turl) &&
|
||||
(url_filter.is_null() ||
|
||||
url_filter.Run(turl->GenerateSearchURL(search_terms_data())))) {
|
||||
turl->starter_pack_id() ==
|
||||
template_url_starter_pack_data::StarterPackId::kNone &&
|
||||
!MatchesDefaultSearchProvider(turl) &&
|
||||
diff --git a/content/browser/btm/btm_service_impl.cc b/content/browser/btm/btm_service_impl.cc
|
||||
--- a/content/browser/btm/btm_service_impl.cc
|
||||
+++ b/content/browser/btm/btm_service_impl.cc
|
||||
@@ -261,7 +261,7 @@ class StateClearer : public BrowsingDataRemover::Observer {
|
||||
@@ -231,7 +231,7 @@ class StateClearer : public BrowsingDataRemover::Observer {
|
||||
remove_mask &= ~BrowsingDataRemover::DATA_TYPE_PRIVACY_SANDBOX;
|
||||
remover->RemoveWithFilterAndReply(
|
||||
base::Time::Min(), base::Time::Max(),
|
||||
@@ -1012,15 +1294,15 @@ diff --git a/content/browser/btm/btm_service_impl.cc b/content/browser/btm/btm_s
|
||||
diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc
|
||||
--- a/content/browser/storage_partition_impl.cc
|
||||
+++ b/content/browser/storage_partition_impl.cc
|
||||
@@ -19,6 +19,7 @@
|
||||
#include "base/containers/contains.h"
|
||||
@@ -18,6 +18,7 @@
|
||||
#include "base/command_line.h"
|
||||
#include "base/dcheck_is_on.h"
|
||||
#include "base/feature_list.h"
|
||||
+#include "base/files/file_util.h"
|
||||
#include "base/functional/bind.h"
|
||||
#include "base/functional/callback_helpers.h"
|
||||
#include "base/functional/concurrent_closures.h"
|
||||
@@ -1557,6 +1558,7 @@ void StoragePartitionImpl::Initialize(
|
||||
@@ -1505,6 +1506,7 @@ void StoragePartitionImpl::Initialize(
|
||||
.AppendASCII("Code Cache");
|
||||
}
|
||||
DCHECK_GE(settings.size_in_bytes(), 0);
|
||||
|
||||
@@ -10,24 +10,24 @@ Conditional immediate support is disabled.
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../settings/PasswordSettings.java | 27 +++++++++++++++++
|
||||
.../settings/PasswordSettings.java | 27 +++++++++++++++++++
|
||||
.../touch_to_fill_controller.cc | 2 ++
|
||||
...etting-to-enable-Credman-for-passkeys.grdp | 12 ++++++++
|
||||
.../webauthn/AuthenticatorImpl.java | 29 +++++++------------
|
||||
...etting-to-enable-Credman-for-passkeys.grdp | 12 +++++++++
|
||||
.../webauthn/AuthenticatorImpl.java | 24 +++++++----------
|
||||
.../components/webauthn/WebauthnFeatures.java | 2 ++
|
||||
.../cred_man/CredManSupportProvider.java | 25 ++++------------
|
||||
.../cred_man/CredManSupportProvider.java | 25 +++++------------
|
||||
.../webauthn/android/webauthn_feature_map.cc | 1 +
|
||||
components/webauthn/features.cc | 4 +++
|
||||
components/webauthn/features.h | 3 ++
|
||||
device/fido/features.cc | 2 ++
|
||||
components/webauthn/features.h | 3 +++
|
||||
device/fido/public/features.cc | 2 ++
|
||||
.../authentication_credentials_container.cc | 5 ++++
|
||||
11 files changed, 75 insertions(+), 37 deletions(-)
|
||||
11 files changed, 74 insertions(+), 33 deletions(-)
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Add-setting-to-enable-Credman-for-passkeys.grdp
|
||||
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java
|
||||
@@ -10,6 +10,7 @@ import android.app.Activity;
|
||||
@@ -11,6 +11,7 @@ import android.app.Activity;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
import android.net.Uri;
|
||||
@@ -35,7 +35,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manage
|
||||
import android.os.Bundle;
|
||||
import android.text.SpannableString;
|
||||
import android.text.style.ForegroundColorSpan;
|
||||
@@ -64,6 +65,10 @@ import org.chromium.chrome.browser.ui.messages.snackbar.INeedSnackbarManager;
|
||||
@@ -68,6 +69,10 @@ import org.chromium.chrome.browser.ui.messages.snackbar.INeedSnackbarManager;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.Snackbar;
|
||||
import org.chromium.chrome.browser.lifetime.ApplicationLifetime;
|
||||
|
||||
@@ -46,7 +46,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manage
|
||||
/**
|
||||
* The "Passwords" screen in Settings, which allows the user to enable or disable password saving,
|
||||
* to view saved passwords (just the username and URL), and to delete saved passwords.
|
||||
@@ -322,6 +327,7 @@ public class PasswordSettings extends ChromeBaseSettingsFragment
|
||||
@@ -334,6 +339,7 @@ public class PasswordSettings extends ChromeBaseSettingsFragment
|
||||
createSavePasswordsSwitch();
|
||||
createAutoSignInCheckbox();
|
||||
createEnableAndroidAutofillSwitch();
|
||||
@@ -54,7 +54,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manage
|
||||
|
||||
PasswordManagerHandlerProvider.getForProfile(getProfile())
|
||||
.getPasswordManagerHandler()
|
||||
@@ -673,6 +679,27 @@ public class PasswordSettings extends ChromeBaseSettingsFragment
|
||||
@@ -687,6 +693,27 @@ public class PasswordSettings extends ChromeBaseSettingsFragment
|
||||
getPrefService().getBoolean(Pref.CREDENTIALS_ENABLE_AUTOSIGNIN));
|
||||
}
|
||||
|
||||
@@ -121,36 +121,36 @@ new file mode 100644
|
||||
diff --git a/components/webauthn/android/java/src/org/chromium/components/webauthn/AuthenticatorImpl.java b/components/webauthn/android/java/src/org/chromium/components/webauthn/AuthenticatorImpl.java
|
||||
--- a/components/webauthn/android/java/src/org/chromium/components/webauthn/AuthenticatorImpl.java
|
||||
+++ b/components/webauthn/android/java/src/org/chromium/components/webauthn/AuthenticatorImpl.java
|
||||
@@ -34,6 +34,8 @@ import org.chromium.blink.mojom.PublicKeyCredentialReportOptions;
|
||||
import org.chromium.blink.mojom.WebAuthnClientCapability;
|
||||
@@ -30,6 +30,8 @@ import org.chromium.blink.mojom.WebAuthnClientCapability;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.components.password_manager.BrowserAssistedLoginType;
|
||||
+import org.chromium.components.webauthn.CredManSupport;
|
||||
+import org.chromium.components.webauthn.cred_man.CredManSupportProvider;
|
||||
import org.chromium.components.ukm.UkmRecorder;
|
||||
import org.chromium.content_public.browser.RenderFrameHost;
|
||||
import org.chromium.content_public.browser.WebContents;
|
||||
@@ -170,8 +172,7 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
import org.chromium.content_public.browser.Visibility;
|
||||
@@ -167,8 +169,7 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
mIsPaymentRequest = options.isPaymentCredentialCreation;
|
||||
mMakeCredentialCallback = callback;
|
||||
mIsOperationPending = true;
|
||||
mRequestCallback = requestCallback;
|
||||
mRequestCallback.setCompletionCallback(this::cleanupRequest);
|
||||
- if (!GmsCoreUtils.isWebauthnSupported()
|
||||
- || (!isChrome(mWebContents) && !GmsCoreUtils.isResultReceiverSupported())) {
|
||||
+ if (CredManSupportProvider.getCredManSupport() == CredManSupport.DISABLED) {
|
||||
recordOutcomeEvent(MakeCredentialOutcome.OTHER_FAILURE);
|
||||
onError(AuthenticatorStatus.NOT_IMPLEMENTED);
|
||||
return;
|
||||
@@ -235,8 +236,7 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
mIsConditionalRequest = options.mediation == Mediation.CONDITIONAL;
|
||||
mIsImmediateRequest = options.mediation == Mediation.IMMEDIATE;
|
||||
|
||||
mRequestCallback.onComplete(
|
||||
WebauthnRequestResponse.forFailedMakeCredential(
|
||||
AuthenticatorStatus.NOT_IMPLEMENTED,
|
||||
@@ -254,8 +255,7 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
&& DeviceFeatureMap.isEnabled(
|
||||
DeviceFeatureList
|
||||
.WEBAUTHN_AUTHENTICATOR_PASSWORDS_ONLY_IMMEDIATE_REQUESTS);
|
||||
- if (!GmsCoreUtils.isWebauthnSupported()
|
||||
- || (!isChrome(mWebContents) && !GmsCoreUtils.isResultReceiverSupported())
|
||||
+ if (CredManSupportProvider.getCredManSupport() == CredManSupport.DISABLED
|
||||
|| options.publicKey == null) {
|
||||
recordOutcomeEvent(GetAssertionOutcome.OTHER_FAILURE);
|
||||
onError(AuthenticatorStatus.NOT_IMPLEMENTED);
|
||||
@@ -277,12 +277,11 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
|| (options.publicKey == null && !isPasswordOnlyFlux)) {
|
||||
RequestMetrics metrics =
|
||||
new RequestMetrics.Builder()
|
||||
@@ -300,12 +300,11 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
}
|
||||
|
||||
private boolean couldSupportConditionalMediation() {
|
||||
@@ -165,7 +165,7 @@ diff --git a/components/webauthn/android/java/src/org/chromium/components/webaut
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -356,26 +355,20 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
@@ -379,22 +378,19 @@ public final class AuthenticatorImpl implements Authenticator, AuthenticationCon
|
||||
capabilities.add(
|
||||
createWebAuthnClientCapability(
|
||||
AuthenticatorConstants.CAPABILITY_CONDITIONAL_GET,
|
||||
@@ -175,17 +175,12 @@ diff --git a/components/webauthn/android/java/src/org/chromium/components/webaut
|
||||
createWebAuthnClientCapability(
|
||||
AuthenticatorConstants.CAPABILITY_UVPAA,
|
||||
- couldSupportUvpaa() && isUvpaa));
|
||||
- boolean conditionalCreateEnabled =
|
||||
- couldSupportConditionalMediation()
|
||||
- && DeviceFeatureMap.isEnabled(
|
||||
- DeviceFeatureList.WEBAUTHN_PASSKEY_UPGRADE);
|
||||
+ true));
|
||||
capabilities.add(
|
||||
createWebAuthnClientCapability(
|
||||
AuthenticatorConstants.CAPABILITY_CONDITIONAL_CREATE,
|
||||
- isUvpaa && conditionalCreateEnabled));
|
||||
+ DeviceFeatureMap.isEnabled(
|
||||
+ DeviceFeatureList.WEBAUTHN_PASSKEY_UPGRADE)));
|
||||
- isUvpaa && couldSupportConditionalMediation()));
|
||||
+ true));
|
||||
capabilities.add(
|
||||
createWebAuthnClientCapability(
|
||||
AuthenticatorConstants.CAPABILITY_IMMEDIATE_GET,
|
||||
@@ -194,16 +189,16 @@ diff --git a/components/webauthn/android/java/src/org/chromium/components/webaut
|
||||
- .WEBAUTHN_IMMEDIATE_GET)
|
||||
- && isUvpaa));
|
||||
+ false));
|
||||
boolean signalSupported =
|
||||
isUvpaa
|
||||
&& DeviceFeatureMap.isEnabled(
|
||||
capabilities.add(
|
||||
createWebAuthnClientCapability(
|
||||
AuthenticatorConstants
|
||||
diff --git a/components/webauthn/android/java/src/org/chromium/components/webauthn/WebauthnFeatures.java b/components/webauthn/android/java/src/org/chromium/components/webauthn/WebauthnFeatures.java
|
||||
--- a/components/webauthn/android/java/src/org/chromium/components/webauthn/WebauthnFeatures.java
|
||||
+++ b/components/webauthn/android/java/src/org/chromium/components/webauthn/WebauthnFeatures.java
|
||||
@@ -17,4 +17,6 @@ public abstract class WebauthnFeatures {
|
||||
public static final String WEBAUTHN_ANDROID_PASSKEY_CACHE_MIGRATION =
|
||||
"WebAuthenticationAndroidPasskeyCacheMigration";
|
||||
@@ -19,4 +19,6 @@ public abstract class WebauthnFeatures {
|
||||
public static final String WEBAUTHN_ANDROID_CRED_MAN_FOR_DEV = "WebAuthnAndroidCredManForDev";
|
||||
public static final String WEBAUTHN_ANDROID_CRED_MAN_REQUEST_EXTRA_BUNDLE =
|
||||
"WebAuthenticationAndroidCredManRequestExtraBundle";
|
||||
+ public static final String WEBAUTHN_ANDROID_PASSKEY =
|
||||
+ "WebAuthenticationAndroidPasskey";
|
||||
}
|
||||
@@ -284,10 +279,10 @@ diff --git a/components/webauthn/android/java/src/org/chromium/components/webaut
|
||||
diff --git a/components/webauthn/android/webauthn_feature_map.cc b/components/webauthn/android/webauthn_feature_map.cc
|
||||
--- a/components/webauthn/android/webauthn_feature_map.cc
|
||||
+++ b/components/webauthn/android/webauthn_feature_map.cc
|
||||
@@ -17,6 +17,7 @@ namespace {
|
||||
const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
@@ -18,6 +18,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kWebAuthnAndroidPasskeyCacheMigration,
|
||||
&kWebAuthnAndroidCredManForDev,
|
||||
&kWebAuthnAndroidCredManRequestExtraBundle,
|
||||
+ &kWebAuthnAndroidPasskey,
|
||||
};
|
||||
|
||||
@@ -295,9 +290,9 @@ diff --git a/components/webauthn/android/webauthn_feature_map.cc b/components/we
|
||||
diff --git a/components/webauthn/features.cc b/components/webauthn/features.cc
|
||||
--- a/components/webauthn/features.cc
|
||||
+++ b/components/webauthn/features.cc
|
||||
@@ -25,6 +25,10 @@ BASE_FEATURE(kWebAuthnAndroidCredManForDev, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
const base::FeatureParam<std::string> kWebAuthnAndroidCredManForDevMode{
|
||||
&kWebAuthnAndroidCredManForDev, "mode", ""};
|
||||
@@ -34,6 +34,10 @@ BASE_FEATURE(kWebAuthnAndroidCredManRequestExtraBundle,
|
||||
BASE_FEATURE(kWebAuthnConditionalUiSuppressedOnWebView,
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
+CROMITE_FEATURE(kWebAuthnAndroidPasskey,
|
||||
+ "WebAuthenticationAndroidPasskey",
|
||||
@@ -316,32 +311,32 @@ diff --git a/components/webauthn/features.h b/components/webauthn/features.h
|
||||
+COMPONENT_EXPORT(WEBAUTHN)
|
||||
+BASE_DECLARE_FEATURE(kWebAuthnAndroidPasskey);
|
||||
+
|
||||
#endif // BUILDFLAG(IS_ANDROID)
|
||||
|
||||
#if !BUILDFLAG(IS_ANDROID)
|
||||
diff --git a/device/fido/features.cc b/device/fido/features.cc
|
||||
--- a/device/fido/features.cc
|
||||
+++ b/device/fido/features.cc
|
||||
@@ -188,6 +188,7 @@ BASE_FEATURE(kWebAuthnImmediateGet,
|
||||
#else
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
// Whether to send a custom bundle values for the CredMan requests. The extras
|
||||
// are used by Google Password Manager.
|
||||
COMPONENT_EXPORT(WEBAUTHN)
|
||||
diff --git a/device/fido/public/features.cc b/device/fido/public/features.cc
|
||||
--- a/device/fido/public/features.cc
|
||||
+++ b/device/fido/public/features.cc
|
||||
@@ -124,6 +124,7 @@ BASE_FEATURE(kWebAuthnPublishPrelinkingInfo,
|
||||
"WebAuthenticationPublishPrelinkingInfo",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
#endif // BUILDFLAG(IS_ANDROID)
|
||||
+SET_CROMITE_FEATURE_DISABLED(kWebAuthnImmediateGet);
|
||||
|
||||
BASE_FEATURE_PARAM(int,
|
||||
kWebAuthnImmediateMediationTimeoutMilliseconds,
|
||||
@@ -200,6 +201,7 @@ BASE_FEATURE_PARAM(int,
|
||||
// Disabled by default.
|
||||
BASE_FEATURE(kWebAuthnHelloSignal,
|
||||
@@ -177,6 +178,7 @@ BASE_FEATURE_PARAM(int,
|
||||
BASE_FEATURE(kWebAuthnImmediateGetAutoselect,
|
||||
"WebAuthenticationImmediateGetAutoselect",
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kWebAuthnImmediateGetAutoselect);
|
||||
|
||||
// Default enabled in M140. Remove in or after M143.
|
||||
BASE_FEATURE(kWebAuthnLargeBlobForGPM,
|
||||
// Deprecation flag. Disabled by default in M142. Remove in or after M145.
|
||||
BASE_FEATURE(kWebAuthnSendPinGeneration,
|
||||
diff --git a/third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc b/third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
|
||||
--- a/third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
|
||||
+++ b/third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
|
||||
@@ -1090,6 +1090,11 @@ DOMException* AuthenticatorStatusToDOMException(
|
||||
@@ -1129,6 +1129,11 @@ DOMException* AuthenticatorStatusToDOMException(
|
||||
const WebAuthnDOMExceptionDetailsPtr& dom_exception_details) {
|
||||
DCHECK_EQ(status != AuthenticatorStatus::ERROR_WITH_DOM_EXCEPTION_DETAILS,
|
||||
dom_exception_details.is_null());
|
||||
|
||||
@@ -21,6 +21,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../accessibility/AccessibilitySettings.java | 12 +++++++
|
||||
.../AccessibilitySettingsDelegate.java | 2 ++
|
||||
.../contextmenu/ContextMenuItemDelegate.java | 3 ++
|
||||
.../ThinWebViewContextMenuItemDelegate.java | 6 ++++
|
||||
...Add-setting-to-invert-tap-and-long-tap.inc | 8 +++++
|
||||
...Add-setting-to-invert-tap-and-long-tap.inc | 3 ++
|
||||
...Add-setting-to-invert-tap-and-long-tap.inc | 1 +
|
||||
@@ -30,7 +31,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../renderer/core/html/html_image_element.h | 2 ++
|
||||
.../core/page/context_menu_controller.cc | 23 +++++++++---
|
||||
.../core/page/context_menu_controller.h | 5 +--
|
||||
22 files changed, 164 insertions(+), 16 deletions(-)
|
||||
23 files changed, 170 insertions(+), 16 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Add-setting-to-invert-tap-and-long-tap.inc
|
||||
create mode 100644 cromite_flags/third_party/blink/common/features_cc/Add-setting-to-invert-tap-and-long-tap.inc
|
||||
create mode 100644 cromite_flags/third_party/blink/common/features_h/Add-setting-to-invert-tap-and-long-tap.inc
|
||||
@@ -70,7 +71,7 @@ diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/va
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/accessibility/settings/ChromeAccessibilitySettingsDelegate.java
|
||||
@@ -165,6 +165,24 @@ public class ChromeAccessibilitySettingsDelegate implements AccessibilitySetting
|
||||
@@ -167,6 +167,24 @@ public class ChromeAccessibilitySettingsDelegate implements AccessibilitySetting
|
||||
mSnackbarManagerSupplier.get().showSnackbar(mSnackbar);
|
||||
}
|
||||
|
||||
@@ -128,7 +129,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/Chr
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
@@ -474,6 +474,9 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
@@ -488,6 +488,9 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
}
|
||||
if (mParams.isAnchor()) {
|
||||
ModelList linkGroup = new ModelList();
|
||||
@@ -138,19 +139,19 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/Chr
|
||||
if (FirstRunStatus.getFirstRunFlowComplete()
|
||||
&& !isEmptyUrl(mParams.getUrl())
|
||||
&& UrlUtilities.isAcceptedScheme(mParams.getUrl())) {
|
||||
@@ -1083,6 +1086,8 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
getProfile(),
|
||||
false);
|
||||
});
|
||||
@@ -1132,6 +1135,8 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
title = mParams.getLinkText();
|
||||
}
|
||||
tabItemDelegate.onReadLater(mParams.getUrl(), title);
|
||||
+ } else if (itemId == R.id.contextmenu_open_in_tab) {
|
||||
+ mItemDelegate.onOpenUrl(mParams.getUrl(), mParams.getReferrer());
|
||||
} else if (itemId == R.id.contextmenu_open_in_chrome) {
|
||||
recordContextMenuSelection(ContextMenuUma.Action.OPEN_IN_CHROME);
|
||||
mItemDelegate.onOpenInChrome(mParams.getUrl(), mParams.getPageUrl());
|
||||
tabItemDelegate.onOpenInChrome(mParams.getUrl(), mParams.getPageUrl());
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
@@ -414,6 +414,14 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
@@ -417,6 +417,14 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
mTab.loadUrl(loadUrlParams);
|
||||
}
|
||||
|
||||
@@ -168,39 +169,39 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextM
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
@@ -446,6 +446,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kTabGroupParityBottomSheetAndroid,
|
||||
@@ -447,6 +447,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kTabClosureMethodRefactor,
|
||||
&kTabModelInitFixes,
|
||||
&kTabStorageSqlitePrototype,
|
||||
+ &blink::features::kShowAlwaysContextMenuOnLinks,
|
||||
&kTabStripAutoSelectOnCloseChange,
|
||||
&kTabStripCloseRefactorAndroid,
|
||||
&kTabStripDensityChangeAndroid,
|
||||
&kTabStripGroupDragDropAndroid,
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
@@ -517,6 +517,8 @@ public abstract class ChromeFeatureList {
|
||||
@@ -528,6 +528,8 @@ public abstract class ChromeFeatureList {
|
||||
"DisableToolbarSwipeUp";
|
||||
public static final String MOVE_TOP_TOOLBAR_TO_BOTTOM =
|
||||
"MoveTopToolbarToBottom";
|
||||
+ public static final String SHOW_ALWAYS_CONTEXT_MENU_ON_LINKS =
|
||||
+ "ShowAlwaysContextMenuOnLinks";
|
||||
public static final String NEW_TAB_PAGE_CUSTOMIZATION_TOOLBAR_BUTTON =
|
||||
"NewTabPageCustomizationToolbarButton";
|
||||
public static final String NEW_TAB_PAGE_CUSTOMIZATION_THEME_SYNC =
|
||||
"NewTabPageCustomizationThemeSync";
|
||||
public static final String NEW_TAB_PAGE_CUSTOMIZATION_V2 = "NewTabPageCustomizationV2";
|
||||
@@ -1031,6 +1033,8 @@ public abstract class ChromeFeatureList {
|
||||
@@ -1051,6 +1053,8 @@ public abstract class ChromeFeatureList {
|
||||
newCachedFlag(DISABLE_TOOLBAR_SWIPE_UP, false);
|
||||
public static final CachedFlag sMoveTopToolbarToBottom =
|
||||
newCachedFlag(MOVE_TOP_TOOLBAR_TO_BOTTOM, false);
|
||||
+ public static final CachedFlag sShowAlwaysContextMenuOnLinks =
|
||||
+ newCachedFlag(SHOW_ALWAYS_CONTEXT_MENU_ON_LINKS, false);
|
||||
public static final CachedFlag sPaintPreviewDemo = newCachedFlag(PAINT_PREVIEW_DEMO, false);
|
||||
public static final CachedFlag sPostGetMyMemoryStateToBackground =
|
||||
newCachedFlag(POST_GET_MEMORY_PRESSURE_TO_BACKGROUND, true);
|
||||
@@ -1303,6 +1307,7 @@ public abstract class ChromeFeatureList {
|
||||
sTopControlsRefactor,
|
||||
public static final CachedFlag sPersistAcrossReboots =
|
||||
newCachedFlag(PERSIST_ACROSS_REBOOTS, false);
|
||||
@@ -1325,6 +1329,7 @@ public abstract class ChromeFeatureList {
|
||||
sTopControlsRefactorV2,
|
||||
sTouchToSearchCallout,
|
||||
sUnparcelIntentFileDescriptors,
|
||||
+ sShowAlwaysContextMenuOnLinks,
|
||||
sUseActivityManagerForTabActivation,
|
||||
sUseChimeAndroidSdk,
|
||||
@@ -208,7 +209,7 @@ diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/f
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -1572,6 +1572,12 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -1657,6 +1657,12 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
<message name="IDS_DISABLE_TOOLBAR_SWIPE_UP" desc="Summary of the preference that allows the user to disable toolbar swipeup.">
|
||||
Disable toolbar swipe up
|
||||
</message>
|
||||
@@ -221,7 +222,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
|
||||
<!-- Safety check -->
|
||||
<message name="IDS_PREFS_SAFETY_CHECK" desc="Title of the Safety check element in settings, allowing the user to check multiple areas of browser safety. [CHAR_LIMIT=32]">
|
||||
@@ -3237,6 +3243,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -3320,6 +3326,9 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_CONTEXTMENU_OPEN_IN_NEW_CHROME_TAB" desc="Context sensitive menu item to open the selected link in a new Chrome tab from Chrome Custom Tab. [CHAR_LIMIT=30]">
|
||||
Open in new Chrome tab
|
||||
</message>
|
||||
@@ -249,7 +250,7 @@ diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibil
|
||||
diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
--- a/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
+++ b/components/browser_ui/accessibility/android/java/src/org/chromium/components/browser_ui/accessibility/AccessibilitySettings.java
|
||||
@@ -60,6 +60,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
@@ -89,6 +89,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
private BooleanPreferenceDelegate mMoveTopToolbarToBottomDelegate;
|
||||
private BooleanPreferenceDelegate mDisableToolbarSwipeUpDelegate;
|
||||
|
||||
@@ -259,7 +260,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
private PageZoomPreference mPageZoomDefaultZoomPref;
|
||||
private ChromeSwitchPreference mPageZoomIncludeOSAdjustment;
|
||||
private ChromeSwitchPreference mPageZoomAlwaysShowPref;
|
||||
@@ -157,6 +160,12 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
@@ -198,6 +201,12 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
mDisableToolbarSwipeUpPref.setChecked(mDisableToolbarSwipeUpDelegate.getValue());
|
||||
mDisableToolbarSwipeUpPref.setOnPreferenceChangeListener(this);
|
||||
|
||||
@@ -272,7 +273,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
Preference captions = findPreference(PREF_CAPTIONS);
|
||||
captions.setOnPreferenceClickListener(
|
||||
preference -> {
|
||||
@@ -265,6 +274,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
@@ -323,6 +332,9 @@ public class AccessibilitySettings extends ChromeBaseSettingsFragment
|
||||
} else if (PREF_DISABLE_TOOLBAR_SWIPE_UP.equals(preference.getKey())) {
|
||||
mDisableToolbarSwipeUpDelegate.setValue((Boolean) newValue);
|
||||
mDelegate.requestRestart(getActivity());
|
||||
@@ -297,7 +298,7 @@ diff --git a/components/browser_ui/accessibility/android/java/src/org/chromium/c
|
||||
diff --git a/components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuItemDelegate.java b/components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuItemDelegate.java
|
||||
--- a/components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuItemDelegate.java
|
||||
+++ b/components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuItemDelegate.java
|
||||
@@ -10,6 +10,7 @@ import androidx.annotation.IntDef;
|
||||
@@ -11,6 +11,7 @@ import androidx.annotation.IntDef;
|
||||
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.content_public.browser.WebContents;
|
||||
@@ -305,7 +306,7 @@ diff --git a/components/embedder_support/android/java/src/org/chromium/component
|
||||
import org.chromium.url.GURL;
|
||||
|
||||
import java.lang.annotation.Retention;
|
||||
@@ -150,6 +151,8 @@ public interface ContextMenuItemDelegate {
|
||||
@@ -175,6 +176,8 @@ public interface ContextMenuItemDelegate {
|
||||
*/
|
||||
GURL getPageUrl();
|
||||
|
||||
@@ -314,6 +315,29 @@ diff --git a/components/embedder_support/android/java/src/org/chromium/component
|
||||
/**
|
||||
* Called when the current embedder app is not the default to handle a View Intent.
|
||||
*
|
||||
diff --git a/components/thin_webview/internal/java/src/org/chromium/components/thinwebview/internal/ThinWebViewContextMenuItemDelegate.java b/components/thin_webview/internal/java/src/org/chromium/components/thinwebview/internal/ThinWebViewContextMenuItemDelegate.java
|
||||
--- a/components/thin_webview/internal/java/src/org/chromium/components/thinwebview/internal/ThinWebViewContextMenuItemDelegate.java
|
||||
+++ b/components/thin_webview/internal/java/src/org/chromium/components/thinwebview/internal/ThinWebViewContextMenuItemDelegate.java
|
||||
@@ -6,6 +6,7 @@ package org.chromium.components.thinwebview.internal;
|
||||
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.components.embedder_support.contextmenu.ContextMenuItemDelegate;
|
||||
+import org.chromium.content_public.common.Referrer;
|
||||
import org.chromium.content_public.browser.WebContents;
|
||||
import org.chromium.ui.base.Clipboard;
|
||||
import org.chromium.url.GURL;
|
||||
@@ -43,6 +44,11 @@ public class ThinWebViewContextMenuItemDelegate implements ContextMenuItemDelega
|
||||
// Intentionally empty.
|
||||
}
|
||||
|
||||
+ @Override
|
||||
+ public void onOpenUrl(GURL url, Referrer referrer) {
|
||||
+ // Intentionally empty. (Add setting to invert tap and long tap)
|
||||
+ }
|
||||
+
|
||||
@Override
|
||||
public GURL getPageUrl() {
|
||||
return mWebContents.getVisibleUrl();
|
||||
diff --git a/cromite_flags/chrome/browser/about_flags_cc/Add-setting-to-invert-tap-and-long-tap.inc b/cromite_flags/chrome/browser/about_flags_cc/Add-setting-to-invert-tap-and-long-tap.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
@@ -344,7 +368,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third_party/blink/renderer/core/html/html_anchor_element.cc
|
||||
--- a/third_party/blink/renderer/core/html/html_anchor_element.cc
|
||||
+++ b/third_party/blink/renderer/core/html/html_anchor_element.cc
|
||||
@@ -65,6 +65,7 @@
|
||||
@@ -69,6 +69,7 @@
|
||||
#include "third_party/blink/renderer/core/loader/render_blocking_resource_manager.h"
|
||||
#include "third_party/blink/renderer/core/navigation_api/navigation_api.h"
|
||||
#include "third_party/blink/renderer/core/page/chrome_client.h"
|
||||
@@ -352,7 +376,7 @@ diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third
|
||||
#include "third_party/blink/renderer/core/page/page.h"
|
||||
#include "third_party/blink/renderer/core/scroll/scroll_into_view_util.h"
|
||||
#include "third_party/blink/renderer/core/speculation_rules/document_speculation_rules.h"
|
||||
@@ -415,6 +416,17 @@ void HTMLAnchorElementBase::NavigateToHyperlink(
|
||||
@@ -429,6 +430,17 @@ void HTMLAnchorElementBase::NavigateToHyperlink(
|
||||
bool is_trusted,
|
||||
base::TimeTicks platform_time_stamp,
|
||||
KURL completed_url) {
|
||||
@@ -370,7 +394,7 @@ diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third
|
||||
LocalDOMWindow* window = GetDocument().domWindow();
|
||||
if (!window) {
|
||||
return;
|
||||
@@ -495,6 +507,15 @@ void HTMLAnchorElementBase::NavigateToHyperlink(
|
||||
@@ -509,6 +521,15 @@ void HTMLAnchorElementBase::NavigateToHyperlink(
|
||||
frame_request.SetImpression(impression);
|
||||
}
|
||||
|
||||
@@ -386,7 +410,7 @@ diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third
|
||||
Frame* target_frame =
|
||||
frame->Tree().FindOrCreateFrameForNavigation(frame_request, target).frame;
|
||||
|
||||
@@ -531,7 +552,7 @@ bool HTMLAnchorElementBase::IsValidInterestInvoker(Element& target) const {
|
||||
@@ -545,7 +566,7 @@ bool HTMLAnchorElementBase::IsValidInterestInvoker(Element& target) const {
|
||||
return IsLink();
|
||||
}
|
||||
|
||||
@@ -395,7 +419,7 @@ diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third
|
||||
event.SetDefaultHandled();
|
||||
|
||||
LocalDOMWindow* window = GetDocument().domWindow();
|
||||
@@ -583,13 +604,12 @@ void HTMLAnchorElementBase::HandleClick(MouseEvent& event) {
|
||||
@@ -603,13 +624,12 @@ void HTMLAnchorElementBase::HandleClick(MouseEvent& event) {
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -413,7 +437,7 @@ diff --git a/third_party/blink/renderer/core/html/html_anchor_element.cc b/third
|
||||
// We distinguish single/double click with some modifiers.
|
||||
// See the comment of `EventHandler.delayed_navigation_task_handle_`.
|
||||
auto task_handle = PostDelayedCancellableTask(
|
||||
@@ -599,7 +619,9 @@ void HTMLAnchorElementBase::HandleClick(MouseEvent& event) {
|
||||
@@ -619,7 +639,9 @@ void HTMLAnchorElementBase::HandleClick(MouseEvent& event) {
|
||||
frame->GetEventHandler().SetDelayedNavigationTaskHandle(
|
||||
std::move(task_handle));
|
||||
} else {
|
||||
@@ -488,7 +512,7 @@ diff --git a/third_party/blink/renderer/core/html/html_image_element.cc b/third_
|
||||
+
|
||||
bool HTMLImageElement::draggable() const {
|
||||
// Image elements are draggable by default.
|
||||
return !EqualIgnoringASCIICase(FastGetAttribute(html_names::kDraggableAttr),
|
||||
return !EqualIgnoringAsciiCase(FastGetAttribute(html_names::kDraggableAttr),
|
||||
diff --git a/third_party/blink/renderer/core/html/html_image_element.h b/third_party/blink/renderer/core/html/html_image_element.h
|
||||
--- a/third_party/blink/renderer/core/html/html_image_element.h
|
||||
+++ b/third_party/blink/renderer/core/html/html_image_element.h
|
||||
@@ -552,7 +576,7 @@ diff --git a/third_party/blink/renderer/core/page/context_menu_controller.cc b/t
|
||||
// Clear any previously set cached results if we are resetting the hit test
|
||||
// result.
|
||||
image_selection_cached_result_ = nullptr;
|
||||
@@ -844,7 +857,7 @@ bool ContextMenuController::ShowContextMenu(LocalFrame* frame,
|
||||
@@ -843,7 +856,7 @@ bool ContextMenuController::ShowContextMenu(LocalFrame* frame,
|
||||
|
||||
SetAutofillData(result.InnerNode(), data);
|
||||
|
||||
|
||||
@@ -26,10 +26,10 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
--- a/chrome/browser/about_flags.cc
|
||||
+++ b/chrome/browser/about_flags.cc
|
||||
@@ -169,6 +169,7 @@
|
||||
@@ -166,6 +166,7 @@
|
||||
#include "components/sensitive_content/features.h"
|
||||
#include "components/services/heap_profiling/public/cpp/switches.h"
|
||||
#include "components/services/on_device_translation/buildflags/buildflags.h"
|
||||
#include "components/services/storage/public/cpp/buckets/bucket_info.h"
|
||||
#include "components/services/storage/dom_storage/features.h"
|
||||
+#include "components/site_engagement/core/features.h"
|
||||
#include "components/shared_highlighting/core/common/shared_highlighting_features.h"
|
||||
#include "components/sharing_message/features.h"
|
||||
@@ -37,7 +37,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
||||
diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/engagement/important_sites_util.cc
|
||||
--- a/chrome/browser/engagement/important_sites_util.cc
|
||||
+++ b/chrome/browser/engagement/important_sites_util.cc
|
||||
@@ -31,6 +31,7 @@
|
||||
@@ -29,6 +29,7 @@
|
||||
#include "components/prefs/scoped_user_pref_update.h"
|
||||
#include "components/site_engagement/content/site_engagement_score.h"
|
||||
#include "components/site_engagement/content/site_engagement_service.h"
|
||||
@@ -45,7 +45,7 @@ diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/
|
||||
#include "components/site_engagement/core/mojom/site_engagement_details.mojom.h"
|
||||
#include "components/webapps/browser/banners/app_banner_settings_helper.h"
|
||||
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
|
||||
@@ -345,6 +346,10 @@ void ImportantSitesUtil::RegisterProfilePrefs(
|
||||
@@ -343,6 +344,10 @@ void ImportantSitesUtil::RegisterProfilePrefs(
|
||||
// static
|
||||
std::set<std::string> ImportantSitesUtil::GetInstalledRegisterableDomains(
|
||||
Profile* profile) {
|
||||
@@ -56,7 +56,7 @@ diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/
|
||||
std::set<GURL> installed_origins = GetOriginsWithInstalledWebApps(profile);
|
||||
std::set<std::string> registerable_domains;
|
||||
|
||||
@@ -359,6 +364,10 @@ std::vector<ImportantDomainInfo>
|
||||
@@ -357,6 +362,10 @@ std::vector<ImportantDomainInfo>
|
||||
ImportantSitesUtil::GetImportantRegisterableDomains(Profile* profile,
|
||||
size_t max_results) {
|
||||
SCOPED_UMA_HISTOGRAM_TIMER("Storage.ImportantSites.GenerationTime");
|
||||
@@ -111,7 +111,7 @@ diff --git a/components/feature_engagement/internal/tracker_impl.cc b/components
|
||||
#include "components/feature_engagement/internal/availability_model_impl.h"
|
||||
#include "components/feature_engagement/internal/blocked_iph_features.h"
|
||||
#include "components/feature_engagement/internal/chrome_variations_configuration.h"
|
||||
@@ -291,6 +292,8 @@ TrackerImpl::TrackerImpl(
|
||||
@@ -290,6 +291,8 @@ TrackerImpl::TrackerImpl(
|
||||
TrackerImpl::~TrackerImpl() = default;
|
||||
|
||||
void TrackerImpl::NotifyEvent(const std::string& event) {
|
||||
@@ -131,7 +131,7 @@ diff --git a/components/feature_engagement/public/feature_configurations.cc b/co
|
||||
#include "components/feature_engagement/public/configuration.h"
|
||||
#include "components/feature_engagement/public/event_constants.h"
|
||||
#include "components/feature_engagement/public/feature_constants.h"
|
||||
@@ -121,6 +122,12 @@ std::optional<FeatureConfig> GetClientSideFeatureConfig(
|
||||
@@ -118,6 +119,12 @@ std::optional<FeatureConfig> GetClientSideFeatureConfig(
|
||||
}
|
||||
|
||||
#endif // BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)
|
||||
|
||||
@@ -5,22 +5,14 @@ Subject: Add support for ISupportHelpAndFeedback
|
||||
Original License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
---
|
||||
.../chrome/browser/settings/SettingsActivity.java | 9 +++++++--
|
||||
.../components/browser_ui/settings/SettingsUtils.java | 4 ++++
|
||||
2 files changed, 11 insertions(+), 2 deletions(-)
|
||||
.../chrome/browser/settings/SettingsActivity.java | 8 ++++++--
|
||||
.../components/browser_ui/settings/SettingsUtils.java | 4 ++++
|
||||
2 files changed, 10 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
@@ -68,6 +68,7 @@ import org.chromium.chrome.browser.ui.messages.snackbar.Snackbar;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetControllerFactory;
|
||||
import org.chromium.components.browser_ui.bottomsheet.ManagedBottomSheetController;
|
||||
+import org.chromium.components.browser_ui.settings.SettingsUtils;
|
||||
import org.chromium.components.browser_ui.modaldialog.AppModalPresenter;
|
||||
import org.chromium.components.browser_ui.settings.EmbeddableSettingsPage;
|
||||
import org.chromium.components.browser_ui.settings.PreferenceUpdateObserver;
|
||||
@@ -922,8 +923,12 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
@@ -1056,8 +1056,12 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
return true;
|
||||
} else if (item.getItemId() == R.id.menu_id_general_help) {
|
||||
RecordUserAction.record("Settings.MobileHelpAndFeedback");
|
||||
|
||||
@@ -15,7 +15,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/base/android/content_uri_utils.cc b/base/android/content_uri_utils.cc
|
||||
--- a/base/android/content_uri_utils.cc
|
||||
+++ b/base/android/content_uri_utils.cc
|
||||
@@ -137,6 +137,16 @@ static void JNI_ContentUriUtils_AddFileInfoToVector(JNIEnv* env,
|
||||
@@ -140,6 +140,16 @@ static void JNI_ContentUriUtils_AddFileInfoToVector(
|
||||
Time::FromMillisecondsSinceUnixEpoch(last_modified));
|
||||
}
|
||||
|
||||
|
||||
@@ -189,7 +189,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/core/execution_context/execution_context.cc b/third_party/blink/renderer/core/execution_context/execution_context.cc
|
||||
--- a/third_party/blink/renderer/core/execution_context/execution_context.cc
|
||||
+++ b/third_party/blink/renderer/core/execution_context/execution_context.cc
|
||||
@@ -94,6 +94,13 @@ blink::WebContentSettingsClient* GetContentSettingsClientFor(
|
||||
@@ -86,6 +86,13 @@ blink::WebContentSettingsClient* GetContentSettingsClientFor(
|
||||
return settings;
|
||||
}
|
||||
|
||||
@@ -206,7 +206,7 @@ diff --git a/third_party/blink/renderer/core/execution_context/execution_context
|
||||
diff --git a/third_party/blink/renderer/core/execution_context/execution_context.h b/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
--- a/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
+++ b/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
@@ -149,6 +149,8 @@ enum ReasonForCallingCanExecuteScripts {
|
||||
@@ -111,6 +111,8 @@ enum ReasonForCallingCanExecuteScripts {
|
||||
|
||||
enum ReferrerPolicySource { kPolicySourceHttpHeader, kPolicySourceMetaTag };
|
||||
|
||||
@@ -218,7 +218,7 @@ diff --git a/third_party/blink/renderer/core/execution_context/execution_context
|
||||
diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
|
||||
--- a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
|
||||
+++ b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
|
||||
@@ -341,6 +341,13 @@ void WebGLRenderingContextBase::InitializeWebGLContextLimits(
|
||||
@@ -342,6 +342,13 @@ void WebGLRenderingContextBase::InitializeWebGLContextLimits(
|
||||
}
|
||||
}
|
||||
|
||||
@@ -232,7 +232,7 @@ diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_ba
|
||||
unsigned WebGLRenderingContextBase::CurrentMaxGLContexts() {
|
||||
base::AutoLock locker(WebGLContextLimitLock());
|
||||
DCHECK(webgl_context_limits_initialized_);
|
||||
@@ -611,25 +618,6 @@ static String ExtractWebGLContextCreationError(
|
||||
@@ -612,25 +619,6 @@ static String ExtractWebGLContextCreationError(
|
||||
const Platform::WebGLContextInfo& info) {
|
||||
StringBuilder builder;
|
||||
builder.Append("Could not create a WebGL context");
|
||||
@@ -258,7 +258,7 @@ diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_ba
|
||||
FormatWebGLStatusString("ErrorMessage", info.error_message.Utf8().c_str(),
|
||||
builder);
|
||||
builder.Append('.');
|
||||
@@ -690,6 +678,12 @@ WebGLRenderingContextBase::CreateWebGraphicsContext3DProvider(
|
||||
@@ -691,6 +679,12 @@ WebGLRenderingContextBase::CreateWebGraphicsContext3DProvider(
|
||||
const CanvasContextCreationAttributesCore& attributes,
|
||||
Platform::WebGLContextType context_type,
|
||||
Platform::WebGLContextInfo* context_info) {
|
||||
@@ -274,7 +274,7 @@ diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_ba
|
||||
diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
|
||||
--- a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
|
||||
+++ b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
|
||||
@@ -1965,6 +1965,8 @@ class MODULES_EXPORT WebGLRenderingContextBase
|
||||
@@ -2009,6 +2009,8 @@ class MODULES_EXPORT WebGLRenderingContextBase
|
||||
DOMArrayBufferView* pixels,
|
||||
int64_t offset);
|
||||
|
||||
|
||||
@@ -187,7 +187,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc b/third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
|
||||
--- a/third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
|
||||
+++ b/third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
|
||||
@@ -47,6 +47,7 @@
|
||||
@@ -48,6 +48,7 @@
|
||||
#include "third_party/blink/public/platform/modules/webrtc/webrtc_logging.h"
|
||||
#include "third_party/blink/public/platform/platform.h"
|
||||
#include "third_party/blink/public/platform/task_type.h"
|
||||
@@ -195,7 +195,7 @@ diff --git a/third_party/blink/renderer/modules/peerconnection/peer_connection_d
|
||||
#include "third_party/blink/public/platform/web_url.h"
|
||||
#include "third_party/blink/public/web/modules/mediastream/media_stream_video_source.h"
|
||||
#include "third_party/blink/public/web/web_document.h"
|
||||
@@ -1041,6 +1042,11 @@ PeerConnectionDependencyFactory::CreatePortAllocator(
|
||||
@@ -1071,6 +1072,11 @@ PeerConnectionDependencyFactory::CreatePortAllocator(
|
||||
// |request_multiple_routes|. Whether local IP addresses could be
|
||||
// collected depends on if mic/camera permission is granted for this
|
||||
// origin.
|
||||
|
||||
@@ -34,7 +34,7 @@ diff --git a/third_party/blink/renderer/modules/document_picture_in_picture/pict
|
||||
#include "third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_event.h"
|
||||
#include "third_party/blink/renderer/platform/heap/garbage_collected.h"
|
||||
#include "third_party/blink/renderer/platform/runtime_enabled_features.h"
|
||||
@@ -388,6 +389,12 @@ void PictureInPictureControllerImpl::CreateDocumentPictureInPictureWindow(
|
||||
@@ -386,6 +387,12 @@ void PictureInPictureControllerImpl::CreateDocumentPictureInPictureWindow(
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -43,7 +43,7 @@ diff --git a/chrome/browser/net/chrome_report_sender.cc b/chrome/browser/net/chr
|
||||
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
|
||||
--- a/content/browser/devtools/protocol/network_handler.cc
|
||||
+++ b/content/browser/devtools/protocol/network_handler.cc
|
||||
@@ -1517,6 +1517,7 @@ String BuildReportStatus(const net::ReportingReport::Status status) {
|
||||
@@ -1628,6 +1628,7 @@ String BuildReportStatus(const net::ReportingReport::Status status) {
|
||||
}
|
||||
}
|
||||
|
||||
@@ -51,7 +51,7 @@ diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/brow
|
||||
std::vector<GURL> ComputeReportingURLs(RenderFrameHostImpl* frame_host) {
|
||||
std::vector<GURL> urls;
|
||||
frame_host->ForEachRenderFrameHostImplWithAction(
|
||||
@@ -1530,6 +1531,7 @@ std::vector<GURL> ComputeReportingURLs(RenderFrameHostImpl* frame_host) {
|
||||
@@ -1641,6 +1642,7 @@ std::vector<GURL> ComputeReportingURLs(RenderFrameHostImpl* frame_host) {
|
||||
});
|
||||
return urls;
|
||||
}
|
||||
@@ -87,7 +87,7 @@ diff --git a/content/browser/network/cross_origin_embedder_policy_reporter.cc b/
|
||||
+ const std::optional<std::string>& endpoint =
|
||||
+ report_only ? report_only_endpoint_ : endpoint_;
|
||||
if (endpoint) {
|
||||
base::Value::Dict body_to_pass;
|
||||
base::DictValue body_to_pass;
|
||||
for (const auto& pair : body) {
|
||||
@@ -125,6 +127,7 @@ void CrossOriginEmbedderPolicyReporter::QueueAndNotify(
|
||||
network_anonymization_key_, std::move(body_to_pass));
|
||||
@@ -111,7 +111,7 @@ diff --git a/content/browser/network/reporting_service_proxy.cc b/content/browse
|
||||
@@ -241,12 +242,14 @@ class ReportingServiceProxyImpl : public blink::mojom::ReportingServiceProxy {
|
||||
const std::string& group,
|
||||
const std::string& type,
|
||||
base::Value::Dict body) {
|
||||
base::DictValue body) {
|
||||
+#if BUILDFLAG(ENABLE_REPORTING)
|
||||
auto* rph = RenderProcessHost::FromID(render_process_id_);
|
||||
if (!rph)
|
||||
@@ -126,7 +126,7 @@ diff --git a/content/browser/network/reporting_service_proxy.cc b/content/browse
|
||||
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
@@ -16347,12 +16347,6 @@ void RenderFrameHostImpl::MaybeGenerateCrashReport(
|
||||
@@ -16697,12 +16697,6 @@ void RenderFrameHostImpl::MaybeGenerateCrashReport(
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -138,7 +138,7 @@ diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/b
|
||||
- std::move(body));
|
||||
}
|
||||
|
||||
void RenderFrameHostImpl::UpdateOrDisableCompositorMetricRecorder() const {
|
||||
base::DictValue RenderFrameHostImpl::ReadCrashReportAPIBody() {
|
||||
diff --git a/content/browser/security/coop/cross_origin_opener_policy_reporter.cc b/content/browser/security/coop/cross_origin_opener_policy_reporter.cc
|
||||
--- a/content/browser/security/coop/cross_origin_opener_policy_reporter.cc
|
||||
+++ b/content/browser/security/coop/cross_origin_opener_policy_reporter.cc
|
||||
@@ -201,7 +201,7 @@ diff --git a/content/browser/security/coop/cross_origin_opener_policy_reporter.c
|
||||
}
|
||||
|
||||
void CrossOriginOpenerPolicyReporter::QueueNavigationReport(
|
||||
base::Value::Dict body,
|
||||
base::DictValue body,
|
||||
const std::string& endpoint,
|
||||
bool is_report_only) {
|
||||
+#if BUILDFLAG(ENABLE_REPORTING)
|
||||
@@ -292,7 +292,7 @@ diff --git a/net/reporting/reporting_header_parser.cc b/net/reporting/reporting_
|
||||
diff --git a/net/reporting/reporting_service.cc b/net/reporting/reporting_service.cc
|
||||
--- a/net/reporting/reporting_service.cc
|
||||
+++ b/net/reporting/reporting_service.cc
|
||||
@@ -236,6 +236,12 @@ class ReportingServiceImpl : public ReportingService {
|
||||
@@ -227,6 +227,12 @@ class ReportingServiceImpl : public ReportingService {
|
||||
int depth,
|
||||
base::TimeTicks queued_ticks,
|
||||
ReportingTargetType target_type) {
|
||||
@@ -308,17 +308,17 @@ diff --git a/net/reporting/reporting_service.cc b/net/reporting/reporting_servic
|
||||
diff --git a/services/network/network_context.h b/services/network/network_context.h
|
||||
--- a/services/network/network_context.h
|
||||
+++ b/services/network/network_context.h
|
||||
@@ -499,14 +499,14 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
|
||||
@@ -492,14 +492,14 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
|
||||
const GURL& url,
|
||||
const std::optional<base::UnguessableToken>& reporting_source,
|
||||
const net::NetworkAnonymizationKey& network_anonymization_key,
|
||||
- base::Value::Dict body) override;
|
||||
+ base::Value::Dict body);
|
||||
- base::DictValue body) override;
|
||||
+ base::DictValue body);
|
||||
void QueueEnterpriseReport(const std::string& type,
|
||||
const std::string& group,
|
||||
const GURL& url,
|
||||
- base::Value::Dict body) override;
|
||||
+ base::Value::Dict body);
|
||||
- base::DictValue body) override;
|
||||
+ base::DictValue body);
|
||||
void QueueSignedExchangeReport(
|
||||
mojom::SignedExchangeReportPtr report,
|
||||
- const net::NetworkAnonymizationKey& network_anonymization_key) override;
|
||||
@@ -329,7 +329,7 @@ diff --git a/services/network/network_context.h b/services/network/network_conte
|
||||
diff --git a/services/network/public/cpp/parsed_headers.cc b/services/network/public/cpp/parsed_headers.cc
|
||||
--- a/services/network/public/cpp/parsed_headers.cc
|
||||
+++ b/services/network/public/cpp/parsed_headers.cc
|
||||
@@ -140,6 +140,7 @@ mojom::ParsedHeadersPtr PopulateParsedHeaders(
|
||||
@@ -137,6 +137,7 @@ mojom::ParsedHeadersPtr PopulateParsedHeaders(
|
||||
}
|
||||
|
||||
#if BUILDFLAG(ENABLE_REPORTING)
|
||||
@@ -340,7 +340,7 @@ diff --git a/services/network/public/cpp/parsed_headers.cc b/services/network/pu
|
||||
diff --git a/services/network/public/mojom/BUILD.gn b/services/network/public/mojom/BUILD.gn
|
||||
--- a/services/network/public/mojom/BUILD.gn
|
||||
+++ b/services/network/public/mojom/BUILD.gn
|
||||
@@ -1833,7 +1833,6 @@ mojom("mojom") {
|
||||
@@ -1894,7 +1894,6 @@ mojom("mojom") {
|
||||
export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
|
||||
export_header_blink = "third_party/blink/public/platform/web_common.h"
|
||||
if (enable_reporting) {
|
||||
@@ -351,7 +351,7 @@ diff --git a/services/network/public/mojom/BUILD.gn b/services/network/public/mo
|
||||
diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
|
||||
--- a/services/network/public/mojom/network_context.mojom
|
||||
+++ b/services/network/public/mojom/network_context.mojom
|
||||
@@ -1245,6 +1245,7 @@ interface NetworkContext {
|
||||
@@ -1247,6 +1247,7 @@ interface NetworkContext {
|
||||
// provided `network_anonymization_key`.
|
||||
//
|
||||
// Spec: https://w3c.github.io/reporting/#concept-reports
|
||||
@@ -359,7 +359,7 @@ diff --git a/services/network/public/mojom/network_context.mojom b/services/netw
|
||||
QueueReport(string type,
|
||||
string group,
|
||||
url.mojom.Url url,
|
||||
@@ -1252,6 +1253,7 @@ interface NetworkContext {
|
||||
@@ -1254,6 +1255,7 @@ interface NetworkContext {
|
||||
NetworkAnonymizationKey network_anonymization_key,
|
||||
mojo_base.mojom.DictionaryValue body);
|
||||
|
||||
@@ -367,7 +367,7 @@ diff --git a/services/network/public/mojom/network_context.mojom b/services/netw
|
||||
QueueEnterpriseReport(string type,
|
||||
string group,
|
||||
url.mojom.Url url,
|
||||
@@ -1262,6 +1264,7 @@ interface NetworkContext {
|
||||
@@ -1264,6 +1266,7 @@ interface NetworkContext {
|
||||
// Note that this queued report will never be delivered if no reporting
|
||||
// endpoint matching is registered for with the provided
|
||||
// `network_anonymization_key`.
|
||||
@@ -383,10 +383,10 @@ diff --git a/third_party/blink/renderer/core/frame/csp/content_security_policy.c
|
||||
#include <utility>
|
||||
|
||||
+#include "net/net_buildflags.h"
|
||||
#include "base/containers/contains.h"
|
||||
#include "base/debug/dump_without_crashing.h"
|
||||
#include "base/feature_list.h"
|
||||
@@ -1355,6 +1356,7 @@ void ContentSecurityPolicy::ReportViolation(
|
||||
#include "base/metrics/histogram_functions.h"
|
||||
@@ -1378,6 +1379,7 @@ void ContentSecurityPolicy::ReportViolation(
|
||||
ShouldBypassContentSecurityPolicy(KURL(violation_data->sourceFile()))) {
|
||||
return;
|
||||
}
|
||||
@@ -394,7 +394,7 @@ diff --git a/third_party/blink/renderer/core/frame/csp/content_security_policy.c
|
||||
PostViolationReport(violation_data, context_frame, report_endpoints,
|
||||
use_reporting_api);
|
||||
|
||||
@@ -1362,6 +1364,7 @@ void ContentSecurityPolicy::ReportViolation(
|
||||
@@ -1385,6 +1387,7 @@ void ContentSecurityPolicy::ReportViolation(
|
||||
// `context_frame` (i.e. we're not processing 'frame-ancestors').
|
||||
if (delegate_ && !context_frame)
|
||||
delegate_->DispatchViolationEvent(*violation_data, element);
|
||||
@@ -405,7 +405,7 @@ diff --git a/third_party/blink/renderer/core/frame/csp/content_security_policy.c
|
||||
diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
--- a/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
+++ b/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
@@ -49,6 +49,7 @@
|
||||
@@ -50,6 +50,7 @@
|
||||
#include "build/build_config.h"
|
||||
#include "mojo/public/cpp/bindings/self_owned_receiver.h"
|
||||
#include "mojo/public/cpp/system/message_pipe.h"
|
||||
@@ -413,7 +413,7 @@ diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/
|
||||
#include "services/network/public/cpp/features.h"
|
||||
#include "services/network/public/mojom/content_security_policy.mojom-blink.h"
|
||||
#include "services/network/public/mojom/source_location.mojom-blink.h"
|
||||
@@ -2871,9 +2872,11 @@ DocumentResourceCoordinator* LocalFrame::GetDocumentResourceCoordinator() {
|
||||
@@ -2889,9 +2890,11 @@ DocumentResourceCoordinator* LocalFrame::GetDocumentResourceCoordinator() {
|
||||
return CHECK_DEREF(GetDocument()).GetResourceCoordinator();
|
||||
}
|
||||
|
||||
@@ -436,7 +436,7 @@ diff --git a/third_party/blink/renderer/core/frame/local_frame.h b/third_party/b
|
||||
#include "net/storage_access_api/status.h"
|
||||
#include "services/metrics/public/cpp/ukm_source_id.h"
|
||||
#include "services/network/public/mojom/fetch_api.mojom-blink-forward.h"
|
||||
@@ -670,7 +671,9 @@ class CORE_EXPORT LocalFrame final
|
||||
@@ -677,7 +678,9 @@ class CORE_EXPORT LocalFrame final
|
||||
return client_hints_preferences_;
|
||||
}
|
||||
|
||||
@@ -457,17 +457,17 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.cc b/third_
|
||||
#include "third_party/blink/public/platform/browser_interface_broker_proxy.h"
|
||||
#include "third_party/blink/public/platform/platform.h"
|
||||
#include "third_party/blink/public/platform/task_type.h"
|
||||
@@ -55,7 +56,9 @@ bool ShouldReportBeVisibleToObservers(Report* report) {
|
||||
|
||||
@@ -59,7 +60,9 @@ const char ReportingContext::kSupplementName[] = "ReportingContext";
|
||||
ReportingContext::ReportingContext(ExecutionContext& context)
|
||||
: execution_context_(context),
|
||||
: Supplement<ExecutionContext>(context),
|
||||
execution_context_(context),
|
||||
+#if BUILDFLAG(ENABLE_REPORTING)
|
||||
reporting_service_(&context),
|
||||
+#endif
|
||||
receivers_(this, &context) {}
|
||||
|
||||
// static
|
||||
@@ -121,7 +124,9 @@ void ReportingContext::Trace(Visitor* visitor) const {
|
||||
@@ -126,7 +129,9 @@ void ReportingContext::Trace(Visitor* visitor) const {
|
||||
visitor->Trace(observers_);
|
||||
visitor->Trace(report_buffer_);
|
||||
visitor->Trace(execution_context_);
|
||||
@@ -475,9 +475,9 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.cc b/third_
|
||||
visitor->Trace(reporting_service_);
|
||||
+#endif
|
||||
visitor->Trace(receivers_);
|
||||
Supplement<ExecutionContext>::Trace(visitor);
|
||||
}
|
||||
|
||||
@@ -143,6 +148,7 @@ void ReportingContext::CountReport(Report* report) {
|
||||
@@ -149,6 +154,7 @@ void ReportingContext::CountReport(Report* report) {
|
||||
UseCounter::Count(execution_context_, feature);
|
||||
}
|
||||
|
||||
@@ -485,7 +485,7 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.cc b/third_
|
||||
const HeapMojoRemote<mojom::blink::ReportingServiceProxy>&
|
||||
ReportingContext::GetReportingService() const {
|
||||
if (!reporting_service_.is_bound()) {
|
||||
@@ -152,6 +158,7 @@ ReportingContext::GetReportingService() const {
|
||||
@@ -158,6 +164,7 @@ ReportingContext::GetReportingService() const {
|
||||
}
|
||||
return reporting_service_;
|
||||
}
|
||||
@@ -493,7 +493,7 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.cc b/third_
|
||||
|
||||
void ReportingContext::NotifyInternal(Report* report) {
|
||||
if (!ShouldReportBeVisibleToObservers(report)) {
|
||||
@@ -178,6 +185,7 @@ void ReportingContext::NotifyInternal(Report* report) {
|
||||
@@ -184,6 +191,7 @@ void ReportingContext::NotifyInternal(Report* report) {
|
||||
|
||||
void ReportingContext::SendToReportingAPI(Report* report,
|
||||
const String& endpoint) const {
|
||||
@@ -501,7 +501,7 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.cc b/third_
|
||||
const String& type = report->type();
|
||||
if (!(type == ReportType::kCSPViolation || type == ReportType::kCSPHash ||
|
||||
type == ReportType::kDeprecation ||
|
||||
@@ -262,6 +270,7 @@ void ReportingContext::SendToReportingAPI(Report* report,
|
||||
@@ -268,6 +276,7 @@ void ReportingContext::SendToReportingAPI(Report* report,
|
||||
url, endpoint, body->featureId(), body->disposition(), body->message(),
|
||||
body->sourceFile(), line_number, column_number);
|
||||
}
|
||||
@@ -520,7 +520,7 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.h b/third_p
|
||||
#include "third_party/blink/public/mojom/frame/reporting_observer.mojom-blink.h"
|
||||
#include "third_party/blink/public/mojom/reporting/reporting.mojom-blink.h"
|
||||
#include "third_party/blink/renderer/core/core_export.h"
|
||||
@@ -52,10 +53,10 @@ class CORE_EXPORT ReportingContext : public GarbageCollected<ReportingContext>,
|
||||
@@ -56,10 +57,10 @@ class CORE_EXPORT ReportingContext : public GarbageCollected<ReportingContext>,
|
||||
private:
|
||||
// Counts the use of a report type via UseCounter.
|
||||
void CountReport(Report*);
|
||||
@@ -533,7 +533,7 @@ diff --git a/third_party/blink/renderer/core/frame/reporting_context.h b/third_p
|
||||
void NotifyInternal(Report* report);
|
||||
// Send |report| via the Reporting API to |endpoint|.
|
||||
void SendToReportingAPI(Report* report, const String& endpoint) const;
|
||||
@@ -67,8 +68,10 @@ class CORE_EXPORT ReportingContext : public GarbageCollected<ReportingContext>,
|
||||
@@ -71,8 +72,10 @@ class CORE_EXPORT ReportingContext : public GarbageCollected<ReportingContext>,
|
||||
|
||||
// This is declared mutable so that the service endpoint can be cached by
|
||||
// const methods.
|
||||
|
||||
@@ -7,24 +7,25 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
chrome/android/BUILD.gn | 1 -
|
||||
.../chrome/browser/feedback/ChromeFeedbackCollector.java | 1 -
|
||||
chrome/browser/feedback/android/BUILD.gn | 2 --
|
||||
chrome/browser/prefs/chrome_pref_service_factory.cc | 2 +-
|
||||
chrome/browser/prefs/chrome_pref_service_factory.cc | 6 ------
|
||||
chrome/browser/profiles/profile_attributes_entry.cc | 2 +-
|
||||
chrome/browser/profiles/profile_impl.cc | 5 +----
|
||||
chrome/browser/profiles/profile_manager.cc | 7 -------
|
||||
.../supervised_user/supervised_user_browser_utils.cc | 1 +
|
||||
chrome/browser/ui/webui/managed_ui_handler.cc | 4 ----
|
||||
.../browser/ui/webui/management/management_ui_handler.cc | 4 ----
|
||||
.../browser/android/content_filters_observer_bridge.cc | 2 +-
|
||||
.../core/browser/supervised_user_pref_store.cc | 1 +
|
||||
.../core/browser/supervised_user_preferences.cc | 6 +++++-
|
||||
.../core/browser/supervised_user_service.cc | 1 +
|
||||
components/supervised_user/core/common/features.cc | 3 ++-
|
||||
components/supervised_user/core/common/features.cc | 1 +
|
||||
extensions/browser/api/management/management_api.cc | 1 +
|
||||
15 files changed, 14 insertions(+), 27 deletions(-)
|
||||
16 files changed, 13 insertions(+), 32 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
||||
--- a/chrome/android/BUILD.gn
|
||||
+++ b/chrome/android/BUILD.gn
|
||||
@@ -815,7 +815,6 @@ if (_is_default_toolchain) {
|
||||
@@ -833,7 +833,6 @@ if (_is_default_toolchain) {
|
||||
"//components/offline_pages/core:offline_page_model_enums_java",
|
||||
"//components/sharing_message:sharing_dialog_type_generated_enum",
|
||||
"//components/sharing_message:sharing_send_message_result_generated_enum",
|
||||
@@ -35,7 +36,7 @@ diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeFeedbackCollector.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeFeedbackCollector.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeFeedbackCollector.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeFeedbackCollector.java
|
||||
@@ -95,7 +95,6 @@ public class ChromeFeedbackCollector extends FeedbackCollector<ChromeFeedbackCol
|
||||
@@ -96,7 +96,6 @@ public class ChromeFeedbackCollector extends FeedbackCollector<ChromeFeedbackCol
|
||||
// FamilyInfoFeedbackSource relies on IdentityManager which is not available for the
|
||||
// incognito profile.
|
||||
if (!initParams.profile.isOffTheRecord()) {
|
||||
@@ -65,19 +66,23 @@ diff --git a/chrome/browser/feedback/android/BUILD.gn b/chrome/browser/feedback/
|
||||
diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc
|
||||
--- a/chrome/browser/prefs/chrome_pref_service_factory.cc
|
||||
+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc
|
||||
@@ -332,7 +332,7 @@ void PrepareFactory(
|
||||
policy::BrowserPolicyConnector* policy_connector) {
|
||||
factory->SetManagedPolicies(policy_service, policy_connector);
|
||||
factory->SetRecommendedPolicies(policy_service, policy_connector);
|
||||
- if (supervised_user_settings) {
|
||||
+ if (((false)) && supervised_user_settings) {
|
||||
// supervised_user_prefs handles the case when content_filters_service is
|
||||
// nullptr. It's simply not subscribing to empty service's notifications.
|
||||
scoped_refptr<PrefStore> supervised_user_prefs =
|
||||
@@ -352,12 +352,6 @@ void PrepareFactory(
|
||||
PrepareFactory(factory, pref_filename, policy_service,
|
||||
std::move(user_pref_store), std::move(extension_prefs), async,
|
||||
policy_connector);
|
||||
-
|
||||
- scoped_refptr<PrefStore> supervised_user_prefs =
|
||||
- base::MakeRefCounted<SupervisedUserPrefStore>(
|
||||
- family_link_settings_service, device_parental_controls);
|
||||
- DCHECK(async || supervised_user_prefs->IsInitializationComplete());
|
||||
- factory->set_supervised_user_prefs(supervised_user_prefs);
|
||||
}
|
||||
|
||||
class ResetOnLoadObserverImpl : public prefs::mojom::ResetOnLoadObserver {
|
||||
diff --git a/chrome/browser/profiles/profile_attributes_entry.cc b/chrome/browser/profiles/profile_attributes_entry.cc
|
||||
--- a/chrome/browser/profiles/profile_attributes_entry.cc
|
||||
+++ b/chrome/browser/profiles/profile_attributes_entry.cc
|
||||
@@ -476,7 +476,7 @@ bool ProfileAttributesEntry::IsSigninRequired() const {
|
||||
@@ -468,7 +468,7 @@ bool ProfileAttributesEntry::IsSigninRequired() const {
|
||||
}
|
||||
|
||||
std::string ProfileAttributesEntry::GetSupervisedUserId() const {
|
||||
@@ -89,7 +94,7 @@ diff --git a/chrome/browser/profiles/profile_attributes_entry.cc b/chrome/browse
|
||||
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
|
||||
--- a/chrome/browser/profiles/profile_impl.cc
|
||||
+++ b/chrome/browser/profiles/profile_impl.cc
|
||||
@@ -679,10 +679,6 @@ void ProfileImpl::DoFinalInit(CreateMode create_mode) {
|
||||
@@ -685,10 +685,6 @@ void ProfileImpl::DoFinalInit(CreateMode create_mode) {
|
||||
prefs->SetTime(prefs::kProfileCreationTime, path_creation_time_);
|
||||
|
||||
pref_change_registrar_.Init(prefs);
|
||||
@@ -100,7 +105,7 @@ diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/p
|
||||
|
||||
// Changes in the profile avatar.
|
||||
pref_change_registrar_.Add(
|
||||
@@ -1603,6 +1599,7 @@ GURL ProfileImpl::GetHomePage() {
|
||||
@@ -1604,6 +1600,7 @@ GURL ProfileImpl::GetHomePage() {
|
||||
}
|
||||
|
||||
void ProfileImpl::UpdateSupervisedUserIdInStorage() {
|
||||
@@ -111,7 +116,7 @@ diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/p
|
||||
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
|
||||
--- a/chrome/browser/profiles/profile_manager.cc
|
||||
+++ b/chrome/browser/profiles/profile_manager.cc
|
||||
@@ -1262,10 +1262,6 @@ void ProfileManager::InitProfileUserPrefs(Profile* profile) {
|
||||
@@ -1276,10 +1276,6 @@ void ProfileManager::InitProfileUserPrefs(Profile* profile) {
|
||||
profile->GetPrefs()->SetString(prefs::kProfileName, profile_name);
|
||||
}
|
||||
|
||||
@@ -122,7 +127,7 @@ diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profile
|
||||
}
|
||||
|
||||
void ProfileManager::RegisterTestingProfile(std::unique_ptr<Profile> profile,
|
||||
@@ -2044,9 +2040,6 @@ void ProfileManager::AddProfileToStorage(Profile* profile) {
|
||||
@@ -2077,9 +2073,6 @@ void ProfileManager::AddProfileToStorage(Profile* profile) {
|
||||
init_params.icon_index =
|
||||
profile->GetPrefs()->GetInteger(prefs::kProfileAvatarIndex);
|
||||
|
||||
@@ -146,7 +151,7 @@ diff --git a/chrome/browser/supervised_user/supervised_user_browser_utils.cc b/c
|
||||
diff --git a/chrome/browser/ui/webui/managed_ui_handler.cc b/chrome/browser/ui/webui/managed_ui_handler.cc
|
||||
--- a/chrome/browser/ui/webui/managed_ui_handler.cc
|
||||
+++ b/chrome/browser/ui/webui/managed_ui_handler.cc
|
||||
@@ -89,10 +89,6 @@ void ManagedUIHandler::AddObservers() {
|
||||
@@ -88,10 +88,6 @@ void ManagedUIHandler::AddObservers() {
|
||||
auto domain = static_cast<policy::PolicyDomain>(i);
|
||||
policy_service->AddObserver(domain, this);
|
||||
}
|
||||
@@ -160,7 +165,7 @@ diff --git a/chrome/browser/ui/webui/managed_ui_handler.cc b/chrome/browser/ui/w
|
||||
diff --git a/chrome/browser/ui/webui/management/management_ui_handler.cc b/chrome/browser/ui/webui/management/management_ui_handler.cc
|
||||
--- a/chrome/browser/ui/webui/management/management_ui_handler.cc
|
||||
+++ b/chrome/browser/ui/webui/management/management_ui_handler.cc
|
||||
@@ -623,10 +623,6 @@ bool ManagementUIHandler::managed() const {
|
||||
@@ -621,10 +621,6 @@ bool ManagementUIHandler::managed() const {
|
||||
|
||||
void ManagementUIHandler::RegisterPrefChange(
|
||||
PrefChangeRegistrar& pref_registrar) {
|
||||
@@ -171,17 +176,29 @@ diff --git a/chrome/browser/ui/webui/management/management_ui_handler.cc b/chrom
|
||||
}
|
||||
|
||||
void ManagementUIHandler::UpdateManagedState() {
|
||||
diff --git a/components/supervised_user/core/browser/android/content_filters_observer_bridge.cc b/components/supervised_user/core/browser/android/content_filters_observer_bridge.cc
|
||||
--- a/components/supervised_user/core/browser/android/content_filters_observer_bridge.cc
|
||||
+++ b/components/supervised_user/core/browser/android/content_filters_observer_bridge.cc
|
||||
@@ -39,7 +39,7 @@ void ContentFiltersObserverBridge::OnChange(JNIEnv* env, bool enabled) {
|
||||
}
|
||||
|
||||
void ContentFiltersObserverBridge::SetEnabled(bool enabled) {
|
||||
- enabled_ = enabled;
|
||||
+ enabled_ = false;
|
||||
NotifyObservers();
|
||||
}
|
||||
|
||||
diff --git a/components/supervised_user/core/browser/supervised_user_pref_store.cc b/components/supervised_user/core/browser/supervised_user_pref_store.cc
|
||||
--- a/components/supervised_user/core/browser/supervised_user_pref_store.cc
|
||||
+++ b/components/supervised_user/core/browser/supervised_user_pref_store.cc
|
||||
@@ -172,6 +172,7 @@ void SupervisedUserPrefStore::OnNewContentFiltersStateAvailable(
|
||||
@@ -188,6 +188,7 @@ void SupervisedUserPrefStore::RecreatePreferences() {
|
||||
return;
|
||||
}
|
||||
|
||||
void SupervisedUserPrefStore::OnNewSettingsAvailable(
|
||||
const base::Value::Dict& settings) {
|
||||
+ if ((true)) return;
|
||||
std::unique_ptr<PrefValueMap> old_prefs = std::move(prefs_);
|
||||
prefs_ = std::make_unique<PrefValueMap>();
|
||||
if (!settings.empty()) {
|
||||
|
||||
diff --git a/components/supervised_user/core/browser/supervised_user_preferences.cc b/components/supervised_user/core/browser/supervised_user_preferences.cc
|
||||
--- a/components/supervised_user/core/browser/supervised_user_preferences.cc
|
||||
+++ b/components/supervised_user/core/browser/supervised_user_preferences.cc
|
||||
@@ -208,7 +225,7 @@ diff --git a/components/supervised_user/core/browser/supervised_user_preferences
|
||||
diff --git a/components/supervised_user/core/browser/supervised_user_service.cc b/components/supervised_user/core/browser/supervised_user_service.cc
|
||||
--- a/components/supervised_user/core/browser/supervised_user_service.cc
|
||||
+++ b/components/supervised_user/core/browser/supervised_user_service.cc
|
||||
@@ -244,6 +244,7 @@ SupervisedUserService::SupervisedUserService(
|
||||
@@ -160,6 +160,7 @@ SupervisedUserService::SupervisedUserService(
|
||||
}
|
||||
|
||||
void SupervisedUserService::SetSettingsServiceActive(bool active) {
|
||||
@@ -219,28 +236,14 @@ diff --git a/components/supervised_user/core/browser/supervised_user_service.cc
|
||||
diff --git a/components/supervised_user/core/common/features.cc b/components/supervised_user/core/common/features.cc
|
||||
--- a/components/supervised_user/core/common/features.cc
|
||||
+++ b/components/supervised_user/core/common/features.cc
|
||||
@@ -30,7 +30,6 @@ BASE_FEATURE(kAllowSubframeLocalWebApprovals,
|
||||
#else
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
#endif
|
||||
-
|
||||
#if BUILDFLAG(IS_IOS) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || \
|
||||
BUILDFLAG(IS_WIN)
|
||||
const int kLocalWebApprovalBottomSheetLoadTimeoutDefaultValueMs = 5000;
|
||||
@@ -116,6 +115,7 @@ const base::FeatureParam<std::string>
|
||||
|
||||
namespace {
|
||||
bool PlatformSupportsLocalSupervision() {
|
||||
+ if ((true)) return false;
|
||||
int32_t major, minor, bugfix;
|
||||
base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugfix);
|
||||
bool supported_by_os = (major == 16 && minor >= 1) || major > 16;
|
||||
@@ -151,4 +151,5 @@ bool ClassifyUrlWithoutCredentialsForLocalSupervision() {
|
||||
|
||||
#endif
|
||||
|
||||
@@ -19,6 +19,7 @@ namespace supervised_user {
|
||||
// Enables local parent approvals for the blocked website on the Family Link
|
||||
// user's device.
|
||||
BASE_FEATURE(kLocalWebApprovals, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kLocalWebApprovals);
|
||||
} // namespace supervised_user
|
||||
|
||||
// TODO(crbug.com/391799078): Support local web approval for subframes on
|
||||
// Desktop.
|
||||
diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc
|
||||
--- a/extensions/browser/api/management/management_api.cc
|
||||
+++ b/extensions/browser/api/management/management_api.cc
|
||||
|
||||
@@ -23,7 +23,7 @@ diff --git a/content/public/renderer/render_frame_media_playback_options.cc b/co
|
||||
diff --git a/third_party/blink/renderer/platform/media/web_media_player_impl.cc b/third_party/blink/renderer/platform/media/web_media_player_impl.cc
|
||||
--- a/third_party/blink/renderer/platform/media/web_media_player_impl.cc
|
||||
+++ b/third_party/blink/renderer/platform/media/web_media_player_impl.cc
|
||||
@@ -1287,6 +1287,12 @@ bool WebMediaPlayerImpl::HasAudio() const {
|
||||
@@ -1342,6 +1342,12 @@ bool WebMediaPlayerImpl::HasAudio() const {
|
||||
return pipeline_metadata_.has_audio;
|
||||
}
|
||||
|
||||
@@ -36,7 +36,7 @@ diff --git a/third_party/blink/renderer/platform/media/web_media_player_impl.cc
|
||||
void WebMediaPlayerImpl::EnabledAudioTracksChanged(
|
||||
std::optional<WebMediaPlayer::TrackId> enabled_track_id) {
|
||||
DCHECK(main_task_runner_->BelongsToCurrentThread());
|
||||
@@ -3654,7 +3660,10 @@ bool WebMediaPlayerImpl::ShouldPausePlaybackWhenHidden() const {
|
||||
@@ -3740,7 +3746,10 @@ bool WebMediaPlayerImpl::ShouldPausePlaybackWhenHidden() const {
|
||||
|
||||
const bool preserve_audio = HasUnmutedAudio() || audio_source_provider_->IsAudioBeingCaptured();
|
||||
// Audio only stream is allowed to play when in background.
|
||||
@@ -51,7 +51,7 @@ diff --git a/third_party/blink/renderer/platform/media/web_media_player_impl.cc
|
||||
diff --git a/third_party/blink/renderer/platform/media/web_media_player_impl.h b/third_party/blink/renderer/platform/media/web_media_player_impl.h
|
||||
--- a/third_party/blink/renderer/platform/media/web_media_player_impl.h
|
||||
+++ b/third_party/blink/renderer/platform/media/web_media_player_impl.h
|
||||
@@ -211,6 +211,9 @@ class PLATFORM_EXPORT WebMediaPlayerImpl
|
||||
@@ -213,6 +213,9 @@ class PLATFORM_EXPORT WebMediaPlayerImpl
|
||||
bool HasVideo() const override;
|
||||
bool HasAudio() const override;
|
||||
|
||||
|
||||
@@ -18,7 +18,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextM
|
||||
import org.chromium.chrome.browser.DefaultBrowserInfo;
|
||||
import org.chromium.chrome.browser.IntentHandler;
|
||||
import org.chromium.chrome.browser.bookmarks.BookmarkManagerOpenerImpl;
|
||||
@@ -45,6 +46,7 @@ import org.chromium.chrome.browser.preferences.Pref;
|
||||
@@ -46,6 +47,7 @@ import org.chromium.chrome.browser.preferences.Pref;
|
||||
import org.chromium.chrome.browser.price_tracking.PriceDropNotificationManagerFactory;
|
||||
import org.chromium.chrome.browser.printing.TabPrinter;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
@@ -26,7 +26,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextM
|
||||
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
|
||||
import org.chromium.chrome.browser.tabmodel.document.ChromeAsyncTabLauncher;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
@@ -348,6 +350,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
@@ -351,6 +353,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
@Nullable Referrer referrer,
|
||||
boolean navigateToTab,
|
||||
@Nullable AdditionalNavigationParams additionalNavigationParams) {
|
||||
@@ -34,7 +34,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextM
|
||||
RecordUserAction.record("MobileNewTabOpened");
|
||||
RecordUserAction.record("LinkOpenedInNewTab");
|
||||
LoadUrlParams loadUrlParams = new LoadUrlParams(url.getSpec());
|
||||
@@ -368,6 +371,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
@@ -371,6 +374,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
* @param url The URL to open.
|
||||
*/
|
||||
public void onOpenInNewTabInGroup(GURL url, @Nullable Referrer referrer) {
|
||||
|
||||
@@ -68,7 +68,7 @@ diff --git a/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/b
|
||||
diff --git a/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java b/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
||||
--- a/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
||||
+++ b/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
||||
@@ -88,6 +88,7 @@ public class TemplateUrl {
|
||||
@@ -109,6 +109,7 @@ public class TemplateUrl {
|
||||
* prepopulated_engines.json.
|
||||
*/
|
||||
public String getNewTabURL() {
|
||||
@@ -79,9 +79,9 @@ diff --git a/components/search_engines/android/java/src/org/chromium/components/
|
||||
diff --git a/components/search_engines/android/template_url_service_android.cc b/components/search_engines/android/template_url_service_android.cc
|
||||
--- a/components/search_engines/android/template_url_service_android.cc
|
||||
+++ b/components/search_engines/android/template_url_service_android.cc
|
||||
@@ -404,6 +404,7 @@ jboolean TemplateUrlServiceAndroid::SetPlayAPISearchEngine(
|
||||
@@ -414,6 +414,7 @@ bool TemplateUrlServiceAndroid::SetPlayAPISearchEngine(
|
||||
jimage_translate_source_language_param_key,
|
||||
const base::android::JavaParamRef<jstring>&
|
||||
const base::android::JavaRef<jstring>&
|
||||
jimage_translate_target_language_param_key) {
|
||||
+ if ((true)) return false;
|
||||
// The function is scheduled to run only when the service is loaded, see
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -18,15 +18,15 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegate.java b/chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegate.java
|
||||
--- a/chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegate.java
|
||||
+++ b/chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegate.java
|
||||
@@ -41,6 +41,7 @@ public class BrowserStateBrowserControlsVisibilityDelegate extends BrowserContro
|
||||
private final ObservableSupplier<Boolean> mPersistentFullscreenMode;
|
||||
@@ -40,6 +40,7 @@ public class BrowserStateBrowserControlsVisibilityDelegate extends BrowserContro
|
||||
private final NonNullObservableSupplier<Boolean> mPersistentFullscreenMode;
|
||||
|
||||
private long mCurrentShowingStartTime;
|
||||
+ private int temporaryToken;
|
||||
|
||||
/**
|
||||
* Constructs a BrowserControlsVisibilityDelegate designed to deal with overrides driven by
|
||||
@@ -66,7 +67,8 @@ public class BrowserStateBrowserControlsVisibilityDelegate extends BrowserContro
|
||||
* Constructs a BrowserControlsVisibilityDelegate designed to deal with overrides driven by the
|
||||
@@ -65,7 +66,8 @@ public class BrowserStateBrowserControlsVisibilityDelegate extends BrowserContro
|
||||
long currentShowingTime = SystemClock.uptimeMillis() - mCurrentShowingStartTime;
|
||||
if (currentShowingTime >= MINIMUM_SHOW_DURATION_MS) return;
|
||||
|
||||
@@ -53,7 +53,7 @@ new file mode 100644
|
||||
diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
--- a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
+++ b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
@@ -84,6 +84,12 @@ found in the LICENSE file.
|
||||
@@ -89,6 +89,12 @@ found in the LICENSE file.
|
||||
android:key="disable_toolbar_swipeup"
|
||||
android:title="@string/disable_toolbar_swipe_up" />
|
||||
|
||||
|
||||
@@ -31,7 +31,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
content/child/BUILD.gn | 7 +
|
||||
content/renderer/BUILD.gn | 4 +
|
||||
.../renderer/renderer_blink_platform_impl.cc | 55 +-
|
||||
...renderer_main_platform_delegate_android.cc | 2 +-
|
||||
content/renderer/renderer_main.cc | 2 -
|
||||
...ndroid-fonts-fingerprinting-mitigation.inc | 12 +
|
||||
...ndroid-fonts-fingerprinting-mitigation.inc | 7 +
|
||||
...ndroid-fonts-fingerprinting-mitigation.inc | 5 +
|
||||
@@ -43,12 +43,12 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../skia/src/ports/SkFontConfigInterface.cpp | 5 +
|
||||
.../ports/SkFontConfigInterface_direct.cpp | 5 +
|
||||
.../src/ports/SkFontConfigInterface_direct.h | 1 +
|
||||
.../skia/src/ports/SkFontMgr_android.cpp | 282 ++-
|
||||
.../skia/src/ports/SkFontMgr_android.cpp | 286 ++-
|
||||
.../skia/src/ports/SkFontMgr_android_data.cpp | 1641 +++++++++++++++++
|
||||
.../skia/src/ports/SkFontMgr_android_ndk.cpp | 2 +-
|
||||
.../src/ports/SkFontMgr_android_parser.cpp | 66 +-
|
||||
.../skia/src/ports/SkFontMgr_android_parser.h | 5 +-
|
||||
42 files changed, 2448 insertions(+), 85 deletions(-)
|
||||
42 files changed, 2449 insertions(+), 88 deletions(-)
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Android-fonts-fingerprinting-mitigation.grdp
|
||||
create mode 100644 components/component_updater/installer_policies/fonts_pack_component_installer.cc
|
||||
create mode 100644 components/component_updater/installer_policies/fonts_pack_component_installer.h
|
||||
@@ -60,7 +60,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java b/android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
|
||||
--- a/android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
|
||||
+++ b/android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
|
||||
@@ -933,6 +933,9 @@ public final class ProductionSupportedFlagList {
|
||||
@@ -996,6 +996,9 @@ public final class ProductionSupportedFlagList {
|
||||
"Hides user preference on the system keyboard by setting the standard "
|
||||
+ "eng layout and removing the layout information from the "
|
||||
+ "javascript keyboard events."),
|
||||
@@ -99,12 +99,12 @@ diff --git a/android_webview/nonembedded/component_updater/registration.cc b/and
|
||||
diff --git a/build/config/freetype/freetype.gni b/build/config/freetype/freetype.gni
|
||||
--- a/build/config/freetype/freetype.gni
|
||||
+++ b/build/config/freetype/freetype.gni
|
||||
@@ -26,5 +26,5 @@ declare_args() {
|
||||
# https://crbug.com/370816215
|
||||
#
|
||||
# Note: //build should not import directly from //pdf for layering reasons.
|
||||
- enable_freetype = !is_android && !is_ios && (is_linux || !is_castos)
|
||||
+ enable_freetype = is_android || (!is_ios && (is_linux || !is_castos))
|
||||
@@ -24,5 +24,5 @@ declare_args() {
|
||||
# This should be kept in sync with the value of `enable_pdf` in
|
||||
# //pdf/features.gni, but for layering reasons,
|
||||
# we can't import pdf's features.gni here.
|
||||
- enable_freetype = !is_android && !is_ios && !is_castos && !is_fuchsia
|
||||
+ enable_freetype = is_android || (!is_ios && !is_castos && !is_fuchsia)
|
||||
}
|
||||
diff --git a/chrome/android/java/res/xml/developer_preferences.xml b/chrome/android/java/res/xml/developer_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/developer_preferences.xml
|
||||
@@ -122,7 +122,7 @@ diff --git a/chrome/android/java/res/xml/developer_preferences.xml b/chrome/andr
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -8012,6 +8012,13 @@ static_library("browser") {
|
||||
@@ -7866,6 +7866,13 @@ static_library("browser") {
|
||||
]
|
||||
}
|
||||
|
||||
@@ -139,7 +139,7 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
diff --git a/chrome/browser/component_updater/registration.cc b/chrome/browser/component_updater/registration.cc
|
||||
--- a/chrome/browser/component_updater/registration.cc
|
||||
+++ b/chrome/browser/component_updater/registration.cc
|
||||
@@ -115,10 +115,20 @@
|
||||
@@ -100,6 +100,11 @@
|
||||
#include "chrome/browser/component_updater/file_type_policies_component_installer.h"
|
||||
#endif
|
||||
|
||||
@@ -150,6 +150,9 @@ diff --git a/chrome/browser/component_updater/registration.cc b/chrome/browser/c
|
||||
+
|
||||
namespace component_updater {
|
||||
|
||||
namespace {
|
||||
@@ -133,6 +138,11 @@ void DeleteOldComponents(const base::FilePath& user_data_dir) {
|
||||
|
||||
void RegisterComponentsForUpdate() {
|
||||
auto* const cus = g_browser_process->component_updater();
|
||||
+#if BUILDFLAG(IS_ANDROID)
|
||||
@@ -187,7 +190,7 @@ diff --git a/chrome/browser/ui/prefs/prefs_tab_helper.cc b/chrome/browser/ui/pre
|
||||
// If a font name in prefs default values starts with a comma, consider it's a
|
||||
// comma-separated font list and resolve it to the first available font.
|
||||
#define PREFS_FONT_LIST 1
|
||||
@@ -442,9 +441,9 @@ void PrefsTabHelper::RegisterProfilePrefs(
|
||||
@@ -447,9 +446,9 @@ void PrefsTabHelper::RegisterProfilePrefs(
|
||||
value = gfx::FontList::FirstAvailableOrFirst(value);
|
||||
}
|
||||
#else // !PREFS_FONT_LIST
|
||||
@@ -203,7 +206,7 @@ diff --git a/chrome/browser/ui/prefs/prefs_tab_helper.cc b/chrome/browser/ui/pre
|
||||
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
|
||||
--- a/chrome/renderer/BUILD.gn
|
||||
+++ b/chrome/renderer/BUILD.gn
|
||||
@@ -266,6 +266,10 @@ static_library("renderer") {
|
||||
@@ -270,6 +270,10 @@ static_library("renderer") {
|
||||
deps += [ "//components/strings" ]
|
||||
}
|
||||
|
||||
@@ -217,7 +220,7 @@ diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
|
||||
diff --git a/components/component_updater/installer_policies/BUILD.gn b/components/component_updater/installer_policies/BUILD.gn
|
||||
--- a/components/component_updater/installer_policies/BUILD.gn
|
||||
+++ b/components/component_updater/installer_policies/BUILD.gn
|
||||
@@ -32,6 +32,13 @@ static_library("installer_policies_no_content_deps") {
|
||||
@@ -28,6 +28,13 @@ static_library("installer_policies_no_content_deps") {
|
||||
"trust_token_key_commitments_component_installer_policy.h",
|
||||
]
|
||||
|
||||
@@ -282,7 +285,7 @@ new file mode 100644
|
||||
+
|
||||
+update_client::CrxInstaller::Result
|
||||
+FontsPackComponentInstallerPolicy::OnCustomInstall(
|
||||
+ const base::Value::Dict& manifest,
|
||||
+ const base::DictValue& manifest,
|
||||
+ const base::FilePath& install_dir) {
|
||||
+ return update_client::CrxInstaller::Result(0); // Nothing custom here.
|
||||
+}
|
||||
@@ -292,14 +295,14 @@ new file mode 100644
|
||||
+void FontsPackComponentInstallerPolicy::ComponentReady(
|
||||
+ const base::Version& version,
|
||||
+ const base::FilePath& install_dir,
|
||||
+ base::Value::Dict manifest) {
|
||||
+ base::DictValue manifest) {
|
||||
+ DCHECK(!install_dir.empty());
|
||||
+ LOG(INFO) << "Fonts Pack Version Ready: " << install_dir.value();
|
||||
+}
|
||||
+
|
||||
+// Called during startup and installation before ComponentReady().
|
||||
+bool FontsPackComponentInstallerPolicy::VerifyInstallation(
|
||||
+ const base::Value::Dict& manifest,
|
||||
+ const base::DictValue& manifest,
|
||||
+ const base::FilePath& install_dir) const {
|
||||
+ return base::PathExists(install_dir);
|
||||
+}
|
||||
@@ -378,14 +381,14 @@ new file mode 100644
|
||||
+ bool SupportsGroupPolicyEnabledComponentUpdates() const override;
|
||||
+ bool RequiresNetworkEncryption() const override;
|
||||
+ update_client::CrxInstaller::Result OnCustomInstall(
|
||||
+ const base::Value::Dict& manifest,
|
||||
+ const base::DictValue& manifest,
|
||||
+ const base::FilePath& install_dir) override;
|
||||
+ void OnCustomUninstall() override;
|
||||
+ bool VerifyInstallation(const base::Value::Dict& manifest,
|
||||
+ bool VerifyInstallation(const base::DictValue& manifest,
|
||||
+ const base::FilePath& install_dir) const override;
|
||||
+ void ComponentReady(const base::Version& version,
|
||||
+ const base::FilePath& install_dir,
|
||||
+ base::Value::Dict manifest) override;
|
||||
+ base::DictValue manifest) override;
|
||||
+ base::FilePath GetRelativeInstallDir() const override;
|
||||
+ void GetHash(std::vector<uint8_t>* hash) const override;
|
||||
+ std::string GetName() const override;
|
||||
@@ -667,7 +670,7 @@ diff --git a/components/services/font/public/mojom/font_service.mojom b/componen
|
||||
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
|
||||
--- a/content/browser/BUILD.gn
|
||||
+++ b/content/browser/BUILD.gn
|
||||
@@ -2608,6 +2608,17 @@ source_set("browser") {
|
||||
@@ -2637,6 +2637,17 @@ source_set("browser") {
|
||||
]
|
||||
}
|
||||
|
||||
@@ -685,7 +688,7 @@ diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
|
||||
if (is_linux || is_chromeos) {
|
||||
sources -=
|
||||
[ "file_system_access/file_path_watcher/file_path_watcher_stub.cc" ]
|
||||
@@ -2654,6 +2665,13 @@ source_set("browser") {
|
||||
@@ -2683,6 +2694,13 @@ source_set("browser") {
|
||||
deps += [ "//components/services/font_data:lib" ]
|
||||
}
|
||||
|
||||
@@ -702,9 +705,9 @@ diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
|
||||
diff --git a/content/browser/renderer_host/render_process_host_impl_receiver_bindings.cc b/content/browser/renderer_host/render_process_host_impl_receiver_bindings.cc
|
||||
--- a/content/browser/renderer_host/render_process_host_impl_receiver_bindings.cc
|
||||
+++ b/content/browser/renderer_host/render_process_host_impl_receiver_bindings.cc
|
||||
@@ -52,6 +52,11 @@
|
||||
#include "third_party/blink/public/mojom/android_font_lookup/android_font_lookup.mojom.h"
|
||||
#endif
|
||||
@@ -56,6 +56,11 @@
|
||||
#include "content/browser/renderer_host/p2p/socket_dispatcher_host.h"
|
||||
#endif // BUILDFLAG(IS_P2P_ENABLED)
|
||||
|
||||
+#if BUILDFLAG(IS_ANDROID)
|
||||
+#include "components/services/font/public/mojom/font_service.mojom.h" // nogncheck
|
||||
@@ -714,7 +717,7 @@ diff --git a/content/browser/renderer_host/render_process_host_impl_receiver_bin
|
||||
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||
#include "components/services/font/public/mojom/font_service.mojom.h" // nogncheck
|
||||
#include "content/browser/font_service.h" // nogncheck
|
||||
@@ -351,6 +356,13 @@ void RenderProcessHostImpl::IOThreadHostImpl::BindHostReceiver(
|
||||
@@ -356,6 +361,13 @@ void RenderProcessHostImpl::IOThreadHostImpl::BindHostReceiver(
|
||||
}
|
||||
#endif
|
||||
|
||||
@@ -731,7 +734,7 @@ diff --git a/content/browser/renderer_host/render_process_host_impl_receiver_bin
|
||||
diff --git a/content/child/BUILD.gn b/content/child/BUILD.gn
|
||||
--- a/content/child/BUILD.gn
|
||||
+++ b/content/child/BUILD.gn
|
||||
@@ -135,6 +135,13 @@ target(link_target_type, "child") {
|
||||
@@ -137,6 +137,13 @@ target(link_target_type, "child") {
|
||||
]
|
||||
}
|
||||
|
||||
@@ -748,7 +751,7 @@ diff --git a/content/child/BUILD.gn b/content/child/BUILD.gn
|
||||
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn
|
||||
--- a/content/renderer/BUILD.gn
|
||||
+++ b/content/renderer/BUILD.gn
|
||||
@@ -350,6 +350,10 @@ target(link_target_type, "renderer") {
|
||||
@@ -351,6 +351,10 @@ target(link_target_type, "renderer") {
|
||||
deps += [ "//services/screen_ai/public/mojom" ]
|
||||
}
|
||||
|
||||
@@ -847,19 +850,19 @@ diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer
|
||||
+#endif
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_LINUX)
|
||||
diff --git a/content/renderer/renderer_main_platform_delegate_android.cc b/content/renderer/renderer_main_platform_delegate_android.cc
|
||||
--- a/content/renderer/renderer_main_platform_delegate_android.cc
|
||||
+++ b/content/renderer/renderer_main_platform_delegate_android.cc
|
||||
@@ -35,7 +35,7 @@ void RendererMainPlatformDelegate::PlatformInitialize() {
|
||||
// Android 14+ user devices with updated system fonts will call statx and
|
||||
// possibly other system calls that are not allowed in the sandbox.
|
||||
// See https://crbug.com/40618213 for details.
|
||||
- [[maybe_unused]] auto mgr = skia::DefaultFontMgr();
|
||||
+ // [[maybe_unused]] auto mgr = skia::DefaultFontMgr();
|
||||
}
|
||||
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||
diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc
|
||||
--- a/content/renderer/renderer_main.cc
|
||||
+++ b/content/renderer/renderer_main.cc
|
||||
@@ -184,8 +184,6 @@ int RendererMain(MainFunctionParams parameters) {
|
||||
// On Linux, Windows, and ChromeOS, the font manager is overridden or
|
||||
// specially handled in RendererBlinkPlatformImpl(). On other platforms,
|
||||
// initialise the default one on a thread pool, to avoid blocking on it later.
|
||||
- base::ThreadPool::PostTask(FROM_HERE,
|
||||
- base::BindOnce([] { skia::DefaultFontMgr(); }));
|
||||
#endif
|
||||
|
||||
void RendererMainPlatformDelegate::PlatformUninitialize() {
|
||||
// This function allows pausing execution using the --renderer-startup-dialog
|
||||
diff --git a/cromite_flags/chrome/browser/about_flags_cc/Android-fonts-fingerprinting-mitigation.inc b/cromite_flags/chrome/browser/about_flags_cc/Android-fonts-fingerprinting-mitigation.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
@@ -902,7 +905,7 @@ new file mode 100644
|
||||
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
|
||||
--- a/skia/BUILD.gn
|
||||
+++ b/skia/BUILD.gn
|
||||
@@ -449,6 +449,18 @@ component("skia") {
|
||||
@@ -444,6 +444,18 @@ component("skia") {
|
||||
sources += skia_ports_fci_sources
|
||||
}
|
||||
|
||||
@@ -924,7 +927,7 @@ diff --git a/skia/BUILD.gn b/skia/BUILD.gn
|
||||
diff --git a/skia/ext/font_utils.cc b/skia/ext/font_utils.cc
|
||||
--- a/skia/ext/font_utils.cc
|
||||
+++ b/skia/ext/font_utils.cc
|
||||
@@ -59,6 +59,7 @@ SkFontMgr* g_fontmgr_override = nullptr;
|
||||
@@ -60,6 +60,7 @@ SkFontMgr* g_fontmgr_override = nullptr;
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
// https://crbug.com/461659286 Failure to create any font causes crash.
|
||||
BASE_FEATURE(kUseAndroidNDKFontAPI, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -1371,28 +1374,26 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
}
|
||||
this->buildNameToFamilyMap(families, custom ? custom->fIsolated : false);
|
||||
this->findDefaultStyleSet();
|
||||
@@ -309,12 +452,12 @@ protected:
|
||||
@@ -309,33 +452,53 @@ protected:
|
||||
}
|
||||
|
||||
enum class NameType { Self, Fallback };
|
||||
using Matcher = bool (*)(const SkString& familyName, const NameToFamily&);
|
||||
- static sk_sp<SkTypeface_AndroidSystem> find_family_style_character(
|
||||
+ sk_sp<SkTypeface> find_family_style_character(
|
||||
const SkString& familyName,
|
||||
const TArray<NameToFamily, true>& nameToFamilyMap,
|
||||
NameType nameType,
|
||||
const SkFontStyle& style, bool elegant,
|
||||
- const SkString& langTag, SkUnichar character)
|
||||
+ const SkString& langTag, SkUnichar character) const
|
||||
const SkString& langTag, SkUnichar character,
|
||||
- Matcher matcher)
|
||||
+ Matcher matcher) const
|
||||
{
|
||||
for (auto&& nameToFamily : nameToFamilyMap) {
|
||||
SkFontStyleSet_Android* family = nameToFamily.styleSet;
|
||||
@@ -325,22 +468,42 @@ protected:
|
||||
continue;
|
||||
}
|
||||
if (!matcher(familyName, nameToFamily)) {
|
||||
continue;
|
||||
}
|
||||
- sk_sp<SkTypeface_AndroidSystem> face(family->matchAStyle(style));
|
||||
- sk_sp<SkTypeface_AndroidSystem> face(nameToFamily.styleSet->matchAStyle(style));
|
||||
+ if (custom_) {
|
||||
+ sk_sp<SkTypeface_AndroidSystemCustom> face(family->matchCromiteStyle(style));
|
||||
+ sk_sp<SkTypeface_AndroidSystemCustom> face(nameToFamily.styleSet->matchCromiteStyle(style));
|
||||
+
|
||||
+ if (!langTag.isEmpty() &&
|
||||
+ std::none_of(face->fLang.begin(), face->fLang.end(), [&](const SkLanguage& lang){
|
||||
@@ -1420,7 +1421,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
+ return face;
|
||||
+ }
|
||||
+ } else {
|
||||
+ sk_sp<SkTypeface_AndroidSystem> face(family->matchAndroidStyle(style));
|
||||
+ sk_sp<SkTypeface_AndroidSystem> face(nameToFamily.styleSet->matchAndroidStyle(style));
|
||||
+
|
||||
+ if (!langTag.isEmpty() &&
|
||||
+ std::none_of(face->fLang.begin(), face->fLang.end(), [&](const SkLanguage& lang){
|
||||
@@ -1429,29 +1430,41 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
+ {
|
||||
+ continue;
|
||||
+ }
|
||||
|
||||
- if (face->unicharToGlyph(character) != 0) {
|
||||
- return face;
|
||||
+
|
||||
+ if (SkToBool(face->fVariantStyle & kElegant_FontVariant) != elegant) {
|
||||
+ continue;
|
||||
+ }
|
||||
+
|
||||
|
||||
- if (face->unicharToGlyph(character) != 0) {
|
||||
- return face;
|
||||
+ if (face->unicharToGlyph(character) != 0) {
|
||||
+ return face;
|
||||
+ }
|
||||
}
|
||||
}
|
||||
return nullptr;
|
||||
@@ -355,7 +518,7 @@ protected:
|
||||
// The variant 'default' means 'compact and elegant'.
|
||||
// As a result, it is not possible to know the variant context from the font alone.
|
||||
// TODO: add 'is_elegant' and 'is_compact' bits to 'style' request.
|
||||
@@ -360,9 +523,9 @@ protected:
|
||||
|
||||
auto find = [this, &style, &character](const SkString& familyName,
|
||||
const SkString& lang,
|
||||
- bool elegant) -> sk_sp<SkTypeface_AndroidSystem>
|
||||
+ bool elegant) -> sk_sp<SkTypeface>
|
||||
{
|
||||
- sk_sp<SkTypeface_AndroidSystem> matchingTypeface;
|
||||
+ sk_sp<SkTypeface> matchingTypeface;
|
||||
if (!familyName.isEmpty()) {
|
||||
matchingTypeface = find_family_style_character(
|
||||
familyName, fNameToFamilyMap, style, elegant, lang, character,
|
||||
@@ -410,7 +573,7 @@ protected:
|
||||
};
|
||||
|
||||
|
||||
- sk_sp<SkTypeface_AndroidSystem> matchingTypeface;
|
||||
+ sk_sp<SkTypeface> matchingTypeface;
|
||||
SkString familyNameString(familyName);
|
||||
for (const SkString& currentFamilyName : { familyNameString, SkString() }) {
|
||||
// The first time match anything elegant, second time anything not elegant.
|
||||
@@ -435,6 +598,7 @@ protected:
|
||||
// If familyName is empty, don't look through everything twice.
|
||||
SkString familyNames[2] = { SkString(familyName), SkString() };
|
||||
size_t familyNamesCount = familyNames[0].isEmpty() ? 1 : 2;
|
||||
@@ -475,6 +638,7 @@ protected:
|
||||
private:
|
||||
|
||||
std::unique_ptr<SkFontScanner> fScanner;
|
||||
@@ -1459,7 +1472,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
|
||||
TArray<sk_sp<SkFontStyleSet_Android>> fStyleSets;
|
||||
sk_sp<SkFontStyleSet> fDefaultStyleSet;
|
||||
@@ -456,7 +620,7 @@ private:
|
||||
@@ -496,7 +660,7 @@ private:
|
||||
}
|
||||
|
||||
sk_sp<SkFontStyleSet_Android> newSet =
|
||||
@@ -1468,7 +1481,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
if (0 == newSet->count()) {
|
||||
return;
|
||||
}
|
||||
@@ -502,7 +666,11 @@ static char const * const gSystemFontUseStrings[] = {
|
||||
@@ -542,7 +706,11 @@ static char const * const gSystemFontUseStrings[] = {
|
||||
|
||||
} // namespace
|
||||
|
||||
@@ -1481,7 +1494,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android.cpp b/third_party/skia
|
||||
std::unique_ptr<SkFontScanner> scanner) {
|
||||
if (custom) {
|
||||
SkASSERT(0 <= custom->fSystemFontUse);
|
||||
@@ -515,5 +683,5 @@ sk_sp<SkFontMgr> SkFontMgr_New_Android(const SkFontMgr_Android_CustomFonts* cust
|
||||
@@ -555,5 +723,5 @@ sk_sp<SkFontMgr> SkFontMgr_New_Android(const SkFontMgr_Android_CustomFonts* cust
|
||||
custom->fFallbackFontsXml);
|
||||
}
|
||||
}
|
||||
@@ -3149,7 +3162,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_ndk.cpp b/third_party/
|
||||
diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_party/skia/src/ports/SkFontMgr_android_parser.cpp
|
||||
--- a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp
|
||||
+++ b/third_party/skia/src/ports/SkFontMgr_android_parser.cpp
|
||||
@@ -654,14 +654,27 @@ static const XML_Memory_Handling_Suite sk_XML_alloc = {
|
||||
@@ -650,14 +650,27 @@ static const XML_Memory_Handling_Suite sk_XML_alloc = {
|
||||
*/
|
||||
static int parse_config_file(const char* filename,
|
||||
std::vector<std::unique_ptr<FontFamily>>& families,
|
||||
@@ -3183,7 +3196,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
return -1;
|
||||
}
|
||||
|
||||
@@ -693,8 +706,8 @@ static int parse_config_file(const char* filename,
|
||||
@@ -689,8 +702,8 @@ static int parse_config_file(const char* filename,
|
||||
SkDebugf(SK_FONTMGR_ANDROID_PARSER_PREFIX "could not buffer enough to continue\n");
|
||||
return -1;
|
||||
}
|
||||
@@ -3194,7 +3207,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
XML_Status status = XML_ParseBuffer(parser, len, done);
|
||||
if (XML_STATUS_ERROR == status) {
|
||||
XML_Error error = XML_GetErrorCode(parser);
|
||||
@@ -706,6 +719,23 @@ static int parse_config_file(const char* filename,
|
||||
@@ -702,6 +715,23 @@ static int parse_config_file(const char* filename,
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
@@ -3218,7 +3231,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
return self.fVersion;
|
||||
}
|
||||
|
||||
@@ -768,8 +798,10 @@ static void append_fallback_font_families_for_locale(
|
||||
@@ -764,8 +794,10 @@ static void append_fallback_font_families_for_locale(
|
||||
|
||||
static void append_system_fallback_font_families(
|
||||
std::vector<std::unique_ptr<FontFamily>>& fallbackFonts,
|
||||
@@ -3230,7 +3243,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
parse_config_file(FALLBACK_FONTS_FILE, fallbackFonts, basePath, true);
|
||||
append_fallback_font_families_for_locale(fallbackFonts,
|
||||
LOCALE_FALLBACK_FONTS_SYSTEM_DIR,
|
||||
@@ -778,8 +810,10 @@ static void append_system_fallback_font_families(
|
||||
@@ -774,8 +806,10 @@ static void append_system_fallback_font_families(
|
||||
|
||||
static void mixin_vendor_fallback_font_families(
|
||||
std::vector<std::unique_ptr<FontFamily>>& fallbackFonts,
|
||||
@@ -3242,17 +3255,17 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
std::vector<std::unique_ptr<FontFamily>> vendorFonts;
|
||||
parse_config_file(VENDOR_FONTS_FILE, vendorFonts, basePath, true);
|
||||
append_fallback_font_families_for_locale(vendorFonts,
|
||||
@@ -811,7 +845,8 @@ static void mixin_vendor_fallback_font_families(
|
||||
@@ -807,7 +841,8 @@ static void mixin_vendor_fallback_font_families(
|
||||
}
|
||||
|
||||
void SkFontMgr_Android_Parser::GetSystemFontFamilies(
|
||||
- std::vector<std::unique_ptr<FontFamily>>& fontFamilies)
|
||||
- std::vector<std::unique_ptr<FontFamily>>& fontFamilies) {
|
||||
+ std::vector<std::unique_ptr<FontFamily>>& fontFamilies,
|
||||
+ const SkFontMgr_Android_CustomFonts* custom)
|
||||
{
|
||||
+ const SkFontMgr_Android_CustomFonts* custom) {
|
||||
static constexpr char kFontFilePrefix[] = "/fonts/";
|
||||
|
||||
// Version 21 of the system font configuration does not need any fallback configuration files.
|
||||
SkString basePath(getenv("ANDROID_ROOT"));
|
||||
@@ -823,8 +858,8 @@ void SkFontMgr_Android_Parser::GetSystemFontFamilies(
|
||||
@@ -820,8 +855,8 @@ void SkFontMgr_Android_Parser::GetSystemFontFamilies(
|
||||
|
||||
// Append all the fallback fonts to system fonts
|
||||
std::vector<std::unique_ptr<FontFamily>> fallbackFonts;
|
||||
@@ -3263,7 +3276,7 @@ diff --git a/third_party/skia/src/ports/SkFontMgr_android_parser.cpp b/third_par
|
||||
fontFamilies.insert(fontFamilies.end(),
|
||||
std::make_move_iterator(fallbackFonts.begin()),
|
||||
std::make_move_iterator(fallbackFonts.end()));
|
||||
@@ -833,15 +868,16 @@ void SkFontMgr_Android_Parser::GetSystemFontFamilies(
|
||||
@@ -830,15 +865,16 @@ void SkFontMgr_Android_Parser::GetSystemFontFamilies(
|
||||
void SkFontMgr_Android_Parser::GetCustomFontFamilies(
|
||||
std::vector<std::unique_ptr<FontFamily>>& fontFamilies,
|
||||
const SkString& basePath,
|
||||
|
||||
@@ -23,7 +23,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../java/res/xml/homepage_preferences.xml | 6 +
|
||||
.../ConnectivityDetector.java | 1 -
|
||||
.../indicator/OfflineDetector.java | 111 +++++++++++++++++-
|
||||
.../OfflineIndicatorControllerV2.java | 15 ++-
|
||||
.../OfflineIndicatorControllerV2.java | 14 ++-
|
||||
.../tabbed_mode/TabbedRootUiCoordinator.java | 5 +-
|
||||
.../tabmodel/TabModelSelectorBase.java | 7 ++
|
||||
.../sAskForRestartOnConnectionChange.java | 32 +++++
|
||||
@@ -33,10 +33,9 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../tabwindow/TabWindowManagerImpl.java | 10 ++
|
||||
.../Ask-for-restart-on-connection-change.grdp | 15 +++
|
||||
.../java/res/layout/floating_snackbar.xml | 10 ++
|
||||
.../android/java/res/layout/snackbar.xml | 10 ++
|
||||
.../ui/messages/snackbar/Snackbar.java | 16 +++
|
||||
.../ui/messages/snackbar/SnackbarManager.java | 6 +
|
||||
.../ui/messages/snackbar/SnackbarView.java | 13 +-
|
||||
.../ui/messages/snackbar/SnackbarView.java | 10 ++
|
||||
.../web_contents/web_contents_android.cc | 16 +++
|
||||
.../web_contents/web_contents_android.h | 1 +
|
||||
.../browser/web_contents/web_contents_impl.cc | 2 +
|
||||
@@ -50,7 +49,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../blink/renderer/core/frame/local_frame.cc | 2 +
|
||||
.../main_thread/frame_scheduler_impl.cc | 2 +
|
||||
.../main_thread/page_scheduler_impl.cc | 9 +-
|
||||
30 files changed, 332 insertions(+), 10 deletions(-)
|
||||
29 files changed, 319 insertions(+), 9 deletions(-)
|
||||
create mode 100644 chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/cromite/sAskForRestartOnConnectionChange.java
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Ask-for-restart-on-connection-change.grdp
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Ask-for-restart-on-connection-change.inc
|
||||
@@ -96,7 +95,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
import org.chromium.components.variations.VariationsAssociatedData;
|
||||
|
||||
+import android.app.Activity;
|
||||
+import org.chromium.base.supplier.ObservableSupplier;
|
||||
+import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
+import org.chromium.url.GURL;
|
||||
+import org.chromium.chrome.R;
|
||||
+import org.chromium.chrome.browser.app.tabwindow.TabWindowManagerSingleton;
|
||||
@@ -136,8 +135,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
private static final String TAG = "OfflineDetector";
|
||||
|
||||
+ private long mLastNetworkId = 0;
|
||||
+ private ObservableSupplier<TabModelSelector> mTabModelSelectorSupplier;
|
||||
+ private ObservableSupplier<LayoutManager> mLayoutManager;
|
||||
+ private MonotonicObservableSupplier<TabModelSelector> mTabModelSelectorSupplier;
|
||||
+ private MonotonicObservableSupplier<LayoutManager> mLayoutManager;
|
||||
+ private Supplier<SnackbarManager> mSnackbarManagerSupplier;
|
||||
+
|
||||
/**
|
||||
@@ -149,8 +148,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
Callback<Boolean> isForegroundCallback,
|
||||
- Context context) {
|
||||
+ Context context,
|
||||
+ ObservableSupplier<TabModelSelector> tabModelSelectorSupplier,
|
||||
+ ObservableSupplier<LayoutManager> layoutManager,
|
||||
+ MonotonicObservableSupplier<TabModelSelector> tabModelSelectorSupplier,
|
||||
+ MonotonicObservableSupplier<LayoutManager> layoutManager,
|
||||
+ Supplier<SnackbarManager> snackbarManagerSupplier) {
|
||||
+ mTabModelSelectorSupplier = tabModelSelectorSupplier;
|
||||
+ mSnackbarManagerSupplier = snackbarManagerSupplier;
|
||||
@@ -245,11 +244,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java
|
||||
@@ -31,6 +31,11 @@ import java.lang.annotation.Retention;
|
||||
@@ -32,6 +32,10 @@ import java.lang.annotation.Retention;
|
||||
import java.lang.annotation.RetentionPolicy;
|
||||
import java.util.function.Supplier;
|
||||
|
||||
+import org.chromium.base.supplier.ObservableSupplierImpl;
|
||||
+import org.chromium.chrome.browser.layouts.LayoutManager;
|
||||
+import org.chromium.chrome.browser.tabmodel.TabModelSelector;
|
||||
+import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
@@ -257,19 +255,19 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
/**
|
||||
* Class that controls visibility and content of {@link StatusIndicatorCoordinator} to relay
|
||||
* connectivity information.
|
||||
@@ -104,7 +109,10 @@ public class OfflineIndicatorControllerV2 {
|
||||
@@ -105,7 +109,10 @@ public class OfflineIndicatorControllerV2 {
|
||||
Context context,
|
||||
StatusIndicatorCoordinator statusIndicator,
|
||||
ObservableSupplier<Boolean> isUrlBarFocusedSupplier,
|
||||
NonNullObservableSupplier<Boolean> isUrlBarFocusedSupplier,
|
||||
- Supplier<Boolean> canAnimateNativeBrowserControls) {
|
||||
+ Supplier<Boolean> canAnimateNativeBrowserControls,
|
||||
+ ObservableSupplier<TabModelSelector> tabModelSelectorSupplier,
|
||||
+ ObservableSupplierImpl<LayoutManager> layoutManager,
|
||||
+ MonotonicObservableSupplier<TabModelSelector> tabModelSelectorSupplier,
|
||||
+ MonotonicObservableSupplier<LayoutManager> layoutManager,
|
||||
+ Supplier<SnackbarManager> snackbarManagerSupplier) {
|
||||
// If "force online connection state" switch is set, the offline indicator should never
|
||||
// show.
|
||||
assert !CommandLine.getInstance()
|
||||
@@ -130,7 +138,10 @@ public class OfflineIndicatorControllerV2 {
|
||||
@@ -131,7 +138,10 @@ public class OfflineIndicatorControllerV2 {
|
||||
new OfflineDetector(
|
||||
(Boolean offline) -> onConnectionStateChanged(offline),
|
||||
(Boolean isForeground) -> onApplicationStateChanged(isForeground),
|
||||
@@ -284,7 +282,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/in
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
@@ -1525,7 +1525,10 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
@@ -1628,7 +1628,10 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
mActivity,
|
||||
mStatusIndicatorCoordinator,
|
||||
isUrlBarFocusedSupplier,
|
||||
@@ -299,7 +297,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
|
||||
@@ -200,6 +200,13 @@ public abstract class TabModelSelectorBase
|
||||
@@ -207,6 +207,13 @@ public abstract class TabModelSelectorBase
|
||||
return null;
|
||||
}
|
||||
|
||||
@@ -353,7 +351,7 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java b/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java
|
||||
--- a/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java
|
||||
+++ b/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java
|
||||
@@ -150,6 +150,8 @@ public interface TabModelSelector {
|
||||
@@ -146,6 +146,8 @@ public interface TabModelSelector {
|
||||
/** Get total pinned tab count across all tab models */
|
||||
int getTotalPinnedTabCount();
|
||||
|
||||
@@ -407,7 +405,7 @@ diff --git a/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browse
|
||||
diff --git a/chrome/browser/tabwindow/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManager.java b/chrome/browser/tabwindow/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManager.java
|
||||
--- a/chrome/browser/tabwindow/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManager.java
|
||||
+++ b/chrome/browser/tabwindow/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManager.java
|
||||
@@ -138,6 +138,8 @@ public interface TabWindowManager {
|
||||
@@ -148,6 +148,8 @@ public interface TabWindowManager {
|
||||
/** Returns the total number of incognito tabs across all tab model selectors. */
|
||||
int getIncognitoTabCount();
|
||||
|
||||
@@ -419,14 +417,14 @@ diff --git a/chrome/browser/tabwindow/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/tabwindow/internal/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManagerImpl.java b/chrome/browser/tabwindow/internal/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManagerImpl.java
|
||||
--- a/chrome/browser/tabwindow/internal/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManagerImpl.java
|
||||
+++ b/chrome/browser/tabwindow/internal/android/java/src/org/chromium/chrome/browser/tabwindow/TabWindowManagerImpl.java
|
||||
@@ -568,6 +568,16 @@ public class TabWindowManagerImpl implements TabWindowManager {
|
||||
@@ -534,6 +534,16 @@ public class TabWindowManagerImpl implements TabWindowManager {
|
||||
return tabGroupModelFilter.getTabsInGroup(tabGroupId);
|
||||
}
|
||||
|
||||
+ @Override
|
||||
+ public void setPagesFrozen(boolean frozen) {
|
||||
+ for (int i : mWindowIdToSelectors.keySet()) {
|
||||
+ TabModelSelector selector = mWindowIdToSelectors.get(i);
|
||||
+ for (Map.Entry<@WindowId Integer, TabModelSelector> entry : mWindowIdToSelectors.entrySet()) {
|
||||
+ TabModelSelector selector = entry.getValue();
|
||||
+ if (selector != null) {
|
||||
+ selector.setPagesFrozen(frozen);
|
||||
+ }
|
||||
@@ -475,38 +473,19 @@ diff --git a/chrome/browser/ui/messages/android/java/res/layout/floating_snackba
|
||||
+ style="@style/TextButton" />
|
||||
</LinearLayout>
|
||||
|
||||
diff --git a/chrome/browser/ui/messages/android/java/res/layout/snackbar.xml b/chrome/browser/ui/messages/android/java/res/layout/snackbar.xml
|
||||
--- a/chrome/browser/ui/messages/android/java/res/layout/snackbar.xml
|
||||
+++ b/chrome/browser/ui/messages/android/java/res/layout/snackbar.xml
|
||||
@@ -82,5 +82,15 @@ found in the LICENSE file.
|
||||
android:paddingEnd="@dimen/snackbar_button_padding"
|
||||
android:paddingStart="@dimen/snackbar_button_padding"
|
||||
style="@style/TextButton" />
|
||||
+
|
||||
+ <org.chromium.ui.widget.ButtonCompat
|
||||
+ android:id="@+id/snackbar_dismiss"
|
||||
+ android:layout_width="wrap_content"
|
||||
+ android:layout_height="wrap_content"
|
||||
+ android:layout_gravity="center_vertical"
|
||||
+ android:paddingEnd="24dp"
|
||||
+ android:paddingStart="24dp"
|
||||
+ android:visibility="gone"
|
||||
+ style="@style/TextButton" />
|
||||
</LinearLayout>
|
||||
</RelativeLayout>
|
||||
diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/Snackbar.java b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/Snackbar.java
|
||||
--- a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/Snackbar.java
|
||||
+++ b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/Snackbar.java
|
||||
@@ -140,6 +140,8 @@ public class Snackbar {
|
||||
@@ -145,6 +145,8 @@ public class Snackbar {
|
||||
private @Nullable String mTemplateText;
|
||||
private @Nullable String mActionText;
|
||||
private @Nullable Object mActionData;
|
||||
+ private String mDismissActionText;
|
||||
+ private Object mDismissActionData;
|
||||
private int mBackgroundColor;
|
||||
private int mTextApperanceResId;
|
||||
private int mTextAppearanceResId;
|
||||
private boolean mDefaultLines = true;
|
||||
@@ -246,6 +248,20 @@ public class Snackbar {
|
||||
@@ -251,6 +253,20 @@ public class Snackbar {
|
||||
return this;
|
||||
}
|
||||
|
||||
@@ -530,7 +509,7 @@ diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarManager.java b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarManager.java
|
||||
--- a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarManager.java
|
||||
+++ b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarManager.java
|
||||
@@ -348,6 +348,12 @@ public class SnackbarManager
|
||||
@@ -434,6 +434,12 @@ public class SnackbarManager
|
||||
new SnackbarView(
|
||||
mActivity,
|
||||
this,
|
||||
@@ -546,15 +525,15 @@ diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarView.java b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarView.java
|
||||
--- a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarView.java
|
||||
+++ b/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarView.java
|
||||
@@ -55,6 +55,7 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
@@ -56,6 +56,7 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
protected final ViewGroup mSnackbarView;
|
||||
protected final TemplatePreservingTextView mMessageView;
|
||||
private final TextView mActionButtonView;
|
||||
+ private final TextView mDismissButtonView;
|
||||
private final ImageView mProfileImageView;
|
||||
private final int mAnimationDuration;
|
||||
private final boolean mIsTablet;
|
||||
@@ -100,11 +101,12 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
private final ViewGroup mOriginalParent;
|
||||
@@ -106,6 +107,7 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
public SnackbarView(
|
||||
Activity activity,
|
||||
SnackbarManager manager,
|
||||
@@ -562,30 +541,16 @@ diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/bro
|
||||
Snackbar snackbar,
|
||||
ViewGroup parentView,
|
||||
@Nullable WindowAndroid windowAndroid,
|
||||
boolean isTablet) {
|
||||
- this(activity, manager, snackbar, parentView, windowAndroid, null, isTablet);
|
||||
+ this(activity, manager, dismissListener, snackbar, parentView, windowAndroid, null, isTablet);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -122,6 +124,7 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
public SnackbarView(
|
||||
Activity activity,
|
||||
SnackbarManager manager,
|
||||
+ OnClickListener dismissListener,
|
||||
Snackbar snackbar,
|
||||
ViewGroup parentView,
|
||||
@Nullable WindowAndroid windowAndroid,
|
||||
@@ -158,6 +161,8 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
@@ -165,6 +167,8 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
(TemplatePreservingTextView) mContainerView.findViewById(R.id.snackbar_message);
|
||||
mActionButtonView = (TextView) mContainerView.findViewById(R.id.snackbar_button);
|
||||
mActionButtonView.setOnClickListener(manager);
|
||||
+ mDismissButtonView = (TextView) mContainerView.findViewById(R.id.snackbar_dismiss);
|
||||
+ mDismissButtonView.setOnClickListener(dismissListener);
|
||||
mProfileImageView = (ImageView) mContainerView.findViewById(R.id.snackbar_profile_image);
|
||||
mEdgeToEdgeSupplier = edgeToEdgeSupplier;
|
||||
// TODO(crbug.com/451807932): Replace with a custom pad adjuster to account for inset
|
||||
@@ -434,6 +439,12 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
// Add bottom margin to extend the snackbar view into the bottom window inset. This
|
||||
// margin has to be applied to the snackbar view itself to avoid weird visual clipping
|
||||
@@ -415,6 +419,12 @@ public class SnackbarView implements InsetObserver.WindowInsetObserver {
|
||||
mActionButtonView.setVisibility(View.VISIBLE);
|
||||
mActionButtonView.setContentDescription(snackbar.getActionText());
|
||||
setViewText(mActionButtonView, snackbar.getActionText(), animate);
|
||||
@@ -601,7 +566,7 @@ diff --git a/chrome/browser/ui/messages/android/java/src/org/chromium/chrome/bro
|
||||
diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc
|
||||
--- a/content/browser/web_contents/web_contents_android.cc
|
||||
+++ b/content/browser/web_contents/web_contents_android.cc
|
||||
@@ -911,6 +911,22 @@ void WebContentsAndroid::SetFocus(JNIEnv* env, jboolean focused) {
|
||||
@@ -903,6 +903,22 @@ void WebContentsAndroid::SetFocus(JNIEnv* env, bool focused) {
|
||||
view->SetFocus(focused);
|
||||
}
|
||||
|
||||
@@ -630,7 +595,7 @@ diff --git a/content/browser/web_contents/web_contents_android.h b/content/brows
|
||||
@@ -199,6 +199,7 @@ class CONTENT_EXPORT WebContentsAndroid {
|
||||
|
||||
void OnScaleFactorChanged(JNIEnv* env);
|
||||
void SetFocus(JNIEnv* env, jboolean focused);
|
||||
void SetFocus(JNIEnv* env, bool focused);
|
||||
+ void SetPageFrozen(JNIEnv* env, jboolean frozen);
|
||||
bool IsBeingDestroyed(JNIEnv* env);
|
||||
|
||||
@@ -638,7 +603,7 @@ diff --git a/content/browser/web_contents/web_contents_android.h b/content/brows
|
||||
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
||||
--- a/content/browser/web_contents/web_contents_impl.cc
|
||||
+++ b/content/browser/web_contents/web_contents_impl.cc
|
||||
@@ -4096,8 +4096,10 @@ void WebContentsImpl::Stop() {
|
||||
@@ -4106,8 +4106,10 @@ void WebContentsImpl::Stop() {
|
||||
void WebContentsImpl::SetPageFrozen(bool frozen) {
|
||||
TRACE_EVENT1("content", "WebContentsImpl::SetPageFrozen", "frozen", frozen);
|
||||
|
||||
@@ -652,7 +617,7 @@ diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser
|
||||
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
|
||||
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
|
||||
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
|
||||
@@ -1143,6 +1143,12 @@ public class WebContentsImpl
|
||||
@@ -1171,6 +1171,12 @@ public class WebContentsImpl
|
||||
WebContentsImplJni.get().setFocus(mNativeWebContentsAndroid, hasFocus);
|
||||
}
|
||||
|
||||
@@ -665,7 +630,7 @@ diff --git a/content/public/android/java/src/org/chromium/content/browser/webcon
|
||||
@Override
|
||||
public void setDisplayCutoutSafeArea(Rect insets) {
|
||||
if (mNativeWebContentsAndroid == 0) return;
|
||||
@@ -1486,6 +1492,8 @@ public class WebContentsImpl
|
||||
@@ -1519,6 +1525,8 @@ public class WebContentsImpl
|
||||
|
||||
void setFocus(long nativeWebContentsAndroid, boolean focused);
|
||||
|
||||
@@ -734,7 +699,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/core/dom/document.cc b/third_party/blink/renderer/core/dom/document.cc
|
||||
--- a/third_party/blink/renderer/core/dom/document.cc
|
||||
+++ b/third_party/blink/renderer/core/dom/document.cc
|
||||
@@ -4665,6 +4665,7 @@ void Document::DispatchUnloadEvents(UnloadEventTimingInfo* unload_timing_info) {
|
||||
@@ -4620,6 +4620,7 @@ void Document::DispatchUnloadEvents(UnloadEventTimingInfo* unload_timing_info) {
|
||||
}
|
||||
|
||||
void Document::DispatchFreezeEvent() {
|
||||
@@ -745,7 +710,7 @@ diff --git a/third_party/blink/renderer/core/dom/document.cc b/third_party/blink
|
||||
diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
--- a/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
+++ b/third_party/blink/renderer/core/frame/local_frame.cc
|
||||
@@ -3321,6 +3321,7 @@ void LocalFrame::DidFreeze() {
|
||||
@@ -3339,6 +3339,7 @@ void LocalFrame::DidFreeze() {
|
||||
LoaderFreezeMode freeze_mode = GetLoaderFreezeMode();
|
||||
GetDocument()->Fetcher()->SetDefersLoading(freeze_mode);
|
||||
Loader().SetDefersLoading(freeze_mode);
|
||||
@@ -753,7 +718,7 @@ diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/
|
||||
}
|
||||
|
||||
void LocalFrame::DidResume() {
|
||||
@@ -3335,6 +3336,7 @@ void LocalFrame::DidResume() {
|
||||
@@ -3353,6 +3354,7 @@ void LocalFrame::DidResume() {
|
||||
GetDocument()->Fetcher()->SetDefersLoading(LoaderFreezeMode::kNone);
|
||||
Loader().SetDefersLoading(LoaderFreezeMode::kNone);
|
||||
|
||||
@@ -764,7 +729,7 @@ diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/
|
||||
diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc b/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
|
||||
--- a/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
|
||||
+++ b/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
|
||||
@@ -1025,7 +1025,9 @@ SchedulingLifecycleState FrameSchedulerImpl::CalculateLifecycleState(
|
||||
@@ -1022,7 +1022,9 @@ SchedulingLifecycleState FrameSchedulerImpl::CalculateLifecycleState(
|
||||
if (!parent_page_scheduler_)
|
||||
return SchedulingLifecycleState::kNotThrottled;
|
||||
if (parent_page_scheduler_->IsFrozen()) {
|
||||
@@ -777,7 +742,7 @@ diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/frame_sch
|
||||
diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
|
||||
--- a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
|
||||
+++ b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
|
||||
@@ -236,10 +236,12 @@ void PageSchedulerImpl::SetPageFrozen(bool frozen) {
|
||||
@@ -235,10 +235,12 @@ void PageSchedulerImpl::SetPageFrozen(bool frozen) {
|
||||
// it is desirable to reject the page freeze to prevent the scheduler from
|
||||
// being put in a bad state. See https://crbug.com/873214 for context of how
|
||||
// this can happen on the browser side.
|
||||
@@ -790,7 +755,7 @@ diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/page_sche
|
||||
PolicyUpdater policy_updater;
|
||||
SetPageFrozenImpl(frozen, policy_updater);
|
||||
}
|
||||
@@ -804,7 +806,12 @@ bool PageSchedulerImpl::IsBackgrounded() const {
|
||||
@@ -803,7 +805,12 @@ bool PageSchedulerImpl::IsBackgrounded() const {
|
||||
// expire immediately when a page is backgrounded, which is undesirable in
|
||||
// headless mode. To prevent that, a page is never considerer backgrounded
|
||||
// when virtual time is enabled.
|
||||
|
||||
@@ -52,7 +52,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/modules/webaudio/audio_buffer.cc b/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
|
||||
--- a/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
|
||||
+++ b/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
|
||||
@@ -200,6 +200,20 @@ AudioBuffer::AudioBuffer(AudioBus* bus)
|
||||
@@ -197,6 +197,20 @@ AudioBuffer::AudioBuffer(AudioBus* bus)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -88,7 +88,7 @@ diff --git a/third_party/blink/renderer/modules/webaudio/audio_buffer.h b/third_
|
||||
diff --git a/third_party/blink/renderer/modules/webaudio/audio_context.cc b/third_party/blink/renderer/modules/webaudio/audio_context.cc
|
||||
--- a/third_party/blink/renderer/modules/webaudio/audio_context.cc
|
||||
+++ b/third_party/blink/renderer/modules/webaudio/audio_context.cc
|
||||
@@ -20,6 +20,7 @@
|
||||
@@ -21,6 +21,7 @@
|
||||
#include "third_party/blink/public/common/features.h"
|
||||
#include "third_party/blink/public/common/mediastream/media_devices.h"
|
||||
#include "third_party/blink/public/platform/browser_interface_broker_proxy.h"
|
||||
@@ -96,7 +96,7 @@ diff --git a/third_party/blink/renderer/modules/webaudio/audio_context.cc b/thir
|
||||
#include "third_party/blink/public/platform/modules/webrtc/webrtc_logging.h"
|
||||
#include "third_party/blink/public/platform/web_audio_latency_hint.h"
|
||||
#include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h"
|
||||
@@ -921,7 +922,9 @@ double AudioContext::baseLatency() const {
|
||||
@@ -1133,7 +1134,9 @@ double AudioContext::baseLatency() const {
|
||||
DCHECK_CALLED_ON_VALID_SEQUENCE(main_thread_sequence_checker_);
|
||||
DCHECK(destination());
|
||||
|
||||
@@ -139,7 +139,7 @@ diff --git a/third_party/blink/renderer/modules/webaudio/base_audio_context.cc b
|
||||
diff --git a/third_party/blink/renderer/modules/webaudio/base_audio_context.h b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
|
||||
--- a/third_party/blink/renderer/modules/webaudio/base_audio_context.h
|
||||
+++ b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
|
||||
@@ -327,6 +327,8 @@ class MODULES_EXPORT BaseAudioContext
|
||||
@@ -331,6 +331,8 @@ class MODULES_EXPORT BaseAudioContext
|
||||
// if the execution context does not exist.
|
||||
bool CheckExecutionContextAndThrowIfNecessary(ExceptionState&);
|
||||
|
||||
@@ -151,7 +151,7 @@ diff --git a/third_party/blink/renderer/modules/webaudio/base_audio_context.h b/
|
||||
diff --git a/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc b/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
|
||||
--- a/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
|
||||
+++ b/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
|
||||
@@ -395,6 +395,7 @@ void OfflineAudioContext::FireCompletionEvent() {
|
||||
@@ -418,6 +418,7 @@ void OfflineAudioContext::FireCompletionEvent() {
|
||||
if (!rendered_buffer) {
|
||||
return;
|
||||
}
|
||||
@@ -170,17 +170,17 @@ diff --git a/third_party/blink/renderer/modules/webaudio/realtime_analyser.cc b/
|
||||
#include "third_party/blink/renderer/platform/audio/audio_bus.h"
|
||||
#include "third_party/blink/renderer/platform/audio/audio_utilities.h"
|
||||
#include "third_party/blink/renderer/platform/audio/vector_math.h"
|
||||
@@ -118,7 +119,8 @@ void RealtimeAnalyser::GetFloatFrequencyData(DOMFloat32Array* destination_array,
|
||||
@@ -117,7 +118,8 @@ void RealtimeAnalyser::GetFloatFrequencyData(DOMFloat32Array* destination_array,
|
||||
for (unsigned i = 0; i < len; ++i) {
|
||||
const float linear_value = UNSAFE_TODO(source[i]);
|
||||
const float linear_value = magnitude_buffer_[i];
|
||||
const double db_mag = audio_utilities::LinearToDecibels(linear_value);
|
||||
- UNSAFE_TODO(destination[i]) = static_cast<float>(db_mag);
|
||||
- destination[i] = static_cast<float>(db_mag);
|
||||
+ auto v = static_cast<float>(db_mag);
|
||||
+ UNSAFE_TODO(destination[i]) = BaseAudioContext::ShuffleAudioData(v, i);
|
||||
+ destination[i] = BaseAudioContext::ShuffleAudioData(v, i);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -156,9 +158,11 @@ void RealtimeAnalyser::GetByteFrequencyData(DOMUint8Array* destination_array,
|
||||
@@ -153,9 +155,11 @@ void RealtimeAnalyser::GetByteFrequencyData(DOMUint8Array* destination_array,
|
||||
|
||||
// The range m_minDecibels to m_maxDecibels will be scaled to byte values
|
||||
// from 0 to UCHAR_MAX.
|
||||
@@ -191,24 +191,24 @@ diff --git a/third_party/blink/renderer/modules/webaudio/realtime_analyser.cc b/
|
||||
+ scaled_value = BaseAudioContext::ShuffleAudioData(scaled_value, i);
|
||||
+
|
||||
// Clip to valid range.
|
||||
UNSAFE_TODO(destination[i]) =
|
||||
destination[i] =
|
||||
static_cast<unsigned char>(ClampTo(scaled_value, 0, UCHAR_MAX));
|
||||
@@ -189,6 +193,7 @@ void RealtimeAnalyser::GetFloatTimeDomainData(
|
||||
input_buffer[(i + write_index - fft_size + kInputBufferSize) %
|
||||
kInputBufferSize]);
|
||||
@@ -184,6 +188,7 @@ void RealtimeAnalyser::GetFloatTimeDomainData(
|
||||
input_buffer_[(i + write_index - fft_size + kInputBufferSize) %
|
||||
kInputBufferSize];
|
||||
|
||||
+ value = BaseAudioContext::ShuffleAudioData(value, i);
|
||||
UNSAFE_TODO(destination[i]) = value;
|
||||
destination[i] = value;
|
||||
}
|
||||
}
|
||||
@@ -212,10 +217,12 @@ void RealtimeAnalyser::GetByteTimeDomainData(DOMUint8Array* destination_array) {
|
||||
|
||||
@@ -205,10 +210,12 @@ void RealtimeAnalyser::GetByteTimeDomainData(DOMUint8Array* destination_array) {
|
||||
base::span<unsigned char> destination = destination_array->AsSpan();
|
||||
for (unsigned i = 0; i < len; ++i) {
|
||||
// Buffer access is protected due to modulo operation.
|
||||
- const float value = UNSAFE_TODO(
|
||||
+ float value = UNSAFE_TODO(
|
||||
input_buffer[(i + write_index - fft_size + kInputBufferSize) %
|
||||
kInputBufferSize]);
|
||||
- const float value =
|
||||
+ float value =
|
||||
input_buffer_[(i + write_index - fft_size + kInputBufferSize) %
|
||||
kInputBufferSize];
|
||||
|
||||
+ value = BaseAudioContext::ShuffleAudioData(value, i);
|
||||
+
|
||||
@@ -218,7 +218,7 @@ diff --git a/third_party/blink/renderer/modules/webaudio/realtime_analyser.cc b/
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -639,9 +639,8 @@
|
||||
@@ -688,9 +688,8 @@
|
||||
{
|
||||
// AudioContext.playoutStats interface.
|
||||
// https://chromestatus.com/feature/5172818344148992
|
||||
|
||||
@@ -12,7 +12,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/third_party/blink/renderer/modules/battery/battery_manager.cc b/third_party/blink/renderer/modules/battery/battery_manager.cc
|
||||
--- a/third_party/blink/renderer/modules/battery/battery_manager.cc
|
||||
+++ b/third_party/blink/renderer/modules/battery/battery_manager.cc
|
||||
@@ -77,46 +77,28 @@ ScriptPromise<BatteryManager> BatteryManager::StartRequest(
|
||||
@@ -80,46 +80,28 @@ ScriptPromise<BatteryManager> BatteryManager::StartRequest(
|
||||
}
|
||||
|
||||
bool BatteryManager::charging() {
|
||||
|
||||
@@ -23,7 +23,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/third_party/blink/renderer/core/execution_context/execution_context.h b/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
--- a/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
+++ b/third_party/blink/renderer/core/execution_context/execution_context.h
|
||||
@@ -425,6 +425,7 @@ class CORE_EXPORT ExecutionContext : public MojoBindingContext,
|
||||
@@ -388,6 +388,7 @@ class CORE_EXPORT ExecutionContext : public Supplementable<ExecutionContext>,
|
||||
void SetAddressSpace(network::mojom::blink::IPAddressSpace ip_address_space);
|
||||
|
||||
HeapObserverList<ContextLifecycleObserver>& ContextLifecycleObserverSet();
|
||||
@@ -45,7 +45,7 @@ diff --git a/third_party/blink/renderer/core/loader/base_fetch_context.h b/third
|
||||
diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
--- a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
+++ b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
@@ -1122,6 +1122,26 @@ bool FrameFetchContext::ShouldBlockRequestByInspector(const KURL& url) const {
|
||||
@@ -1138,6 +1138,26 @@ bool FrameFetchContext::ShouldBlockRequestByInspector(const KURL& url) const {
|
||||
return should_block_request;
|
||||
}
|
||||
|
||||
@@ -75,7 +75,7 @@ diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/thi
|
||||
diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.h b/third_party/blink/renderer/core/loader/frame_fetch_context.h
|
||||
--- a/third_party/blink/renderer/core/loader/frame_fetch_context.h
|
||||
+++ b/third_party/blink/renderer/core/loader/frame_fetch_context.h
|
||||
@@ -191,6 +191,7 @@ class CORE_EXPORT FrameFetchContext final : public BaseFetchContext,
|
||||
@@ -197,6 +197,7 @@ class CORE_EXPORT FrameFetchContext final : public BaseFetchContext,
|
||||
bool ShouldBlockWebSocketByMixedContentCheck(const KURL&) const override;
|
||||
std::unique_ptr<WebSocketHandshakeThrottle> CreateWebSocketHandshakeThrottle()
|
||||
override;
|
||||
@@ -93,8 +93,8 @@ diff --git a/third_party/blink/renderer/core/loader/worker_fetch_context.cc b/th
|
||||
+#include "third_party/blink/renderer/platform/network/network_utils.h"
|
||||
#include "third_party/blink/renderer/platform/runtime_enabled_features.h"
|
||||
#include "third_party/blink/renderer/platform/scheduler/public/virtual_time_controller.h"
|
||||
#include "third_party/blink/renderer/platform/weborigin/security_policy.h"
|
||||
@@ -89,6 +90,26 @@ bool WorkerFetchContext::ShouldBlockRequestByInspector(const KURL& url) const {
|
||||
#include "third_party/blink/renderer/platform/supplementable.h"
|
||||
@@ -90,6 +91,26 @@ bool WorkerFetchContext::ShouldBlockRequestByInspector(const KURL& url) const {
|
||||
return should_block_request;
|
||||
}
|
||||
|
||||
@@ -148,7 +148,7 @@ diff --git a/third_party/blink/renderer/modules/background_fetch/background_fetc
|
||||
--- a/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
|
||||
+++ b/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
|
||||
@@ -104,6 +104,30 @@ bool ShouldBlockDanglingMarkup(const KURL& request_url) {
|
||||
request_url.ProtocolIsInHTTPFamily();
|
||||
request_url.ProtocolIsInHttpFamily();
|
||||
}
|
||||
|
||||
+bool ShouldBlockGateWayAttacks(ExecutionContext* execution_context,
|
||||
|
||||
@@ -25,7 +25,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
@@ -5158,7 +5158,17 @@ void RenderFrameHostImpl::SetLastCommittedOrigin(
|
||||
@@ -5374,7 +5374,17 @@ void RenderFrameHostImpl::SetLastCommittedOrigin(
|
||||
}
|
||||
|
||||
void RenderFrameHostImpl::SetInheritedBaseUrl(const GURL& inherited_base_url) {
|
||||
@@ -106,7 +106,7 @@ diff --git a/third_party/blink/renderer/core/frame/location.cc b/third_party/bli
|
||||
diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
--- a/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
+++ b/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
@@ -835,6 +835,11 @@ WebString DocumentLoader::HttpMethod() const {
|
||||
@@ -850,6 +850,11 @@ WebString DocumentLoader::HttpMethod() const {
|
||||
}
|
||||
|
||||
const AtomicString& DocumentLoader::GetReferrer() const {
|
||||
@@ -118,7 +118,7 @@ diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_p
|
||||
return referrer_;
|
||||
}
|
||||
|
||||
@@ -2913,6 +2918,13 @@ void DocumentLoader::CommitNavigation() {
|
||||
@@ -2965,6 +2970,13 @@ void DocumentLoader::CommitNavigation() {
|
||||
response_.HttpHeaderField(http_names::kDocumentPolicyReportOnly));
|
||||
}
|
||||
|
||||
@@ -135,7 +135,7 @@ diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_p
|
||||
diff --git a/third_party/blink/renderer/core/loader/document_loader.h b/third_party/blink/renderer/core/loader/document_loader.h
|
||||
--- a/third_party/blink/renderer/core/loader/document_loader.h
|
||||
+++ b/third_party/blink/renderer/core/loader/document_loader.h
|
||||
@@ -768,7 +768,7 @@ class CORE_EXPORT DocumentLoader : public GarbageCollected<DocumentLoader>,
|
||||
@@ -789,7 +789,7 @@ class CORE_EXPORT DocumentLoader : public GarbageCollected<DocumentLoader>,
|
||||
// |archive_|, but won't have |loading_main_document_from_mhtml_archive_| set.
|
||||
bool loading_main_document_from_mhtml_archive_ = false;
|
||||
const bool loading_srcdoc_ = false;
|
||||
|
||||
@@ -39,7 +39,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
|
||||
/**
|
||||
* Main toolbar of bookmark UI. It is responsible for displaying title and buttons associated with
|
||||
@@ -190,6 +191,11 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -197,6 +198,11 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
void setCurrentFolder(BookmarkId folder) {
|
||||
mCurrentFolder = mBookmarkModel.getBookmarkById(folder);
|
||||
enableImportExportMenu();
|
||||
@@ -51,7 +51,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
}
|
||||
|
||||
void enableImportExportMenu() {
|
||||
@@ -226,6 +232,17 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -233,6 +239,17 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
mExportBookmarkRunnable.run();
|
||||
return true;
|
||||
}
|
||||
@@ -69,7 +69,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
return assumeNonNull(mMenuIdClickedFunction).apply(menuItem.getItemId());
|
||||
}
|
||||
|
||||
@@ -248,6 +265,7 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
@@ -255,6 +272,7 @@ public class BookmarkToolbar extends SelectableListToolbar<BookmarkId>
|
||||
|
||||
getMenu().findItem(R.id.import_menu_id).setVisible(mCurrentFolder != null);
|
||||
getMenu().findItem(R.id.export_menu_id).setVisible(mCurrentFolder != null);
|
||||
@@ -80,7 +80,7 @@ diff --git a/chrome/browser/bookmarks/android/java/src/org/chromium/chrome/brows
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -264,6 +264,9 @@ CHAR_LIMIT guidelines:
|
||||
@@ -271,6 +271,9 @@ CHAR_LIMIT guidelines:
|
||||
<message name="IDS_NOTIFICATION_CATEGORY_SITES" desc="Label for notifications from websites, within a list of notification categories. [CHAR_LIMIT=32]">
|
||||
Sites
|
||||
</message>
|
||||
|
||||
@@ -21,7 +21,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
chrome/browser/endpoint_fetcher/BUILD.gn | 32 ++
|
||||
chrome/browser/endpoint_fetcher/DEPS | 3 +
|
||||
chrome/browser/endpoint_fetcher/OWNERS | 1 +
|
||||
.../endpoint_fetcher_android.cc | 107 +++++++
|
||||
.../endpoint_fetcher_android.cc | 109 +++++++
|
||||
.../endpoint_fetcher/EndpointFetcher.java | 63 ++++
|
||||
.../EndpointHeaderResponse.java | 31 ++
|
||||
.../endpoint_fetcher/EndpointResponse.java | 30 ++
|
||||
@@ -39,8 +39,6 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../strings/android_chrome_strings.grd | 23 +-
|
||||
.../ui/lens/lens_overlay_query_controller.cc | 2 +-
|
||||
components/commerce/core/account_checker.cc | 2 +-
|
||||
.../core/compare/cluster_server_proxy.cc | 2 +-
|
||||
.../product_specifications_server_proxy.cc | 2 +-
|
||||
.../subscriptions_server_proxy.cc | 2 +-
|
||||
.../internal/composebox_query_controller.cc | 2 +-
|
||||
.../data_sharing_network_loader_impl.cc | 2 +-
|
||||
@@ -50,7 +48,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
components/manta/base_provider.cc | 4 +-
|
||||
.../Bromite-auto-updater.inc | 3 +
|
||||
.../Bromite-auto-updater.inc | 1 +
|
||||
42 files changed, 1154 insertions(+), 106 deletions(-)
|
||||
40 files changed, 1154 insertions(+), 104 deletions(-)
|
||||
create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/omaha/CromiteUpdateStatusProvider.java
|
||||
create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/omaha/inline/BromiteInlineUpdateController.java
|
||||
create mode 100644 chrome/browser/endpoint_fetcher/BUILD.gn
|
||||
@@ -79,7 +77,7 @@ diff --git a/build/android/java/templates/BuildConfig.template b/build/android/j
|
||||
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
|
||||
--- a/build/config/android/rules.gni
|
||||
+++ b/build/config/android/rules.gni
|
||||
@@ -1959,6 +1959,9 @@ if (!is_robolectric && enable_java_templates) {
|
||||
@@ -1979,6 +1979,9 @@ if (!is_robolectric && enable_java_templates) {
|
||||
sources = [ "//build/android/java/templates/BuildConfig.template" ]
|
||||
defines = []
|
||||
|
||||
@@ -92,7 +90,7 @@ diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
|
||||
diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
|
||||
--- a/chrome/android/chrome_java_sources.gni
|
||||
+++ b/chrome/android/chrome_java_sources.gni
|
||||
@@ -871,6 +871,8 @@ chrome_java_sources = [
|
||||
@@ -906,6 +906,8 @@ chrome_java_sources = [
|
||||
"java/src/org/chromium/chrome/browser/omaha/OmahaBase.java",
|
||||
"java/src/org/chromium/chrome/browser/omaha/OmahaDelegate.java",
|
||||
"java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java",
|
||||
@@ -119,7 +117,7 @@ diff --git a/chrome/android/java/res/xml/about_chrome_preferences.xml b/chrome/a
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
@@ -31,10 +31,15 @@ import org.chromium.ui.widget.Toast;
|
||||
@@ -32,10 +32,15 @@ import org.chromium.ui.widget.Toast;
|
||||
|
||||
import java.util.Calendar;
|
||||
|
||||
@@ -136,7 +134,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/
|
||||
static {
|
||||
CalendarFactory.warmUp();
|
||||
}
|
||||
@@ -42,6 +47,7 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
@@ -43,6 +48,7 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
private static final int TAPS_FOR_DEVELOPER_SETTINGS = 7;
|
||||
|
||||
private static final String PREF_APPLICATION_VERSION = "application_version";
|
||||
@@ -144,9 +142,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/
|
||||
private static final String PREF_OS_VERSION = "os_version";
|
||||
private static final String PREF_LEGAL_INFORMATION = "legal_information";
|
||||
|
||||
@@ -78,6 +84,13 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
assumeNonNull(p);
|
||||
int currentYear = CalendarFactory.get().get(Calendar.YEAR);
|
||||
@@ -82,6 +88,13 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
calendar.setTimeInMillis(System.currentTimeMillis());
|
||||
int currentYear = calendar.get(Calendar.YEAR);
|
||||
p.setSummary(getString(R.string.legal_information_summary, currentYear));
|
||||
+
|
||||
+ ChromeSwitchPreference allowInlineUpdate =
|
||||
@@ -158,7 +156,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -148,6 +161,19 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
@@ -152,6 +165,19 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -366,7 +364,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMen
|
||||
+ mMenuUiState.itemState.summary =
|
||||
+ resources.getString(defaultUpdateSummary);
|
||||
+ }
|
||||
+ mMenuUiState.itemState.icon = R.drawable.ic_history_googblue_24dp;
|
||||
+ mMenuUiState.itemState.icon = R.drawable.ic_history_24dp;
|
||||
+ mMenuUiState.itemState.iconTintId = R.color.default_icon_color_blue_light;
|
||||
+ mMenuUiState.itemState.enabled = true;
|
||||
+ break;
|
||||
@@ -390,7 +388,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMen
|
||||
+ mMenuUiState.itemState.title = R.string.menu_inline_update_failed;
|
||||
+ mMenuUiState.itemState.titleColorId = R.color.default_text_color_blue_dark;
|
||||
+ mMenuUiState.itemState.summary = resources.getString(R.string.try_again);
|
||||
+ mMenuUiState.itemState.icon = R.drawable.ic_history_googblue_24dp;
|
||||
+ mMenuUiState.itemState.icon = R.drawable.ic_history_24dp;
|
||||
+ mMenuUiState.itemState.iconTintId = R.color.default_icon_color_blue_light;
|
||||
+ mMenuUiState.itemState.enabled = true;
|
||||
+ break;
|
||||
@@ -690,7 +688,7 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -2652,6 +2652,12 @@ static_library("browser") {
|
||||
@@ -2504,6 +2504,12 @@ static_library("browser") {
|
||||
}
|
||||
|
||||
if (is_android) {
|
||||
@@ -758,7 +756,7 @@ diff --git a/chrome/browser/endpoint_fetcher/endpoint_fetcher_android.cc b/chrom
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/chrome/browser/endpoint_fetcher/endpoint_fetcher_android.cc
|
||||
@@ -0,0 +1,107 @@
|
||||
@@ -0,0 +1,109 @@
|
||||
+// Copyright 2019 The Chromium Authors
|
||||
+// Use of this source code is governed by a BSD-style license that can be
|
||||
+// found in the LICENSE file.
|
||||
@@ -815,11 +813,11 @@ new file mode 100644
|
||||
+
|
||||
+static void JNI_EndpointFetcher_NativeFetchWithNoAuth(
|
||||
+ JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& jprofile,
|
||||
+ const base::android::JavaParamRef<jstring>& jurl,
|
||||
+ const base::android::JavaRef<jobject>& jprofile,
|
||||
+ const base::android::JavaRef<jstring>& jurl,
|
||||
+ jlong jtimeout, jboolean intercept_redirect,
|
||||
+ jint jannotation_hash_code,
|
||||
+ const base::android::JavaParamRef<jobject>& jcallback) {
|
||||
+ const base::android::JavaRef<jobject>& jcallback) {
|
||||
+ auto endpoint_fetcher = std::make_unique<endpoint_fetcher::EndpointFetcher>(
|
||||
+ Profile::FromJavaObject(jprofile)
|
||||
+ ->GetDefaultStoragePartition()
|
||||
@@ -842,11 +840,11 @@ new file mode 100644
|
||||
+
|
||||
+static void JNI_EndpointFetcher_NativeHeadWithNoAuth(
|
||||
+ JNIEnv* env,
|
||||
+ const base::android::JavaParamRef<jobject>& jprofile,
|
||||
+ const base::android::JavaParamRef<jstring>& jurl,
|
||||
+ const base::android::JavaRef<jobject>& jprofile,
|
||||
+ const base::android::JavaRef<jstring>& jurl,
|
||||
+ jlong jtimeout, jboolean intercept_redirect,
|
||||
+ jint jannotation_hash_code,
|
||||
+ const base::android::JavaParamRef<jobject>& jcallback) {
|
||||
+ const base::android::JavaRef<jobject>& jcallback) {
|
||||
+ auto endpoint_fetcher = std::make_unique<endpoint_fetcher::EndpointFetcher>(
|
||||
+ Profile::FromJavaObject(jprofile)
|
||||
+ ->GetDefaultStoragePartition()
|
||||
@@ -866,6 +864,8 @@ new file mode 100644
|
||||
+ std::move(endpoint_fetcher)),
|
||||
+ nullptr);
|
||||
+}
|
||||
+
|
||||
+DEFINE_JNI(EndpointFetcher)
|
||||
diff --git a/chrome/browser/endpoint_fetcher/java/src/org/chromium/chrome/browser/endpoint_fetcher/EndpointFetcher.java b/chrome/browser/endpoint_fetcher/java/src/org/chromium/chrome/browser/endpoint_fetcher/EndpointFetcher.java
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
@@ -1008,29 +1008,29 @@ new file mode 100644
|
||||
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
--- a/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
|
||||
@@ -387,6 +387,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
@@ -402,6 +402,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
|
||||
&kProtectedTabsAndroid,
|
||||
&kPwaRestoreUi,
|
||||
&kPwaRestoreUiAtStartup,
|
||||
+ &kInlineUpdateFlow,
|
||||
&kReadAloud,
|
||||
&kReadAloudAudioOverviews,
|
||||
&kReadAloudAudioOverviewsFeedback,
|
||||
&kReadAloudIPHMenuButtonHighlightCCT,
|
||||
&kReadAloudPlayback,
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
|
||||
@@ -477,6 +477,7 @@ public abstract class ChromeFeatureList {
|
||||
@@ -486,6 +486,7 @@ public abstract class ChromeFeatureList {
|
||||
public static final String INCOGNITO_NTP_SMALL_ICON = "IncognitoNtpSmallIcon";
|
||||
public static final String INCOGNITO_SCREENSHOT = "IncognitoScreenshot";
|
||||
public static final String INCOGNITO_THEME_OVERLAY_TESTING = "IncognitoThemeOverlayTesting";
|
||||
+ public static final String INLINE_UPDATE_FLOW = "InlineUpdateFlow";
|
||||
public static final String INSTANCE_SWITCHER_V2 = "InstanceSwitcherV2";
|
||||
public static final String IP_PROTECTION_UX = "IpProtectionUx";
|
||||
public static final String INLINE_PDF_V2 = "InlinePdfV2";
|
||||
public static final String KEYBOARD_ESC_BACK_NAVIGATION = "KeyboardEscBackNavigation";
|
||||
public static final String LAUNCH_CAUSE_SCREEN_OFF_FIX = "LaunchCauseScreenOffFix";
|
||||
diff --git a/chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.cc b/chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.cc
|
||||
--- a/chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.cc
|
||||
+++ b/chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.cc
|
||||
@@ -264,7 +264,7 @@ AccessCodeCastDiscoveryInterface::CreateEndpointFetcher(
|
||||
@@ -265,7 +265,7 @@ AccessCodeCastDiscoveryInterface::CreateEndpointFetcher(
|
||||
.SetTimeout(kTimeout)
|
||||
.SetUrl(GURL(base::StrCat({GetDiscoveryUrl(), "/", access_code})))
|
||||
.SetPostData(kEmptyPostData)
|
||||
@@ -1351,9 +1351,9 @@ diff --git a/chrome/browser/omaha/android/java/src/org/chromium/chrome/browser/o
|
||||
- mMetrics.startUpdate();
|
||||
-
|
||||
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(mStatus.updateUrl));
|
||||
if (newTask) intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
|
||||
context.startActivity(intent);
|
||||
@@ -201,9 +238,15 @@ public class UpdateStatusProvider {
|
||||
// Ensure that the app vs browser disambiguation dialog is not shown.
|
||||
intent.addFlags(Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER);
|
||||
@@ -203,9 +240,15 @@ public class UpdateStatusProvider {
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -1371,7 +1371,7 @@ diff --git a/chrome/browser/omaha/android/java/src/org/chromium/chrome/browser/o
|
||||
}
|
||||
|
||||
@RequiresNonNull("mStatus")
|
||||
@@ -212,35 +255,52 @@ public class UpdateStatusProvider {
|
||||
@@ -214,35 +257,52 @@ public class UpdateStatusProvider {
|
||||
}
|
||||
|
||||
private void resolveStatus() {
|
||||
@@ -1433,7 +1433,7 @@ diff --git a/chrome/browser/omaha/android/java/src/org/chromium/chrome/browser/o
|
||||
mCallback = resultReceiver;
|
||||
}
|
||||
|
||||
@@ -252,7 +312,7 @@ public class UpdateStatusProvider {
|
||||
@@ -254,7 +314,7 @@ public class UpdateStatusProvider {
|
||||
protected UpdateStatus doInBackground() {
|
||||
UpdateStatus testStatus = getTestStatus();
|
||||
if (testStatus != null) return testStatus;
|
||||
@@ -1442,7 +1442,7 @@ diff --git a/chrome/browser/omaha/android/java/src/org/chromium/chrome/browser/o
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -270,6 +330,8 @@ public class UpdateStatusProvider {
|
||||
@@ -272,6 +332,8 @@ public class UpdateStatusProvider {
|
||||
status.mIsSimulated = true;
|
||||
status.updateState = forcedUpdateState;
|
||||
|
||||
@@ -1451,7 +1451,7 @@ diff --git a/chrome/browser/omaha/android/java/src/org/chromium/chrome/browser/o
|
||||
// Push custom configurations for certain update states.
|
||||
switch (forcedUpdateState) {
|
||||
case UpdateState.UPDATE_AVAILABLE:
|
||||
@@ -287,31 +349,33 @@ public class UpdateStatusProvider {
|
||||
@@ -289,31 +351,33 @@ public class UpdateStatusProvider {
|
||||
return status;
|
||||
}
|
||||
|
||||
@@ -1621,7 +1621,7 @@ diff --git a/chrome/browser/save_to_drive/drive_uploader.cc b/chrome/browser/sav
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -2315,6 +2315,12 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -2401,6 +2401,12 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
<message name="IDS_DEPRECATION_WARNING" desc="Warning about Chrome updates no longer being supported">
|
||||
Chrome updates are no longer supported for this version of Android
|
||||
</message>
|
||||
@@ -1634,7 +1634,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
|
||||
<!-- Account management UI strings. -->
|
||||
<message name="IDS_ACCOUNT_MANAGEMENT_TITLE" desc="Header title for the account management screen. [CHAR_LIMIT=32]">
|
||||
@@ -4366,7 +4372,10 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -4486,7 +4492,10 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
|
||||
<!-- Main menu items -->
|
||||
<message name="IDS_MENU_UPDATE" desc="Menu item for updating chrome. [CHAR_LIMIT=24]">
|
||||
@@ -1646,7 +1646,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
</message>
|
||||
<message name="IDS_MENU_UPDATE_SUMMARY_DEFAULT" desc="Summary string for update menu item explaining that a newer version of Chrome is available. [CHAR_LIMIT=30]">
|
||||
Newer version is available
|
||||
@@ -4377,6 +4386,18 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -4497,6 +4506,18 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
<message name="IDS_MENU_UPDATE_UNSUPPORTED_SUMMARY_DEFAULT" desc="Summary string for update menu item explaining that the Android version on the device is unsupported. [CHAR_LIMIT=30]">
|
||||
Android version is unsupported
|
||||
</message>
|
||||
@@ -1668,7 +1668,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
diff --git a/chrome/browser/ui/lens/lens_overlay_query_controller.cc b/chrome/browser/ui/lens/lens_overlay_query_controller.cc
|
||||
--- a/chrome/browser/ui/lens/lens_overlay_query_controller.cc
|
||||
+++ b/chrome/browser/ui/lens/lens_overlay_query_controller.cc
|
||||
@@ -770,7 +770,7 @@ LensOverlayQueryController::CreateEndpointFetcher(
|
||||
@@ -771,7 +771,7 @@ LensOverlayQueryController::CreateEndpointFetcher(
|
||||
.SetTimeout(timeout)
|
||||
.SetUrl(fetch_url)
|
||||
.SetUploadProgressCallback(std::move(upload_progress_callback))
|
||||
@@ -1689,30 +1689,6 @@ diff --git a/components/commerce/core/account_checker.cc b/components/commerce/c
|
||||
}
|
||||
|
||||
} // namespace commerce
|
||||
diff --git a/components/commerce/core/compare/cluster_server_proxy.cc b/components/commerce/core/compare/cluster_server_proxy.cc
|
||||
--- a/components/commerce/core/compare/cluster_server_proxy.cc
|
||||
+++ b/components/commerce/core/compare/cluster_server_proxy.cc
|
||||
@@ -156,7 +156,7 @@ std::unique_ptr<EndpointFetcher> ClusterServerProxy::CreateEndpointFetcher(
|
||||
.SetPostData(post_data);
|
||||
commerce::MaybeUseAlternateShoppingServer(request_params);
|
||||
return std::make_unique<EndpointFetcher>(
|
||||
- url_loader_factory_, identity_manager_, request_params.Build());
|
||||
+ url_loader_factory_, identity_manager_, request_params.Build(), kGetComparableProductsTrafficAnnotation);
|
||||
}
|
||||
|
||||
void ClusterServerProxy::HandleCompareResponse(
|
||||
diff --git a/components/commerce/core/compare/product_specifications_server_proxy.cc b/components/commerce/core/compare/product_specifications_server_proxy.cc
|
||||
--- a/components/commerce/core/compare/product_specifications_server_proxy.cc
|
||||
+++ b/components/commerce/core/compare/product_specifications_server_proxy.cc
|
||||
@@ -296,7 +296,7 @@ ProductSpecificationsServerProxy::CreateEndpointFetcher(
|
||||
.SetPostData(post_data);
|
||||
MaybeUseAlternateShoppingServer(request_params);
|
||||
return std::make_unique<EndpointFetcher>(
|
||||
- url_loader_factory_, identity_manager_, request_params.Build());
|
||||
+ url_loader_factory_, identity_manager_, request_params.Build(), kShoppingListTrafficAnnotation);
|
||||
}
|
||||
|
||||
std::optional<ProductSpecifications>
|
||||
diff --git a/components/commerce/core/subscriptions/subscriptions_server_proxy.cc b/components/commerce/core/subscriptions/subscriptions_server_proxy.cc
|
||||
--- a/components/commerce/core/subscriptions/subscriptions_server_proxy.cc
|
||||
+++ b/components/commerce/core/subscriptions/subscriptions_server_proxy.cc
|
||||
@@ -1728,7 +1704,7 @@ diff --git a/components/commerce/core/subscriptions/subscriptions_server_proxy.c
|
||||
diff --git a/components/contextual_search/internal/composebox_query_controller.cc b/components/contextual_search/internal/composebox_query_controller.cc
|
||||
--- a/components/contextual_search/internal/composebox_query_controller.cc
|
||||
+++ b/components/contextual_search/internal/composebox_query_controller.cc
|
||||
@@ -777,7 +777,7 @@ ComposeboxQueryController::CreateEndpointFetcher(
|
||||
@@ -1148,7 +1148,7 @@ ComposeboxQueryController::CreateEndpointFetcher(
|
||||
.SetTimeout(timeout)
|
||||
.SetUploadProgressCallback(std::move(upload_progress_callback))
|
||||
.SetUrl(fetch_url)
|
||||
@@ -1752,7 +1728,7 @@ diff --git a/components/data_sharing/internal/data_sharing_network_loader_impl.c
|
||||
diff --git a/components/data_sharing/internal/preview_server_proxy.cc b/components/data_sharing/internal/preview_server_proxy.cc
|
||||
--- a/components/data_sharing/internal/preview_server_proxy.cc
|
||||
+++ b/components/data_sharing/internal/preview_server_proxy.cc
|
||||
@@ -346,7 +346,7 @@ std::unique_ptr<EndpointFetcher> PreviewServerProxy::CreateEndpointFetcher(
|
||||
@@ -345,7 +345,7 @@ std::unique_ptr<EndpointFetcher> PreviewServerProxy::CreateEndpointFetcher(
|
||||
.SetContentType(kContentType)
|
||||
.SetTimeout(kTimeout)
|
||||
.SetUrl(url)
|
||||
@@ -1973,7 +1949,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.cc b/components/endpoi
|
||||
diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoint_fetcher/endpoint_fetcher.h
|
||||
--- a/components/endpoint_fetcher/endpoint_fetcher.h
|
||||
+++ b/components/endpoint_fetcher/endpoint_fetcher.h
|
||||
@@ -20,6 +20,9 @@
|
||||
@@ -19,6 +19,9 @@
|
||||
#include "services/network/public/mojom/fetch_api.mojom-forward.h"
|
||||
#include "url/gurl.h"
|
||||
|
||||
@@ -1983,7 +1959,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
namespace base {
|
||||
class TimeDelta;
|
||||
} // namespace base
|
||||
@@ -61,6 +64,7 @@ enum class HttpMethod {
|
||||
@@ -60,6 +63,7 @@ enum class HttpMethod {
|
||||
kPost = 1,
|
||||
kDelete = 2,
|
||||
kPut = 3,
|
||||
@@ -1991,7 +1967,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
};
|
||||
|
||||
enum AuthType {
|
||||
@@ -79,6 +83,8 @@ struct EndpointResponse {
|
||||
@@ -78,6 +82,8 @@ struct EndpointResponse {
|
||||
~EndpointResponse();
|
||||
|
||||
std::string response;
|
||||
@@ -2000,7 +1976,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
int http_status_code{-1};
|
||||
std::optional<FetchErrorType> error_type;
|
||||
scoped_refptr<net::HttpResponseHeaders> headers;
|
||||
@@ -301,7 +307,16 @@ class EndpointFetcher {
|
||||
@@ -300,7 +306,16 @@ class EndpointFetcher {
|
||||
EndpointFetcher(
|
||||
const scoped_refptr<network::SharedURLLoaderFactory>& url_loader_factory,
|
||||
signin::IdentityManager* identity_manager,
|
||||
@@ -2018,7 +1994,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
|
||||
EndpointFetcher(const EndpointFetcher& endpoint_fetcher) = delete;
|
||||
EndpointFetcher& operator=(const EndpointFetcher& endpoint_fetcher) = delete;
|
||||
@@ -334,11 +349,17 @@ class EndpointFetcher {
|
||||
@@ -333,11 +348,17 @@ class EndpointFetcher {
|
||||
|
||||
void OnResponseFetched(EndpointFetcherCallback callback,
|
||||
std::optional<std::string> response_body);
|
||||
@@ -2036,7 +2012,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
|
||||
// Members set in constructor
|
||||
const scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory_;
|
||||
@@ -349,6 +370,8 @@ class EndpointFetcher {
|
||||
@@ -348,6 +369,8 @@ class EndpointFetcher {
|
||||
// SingleClientSharedTabGroupVersioningSyncTest.ShouldShowVersioningMessagesAfterRestart/kSyncTransportOnly
|
||||
const raw_ptr<signin::IdentityManager, DanglingUntriaged> identity_manager_;
|
||||
|
||||
@@ -2045,7 +2021,7 @@ diff --git a/components/endpoint_fetcher/endpoint_fetcher.h b/components/endpoin
|
||||
// The complete definition of the specific network request to be performed.
|
||||
// Contains authentication details and response handling preferences.
|
||||
const RequestParams request_params_;
|
||||
@@ -358,6 +381,9 @@ class EndpointFetcher {
|
||||
@@ -357,6 +380,9 @@ class EndpointFetcher {
|
||||
access_token_fetcher_;
|
||||
std::unique_ptr<network::SimpleURLLoader> simple_url_loader_;
|
||||
|
||||
|
||||
@@ -10,10 +10,10 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/chrome_public_apk_tmpl.gni b/chrome/android/chrome_public_apk_tmpl.gni
|
||||
--- a/chrome/android/chrome_public_apk_tmpl.gni
|
||||
+++ b/chrome/android/chrome_public_apk_tmpl.gni
|
||||
@@ -27,7 +27,7 @@ declare_args() {
|
||||
# WebView providers which declare one of a handful of package names. See
|
||||
# https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/build-instructions.md#Changing-package-name
|
||||
# for details.
|
||||
@@ -23,7 +23,7 @@ declare_args() {
|
||||
# Android package name to use when compiling the public chrome targets
|
||||
# (chrome_public_apk, trichrome_chrome_bundle, etc. as well as the
|
||||
# *_bundle variants). This defaults to the Chromium browser package name.
|
||||
- chrome_public_manifest_package = "org.chromium.chrome"
|
||||
+ chrome_public_manifest_package = "org.bromite.bromite"
|
||||
if (use_stable_package_name_for_trichrome) {
|
||||
|
||||
@@ -21,16 +21,16 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../java/res/xml/adblock_preferences.xml | 25 ++
|
||||
.../android/java/res/xml/main_preferences.xml | 5 +
|
||||
.../browser/settings/AdBlockEditor.java | 91 ++++++
|
||||
.../browser/settings/AdBlockPreferences.java | 74 +++++
|
||||
.../browser/settings/AdBlockPreferences.java | 76 +++++
|
||||
.../browser/settings/SettingsActivity.java | 3 +
|
||||
chrome/app/generated_resources.grd | 10 +
|
||||
chrome/browser/after_startup_task_utils.cc | 4 +
|
||||
chrome/browser/browser_process.h | 6 +
|
||||
chrome/browser/browser_process_impl.cc | 28 ++
|
||||
chrome/browser/after_startup_task_utils.cc | 5 +
|
||||
chrome/browser/browser_process.h | 5 +
|
||||
chrome/browser/browser_process_impl.cc | 30 ++
|
||||
chrome/browser/browser_process_impl.h | 2 +
|
||||
chrome/browser/chrome_browser_main.cc | 3 +
|
||||
chrome/browser/flags/BUILD.gn | 3 +
|
||||
.../flags/android/adblock_native_gateway.cc | 31 ++
|
||||
.../flags/android/adblock_native_gateway.cc | 33 ++
|
||||
.../browser/flags/AdBlockNativeGateway.java | 30 ++
|
||||
.../net/system_network_context_manager.cc | 4 +
|
||||
.../strings/android_chrome_strings.grd | 14 +
|
||||
@@ -43,14 +43,14 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../component_updater/download_filters_task.h | 129 ++++++++
|
||||
...ent_subresource_filter_throttle_manager.cc | 15 +
|
||||
...tent_subresource_filter_throttle_manager.h | 2 +
|
||||
.../content/shared/browser/ruleset_service.cc | 44 ++-
|
||||
.../content/shared/browser/ruleset_service.h | 8 +-
|
||||
.../content/browser/ruleset_service.cc | 44 ++-
|
||||
.../content/browser/ruleset_service.h | 8 +-
|
||||
.../unindexed_ruleset_stream_generator.cc | 3 +
|
||||
.../core/browser/ruleset_version.h | 4 +
|
||||
.../browser/subresource_filter_features.cc | 118 +-------
|
||||
.../core/browser/verified_ruleset_dealer.cc | 4 +
|
||||
.../core/common/indexed_ruleset.cc | 5 +-
|
||||
38 files changed, 1282 insertions(+), 127 deletions(-)
|
||||
38 files changed, 1288 insertions(+), 127 deletions(-)
|
||||
create mode 100644 chrome/android/java/res/layout/adblock_editor.xml
|
||||
create mode 100644 chrome/android/java/res/xml/adblock_preferences.xml
|
||||
create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java
|
||||
@@ -65,7 +65,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
||||
--- a/chrome/android/BUILD.gn
|
||||
+++ b/chrome/android/BUILD.gn
|
||||
@@ -302,6 +302,7 @@ if (_is_default_toolchain) {
|
||||
@@ -318,6 +318,7 @@ if (_is_default_toolchain) {
|
||||
"//chrome/android/features/tab_ui/public:ui_java_resources",
|
||||
"//chrome/android/modules/stack_unwinder/provider:java",
|
||||
"//chrome/android/webapk/libs/client:client_java",
|
||||
@@ -76,7 +76,7 @@ diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
||||
diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_java_resources.gni
|
||||
--- a/chrome/android/chrome_java_resources.gni
|
||||
+++ b/chrome/android/chrome_java_resources.gni
|
||||
@@ -453,6 +453,7 @@ chrome_java_resources = [
|
||||
@@ -432,6 +432,7 @@ chrome_java_resources = [
|
||||
"java/res/layout/account_management_account_row.xml",
|
||||
"java/res/layout/app_history_filter.xml",
|
||||
"java/res/layout/auto_pip_permission_dialog.xml",
|
||||
@@ -84,7 +84,7 @@ diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_ja
|
||||
"java/res/layout/auto_sign_in_first_run_dialog.xml",
|
||||
"java/res/layout/autofill_billing_address_dropdown.xml",
|
||||
"java/res/layout/autofill_card_name_and_number.xml",
|
||||
@@ -658,6 +659,7 @@ chrome_java_resources = [
|
||||
@@ -638,6 +639,7 @@ chrome_java_resources = [
|
||||
"java/res/xml/account_management_preferences.xml",
|
||||
"java/res/xml/ad_services_config.xml",
|
||||
"java/res/xml/appearance_preferences.xml",
|
||||
@@ -95,7 +95,7 @@ diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_ja
|
||||
diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
|
||||
--- a/chrome/android/chrome_java_sources.gni
|
||||
+++ b/chrome/android/chrome_java_sources.gni
|
||||
@@ -942,6 +942,8 @@ chrome_java_sources = [
|
||||
@@ -977,6 +977,8 @@ chrome_java_sources = [
|
||||
"java/src/org/chromium/chrome/browser/permissions/PermissionBlockedDialog.java",
|
||||
"java/src/org/chromium/chrome/browser/permissions/PermissionUpdateRequester.java",
|
||||
"java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceImpl.java",
|
||||
@@ -179,7 +179,7 @@ new file mode 100644
|
||||
diff --git a/chrome/android/java/res/values/styles.xml b/chrome/android/java/res/values/styles.xml
|
||||
--- a/chrome/android/java/res/values/styles.xml
|
||||
+++ b/chrome/android/java/res/values/styles.xml
|
||||
@@ -331,6 +331,24 @@ found in the LICENSE file.
|
||||
@@ -339,6 +339,24 @@ found in the LICENSE file.
|
||||
</item>
|
||||
</style>
|
||||
|
||||
@@ -251,7 +251,7 @@ new file mode 100644
|
||||
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/main_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
||||
@@ -111,6 +111,11 @@ found in the LICENSE file.
|
||||
@@ -113,6 +113,11 @@ found in the LICENSE file.
|
||||
android:key="toolbar_shortcut"
|
||||
android:order="21"
|
||||
android:title="@string/toolbar_shortcut"/>
|
||||
@@ -363,7 +363,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBloc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java
|
||||
@@ -0,0 +1,74 @@
|
||||
@@ -0,0 +1,76 @@
|
||||
+// Copyright 2015 The Chromium Authors. All rights reserved.
|
||||
+// Use of this source code is governed by a BSD-style license that can be
|
||||
+// found in the LICENSE file.
|
||||
@@ -374,8 +374,9 @@ new file mode 100644
|
||||
+import androidx.preference.Preference;
|
||||
+import androidx.preference.PreferenceFragmentCompat;
|
||||
+
|
||||
+import org.chromium.base.supplier.ObservableSupplier;
|
||||
+import org.chromium.base.supplier.ObservableSupplierImpl;
|
||||
+import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
+import org.chromium.base.supplier.ObservableSuppliers;
|
||||
+import org.chromium.base.supplier.SettableMonotonicObservableSupplier;
|
||||
+import java.util.function.Supplier;
|
||||
+
|
||||
+import org.chromium.content_public.browser.BrowserContextHandle;
|
||||
@@ -398,10 +399,11 @@ new file mode 100644
|
||||
+ private static final String PREF_ADBLOCK_EDIT = "adblock_edit";
|
||||
+
|
||||
+ private Preference mAdBlockEdit;
|
||||
+ private final ObservableSupplierImpl<String> mPageTitle = new ObservableSupplierImpl<>();
|
||||
+ private final SettableMonotonicObservableSupplier<String> mPageTitle =
|
||||
+ ObservableSuppliers.createMonotonic();
|
||||
+
|
||||
+ @Override
|
||||
+ public ObservableSupplier<String> getPageTitle() {
|
||||
+ public MonotonicObservableSupplier<String> getPageTitle() {
|
||||
+ return mPageTitle;
|
||||
+ }
|
||||
+
|
||||
@@ -441,7 +443,7 @@ new file mode 100644
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
|
||||
@@ -95,6 +95,8 @@ import java.util.HashMap;
|
||||
@@ -106,6 +106,8 @@ import java.util.HashMap;
|
||||
import java.util.Locale;
|
||||
import java.util.Map;
|
||||
|
||||
@@ -450,7 +452,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/Settin
|
||||
/**
|
||||
* The Chrome settings activity.
|
||||
*
|
||||
@@ -1175,6 +1177,7 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
@@ -1325,6 +1327,7 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
|
||||
&& !MAIN_FRAGMENT_TAG.equals(fragment.getTag())) {
|
||||
return;
|
||||
}
|
||||
@@ -461,7 +463,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/Settin
|
||||
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
|
||||
--- a/chrome/app/generated_resources.grd
|
||||
+++ b/chrome/app/generated_resources.grd
|
||||
@@ -17395,6 +17395,16 @@ Please help our engineers fix this problem. Tell us what happened right before y
|
||||
@@ -17715,6 +17715,16 @@ Please help our engineers fix this problem. Tell us what happened right before y
|
||||
Never show this again.
|
||||
</message>
|
||||
|
||||
@@ -481,16 +483,17 @@ diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources
|
||||
diff --git a/chrome/browser/after_startup_task_utils.cc b/chrome/browser/after_startup_task_utils.cc
|
||||
--- a/chrome/browser/after_startup_task_utils.cc
|
||||
+++ b/chrome/browser/after_startup_task_utils.cc
|
||||
@@ -24,6 +24,8 @@
|
||||
@@ -24,6 +24,9 @@
|
||||
#include "chrome/browser/ui/ash/login/login_display_host.h"
|
||||
#endif
|
||||
|
||||
+#include "chrome/browser/browser_process.h"
|
||||
+#include "components/component_updater/adblock_updater_service.h"
|
||||
+
|
||||
using content::BrowserThread;
|
||||
|
||||
namespace {
|
||||
@@ -129,6 +131,8 @@ void SetBrowserStartupIsComplete() {
|
||||
@@ -129,6 +132,8 @@ void SetBrowserStartupIsComplete() {
|
||||
}
|
||||
GetAfterStartupTasks().clear();
|
||||
GetAfterStartupTasks().shrink_to_fit();
|
||||
@@ -502,15 +505,7 @@ diff --git a/chrome/browser/after_startup_task_utils.cc b/chrome/browser/after_s
|
||||
diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
|
||||
--- a/chrome/browser/browser_process.h
|
||||
+++ b/chrome/browser/browser_process.h
|
||||
@@ -31,6 +31,7 @@
|
||||
#include "chrome/common/buildflags.h"
|
||||
#include "components/safe_browsing/buildflags.h"
|
||||
#include "media/media_buildflags.h"
|
||||
+#include "components/component_updater/adblock_updater_service.h"
|
||||
|
||||
class BackgroundModeManager;
|
||||
class BrowserProcessPlatformPart;
|
||||
@@ -88,6 +89,10 @@ namespace component_updater {
|
||||
@@ -96,6 +96,10 @@ namespace component_updater {
|
||||
class ComponentUpdateService;
|
||||
}
|
||||
|
||||
@@ -521,18 +516,27 @@ diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
|
||||
namespace gcm {
|
||||
class GCMDriver;
|
||||
}
|
||||
@@ -276,6 +281,7 @@ class BrowserProcess {
|
||||
#endif
|
||||
@@ -294,6 +298,7 @@ class BrowserProcess {
|
||||
virtual activity_reporter::ActivityReporter* activity_reporter() = 0;
|
||||
|
||||
virtual component_updater::ComponentUpdateService* component_updater() = 0;
|
||||
+ virtual adblock_updater::AdBlockUpdaterService* adblock_updater() = 0;
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
virtual MediaFileSystemRegistry* media_file_system_registry() = 0;
|
||||
|
||||
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
|
||||
--- a/chrome/browser/browser_process_impl.cc
|
||||
+++ b/chrome/browser/browser_process_impl.cc
|
||||
@@ -1284,6 +1284,34 @@ BrowserProcessImpl::component_updater() {
|
||||
@@ -184,6 +184,8 @@
|
||||
#include "ui/message_center/message_center.h"
|
||||
#endif
|
||||
|
||||
+#include "components/component_updater/adblock_updater_service.h"
|
||||
+
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
#include "chrome/browser/accessibility/accessibility_prefs/android/accessibility_prefs_controller.h"
|
||||
#include "chrome/browser/flags/android/chrome_feature_list.h"
|
||||
@@ -1375,6 +1377,34 @@ BrowserProcessImpl::component_updater() {
|
||||
return component_updater_.get();
|
||||
}
|
||||
|
||||
@@ -565,20 +569,20 @@ diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_pro
|
||||
+}
|
||||
+
|
||||
void BrowserProcessImpl::OnKeepAliveStateChanged(bool is_keeping_alive) {
|
||||
if (is_keeping_alive)
|
||||
if (is_keeping_alive) {
|
||||
Pin();
|
||||
diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h
|
||||
--- a/chrome/browser/browser_process_impl.h
|
||||
+++ b/chrome/browser/browser_process_impl.h
|
||||
@@ -213,6 +213,7 @@ class BrowserProcessImpl : public BrowserProcess,
|
||||
#endif
|
||||
@@ -220,6 +220,7 @@ class BrowserProcessImpl : public BrowserProcess,
|
||||
|
||||
activity_reporter::ActivityReporter* activity_reporter() override;
|
||||
component_updater::ComponentUpdateService* component_updater() override;
|
||||
+ adblock_updater::AdBlockUpdaterService* adblock_updater() override;
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
MediaFileSystemRegistry* media_file_system_registry() override;
|
||||
WebRtcLogUploader* webrtc_log_uploader() override;
|
||||
network_time::NetworkTimeTracker* network_time_tracker() override;
|
||||
@@ -426,6 +427,7 @@ class BrowserProcessImpl : public BrowserProcess,
|
||||
#endif
|
||||
@@ -439,6 +440,7 @@ class BrowserProcessImpl : public BrowserProcess,
|
||||
// to concerns over integrity of data shared between profiles,
|
||||
// but some users of component updater only install per-user.
|
||||
std::unique_ptr<component_updater::ComponentUpdateService> component_updater_;
|
||||
@@ -589,7 +593,7 @@ diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_proc
|
||||
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
|
||||
--- a/chrome/browser/chrome_browser_main.cc
|
||||
+++ b/chrome/browser/chrome_browser_main.cc
|
||||
@@ -430,6 +430,9 @@ StartupProfileInfo CreateInitialProfile(
|
||||
@@ -439,6 +439,9 @@ StartupProfileInfo CreateInitialProfile(
|
||||
// missing code in the above test.
|
||||
CHECK(profile_info.profile) << "Cannot get default profile.";
|
||||
|
||||
@@ -630,7 +634,7 @@ diff --git a/chrome/browser/flags/android/adblock_native_gateway.cc b/chrome/bro
|
||||
new file mode 100755
|
||||
--- /dev/null
|
||||
+++ b/chrome/browser/flags/android/adblock_native_gateway.cc
|
||||
@@ -0,0 +1,31 @@
|
||||
@@ -0,0 +1,33 @@
|
||||
+#include "chrome/browser/flags/jni_headers/AdBlockNativeGateway_jni.h"
|
||||
+
|
||||
+#include "base/android/jni_string.h"
|
||||
@@ -639,7 +643,7 @@ new file mode 100755
|
||||
+#include "components/prefs/pref_service.h"
|
||||
+
|
||||
+using base::android::ScopedJavaLocalRef;
|
||||
+using base::android::JavaParamRef;
|
||||
+using base::android::JavaRef;
|
||||
+
|
||||
+static ScopedJavaLocalRef<jstring> JNI_AdBlockNativeGateway_GetAdBlockFiltersURL(
|
||||
+ JNIEnv* env) {
|
||||
@@ -648,20 +652,22 @@ new file mode 100755
|
||||
+}
|
||||
+
|
||||
+static void JNI_AdBlockNativeGateway_SetAdBlockFiltersURL(
|
||||
+ JNIEnv* env, const JavaParamRef<jstring>& url) {
|
||||
+ JNIEnv* env, const JavaRef<jstring>& url) {
|
||||
+ g_browser_process->local_state()->SetString(prefs::kAdBlockFiltersURL,
|
||||
+ base::android::ConvertJavaStringToUTF8(env, url));
|
||||
+}
|
||||
+
|
||||
+static jboolean JNI_AdBlockNativeGateway_GetAdBlockEnabled(
|
||||
+static bool JNI_AdBlockNativeGateway_GetAdBlockEnabled(
|
||||
+ JNIEnv* env) {
|
||||
+ return g_browser_process->local_state()->GetBoolean(prefs::kAdBlockEnabled);
|
||||
+}
|
||||
+
|
||||
+static void JNI_AdBlockNativeGateway_SetAdBlockEnabled(
|
||||
+ JNIEnv* env, jboolean enabled) {
|
||||
+ JNIEnv* env, bool enabled) {
|
||||
+ g_browser_process->local_state()->SetBoolean(prefs::kAdBlockEnabled, enabled);
|
||||
+}
|
||||
+
|
||||
+DEFINE_JNI(AdBlockNativeGateway)
|
||||
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/AdBlockNativeGateway.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/AdBlockNativeGateway.java
|
||||
new file mode 100755
|
||||
--- /dev/null
|
||||
@@ -690,7 +696,7 @@ new file mode 100755
|
||||
+ }
|
||||
+
|
||||
+ @NativeMethods
|
||||
+ interface Natives {
|
||||
+ public interface Natives {
|
||||
+ void setAdBlockFiltersURL(String url);
|
||||
+ String getAdBlockFiltersURL();
|
||||
+ void setAdBlockEnabled(boolean enabled);
|
||||
@@ -700,7 +706,7 @@ new file mode 100755
|
||||
diff --git a/chrome/browser/net/system_network_context_manager.cc b/chrome/browser/net/system_network_context_manager.cc
|
||||
--- a/chrome/browser/net/system_network_context_manager.cc
|
||||
+++ b/chrome/browser/net/system_network_context_manager.cc
|
||||
@@ -716,6 +716,10 @@ void SystemNetworkContextManager::RegisterPrefs(PrefRegistrySimple* registry) {
|
||||
@@ -718,6 +718,10 @@ void SystemNetworkContextManager::RegisterPrefs(PrefRegistrySimple* registry) {
|
||||
DefaultDnsOverHttpsConfigSource::RegisterPrefs(registry);
|
||||
NetworkProcessLaunchWatcher::RegisterPrefs(registry);
|
||||
|
||||
@@ -714,7 +720,7 @@ diff --git a/chrome/browser/net/system_network_context_manager.cc b/chrome/brows
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -236,6 +236,20 @@ CHAR_LIMIT guidelines:
|
||||
@@ -239,6 +239,20 @@ CHAR_LIMIT guidelines:
|
||||
Try searching the help center
|
||||
</message>
|
||||
|
||||
@@ -738,7 +744,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
|
||||
--- a/chrome/common/pref_names.h
|
||||
+++ b/chrome/common/pref_names.h
|
||||
@@ -2979,6 +2979,11 @@ inline constexpr char kAudioCaptureAllowed[] = "hardware.audio_capture_enabled";
|
||||
@@ -2778,6 +2778,11 @@ inline constexpr char kAudioCaptureAllowed[] = "hardware.audio_capture_enabled";
|
||||
inline constexpr char kAudioCaptureAllowedUrls[] =
|
||||
"hardware.audio_capture_allowed_urls";
|
||||
|
||||
@@ -753,7 +759,7 @@ diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
|
||||
diff --git a/components/browser_ui/strings/android/site_settings.grdp b/components/browser_ui/strings/android/site_settings.grdp
|
||||
--- a/components/browser_ui/strings/android/site_settings.grdp
|
||||
+++ b/components/browser_ui/strings/android/site_settings.grdp
|
||||
@@ -424,6 +424,9 @@
|
||||
@@ -421,6 +421,9 @@
|
||||
<message name="IDS_INTRUSIVE_ADS_INFORMATION" desc="The extra information at the top of the Site Details page when the site tends to show intrusive ads">
|
||||
This site shows intrusive or misleading ads
|
||||
</message>
|
||||
@@ -1115,7 +1121,7 @@ new file mode 100644
|
||||
+#include "components/component_updater/update_scheduler.h"
|
||||
+#include "url/gurl.h"
|
||||
+#include "components/component_updater/download_filters_task.h"
|
||||
+#include "components/subresource_filter/content/shared/browser/ruleset_service.h"
|
||||
+#include "components/subresource_filter/content/browser/ruleset_service.h"
|
||||
+#include "services/network/public/cpp/shared_url_loader_factory.h"
|
||||
+
|
||||
+namespace adblock_updater {
|
||||
@@ -1577,17 +1583,18 @@ new file mode 100644
|
||||
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
|
||||
--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
|
||||
+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
|
||||
@@ -18,6 +18,9 @@
|
||||
@@ -17,7 +17,10 @@
|
||||
#include "base/trace_event/trace_event.h"
|
||||
#include "base/trace_event/traced_value.h"
|
||||
#include "base/tracing/protos/chrome_track_event.pbzero.h"
|
||||
+#include "components/content_settings/core/common/content_settings_types.h"
|
||||
#include "components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.h"
|
||||
+#include "components/subresource_filter/content/browser/subresource_filter_content_settings_manager.h"
|
||||
+#include "components/subresource_filter/content/browser/subresource_filter_profile_context.h"
|
||||
#include "components/subresource_filter/content/browser/ad_tagging_utils.h"
|
||||
#include "components/subresource_filter/content/browser/content_subresource_filter_web_contents_helper.h"
|
||||
#include "components/subresource_filter/content/browser/profile_interaction_manager.h"
|
||||
@@ -114,6 +117,7 @@ ContentSubresourceFilterThrottleManager::
|
||||
#include "components/subresource_filter/content/browser/page_load_statistics.h"
|
||||
@@ -113,6 +116,7 @@ ContentSubresourceFilterThrottleManager::
|
||||
profile_interaction_manager_(
|
||||
std::make_unique<subresource_filter::ProfileInteractionManager>(
|
||||
profile_context)),
|
||||
@@ -1595,7 +1602,7 @@ diff --git a/components/subresource_filter/content/browser/content_subresource_f
|
||||
web_contents_helper_(web_contents_helper) {}
|
||||
|
||||
ContentSubresourceFilterThrottleManager::
|
||||
@@ -661,6 +665,17 @@ ContentSubresourceFilterThrottleManager::
|
||||
@@ -659,6 +663,17 @@ ContentSubresourceFilterThrottleManager::
|
||||
throttle->NotifyPageActivationWithRuleset(EnsureRulesetHandle(),
|
||||
ad_tagging_state);
|
||||
}
|
||||
@@ -1625,9 +1632,9 @@ diff --git a/components/subresource_filter/content/browser/content_subresource_f
|
||||
// Unowned since the throttle manager cannot outlive the Page that owns it.
|
||||
// The throttle manager is held as user data first on NavigationHandle, then
|
||||
// transferred to Page once it is created. Once the Page is created and this
|
||||
diff --git a/components/subresource_filter/content/shared/browser/ruleset_service.cc b/components/subresource_filter/content/shared/browser/ruleset_service.cc
|
||||
--- a/components/subresource_filter/content/shared/browser/ruleset_service.cc
|
||||
+++ b/components/subresource_filter/content/shared/browser/ruleset_service.cc
|
||||
diff --git a/components/subresource_filter/content/browser/ruleset_service.cc b/components/subresource_filter/content/browser/ruleset_service.cc
|
||||
--- a/components/subresource_filter/content/browser/ruleset_service.cc
|
||||
+++ b/components/subresource_filter/content/browser/ruleset_service.cc
|
||||
@@ -50,12 +50,7 @@ namespace {
|
||||
void RecordIndexAndWriteRulesetResult(
|
||||
std::string_view uma_tag,
|
||||
@@ -1759,9 +1766,9 @@ diff --git a/components/subresource_filter/content/shared/browser/ruleset_servic
|
||||
if (!version.IsValid()) {
|
||||
return;
|
||||
}
|
||||
diff --git a/components/subresource_filter/content/shared/browser/ruleset_service.h b/components/subresource_filter/content/shared/browser/ruleset_service.h
|
||||
--- a/components/subresource_filter/content/shared/browser/ruleset_service.h
|
||||
+++ b/components/subresource_filter/content/shared/browser/ruleset_service.h
|
||||
diff --git a/components/subresource_filter/content/browser/ruleset_service.h b/components/subresource_filter/content/browser/ruleset_service.h
|
||||
--- a/components/subresource_filter/content/browser/ruleset_service.h
|
||||
+++ b/components/subresource_filter/content/browser/ruleset_service.h
|
||||
@@ -183,7 +183,7 @@ class RulesetService {
|
||||
//
|
||||
// Virtual so that it can be mocked out in tests.
|
||||
@@ -1784,9 +1791,9 @@ diff --git a/components/subresource_filter/content/shared/browser/ruleset_servic
|
||||
// Reads the rules via the |unindexed_ruleset_stream_generator|, and indexes
|
||||
// them using |indexer|. Returns whether the entire ruleset could be parsed.
|
||||
static bool IndexRuleset(
|
||||
diff --git a/components/subresource_filter/content/shared/browser/unindexed_ruleset_stream_generator.cc b/components/subresource_filter/content/shared/browser/unindexed_ruleset_stream_generator.cc
|
||||
--- a/components/subresource_filter/content/shared/browser/unindexed_ruleset_stream_generator.cc
|
||||
+++ b/components/subresource_filter/content/shared/browser/unindexed_ruleset_stream_generator.cc
|
||||
diff --git a/components/subresource_filter/content/browser/unindexed_ruleset_stream_generator.cc b/components/subresource_filter/content/browser/unindexed_ruleset_stream_generator.cc
|
||||
--- a/components/subresource_filter/content/browser/unindexed_ruleset_stream_generator.cc
|
||||
+++ b/components/subresource_filter/content/browser/unindexed_ruleset_stream_generator.cc
|
||||
@@ -12,6 +12,7 @@
|
||||
#include "third_party/protobuf/src/google/protobuf/io/zero_copy_stream_impl.h"
|
||||
#include "third_party/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite.h"
|
||||
@@ -1821,7 +1828,7 @@ diff --git a/components/subresource_filter/core/browser/ruleset_version.h b/comp
|
||||
diff --git a/components/subresource_filter/core/browser/subresource_filter_features.cc b/components/subresource_filter/core/browser/subresource_filter_features.cc
|
||||
--- a/components/subresource_filter/core/browser/subresource_filter_features.cc
|
||||
+++ b/components/subresource_filter/core/browser/subresource_filter_features.cc
|
||||
@@ -55,75 +55,8 @@ class CommaSeparatedStrings {
|
||||
@@ -54,75 +54,8 @@ class CommaSeparatedStrings {
|
||||
const std::vector<std::string_view> pieces_;
|
||||
};
|
||||
|
||||
@@ -1898,7 +1905,7 @@ diff --git a/components/subresource_filter/core/browser/subresource_filter_featu
|
||||
// If ad tagging is enabled, turn on the dryrun automatically.
|
||||
bool ad_tagging_enabled = base::FeatureList::IsEnabled(kAdTagging);
|
||||
const struct {
|
||||
@@ -131,23 +64,16 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
|
||||
@@ -130,23 +63,16 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
|
||||
bool enabled_by_default;
|
||||
Configuration (*factory_method)();
|
||||
} kAvailablePresetConfigurations[] = {
|
||||
@@ -1924,7 +1931,7 @@ diff --git a/components/subresource_filter/core/browser/subresource_filter_featu
|
||||
enabled_configurations.push_back(available_preset.factory_method());
|
||||
}
|
||||
}
|
||||
@@ -155,48 +81,12 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
|
||||
@@ -154,48 +80,12 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
|
||||
return enabled_configurations;
|
||||
}
|
||||
|
||||
|
||||
@@ -15,7 +15,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/browser/ui/views/toolbar/reload_button.cc b/chrome/browser/ui/views/toolbar/reload_button.cc
|
||||
--- a/chrome/browser/ui/views/toolbar/reload_button.cc
|
||||
+++ b/chrome/browser/ui/views/toolbar/reload_button.cc
|
||||
@@ -276,6 +276,14 @@ void ReloadButton::ButtonPressed(const ui::Event& event) {
|
||||
@@ -284,6 +284,14 @@ void ReloadButton::ButtonPressed(const ui::Event& event) {
|
||||
command = IDC_RELOAD;
|
||||
}
|
||||
|
||||
@@ -33,7 +33,7 @@ diff --git a/chrome/browser/ui/views/toolbar/reload_button.cc b/chrome/browser/u
|
||||
diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h
|
||||
--- a/ui/views/widget/widget.h
|
||||
+++ b/ui/views/widget/widget.h
|
||||
@@ -1468,6 +1468,19 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
@@ -1481,6 +1481,19 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
// initialized.
|
||||
void SaveWindowPlacementIfNeeded();
|
||||
|
||||
@@ -53,7 +53,7 @@ diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h
|
||||
protected:
|
||||
// Creates the RootView to be used within this Widget. Subclasses may override
|
||||
// to create custom RootViews that do specialized event processing.
|
||||
@@ -1508,13 +1521,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
@@ -1521,13 +1534,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
void set_widget_closed() { widget_closed_ = true; }
|
||||
|
||||
private:
|
||||
@@ -67,7 +67,7 @@ diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h
|
||||
class PaintAsActiveLockImpl;
|
||||
|
||||
friend class ButtonTest;
|
||||
@@ -1525,11 +1531,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
@@ -1538,11 +1544,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
||||
friend class ui_devtools::BubbleLocking;
|
||||
friend void DisableActivationChangeHandlingForTests();
|
||||
|
||||
|
||||
@@ -8,15 +8,15 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../settings/site_settings/popups_page.html | 2 +
|
||||
.../tab_under_navigation_throttle.cc | 11 +-
|
||||
.../android/popup_blocked_message_delegate.cc | 20 +++-
|
||||
.../android/popup_blocked_message_delegate.cc | 20 ++-
|
||||
.../android/popup_blocked_message_delegate.h | 1 +
|
||||
components/blocked_content/popup_blocker.cc | 3 +
|
||||
components/blocked_content_strings.grdp | 3 +
|
||||
.../impl/BromitePopupContentSetting.java | 106 ++++++++++++++++++
|
||||
.../impl/BromitePopupContentSetting.java | 115 ++++++++++++++++++
|
||||
.../bromite_content_settings/popups.grdp | 18 +++
|
||||
.../bromite_content_settings/popups.inc | 13 +++
|
||||
.../bromite_content_settings/popups.inc | 13 ++
|
||||
.../core/browser/content_settings_registry.cc | 2 +-
|
||||
10 files changed, 173 insertions(+), 6 deletions(-)
|
||||
10 files changed, 182 insertions(+), 6 deletions(-)
|
||||
create mode 100644 components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/impl/BromitePopupContentSetting.java
|
||||
create mode 100644 components/browser_ui/strings/bromite_content_settings/popups.grdp
|
||||
create mode 100644 components/content_settings/core/browser/bromite_content_settings/popups.inc
|
||||
@@ -146,7 +146,7 @@ diff --git a/components/browser_ui/site_settings/android/java/src/org/chromium/c
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/impl/BromitePopupContentSetting.java
|
||||
@@ -0,0 +1,106 @@
|
||||
@@ -0,0 +1,115 @@
|
||||
+/*
|
||||
+ This file is part of Bromite.
|
||||
+
|
||||
@@ -239,6 +239,15 @@ new file mode 100644
|
||||
+ }
|
||||
+
|
||||
+ @Override
|
||||
+ public int[] getTriStateSettingIconIDs() {
|
||||
+ return new int[] {
|
||||
+ R.drawable.permission_popups,
|
||||
+ R.drawable.permission_popups,
|
||||
+ R.drawable.sensors_off_24px
|
||||
+ };
|
||||
+ }
|
||||
+
|
||||
+ @Override
|
||||
+ public boolean showOnlyDescriptions() {
|
||||
+ return true;
|
||||
+ }
|
||||
@@ -297,7 +306,7 @@ new file mode 100644
|
||||
diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
--- a/components/content_settings/core/browser/content_settings_registry.cc
|
||||
+++ b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
@@ -140,7 +140,7 @@ void ContentSettingsRegistry::Init() {
|
||||
@@ -139,7 +139,7 @@ void ContentSettingsRegistry::Init() {
|
||||
WebsiteSettingsInfo::SYNCABLE,
|
||||
/*allowlisted_primary_schemes=*/
|
||||
{kChromeUIScheme, kChromeDevToolsScheme, kExtensionScheme},
|
||||
|
||||
@@ -16,9 +16,9 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
chrome/app/extensions_strings.grdp | 6 ++
|
||||
.../developer_private_api.cc | 28 +++++++++
|
||||
.../developer_private/developer_private_api.h | 3 +
|
||||
.../developer_private_functions_shared.cc | 8 ++-
|
||||
.../developer_private_functions.cc | 8 ++-
|
||||
.../profile_info_generator.cc | 3 +
|
||||
.../webstore_private/webstore_private_api.cc | 15 ++++-
|
||||
.../webstore_private/webstore_private_api.cc | 14 ++++-
|
||||
.../extensions/chrome_extension_system.cc | 1 +
|
||||
.../extensions/cws_info_service_factory.cc | 3 +-
|
||||
.../extensions/extension_management.cc | 1 +
|
||||
@@ -49,13 +49,13 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
extensions/common/extension_features.cc | 7 +++
|
||||
extensions/common/extension_features.h | 10 +++
|
||||
.../definitions/developer_private.d.ts | 2 +
|
||||
36 files changed, 254 insertions(+), 107 deletions(-)
|
||||
36 files changed, 253 insertions(+), 107 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Webstore-protection.inc
|
||||
|
||||
diff --git a/chrome/app/extensions_strings.grdp b/chrome/app/extensions_strings.grdp
|
||||
--- a/chrome/app/extensions_strings.grdp
|
||||
+++ b/chrome/app/extensions_strings.grdp
|
||||
@@ -88,6 +88,12 @@
|
||||
@@ -79,6 +79,12 @@
|
||||
<message name="IDS_EXTENSIONS_DISABLED_UNSUPPORTED_DEVELOPER_MODE_TOAST" desc="Text displayed in a toast popup message when extensions are disabled due to unsupported developer mode.">
|
||||
Developer Mode Off. Some extensions were disabled.
|
||||
</message>
|
||||
@@ -84,7 +84,7 @@ diff --git a/chrome/browser/extensions/api/developer_private/developer_private_a
|
||||
namespace extensions {
|
||||
|
||||
namespace developer = api::developer_private;
|
||||
@@ -69,6 +75,28 @@ DeveloperPrivateAPI::GetFactoryInstance() {
|
||||
@@ -70,6 +76,28 @@ DeveloperPrivateAPI::GetFactoryInstance() {
|
||||
return g_developer_private_api_factory.Pointer();
|
||||
}
|
||||
|
||||
@@ -126,10 +126,10 @@ diff --git a/chrome/browser/extensions/api/developer_private/developer_private_a
|
||||
// Convenience method to get the DeveloperPrivateAPI for a profile.
|
||||
static DeveloperPrivateAPI* Get(content::BrowserContext* context);
|
||||
|
||||
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc b/chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc
|
||||
--- a/chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc
|
||||
+++ b/chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc
|
||||
@@ -375,6 +375,7 @@ ExtensionFunction::ResponseAction DeveloperPrivateAutoUpdateFunction::Run() {
|
||||
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_functions.cc b/chrome/browser/extensions/api/developer_private/developer_private_functions.cc
|
||||
--- a/chrome/browser/extensions/api/developer_private/developer_private_functions.cc
|
||||
+++ b/chrome/browser/extensions/api/developer_private/developer_private_functions.cc
|
||||
@@ -451,6 +451,7 @@ ExtensionFunction::ResponseAction DeveloperPrivateAutoUpdateFunction::Run() {
|
||||
ExtensionUpdater::CheckParams params;
|
||||
params.fetch_priority = DownloadFetchPriority::kForeground;
|
||||
params.install_immediately = true;
|
||||
@@ -137,7 +137,7 @@ diff --git a/chrome/browser/extensions/api/developer_private/developer_private_f
|
||||
params.callback =
|
||||
base::BindOnce(&DeveloperPrivateAutoUpdateFunction::OnComplete, this);
|
||||
updater->CheckNow(std::move(params));
|
||||
@@ -511,7 +512,7 @@ DeveloperPrivateUpdateProfileConfigurationFunction::Run() {
|
||||
@@ -587,7 +588,7 @@ DeveloperPrivateUpdateProfileConfigurationFunction::Run() {
|
||||
|
||||
const developer::ProfileConfigurationUpdate& update = params->update;
|
||||
|
||||
@@ -146,7 +146,7 @@ diff --git a/chrome/browser/extensions/api/developer_private/developer_private_f
|
||||
Profile* profile = Profile::FromBrowserContext(browser_context());
|
||||
CHECK(profile);
|
||||
if (supervised_user::AreExtensionsPermissionsEnabled(profile)) {
|
||||
@@ -525,6 +526,11 @@ DeveloperPrivateUpdateProfileConfigurationFunction::Run() {
|
||||
@@ -601,6 +602,11 @@ DeveloperPrivateUpdateProfileConfigurationFunction::Run() {
|
||||
->MarkNoticeAsAcknowledgedGlobally();
|
||||
}
|
||||
|
||||
@@ -181,15 +181,7 @@ diff --git a/chrome/browser/extensions/api/developer_private/profile_info_genera
|
||||
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
|
||||
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
|
||||
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
|
||||
@@ -68,6 +68,7 @@
|
||||
#include "extensions/browser/scoped_active_install.h"
|
||||
#include "extensions/buildflags/buildflags.h"
|
||||
#include "extensions/common/extension.h"
|
||||
+#include "extensions/common/extension_features.h"
|
||||
#include "extensions/common/manifest.h"
|
||||
#include "extensions/common/manifest_constants.h"
|
||||
#include "extensions/common/manifest_handlers/permissions_parser.h"
|
||||
@@ -242,6 +243,8 @@ Profile* GetProfileInIncognito(Profile* profile) {
|
||||
@@ -254,6 +254,8 @@ Profile* GetProfileInIncognito(Profile* profile) {
|
||||
// there was previously stored data, or an empty string otherwise. The Set will
|
||||
// overwrite any previous login.
|
||||
std::string GetWebstoreLogin(Profile* profile) {
|
||||
@@ -198,7 +190,7 @@ diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api
|
||||
if (profile->GetPrefs()->HasPrefPath(kWebstoreLogin)) {
|
||||
return profile->GetPrefs()->GetString(kWebstoreLogin);
|
||||
}
|
||||
@@ -249,11 +252,15 @@ std::string GetWebstoreLogin(Profile* profile) {
|
||||
@@ -261,11 +263,15 @@ std::string GetWebstoreLogin(Profile* profile) {
|
||||
}
|
||||
|
||||
void SetWebstoreLogin(Profile* profile, const std::string& login) {
|
||||
@@ -214,7 +206,7 @@ diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api
|
||||
switch (status) {
|
||||
case kCanRequest:
|
||||
return api::webstore_private::ExtensionInstallStatus::kCanRequest;
|
||||
@@ -1177,7 +1184,8 @@ ExtensionFunction::ResponseAction
|
||||
@@ -1317,7 +1323,8 @@ ExtensionFunction::ResponseAction
|
||||
WebstorePrivateIsInIncognitoModeFunction::Run() {
|
||||
Profile* profile = Profile::FromBrowserContext(browser_context());
|
||||
return RespondNow(ArgumentList(IsInIncognitoMode::Results::Create(
|
||||
@@ -224,7 +216,7 @@ diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api
|
||||
}
|
||||
|
||||
WebstorePrivateIsPendingCustodianApprovalFunction::
|
||||
@@ -1274,11 +1282,14 @@ WebstorePrivateGetReferrerChainFunction::Run() {
|
||||
@@ -1414,11 +1421,14 @@ WebstorePrivateGetReferrerChainFunction::Run() {
|
||||
request.mutable_referrer_chain_options()->set_recent_navigations_to_collect(
|
||||
recent_navigations_to_collect);
|
||||
|
||||
@@ -243,7 +235,7 @@ diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api
|
||||
diff --git a/chrome/browser/extensions/chrome_extension_system.cc b/chrome/browser/extensions/chrome_extension_system.cc
|
||||
--- a/chrome/browser/extensions/chrome_extension_system.cc
|
||||
+++ b/chrome/browser/extensions/chrome_extension_system.cc
|
||||
@@ -96,6 +96,7 @@ UninstallPingSender::FilterResult ShouldSendUninstallPing(
|
||||
@@ -99,6 +99,7 @@ UninstallPingSender::FilterResult ShouldSendUninstallPing(
|
||||
Profile* profile,
|
||||
const Extension* extension,
|
||||
UninstallReason reason) {
|
||||
@@ -267,7 +259,7 @@ diff --git a/chrome/browser/extensions/cws_info_service_factory.cc b/chrome/brow
|
||||
diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc
|
||||
--- a/chrome/browser/extensions/extension_management.cc
|
||||
+++ b/chrome/browser/extensions/extension_management.cc
|
||||
@@ -436,6 +436,7 @@ bool ExtensionManagement::IsExemptFromMV2DeprecationByPolicy(
|
||||
@@ -435,6 +435,7 @@ bool ExtensionManagement::IsExemptFromMV2DeprecationByPolicy(
|
||||
|
||||
bool ExtensionManagement::IsAllowedByUnpublishedAvailabilityPolicy(
|
||||
const Extension* extension) {
|
||||
@@ -291,7 +283,7 @@ diff --git a/chrome/browser/extensions/extension_safety_check_utils.cc b/chrome/
|
||||
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
|
||||
--- a/chrome/browser/extensions/extension_service.cc
|
||||
+++ b/chrome/browser/extensions/extension_service.cc
|
||||
@@ -247,8 +247,6 @@ ExtensionService::ExtensionService(
|
||||
@@ -249,8 +249,6 @@ ExtensionService::ExtensionService(
|
||||
UpgradeDetector::GetInstance()->AddObserver(this);
|
||||
#endif
|
||||
|
||||
@@ -299,8 +291,8 @@ diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/ext
|
||||
-
|
||||
ExtensionManagementFactory::GetForBrowserContext(profile_)->AddObserver(this);
|
||||
|
||||
if (autoupdate_enabled) {
|
||||
@@ -763,7 +761,7 @@ void ExtensionService::OnExtensionManagementSettingsChanged() {
|
||||
if (auto* extension_install_policy_service =
|
||||
@@ -773,7 +771,7 @@ void ExtensionService::OnExtensionManagementSettingsChanged() {
|
||||
// unpublished extensions should not be enabled. This update allows
|
||||
// unpublished extensions to be disabled sooner rather than waiting till the
|
||||
// next regularly scheduled fetch.
|
||||
@@ -361,7 +353,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
update_check_params->update_info[extension_id] =
|
||||
GetExtensionUpdateData(extension_id);
|
||||
} else if (AddExtensionToDownloader(extension, request_id,
|
||||
@@ -433,6 +439,12 @@ bool ExtensionUpdater::AddExtensionToDownloader(
|
||||
@@ -434,6 +440,12 @@ bool ExtensionUpdater::AddExtensionToDownloader(
|
||||
}
|
||||
|
||||
void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
@@ -374,7 +366,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
CHECK(enabled_);
|
||||
if (params.ids.empty()) {
|
||||
// Checking all extensions. Cancel pending DoCheckSoon() call if there's
|
||||
@@ -450,7 +462,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
@@ -451,7 +463,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
|
||||
int request_id = next_request_id_++;
|
||||
|
||||
@@ -383,17 +375,17 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
if (params.ids.empty()) {
|
||||
NotifyStarted();
|
||||
}
|
||||
@@ -519,7 +531,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
update_check_params.update_info[pending_id] =
|
||||
GetExtensionUpdateData(pending_id);
|
||||
@@ -528,7 +540,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
<< " will be reinstalled with ExtensionDownloader.";
|
||||
}
|
||||
} else if (!Manifest::IsAutoUpdateableLocation(info->install_source())) {
|
||||
- VLOG(2) << "Extension " << pending_id << " is not auto updateable";
|
||||
+ LOG(INFO) << "Extension " << pending_id << " is not auto updateable";
|
||||
continue;
|
||||
}
|
||||
// We have to mark high-priority extensions (such as policy-forced
|
||||
@@ -529,7 +541,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
// See https://crbug.com/904600 and https://crbug.com/965686.
|
||||
@@ -538,7 +550,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
// See https://crbug.com/41425994 and https://crbug.com/41460304.
|
||||
const bool is_high_priority_extension_pending =
|
||||
pending_extension_manager->HasHighPriorityPendingExtension();
|
||||
- if (CanUseUpdateService(pending_id)) {
|
||||
@@ -401,16 +393,16 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
update_check_params.update_info[pending_id] =
|
||||
GetExtensionUpdateData(pending_id);
|
||||
update_check_params.update_info[pending_id].is_corrupt_reinstall =
|
||||
@@ -552,6 +564,8 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
@@ -562,6 +574,8 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
LOG(WARNING) << "Corrupt extension with id " << pending_id
|
||||
<< " will be reinstalled with ExtensionDownloader.";
|
||||
}
|
||||
+ LOG(INFO) << "Extension " << pending_id << " is auto updateable "
|
||||
+ << "from " << info->update_url();
|
||||
} else {
|
||||
InstallStageTracker::Get(profile_)->ReportFailure(
|
||||
pending_id,
|
||||
@@ -564,13 +578,6 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
InstallStageTrackerFactory::GetForBrowserContext(profile_)
|
||||
->ReportFailure(
|
||||
@@ -575,13 +589,6 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
AddToDownloader(®istry_->disabled_extensions(), pending_ids, request_id,
|
||||
params.fetch_priority, &update_check_params);
|
||||
ExtensionSet remotely_disabled_extensions;
|
||||
@@ -424,7 +416,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
AddToDownloader(&remotely_disabled_extensions, pending_ids, request_id,
|
||||
params.fetch_priority, &update_check_params);
|
||||
} else {
|
||||
@@ -578,7 +585,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
@@ -589,7 +596,7 @@ void ExtensionUpdater::CheckNow(CheckParams params) {
|
||||
const Extension* extension =
|
||||
registry_->GetExtensionById(id, ExtensionRegistry::EVERYTHING);
|
||||
if (extension) {
|
||||
@@ -433,8 +425,8 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
update_check_params.update_info[id] = GetExtensionUpdateData(id);
|
||||
} else if (AddExtensionToDownloader(*extension, request_id,
|
||||
params.fetch_priority)) {
|
||||
@@ -722,7 +729,7 @@ void ExtensionUpdater::OnExtensionDownloadFinished(
|
||||
file.extension_id, InstallStageTracker::Stage::INSTALLING);
|
||||
@@ -736,7 +743,7 @@ void ExtensionUpdater::OnExtensionDownloadFinished(
|
||||
InstallStageTracker::Stage::INSTALLING);
|
||||
UpdatePingData(file.extension_id, ping);
|
||||
|
||||
- VLOG(2) << download_url << " written to " << file.path.value();
|
||||
@@ -442,7 +434,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
|
||||
FetchedCRXFile fetched(file, file_ownership_passed, request_ids,
|
||||
std::move(callback));
|
||||
@@ -733,6 +740,7 @@ void ExtensionUpdater::OnExtensionDownloadFinished(
|
||||
@@ -747,6 +754,7 @@ void ExtensionUpdater::OnExtensionDownloadFinished(
|
||||
|
||||
bool ExtensionUpdater::GetPingDataForExtension(const ExtensionId& id,
|
||||
DownloadPingData* ping_data) {
|
||||
@@ -450,7 +442,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
DCHECK(alive_);
|
||||
ping_data->rollcall_days =
|
||||
CalculatePingDaysForExtension(extension_prefs_->LastPingDay(id));
|
||||
@@ -852,7 +860,7 @@ bool ExtensionUpdater::CanUseUpdateService(
|
||||
@@ -865,7 +873,7 @@ bool ExtensionUpdater::CanUseUpdateService(
|
||||
void ExtensionUpdater::InstallCRXFile(FetchedCRXFile crx_file) {
|
||||
std::set<int> request_ids;
|
||||
|
||||
@@ -459,7 +451,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/bro
|
||||
<< crx_file.info.path.value();
|
||||
|
||||
// The delegate is now responsible for cleaning up the temp file at
|
||||
@@ -1061,7 +1069,7 @@ void ExtensionUpdater::NotifyIfFinished(int request_id) {
|
||||
@@ -1075,7 +1083,7 @@ void ExtensionUpdater::NotifyIfFinished(int request_id) {
|
||||
if (!request.in_progress_ids.empty() || request.awaiting_update_service) {
|
||||
return; // This request is not done yet.
|
||||
}
|
||||
@@ -480,7 +472,7 @@ diff --git a/chrome/browser/extensions/updater/extension_updater.h b/chrome/brow
|
||||
// An extension update check can be originated by a user or by a scheduled
|
||||
// task. When the value of |fetch_priority| is FOREGROUND, the update
|
||||
// request was initiated by a user.
|
||||
@@ -397,6 +399,8 @@ class ExtensionUpdater : public KeyedService,
|
||||
@@ -398,6 +400,8 @@ class ExtensionUpdater : public KeyedService,
|
||||
base::TimeDelta frequency_;
|
||||
bool will_check_soon_ = false;
|
||||
|
||||
@@ -504,10 +496,10 @@ diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/brows
|
||||
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
|
||||
--- a/chrome/browser/extensions/webstore_installer.cc
|
||||
+++ b/chrome/browser/extensions/webstore_installer.cc
|
||||
@@ -595,7 +595,7 @@ void WebstoreInstaller::StartDownload(
|
||||
traffic_annotation));
|
||||
@@ -589,7 +589,7 @@ void WebstoreInstaller::StartDownload(
|
||||
render_frame_host->CreateDownloadUrlParameters(download_url_,
|
||||
traffic_annotation);
|
||||
params->set_file_path(file);
|
||||
params->set_initiator(render_frame_host->GetLastCommittedOrigin());
|
||||
- if (controller.GetVisibleEntry()) {
|
||||
+ if ((false) && controller.GetVisibleEntry()) {
|
||||
content::Referrer referrer = content::Referrer::SanitizeForRequest(
|
||||
@@ -527,7 +519,7 @@ diff --git a/chrome/browser/resources/extensions/manager.html.ts b/chrome/browse
|
||||
diff --git a/chrome/browser/resources/extensions/manager.ts b/chrome/browser/resources/extensions/manager.ts
|
||||
--- a/chrome/browser/resources/extensions/manager.ts
|
||||
+++ b/chrome/browser/resources/extensions/manager.ts
|
||||
@@ -146,6 +146,8 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
@@ -143,6 +143,8 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
*/
|
||||
didInitPage_: {type: Boolean},
|
||||
|
||||
@@ -536,7 +528,7 @@ diff --git a/chrome/browser/resources/extensions/manager.ts b/chrome/browser/res
|
||||
narrow_: {type: Boolean},
|
||||
|
||||
showDrawer_: {type: Boolean},
|
||||
@@ -167,6 +169,8 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
@@ -164,6 +166,8 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
accessor inDevMode: boolean = loadTimeData.getBoolean('inDevMode');
|
||||
accessor isMv2DeprecationNoticeDismissed: boolean =
|
||||
loadTimeData.getBoolean('MV2DeprecationNoticeDismissed');
|
||||
@@ -545,7 +537,7 @@ diff --git a/chrome/browser/resources/extensions/manager.ts b/chrome/browser/res
|
||||
accessor showActivityLog: boolean =
|
||||
loadTimeData.getBoolean('showActivityLog');
|
||||
accessor enableEnhancedSiteControls: boolean =
|
||||
@@ -231,6 +235,7 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
@@ -247,6 +251,7 @@ export class ExtensionsManagerElement extends ExtensionsManagerElementBase {
|
||||
this.canLoadUnpacked = profileInfo.canLoadUnpacked;
|
||||
this.isMv2DeprecationNoticeDismissed =
|
||||
profileInfo.isMv2DeprecationNoticeDismissed;
|
||||
@@ -577,7 +569,7 @@ diff --git a/chrome/browser/resources/extensions/toolbar.css b/chrome/browser/re
|
||||
|
||||
+#need-update {
|
||||
+ color: red;
|
||||
+ margin-inline: 0px;
|
||||
+ margin-inline: 0;
|
||||
+}
|
||||
+
|
||||
cr-toolbar {
|
||||
@@ -594,7 +586,7 @@ diff --git a/chrome/browser/resources/extensions/toolbar.html.ts b/chrome/browse
|
||||
+ <span>$i18n{toolbarExtensionUpdateEnabled}
|
||||
+ <span id="need-update" ?hidden="${!this.shouldShowRelaunchDialog}">$i18n{toolbarExtensionUpdateEnabledNeedRestart}</span>
|
||||
+ </span>
|
||||
+ <cr-toggle @change="${this.onExtUpdateEnabledChanged_}" ?checked="${this.isExtUpdateEnabled}">
|
||||
+ <cr-toggle @change="${this.onExtUpdateEnabledChange_}" ?checked="${this.isExtUpdateEnabled}">
|
||||
+ </cr-toggle>
|
||||
+ </div>
|
||||
</cr-toolbar>
|
||||
@@ -653,7 +645,7 @@ diff --git a/chrome/browser/resources/extensions/toolbar.ts b/chrome/browser/res
|
||||
'Options_ToggleDeveloperMode_' + (e.detail ? 'Enabled' : 'Disabled'));
|
||||
}
|
||||
|
||||
+ protected onExtUpdateEnabledChanged_(e: CustomEvent<boolean>) {
|
||||
+ protected onExtUpdateEnabledChange_(e: CustomEvent<boolean>) {
|
||||
+ this.delegate.setExtUpdateEnabled(e.detail);
|
||||
+ this.shouldShowRelaunchDialog = true;
|
||||
+ this.isExtUpdateEnabled = e.detail;
|
||||
@@ -689,7 +681,7 @@ diff --git a/chrome/browser/ui/webui/extensions/extensions_ui.cc b/chrome/browse
|
||||
#include "chrome/browser/extensions/manifest_v2_experiment_manager.h"
|
||||
#include "chrome/browser/extensions/mv2_experiment_stage.h"
|
||||
#include "chrome/browser/extensions/permissions_url_constants.h"
|
||||
@@ -381,6 +382,8 @@ content::WebUIDataSource* CreateAndAddExtensionsSource(Profile* profile,
|
||||
@@ -387,6 +388,8 @@ content::WebUIDataSource* CreateAndAddExtensionsSource(Profile* profile,
|
||||
{"itemSuspiciousInstallLearnMore",
|
||||
IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE_LEARN_MORE},
|
||||
{"toolbarDevMode", IDS_EXTENSIONS_DEVELOPER_MODE},
|
||||
@@ -698,7 +690,7 @@ diff --git a/chrome/browser/ui/webui/extensions/extensions_ui.cc b/chrome/browse
|
||||
{"toolbarLoadUnpacked", IDS_EXTENSIONS_TOOLBAR_LOAD_UNPACKED},
|
||||
{"toolbarLoadUnpackedDone", IDS_EXTENSIONS_TOOLBAR_LOAD_UNPACKED_DONE},
|
||||
{"toolbarPack", IDS_EXTENSIONS_TOOLBAR_PACK},
|
||||
@@ -466,6 +469,10 @@ content::WebUIDataSource* CreateAndAddExtensionsSource(Profile* profile,
|
||||
@@ -472,6 +475,10 @@ content::WebUIDataSource* CreateAndAddExtensionsSource(Profile* profile,
|
||||
"hostPermissionsLearnMoreLink",
|
||||
extension_permissions_constants::kRuntimeHostPermissionsHelpURL);
|
||||
source->AddBoolean(kInDevModeKey, in_dev_mode);
|
||||
@@ -735,7 +727,7 @@ diff --git a/chrome/browser/update_client/chrome_update_query_params_delegate.cc
|
||||
diff --git a/chrome/common/extensions/api/developer_private.idl b/chrome/common/extensions/api/developer_private.idl
|
||||
--- a/chrome/common/extensions/api/developer_private.idl
|
||||
+++ b/chrome/common/extensions/api/developer_private.idl
|
||||
@@ -273,6 +273,7 @@ namespace developerPrivate {
|
||||
@@ -269,6 +269,7 @@ namespace developerPrivate {
|
||||
boolean isIncognitoAvailable;
|
||||
boolean isChildAccount;
|
||||
boolean isMv2DeprecationNoticeDismissed;
|
||||
@@ -743,7 +735,7 @@ diff --git a/chrome/common/extensions/api/developer_private.idl b/chrome/common/
|
||||
};
|
||||
|
||||
dictionary GetExtensionsInfoOptions {
|
||||
@@ -296,6 +297,7 @@ namespace developerPrivate {
|
||||
@@ -292,6 +293,7 @@ namespace developerPrivate {
|
||||
dictionary ProfileConfigurationUpdate {
|
||||
boolean? inDeveloperMode;
|
||||
boolean? isMv2DeprecationNoticeDismissed;
|
||||
@@ -965,7 +957,7 @@ diff --git a/extensions/browser/api/management/management_api.cc b/extensions/br
|
||||
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
|
||||
--- a/extensions/browser/updater/extension_downloader.cc
|
||||
+++ b/extensions/browser/updater/extension_downloader.cc
|
||||
@@ -485,8 +485,8 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
@@ -486,8 +486,8 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
std::vector<std::string_view> id_vector(extension_ids.begin(),
|
||||
extension_ids.end());
|
||||
std::string id_list = base::JoinString(id_vector, ",");
|
||||
@@ -976,7 +968,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
<< (active_request->foreground_check()
|
||||
? kUpdateInteractivityForeground
|
||||
: kUpdateInteractivityBackground);
|
||||
@@ -511,7 +511,7 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
@@ -512,7 +512,7 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
destination: WEBSITE
|
||||
}
|
||||
policy {
|
||||
@@ -985,7 +977,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
cookies_store: "user"
|
||||
setting:
|
||||
"This feature cannot be disabled. It is only enabled when the user "
|
||||
@@ -528,6 +528,7 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
@@ -529,6 +529,7 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
auto resource_request = std::make_unique<network::ResourceRequest>();
|
||||
resource_request->url = active_request->full_url(),
|
||||
resource_request->load_flags = net::LOAD_DISABLE_CACHE;
|
||||
@@ -993,7 +985,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
|
||||
if (active_request->fetch_priority() == DownloadFetchPriority::kForeground) {
|
||||
resource_request->priority = net::MEDIUM;
|
||||
@@ -536,10 +537,6 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
@@ -537,10 +538,6 @@ void ExtensionDownloader::CreateManifestLoader() {
|
||||
// Send traffic-management headers to the webstore, and omit credentials.
|
||||
// https://bugs.chromium.org/p/chromium/issues/detail?id=647516
|
||||
if (extension_urls::IsWebstoreUpdateUrl(active_request->full_url())) {
|
||||
@@ -1004,7 +996,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
resource_request->headers.SetHeader(kUpdateAppIdHeader, id_list);
|
||||
resource_request->headers.SetHeader(
|
||||
kUpdateUpdaterHeader,
|
||||
@@ -824,20 +821,6 @@ void ExtensionDownloader::HandleManifestResults(
|
||||
@@ -825,20 +822,6 @@ void ExtensionDownloader::HandleManifestResults(
|
||||
update.second->info);
|
||||
}
|
||||
|
||||
@@ -1025,7 +1017,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
ExtensionIdSet extension_ids_with_errors;
|
||||
for (const auto& failure : failures)
|
||||
extension_ids_with_errors.insert(failure.first.id);
|
||||
@@ -859,7 +842,7 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
@@ -861,7 +844,7 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
// extensions that have already existed in the system.
|
||||
if (!delegate_->GetExtensionExistingVersion(extension_id,
|
||||
&extension_version)) {
|
||||
@@ -1034,7 +1026,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
return UpdateAvailability::kBadUpdateSpecification;
|
||||
}
|
||||
VLOG(2) << extension_id << " is at '" << extension_version << "'";
|
||||
@@ -870,11 +853,11 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
@@ -872,11 +855,11 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
const std::string& update_version_str = update->version;
|
||||
if (VLOG_IS_ON(2)) {
|
||||
if (update_version_str.empty())
|
||||
@@ -1048,7 +1040,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
<< " latest version is '" << update_version_str << "'";
|
||||
}
|
||||
|
||||
@@ -884,21 +867,21 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
@@ -886,14 +869,14 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
// we don't want it.
|
||||
if (update_version_str.empty()) {
|
||||
// If update manifest doesn't have version number => no update.
|
||||
@@ -1065,15 +1057,16 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
<< update_version_str << "'";
|
||||
continue;
|
||||
}
|
||||
|
||||
const base::Version existing_version(extension_version);
|
||||
if (update_version.CompareTo(existing_version) <= 0) {
|
||||
- VLOG(2) << extension_id << " version is not older than '"
|
||||
+ LOG(INFO) << extension_id << " version is not older than '"
|
||||
<< update_version_str << "'";
|
||||
bool can_rollback =
|
||||
update_version.CompareTo(existing_version) < 0 &&
|
||||
@@ -925,7 +908,9 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
@@ -921,7 +904,7 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
update->browser_min_version)) {
|
||||
// TODO(asargent) - We may want this to show up in the extensions UI
|
||||
// eventually. (http://crbug.com/12547).
|
||||
- DLOG(WARNING) << "Updated version of extension " << extension_id
|
||||
+ LOG(INFO) << "Updated version of extension " << extension_id
|
||||
<< " available, but requires chrome version "
|
||||
<< update->browser_min_version;
|
||||
has_noupdate = true;
|
||||
@@ -929,7 +912,9 @@ ExtensionDownloader::GetUpdateAvailability(
|
||||
}
|
||||
|
||||
// Stop checking as soon as an update for |extension_id| is found.
|
||||
@@ -1084,7 +1077,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
*update_result_out = const_cast<UpdateManifestResult*>(update);
|
||||
return UpdateAvailability::kAvailable;
|
||||
}
|
||||
@@ -1170,7 +1155,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
@@ -1175,7 +1160,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
int load_flags = net::LOAD_DISABLE_CACHE;
|
||||
bool is_secure = fetch->url.SchemeIsCryptographic();
|
||||
extension_loader_resource_request_->load_flags = load_flags;
|
||||
@@ -1093,7 +1086,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
extension_loader_resource_request_->credentials_mode =
|
||||
network::mojom::CredentialsMode::kOmit;
|
||||
} else {
|
||||
@@ -1178,7 +1163,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
@@ -1183,7 +1168,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
net::SiteForCookies::FromUrl(fetch->url);
|
||||
}
|
||||
|
||||
@@ -1102,7 +1095,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
is_secure) {
|
||||
if (access_token_.empty()) {
|
||||
// We should try OAuth2, but we have no token cached. This
|
||||
@@ -1201,7 +1186,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
@@ -1206,7 +1191,7 @@ void ExtensionDownloader::CreateExtensionLoader() {
|
||||
base::StringPrintf("Bearer %s", access_token_.c_str()));
|
||||
}
|
||||
|
||||
@@ -1111,7 +1104,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
|
||||
StartExtensionLoader();
|
||||
}
|
||||
@@ -1223,7 +1208,7 @@ void ExtensionDownloader::StartExtensionLoader() {
|
||||
@@ -1228,7 +1213,7 @@ void ExtensionDownloader::StartExtensionLoader() {
|
||||
destination: WEBSITE
|
||||
}
|
||||
policy {
|
||||
@@ -1120,7 +1113,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
cookies_store: "user"
|
||||
setting:
|
||||
"This feature cannot be disabled. It is only enabled when the user "
|
||||
@@ -1294,6 +1279,7 @@ void ExtensionDownloader::OnExtensionLoadComplete(base::FilePath crx_path) {
|
||||
@@ -1299,6 +1284,7 @@ void ExtensionDownloader::OnExtensionLoadComplete(base::FilePath crx_path) {
|
||||
RETRY_HISTOGRAM("CrxFetchSuccess",
|
||||
extensions_queue_.active_request_failure_count(),
|
||||
url);
|
||||
@@ -1128,7 +1121,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
std::unique_ptr<ExtensionFetch> fetch_data =
|
||||
std::move(extensions_queue_.reset_active_request().fetch);
|
||||
delegate_->OnExtensionDownloadStageChanged(
|
||||
@@ -1314,7 +1300,7 @@ void ExtensionDownloader::OnExtensionLoadComplete(base::FilePath crx_path) {
|
||||
@@ -1319,7 +1305,7 @@ void ExtensionDownloader::OnExtensionLoadComplete(base::FilePath crx_path) {
|
||||
} else {
|
||||
const std::set<int> request_ids = active_request.GetRequestIds();
|
||||
const ExtensionDownloaderDelegate::PingResult& ping = ping_results_[id];
|
||||
@@ -1137,7 +1130,7 @@ diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/bro
|
||||
<< "' response code:" << response_code;
|
||||
if (ShouldRetryRequest(extension_loader_.get()) &&
|
||||
extensions_queue_.active_request_failure_count() < kMaxRetries) {
|
||||
@@ -1408,6 +1394,7 @@ void ExtensionDownloader::NotifyExtensionsDownloadFailedWithList(
|
||||
@@ -1413,6 +1399,7 @@ void ExtensionDownloader::NotifyExtensionsDownloadFailedWithList(
|
||||
bool ExtensionDownloader::IterateFetchCredentialsAfterFailure(
|
||||
ExtensionFetch* fetch,
|
||||
int response_code) {
|
||||
@@ -1159,7 +1152,7 @@ diff --git a/extensions/browser/updater/extension_downloader.h b/extensions/brow
|
||||
diff --git a/extensions/browser/updater/manifest_fetch_data.cc b/extensions/browser/updater/manifest_fetch_data.cc
|
||||
--- a/extensions/browser/updater/manifest_fetch_data.cc
|
||||
+++ b/extensions/browser/updater/manifest_fetch_data.cc
|
||||
@@ -108,7 +108,7 @@ ManifestFetchData::ManifestFetchData(const GURL& update_url,
|
||||
@@ -107,7 +107,7 @@ ManifestFetchData::ManifestFetchData(const GURL& update_url,
|
||||
: base_url_(update_url),
|
||||
full_url_(update_url),
|
||||
brand_code_(brand_code),
|
||||
@@ -1168,7 +1161,7 @@ diff --git a/extensions/browser/updater/manifest_fetch_data.cc b/extensions/brow
|
||||
fetch_priority_(fetch_priority) {
|
||||
UpdateFullUrl(base_query_params);
|
||||
request_ids_.insert(request_id);
|
||||
@@ -161,18 +161,12 @@ bool ManifestFetchData::AddExtension(const std::string& id,
|
||||
@@ -160,18 +160,12 @@ bool ManifestFetchData::AddExtension(const std::string& id,
|
||||
// Compute the string we'd append onto the full_url_, and see if it fits.
|
||||
std::vector<std::string> parts;
|
||||
parts.push_back("id=" + id);
|
||||
@@ -1201,8 +1194,8 @@ diff --git a/extensions/browser/updater/safe_manifest_parser.cc b/extensions/bro
|
||||
diff --git a/extensions/common/extension_features.cc b/extensions/common/extension_features.cc
|
||||
--- a/extensions/common/extension_features.cc
|
||||
+++ b/extensions/common/extension_features.cc
|
||||
@@ -183,4 +183,11 @@ BASE_FEATURE(kEnableShouldShowPromotion, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
BASE_FEATURE(kWebRequestPersistFilteredEvents,
|
||||
@@ -218,4 +218,11 @@ BASE_FEATURE(kSearchEngineUnconditionalDialog,
|
||||
BASE_FEATURE(kWebRequestPersistFilteredEventsViaEventRouter,
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
+CROMITE_FEATURE(kEnableExtensionAutoupdate,
|
||||
@@ -1216,9 +1209,9 @@ diff --git a/extensions/common/extension_features.cc b/extensions/common/extensi
|
||||
diff --git a/extensions/common/extension_features.h b/extensions/common/extension_features.h
|
||||
--- a/extensions/common/extension_features.h
|
||||
+++ b/extensions/common/extension_features.h
|
||||
@@ -307,6 +307,16 @@ BASE_DECLARE_FEATURE(kWebRequestSecurityInfo);
|
||||
// browser startup).
|
||||
BASE_DECLARE_FEATURE(kWebRequestPersistFilteredEvents);
|
||||
@@ -323,6 +323,16 @@ BASE_DECLARE_FEATURE(kWebRequestSecurityInfo);
|
||||
// in WebRequestEventRouter.
|
||||
BASE_DECLARE_FEATURE(kWebRequestPersistFilteredEventsViaEventRouter);
|
||||
|
||||
+// Activates the auto update of extensions.
|
||||
+// the only data provided by default is the list of extensions.
|
||||
@@ -1236,7 +1229,7 @@ diff --git a/extensions/common/extension_features.h b/extensions/common/extensio
|
||||
diff --git a/tools/typescript/definitions/developer_private.d.ts b/tools/typescript/definitions/developer_private.d.ts
|
||||
--- a/tools/typescript/definitions/developer_private.d.ts
|
||||
+++ b/tools/typescript/definitions/developer_private.d.ts
|
||||
@@ -265,6 +265,7 @@ declare global {
|
||||
@@ -264,6 +264,7 @@ declare global {
|
||||
isIncognitoAvailable: boolean;
|
||||
isChildAccount: boolean;
|
||||
isMv2DeprecationNoticeDismissed: boolean;
|
||||
@@ -1244,7 +1237,7 @@ diff --git a/tools/typescript/definitions/developer_private.d.ts b/tools/typescr
|
||||
}
|
||||
|
||||
export interface ExtensionConfigurationUpdate {
|
||||
@@ -282,6 +283,7 @@ declare global {
|
||||
@@ -281,6 +282,7 @@ declare global {
|
||||
export interface ProfileConfigurationUpdate {
|
||||
inDeveloperMode?: boolean;
|
||||
isMv2DeprecationNoticeDismissed?: boolean;
|
||||
|
||||
@@ -79,12 +79,12 @@ diff --git a/services/network/cors/preflight_result.cc b/services/network/cors/p
|
||||
diff --git a/services/network/network_context.cc b/services/network/network_context.cc
|
||||
--- a/services/network/network_context.cc
|
||||
+++ b/services/network/network_context.cc
|
||||
@@ -1368,6 +1368,7 @@ void NetworkContext::ClearHttpCache(base::Time start_time,
|
||||
@@ -1379,6 +1379,7 @@ void NetworkContext::ClearHttpCache(base::Time start_time,
|
||||
base::Time end_time,
|
||||
mojom::ClearDataFilterPtr filter,
|
||||
ClearHttpCacheCallback callback) {
|
||||
+ cors_preflight_controller_.ClearCache();
|
||||
// It's safe to use Unretained below as the HttpCacheDataRemover is owned by
|
||||
// |this| and guarantees it won't call its callback if deleted.
|
||||
http_cache_data_removers_.push_back(HttpCacheDataRemover::CreateAndStart(
|
||||
if (base::FeatureList::IsEnabled(net::features::kLogicalClearHttpCache)) {
|
||||
net::HttpCache* cache =
|
||||
url_request_context_->http_transaction_factory()->GetCache();
|
||||
--
|
||||
|
||||
@@ -31,7 +31,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java b/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
|
||||
--- a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
|
||||
+++ b/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
|
||||
@@ -95,7 +95,7 @@ public class SupportLibWebViewChromiumFactory implements WebViewProviderFactoryB
|
||||
@@ -99,7 +99,7 @@ public class SupportLibWebViewChromiumFactory implements WebViewProviderFactoryB
|
||||
Features.GET_COOKIE_INFO,
|
||||
Features.WEB_MESSAGE_ARRAY_BUFFER,
|
||||
Features.IMAGE_DRAG_DROP,
|
||||
@@ -65,7 +65,7 @@ diff --git a/components/client_hints/browser/client_hints.cc b/components/client
|
||||
diff --git a/components/embedder_support/user_agent_utils.cc b/components/embedder_support/user_agent_utils.cc
|
||||
--- a/components/embedder_support/user_agent_utils.cc
|
||||
+++ b/components/embedder_support/user_agent_utils.cc
|
||||
@@ -202,9 +202,7 @@ const blink::UserAgentBrandList GetUserAgentBrandList(
|
||||
@@ -163,9 +163,7 @@ const blink::UserAgentBrandList GetUserAgentBrandList(
|
||||
bool parse_result = base::StringToInt(major_version, &major_version_number);
|
||||
DCHECK(parse_result);
|
||||
std::optional<std::string> brand;
|
||||
@@ -76,7 +76,7 @@ diff --git a/components/embedder_support/user_agent_utils.cc b/components/embedd
|
||||
|
||||
std::string brand_version =
|
||||
output_version_type == blink::UserAgentBrandVersionType::kFullVersion
|
||||
@@ -695,6 +693,7 @@ blink::UserAgentMetadata GetUserAgentMetadata(bool only_low_entropy_ch) {
|
||||
@@ -662,6 +660,7 @@ blink::UserAgentMetadata GetUserAgentMetadata(bool only_low_entropy_ch) {
|
||||
}
|
||||
|
||||
// High entropy client hints.
|
||||
@@ -87,7 +87,7 @@ diff --git a/components/embedder_support/user_agent_utils.cc b/components/embedd
|
||||
diff --git a/content/browser/client_hints/client_hints.cc b/content/browser/client_hints/client_hints.cc
|
||||
--- a/content/browser/client_hints/client_hints.cc
|
||||
+++ b/content/browser/client_hints/client_hints.cc
|
||||
@@ -58,6 +58,7 @@
|
||||
@@ -57,6 +57,7 @@
|
||||
#include "third_party/blink/public/common/features.h"
|
||||
#include "third_party/blink/public/common/page/page_zoom.h"
|
||||
#include "third_party/blink/public/common/user_agent/user_agent_metadata.h"
|
||||
@@ -95,7 +95,7 @@ diff --git a/content/browser/client_hints/client_hints.cc b/content/browser/clie
|
||||
#include "ui/display/display.h"
|
||||
#include "ui/display/screen.h"
|
||||
#include "url/origin.h"
|
||||
@@ -602,10 +603,21 @@ bool IsClientHintEnabled(const ClientHintsExtendedData& data,
|
||||
@@ -601,10 +602,21 @@ bool IsClientHintEnabled(const ClientHintsExtendedData& data,
|
||||
|
||||
bool IsClientHintAllowed(const ClientHintsExtendedData& data,
|
||||
WebClientHintsType type) {
|
||||
@@ -119,7 +119,7 @@ diff --git a/content/browser/client_hints/client_hints.cc b/content/browser/clie
|
||||
network::GetClientHintToPolicyFeatureMap().at(type),
|
||||
data.resource_origin));
|
||||
}
|
||||
@@ -630,6 +642,7 @@ bool IsJavascriptEnabled(FrameTreeNode* frame_tree_node) {
|
||||
@@ -629,6 +641,7 @@ bool IsJavascriptEnabled(FrameTreeNode* frame_tree_node) {
|
||||
void UpdateIFramePermissionsPolicyWithDelegationSupportForClientHints(
|
||||
ClientHintsExtendedData& data,
|
||||
const network::ParsedPermissionsPolicy& container_policy) {
|
||||
@@ -156,7 +156,7 @@ new file mode 100644
|
||||
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
|
||||
--- a/net/http/http_network_transaction.cc
|
||||
+++ b/net/http/http_network_transaction.cc
|
||||
@@ -113,6 +113,7 @@ const size_t kMaxRestarts = 32;
|
||||
@@ -119,6 +119,7 @@ const size_t kMaxRestarts = 32;
|
||||
|
||||
// Returns true when Early Hints are allowed on the given protocol.
|
||||
bool EarlyHintsAreAllowedOn(HttpConnectionInfo connection_info) {
|
||||
@@ -262,7 +262,7 @@ diff --git a/third_party/blink/renderer/core/frame/navigator_ua_data.idl b/third
|
||||
diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
--- a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
+++ b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
|
||||
@@ -231,6 +231,8 @@ bool ShouldSendClientHint(const network::PermissionsPolicy& policy,
|
||||
@@ -233,6 +233,8 @@ bool ShouldSendClientHint(const network::PermissionsPolicy& policy,
|
||||
bool is_1p_origin,
|
||||
network::mojom::blink::WebClientHintsType type,
|
||||
const ClientHintsPreferences& hints_preferences) {
|
||||
@@ -271,7 +271,7 @@ diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/thi
|
||||
// For subresource requests, sending the hint in the fetch request based on
|
||||
// the permissions policy.
|
||||
if (!policy.IsFeatureEnabledForOrigin(
|
||||
@@ -715,7 +717,7 @@ void FrameFetchContext::AddClientHintsIfNecessary(
|
||||
@@ -731,7 +733,7 @@ void FrameFetchContext::AddClientHintsIfNecessary(
|
||||
}
|
||||
|
||||
// Only send User Agent hints if the info is available
|
||||
@@ -283,7 +283,7 @@ diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/thi
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -610,6 +610,11 @@
|
||||
@@ -647,6 +647,11 @@
|
||||
name: "AriaNotifyV2",
|
||||
status: {"Android": "test", "Win": "test", "Mac": "test", "Linux": "test"},
|
||||
},
|
||||
@@ -295,7 +295,7 @@ diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
{
|
||||
name: "AriaRowColIndexText",
|
||||
status: "stable",
|
||||
@@ -1016,8 +1021,7 @@
|
||||
@@ -1085,8 +1090,7 @@
|
||||
// Allows top-level sites to restrict collection of high-entropy UA client
|
||||
// hints (from 3Ps, or itself) via the getHighEntropyValues API.
|
||||
// crbug.com/385161047
|
||||
|
||||
@@ -88,7 +88,7 @@ new file mode 100644
|
||||
diff --git a/net/base/features.cc b/net/base/features.cc
|
||||
--- a/net/base/features.cc
|
||||
+++ b/net/base/features.cc
|
||||
@@ -443,7 +443,7 @@ BASE_FEATURE(kRelatedWebsitePartitionAPI, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
@@ -294,7 +294,7 @@ BASE_FEATURE(kRelatedWebsitePartitionAPI, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
// NetworkChangeNotifier::AreNetworkHandlesSupported).
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
inline constexpr auto kMigrateSessionsOnNetworkChangeV2Default =
|
||||
|
||||
@@ -13,7 +13,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/android/chrome_public_apk_tmpl.gni b/chrome/android/chrome_public_apk_tmpl.gni
|
||||
--- a/chrome/android/chrome_public_apk_tmpl.gni
|
||||
+++ b/chrome/android/chrome_public_apk_tmpl.gni
|
||||
@@ -674,6 +674,7 @@ template("chrome_common_apk_or_module_tmpl") {
|
||||
@@ -600,6 +600,7 @@ template("chrome_common_apk_or_module_tmpl") {
|
||||
[ "//components/crash/core/app:chrome_crashpad_handler_named_as_so" ]
|
||||
loadable_modules += [ "$root_out_dir/libchrome_crashpad_handler.so" ]
|
||||
library_always_compress += [ "libchrome_crashpad_handler.so" ]
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -18,7 +18,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_java_resources.gni
|
||||
--- a/chrome/android/chrome_java_resources.gni
|
||||
+++ b/chrome/android/chrome_java_resources.gni
|
||||
@@ -683,7 +683,7 @@ chrome_java_resources = [
|
||||
@@ -663,7 +663,7 @@ chrome_java_resources = [
|
||||
"java/res/xml/manage_sync_preferences.xml",
|
||||
"java/res/xml/personalize_google_services_preferences.xml",
|
||||
"java/res/xml/incognito_preferences.xml",
|
||||
@@ -30,9 +30,9 @@ diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_ja
|
||||
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/main_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
||||
@@ -11,7 +11,7 @@ found in the LICENSE file.
|
||||
<!-- `order=0` is reserved and it will be added in code. -->
|
||||
<!-- TODO(crbug.com/364906215): Move SettingsPromoCardPreference here once SyncPromoPreference is removed -->
|
||||
@@ -12,7 +12,7 @@ found in the LICENSE file.
|
||||
android:key="settings_promo_card"
|
||||
android:order="0" />
|
||||
<PreferenceCategory
|
||||
- android:key="account_and_google_services_section"
|
||||
+ android:key="account_and_google_services_section" app:isPreferenceVisible="false"
|
||||
@@ -247,7 +247,7 @@ new file mode 100644
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
|
||||
@@ -189,7 +189,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -196,7 +196,7 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
public void onCreatePreferencesCromite(@Nullable Bundle savedInstanceState, @Nullable String rootKey) {
|
||||
mPageTitle.set(getString(R.string.prefs_privacy_security));
|
||||
|
||||
@@ -256,7 +256,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/setting
|
||||
|
||||
Preference sandboxPreference = findPreference(PREF_PRIVACY_SANDBOX);
|
||||
// Overwrite the click listener to pass a correct referrer to the fragment.
|
||||
@@ -282,7 +282,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
@@ -283,7 +283,9 @@ public class PrivacySettings extends ChromeBaseSettingsFragment
|
||||
|
||||
ChromeSwitchPreference passwordLeakTogglePref =
|
||||
(ChromeSwitchPreference) findPreference(PREF_PASSWORD_LEAK_DETECTION);
|
||||
|
||||
@@ -4,6 +4,7 @@ Subject: Cromite Branding
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
base/win/message_window.cc | 2 +-
|
||||
build/BUILD.gn | 8 ++
|
||||
build/config/BUILDCONFIG.gn | 4 +
|
||||
chrome/android/java/AndroidManifest.xml | 2 +-
|
||||
@@ -26,7 +27,6 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../mipmap-xxxhdpi/layered_app_icon.png | Bin 3652 -> 29220 bytes
|
||||
.../layered_app_icon_background.png | Bin 3519 -> 142032 bytes
|
||||
.../values/channel_constants.xml | 8 +-
|
||||
.../about_settings/AboutChromeSettings.java | 4 +-
|
||||
.../ChromeContextMenuPopulator.java | 2 +-
|
||||
.../browser/fullscreen/FullscreenToast.java | 2 +-
|
||||
.../inline/BromiteInlineUpdateController.java | 19 +++-
|
||||
@@ -39,18 +39,21 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../theme/chromium/win/tiles/SmallLogo.png | Bin 9784 -> 12363 bytes
|
||||
.../chromium/product_logo_32.png | Bin 822 -> 2301 bytes
|
||||
chrome/browser/BUILD.gn | 1 +
|
||||
.../external_registry_loader_win.cc | 3 +-
|
||||
.../browser/hub/HubToolbarMediator.java | 2 +-
|
||||
.../android/res/layout/hub_toolbar_layout.xml | 82 ++++++++-------
|
||||
.../android/res/layout/hub_toolbar_layout.xml | 83 +++++++++-------
|
||||
.../chrome/browser/omaha/UpdateConfigs.java | 2 +-
|
||||
chrome/browser/prefs/BUILD.gn | 1 +
|
||||
.../prefs/chrome_pref_service_factory.cc | 6 +-
|
||||
chrome/browser/process_singleton_win.cc | 2 +-
|
||||
.../profiles/profile_shortcut_manager_win.cc | 2 +-
|
||||
.../settings/settings_menu/settings_menu.html | 14 ++-
|
||||
.../tab_group_sync/TabGroupSyncUtils.java | 5 +-
|
||||
.../OmniboxSuggestionsContainer.java | 8 +-
|
||||
.../strings/android_chrome_strings.grd | 4 +-
|
||||
.../toolbar/chrome_labs/chrome_labs_utils.cc | 1 +
|
||||
chrome/common/url_constants.h | 4 +-
|
||||
.../install_static/chromium_install_modes.cc | 2 +-
|
||||
.../install_static/chromium_install_modes.h | 2 +-
|
||||
.../strings/android/browser_ui_strings.grd | 2 +-
|
||||
.../drawable-hdpi/fre_product_logo.png | Bin 3912 -> 22295 bytes
|
||||
.../drawable-mdpi/fre_product_logo.png | Bin 2490 -> 12171 bytes
|
||||
@@ -60,18 +63,31 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../browser/autocomplete_controller.cc | 1 +
|
||||
.../vector_icons/product_chrome_refresh.icon | 93 +++++++++---------
|
||||
components/policy/core/common/policy_paths.cc | 2 +-
|
||||
.../policy/tools/generate_policy_source.py | 2 +-
|
||||
.../chromium/product_logo.png | Bin 1562 -> 3577 bytes
|
||||
.../chromium/product_logo_white.png | Bin 1417 -> 3040 bytes
|
||||
.../chromium/product_logo.png | Bin 2714 -> 7923 bytes
|
||||
.../chromium/product_logo_white.png | Bin 2512 -> 6790 bytes
|
||||
.../webui/version/resources/about_version.ts | 4 +-
|
||||
.../resources/about_version_mobile.css | 9 ++
|
||||
.../resources/about_version_mobile.css | 10 ++
|
||||
content/child/runtime_features.cc | 44 ++++-----
|
||||
.../Cromite-Branding.inc | 2 +
|
||||
.../Cromite-Branding.inc | 1 +
|
||||
tools/grit/grit/grd_reader.py | 35 +++++++
|
||||
65 files changed, 265 insertions(+), 175 deletions(-)
|
||||
69 files changed, 272 insertions(+), 179 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Cromite-Branding.inc
|
||||
|
||||
diff --git a/base/win/message_window.cc b/base/win/message_window.cc
|
||||
--- a/base/win/message_window.cc
|
||||
+++ b/base/win/message_window.cc
|
||||
@@ -29,7 +29,7 @@
|
||||
// To avoid conflicts with the macro from the Windows SDK...
|
||||
#undef FindWindow
|
||||
|
||||
-const wchar_t kMessageWindowClassName[] = L"Chrome_MessageWindow";
|
||||
+const wchar_t kMessageWindowClassName[] = L"Cromite_MessageWindow";
|
||||
|
||||
namespace {
|
||||
|
||||
diff --git a/build/BUILD.gn b/build/BUILD.gn
|
||||
--- a/build/BUILD.gn
|
||||
+++ b/build/BUILD.gn
|
||||
@@ -107,7 +123,7 @@ diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
|
||||
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
|
||||
--- a/chrome/android/java/AndroidManifest.xml
|
||||
+++ b/chrome/android/java/AndroidManifest.xml
|
||||
@@ -200,7 +200,7 @@ by a child template that "extends" this file.
|
||||
@@ -206,7 +206,7 @@ by a child template that "extends" this file.
|
||||
<application android:name="{% block application_name %}org.chromium.chrome.browser.base.SplitChromeApplication{% endblock %}"
|
||||
android:icon="@drawable/ic_launcher"
|
||||
android:roundIcon="@drawable/ic_launcher_round"
|
||||
@@ -139,8 +155,8 @@ diff --git a/chrome/android/java/res/xml/legal_information_preferences.xml b/chr
|
||||
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/main_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
||||
@@ -12,20 +12,20 @@ found in the LICENSE file.
|
||||
<!-- TODO(crbug.com/364906215): Move SettingsPromoCardPreference here once SyncPromoPreference is removed -->
|
||||
@@ -13,19 +13,19 @@ found in the LICENSE file.
|
||||
android:order="0" />
|
||||
<PreferenceCategory
|
||||
android:key="account_and_google_services_section"
|
||||
- android:order="1"
|
||||
@@ -148,9 +164,8 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
||||
android:title="@string/prefs_section_account_and_google_services"/>
|
||||
<org.chromium.chrome.browser.sync.settings.SignInPreference
|
||||
android:key="sign_in"
|
||||
- android:order="2"
|
||||
+ android:order="1002"
|
||||
android:title="@string/sign_in_to_chrome"/>
|
||||
- android:order="2"/>
|
||||
+ android:order="1002"/>
|
||||
<org.chromium.components.browser_ui.settings.ChromeBasePreference
|
||||
android:key="manage_sync"
|
||||
- android:order="3"
|
||||
@@ -9145,24 +9160,10 @@ diff --git a/chrome/android/java/res_chromium_base/values/channel_constants.xml
|
||||
+ <string name="search_widget_title" translatable="false">Cromite search</string>
|
||||
+ <string name="quick_action_search_widget_title" translatable="false">Cromite quick action search</string>
|
||||
</resources>
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/about_settings/AboutChromeSettings.java
|
||||
@@ -82,7 +82,9 @@ public class AboutChromeSettings extends ChromeBaseSettingsFragment
|
||||
p.setSummary(AboutSettingsBridge.getOSVersion());
|
||||
p = findPreference(PREF_LEGAL_INFORMATION);
|
||||
assumeNonNull(p);
|
||||
- int currentYear = CalendarFactory.get().get(Calendar.YEAR);
|
||||
+ Calendar calendar = CalendarFactory.get();
|
||||
+ calendar.setTimeInMillis(System.currentTimeMillis());
|
||||
+ int currentYear = calendar.get(Calendar.YEAR);
|
||||
p.setSummary(getString(R.string.legal_information_summary, currentYear));
|
||||
|
||||
ChromeSwitchPreference allowInlineUpdate =
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
|
||||
@@ -481,8 +481,8 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
@@ -495,8 +495,8 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
|
||||
&& !isEmptyUrl(mParams.getUrl())
|
||||
&& UrlUtilities.isAcceptedScheme(mParams.getUrl())) {
|
||||
if (mMode == ContextMenuMode.NORMAL) {
|
||||
@@ -9230,7 +9231,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omaha/inline/Br
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
@@ -909,12 +909,12 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
@@ -1014,12 +1014,12 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
if (tab.canGoBack()) {
|
||||
return ActionType.NAVIGATE_BACK;
|
||||
}
|
||||
@@ -9248,7 +9249,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/app/extensions_strings.grdp b/chrome/app/extensions_strings.grdp
|
||||
--- a/chrome/app/extensions_strings.grdp
|
||||
+++ b/chrome/app/extensions_strings.grdp
|
||||
@@ -404,7 +404,7 @@
|
||||
@@ -395,7 +395,7 @@
|
||||
No recent activities
|
||||
</message>
|
||||
<message name="IDS_EXTENSIONS_NO_INSTALLED_ITEMS" desc="The message shown to the user on the Extensions settings page when there are no extensions or apps installed.">
|
||||
@@ -9257,7 +9258,7 @@ diff --git a/chrome/app/extensions_strings.grdp b/chrome/app/extensions_strings.
|
||||
</message>
|
||||
<message name="IDS_EXTENSIONS_NO_DESCRIPTION" desc="The message shown to the user when an extension does not have any description.">
|
||||
No description provided
|
||||
@@ -542,7 +542,7 @@
|
||||
@@ -533,7 +533,7 @@
|
||||
My extensions
|
||||
</message>
|
||||
<message name="IDS_EXTENSIONS_SIDEBAR_DISCOVER_MORE" desc="The text displayed in the sidebar of the chrome://extensions page to open the Chrome Web Store to get more extensions.">
|
||||
@@ -13223,7 +13224,7 @@ e)fqMZZ`3a)Ds&5H<cfp<0000<MNUMnLSTYHt&Yn8
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -1825,6 +1825,7 @@ static_library("browser") {
|
||||
@@ -1623,6 +1623,7 @@ static_library("browser") {
|
||||
"//build/config/chromebox_for_meetings:buildflags",
|
||||
"//build/config/compiler:compiler_buildflags",
|
||||
"//build/config/linux/dbus:buildflags",
|
||||
@@ -13231,6 +13232,26 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
"//cc",
|
||||
"//chrome:extra_resources",
|
||||
"//chrome:resources",
|
||||
diff --git a/chrome/browser/extensions/external_registry_loader_win.cc b/chrome/browser/extensions/external_registry_loader_win.cc
|
||||
--- a/chrome/browser/extensions/external_registry_loader_win.cc
|
||||
+++ b/chrome/browser/extensions/external_registry_loader_win.cc
|
||||
@@ -35,7 +35,7 @@ using content::BrowserThread;
|
||||
namespace {
|
||||
|
||||
// The Registry subkey that contains information about external extensions.
|
||||
-const wchar_t kRegistryExtensions[] = L"Software\\Google\\Chrome\\Extensions";
|
||||
+const wchar_t kRegistryExtensions[] = L"Software\\Uazo\\Cromite\\Extensions";
|
||||
|
||||
// Registry value of the key that defines the installation parameter.
|
||||
const wchar_t kRegistryExtensionInstallParam[] = L"install_parameter";
|
||||
@@ -82,6 +82,7 @@ void ExternalRegistryLoader::StartLoading() {
|
||||
|
||||
base::DictValue ExternalRegistryLoader::LoadPrefsOnBlockingThread() {
|
||||
base::DictValue prefs;
|
||||
+ if ((true)) return prefs;
|
||||
|
||||
// A map of IDs, to weed out duplicates between HKCU and HKLM.
|
||||
std::set<std::wstring> keys;
|
||||
diff --git a/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediator.java b/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediator.java
|
||||
--- a/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediator.java
|
||||
+++ b/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediator.java
|
||||
@@ -13240,22 +13261,26 @@ diff --git a/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/br
|
||||
int screenWidthDp = configuration.screenWidthDp;
|
||||
- boolean isTablet = HubUtils.isScreenWidthTablet(screenWidthDp);
|
||||
+ boolean isTablet = true; //HubUtils.isScreenWidthTablet(screenWidthDp);
|
||||
mPropertyModel.set(BACK_BUTTON_VISIBLE, isTablet);
|
||||
|
||||
Pane pane = mPaneManager.getFocusedPaneSupplier().get();
|
||||
if (pane == null) return;
|
||||
diff --git a/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.xml b/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.xml
|
||||
--- a/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.xml
|
||||
+++ b/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.xml
|
||||
@@ -38,33 +38,20 @@ found in the LICENSE file.
|
||||
@@ -38,34 +38,22 @@ found in the LICENSE file.
|
||||
android:layout_width="wrap_content"
|
||||
android:layout_height="match_parent"
|
||||
android:layout_gravity="start|center_vertical">
|
||||
-
|
||||
+ <Space
|
||||
+ android:layout_width="@dimen/hub_toolbar_action_button_start_margin"
|
||||
+ android:layout_height="match_parent"/>
|
||||
|
||||
- <!-- This is needed to keep the new tab button aligned with the first tab. -->
|
||||
- <Space
|
||||
- android:id="@+id/margin_spacer"
|
||||
- android:layout_width="@dimen/hub_toolbar_action_button_start_margin"
|
||||
- android:layout_height="match_parent"
|
||||
- android:visibility="gone"/>
|
||||
- android:visibility="visible"/>
|
||||
-
|
||||
- <org.chromium.ui.widget.ChromeImageButton
|
||||
- android:id="@+id/toolbar_back_button"
|
||||
@@ -13277,9 +13302,7 @@ diff --git a/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.x
|
||||
- android:layout_gravity="start|center_vertical"
|
||||
- android:visibility="gone"
|
||||
- style="?attr/newTabButtonStyle"/>
|
||||
+ <Space
|
||||
+ android:layout_width="@dimen/hub_toolbar_action_button_start_margin"
|
||||
+ android:layout_height="match_parent"/>
|
||||
+ <!-- On tablets, the searchbox (R.id.search_box) is hidden in favor of a button. -->
|
||||
+ <org.chromium.ui.widget.ChromeImageButton
|
||||
+ android:id="@+id/search_loupe"
|
||||
+ android:visibility="gone"
|
||||
@@ -13287,14 +13310,14 @@ diff --git a/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.x
|
||||
+ android:layout_width="44dp"
|
||||
+ android:layout_height="match_parent"
|
||||
+ android:contentDescription="@string/search"
|
||||
+ android:src="@drawable/ic_search"
|
||||
+ android:src="@drawable/ic_search_24dp"
|
||||
+ android:tooltipText="@string/accessibility_search_loupe_tooltip_text"
|
||||
+ style="@style/ToolbarMenuButton"
|
||||
+ app:tint="@color/default_icon_color_tint_list" />
|
||||
</LinearLayout>
|
||||
|
||||
<FrameLayout
|
||||
@@ -96,18 +83,39 @@ found in the LICENSE file.
|
||||
@@ -97,18 +85,39 @@ found in the LICENSE file.
|
||||
android:layout_width="wrap_content"
|
||||
android:layout_height="match_parent"
|
||||
android:layout_gravity="end" >
|
||||
@@ -13321,7 +13344,7 @@ diff --git a/chrome/browser/hub/internal/android/res/layout/hub_toolbar_layout.x
|
||||
- android:layout_width="44dp"
|
||||
- android:layout_height="match_parent"
|
||||
- android:contentDescription="@string/search"
|
||||
- android:src="@drawable/ic_search"
|
||||
- android:src="@drawable/ic_search_24dp"
|
||||
- android:tooltipText="@string/accessibility_search_loupe_tooltip_text"
|
||||
style="@style/ToolbarMenuButton"
|
||||
- app:tint="@color/default_icon_color_tint_list" />
|
||||
@@ -13378,7 +13401,7 @@ diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browse
|
||||
#include "chrome/browser/browser_process.h"
|
||||
#include "chrome/browser/enterprise/signin/enterprise_signin_prefs.h"
|
||||
#include "chrome/browser/policy/chrome_browser_policy_connector.h"
|
||||
@@ -294,10 +295,7 @@ std::unique_ptr<ProfilePrefStoreManager> CreateProfilePrefStoreManager(
|
||||
@@ -293,10 +294,7 @@ std::unique_ptr<ProfilePrefStoreManager> CreateProfilePrefStoreManager(
|
||||
const base::FilePath& profile_path) {
|
||||
std::string seed;
|
||||
CHECK(ui::ResourceBundle::HasSharedInstance());
|
||||
@@ -13390,10 +13413,22 @@ diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browse
|
||||
return std::make_unique<ProfilePrefStoreManager>(profile_path, seed);
|
||||
}
|
||||
|
||||
diff --git a/chrome/browser/process_singleton_win.cc b/chrome/browser/process_singleton_win.cc
|
||||
--- a/chrome/browser/process_singleton_win.cc
|
||||
+++ b/chrome/browser/process_singleton_win.cc
|
||||
@@ -381,7 +381,7 @@ ProcessSingleton::NotifyOtherProcessOrCreate() {
|
||||
bool ProcessSingleton::Create() {
|
||||
TRACE_EVENT0("startup", "ProcessSingleton::Create");
|
||||
|
||||
- static const wchar_t kMutexName[] = L"Local\\ChromeProcessSingletonStartup!";
|
||||
+ static const wchar_t kMutexName[] = L"Local\\CromiteProcessSingletonStartup!";
|
||||
|
||||
remote_window_ = FindRunningChromeWindow(user_data_dir_);
|
||||
if (!remote_window_ && !EscapeVirtualization(user_data_dir_)) {
|
||||
diff --git a/chrome/browser/profiles/profile_shortcut_manager_win.cc b/chrome/browser/profiles/profile_shortcut_manager_win.cc
|
||||
--- a/chrome/browser/profiles/profile_shortcut_manager_win.cc
|
||||
+++ b/chrome/browser/profiles/profile_shortcut_manager_win.cc
|
||||
@@ -79,7 +79,7 @@ const int kMaxProfileShortcutFileNameLength = 64;
|
||||
@@ -78,7 +78,7 @@ const int kMaxProfileShortcutFileNameLength = 64;
|
||||
// Incrementing this number will cause profile icons to be regenerated on
|
||||
// profile startup (it should be incremented whenever the product/avatar icons
|
||||
// change, etc).
|
||||
@@ -13424,7 +13459,7 @@ diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html
|
||||
#menu {
|
||||
color: var(--google-grey-700);
|
||||
display: flex;
|
||||
@@ -177,7 +189,7 @@
|
||||
@@ -167,7 +179,7 @@
|
||||
</a>
|
||||
<a role="menuitem" id="about-menu" href="/help"
|
||||
class="cr-nav-menu-item">
|
||||
@@ -13433,6 +13468,21 @@ diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html
|
||||
$i18n{aboutPageTitle}
|
||||
<cr-ripple></cr-ripple>
|
||||
</a>
|
||||
diff --git a/chrome/browser/tab_group_sync/android/java/src/org/chromium/chrome/browser/tab_group_sync/TabGroupSyncUtils.java b/chrome/browser/tab_group_sync/android/java/src/org/chromium/chrome/browser/tab_group_sync/TabGroupSyncUtils.java
|
||||
--- a/chrome/browser/tab_group_sync/android/java/src/org/chromium/chrome/browser/tab_group_sync/TabGroupSyncUtils.java
|
||||
+++ b/chrome/browser/tab_group_sync/android/java/src/org/chromium/chrome/browser/tab_group_sync/TabGroupSyncUtils.java
|
||||
@@ -127,7 +127,10 @@ public final class TabGroupSyncUtils {
|
||||
for (String syncGroupId : tabGroupSyncService.getAllGroupIds()) {
|
||||
SavedTabGroup savedTabGroup = tabGroupSyncService.getGroup(syncGroupId);
|
||||
// If there is no local ID the group is already hidden so this is a no-op.
|
||||
- if (savedTabGroup == null || savedTabGroup.localId == null) continue;
|
||||
+ if (savedTabGroup == null || savedTabGroup.localId == null) {
|
||||
+ tabGroupSyncService.removeGroup(syncGroupId);
|
||||
+ continue;
|
||||
+ }
|
||||
|
||||
if (!isInAnyWindow(savedTabGroup.localId, filterList)) {
|
||||
tabGroupSyncService.removeLocalTabGroupMapping(
|
||||
diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsContainer.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsContainer.java
|
||||
--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsContainer.java
|
||||
+++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsContainer.java
|
||||
@@ -13444,7 +13494,7 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.chrome.browser.omnibox.OmniboxMetrics;
|
||||
import org.chromium.chrome.browser.omnibox.R;
|
||||
@@ -111,8 +112,11 @@ public class OmniboxSuggestionsContainer extends FrameLayout {
|
||||
@@ -109,8 +110,11 @@ public class OmniboxSuggestionsContainer extends FrameLayout {
|
||||
// Omnibox.
|
||||
// Making the container `clickable=true` achieves similar goal, but this consumes all
|
||||
// activators, including keyboard <Enter> key.
|
||||
@@ -13457,11 +13507,11 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
+ return false;
|
||||
}
|
||||
|
||||
private void maybeUpdateLayoutParams(int topMargin) {
|
||||
/**
|
||||
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
||||
@@ -2380,7 +2380,7 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
@@ -2466,7 +2466,7 @@ Your Google account may have other forms of browsing history like searches and a
|
||||
About Chrome
|
||||
</message>
|
||||
<message name="IDS_LEGAL_INFORMATION_SUMMARY" desc="Summary for legal information" meaning="Android">
|
||||
@@ -13470,7 +13520,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
</message>
|
||||
<message name="IDS_APPLICATION_VERSION_TITLE" desc="Title for application version">
|
||||
Application version
|
||||
@@ -5845,7 +5845,7 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
@@ -6039,7 +6039,7 @@ To change this setting, <ph name="BEGIN_LINK">BEGIN_LINK</ph>delete the Chrome d
|
||||
|
||||
<!-- Storage Preference UI strings for clearing storage. -->
|
||||
<message name="IDS_STORAGE_MANAGEMENT_ACTIVITY_LABEL" desc="Title for Chrome's Manage Space Activity.">
|
||||
@@ -13482,7 +13532,7 @@ diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chro
|
||||
diff --git a/chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc b/chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc
|
||||
--- a/chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc
|
||||
+++ b/chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc
|
||||
@@ -140,6 +140,7 @@ bool AreNewChromeLabsExperimentsAvailable(Profile* profile) {
|
||||
@@ -139,6 +139,7 @@ bool AreNewChromeLabsExperimentsAvailable(Profile* profile) {
|
||||
}
|
||||
|
||||
bool IsChromeLabsEnabled() {
|
||||
@@ -13493,7 +13543,7 @@ diff --git a/chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc b/chrome
|
||||
diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h
|
||||
--- a/chrome/common/url_constants.h
|
||||
+++ b/chrome/common/url_constants.h
|
||||
@@ -135,7 +135,7 @@ inline constexpr char kChromeHelpViaMenuURL[] =
|
||||
@@ -117,7 +117,7 @@ inline constexpr char kChromeHelpViaMenuURL[] =
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
|
||||
inline constexpr char kChromeHelpViaWebUIURL[] =
|
||||
@@ -13502,31 +13552,31 @@ diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
inline constexpr char kChromeOsHelpViaWebUIURL[] =
|
||||
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
|
||||
@@ -193,7 +193,7 @@ inline constexpr char kChromeUIUntrustedNewTabPageUrl[] =
|
||||
@@ -175,7 +175,7 @@ inline constexpr char kChromeUIUntrustedNewTabPageUrl[] =
|
||||
"chrome-untrusted://new-tab-page/";
|
||||
|
||||
// The URL for the Chromium project used in the About dialog.
|
||||
-inline constexpr char16_t kChromiumProjectURL[] = u"https://www.chromium.org/";
|
||||
+inline constexpr char16_t kChromiumProjectURL[] = u"https://www.cromite.org/";
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
static_assert(std::u16string_view(kChromiumProjectURL) ==
|
||||
ash::chrome_external_urls::kChromiumProjectURL);
|
||||
diff --git a/chrome/install_static/chromium_install_modes.h b/chrome/install_static/chromium_install_modes.h
|
||||
--- a/chrome/install_static/chromium_install_modes.h
|
||||
+++ b/chrome/install_static/chromium_install_modes.h
|
||||
@@ -21,7 +21,7 @@ inline constexpr wchar_t kCompanyPathName[] = L"";
|
||||
|
||||
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
|
||||
// The URL for the "Clear browsing data in Chrome" help center article.
|
||||
diff --git a/chrome/install_static/chromium_install_modes.cc b/chrome/install_static/chromium_install_modes.cc
|
||||
--- a/chrome/install_static/chromium_install_modes.cc
|
||||
+++ b/chrome/install_static/chromium_install_modes.cc
|
||||
@@ -14,7 +14,7 @@ namespace install_static {
|
||||
|
||||
const wchar_t kCompanyPathName[] = L"";
|
||||
|
||||
-const wchar_t kProductPathName[] = L"Chromium";
|
||||
+const wchar_t kProductPathName[] = L"Cromite";
|
||||
|
||||
const size_t kProductPathNameLength = _countof(kProductPathName) - 1;
|
||||
// The brand-specific product name to be included as a component of the install
|
||||
// and user data directory paths.
|
||||
-inline constexpr wchar_t kProductPathName[] = L"Chromium";
|
||||
+inline constexpr wchar_t kProductPathName[] = L"Cromite";
|
||||
|
||||
// The brand-specific safe browsing client name.
|
||||
inline constexpr char kSafeBrowsingName[] = "chromium";
|
||||
diff --git a/components/browser_ui/strings/android/browser_ui_strings.grd b/components/browser_ui/strings/android/browser_ui_strings.grd
|
||||
--- a/components/browser_ui/strings/android/browser_ui_strings.grd
|
||||
+++ b/components/browser_ui/strings/android/browser_ui_strings.grd
|
||||
@@ -1020,7 +1020,7 @@
|
||||
@@ -1003,7 +1003,7 @@
|
||||
|
||||
<!-- Accessibility preferences -->
|
||||
<message name="IDS_PREFS_ACCESSIBILITY" desc="Title of Accessibility settings, which allows the user to change webpage font sizes. [CHAR_LIMIT=32]">
|
||||
@@ -18434,7 +18484,7 @@ i?Ib$(ofrX17!1R|`h|N%TnD<%35@j2bgPM^i2nno*_EOI
|
||||
diff --git a/components/omnibox/browser/autocomplete_controller.cc b/components/omnibox/browser/autocomplete_controller.cc
|
||||
--- a/components/omnibox/browser/autocomplete_controller.cc
|
||||
+++ b/components/omnibox/browser/autocomplete_controller.cc
|
||||
@@ -1106,6 +1106,7 @@ bool AutocompleteController::ShouldRunProvider(
|
||||
@@ -1117,6 +1117,7 @@ bool AutocompleteController::ShouldRunProvider(
|
||||
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
if (omnibox::IsAndroidHub(input_.current_page_classification())) {
|
||||
@@ -18555,6 +18605,18 @@ diff --git a/components/policy/core/common/policy_paths.cc b/components/policy/c
|
||||
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
|
||||
#endif // BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_MAC)
|
||||
|
||||
diff --git a/components/policy/tools/generate_policy_source.py b/components/policy/tools/generate_policy_source.py
|
||||
--- a/components/policy/tools/generate_policy_source.py
|
||||
+++ b/components/policy/tools/generate_policy_source.py
|
||||
@@ -28,7 +28,7 @@ from xml.sax.saxutils import escape as xml_escape
|
||||
|
||||
CHROME_POLICY_KEY = 'SOFTWARE\\\\Policies\\\\Google\\\\Chrome'
|
||||
CHROME_FOR_TESTING_POLICY_KEY = CHROME_POLICY_KEY + ' for Testing'
|
||||
-CHROMIUM_POLICY_KEY = 'SOFTWARE\\\\Policies\\\\Chromium'
|
||||
+CHROMIUM_POLICY_KEY = 'SOFTWARE\\\\Policies\\\\Cromite'
|
||||
PLATFORM_STRINGS = {
|
||||
'chrome_frame': ['win'],
|
||||
'chrome_os': ['chrome_os'],
|
||||
diff --git a/components/resources/default_100_percent/chromium/product_logo.png b/components/resources/default_100_percent/chromium/product_logo.png
|
||||
index 7b60bd8c6053346e4eb265cc77d28add65103028..66b3c4c7a4f68fba1ef098000bd373ba103a0de0 100644
|
||||
GIT binary patch
|
||||
@@ -19179,12 +19241,13 @@ diff --git a/components/webui/version/resources/about_version.ts b/components/we
|
||||
diff --git a/components/webui/version/resources/about_version_mobile.css b/components/webui/version/resources/about_version_mobile.css
|
||||
--- a/components/webui/version/resources/about_version_mobile.css
|
||||
+++ b/components/webui/version/resources/about_version_mobile.css
|
||||
@@ -17,3 +17,12 @@
|
||||
@@ -17,3 +17,13 @@
|
||||
margin-left: auto;
|
||||
margin-right: auto;
|
||||
}
|
||||
+
|
||||
+tr, td {
|
||||
+tr,
|
||||
+td {
|
||||
+ display: block;
|
||||
+ text-align: left !important;
|
||||
+}
|
||||
@@ -19195,7 +19258,7 @@ diff --git a/components/webui/version/resources/about_version_mobile.css b/compo
|
||||
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
|
||||
--- a/content/child/runtime_features.cc
|
||||
+++ b/content/child/runtime_features.cc
|
||||
@@ -573,19 +573,22 @@ void ResolveInvalidConfigurations() {
|
||||
@@ -549,19 +549,22 @@ void ResolveInvalidConfigurations() {
|
||||
base::FeatureList::IsEnabled(
|
||||
features::kPrivacySandboxAdsAPIsM1Override)) &&
|
||||
!base::FeatureList::IsEnabled(blink::features::kFencedFrames)) {
|
||||
@@ -19222,7 +19285,7 @@ diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.
|
||||
<< "Fenced frames must be enabled in order to enable local "
|
||||
"unpartitioned "
|
||||
<< "data access. Use --" << switches::kEnableFeatures << "="
|
||||
@@ -593,12 +596,14 @@ void ResolveInvalidConfigurations() {
|
||||
@@ -569,12 +572,14 @@ void ResolveInvalidConfigurations() {
|
||||
WebRuntimeFeatures::EnableFeatureFromString(
|
||||
"FencedFramesLocalUnpartitionedDataAccess", false);
|
||||
}
|
||||
@@ -19238,7 +19301,7 @@ diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.
|
||||
<< "Topics cannot be enabled in this configuration. Use --"
|
||||
<< switches::kEnableFeatures << "="
|
||||
<< network::features::kBrowsingTopics.name << " in addition.";
|
||||
@@ -606,30 +611,23 @@ void ResolveInvalidConfigurations() {
|
||||
@@ -582,30 +587,23 @@ void ResolveInvalidConfigurations() {
|
||||
WebRuntimeFeatures::EnableTopicsDocumentAPI(false);
|
||||
WebRuntimeFeatures::EnableTopicsImgAPI(false);
|
||||
} else {
|
||||
@@ -19275,7 +19338,7 @@ diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.
|
||||
<< "AttributionReporting cannot be enabled in this "
|
||||
"configuration. Use --"
|
||||
<< switches::kEnableFeatures << "="
|
||||
@@ -637,23 +635,25 @@ void ResolveInvalidConfigurations() {
|
||||
@@ -613,23 +611,25 @@ void ResolveInvalidConfigurations() {
|
||||
<< " in addition.";
|
||||
WebRuntimeFeatures::EnableAttributionReporting(false);
|
||||
}
|
||||
@@ -19296,22 +19359,21 @@ diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.
|
||||
+ CHECK(false) << "kInterestGroupStorage is enabled!";
|
||||
}
|
||||
|
||||
// PermissionElement cannot be enabled without the support of the
|
||||
// UserMediaElement cannot be enabled without the support of the
|
||||
// browser process.
|
||||
if (!base::FeatureList::IsEnabled(blink::features::kPermissionElement)) {
|
||||
if (!base::FeatureList::IsEnabled(blink::features::kUserMediaElement)) {
|
||||
- LOG_IF(WARNING,
|
||||
- WebRuntimeFeatures::IsPermissionElementEnabledByRuntimeFlag())
|
||||
+ CHECK(!WebRuntimeFeatures::IsPermissionElementEnabledByRuntimeFlag())
|
||||
<< "PermissionElement cannot be enabled in this configuration. Use --"
|
||||
- WebRuntimeFeatures::IsUserMediaElementEnabledByRuntimeFlag())
|
||||
+ CHECK(!WebRuntimeFeatures::IsUserMediaElementEnabledByRuntimeFlag())
|
||||
<< "UserMediaElement cannot be enabled in this configuration. Use --"
|
||||
<< switches::kEnableFeatures << "="
|
||||
<< blink::features::kPermissionElement.name << " instead.";
|
||||
<< blink::features::kUserMediaElement.name << " instead.";
|
||||
diff --git a/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Cromite-Branding.inc b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Cromite-Branding.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Cromite-Branding.inc
|
||||
@@ -0,0 +1,2 @@
|
||||
+SET_CROMITE_FEATURE_ENABLED(kAndroidTabDeclutterArchiveAllButActiveTab);
|
||||
+SET_CROMITE_FEATURE_ENABLED(kGridTabSwitcherUpdate);
|
||||
@@ -0,0 +1 @@
|
||||
+SET_CROMITE_FEATURE_DISABLED(kShowTabListAnimations);
|
||||
diff --git a/tools/grit/grit/grd_reader.py b/tools/grit/grit/grd_reader.py
|
||||
--- a/tools/grit/grit/grd_reader.py
|
||||
+++ b/tools/grit/grit/grd_reader.py
|
||||
|
||||
@@ -11,7 +11,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../browser/ChromeActionModeHandler.java | 4 +-
|
||||
.../chrome/browser/ChromeTabbedActivity.java | 15 +++-
|
||||
...ActivityTabWebContentsDelegateAndroid.java | 10 ++-
|
||||
.../compositor/layouts/LayoutManagerImpl.java | 8 ++
|
||||
.../compositor/layouts/LayoutManagerImpl.java | 9 ++-
|
||||
.../tab/TabContextMenuItemDelegate.java | 7 +-
|
||||
.../chrome/browser/ui/RootUiCoordinator.java | 8 +-
|
||||
.../Customize-selection-popup.grdp | 34 +++++++++
|
||||
@@ -23,7 +23,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../browser/PendingSelectionMenu.java | 8 +-
|
||||
.../browser/SelectionMenuItem.java | 73 ++++++++++++-------
|
||||
.../SelectionActionMenuDelegate.java | 32 +++++---
|
||||
16 files changed, 194 insertions(+), 66 deletions(-)
|
||||
16 files changed, 194 insertions(+), 67 deletions(-)
|
||||
create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Customize-selection-popup.grdp
|
||||
|
||||
diff --git a/android_webview/java/src/org/chromium/android_webview/selection/SamsungSelectionActionMenuDelegate.java b/android_webview/java/src/org/chromium/android_webview/selection/SamsungSelectionActionMenuDelegate.java
|
||||
@@ -81,7 +81,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionMod
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
||||
@@ -897,10 +897,17 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@@ -936,10 +936,17 @@ public class ChromeTabbedActivity extends ChromeActivity implements PreAttachInt
|
||||
@TabLaunchType int type,
|
||||
@TabCreationState int creationState,
|
||||
boolean markedForSelection) {
|
||||
@@ -106,7 +106,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedAct
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
|
||||
@@ -250,6 +250,14 @@ public class ActivityTabWebContentsDelegateAndroid extends TabWebContentsDelegat
|
||||
@@ -253,6 +253,14 @@ public class ActivityTabWebContentsDelegateAndroid extends TabWebContentsDelegat
|
||||
// Skip opening a new Tab if it doesn't make sense.
|
||||
if (mTab.isClosing()) return false;
|
||||
|
||||
@@ -118,47 +118,52 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/tab_activit
|
||||
+ tabLaunchType = TabLaunchType.FROM_LONGPRESS_BACKGROUND_IN_GROUP;
|
||||
+ }
|
||||
+
|
||||
WindowAndroid window = mTab.getWindowAndroid();
|
||||
boolean openingPopup =
|
||||
window != null
|
||||
@@ -294,7 +302,7 @@ public class ActivityTabWebContentsDelegateAndroid extends TabWebContentsDelegat
|
||||
if (ChromeFeatureList.isEnabled(ChromeFeatureList.DOCUMENT_PICTURE_IN_PICTURE_API)
|
||||
&& disposition == WindowOpenDisposition.NEW_PICTURE_IN_PICTURE) {
|
||||
assertNonNull(pictureInPictureWindowOptions);
|
||||
@@ -270,7 +278,7 @@ public class ActivityTabWebContentsDelegateAndroid extends TabWebContentsDelegat
|
||||
mTab,
|
||||
/* shouldPin= */ false,
|
||||
webContents,
|
||||
- TabLaunchType.FROM_LONGPRESS_FOREGROUND,
|
||||
+ tabLaunchType,
|
||||
targetUrl,
|
||||
!openingPopup && !willReparentTab);
|
||||
addTabToModel);
|
||||
if (tab == null) return false;
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java
|
||||
@@ -18,6 +18,7 @@ import android.view.ViewGroup;
|
||||
@@ -20,6 +20,7 @@ import androidx.annotation.Px;
|
||||
import androidx.annotation.VisibleForTesting;
|
||||
|
||||
import org.chromium.base.Callback;
|
||||
+import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.ObserverList;
|
||||
import org.chromium.base.TraceEvent;
|
||||
import org.chromium.base.supplier.ObservableSupplier;
|
||||
@@ -247,6 +248,13 @@ public class LayoutManagerImpl
|
||||
!= TabLaunchType
|
||||
.FROM_COLLABORATION_BACKGROUND_IN_GROUP)
|
||||
|| (!getTabModelSelector().isIncognitoSelected() && incognito);
|
||||
+ boolean selectionPopupTabsForeground =
|
||||
+ ContextUtils.getAppSharedPreferences().getBoolean(
|
||||
+ "selection_popup_tabs_foreground", false);
|
||||
+ if (selectionPopupTabsForeground) {
|
||||
+ willBeSelected = launchType != TabLaunchType.FROM_RESTORE_TABS_UI
|
||||
+ || (!getTabModelSelector().isIncognitoSelected() && incognito);
|
||||
+ }
|
||||
float lastTapX = LocalizationUtils.isLayoutRtl() ? mHost.getWidth() * mPxToDp : 0.f;
|
||||
float lastTapY = 0.f;
|
||||
if (launchType != TabLaunchType.FROM_CHROME_UI) {
|
||||
import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
@@ -243,11 +244,17 @@ public class LayoutManagerImpl
|
||||
boolean willBeSelected = willAddedTabBeSelected(launchType, incognito);
|
||||
float lastTapX = LocalizationUtils.isLayoutRtl() ? mHost.getWidth() * mPxToDp : 0.f;
|
||||
float lastTapY = 0.f;
|
||||
+ boolean selectionPopupTabsForeground =
|
||||
+ ContextUtils.getAppSharedPreferences().getBoolean(
|
||||
+ "selection_popup_tabs_foreground", false);
|
||||
+ if (selectionPopupTabsForeground) {
|
||||
+ willBeSelected = launchType != TabLaunchType.FROM_RESTORE_TABS_UI
|
||||
+ || (!getTabModelSelector().isIncognitoSelected() && incognito);
|
||||
+ }
|
||||
if (launchType != TabLaunchType.FROM_CHROME_UI) {
|
||||
lastTapX = mPxToDp * mLastTapX;
|
||||
lastTapY = mPxToDp * mLastTapY;
|
||||
}
|
||||
-
|
||||
tabCreated(
|
||||
tabId,
|
||||
getTabModelSelector().getCurrentTabId(),
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
|
||||
@@ -430,8 +430,13 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
@@ -433,8 +433,13 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
|
||||
public void onOpenImageInNewTab(GURL url, @Nullable Referrer referrer) {
|
||||
LoadUrlParams loadUrlParams = new LoadUrlParams(url.getSpec());
|
||||
loadUrlParams.setReferrer(referrer);
|
||||
@@ -176,15 +181,15 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextM
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
|
||||
@@ -33,6 +33,7 @@ import androidx.core.view.WindowInsetsCompat;
|
||||
@@ -34,6 +34,7 @@ import androidx.core.view.WindowInsetsCompat;
|
||||
|
||||
import org.chromium.base.Callback;
|
||||
import org.chromium.base.CallbackController;
|
||||
import org.chromium.base.DeviceInfo;
|
||||
+import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.DeviceInfo;
|
||||
import org.chromium.base.TraceEvent;
|
||||
import org.chromium.base.lifetime.Destroyable;
|
||||
import org.chromium.base.metrics.RecordUserAction;
|
||||
@@ -1021,11 +1022,16 @@ public class RootUiCoordinator
|
||||
@@ -1060,11 +1061,16 @@ public class RootUiCoordinator
|
||||
TrackerFactory.getTrackerForProfile(tab.getProfile())
|
||||
.notifyEvent(EventConstants.WEB_SEARCH_PERFORMED);
|
||||
|
||||
@@ -265,7 +270,7 @@ diff --git a/components/android_autofill/browser/java/src/org/chromium/component
|
||||
diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
--- a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
+++ b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
|
||||
@@ -84,4 +84,28 @@ found in the LICENSE file.
|
||||
@@ -89,4 +89,28 @@ found in the LICENSE file.
|
||||
android:key="disable_toolbar_swipeup"
|
||||
android:title="@string/disable_toolbar_swipe_up" />
|
||||
|
||||
@@ -390,7 +395,7 @@ diff --git a/content/public/android/java/src/org/chromium/content/browser/select
|
||||
diff --git a/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java b/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
|
||||
--- a/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
|
||||
+++ b/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
|
||||
@@ -1114,7 +1114,7 @@ public class SelectionPopupControllerImpl extends ActionModeCallbackHelper
|
||||
@@ -1133,7 +1133,7 @@ public class SelectionPopupControllerImpl extends ActionModeCallbackHelper
|
||||
|
||||
private boolean handleAssistMenuItemClick(int order) {
|
||||
// Primary assist action is always the first action in the list so offset by 1.
|
||||
@@ -402,15 +407,15 @@ diff --git a/content/public/android/java/src/org/chromium/content/browser/select
|
||||
diff --git a/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java
|
||||
--- a/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java
|
||||
+++ b/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java
|
||||
@@ -18,6 +18,7 @@ import org.jni_zero.CalledByNative;
|
||||
import org.jni_zero.JNINamespace;
|
||||
@@ -19,6 +19,7 @@ import org.jni_zero.JNINamespace;
|
||||
import org.jni_zero.JniType;
|
||||
import org.jni_zero.NativeMethods;
|
||||
|
||||
+import org.chromium.base.ContextUtils;
|
||||
import org.chromium.base.ObserverList;
|
||||
import org.chromium.base.UserData;
|
||||
import org.chromium.build.annotations.Initializer;
|
||||
@@ -84,6 +85,9 @@ public class SmartSelectionClient implements SelectionClient, UserData {
|
||||
@@ -81,6 +82,9 @@ public class SmartSelectionClient implements SelectionClient, UserData {
|
||||
return null;
|
||||
}
|
||||
|
||||
|
||||
@@ -10,9 +10,10 @@ Original License: BSD-3-Clause - https://spdx.org/licenses/BSD-3-Clause.html
|
||||
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
---
|
||||
chrome/android/java/res/layout/url_bar.xml | 1 +
|
||||
.../browser/omnibox/LocationBarMediator.java | 14 ++++++++---
|
||||
.../chrome/browser/omnibox/UrlBar.java | 24 +++++++++++++++++++
|
||||
3 files changed, 36 insertions(+), 3 deletions(-)
|
||||
.../browser/omnibox/LocationBarMediator.java | 25 +++++++++++++-----
|
||||
.../chrome/browser/omnibox/UrlBar.java | 26 +++++++++++++++++++
|
||||
.../browser/omnibox/UrlBarViewBinder.java | 1 +
|
||||
4 files changed, 47 insertions(+), 6 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/java/res/layout/url_bar.xml b/chrome/android/java/res/layout/url_bar.xml
|
||||
--- a/chrome/android/java/res/layout/url_bar.xml
|
||||
@@ -28,34 +29,80 @@ diff --git a/chrome/android/java/res/layout/url_bar.xml b/chrome/android/java/re
|
||||
diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
|
||||
--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
|
||||
+++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
|
||||
@@ -409,8 +409,17 @@ class LocationBarMediator
|
||||
if (!mUrlFocusedWithPastedText
|
||||
&& !shouldRetainOmniboxOnFocus
|
||||
&& mLocationBarLayout.shouldClearTextOnFocus()) {
|
||||
- setUrlBarText(
|
||||
- UrlBarData.EMPTY, UrlBar.ScrollType.NO_SCROLL, SelectionState.SELECT_END);
|
||||
+ UrlBarData data = mLocationBarDataProvider.getUrlBarData();
|
||||
+ @SelectionState int selectionState = SelectionState.SELECT_ALL;
|
||||
+ GURL url = mLocationBarDataProvider.getUrlBarData().url;
|
||||
+ if (url != null && mTemplateUrlServiceSupplier.get() != null) {
|
||||
+ String searchParams =
|
||||
+ mTemplateUrlServiceSupplier.get().getSearchQueryForUrl(url);
|
||||
+ if (searchParams != null && !searchParams.isEmpty()) {
|
||||
+ data = UrlBarData.forUrlAndText(data.url, data.displayText, searchParams);
|
||||
+ }
|
||||
+ }
|
||||
+ setUrlBarText(data, UrlBar.ScrollType.NO_SCROLL, selectionState);
|
||||
} else if (shouldRetainOmniboxOnFocus) {
|
||||
mUrlCoordinator.setSelectAllOnFocus(true);
|
||||
@@ -591,7 +591,7 @@ class LocationBarMediator
|
||||
if (NativePage.isChromePageUrl(currentUrl, mLocationBarDataProvider.isOffTheRecord())
|
||||
&& mCurrentInput != null) {
|
||||
mCurrentInput.setUserText(null);
|
||||
- beginOrResumeInput(/* activateNewSession= */ false);
|
||||
+ beginOrResumeInput(/* activateNewSession= */ false, /* wasFocus */ false);
|
||||
} else {
|
||||
setUrlBarText(
|
||||
mLocationBarDataProvider.getUrlBarData(),
|
||||
@@ -842,7 +842,7 @@ class LocationBarMediator
|
||||
if (mCurrentInput == null) return; // session not started yet.
|
||||
|
||||
mCurrentInput.setUserText(null);
|
||||
- beginOrResumeInput(/* activateNewSession= */ false);
|
||||
+ beginOrResumeInput(/* activateNewSession= */ false, /* wasFocus */ false);
|
||||
updateButtonVisibility();
|
||||
mUrlCoordinator.requestAccessibilityFocus();
|
||||
}
|
||||
@@ -923,7 +923,7 @@ class LocationBarMediator
|
||||
// Existing text (e.g. if the user pasted via the fakebox) from the fake box
|
||||
// should be restored after toggling the focus.
|
||||
if (mCurrentInput != null && !mCurrentInput.getUserText().isEmpty()) {
|
||||
- beginOrResumeInput(/* activateNewSession= */ false);
|
||||
+ beginOrResumeInput(/* activateNewSession= */ false, /* wasFocus */ false);
|
||||
}
|
||||
}
|
||||
@@ -1898,7 +1907,6 @@ class LocationBarMediator
|
||||
mUrlCoordinator.setKeyboardVisibility(true, false);
|
||||
|
||||
@@ -968,7 +968,7 @@ class LocationBarMediator
|
||||
*/
|
||||
@EnsuresNonNullIf("mCurrentInput")
|
||||
@VisibleForTesting
|
||||
- void beginOrResumeInput(boolean activateNewSession) {
|
||||
+ void beginOrResumeInput(boolean activateNewSession, boolean wasFocus) {
|
||||
// Do not instantiate a new ephemeral session unless we're activating it as well.
|
||||
var session = FuseboxSessionState.from(mLocationBarDataProvider);
|
||||
|
||||
@@ -1002,6 +1002,19 @@ class LocationBarMediator
|
||||
.addSyncObserverAndCallIfNonNull(mAutocompleteRequestTypeObserver);
|
||||
|
||||
UrlBarData data = UrlBarData.forNonUrlText(mCurrentInput.getUserText());
|
||||
+ if (wasFocus) {
|
||||
+ data = mLocationBarDataProvider.getUrlBarData();
|
||||
+ GURL url = mLocationBarDataProvider.getUrlBarData().url;
|
||||
+ if (url != null && mTemplateUrlServiceSupplier.get() != null) {
|
||||
+ String searchParams =
|
||||
+ mTemplateUrlServiceSupplier.get().getSearchQueryForUrl(url);
|
||||
+ if (searchParams != null && !searchParams.isEmpty()) {
|
||||
+ mCurrentInput.setUserText(searchParams);
|
||||
+ data = UrlBarData.forUrlAndText(data.url, data.displayText, searchParams);
|
||||
+ }
|
||||
+ }
|
||||
+ mCurrentInput.setSelection(0, Integer.MAX_VALUE);
|
||||
+ }
|
||||
mUrlCoordinator.setUrlBarData(
|
||||
data, UrlBar.ScrollType.NO_SCROLL, mCurrentInput.getSelection());
|
||||
|
||||
@@ -1076,7 +1089,7 @@ class LocationBarMediator
|
||||
// This call is permitted to happen before anyone else is activated, and
|
||||
// must be called before everyone else cleans up.
|
||||
if (hasFocus) {
|
||||
- beginOrResumeInput(/* activateNewSession= */ true);
|
||||
+ beginOrResumeInput(/* activateNewSession= */ true, /* wasFocus */ true);
|
||||
} else {
|
||||
endInputInternal();
|
||||
}
|
||||
@@ -1953,7 +1966,7 @@ class LocationBarMediator
|
||||
}
|
||||
|
||||
// Wait for the Url focus change before refreshing autocomplete.
|
||||
- beginOrResumeInput(/* activateNewSession= */ true);
|
||||
+ beginOrResumeInput(/* activateNewSession= */ true, /* wasFocus */ false);
|
||||
}
|
||||
|
||||
-
|
||||
// UrlBarDelegate implementation.
|
||||
|
||||
@Override
|
||||
/**
|
||||
diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
|
||||
--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
|
||||
+++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
|
||||
@@ -67,18 +114,26 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
import android.os.SystemClock;
|
||||
import android.text.Editable;
|
||||
import android.text.InputType;
|
||||
@@ -116,6 +117,7 @@ public class UrlBar extends AutocompleteEditText {
|
||||
@@ -57,6 +58,7 @@ import org.chromium.components.browser_ui.util.FirstDrawDetector;
|
||||
import org.chromium.components.omnibox.OmniboxFeatures;
|
||||
import org.chromium.ui.KeyboardVisibilityDelegate;
|
||||
import org.chromium.ui.base.KeyNavigationUtil;
|
||||
+import org.chromium.ui.base.DeviceFormFactor;
|
||||
import org.chromium.ui.display.DisplayAndroid;
|
||||
import org.chromium.ui.display.DisplayUtil;
|
||||
|
||||
@@ -109,6 +111,7 @@ public class UrlBar extends AutocompleteEditText {
|
||||
private boolean mFocusEventEmitted;
|
||||
private boolean mAllowFocus = true;
|
||||
private boolean mShouldSendTypingStartedEvent;
|
||||
|
||||
private boolean mAllowMultilineInput;
|
||||
+ private boolean mPendingSelectAll;
|
||||
private boolean mCurrentInputCanBeWrapped;
|
||||
|
||||
private boolean mPendingScroll;
|
||||
private boolean mIsInCct;
|
||||
|
||||
@@ -369,6 +371,28 @@ public class UrlBar extends AutocompleteEditText {
|
||||
@@ -332,6 +335,29 @@ public class UrlBar extends AutocompleteEditText {
|
||||
mPendingScroll = false;
|
||||
}
|
||||
fixupTextDirection();
|
||||
|
||||
mShouldSendTypingStartedEvent = focused;
|
||||
+
|
||||
+ if (mPendingSelectAll) {
|
||||
+ UrlBar sender = this;
|
||||
@@ -94,7 +149,8 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
+
|
||||
+ @Override
|
||||
+ public void selectAll() {
|
||||
+ mPendingSelectAll = true;
|
||||
+ if (!DeviceFormFactor.isNonMultiDisplayContextOnTablet(getContext()))
|
||||
+ mPendingSelectAll = true;
|
||||
+ super.selectAll();
|
||||
+ }
|
||||
+
|
||||
@@ -104,4 +160,15 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow
|
||||
}
|
||||
|
||||
@Override
|
||||
diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBarViewBinder.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBarViewBinder.java
|
||||
--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBarViewBinder.java
|
||||
+++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBarViewBinder.java
|
||||
@@ -100,6 +100,7 @@ class UrlBarViewBinder {
|
||||
selectionRange = Range.create(textLength, textLength);
|
||||
}
|
||||
view.setSelection(selectionRange.getLower(), selectionRange.getUpper());
|
||||
+ view.selectAll();
|
||||
view.requestAccessibilityFocus();
|
||||
}
|
||||
} else if (UrlBarProperties.TEXT_COLOR.equals(propertyKey)) {
|
||||
--
|
||||
|
||||
@@ -42,7 +42,7 @@ diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibil
|
||||
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
|
||||
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
|
||||
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
|
||||
@@ -1142,6 +1142,11 @@ public class WebContentsAccessibilityImpl extends AccessibilityNodeProviderCompa
|
||||
@@ -1325,6 +1325,11 @@ public class WebContentsAccessibilityImpl extends AccessibilityNodeProviderCompa
|
||||
structure.setChildCount(0);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -14,7 +14,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/main_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
||||
@@ -96,7 +96,8 @@ found in the LICENSE file.
|
||||
@@ -98,7 +98,8 @@ found in the LICENSE file.
|
||||
android:fragment="org.chromium.chrome.browser.tasks.tab_management.TabsSettings"
|
||||
android:key="tabs"
|
||||
android:order="18"
|
||||
@@ -22,8 +22,8 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
||||
+ android:title="@string/tabs_settings_title"
|
||||
+ app:isPreferenceVisible="false"/>
|
||||
<Preference
|
||||
android:fragment="org.chromium.chrome.browser.homepage.settings.HomepageSettings"
|
||||
android:key="homepage"
|
||||
android:fragment="org.chromium.chrome.browser.glic.GlicSettings"
|
||||
android:key="glic"
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabArchiveSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabArchiveSettings.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabArchiveSettings.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabArchiveSettings.java
|
||||
|
||||
@@ -16,7 +16,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/third_party/blink/renderer/core/css/parser/css_supports_parser.cc b/third_party/blink/renderer/core/css/parser/css_supports_parser.cc
|
||||
--- a/third_party/blink/renderer/core/css/parser/css_supports_parser.cc
|
||||
+++ b/third_party/blink/renderer/core/css/parser/css_supports_parser.cc
|
||||
@@ -263,7 +263,7 @@ bool CSSSupportsParser::ConsumeBlinkFeatureFn(CSSParserTokenStream& stream) {
|
||||
@@ -298,7 +298,7 @@ bool CSSSupportsParser::ConsumeBlinkFeatureFn(CSSParserTokenStream& stream) {
|
||||
feature_name.Value().Utf8()) &&
|
||||
guard.Release()) {
|
||||
stream.ConsumeWhitespace();
|
||||
@@ -28,7 +28,7 @@ diff --git a/third_party/blink/renderer/core/css/parser/css_supports_parser.cc b
|
||||
diff --git a/third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc b/third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc
|
||||
--- a/third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc
|
||||
+++ b/third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc
|
||||
@@ -520,7 +520,7 @@ DocumentRulePredicate* DocumentRulePredicate::Parse(
|
||||
@@ -521,7 +521,7 @@ DocumentRulePredicate* DocumentRulePredicate::Parse(
|
||||
HeapVector<CSSSelector> arena;
|
||||
CSSPropertyValueSet* empty_properties =
|
||||
ImmutableCSSPropertyValueSet::Create(base::span<CSSPropertyValue>(),
|
||||
|
||||
@@ -15,7 +15,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -1419,7 +1419,7 @@
|
||||
@@ -1507,7 +1507,7 @@
|
||||
},
|
||||
{
|
||||
name: "CSSDynamicRangeLimit",
|
||||
|
||||
@@ -4,26 +4,24 @@ Subject: Disable Compose feature
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
chrome/browser/ui/webui/settings/settings_ui.cc | 6 ++++--
|
||||
chrome/browser/ui/webui/settings/settings_ui.cc | 4 ++--
|
||||
components/compose/core/browser/compose_features.cc | 2 ++
|
||||
components/compose/features.gni | 2 +-
|
||||
3 files changed, 7 insertions(+), 3 deletions(-)
|
||||
3 files changed, 5 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/chrome/browser/ui/webui/settings/settings_ui.cc b/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
--- a/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
+++ b/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
@@ -20,7 +20,9 @@
|
||||
@@ -21,7 +21,7 @@
|
||||
#include "chrome/browser/browser_features.h"
|
||||
#include "chrome/browser/browser_process.h"
|
||||
#include "chrome/browser/commerce/shopping_service_factory.h"
|
||||
-#include "chrome/browser/compose/compose_enabling.h"
|
||||
+// #if BUILDFLAG(ENABLE_COMPOSE)
|
||||
+// #include "chrome/browser/compose/compose_enabling.h"
|
||||
+// #endif
|
||||
#include "chrome/browser/glic/public/glic_enabling.h"
|
||||
#include "chrome/browser/glic/public/glic_keyed_service.h"
|
||||
#include "chrome/browser/history_embeddings/history_embeddings_utils.h"
|
||||
#include "chrome/browser/optimization_guide/optimization_guide_keyed_service.h"
|
||||
#include "chrome/browser/optimization_guide/optimization_guide_keyed_service_factory.h"
|
||||
@@ -359,7 +361,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
|
||||
@@ -369,7 +369,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
|
||||
base::FeatureList::IsEnabled(permissions::features::kKeyboardLockPrompt));
|
||||
|
||||
#if BUILDFLAG(ENABLE_COMPOSE)
|
||||
|
||||
@@ -12,16 +12,16 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
|
||||
--- a/chrome/browser/chrome_content_browser_client.cc
|
||||
+++ b/chrome/browser/chrome_content_browser_client.cc
|
||||
@@ -1452,8 +1452,7 @@ void ChromeContentBrowserClient::RegisterProfilePrefs(
|
||||
@@ -1527,8 +1527,7 @@ void ChromeContentBrowserClient::RegisterProfilePrefs(
|
||||
registry->RegisterBooleanPref(prefs::kSandboxExternalProtocolBlocked, true);
|
||||
registry->RegisterBooleanPref(prefs::kSSLErrorOverrideAllowed, true);
|
||||
registry->RegisterListPref(prefs::kSSLErrorOverrideAllowedForOrigins);
|
||||
- registry->RegisterBooleanPref(prefs::kCompressionDictionaryTransportEnabled,
|
||||
- true);
|
||||
+ registry->RegisterBooleanPref(prefs::kCompressionDictionaryTransportEnabled, false);
|
||||
#if BUILDFLAG(ENABLE_ON_DEVICE_TRANSLATION)
|
||||
registry->RegisterBooleanPref(prefs::kTranslatorAPIAllowed, true);
|
||||
#endif
|
||||
registry->RegisterBooleanPref(
|
||||
prefs::kSuppressDifferentOriginSubframeJSDialogs, true);
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
diff --git a/cromite_flags/services/network/public/cpp/features_cc/Disable-Compression-Dictionary-Transport.inc b/cromite_flags/services/network/public/cpp/features_cc/Disable-Compression-Dictionary-Transport.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
|
||||
@@ -10,7 +10,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/chrome/browser/device_api/device_service_impl.cc b/chrome/browser/device_api/device_service_impl.cc
|
||||
--- a/chrome/browser/device_api/device_service_impl.cc
|
||||
+++ b/chrome/browser/device_api/device_service_impl.cc
|
||||
@@ -155,6 +155,7 @@ bool IsPermissionsPolicyFeatureEnabled() {
|
||||
@@ -147,6 +147,7 @@ bool IsAffiliatedUser() {
|
||||
|
||||
bool IsTrustedContext(content::RenderFrameHost& host,
|
||||
const url::Origin& origin) {
|
||||
@@ -18,7 +18,7 @@ diff --git a/chrome/browser/device_api/device_service_impl.cc b/chrome/browser/d
|
||||
// Do not create the service for the incognito mode.
|
||||
if (GetProfile(host)->IsIncognitoProfile()) {
|
||||
return false;
|
||||
@@ -350,6 +351,10 @@ void DeviceServiceImpl::GetAnnotatedLocation(
|
||||
@@ -323,6 +324,10 @@ void DeviceServiceImpl::GetAnnotatedLocation(
|
||||
void DeviceServiceImpl::GetDeviceAttribute(
|
||||
void (DeviceAttributeApi::*method)(DeviceAttributeCallback callback),
|
||||
DeviceAttributeCallback callback) {
|
||||
@@ -26,7 +26,7 @@ diff --git a/chrome/browser/device_api/device_service_impl.cc b/chrome/browser/d
|
||||
+ device_attribute_api_->ReportNotAllowedError(std::move(callback));
|
||||
+ return;
|
||||
+ }
|
||||
if (!IsAffiliatedUser()) {
|
||||
if (!IsAffiliatedUser() &&
|
||||
!IsDevModeInstalledIwaOrigin(render_frame_host(), origin())) {
|
||||
device_attribute_api_->ReportNotAffiliatedError(std::move(callback));
|
||||
return;
|
||||
--
|
||||
|
||||
@@ -47,7 +47,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -2286,7 +2286,7 @@
|
||||
@@ -2462,7 +2462,7 @@
|
||||
{
|
||||
name: "FedCm",
|
||||
public: true,
|
||||
|
||||
@@ -5,13 +5,13 @@ Subject: Disable GSA by default
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../src/org/chromium/base/PackageUtils.java | 1 +
|
||||
.../chrome/browser/IntentHandler.java | 7 ----
|
||||
.../chrome/browser/IntentHandler.java | 6 ----
|
||||
.../chrome/browser/share/LensUtils.java | 14 ++------
|
||||
.../chromium/chrome/browser/gsa/GSAUtils.java | 34 +++----------------
|
||||
.../GoogleBottomBarActionsHandler.java | 19 ++---------
|
||||
.../chrome/browser/pdf/PdfCoordinator.java | 2 +-
|
||||
.../Disable-GSA-by-default.inc | 1 +
|
||||
7 files changed, 12 insertions(+), 66 deletions(-)
|
||||
7 files changed, 12 insertions(+), 65 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Disable-GSA-by-default.inc
|
||||
|
||||
diff --git a/base/android/java/src/org/chromium/base/PackageUtils.java b/base/android/java/src/org/chromium/base/PackageUtils.java
|
||||
@@ -28,7 +28,7 @@ diff --git a/base/android/java/src/org/chromium/base/PackageUtils.java b/base/an
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
|
||||
@@ -49,7 +49,6 @@ import org.chromium.chrome.browser.document.ChromeLauncherActivity;
|
||||
@@ -51,7 +51,6 @@ import org.chromium.chrome.browser.document.ChromeLauncherActivity;
|
||||
import org.chromium.chrome.browser.externalnav.IntentWithRequestMetadataHandler;
|
||||
import org.chromium.chrome.browser.externalnav.IntentWithRequestMetadataHandler.RequestMetadata;
|
||||
import org.chromium.chrome.browser.flags.ChromeFeatureList;
|
||||
@@ -36,7 +36,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.j
|
||||
import org.chromium.chrome.browser.omnibox.suggestions.AutocompleteCoordinator;
|
||||
import org.chromium.chrome.browser.pdf.PdfUtils;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
@@ -303,9 +302,6 @@ public class IntentHandler {
|
||||
@@ -310,9 +309,6 @@ public class IntentHandler {
|
||||
public static final String EXTRA_TIPS_NOTIFICATION_FEATURE_TYPE =
|
||||
"org.chromium.chrome.browser.tips_notification_feature_type";
|
||||
|
||||
@@ -46,15 +46,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.j
|
||||
/** Action to launch the Chrome Item Picker UI, e.g.: tabs. */
|
||||
public static final String EXTRA_OPEN_CHROME_ITEM_PICKER =
|
||||
"org.chromium.chrome.browser.actions.open_chrome_item_picker";
|
||||
@@ -313,7 +309,6 @@ public class IntentHandler {
|
||||
/** Optional extra for the maximum number of items the user can select. */
|
||||
public static final String EXTRA_ITEM_PICKER_MAX_SELECTABLE_ITEMS =
|
||||
"org.chromium.chrome.browser.extras.item_picker_max_selectable_items";
|
||||
-
|
||||
public static final String EXTRA_ITEM_PICKER_ERROR =
|
||||
"org.chromium.chrome.browser.chrome_item_picker.EXTRA_ITEM_PICKER_ERROR";
|
||||
|
||||
@@ -569,8 +564,6 @@ public class IntentHandler {
|
||||
@@ -573,8 +569,6 @@ public class IntentHandler {
|
||||
return ExternalAppId.LINE;
|
||||
} else if (PACKAGE_WHATSAPP.equals(packageName)) {
|
||||
return ExternalAppId.WHATSAPP;
|
||||
@@ -74,7 +66,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/LensUtils
|
||||
import org.chromium.components.externalauth.ExternalAuthUtils;
|
||||
|
||||
/** This class provides utilities for intenting into Google Lens. */
|
||||
@@ -50,12 +49,7 @@ public class LensUtils {
|
||||
@@ -49,12 +48,7 @@ public class LensUtils {
|
||||
if (context == null) {
|
||||
return "";
|
||||
}
|
||||
@@ -87,7 +79,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/LensUtils
|
||||
}
|
||||
}
|
||||
|
||||
@@ -78,15 +72,11 @@ public class LensUtils {
|
||||
@@ -77,15 +71,11 @@ public class LensUtils {
|
||||
* @return Whether the package is valid.
|
||||
*/
|
||||
public static boolean isValidAgsaPackage() {
|
||||
@@ -240,7 +232,7 @@ diff --git a/chrome/browser/ui/android/google_bottom_bar/java/src/org/chromium/c
|
||||
diff --git a/chrome/browser/ui/android/pdf/java/src/org/chromium/chrome/browser/pdf/PdfCoordinator.java b/chrome/browser/ui/android/pdf/java/src/org/chromium/chrome/browser/pdf/PdfCoordinator.java
|
||||
--- a/chrome/browser/ui/android/pdf/java/src/org/chromium/chrome/browser/pdf/PdfCoordinator.java
|
||||
+++ b/chrome/browser/ui/android/pdf/java/src/org/chromium/chrome/browser/pdf/PdfCoordinator.java
|
||||
@@ -276,7 +276,7 @@ public class PdfCoordinator {
|
||||
@@ -351,7 +351,7 @@ public class PdfCoordinator implements PdfActionsDelegate {
|
||||
}
|
||||
|
||||
@Nullable String requestAssistContent(String filename, boolean isWorkProfile) {
|
||||
|
||||
@@ -16,7 +16,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java b/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java
|
||||
--- a/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java
|
||||
+++ b/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java
|
||||
@@ -162,6 +162,7 @@ public class InstalledAppProviderImpl implements InstalledAppProvider {
|
||||
@@ -137,6 +137,7 @@ public class InstalledAppProviderImpl implements InstalledAppProvider {
|
||||
final Url manifestUrl,
|
||||
final boolean addSavedRelatedApplications,
|
||||
final FilterInstalledApps_Response callback) {
|
||||
@@ -58,7 +58,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -3037,9 +3037,8 @@
|
||||
@@ -3266,9 +3266,8 @@
|
||||
status: "stable",
|
||||
},
|
||||
{
|
||||
|
||||
@@ -5,8 +5,9 @@ Subject: Disable PrivacyGuide
|
||||
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
---
|
||||
chrome/android/java/res/xml/privacy_preferences.xml | 1 +
|
||||
chrome/browser/prefs/browser_prefs.cc | 2 +-
|
||||
chrome/browser/ui/webui/settings/settings_ui.cc | 3 +--
|
||||
2 files changed, 2 insertions(+), 2 deletions(-)
|
||||
3 files changed, 3 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/privacy_preferences.xml
|
||||
@@ -19,10 +20,22 @@ diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/androi
|
||||
android:title="@string/privacy_guide_pref_title"
|
||||
android:summary="@string/privacy_guide_pref_summary"
|
||||
android:fragment="org.chromium.chrome.browser.privacy_guide.PrivacyGuideFragment" />
|
||||
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
|
||||
--- a/chrome/browser/prefs/browser_prefs.cc
|
||||
+++ b/chrome/browser/prefs/browser_prefs.cc
|
||||
@@ -2158,7 +2158,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
|
||||
registry->RegisterBooleanPref(webauthn::pref_names::kAllowWithBrokenCerts,
|
||||
false);
|
||||
|
||||
- registry->RegisterBooleanPref(prefs::kPrivacyGuideViewed, false);
|
||||
+ registry->RegisterBooleanPref(prefs::kPrivacyGuideViewed, true);
|
||||
|
||||
RegisterProfilePrefsForMigration(registry);
|
||||
|
||||
diff --git a/chrome/browser/ui/webui/settings/settings_ui.cc b/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
--- a/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
+++ b/chrome/browser/ui/webui/settings/settings_ui.cc
|
||||
@@ -336,8 +336,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
|
||||
@@ -342,8 +342,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
|
||||
bool show_privacy_guide =
|
||||
|
||||
@@ -3,15 +3,27 @@ Date: Wed, 24 Jan 2024 12:19:44 +0000
|
||||
Subject: Disable Read Aloud by default
|
||||
|
||||
---
|
||||
.../flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc | 2 ++
|
||||
1 file changed, 2 insertions(+)
|
||||
chrome/browser/prefs/browser_prefs.cc | 2 +-
|
||||
.../flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc | 1 +
|
||||
2 files changed, 2 insertions(+), 1 deletion(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc
|
||||
|
||||
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
|
||||
--- a/chrome/browser/prefs/browser_prefs.cc
|
||||
+++ b/chrome/browser/prefs/browser_prefs.cc
|
||||
@@ -1505,7 +1505,7 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
registry->RegisterBooleanPref(policy::policy_prefs::kBackForwardCacheEnabled,
|
||||
true);
|
||||
- registry->RegisterBooleanPref(policy::policy_prefs::kReadAloudEnabled, true);
|
||||
+ registry->RegisterBooleanPref(policy::policy_prefs::kReadAloudEnabled, false);
|
||||
#endif // BUILDFLAG(IS_ANDROID)
|
||||
|
||||
// Below this point is for platform-specific and compile-time conditional
|
||||
diff --git a/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/Disable-Read-Aloud.inc
|
||||
@@ -0,0 +1,2 @@
|
||||
+SET_CROMITE_FEATURE_DISABLED(kReadAloud);
|
||||
@@ -0,0 +1 @@
|
||||
+SET_CROMITE_FEATURE_DISABLED(kReadAloudPlayback);
|
||||
--
|
||||
|
||||
@@ -5,15 +5,15 @@ Subject: Disable Real Box
|
||||
Real-box is search box in ntp
|
||||
---
|
||||
chrome/browser/prefs/browser_prefs.cc | 2 +-
|
||||
.../browser/resources/new_tab_page/app.html | 19 -------------------
|
||||
.../browser/resources/new_tab_page/app.html | 19 +------------------
|
||||
.../searchbox/searchbox_handler.cc | 1 +
|
||||
components/search/ntp_features.cc | 4 ++--
|
||||
4 files changed, 4 insertions(+), 22 deletions(-)
|
||||
4 files changed, 5 insertions(+), 21 deletions(-)
|
||||
|
||||
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
|
||||
--- a/chrome/browser/prefs/browser_prefs.cc
|
||||
+++ b/chrome/browser/prefs/browser_prefs.cc
|
||||
@@ -1987,7 +1987,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
|
||||
@@ -2130,7 +2130,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
|
||||
registry->RegisterBooleanPref(
|
||||
prefs::kLensRegionSearchEnabled, true,
|
||||
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
|
||||
@@ -25,14 +25,14 @@ diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browse
|
||||
diff --git a/chrome/browser/resources/new_tab_page/app.html b/chrome/browser/resources/new_tab_page/app.html
|
||||
--- a/chrome/browser/resources/new_tab_page/app.html
|
||||
+++ b/chrome/browser/resources/new_tab_page/app.html
|
||||
@@ -40,25 +40,6 @@ import {nothing} from '//resources/lit/v3_0/lit.rollup.js';
|
||||
?hidden="${!this.showScrim_}"></div>
|
||||
` : ''}
|
||||
<div id="searchboxContainer">
|
||||
- <cr-searchbox id="searchbox" ?is-dark="${this.isThemeDark_()}"
|
||||
@@ -43,24 +43,7 @@ import {nothing} from '//resources/lit/v3_0/lit.rollup.js';
|
||||
<div id="searchboxContainer"
|
||||
@focusin="${this.onSearchboxContainerFocusin_}"
|
||||
@focusout="${this.onSearchboxContainerFocusout_}">
|
||||
- <ntp-searchbox id="searchbox" ?is-dark="${this.isThemeDark_()}"
|
||||
- placeholder-text="$i18n{searchBoxPlaceholder}"
|
||||
- ?color-source-is-baseline="${this.colorSourceIsBaseline}"
|
||||
- @open-composebox="${this.openComposebox_}"
|
||||
- @open-composebox="${this.onOpenComposebox_}"
|
||||
- @open-lens-search="${this.onOpenLensSearch_}"
|
||||
- @open-voice-search="${this.onOpenVoiceSearch_}" ?shown="${this.realboxShown_}"
|
||||
- ?had-secondary-side="${this.realboxHadSecondarySide}"
|
||||
@@ -44,20 +44,20 @@ diff --git a/chrome/browser/resources/new_tab_page/app.html b/chrome/browser/res
|
||||
- searchbox-layout-mode="${this.realboxLayoutMode_}"
|
||||
- ?ntp-realbox-next-enabled="${this.ntpRealboxNextEnabled_}"
|
||||
- ?cycling-placeholders="${this.searchboxCyclingPlaceholders_}"
|
||||
- @searchbox-input-focus-changed="${this.onInputFocusChanged_}"
|
||||
- context-menu-glif-animation-state="${this.contextMenuGlifAnimationState_}"
|
||||
- ?multi-line-enabled="${this.multiLineEnabled_}">
|
||||
- </cr-searchbox>
|
||||
- </ntp-searchbox>
|
||||
+ <div id="searchbox"></div>
|
||||
${this.showComposebox_ ? html`
|
||||
${this.enableModalComposebox_ ? html`
|
||||
<div id="dialogAnchor"></div>
|
||||
<div id="dialogAnchor"></div>
|
||||
<dialog id="composeboxDialog">
|
||||
diff --git a/chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.cc b/chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.cc
|
||||
--- a/chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.cc
|
||||
+++ b/chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.cc
|
||||
@@ -299,6 +299,7 @@ void SearchboxHandler::SetupWebUIDataSource(content::WebUIDataSource* source,
|
||||
Profile* profile,
|
||||
@@ -307,6 +307,7 @@ void SearchboxHandler::SetupWebUIDataSource(content::WebUIDataSource* source,
|
||||
bool enable_voice_search,
|
||||
bool enable_lens_search) {
|
||||
bool enable_lens_search,
|
||||
bool session_allows_drag_and_drop) {
|
||||
+ enable_lens_search = false;
|
||||
// The WebUI Omnibox code will override this to `true` to adjust various
|
||||
// color and layout options.
|
||||
@@ -65,7 +65,7 @@ diff --git a/chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.c
|
||||
diff --git a/components/search/ntp_features.cc b/components/search/ntp_features.cc
|
||||
--- a/components/search/ntp_features.cc
|
||||
+++ b/components/search/ntp_features.cc
|
||||
@@ -114,7 +114,7 @@ BASE_FEATURE(kNtpDriveModuleShowSixFiles, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
@@ -91,7 +91,7 @@ BASE_FEATURE(kNtpDriveModuleSegmentation, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
// If enabled, logo will be shown.
|
||||
// This is a kill switch. Keep indefinitely.
|
||||
@@ -74,7 +74,7 @@ diff --git a/components/search/ntp_features.cc b/components/search/ntp_features.
|
||||
|
||||
// If enabled, middle slot promo will be shown.
|
||||
// This is a kill switch. Keep indefinitely.
|
||||
@@ -156,7 +156,7 @@ BASE_FEATURE(kNtpModuleSignInRequirement, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
@@ -133,7 +133,7 @@ BASE_FEATURE(kNtpModuleSignInRequirement, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
// If enabled, OneGoogleBar will be shown.
|
||||
// This is a kill switch. Keep indefinitely.
|
||||
|
||||
@@ -14,7 +14,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -4951,8 +4951,8 @@
|
||||
@@ -5384,8 +5384,8 @@
|
||||
{
|
||||
// Preserves the sticky user activation state after a page navigates to
|
||||
// another same-origin page. https://crbug.com/433729626
|
||||
|
||||
@@ -29,10 +29,10 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../features_cc/Disable-TLS-resumption.inc | 7 +++
|
||||
.../features_h/Disable-TLS-resumption.inc | 5 ++
|
||||
net/http/http_network_session.cc | 1 +
|
||||
net/quic/quic_session_pool.cc | 34 ++++++++++-
|
||||
net/quic/quic_session_pool.cc | 35 ++++++++++-
|
||||
net/socket/ssl_client_socket_impl.cc | 59 +++++++++++++++++++
|
||||
net/socket/ssl_client_socket_impl.h | 2 +
|
||||
7 files changed, 119 insertions(+), 1 deletion(-)
|
||||
7 files changed, 119 insertions(+), 2 deletions(-)
|
||||
create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Disable-TLS-resumption.inc
|
||||
create mode 100644 cromite_flags/net/base/features_cc/Disable-TLS-resumption.inc
|
||||
create mode 100644 cromite_flags/net/base/features_h/Disable-TLS-resumption.inc
|
||||
@@ -79,7 +79,7 @@ new file mode 100644
|
||||
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
|
||||
--- a/net/http/http_network_session.cc
|
||||
+++ b/net/http/http_network_session.cc
|
||||
@@ -218,6 +218,7 @@ HttpNetworkSession::HttpNetworkSession(const HttpNetworkSessionParams& params,
|
||||
@@ -217,6 +217,7 @@ HttpNetworkSession::HttpNetworkSession(const HttpNetworkSessionParams& params,
|
||||
|
||||
next_protos_.push_back(NextProto::kProtoHTTP11);
|
||||
|
||||
@@ -129,15 +129,16 @@ diff --git a/net/quic/quic_session_pool.cc b/net/quic/quic_session_pool.cc
|
||||
QuicSessionRequest::QuicSessionRequest(QuicSessionPool* pool) : pool_(pool) {}
|
||||
|
||||
QuicSessionRequest::~QuicSessionRequest() {
|
||||
@@ -2422,7 +2454,7 @@ QuicSessionPool::CreateCryptoConfigHandle(QuicCryptoClientConfigKey key) {
|
||||
@@ -2429,8 +2461,7 @@ QuicSessionPool::CreateCryptoConfigHandle(QuicCryptoClientConfigKey key) {
|
||||
cert_verifier_, transport_security_state_, sct_auditing_delegate_,
|
||||
std::move(hostnames_to_allow_unknown_roots),
|
||||
key.network_anonymization_key),
|
||||
- std::make_unique<quic::QuicClientSessionCache>(), this);
|
||||
+ std::make_unique<BromiteSessionCache>(), this);
|
||||
- std::make_unique<quic::QuicClientSessionCache>(
|
||||
- kDefaultQuicSessionCacheSize),
|
||||
+ std::make_unique<BromiteSessionCache>(),
|
||||
kDefaultQuicSessionCacheSize, this);
|
||||
|
||||
quic::QuicCryptoClientConfig* crypto_config = crypto_config_owner->config();
|
||||
crypto_config->AddCanonicalSuffix(".c.youtube.com");
|
||||
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
|
||||
--- a/net/socket/ssl_client_socket_impl.cc
|
||||
+++ b/net/socket/ssl_client_socket_impl.cc
|
||||
@@ -175,7 +176,7 @@ diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket
|
||||
Disconnect();
|
||||
}
|
||||
|
||||
@@ -709,6 +735,8 @@ int SSLClientSocketImpl::Init() {
|
||||
@@ -710,6 +736,8 @@ int SSLClientSocketImpl::Init() {
|
||||
}
|
||||
if (session)
|
||||
SSL_set_session(ssl_.get(), session.get());
|
||||
@@ -184,7 +185,7 @@ diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket
|
||||
}
|
||||
|
||||
transport_adapter_ = std::make_unique<SocketBIOAdapter>(
|
||||
@@ -986,6 +1014,35 @@ int SSLClientSocketImpl::DoHandshakeComplete(int result) {
|
||||
@@ -994,6 +1022,35 @@ int SSLClientSocketImpl::DoHandshakeComplete(int result) {
|
||||
: SSLHandshakeDetails::kTLS13Full;
|
||||
}
|
||||
}
|
||||
@@ -220,7 +221,7 @@ diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket
|
||||
UMA_HISTOGRAM_ENUMERATION("Net.SSLHandshakeDetails", details);
|
||||
|
||||
// Measure TLS connections that implement the renegotiation_info and EMS
|
||||
@@ -1625,6 +1682,8 @@ bool SSLClientSocketImpl::IsRenegotiationAllowed() const {
|
||||
@@ -1624,6 +1681,8 @@ bool SSLClientSocketImpl::IsRenegotiationAllowed() const {
|
||||
}
|
||||
|
||||
bool SSLClientSocketImpl::IsCachingEnabled() const {
|
||||
@@ -232,7 +233,7 @@ diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket
|
||||
diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h
|
||||
--- a/net/socket/ssl_client_socket_impl.h
|
||||
+++ b/net/socket/ssl_client_socket_impl.h
|
||||
@@ -127,6 +127,8 @@ class NET_EXPORT_PRIVATE SSLClientSocketImpl
|
||||
@@ -128,6 +128,8 @@ class NET_EXPORT_PRIVATE SSLClientSocketImpl
|
||||
friend class SSLContext;
|
||||
FRIEND_TEST_ALL_PREFIXES(SSLClientSocketTest, ParseServerTrustAnchorIDs);
|
||||
|
||||
|
||||
@@ -21,7 +21,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -5592,8 +5592,7 @@
|
||||
@@ -6054,8 +6054,7 @@
|
||||
status: "stable",
|
||||
},
|
||||
{
|
||||
|
||||
@@ -14,7 +14,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
--- a/components/content_settings/core/browser/content_settings_registry.cc
|
||||
+++ b/components/content_settings/core/browser/content_settings_registry.cc
|
||||
@@ -347,8 +347,13 @@ void ContentSettingsRegistry::Init() {
|
||||
@@ -346,8 +346,13 @@ void ContentSettingsRegistry::Init() {
|
||||
ContentSettingsInfo::INHERIT_IF_LESS_PERMISSIVE,
|
||||
PermissionSettingsInfo::EXCEPTIONS_ON_SECURE_AND_INSECURE_ORIGINS);
|
||||
|
||||
|
||||
@@ -12,7 +12,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
|
||||
--- a/content/child/runtime_features.cc
|
||||
+++ b/content/child/runtime_features.cc
|
||||
@@ -552,6 +552,8 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
|
||||
@@ -528,6 +528,8 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
|
||||
|
||||
WebRuntimeFeatures::EnableRemotePlayback(false);
|
||||
|
||||
@@ -24,7 +24,7 @@ diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.
|
||||
diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc
|
||||
--- a/gpu/config/gpu_finch_features.cc
|
||||
+++ b/gpu/config/gpu_finch_features.cc
|
||||
@@ -196,7 +196,7 @@ BASE_FEATURE(kEnableDrDc,
|
||||
@@ -205,7 +205,7 @@ BASE_FEATURE(kEnableDrDc,
|
||||
// enabled by default on supported platforms.
|
||||
#if BUILDFLAG(IS_APPLE) || BUILDFLAG(IS_WIN) || BUILDFLAG(IS_CHROMEOS) || \
|
||||
BUILDFLAG(IS_ANDROID) || BUILDFLAG(USE_WEBGPU_ON_VULKAN_VIA_GL_INTEROP)
|
||||
@@ -36,7 +36,7 @@ diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc
|
||||
diff --git a/third_party/blink/renderer/modules/webgpu/gpu.cc b/third_party/blink/renderer/modules/webgpu/gpu.cc
|
||||
--- a/third_party/blink/renderer/modules/webgpu/gpu.cc
|
||||
+++ b/third_party/blink/renderer/modules/webgpu/gpu.cc
|
||||
@@ -153,6 +153,8 @@ GPU::GPU(NavigatorBase& navigator)
|
||||
@@ -157,6 +157,8 @@ GPU::GPU(NavigatorBase& navigator)
|
||||
GPU::~GPU() = default;
|
||||
|
||||
WGSLLanguageFeatures* GPU::wgslLanguageFeatures() const {
|
||||
@@ -45,7 +45,7 @@ diff --git a/third_party/blink/renderer/modules/webgpu/gpu.cc b/third_party/blin
|
||||
return wgsl_language_features_.Get();
|
||||
}
|
||||
|
||||
@@ -404,6 +406,7 @@ ScriptPromise<IDLNullable<GPUAdapter>> GPU::requestAdapter(
|
||||
@@ -412,6 +414,7 @@ ScriptPromise<IDLNullable<GPUAdapter>> GPU::requestAdapter(
|
||||
"WebGPU is experimental on this platform. See "
|
||||
"https://github.com/gpuweb/gpuweb/wiki/"
|
||||
"Implementation-Status#implementation-status"));
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -4,21 +4,18 @@ Subject: Disable all promo dialogs
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java | 1 +
|
||||
chrome/browser/ui/browser_ui_prefs.cc | 2 +-
|
||||
.../views/profiles/profile_picker_feature_promo_controller.cc | 1 +
|
||||
.../user_education/impl/browser_feature_promo_controller_20.cc | 1 +
|
||||
.../chrome/browser/user_education/UserEducationHelper.java | 1 +
|
||||
.../browser/user_education/user_education_service_factory.cc | 1 +
|
||||
.../common/feature_promo/feature_promo_registry.cc | 2 ++
|
||||
.../common/feature_promo/impl/feature_promo_controller_20.cc | 1 +
|
||||
.../common/feature_promo/impl/feature_promo_controller_25.cc | 3 ++-
|
||||
9 files changed, 11 insertions(+), 2 deletions(-)
|
||||
.../chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java | 1 +
|
||||
chrome/browser/ui/browser_ui_prefs.cc | 2 +-
|
||||
.../chrome/browser/user_education/UserEducationHelper.java | 1 +
|
||||
chrome/browser/user_education/user_education_service_factory.cc | 1 +
|
||||
.../common/feature_promo/feature_promo_registry.cc | 2 ++
|
||||
.../common/feature_promo/impl/feature_promo_queue.cc | 1 +
|
||||
6 files changed, 7 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
@@ -1858,6 +1858,7 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
@@ -2065,6 +2065,7 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
}
|
||||
|
||||
private boolean maybeShowPromo(Profile profile) {
|
||||
@@ -29,7 +26,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/Tab
|
||||
diff --git a/chrome/browser/ui/browser_ui_prefs.cc b/chrome/browser/ui/browser_ui_prefs.cc
|
||||
--- a/chrome/browser/ui/browser_ui_prefs.cc
|
||||
+++ b/chrome/browser/ui/browser_ui_prefs.cc
|
||||
@@ -187,7 +187,7 @@ void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
|
||||
@@ -191,7 +191,7 @@ void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
|
||||
|
||||
registry->RegisterBooleanPref(prefs::kEnterpriseHardwarePlatformAPIEnabled,
|
||||
false);
|
||||
@@ -38,28 +35,6 @@ diff --git a/chrome/browser/ui/browser_ui_prefs.cc b/chrome/browser/ui/browser_u
|
||||
registry->RegisterBooleanPref(
|
||||
prefs::kExternalProtocolDialogShowAlwaysOpenCheckbox, true);
|
||||
registry->RegisterBooleanPref(prefs::kScreenCaptureAllowed, true);
|
||||
diff --git a/chrome/browser/ui/views/profiles/profile_picker_feature_promo_controller.cc b/chrome/browser/ui/views/profiles/profile_picker_feature_promo_controller.cc
|
||||
--- a/chrome/browser/ui/views/profiles/profile_picker_feature_promo_controller.cc
|
||||
+++ b/chrome/browser/ui/views/profiles/profile_picker_feature_promo_controller.cc
|
||||
@@ -36,6 +36,7 @@ user_education::FeaturePromoResult
|
||||
ProfilePickerFeaturePromoController::CanShowPromoForElement(
|
||||
ui::TrackedElement* anchor_element,
|
||||
const user_education::UserEducationContextPtr&) const {
|
||||
+ if ((true)) return user_education::FeaturePromoResult::kBlockedByUi;
|
||||
return ProfilePicker::IsOpen()
|
||||
? user_education::FeaturePromoResult::Success()
|
||||
: user_education::FeaturePromoResult::kBlockedByUi;
|
||||
diff --git a/chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_20.cc b/chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_20.cc
|
||||
--- a/chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_20.cc
|
||||
+++ b/chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_20.cc
|
||||
@@ -47,6 +47,7 @@ user_education::FeaturePromoResult
|
||||
BrowserFeaturePromoController20::CanShowPromoForElement(
|
||||
ui::TrackedElement* anchor_element,
|
||||
const user_education::UserEducationContextPtr& context) const {
|
||||
+ if ((true)) return user_education::FeaturePromoResult::kBlockedByUi;
|
||||
auto* const browser_context = context->AsA<BrowserUserEducationContext>();
|
||||
CHECK(browser_context && browser_context->IsValid());
|
||||
auto* const browser_view = &browser_context->GetBrowserView();
|
||||
diff --git a/chrome/browser/user_education/java/src/org/chromium/chrome/browser/user_education/UserEducationHelper.java b/chrome/browser/user_education/java/src/org/chromium/chrome/browser/user_education/UserEducationHelper.java
|
||||
--- a/chrome/browser/user_education/java/src/org/chromium/chrome/browser/user_education/UserEducationHelper.java
|
||||
+++ b/chrome/browser/user_education/java/src/org/chromium/chrome/browser/user_education/UserEducationHelper.java
|
||||
@@ -85,7 +60,7 @@ diff --git a/chrome/browser/user_education/user_education_service_factory.cc b/c
|
||||
diff --git a/components/user_education/common/feature_promo/feature_promo_registry.cc b/components/user_education/common/feature_promo/feature_promo_registry.cc
|
||||
--- a/components/user_education/common/feature_promo/feature_promo_registry.cc
|
||||
+++ b/components/user_education/common/feature_promo/feature_promo_registry.cc
|
||||
@@ -20,6 +20,7 @@ FeaturePromoRegistry& FeaturePromoRegistry::operator=(
|
||||
@@ -19,6 +19,7 @@ FeaturePromoRegistry& FeaturePromoRegistry::operator=(
|
||||
FeaturePromoRegistry::~FeaturePromoRegistry() = default;
|
||||
|
||||
void FeaturePromoRegistry::RegisterFeature(FeaturePromoSpecification spec) {
|
||||
@@ -93,7 +68,7 @@ diff --git a/components/user_education/common/feature_promo/feature_promo_regist
|
||||
const base::Feature* const iph_feature = spec.feature();
|
||||
CHECK(iph_feature);
|
||||
CHECK_NE(FeaturePromoSpecification::PromoType::kUnspecified,
|
||||
@@ -35,6 +36,7 @@ NewBadgeRegistry& NewBadgeRegistry::operator=(
|
||||
@@ -34,6 +35,7 @@ NewBadgeRegistry& NewBadgeRegistry::operator=(
|
||||
NewBadgeRegistry::~NewBadgeRegistry() = default;
|
||||
|
||||
void NewBadgeRegistry::RegisterFeature(NewBadgeSpecification spec) {
|
||||
@@ -101,35 +76,15 @@ diff --git a/components/user_education/common/feature_promo/feature_promo_regist
|
||||
const base::Feature* const iph_feature = spec.feature;
|
||||
CHECK(iph_feature);
|
||||
FeatureRegistry<NewBadgeSpecification>::RegisterFeature(*iph_feature,
|
||||
diff --git a/components/user_education/common/feature_promo/impl/feature_promo_controller_20.cc b/components/user_education/common/feature_promo/impl/feature_promo_controller_20.cc
|
||||
--- a/components/user_education/common/feature_promo/impl/feature_promo_controller_20.cc
|
||||
+++ b/components/user_education/common/feature_promo/impl/feature_promo_controller_20.cc
|
||||
@@ -106,6 +106,7 @@ FeaturePromoResult FeaturePromoController20::CanShowPromoCommon(
|
||||
const UserEducationContextPtr& context,
|
||||
ShowSource source,
|
||||
CanShowPromoOutputs* outputs) const {
|
||||
+ if ((true)) return FeaturePromoResult::kBlockedByContext;
|
||||
const bool for_demo = source == ShowSource::kDemo;
|
||||
|
||||
// Ensure that this promo isn't already queued for startup.
|
||||
diff --git a/components/user_education/common/feature_promo/impl/feature_promo_controller_25.cc b/components/user_education/common/feature_promo/impl/feature_promo_controller_25.cc
|
||||
--- a/components/user_education/common/feature_promo/impl/feature_promo_controller_25.cc
|
||||
+++ b/components/user_education/common/feature_promo/impl/feature_promo_controller_25.cc
|
||||
@@ -189,6 +189,7 @@ FeaturePromoController25::~FeaturePromoController25() {
|
||||
FeaturePromoResult FeaturePromoController25::CanShowPromo(
|
||||
const FeaturePromoParams& params,
|
||||
diff --git a/components/user_education/common/feature_promo/impl/feature_promo_queue.cc b/components/user_education/common/feature_promo/impl/feature_promo_queue.cc
|
||||
--- a/components/user_education/common/feature_promo/impl/feature_promo_queue.cc
|
||||
+++ b/components/user_education/common/feature_promo/impl/feature_promo_queue.cc
|
||||
@@ -76,6 +76,7 @@ FeaturePromoResult FeaturePromoQueue::CanShow(
|
||||
const FeaturePromoSpecification& spec,
|
||||
const FeaturePromoParams& promo_params,
|
||||
const UserEducationContextPtr& context) const {
|
||||
+ if ((true)) return FeaturePromoResult::kBlockedByContext;
|
||||
auto* const spec = registry()->GetParamsForFeature(*params.feature);
|
||||
if (!spec) {
|
||||
return FeaturePromoResult::kError;
|
||||
@@ -211,7 +212,7 @@ void FeaturePromoController25::MaybeShowStartupPromo(
|
||||
void FeaturePromoController25::MaybeShowPromo(FeaturePromoParams params,
|
||||
UserEducationContextPtr context) {
|
||||
auto* const spec = registry()->GetParamsForFeature(*params.feature);
|
||||
- if (!spec) {
|
||||
+ if (((true)) || !spec) {
|
||||
PostShowPromoResult(std::move(params.show_promo_result_callback),
|
||||
FeaturePromoResult::kError);
|
||||
return;
|
||||
+ if ((true)) return user_education::FeaturePromoResult::kBlockedByUi;
|
||||
auto required = required_preconditions_provider_->GetPreconditions(
|
||||
spec, promo_params, context);
|
||||
UnownedTypedDataCollection data;
|
||||
--
|
||||
|
||||
@@ -16,7 +16,6 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../apk/AndroidManifest.xml | 3 -
|
||||
chrome/android/java/AndroidManifest.xml | 4 -
|
||||
.../ChromeSiteSettingsDelegate.java | 2 +
|
||||
.../k_anonymity_trust_token_getter.cc | 2 +-
|
||||
.../privacy_page/privacy_page_index.html | 9 -
|
||||
chrome/browser/resources/settings/route.ts | 2 +-
|
||||
.../site_settings/site_settings_page.ts | 1 +
|
||||
@@ -47,14 +46,14 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
third_party/blink/renderer/core/page/page.cc | 2 +-
|
||||
.../platform/runtime_enabled_features.json5 | 20 +-
|
||||
ui/events/android/motion_event_android.cc | 8 +-
|
||||
36 files changed, 103 insertions(+), 437 deletions(-)
|
||||
35 files changed, 102 insertions(+), 436 deletions(-)
|
||||
create mode 100644 cromite_flags/services/network/public/cpp/features_cc/Disable-conversion-measurement-api.inc
|
||||
create mode 100644 cromite_flags/third_party/blink/common/features_cc/Disable-conversion-measurement-api.inc
|
||||
|
||||
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
|
||||
--- a/android_webview/browser/aw_content_browser_client.cc
|
||||
+++ b/android_webview/browser/aw_content_browser_client.cc
|
||||
@@ -1352,6 +1352,7 @@ network::mojom::AttributionSupport
|
||||
@@ -1371,6 +1371,7 @@ network::mojom::AttributionSupport
|
||||
AwContentBrowserClient::GetAttributionSupport(
|
||||
AttributionReportingOsApiState state,
|
||||
bool client_os_disabled) {
|
||||
@@ -62,7 +61,7 @@ diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webv
|
||||
// WebView only supports OS-level attribution and not web-attribution.
|
||||
switch (state) {
|
||||
case AttributionReportingOsApiState::kDisabled:
|
||||
@@ -1370,6 +1371,8 @@ bool AwContentBrowserClient::IsAttributionReportingOperationAllowed(
|
||||
@@ -1389,6 +1390,8 @@ bool AwContentBrowserClient::IsAttributionReportingOperationAllowed(
|
||||
const url::Origin* destination_origin,
|
||||
const url::Origin* reporting_origin,
|
||||
bool* can_bypass) {
|
||||
@@ -74,7 +73,7 @@ diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webv
|
||||
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
|
||||
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
|
||||
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
|
||||
@@ -202,7 +202,7 @@ public class AwSettings {
|
||||
@@ -201,7 +201,7 @@ public class AwSettings {
|
||||
private boolean mSpatialNavigationEnabled; // Default depends on device features.
|
||||
private boolean mEnableSupportedHardwareAcceleratedFeatures;
|
||||
private int mMixedContentMode = WebSettings.MIXED_CONTENT_NEVER_ALLOW;
|
||||
@@ -83,7 +82,7 @@ diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.ja
|
||||
|
||||
@SpeculativeLoadingAllowedFlags
|
||||
private int mSpeculativeLoadingAllowedFlags =
|
||||
@@ -1795,7 +1795,7 @@ public class AwSettings {
|
||||
@@ -1820,7 +1820,7 @@ public class AwSettings {
|
||||
public void setAttributionBehavior(@AttributionBehavior int behavior) {
|
||||
synchronized (mAwSettingsLock) {
|
||||
if (mAttributionBehavior != behavior) {
|
||||
@@ -95,7 +94,7 @@ diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.ja
|
||||
diff --git a/android_webview/tools/system_webview_shell/apk/AndroidManifest.xml b/android_webview/tools/system_webview_shell/apk/AndroidManifest.xml
|
||||
--- a/android_webview/tools/system_webview_shell/apk/AndroidManifest.xml
|
||||
+++ b/android_webview/tools/system_webview_shell/apk/AndroidManifest.xml
|
||||
@@ -178,9 +178,6 @@
|
||||
@@ -191,9 +191,6 @@
|
||||
android:exported="true">
|
||||
</activity>
|
||||
|
||||
@@ -116,7 +115,7 @@ diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/Andro
|
||||
<uses-permission-sdk-23 android:name="android.permission.BLUETOOTH_ADMIN" android:maxSdkVersion="30"/>
|
||||
<uses-permission-sdk-23 android:name="android.permission.BLUETOOTH_CONNECT"/>
|
||||
<!--
|
||||
@@ -1221,9 +1220,6 @@ by a child template that "extends" this file.
|
||||
@@ -1240,9 +1239,6 @@ by a child template that "extends" this file.
|
||||
android:name="com.google.android.gms.cast.framework.ReconnectionService"
|
||||
tools:node="remove" />
|
||||
|
||||
@@ -138,18 +137,6 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/site_settings/C
|
||||
case SiteSettingsCategory.Type.AUTO_DARK_WEB_CONTENT:
|
||||
return ChromeFeatureList.isEnabled(
|
||||
ChromeFeatureList.DARKEN_WEBSITES_CHECKBOX_IN_THEMES_SETTING);
|
||||
diff --git a/chrome/browser/k_anonymity_service/k_anonymity_trust_token_getter.cc b/chrome/browser/k_anonymity_service/k_anonymity_trust_token_getter.cc
|
||||
--- a/chrome/browser/k_anonymity_service/k_anonymity_trust_token_getter.cc
|
||||
+++ b/chrome/browser/k_anonymity_service/k_anonymity_trust_token_getter.cc
|
||||
@@ -122,7 +122,7 @@ KAnonymityTrustTokenGetter::~KAnonymityTrustTokenGetter() = default;
|
||||
|
||||
void KAnonymityTrustTokenGetter::TryGetTrustTokenAndKey(
|
||||
TryGetTrustTokenAndKeyCallback callback) {
|
||||
- if (!identity_manager_ ||
|
||||
+ if (((true)) || !identity_manager_ ||
|
||||
!identity_manager_->HasPrimaryAccount(signin::ConsentLevel::kSignin)) {
|
||||
std::move(callback).Run(std::nullopt);
|
||||
return;
|
||||
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page_index.html b/chrome/browser/resources/settings/privacy_page/privacy_page_index.html
|
||||
--- a/chrome/browser/resources/settings/privacy_page/privacy_page_index.html
|
||||
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page_index.html
|
||||
@@ -172,8 +159,8 @@ diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page_index.h
|
||||
diff --git a/chrome/browser/resources/settings/route.ts b/chrome/browser/resources/settings/route.ts
|
||||
--- a/chrome/browser/resources/settings/route.ts
|
||||
+++ b/chrome/browser/resources/settings/route.ts
|
||||
@@ -79,7 +79,7 @@ function addPrivacyChildRoutes(r: Partial<SettingsRoutes>) {
|
||||
r.SITE_SETTINGS.createChild('smartCardReaders');
|
||||
@@ -82,7 +82,7 @@ function addPrivacyChildRoutes(r: Partial<SettingsRoutes>) {
|
||||
r.SITE_SETTINGS_WEB_PRINTING = r.SITE_SETTINGS.createChild('webPrinting');
|
||||
}
|
||||
// </if>
|
||||
- r.SITE_SETTINGS_AUTO_VERIFY = r.SITE_SETTINGS.createChild('autoVerify');
|
||||
@@ -308,16 +295,16 @@ diff --git a/content/browser/attribution_reporting/attribution_data_host_manager
|
||||
diff --git a/content/browser/attribution_reporting/attribution_host.cc b/content/browser/attribution_reporting/attribution_host.cc
|
||||
--- a/content/browser/attribution_reporting/attribution_host.cc
|
||||
+++ b/content/browser/attribution_reporting/attribution_host.cc
|
||||
@@ -132,8 +132,6 @@ AttributionHost::AttributionHost(WebContents* web_contents)
|
||||
attribution_reporting::features::kConversionMeasurement));
|
||||
|
||||
#if BUILDFLAG(IS_ANDROID)
|
||||
- input_event_tracker_android_ =
|
||||
- std::make_unique<AttributionInputEventTrackerAndroid>(web_contents);
|
||||
@@ -136,8 +136,6 @@ AttributionHost::AttributionHost(WebContents* web_contents)
|
||||
// AttributionInputEventTrackerAndroid without a native view will crash. For
|
||||
// now, just disable this code if the view is null.
|
||||
if (web_contents->GetNativeView()) {
|
||||
- input_event_tracker_android_ =
|
||||
- std::make_unique<AttributionInputEventTrackerAndroid>(web_contents);
|
||||
}
|
||||
#endif
|
||||
}
|
||||
|
||||
@@ -342,6 +340,7 @@ void AttributionHost::NotifyNavigationRegistrationData(
|
||||
@@ -347,6 +345,7 @@ void AttributionHost::NotifyNavigationRegistrationData(
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -328,7 +315,7 @@ diff --git a/content/browser/attribution_reporting/attribution_host.cc b/content
|
||||
diff --git a/content/browser/attribution_reporting/attribution_manager_impl.cc b/content/browser/attribution_reporting/attribution_manager_impl.cc
|
||||
--- a/content/browser/attribution_reporting/attribution_manager_impl.cc
|
||||
+++ b/content/browser/attribution_reporting/attribution_manager_impl.cc
|
||||
@@ -522,11 +522,7 @@ bool IsOperationAllowed(
|
||||
@@ -523,11 +523,7 @@ bool IsOperationAllowed(
|
||||
}
|
||||
|
||||
std::unique_ptr<AttributionOsLevelManager> CreateOsLevelManager() {
|
||||
@@ -363,7 +350,7 @@ diff --git a/content/browser/attribution_reporting/attribution_os_level_manager.
|
||||
diff --git a/content/browser/attribution_reporting/attribution_report_network_sender.cc b/content/browser/attribution_reporting/attribution_report_network_sender.cc
|
||||
--- a/content/browser/attribution_reporting/attribution_report_network_sender.cc
|
||||
+++ b/content/browser/attribution_reporting/attribution_report_network_sender.cc
|
||||
@@ -131,6 +131,9 @@ void AttributionReportNetworkSender::SendReport(GURL url,
|
||||
@@ -117,6 +117,9 @@ void AttributionReportNetworkSender::SendReport(GURL url,
|
||||
url::Origin origin,
|
||||
std::string body,
|
||||
UrlLoaderCallback callback) {
|
||||
@@ -373,7 +360,7 @@ diff --git a/content/browser/attribution_reporting/attribution_report_network_se
|
||||
auto resource_request = std::make_unique<network::ResourceRequest>();
|
||||
resource_request->url = std::move(url);
|
||||
resource_request->method = net::HttpRequestHeaders::kPostMethod;
|
||||
@@ -206,6 +209,12 @@ void AttributionReportNetworkSender::OnReportSent(
|
||||
@@ -192,6 +195,12 @@ void AttributionReportNetworkSender::OnReportSent(
|
||||
ReportSentCallback sent_callback,
|
||||
UrlLoaderList::iterator it,
|
||||
scoped_refptr<net::HttpResponseHeaders> headers) {
|
||||
@@ -389,7 +376,7 @@ diff --git a/content/browser/attribution_reporting/attribution_report_network_se
|
||||
diff --git a/content/browser/attribution_reporting/attribution_storage_sql.cc b/content/browser/attribution_reporting/attribution_storage_sql.cc
|
||||
--- a/content/browser/attribution_reporting/attribution_storage_sql.cc
|
||||
+++ b/content/browser/attribution_reporting/attribution_storage_sql.cc
|
||||
@@ -535,6 +535,8 @@ void AssignSourceForDeactivationOrDeletion(
|
||||
@@ -534,6 +534,8 @@ void AssignSourceForDeactivationOrDeletion(
|
||||
}
|
||||
}
|
||||
|
||||
@@ -398,7 +385,7 @@ diff --git a/content/browser/attribution_reporting/attribution_storage_sql.cc b/
|
||||
} // namespace
|
||||
|
||||
// static
|
||||
@@ -557,9 +559,9 @@ bool AttributionStorageSql::Transaction::Commit() {
|
||||
@@ -556,9 +558,9 @@ bool AttributionStorageSql::Transaction::Commit() {
|
||||
AttributionStorageSql::AttributionStorageSql(
|
||||
const base::FilePath& user_data_directory,
|
||||
AttributionResolverDelegate* delegate)
|
||||
@@ -414,7 +401,7 @@ diff --git a/content/browser/attribution_reporting/attribution_storage_sql.cc b/
|
||||
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
@@ -10507,6 +10507,7 @@ bool RenderFrameHostImpl::IsFencedFrameReportingFromRendererAllowed(
|
||||
@@ -10794,6 +10794,7 @@ bool RenderFrameHostImpl::IsFencedFrameReportingFromRendererAllowed(
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -422,7 +409,7 @@ diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/b
|
||||
if (!IsActive()) {
|
||||
// reportEvent is not allowed when this RenderFrameHost or one of its
|
||||
// ancestors is not active.
|
||||
@@ -14607,6 +14608,16 @@ void RenderFrameHostImpl::BindTrustTokenQueryAnswerer(
|
||||
@@ -14951,6 +14952,16 @@ void RenderFrameHostImpl::BindTrustTokenQueryAnswerer(
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -442,7 +429,7 @@ diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/b
|
||||
diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc
|
||||
--- a/content/browser/storage_partition_impl.cc
|
||||
+++ b/content/browser/storage_partition_impl.cc
|
||||
@@ -1512,15 +1512,6 @@ void StoragePartitionImpl::Initialize(
|
||||
@@ -1460,15 +1460,6 @@ void StoragePartitionImpl::Initialize(
|
||||
|
||||
bucket_manager_ = std::make_unique<BucketManager>(this);
|
||||
|
||||
@@ -458,7 +445,7 @@ diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage
|
||||
if (base::FeatureList::IsEnabled(network::features::kInterestGroupStorage)) {
|
||||
// Auction worklets on non-Android use dedicated processes; on Android due
|
||||
// to high cost of process launch they try to reuse renderers.
|
||||
@@ -1572,9 +1563,6 @@ void StoragePartitionImpl::Initialize(
|
||||
@@ -1520,9 +1511,6 @@ void StoragePartitionImpl::Initialize(
|
||||
|
||||
font_access_manager_ = FontAccessManager::Create();
|
||||
|
||||
@@ -471,7 +458,7 @@ diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage
|
||||
diff --git a/content/public/android/BUILD.gn b/content/public/android/BUILD.gn
|
||||
--- a/content/public/android/BUILD.gn
|
||||
+++ b/content/public/android/BUILD.gn
|
||||
@@ -213,8 +213,6 @@ android_library("content_full_java") {
|
||||
@@ -204,8 +204,6 @@ android_library("content_full_java") {
|
||||
"//third_party/androidx:androidx_appcompat_appcompat_resources_java",
|
||||
"//third_party/androidx:androidx_collection_collection_java",
|
||||
"//third_party/androidx:androidx_core_core_java",
|
||||
@@ -945,7 +932,7 @@ diff --git a/content/public/android/java/src/org/chromium/content/browser/Attrib
|
||||
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
|
||||
--- a/content/public/browser/content_browser_client.cc
|
||||
+++ b/content/public/browser/content_browser_client.cc
|
||||
@@ -649,6 +649,7 @@ void ContentBrowserClient::OnAuctionComplete(
|
||||
@@ -653,6 +653,7 @@ void ContentBrowserClient::OnAuctionComplete(
|
||||
network::mojom::AttributionSupport ContentBrowserClient::GetAttributionSupport(
|
||||
AttributionReportingOsApiState state,
|
||||
bool client_os_disabled) {
|
||||
@@ -953,7 +940,7 @@ diff --git a/content/public/browser/content_browser_client.cc b/content/public/b
|
||||
switch (state) {
|
||||
case AttributionReportingOsApiState::kDisabled:
|
||||
return network::mojom::AttributionSupport::kWeb;
|
||||
@@ -666,13 +667,13 @@ bool ContentBrowserClient::IsAttributionReportingOperationAllowed(
|
||||
@@ -670,13 +671,13 @@ bool ContentBrowserClient::IsAttributionReportingOperationAllowed(
|
||||
const url::Origin* destination_origin,
|
||||
const url::Origin* reporting_origin,
|
||||
bool* can_bypass) {
|
||||
@@ -969,7 +956,7 @@ diff --git a/content/public/browser/content_browser_client.cc b/content/public/b
|
||||
}
|
||||
|
||||
bool ContentBrowserClient::IsAttributionReportingAllowedForContext(
|
||||
@@ -680,7 +681,7 @@ bool ContentBrowserClient::IsAttributionReportingAllowedForContext(
|
||||
@@ -684,7 +685,7 @@ bool ContentBrowserClient::IsAttributionReportingAllowedForContext(
|
||||
content::RenderFrameHost* rfh,
|
||||
const url::Origin& context_origin,
|
||||
const url::Origin& reporting_origin) {
|
||||
@@ -1012,7 +999,7 @@ new file mode 100644
|
||||
diff --git a/services/network/attribution/request_headers_internal.cc b/services/network/attribution/request_headers_internal.cc
|
||||
--- a/services/network/attribution/request_headers_internal.cc
|
||||
+++ b/services/network/attribution/request_headers_internal.cc
|
||||
@@ -189,6 +189,7 @@ std::string SerializeAttributionReportingEligibleHeader(
|
||||
@@ -188,6 +188,7 @@ std::string SerializeAttributionReportingEligibleHeader(
|
||||
std::string GetAttributionSupportHeader(
|
||||
mojom::AttributionSupport attribution_support,
|
||||
const AttributionReportingHeaderGreaseOptions& options) {
|
||||
@@ -1023,7 +1010,7 @@ diff --git a/services/network/attribution/request_headers_internal.cc b/services
|
||||
diff --git a/services/network/network_context.cc b/services/network/network_context.cc
|
||||
--- a/services/network/network_context.cc
|
||||
+++ b/services/network/network_context.cc
|
||||
@@ -1312,6 +1312,10 @@ void NetworkContext::ClearTrustTokenData(mojom::ClearDataFilterPtr filter,
|
||||
@@ -1323,6 +1323,10 @@ void NetworkContext::ClearTrustTokenData(mojom::ClearDataFilterPtr filter,
|
||||
|
||||
void NetworkContext::ClearTrustTokenSessionOnlyData(
|
||||
ClearTrustTokenSessionOnlyDataCallback callback) {
|
||||
@@ -1034,7 +1021,7 @@ diff --git a/services/network/network_context.cc b/services/network/network_cont
|
||||
// Only called when Private State Tokens is enabled, i.e.,
|
||||
// `trust_token_store_` is non-null.
|
||||
DCHECK(trust_token_store_);
|
||||
@@ -2731,26 +2735,6 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext(
|
||||
@@ -2766,26 +2770,6 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext(
|
||||
builder.set_network_quality_estimator(
|
||||
network_service_->network_quality_estimator());
|
||||
}
|
||||
@@ -1095,7 +1082,7 @@ diff --git a/third_party/blink/renderer/core/frame/attribution_src_loader.cc b/t
|
||||
diff --git a/third_party/blink/renderer/core/page/page.cc b/third_party/blink/renderer/core/page/page.cc
|
||||
--- a/third_party/blink/renderer/core/page/page.cc
|
||||
+++ b/third_party/blink/renderer/core/page/page.cc
|
||||
@@ -1586,7 +1586,7 @@ void Page::UpdateBrowsingContextGroup(
|
||||
@@ -1590,7 +1590,7 @@ void Page::UpdateBrowsingContextGroup(
|
||||
|
||||
void Page::SetAttributionSupport(
|
||||
network::mojom::AttributionSupport attribution_support) {
|
||||
@@ -1103,11 +1090,11 @@ diff --git a/third_party/blink/renderer/core/page/page.cc b/third_party/blink/re
|
||||
+ attribution_support_ = network::mojom::AttributionSupport::kNone;
|
||||
}
|
||||
|
||||
// static
|
||||
template class CORE_TEMPLATE_EXPORT Supplement<Page>;
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -301,8 +301,8 @@
|
||||
@@ -296,8 +296,8 @@
|
||||
},
|
||||
{
|
||||
// Interest Group JS API/runtimeflag.
|
||||
@@ -1118,7 +1105,7 @@ diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
origin_trial_feature_name: "AdInterestGroupAPI",
|
||||
implied_by: ["Fledge", "Parakeet"],
|
||||
public: true,
|
||||
@@ -626,8 +626,8 @@
|
||||
@@ -663,8 +663,8 @@
|
||||
status: "stable",
|
||||
},
|
||||
{
|
||||
@@ -1129,7 +1116,7 @@ diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
base_feature: "none",
|
||||
public: true,
|
||||
},
|
||||
@@ -4047,8 +4047,8 @@
|
||||
@@ -4378,8 +4378,8 @@
|
||||
base_feature: "none",
|
||||
},
|
||||
{
|
||||
@@ -1140,7 +1127,7 @@ diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
base_feature: "none",
|
||||
public: true,
|
||||
},
|
||||
@@ -5268,16 +5268,16 @@
|
||||
@@ -5714,16 +5714,16 @@
|
||||
status: "experimental",
|
||||
},
|
||||
{
|
||||
|
||||
@@ -12,7 +12,7 @@ Subject: Disable crash reporting
|
||||
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
|
||||
--- a/chrome/browser/chrome_content_browser_client.cc
|
||||
+++ b/chrome/browser/chrome_content_browser_client.cc
|
||||
@@ -2688,15 +2688,6 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
|
||||
@@ -2788,15 +2788,6 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
|
||||
base::NumberToString(pid));
|
||||
}
|
||||
#endif
|
||||
@@ -31,7 +31,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
|
||||
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
||||
@@ -16276,6 +16276,7 @@ void RenderFrameHostImpl::OnSameDocumentCommitProcessed(
|
||||
@@ -16626,6 +16626,7 @@ void RenderFrameHostImpl::OnSameDocumentCommitProcessed(
|
||||
void RenderFrameHostImpl::MaybeGenerateCrashReport(
|
||||
base::TerminationStatus status,
|
||||
int exit_code) {
|
||||
@@ -42,7 +42,7 @@ diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/b
|
||||
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
||||
--- a/content/browser/web_contents/web_contents_impl.cc
|
||||
+++ b/content/browser/web_contents/web_contents_impl.cc
|
||||
@@ -10332,7 +10332,7 @@ void WebContentsImpl::RendererUnresponsive(
|
||||
@@ -10449,7 +10449,7 @@ void WebContentsImpl::RendererUnresponsive(
|
||||
base::UmaHistogramEnumeration(
|
||||
"ReportingAndNEL.UnresponsiveRenderer.CrashReportOutcome", outcome);
|
||||
|
||||
|
||||
@@ -23,10 +23,10 @@ diff --git a/third_party/blink/renderer/core/loader/ping_loader.cc b/third_party
|
||||
const KURL& ping_url,
|
||||
const KURL& destination_url) {
|
||||
+ if ((true)) return;
|
||||
if (!ping_url.ProtocolIsInHTTPFamily())
|
||||
if (!ping_url.ProtocolIsInHttpFamily()) {
|
||||
return;
|
||||
|
||||
@@ -148,6 +150,7 @@ void PingLoader::SendViolationReport(ExecutionContext* execution_context,
|
||||
}
|
||||
@@ -149,6 +151,7 @@ void PingLoader::SendViolationReport(ExecutionContext* execution_context,
|
||||
const KURL& report_url,
|
||||
scoped_refptr<EncodedFormData> report,
|
||||
bool is_frame_ancestors_violation) {
|
||||
|
||||
@@ -6,12 +6,12 @@ Do not expose the user's preferred font scale to CSS.
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
.../common/features_cc/Disable-CSSPreferredTextScale.inc | 1 +
|
||||
.../core/css/document_style_environment_variables.cc | 6 ++++--
|
||||
.../blink/renderer/core/css/style_environment_variables.cc | 4 +++-
|
||||
third_party/blink/renderer/core/page/page.cc | 4 +++-
|
||||
.../blink/renderer/platform/runtime_enabled_features.json5 | 3 +++
|
||||
5 files changed, 14 insertions(+), 4 deletions(-)
|
||||
.../common/features_cc/Disable-CSSPreferredTextScale.inc | 1 +
|
||||
.../renderer/core/css/document_style_environment_variables.cc | 1 +
|
||||
.../blink/renderer/core/css/style_environment_variables.cc | 4 +++-
|
||||
third_party/blink/renderer/core/page/page.cc | 4 +++-
|
||||
.../blink/renderer/platform/runtime_enabled_features.json5 | 3 +++
|
||||
5 files changed, 11 insertions(+), 2 deletions(-)
|
||||
create mode 100644 cromite_flags/third_party/blink/common/features_cc/Disable-CSSPreferredTextScale.inc
|
||||
|
||||
diff --git a/cromite_flags/third_party/blink/common/features_cc/Disable-CSSPreferredTextScale.inc b/cromite_flags/third_party/blink/common/features_cc/Disable-CSSPreferredTextScale.inc
|
||||
@@ -23,23 +23,18 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/core/css/document_style_environment_variables.cc b/third_party/blink/renderer/core/css/document_style_environment_variables.cc
|
||||
--- a/third_party/blink/renderer/core/css/document_style_environment_variables.cc
|
||||
+++ b/third_party/blink/renderer/core/css/document_style_environment_variables.cc
|
||||
@@ -55,8 +55,10 @@ DocumentStyleEnvironmentVariables::DocumentStyleEnvironmentVariables(
|
||||
StyleEnvironmentVariables& parent,
|
||||
Document& document)
|
||||
: StyleEnvironmentVariables(parent), document_(&document) {
|
||||
- SetPreferredTextScale(
|
||||
- document_->GetSettings()->GetAccessibilityFontScaleFactor());
|
||||
+ if (RuntimeEnabledFeatures::CSSPreferredTextScaleEnabled()) {
|
||||
+ SetPreferredTextScale(
|
||||
+ document_->GetSettings()->GetAccessibilityFontScaleFactor());
|
||||
+ }
|
||||
@@ -95,6 +95,7 @@ void DocumentStyleEnvironmentVariables::RecordVariableUsage(
|
||||
}
|
||||
|
||||
void DocumentStyleEnvironmentVariables::RecordVariableUsage(
|
||||
void DocumentStyleEnvironmentVariables::UpdatePreferredTextScaleFromDocument() {
|
||||
+ if (!RuntimeEnabledFeatures::CSSPreferredTextScaleEnabled()) return;
|
||||
double scale_factor;
|
||||
|
||||
Settings* settings = document_->GetSettings();
|
||||
diff --git a/third_party/blink/renderer/core/css/style_environment_variables.cc b/third_party/blink/renderer/core/css/style_environment_variables.cc
|
||||
--- a/third_party/blink/renderer/core/css/style_environment_variables.cc
|
||||
+++ b/third_party/blink/renderer/core/css/style_environment_variables.cc
|
||||
@@ -49,7 +49,9 @@ void SetDefaultEnvironmentVariables(StyleEnvironmentVariables* instance) {
|
||||
@@ -48,7 +48,9 @@ void SetDefaultEnvironmentVariables(StyleEnvironmentVariables* instance) {
|
||||
instance->SetVariable(UADefinedVariable::kKeyboardInsetHeight,
|
||||
kKeyboardInsetDefault);
|
||||
|
||||
@@ -53,7 +48,7 @@ diff --git a/third_party/blink/renderer/core/css/style_environment_variables.cc
|
||||
diff --git a/third_party/blink/renderer/core/page/page.cc b/third_party/blink/renderer/core/page/page.cc
|
||||
--- a/third_party/blink/renderer/core/page/page.cc
|
||||
+++ b/third_party/blink/renderer/core/page/page.cc
|
||||
@@ -1056,7 +1056,9 @@ void Page::SettingsChanged(ChangeType change_type) {
|
||||
@@ -1063,7 +1063,9 @@ void Page::SettingsChanged(ChangeType change_type) {
|
||||
}
|
||||
break;
|
||||
case ChangeType::kFontScaleFactor:
|
||||
@@ -67,7 +62,7 @@ diff --git a/third_party/blink/renderer/core/page/page.cc b/third_party/blink/re
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -1582,6 +1582,9 @@
|
||||
@@ -1664,6 +1664,9 @@
|
||||
name: "CSSPositionStickyStaticScrollPosition",
|
||||
status: "test",
|
||||
},
|
||||
|
||||
@@ -7,9 +7,75 @@ see https://w3c.github.io/webappsec-dbsc/#privacy-considerations
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
net/features.gni | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
.../metrics/chrome_browser_main_extra_parts_metrics.cc | 6 ++++++
|
||||
net/BUILD.gn | 7 +++++++
|
||||
net/base/features.cc | 10 ++++++----
|
||||
net/features.gni | 2 +-
|
||||
4 files changed, 20 insertions(+), 5 deletions(-)
|
||||
|
||||
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
|
||||
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
|
||||
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
|
||||
@@ -127,6 +127,10 @@
|
||||
#include "chrome/browser/signin/bound_session_credentials/unexportable_key_service_factory.h"
|
||||
#endif // BUILDFLAG(IS_MAC)
|
||||
|
||||
+#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
|
||||
+#include "net/net_buildflags.h"
|
||||
+#endif
|
||||
+
|
||||
namespace {
|
||||
|
||||
// The number of restarts to wait until removing the enable-benchmarking flag.
|
||||
@@ -931,7 +935,9 @@ void RecordStartupMetrics() {
|
||||
#endif // BUILDFLAG(IS_WIN)
|
||||
|
||||
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
|
||||
+#if BUILDFLAG(ENABLE_DEVICE_BOUND_SESSIONS)
|
||||
crypto::MaybeMeasureTpmOperations(unexportable_keys::GetDefaultConfig());
|
||||
+#endif
|
||||
#endif // BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
|
||||
|
||||
// Record whether Chrome is the default browser or not.
|
||||
diff --git a/net/BUILD.gn b/net/BUILD.gn
|
||||
--- a/net/BUILD.gn
|
||||
+++ b/net/BUILD.gn
|
||||
@@ -1287,6 +1287,13 @@ component("net") {
|
||||
]
|
||||
}
|
||||
|
||||
+ if (!enable_device_bound_sessions) {
|
||||
+ sources += [
|
||||
+ "device_bound_sessions/session_error.cc",
|
||||
+ "device_bound_sessions/session_error.h",
|
||||
+ ]
|
||||
+ }
|
||||
+
|
||||
if (enable_device_bound_sessions) {
|
||||
sources += [
|
||||
"device_bound_sessions/cookie_craving.cc",
|
||||
diff --git a/net/base/features.cc b/net/base/features.cc
|
||||
--- a/net/base/features.cc
|
||||
+++ b/net/base/features.cc
|
||||
@@ -356,12 +356,14 @@ BASE_FEATURE(kUseNetworkPathMonitorForNetworkChangeNotifier,
|
||||
);
|
||||
#endif // BUILDFLAG(IS_APPLE)
|
||||
|
||||
-#if BUILDFLAG(IS_WIN)
|
||||
-BASE_FEATURE(kDeviceBoundSessions, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
-#else
|
||||
BASE_FEATURE(kDeviceBoundSessions, base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
+BASE_FEATURE(kPersistDeviceBoundSessions,
|
||||
+#if BUILDFLAG(IS_WIN) && BUILDFLAG(ENABLE_DEVICE_BOUND_SESSIONS)
|
||||
+ base::FEATURE_ENABLED_BY_DEFAULT
|
||||
+#else
|
||||
+ base::FEATURE_DISABLED_BY_DEFAULT
|
||||
+);
|
||||
#endif
|
||||
-BASE_FEATURE(kPersistDeviceBoundSessions, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
BASE_FEATURE_PARAM(bool,
|
||||
kDeviceBoundSessionsRequireOriginTrialTokens,
|
||||
&kDeviceBoundSessions,
|
||||
diff --git a/net/features.gni b/net/features.gni
|
||||
--- a/net/features.gni
|
||||
+++ b/net/features.gni
|
||||
|
||||
@@ -12,7 +12,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
diff --git a/chrome/browser/feed/android/web_feed_bridge.cc b/chrome/browser/feed/android/web_feed_bridge.cc
|
||||
--- a/chrome/browser/feed/android/web_feed_bridge.cc
|
||||
+++ b/chrome/browser/feed/android/web_feed_bridge.cc
|
||||
@@ -81,10 +81,7 @@ base::android::ScopedJavaLocalRef<jbyteArray> ToJavaWebFeedId(
|
||||
@@ -80,10 +80,7 @@ base::android::ScopedJavaLocalRef<jbyteArray> ToJavaWebFeedId(
|
||||
}
|
||||
|
||||
WebFeedSubscriptions* GetSubscriptions() {
|
||||
@@ -24,7 +24,7 @@ diff --git a/chrome/browser/feed/android/web_feed_bridge.cc b/chrome/browser/fee
|
||||
}
|
||||
|
||||
FeedApi* GetStream() {
|
||||
@@ -217,10 +214,7 @@ static void JNI_WebFeedBridge_FollowWebFeed(
|
||||
@@ -216,10 +213,7 @@ static void JNI_WebFeedBridge_FollowWebFeed(
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -35,8 +35,8 @@ diff --git a/chrome/browser/feed/android/web_feed_bridge.cc b/chrome/browser/fee
|
||||
+ std::move(callback).Run({});
|
||||
}
|
||||
|
||||
static jboolean JNI_WebFeedBridge_IsCormorantEnabledForLocale(JNIEnv* env) {
|
||||
@@ -261,11 +255,7 @@ static void JNI_WebFeedBridge_UnfollowWebFeed(
|
||||
static bool JNI_WebFeedBridge_IsWebFeedEnabled(JNIEnv* env) {
|
||||
@@ -260,11 +254,7 @@ static void JNI_WebFeedBridge_UnfollowWebFeed(
|
||||
auto callback =
|
||||
AdaptCallbackForJava<WebFeedSubscriptions::UnfollowWebFeedResult>(
|
||||
env, j_callback);
|
||||
@@ -49,7 +49,7 @@ diff --git a/chrome/browser/feed/android/web_feed_bridge.cc b/chrome/browser/fee
|
||||
}
|
||||
|
||||
static void JNI_WebFeedBridge_FindWebFeedInfoForPage(
|
||||
@@ -276,17 +266,7 @@ static void JNI_WebFeedBridge_FindWebFeedInfoForPage(
|
||||
@@ -275,17 +265,7 @@ static void JNI_WebFeedBridge_FindWebFeedInfoForPage(
|
||||
base::OnceCallback<void(WebFeedMetadata)> callback =
|
||||
AdaptCallbackForJava<WebFeedMetadata>(env, j_callback);
|
||||
|
||||
@@ -83,7 +83,7 @@ diff --git a/components/feed/core/shared_prefs/pref_names.cc b/components/feed/c
|
||||
diff --git a/components/feed/feed_feature_list.cc b/components/feed/feed_feature_list.cc
|
||||
--- a/components/feed/feed_feature_list.cc
|
||||
+++ b/components/feed/feed_feature_list.cc
|
||||
@@ -88,4 +88,7 @@ bool IsWebFeedEnabledForLocale(const std::string& country) {
|
||||
@@ -86,4 +86,7 @@ bool IsWebFeedEnabledForLocale(const std::string& country) {
|
||||
!base::FeatureList::IsEnabled(kWebFeedKillSwitch);
|
||||
}
|
||||
|
||||
|
||||
@@ -22,7 +22,7 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../firstrun/VariationsSeedFetcher.java | 36 +++----------------
|
||||
components/variations/net/BUILD.gn | 2 --
|
||||
.../omnibox_autofocus_url_loader_throttle.cc | 1 +
|
||||
.../variations/net/variations_http_headers.cc | 2 ++
|
||||
.../variations/net/variations_http_headers.cc | 2 +-
|
||||
.../net/variations_url_loader_throttle.cc | 1 +
|
||||
.../service/variations_field_trial_creator.cc | 6 ++--
|
||||
.../variations/service/variations_service.cc | 19 ++--------
|
||||
@@ -34,14 +34,14 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
||||
.../Disable-fetching-of-all-field-trials.inc | 1 +
|
||||
.../renderer/core/loader/document_loader.cc | 7 ----
|
||||
.../platform/loader/fetch/resource_request.h | 1 -
|
||||
27 files changed, 31 insertions(+), 90 deletions(-)
|
||||
27 files changed, 30 insertions(+), 91 deletions(-)
|
||||
create mode 100644 cromite_flags/net/base/features_cc/Disable-fetching-of-all-field-trials.inc
|
||||
create mode 100644 cromite_flags/services/network/public/cpp/features_cc/Disable-fetching-of-all-field-trials.inc
|
||||
|
||||
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
|
||||
--- a/android_webview/browser/aw_browser_context.cc
|
||||
+++ b/android_webview/browser/aw_browser_context.cc
|
||||
@@ -496,6 +496,7 @@ AwBrowserContext::RetrieveInProgressDownloadManager() {
|
||||
@@ -497,6 +497,7 @@ AwBrowserContext::RetrieveInProgressDownloadManager() {
|
||||
|
||||
content::OriginTrialsControllerDelegate*
|
||||
AwBrowserContext::GetOriginTrialsControllerDelegate() {
|
||||
@@ -75,7 +75,7 @@ diff --git a/android_webview/common/aw_content_client.cc b/android_webview/commo
|
||||
diff --git a/android_webview/nonembedded/BUILD.gn b/android_webview/nonembedded/BUILD.gn
|
||||
--- a/android_webview/nonembedded/BUILD.gn
|
||||
+++ b/android_webview/nonembedded/BUILD.gn
|
||||
@@ -107,7 +107,6 @@ android_library("services_java") {
|
||||
@@ -108,7 +108,6 @@ android_library("services_java") {
|
||||
"java/src/org/chromium/android_webview/services/AwMinidumpUploadJobService.java",
|
||||
"java/src/org/chromium/android_webview/services/AwMinidumpUploaderDelegate.java",
|
||||
"java/src/org/chromium/android_webview/services/AwNetLogService.java",
|
||||
@@ -83,7 +83,7 @@ diff --git a/android_webview/nonembedded/BUILD.gn b/android_webview/nonembedded/
|
||||
"java/src/org/chromium/android_webview/services/ComponentUpdaterResetSafeModeAction.java",
|
||||
"java/src/org/chromium/android_webview/services/ComponentUpdaterSafeModeUtils.java",
|
||||
"java/src/org/chromium/android_webview/services/ComponentsProviderPathUtil.java",
|
||||
@@ -126,7 +125,6 @@ android_library("services_java") {
|
||||
@@ -127,7 +126,6 @@ android_library("services_java") {
|
||||
"java/src/org/chromium/android_webview/services/SafeModeService.java",
|
||||
"java/src/org/chromium/android_webview/services/SafeModeVariationsSeedContentProvider.java",
|
||||
"java/src/org/chromium/android_webview/services/StartupFeatureMetadataHolder.java",
|
||||
@@ -159,7 +159,7 @@ diff --git a/chrome/browser/metrics/chrome_browser_sampling_trials.cc b/chrome/b
|
||||
diff --git a/chrome/browser/net/system_network_context_manager.cc b/chrome/browser/net/system_network_context_manager.cc
|
||||
--- a/chrome/browser/net/system_network_context_manager.cc
|
||||
+++ b/chrome/browser/net/system_network_context_manager.cc
|
||||
@@ -931,7 +931,6 @@ void SystemNetworkContextManager::AddSSLConfigToNetworkContextParams(
|
||||
@@ -935,7 +935,6 @@ void SystemNetworkContextManager::AddSSLConfigToNetworkContextParams(
|
||||
|
||||
void SystemNetworkContextManager::ConfigureDefaultNetworkContextParams(
|
||||
network::mojom::NetworkContextParams* network_context_params) {
|
||||
@@ -181,7 +181,7 @@ diff --git a/chrome/browser/origin_trials/origin_trials_factory.cc b/chrome/brow
|
||||
diff --git a/components/ukm/ukm_recorder_impl.cc b/components/ukm/ukm_recorder_impl.cc
|
||||
--- a/components/ukm/ukm_recorder_impl.cc
|
||||
+++ b/components/ukm/ukm_recorder_impl.cc
|
||||
@@ -192,6 +192,9 @@ std::string WebDXFeaturesToStringForDebug(const std::set<int32_t>& features) {
|
||||
@@ -191,6 +191,9 @@ std::string WebDXFeaturesToStringForDebug(const std::set<int32_t>& features) {
|
||||
|
||||
UkmRecorderImpl::UkmRecorderImpl()
|
||||
: sampling_seed_(static_cast<uint32_t>(base::RandUint64())) {
|
||||
@@ -285,15 +285,15 @@ diff --git a/components/variations/net/omnibox_autofocus_url_loader_throttle.cc
|
||||
diff --git a/components/variations/net/variations_http_headers.cc b/components/variations/net/variations_http_headers.cc
|
||||
--- a/components/variations/net/variations_http_headers.cc
|
||||
+++ b/components/variations/net/variations_http_headers.cc
|
||||
@@ -252,6 +252,8 @@ class VariationsHeaderHelper {
|
||||
VariationsHeaderHelper& operator=(const VariationsHeaderHelper&) = delete;
|
||||
@@ -140,7 +140,7 @@ bool ShouldAppendVariationsHeader(const GURL& url, InIncognito incognito) {
|
||||
std::optional<std::string> GetHeaderValue(
|
||||
variations::mojom::VariationsHeadersPtr variations_headers,
|
||||
bool is_first_party_context) {
|
||||
- if (!variations_headers) {
|
||||
+ if (((true))) {
|
||||
return std::nullopt;
|
||||
}
|
||||
|
||||
bool AppendHeaderIfNeeded(const GURL& url, InIncognito incognito) {
|
||||
+ if((true)) return false;
|
||||
+
|
||||
// Note the criteria for attaching client experiment headers:
|
||||
// 1. We only transmit to Google owned domains which can evaluate
|
||||
// experiments.
|
||||
diff --git a/components/variations/net/variations_url_loader_throttle.cc b/components/variations/net/variations_url_loader_throttle.cc
|
||||
--- a/components/variations/net/variations_url_loader_throttle.cc
|
||||
+++ b/components/variations/net/variations_url_loader_throttle.cc
|
||||
@@ -308,7 +308,7 @@ diff --git a/components/variations/net/variations_url_loader_throttle.cc b/compo
|
||||
diff --git a/components/variations/service/variations_field_trial_creator.cc b/components/variations/service/variations_field_trial_creator.cc
|
||||
--- a/components/variations/service/variations_field_trial_creator.cc
|
||||
+++ b/components/variations/service/variations_field_trial_creator.cc
|
||||
@@ -130,6 +130,7 @@ Study::CpuArchitecture GetCurrentCpuArchitecture() {
|
||||
@@ -122,6 +122,7 @@ Study::CpuArchitecture GetCurrentCpuArchitecture() {
|
||||
}
|
||||
|
||||
#if BUILDFLAG(FIELDTRIAL_TESTING_ENABLED)
|
||||
@@ -316,7 +316,7 @@ diff --git a/components/variations/service/variations_field_trial_creator.cc b/c
|
||||
// Determines whether the field trial testing config defined in
|
||||
// testing/variations/fieldtrial_testing_config.json should be applied. If the
|
||||
// "disable_fieldtrial_testing_config" GN flag is set to true, then the testing
|
||||
@@ -374,9 +375,6 @@ bool VariationsFieldTrialCreator::SetUpFieldTrials(
|
||||
@@ -332,9 +333,6 @@ bool VariationsFieldTrialCreator::SetUpFieldTrials(
|
||||
metrics_state_manager->GetLowEntropySource());
|
||||
}
|
||||
|
||||
@@ -326,7 +326,7 @@ diff --git a/components/variations/service/variations_field_trial_creator.cc b/c
|
||||
platform_field_trials->RegisterFeatureOverrides(feature_list.get());
|
||||
|
||||
base::FeatureList::SetInstance(std::move(feature_list));
|
||||
@@ -725,6 +723,7 @@ CreateTrialsResult VariationsFieldTrialCreator::CreateTrialsFromSeed(
|
||||
@@ -639,6 +637,7 @@ CreateTrialsResult VariationsFieldTrialCreator::CreateTrialsFromSeed(
|
||||
base::FeatureList* feature_list,
|
||||
SafeSeedManager* safe_seed_manager,
|
||||
std::unique_ptr<ClientFilterableState> client_state) {
|
||||
@@ -334,7 +334,7 @@ diff --git a/components/variations/service/variations_field_trial_creator.cc b/c
|
||||
TRACE_EVENT0("startup", "VariationsFieldTrialCreator::CreateTrialsFromSeed");
|
||||
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
|
||||
CHECK(!create_trials_from_seed_called_);
|
||||
@@ -844,6 +843,7 @@ CreateTrialsResult VariationsFieldTrialCreator::CreateTrialsFromSeed(
|
||||
@@ -757,6 +756,7 @@ CreateTrialsResult VariationsFieldTrialCreator::CreateTrialsFromSeed(
|
||||
|
||||
void VariationsFieldTrialCreator::LoadSeedFromJsonFile(
|
||||
const base::FilePath& json_seed_path) {
|
||||
@@ -369,7 +369,7 @@ diff --git a/components/variations/service/variations_service.cc b/components/va
|
||||
}
|
||||
|
||||
// Returns the already downloaded first run seed, and clear the seed from the
|
||||
@@ -636,7 +621,7 @@ bool VariationsService::DoFetchFromURL(const GURL& url, bool is_http_retry) {
|
||||
@@ -632,7 +617,7 @@ bool VariationsService::DoFetchFromURL(const GURL& url, bool is_http_retry) {
|
||||
// debugger or if the machine was suspended) and OnURLFetchComplete() hasn't
|
||||
// had a chance to run yet from the previous request. In this case, don't
|
||||
// start a new request and just let the previous one finish.
|
||||
@@ -417,7 +417,7 @@ diff --git a/content/browser/origin_trials/origin_trials_utils.cc b/content/brow
|
||||
diff --git a/content/browser/renderer_host/navigation_request.cc b/content/browser/renderer_host/navigation_request.cc
|
||||
--- a/content/browser/renderer_host/navigation_request.cc
|
||||
+++ b/content/browser/renderer_host/navigation_request.cc
|
||||
@@ -842,6 +842,7 @@ void PersistOriginTrialsFromHeaders(
|
||||
@@ -839,6 +839,7 @@ void PersistOriginTrialsFromHeaders(
|
||||
const network::mojom::URLResponseHead* response,
|
||||
BrowserContext* browser_context,
|
||||
ukm::SourceId source_id) {
|
||||
@@ -458,7 +458,7 @@ new file mode 100644
|
||||
diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
--- a/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
+++ b/third_party/blink/renderer/core/loader/document_loader.cc
|
||||
@@ -211,13 +211,6 @@ std::vector<int> CopyInitiatorOriginTrials(
|
||||
@@ -214,13 +214,6 @@ std::vector<int> CopyInitiatorOriginTrials(
|
||||
const Vector<mojom::blink::OriginTrialFeature>&
|
||||
initiator_origin_trial_features) {
|
||||
std::vector<int> result;
|
||||
@@ -475,7 +475,7 @@ diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_p
|
||||
diff --git a/third_party/blink/renderer/platform/loader/fetch/resource_request.h b/third_party/blink/renderer/platform/loader/fetch/resource_request.h
|
||||
--- a/third_party/blink/renderer/platform/loader/fetch/resource_request.h
|
||||
+++ b/third_party/blink/renderer/platform/loader/fetch/resource_request.h
|
||||
@@ -568,7 +568,6 @@ class PLATFORM_EXPORT ResourceRequestHead {
|
||||
@@ -581,7 +581,6 @@ class PLATFORM_EXPORT ResourceRequestHead {
|
||||
}
|
||||
void SetTrustTokenParams(
|
||||
std::optional<network::mojom::blink::TrustTokenParams> params) {
|
||||
|
||||
@@ -31,7 +31,7 @@ new file mode 100644
|
||||
diff --git a/services/network/public/cpp/permissions_policy/permissions_policy_features.json5 b/services/network/public/cpp/permissions_policy/permissions_policy_features.json5
|
||||
--- a/services/network/public/cpp/permissions_policy/permissions_policy_features.json5
|
||||
+++ b/services/network/public/cpp/permissions_policy/permissions_policy_features.json5
|
||||
@@ -385,6 +385,7 @@
|
||||
@@ -403,6 +403,7 @@
|
||||
{
|
||||
name: "IdleDetection",
|
||||
permissions_policy_name: "idle-detection",
|
||||
@@ -55,7 +55,7 @@ diff --git a/third_party/blink/renderer/modules/idle/idle_detector.idl b/third_p
|
||||
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
|
||||
@@ -233,6 +233,11 @@
|
||||
@@ -228,6 +228,11 @@
|
||||
name: "AcceleratedSmallCanvases",
|
||||
status: "stable",
|
||||
},
|
||||
|
||||
@@ -0,0 +1,561 @@
|
||||
From: uazo <uazo@users.noreply.github.com>
|
||||
Date: Fri, 21 Apr 2023 13:10:20 +0000
|
||||
Subject: Disable integration with Gemini
|
||||
|
||||
Due to errors, some points are not covered by the gn arg check.
|
||||
This patch fixes build errors.
|
||||
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
chrome/android/BUILD.gn | 2 -
|
||||
.../android/java/res/xml/main_preferences.xml | 5 ---
|
||||
.../AppMenuPropertiesDelegateImpl.java | 11 -----
|
||||
.../search/SearchIndexProviderRegistry.java | 1 -
|
||||
.../TabbedAdaptiveToolbarBehavior.java | 8 ----
|
||||
.../TabbedAppMenuPropertiesDelegate.java | 13 +-----
|
||||
.../tabbed_mode/TabbedRootUiCoordinator.java | 3 +-
|
||||
chrome/browser/BUILD.gn | 2 -
|
||||
chrome/browser/actor/BUILD.gn | 3 --
|
||||
chrome/browser/android/tab_features.cc | 4 ++
|
||||
chrome/browser/android/tab_features.h | 4 ++
|
||||
.../contextual_cueing_helper.cc | 2 +
|
||||
.../contextual_cueing_page_data.cc | 3 ++
|
||||
.../api/pdf_viewer_private/BUILD.gn | 3 --
|
||||
.../pdf_viewer_private_api.cc | 43 +------------------
|
||||
chrome/browser/glic/BUILD.gn | 2 +-
|
||||
chrome/browser/glic/android/BUILD.gn | 2 +-
|
||||
chrome/browser/pdf/BUILD.gn | 1 -
|
||||
chrome/browser/sync/BUILD.gn | 4 +-
|
||||
chrome/browser/sync/test/integration/BUILD.gn | 2 +-
|
||||
chrome/browser/ui/pdf/BUILD.gn | 1 -
|
||||
.../pdf/chrome_pdf_document_helper_client.cc | 2 +
|
||||
.../ui/tabs/alert/tab_alert_controller.cc | 2 +
|
||||
chrome/common/BUILD.gn | 1 +
|
||||
chrome/common/chrome_features.cc | 1 +
|
||||
chrome/common/features.gni | 2 +
|
||||
chrome/test/BUILD.gn | 2 +-
|
||||
components/browser_sync/BUILD.gn | 2 +-
|
||||
28 files changed, 32 insertions(+), 99 deletions(-)
|
||||
|
||||
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
||||
--- a/chrome/android/BUILD.gn
|
||||
+++ b/chrome/android/BUILD.gn
|
||||
@@ -374,8 +374,6 @@ if (_is_default_toolchain) {
|
||||
"//chrome/browser/creator/android:java",
|
||||
"//chrome/browser/data_sharing:factory_java",
|
||||
"//chrome/browser/data_sharing:instant_message_delegate_factory_java",
|
||||
- "//chrome/browser/glic:public_java",
|
||||
- "//chrome/browser/glic/android:java",
|
||||
"//chrome/browser/page_content_annotations:factory_java",
|
||||
"//chrome/browser/prefs/android:java",
|
||||
"//chrome/browser/settings:search_java",
|
||||
diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
|
||||
--- a/chrome/android/java/res/xml/main_preferences.xml
|
||||
+++ b/chrome/android/java/res/xml/main_preferences.xml
|
||||
@@ -100,11 +100,6 @@ found in the LICENSE file.
|
||||
android:order="18"
|
||||
android:title="@string/tabs_settings_title"
|
||||
app:isPreferenceVisible="false"/>
|
||||
- <Preference
|
||||
- android:fragment="org.chromium.chrome.browser.glic.GlicSettings"
|
||||
- android:key="glic"
|
||||
- android:order="19"
|
||||
- android:title="@string/glic_button_entrypoint_label"/>
|
||||
<Preference
|
||||
android:fragment="org.chromium.chrome.browser.homepage.settings.HomepageSettings"
|
||||
android:key="homepage"
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
|
||||
@@ -739,17 +739,6 @@ public abstract class AppMenuPropertiesDelegateImpl implements AppMenuProperties
|
||||
return downloadButton;
|
||||
}
|
||||
|
||||
- protected PropertyModel buildGlicActionModel(@Nullable Tab currentTab) {
|
||||
- PropertyModel glicButton =
|
||||
- buildModelForIcon(
|
||||
- R.id.glic_menu_id,
|
||||
- R.string.glic_button_entrypoint_ask_gemini_label,
|
||||
- R.string.glic_button_entrypoint_label,
|
||||
- R.drawable.ic_spark_24dp);
|
||||
- glicButton.set(AppMenuItemProperties.ENABLED, true);
|
||||
- return glicButton;
|
||||
- }
|
||||
-
|
||||
/** Build the PropertyModel for the page info action. */
|
||||
protected PropertyModel buildPageInfoModel(@Nullable Tab currentTab) {
|
||||
PropertyModel pageInfoButton =
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java
|
||||
@@ -35,7 +35,6 @@ public final class SearchIndexProviderRegistry {
|
||||
.SEARCH_INDEX_DATA_PROVIDER,
|
||||
org.chromium.chrome.browser.contextualsearch.ContextualSearchSettingsFragment
|
||||
.SEARCH_INDEX_DATA_PROVIDER,
|
||||
- org.chromium.chrome.browser.glic.GlicSettings.SEARCH_INDEX_DATA_PROVIDER,
|
||||
org.chromium.chrome.browser.privacy.settings.DoNotTrackSettings
|
||||
.SEARCH_INDEX_DATA_PROVIDER,
|
||||
org.chromium.chrome.browser.homepage.settings.HomepageSettings
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAdaptiveToolbarBehavior.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAdaptiveToolbarBehavior.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAdaptiveToolbarBehavior.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAdaptiveToolbarBehavior.java
|
||||
@@ -19,7 +19,6 @@ import org.chromium.chrome.browser.ai.PageSummaryButtonController;
|
||||
import org.chromium.chrome.browser.bookmarks.AddToBookmarksToolbarButtonController;
|
||||
import org.chromium.chrome.browser.bookmarks.BookmarkModel;
|
||||
import org.chromium.chrome.browser.bookmarks.TabBookmarker;
|
||||
-import org.chromium.chrome.browser.glic.GlicToolbarButtonController;
|
||||
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
|
||||
import org.chromium.chrome.browser.tab_group_suggestion.toolbar.GroupSuggestionsButtonController;
|
||||
import org.chromium.chrome.browser.tab_group_suggestion.toolbar.GroupSuggestionsButtonDataProvider;
|
||||
@@ -125,13 +124,6 @@ public class TabbedAdaptiveToolbarBehavior implements AdaptiveToolbarBehavior {
|
||||
controller.addButtonVariant(AdaptiveToolbarButtonVariant.TAB_GROUPING, tabGrouping);
|
||||
}
|
||||
|
||||
- if (AdaptiveToolbarFeatures.isGlicActionEnabled()) {
|
||||
- controller.addButtonVariant(
|
||||
- AdaptiveToolbarButtonVariant.GLIC,
|
||||
- new GlicToolbarButtonController(
|
||||
- mContext, mActivityTabProvider, mToggleGlicCallback));
|
||||
- }
|
||||
-
|
||||
mRegisterVoiceSearchRunnable.run();
|
||||
}
|
||||
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
|
||||
@@ -237,11 +237,7 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
iconModels.add(buildForwardActionModel(currentTab));
|
||||
iconModels.add(buildBookmarkActionModel(currentTab));
|
||||
iconModels.add(buildDownloadActionModel(currentTab));
|
||||
- if (ChromeFeatureList.sGlic.isEnabled()) {
|
||||
- iconModels.add(buildGlicActionModel(currentTab));
|
||||
- } else {
|
||||
- iconModels.add(buildPageInfoModel(currentTab));
|
||||
- }
|
||||
+ iconModels.add(buildPageInfoModel(currentTab));
|
||||
|
||||
iconModels.add(buildReloadModel(currentTab));
|
||||
|
||||
@@ -1399,12 +1395,7 @@ public class TabbedAppMenuPropertiesDelegate extends AppMenuPropertiesDelegateIm
|
||||
|| !ChromeFeatureList.sGlic.isEnabled()) {
|
||||
return null;
|
||||
}
|
||||
- return new MVCListAdapter.ListItem(
|
||||
- AppMenuHandler.AppMenuItemType.STANDARD,
|
||||
- buildModelForStandardMenuItem(
|
||||
- R.id.glic_menu_id,
|
||||
- R.string.glic_button_entrypoint_ask_gemini_label,
|
||||
- shouldShowIconBeforeItem() ? R.drawable.ic_spark_24dp : Resources.ID_NULL));
|
||||
+ return null;
|
||||
}
|
||||
|
||||
/**
|
||||
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
|
||||
@@ -107,7 +107,6 @@ import org.chromium.chrome.browser.gesturenav.BackActionDelegate;
|
||||
import org.chromium.chrome.browser.gesturenav.HistoryNavigationCoordinator;
|
||||
import org.chromium.chrome.browser.gesturenav.NavigationSheet;
|
||||
import org.chromium.chrome.browser.gesturenav.TabbedSheetDelegate;
|
||||
-import org.chromium.chrome.browser.glic.GlicKeyedServiceHandler;
|
||||
import org.chromium.chrome.browser.history.HistoryManagerUtils;
|
||||
import org.chromium.chrome.browser.hub.HubManager;
|
||||
import org.chromium.chrome.browser.incognito.reauth.IncognitoReauthCoordinatorFactory;
|
||||
@@ -2255,7 +2254,7 @@ public class TabbedRootUiCoordinator extends RootUiCoordinator {
|
||||
Profile profile = mTabModelSelectorSupplier.get().getCurrentModel().getProfile();
|
||||
assert profile != null;
|
||||
|
||||
- return GlicKeyedServiceHandler.toggleGlic(profile, mChromeAndroidTaskSupplier.get());
|
||||
+ return false;
|
||||
}
|
||||
|
||||
/* package */ KeyboardFocusRowManager getKeyboardFocusRowManagerForTesting() {
|
||||
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
||||
--- a/chrome/browser/BUILD.gn
|
||||
+++ b/chrome/browser/BUILD.gn
|
||||
@@ -3274,8 +3274,6 @@ static_library("browser") {
|
||||
"//chrome/browser/flags:flags_android_impl",
|
||||
"//chrome/browser/gesturenav/android:gesturenav",
|
||||
"//chrome/browser/gesturenav/android:impl",
|
||||
- "//chrome/browser/glic/android",
|
||||
- "//chrome/browser/glic/android:jni_headers",
|
||||
"//chrome/browser/keyboard_accessory/android",
|
||||
"//chrome/browser/language/android:jni_headers",
|
||||
"//chrome/browser/lifetime/android:jni_headers",
|
||||
diff --git a/chrome/browser/actor/BUILD.gn b/chrome/browser/actor/BUILD.gn
|
||||
--- a/chrome/browser/actor/BUILD.gn
|
||||
+++ b/chrome/browser/actor/BUILD.gn
|
||||
@@ -399,9 +399,6 @@ source_set("browser_tests") {
|
||||
":tools_test_support",
|
||||
"ui:event_dispatcher",
|
||||
"//chrome/browser/affiliations",
|
||||
- "//chrome/browser/glic",
|
||||
- "//chrome/browser/glic/actor:browser_tests",
|
||||
- "//chrome/browser/glic/test_support",
|
||||
"//chrome/browser/lookalikes:test_support",
|
||||
"//chrome/browser/optimization_guide",
|
||||
"//chrome/browser/optimization_guide:test_support",
|
||||
diff --git a/chrome/browser/android/tab_features.cc b/chrome/browser/android/tab_features.cc
|
||||
--- a/chrome/browser/android/tab_features.cc
|
||||
+++ b/chrome/browser/android/tab_features.cc
|
||||
@@ -9,8 +9,10 @@
|
||||
#include "chrome/browser/actor/actor_tab_data.h"
|
||||
#include "chrome/browser/actor/android/ui/actor_ui_tab_controller_android.h"
|
||||
#include "chrome/browser/glic/public/glic_enabling.h"
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
#include "chrome/browser/glic/public/widget/glic_side_panel_coordinator_android.h"
|
||||
#include "chrome/browser/glic/service/glic_instance_helper.h"
|
||||
+#endif
|
||||
#include "chrome/browser/net/qwac_web_contents_observer.h"
|
||||
#include "chrome/browser/preloading/new_tab_page_preload/new_tab_page_preload_pipeline_manager.h"
|
||||
#include "chrome/browser/profiles/profile.h"
|
||||
@@ -62,11 +64,13 @@ TabFeatures::TabFeatures(content::WebContents* web_contents, Profile* profile) {
|
||||
GetUserDataFactory().CreateInstance<lens::TabContextualizationController>(
|
||||
*tab, tab);
|
||||
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
glic_instance_helper_ =
|
||||
GetUserDataFactory().CreateInstance<glic::GlicInstanceHelper>(*tab, tab);
|
||||
glic_side_panel_coordinator_ =
|
||||
GetUserDataFactory()
|
||||
.CreateInstance<glic::GlicSidePanelCoordinatorAndroid>(*tab, tab);
|
||||
+#endif
|
||||
}
|
||||
|
||||
TabFeatures::~TabFeatures() = default;
|
||||
diff --git a/chrome/browser/android/tab_features.h b/chrome/browser/android/tab_features.h
|
||||
--- a/chrome/browser/android/tab_features.h
|
||||
+++ b/chrome/browser/android/tab_features.h
|
||||
@@ -26,10 +26,12 @@ namespace content {
|
||||
class WebContents;
|
||||
} // namespace content
|
||||
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
namespace glic {
|
||||
class GlicInstanceHelper;
|
||||
class GlicSidePanelCoordinator;
|
||||
} // namespace glic
|
||||
+#endif
|
||||
|
||||
namespace sync_sessions {
|
||||
class SyncSessionsRouterTabHelper;
|
||||
@@ -72,8 +74,10 @@ class TabFeatures {
|
||||
std::unique_ptr<lens::TabContextualizationController>
|
||||
tab_contextualization_controller_;
|
||||
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
std::unique_ptr<glic::GlicInstanceHelper> glic_instance_helper_;
|
||||
std::unique_ptr<glic::GlicSidePanelCoordinator> glic_side_panel_coordinator_;
|
||||
+#endif
|
||||
std::unique_ptr<actor::ui::ActorUiTabControllerInterface>
|
||||
actor_ui_tab_controller_;
|
||||
};
|
||||
diff --git a/chrome/browser/contextual_cueing/contextual_cueing_helper.cc b/chrome/browser/contextual_cueing/contextual_cueing_helper.cc
|
||||
--- a/chrome/browser/contextual_cueing/contextual_cueing_helper.cc
|
||||
+++ b/chrome/browser/contextual_cueing/contextual_cueing_helper.cc
|
||||
@@ -419,6 +419,7 @@ void ContextualCueingHelper::OnCueingDecision(
|
||||
return;
|
||||
}
|
||||
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
// Handle side panel auto-open case: bypass nudge and open panel directly.
|
||||
// If auto-open fails or is disabled, falls through to standard nudge.
|
||||
if (should_open_side_panel) {
|
||||
@@ -454,6 +455,7 @@ void ContextualCueingHelper::OnCueingDecision(
|
||||
contextual_cueing_service_->GetWeakPtr(),
|
||||
web_contents(), document_available_time,
|
||||
decision_result->is_dynamic));
|
||||
+#endif
|
||||
}
|
||||
|
||||
// static
|
||||
diff --git a/chrome/browser/contextual_cueing/contextual_cueing_page_data.cc b/chrome/browser/contextual_cueing/contextual_cueing_page_data.cc
|
||||
--- a/chrome/browser/contextual_cueing/contextual_cueing_page_data.cc
|
||||
+++ b/chrome/browser/contextual_cueing/contextual_cueing_page_data.cc
|
||||
@@ -10,6 +10,7 @@
|
||||
#include "base/strings/string_util.h"
|
||||
#include "base/task/single_thread_task_runner.h"
|
||||
#include "chrome/browser/glic/public/features.h"
|
||||
+#include "chrome/common/buildflags.h"
|
||||
#include "chrome/browser/contextual_cueing/contextual_cueing_features.h"
|
||||
#include "chrome/grit/generated_resources.h"
|
||||
#include "content/public/browser/web_contents.h"
|
||||
@@ -95,6 +96,7 @@ PAGE_USER_DATA_KEY_IMPL(ContextualCueingPageData);
|
||||
|
||||
// Attempts to find the matching cueing configuration.
|
||||
void ContextualCueingPageData::FindMatchingConfig() {
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
CHECK(cueing_decision_callback_);
|
||||
bool needs_pdf_page_count = false;
|
||||
bool needs_page_content = false;
|
||||
@@ -159,6 +161,7 @@ void ContextualCueingPageData::FindMatchingConfig() {
|
||||
// Wait till the page content is returned.
|
||||
return;
|
||||
}
|
||||
+#endif
|
||||
// None of the config matched, and no client-signals were requested.
|
||||
std::move(cueing_decision_callback_)
|
||||
.Run(base::unexpected(NudgeDecision::kClientConditionsUnmet));
|
||||
diff --git a/chrome/browser/extensions/api/pdf_viewer_private/BUILD.gn b/chrome/browser/extensions/api/pdf_viewer_private/BUILD.gn
|
||||
--- a/chrome/browser/extensions/api/pdf_viewer_private/BUILD.gn
|
||||
+++ b/chrome/browser/extensions/api/pdf_viewer_private/BUILD.gn
|
||||
@@ -18,7 +18,6 @@ source_set("pdf_viewer_private") {
|
||||
|
||||
deps = [
|
||||
"//base",
|
||||
- "//chrome/browser/glic",
|
||||
"//chrome/browser/pdf",
|
||||
"//chrome/browser/pdf:pdf_pref_names",
|
||||
"//chrome/browser/profiles:profile",
|
||||
@@ -46,8 +45,6 @@ source_set("browser_tests") {
|
||||
sources = [ "pdf_viewer_private_browsertest.cc" ]
|
||||
deps = [
|
||||
":pdf_viewer_private",
|
||||
- "//chrome/browser/glic",
|
||||
- "//chrome/browser/glic/test_support",
|
||||
"//chrome/test:test_support",
|
||||
"//content/test:test_support",
|
||||
]
|
||||
diff --git a/chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_api.cc b/chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_api.cc
|
||||
--- a/chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_api.cc
|
||||
+++ b/chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_api.cc
|
||||
@@ -12,9 +12,6 @@
|
||||
#include "base/numerics/safe_conversions.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "base/values.h"
|
||||
-#include "chrome/browser/glic/public/glic_enabling.h"
|
||||
-#include "chrome/browser/glic/public/glic_keyed_service.h"
|
||||
-#include "chrome/browser/glic/public/glic_keyed_service_factory.h"
|
||||
#include "chrome/browser/pdf/pdf_pref_names.h"
|
||||
#include "chrome/browser/pdf/pdf_viewer_stream_manager.h"
|
||||
#include "chrome/browser/profiles/profile.h"
|
||||
@@ -52,8 +49,6 @@ namespace SetPdfPluginAttributes =
|
||||
|
||||
namespace SetPdfDocumentTitle = api::pdf_viewer_private::SetPdfDocumentTitle;
|
||||
|
||||
-constexpr char kSummarizePrompt[] = "Summarize this document";
|
||||
-
|
||||
// Check if the current URL is allowed based on a list of allowlisted domains.
|
||||
bool IsUrlAllowedToEmbedLocalFiles(const GURL& current_url,
|
||||
const base::ListValue& allowlisted_domains) {
|
||||
@@ -308,43 +303,7 @@ ExtensionFunction::ResponseAction PdfViewerPrivateGlicSummarizeFunction::Run() {
|
||||
return RespondNow(Error("No tab."));
|
||||
}
|
||||
|
||||
- if (!glic::GlicEnabling::IsEnabledForProfile(
|
||||
- Profile::FromBrowserContext(contents->GetBrowserContext()))) {
|
||||
- return RespondNow(Error("Glic is not enabled."));
|
||||
- }
|
||||
-
|
||||
- glic::GlicKeyedService* glic_service =
|
||||
- glic::GlicKeyedServiceFactory::GetGlicKeyedService(
|
||||
- contents->GetBrowserContext());
|
||||
- CHECK(glic_service);
|
||||
-
|
||||
- int arm = features::kPdfGlicSummarizeArm.Get();
|
||||
- bool has_consented = glic::GlicEnabling::HasConsentedForProfile(
|
||||
- Profile::FromBrowserContext(contents->GetBrowserContext()));
|
||||
-
|
||||
- glic::GlicInvokeOptions options{
|
||||
- glic::mojom::InvocationSource::kPdfSummarizeButton};
|
||||
- options.prompts.push_back(kSummarizePrompt);
|
||||
- options.conversation = glic::NewConversation();
|
||||
-
|
||||
- if (has_consented) {
|
||||
- glic_service->InvokeWithAutoSubmit(
|
||||
- glic::InvokeWithAutoSubmitPasskeyProvider::GetPassKey(), tab_interface,
|
||||
- std::move(options));
|
||||
- } else {
|
||||
- if (arm == 3) {
|
||||
- options.fre_override = glic::mojom::FreOverride::kTrustFirstInline;
|
||||
- glic_service->InvokeWithAutoSubmit(
|
||||
- glic::InvokeWithAutoSubmitPasskeyProvider::GetPassKey(),
|
||||
- tab_interface, std::move(options));
|
||||
- } else {
|
||||
- options.fre_override = glic::mojom::FreOverride::kTrustFirstText;
|
||||
- glic_service->Invoke(tab_interface, std::move(options));
|
||||
- }
|
||||
- }
|
||||
-
|
||||
- success = true;
|
||||
- return RespondNow(NoArguments());
|
||||
+ return RespondNow(Error("Glic is not enabled."));
|
||||
}
|
||||
|
||||
} // namespace extensions
|
||||
diff --git a/chrome/browser/glic/BUILD.gn b/chrome/browser/glic/BUILD.gn
|
||||
--- a/chrome/browser/glic/BUILD.gn
|
||||
+++ b/chrome/browser/glic/BUILD.gn
|
||||
@@ -440,7 +440,7 @@ source_set("impl") {
|
||||
deps += [
|
||||
":actor_types_for_migration",
|
||||
"//chrome/browser/context_sharing/tab_bottom_sheet/android:jni_headers",
|
||||
- "//chrome/browser/glic/android",
|
||||
+ #"//chrome/browser/glic/android",
|
||||
"//ui/android",
|
||||
]
|
||||
}
|
||||
diff --git a/chrome/browser/glic/android/BUILD.gn b/chrome/browser/glic/android/BUILD.gn
|
||||
--- a/chrome/browser/glic/android/BUILD.gn
|
||||
+++ b/chrome/browser/glic/android/BUILD.gn
|
||||
@@ -62,7 +62,7 @@ android_library("java") {
|
||||
]
|
||||
}
|
||||
|
||||
-source_set("android") {
|
||||
+source_set("android_notused") {
|
||||
sources = [
|
||||
"glic_keyed_service_android.cc",
|
||||
"glic_keyed_service_android.h",
|
||||
diff --git a/chrome/browser/pdf/BUILD.gn b/chrome/browser/pdf/BUILD.gn
|
||||
--- a/chrome/browser/pdf/BUILD.gn
|
||||
+++ b/chrome/browser/pdf/BUILD.gn
|
||||
@@ -32,7 +32,6 @@ source_set("pdf") {
|
||||
"//build:chromeos_buildflags",
|
||||
"//chrome/browser:browser_process",
|
||||
"//chrome/browser:resources",
|
||||
- "//chrome/browser/glic",
|
||||
"//chrome/browser/pdf:pdf_pref_names",
|
||||
"//chrome/browser/profiles:profile",
|
||||
"//chrome/browser/resources/pdf:resources",
|
||||
diff --git a/chrome/browser/sync/BUILD.gn b/chrome/browser/sync/BUILD.gn
|
||||
--- a/chrome/browser/sync/BUILD.gn
|
||||
+++ b/chrome/browser/sync/BUILD.gn
|
||||
@@ -103,7 +103,7 @@ source_set("sync") {
|
||||
"//chrome/browser/password_manager/factories",
|
||||
"//chrome/browser/plus_addresses",
|
||||
"//chrome/browser/signin",
|
||||
- "//chrome/browser/skills",
|
||||
+ #"//chrome/browser/skills",
|
||||
"//chrome/browser/subscription_eligibility",
|
||||
"//chrome/browser/ui/sync",
|
||||
"//chrome/browser/ui/toolbar",
|
||||
@@ -146,7 +146,7 @@ source_set("sync") {
|
||||
"//components/saved_tab_groups/public",
|
||||
"//components/send_tab_to_self",
|
||||
"//components/sharing_message",
|
||||
- "//components/skills/public",
|
||||
+ #"//components/skills/public",
|
||||
"//components/spellcheck:buildflags",
|
||||
"//components/spellcheck/browser",
|
||||
"//components/strings:components_strings_grit",
|
||||
diff --git a/chrome/browser/sync/test/integration/BUILD.gn b/chrome/browser/sync/test/integration/BUILD.gn
|
||||
--- a/chrome/browser/sync/test/integration/BUILD.gn
|
||||
+++ b/chrome/browser/sync/test/integration/BUILD.gn
|
||||
@@ -254,7 +254,7 @@ source_set("sync_integration_tests_impl") {
|
||||
"//chrome/browser/search_engines",
|
||||
"//chrome/browser/send_tab_to_self",
|
||||
"//chrome/browser/sharing",
|
||||
- "//chrome/browser/skills",
|
||||
+ #"//chrome/browser/skills",
|
||||
"//chrome/browser/themes",
|
||||
"//chrome/browser/ui:ui_features",
|
||||
"//chrome/browser/ui/tabs/saved_tab_groups",
|
||||
diff --git a/chrome/browser/ui/pdf/BUILD.gn b/chrome/browser/ui/pdf/BUILD.gn
|
||||
--- a/chrome/browser/ui/pdf/BUILD.gn
|
||||
+++ b/chrome/browser/ui/pdf/BUILD.gn
|
||||
@@ -15,7 +15,6 @@ source_set("pdf") {
|
||||
]
|
||||
deps = [
|
||||
"//chrome/browser/download",
|
||||
- "//chrome/browser/glic",
|
||||
"//chrome/browser/pdf",
|
||||
"//chrome/browser/screen_ai:screen_ai_install_state",
|
||||
"//chrome/browser/ui/tab_contents",
|
||||
diff --git a/chrome/browser/ui/pdf/chrome_pdf_document_helper_client.cc b/chrome/browser/ui/pdf/chrome_pdf_document_helper_client.cc
|
||||
--- a/chrome/browser/ui/pdf/chrome_pdf_document_helper_client.cc
|
||||
+++ b/chrome/browser/ui/pdf/chrome_pdf_document_helper_client.cc
|
||||
@@ -66,6 +66,7 @@ void LogGlicSummarizeMetrics(content::RenderFrameHost* render_frame_host) {
|
||||
return;
|
||||
}
|
||||
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
bool glic_enabled = glic::GlicEnabling::IsEnabledForProfile(
|
||||
Profile::FromBrowserContext(web_contents_to_use->GetBrowserContext()));
|
||||
base::UmaHistogramBoolean("PDF.GlicEnabled", glic_enabled);
|
||||
@@ -74,6 +75,7 @@ void LogGlicSummarizeMetrics(content::RenderFrameHost* render_frame_host) {
|
||||
web_contents_to_use->GetBrowserContext());
|
||||
base::UmaHistogramBoolean("PDF.GlicSummarizeButtonEnabled",
|
||||
glic_summarize_button_enabled);
|
||||
+#endif
|
||||
}
|
||||
|
||||
} // namespace
|
||||
diff --git a/chrome/browser/ui/tabs/alert/tab_alert_controller.cc b/chrome/browser/ui/tabs/alert/tab_alert_controller.cc
|
||||
--- a/chrome/browser/ui/tabs/alert/tab_alert_controller.cc
|
||||
+++ b/chrome/browser/ui/tabs/alert/tab_alert_controller.cc
|
||||
@@ -173,12 +173,14 @@ std::u16string TabAlertController::GetTabAlertStateText(
|
||||
case TabAlert::kActorWaitingOnUser:
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_TOOLTIP_TAB_ALERT_STATE_ACTOR_ACCESSING);
|
||||
+#if BUILDFLAG(ENABLE_GLIC)
|
||||
case TabAlert::kGlicAccessing:
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_TOOLTIP_TAB_ALERT_STATE_GLIC_ACCESSING);
|
||||
case TabAlert::kGlicSharing:
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_TOOLTIP_TAB_ALERT_STATE_GLIC_SHARING);
|
||||
+#endif
|
||||
}
|
||||
NOTREACHED();
|
||||
}
|
||||
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
|
||||
--- a/chrome/common/BUILD.gn
|
||||
+++ b/chrome/common/BUILD.gn
|
||||
@@ -55,6 +55,7 @@ buildflag_header("buildflags") {
|
||||
"ENABLE_BACKGROUND_CONTENTS=$enable_background_contents",
|
||||
"ENABLE_CHROME_NOTIFICATIONS=$enable_chrome_notifications",
|
||||
"ENABLE_DOWNGRADE_PROCESSING=$enable_downgrade_processing",
|
||||
+ "ENABLE_GLIC=$enable_glic",
|
||||
"ENABLE_HANGOUT_SERVICES_EXTENSION=$enable_hangout_services_extension",
|
||||
"ENABLE_PDF_SAVE_TO_DRIVE=$enable_pdf_save_to_drive",
|
||||
"ENABLE_SERVICE_DISCOVERY=$enable_service_discovery",
|
||||
diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc
|
||||
--- a/chrome/common/chrome_features.cc
|
||||
+++ b/chrome/common/chrome_features.cc
|
||||
@@ -525,6 +525,7 @@ BASE_FEATURE(kGlic,
|
||||
base::FEATURE_DISABLED_BY_DEFAULT
|
||||
#endif
|
||||
);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kGlic);
|
||||
|
||||
// Controls whether the Glic feature is always detached.
|
||||
BASE_FEATURE(kGlicDetached, base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
diff --git a/chrome/common/features.gni b/chrome/common/features.gni
|
||||
--- a/chrome/common/features.gni
|
||||
+++ b/chrome/common/features.gni
|
||||
@@ -45,6 +45,8 @@ declare_args() {
|
||||
# Enables usage of notifications via Chrome's MessageCenter.
|
||||
enable_chrome_notifications = is_mac || is_win || is_linux
|
||||
|
||||
+ enable_glic = is_mac || is_win || is_linux || is_chromeos
|
||||
+
|
||||
# Skips unmigrated actor files in the build on Android. This is temporary, and
|
||||
# will eventually be removed once migration is done. Adding this flag likely
|
||||
# means the code needs to be adapted for Android. Once adapted, the final code
|
||||
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
|
||||
--- a/chrome/test/BUILD.gn
|
||||
+++ b/chrome/test/BUILD.gn
|
||||
@@ -2028,7 +2028,7 @@ if (is_android) {
|
||||
"//chrome/browser/content_settings:content_settings_factory",
|
||||
"//chrome/browser/enterprise/data_controls",
|
||||
"//chrome/browser/flags:flags_android",
|
||||
- "//chrome/browser/glic:browser_tests",
|
||||
+ #"//chrome/browser/glic:browser_tests",
|
||||
"//chrome/browser/history",
|
||||
"//chrome/browser/keyboard_accessory/android:public",
|
||||
"//chrome/browser/metrics:test_support",
|
||||
diff --git a/components/browser_sync/BUILD.gn b/components/browser_sync/BUILD.gn
|
||||
--- a/components/browser_sync/BUILD.gn
|
||||
+++ b/components/browser_sync/BUILD.gn
|
||||
@@ -50,7 +50,7 @@ static_library("browser_sync") {
|
||||
"//components/send_tab_to_self",
|
||||
"//components/sharing_message",
|
||||
"//components/skills:features",
|
||||
- "//components/skills/public",
|
||||
+ #"//components/skills/public",
|
||||
"//components/supervised_user/core/common:buildflags",
|
||||
"//components/sync/invalidations",
|
||||
"//components/sync_bookmarks",
|
||||
--
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user