Release 80.0.3987.95

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 80.0.3987.95
+* enable user-agent freeze (fixes https://github.com/bromite/bromite/issues/483)
+* fix issue with AMP (fixes https://github.com/bromite/bromite/issues/488)
+* fix crash on home page (fixes https://github.com/bromite/bromite/issues/484)
+
 # 80.0.3987.78
 * removed ungoogled-chromium patch for non-remote developer tools resources
 * removed patch for 64-bit webview (it is now a default from upstream)

FAQ.md

@@ -1,4 +1,4 @@
-# F.A.Q.
+# Frequently Asked Questions
 
 ## Does Google Sync/Translate/Data saver work?
 No.
@@ -63,7 +63,7 @@ No; Bromite will support extensions only if upstream (Chromium) does, or similar
 ## Why do push notifications not work on this website?
 
 The [Chromium Blink engine](https://www.chromium.org/blink) uses [GCM](https://en.wikipedia.org/wiki/Google_Cloud_Messaging) to deliver messages
-when websites use the [Push API](https://w3c.github.io/push-api/); this will not work because cloud integrations are disabled in Bromite (GCM in this case).
+when websites use the [Push API](https://w3c.github.io/push-api/); this will not work in Bromite because cloud integrations are disabled (GCM in this case).
 
 [ServiceWorker notifications](https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification) do work instead since they use
 [android.app.Notification](https://developer.android.com/guide/topics/ui/notifiers/notifications).

README.md

@@ -47,7 +47,7 @@ ETH donations address: `0xf47ff39223d828f99fec5ab53bd068c5c0522042`
 * [StartPage](https://startpage.com/), [DuckDuckGo](https://duckduckgo.com/) and [Qwant](https://www.qwant.com/) search engines available by default
 * flags to disable custom intents and clear session on exit
 * flags to toggle anti-fingerprinting mitigations for canvas, audio, client rects, webGL and sensor APIs
-* use fixed User-Agent to conceal real model and browser version
+* use frozen User-Agent to conceal real model and browser version
 * privacy enhancement patches from [Iridium](https://iridiumbrowser.de/), [Inox patchset](https://github.com/gcarq/inox-patchset), [Brave](https://brave.com/) and [ungoogled-chromium](https://github.com/Eloston/ungoogled-chromium) projects
 * security enhancement patches from [GrapheneOS](https://github.com/GrapheneOS) project
 

build/bromite_patches_list.txt

@@ -52,7 +52,6 @@ Add-flag-to-control-video-playback-resume-feature.patch
 Open-YouTube-links-in-Bromite.patch
 Add-exit-menu-item.patch
 Remove-help-menu-item.patch
-User-Agent-anonymize.patch
 AudioBuffer-AnalyserNode-fingerprinting-mitigations-via-IDL.patch
 Multiple-fingerprinting-mitigations-for-canvas-text-and-client-rectangles.patch
 Add-flags-to-disable-device-motion-and-orientation-APIs.patch
@@ -136,4 +135,5 @@ Restore-enable-horizontal-tab-switcher-flag.patch
 Use-a-minimum-DoH-timeout-of-400ms.patch
 Disable-DRM-media-origin-IDs-preprovisioning.patch
 Disable-smart-selection-by-default.patch
+Enable-user-agent-freeze-by-default.patch
 Automated-domain-substitution.patch

build/patches/Add-option-to-use-home-page-as-NTP.patch

@@ -21,7 +21,7 @@ diff --git a/chrome/android/java/res/xml/homepage_preferences.xml b/chrome/andro
  <PreferenceScreen
      xmlns:android="http://schemas.android.com/apk/res/android">
  
-+    <org.chromium.chrome.browser.preferences.ChromeSwitchPreference
++    <org.chromium.chrome.browser.settings.ChromeSwitchPreference
 +        android:key="ntp_is_homepage_switch"
 +        android:summaryOn="@string/options_ntp_is_homepage_label"
 +        android:summaryOff="@string/options_ntp_is_homepage_label" />

build/patches/Automated-domain-substitution.patch

@@ -14193,7 +14193,7 @@ diff --git a/chrome/browser/notifications/notification_permission_context.h b/ch
 diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
 --- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
 +++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
-@@ -479,7 +479,7 @@ bool NotificationPlatformBridgeMac::VerifyNotificationData(
+@@ -489,7 +489,7 @@ bool NotificationPlatformBridgeMac::VerifyNotificationData(
  // Overriden from _NSUserNotificationCenterDelegatePrivate.
  // Emitted when a user closes a notification from the notification center.
  // This is an undocumented method introduced in 10.8 according to
@@ -38278,7 +38278,7 @@ diff --git a/components/sync_bookmarks/PRESUBMIT.py b/components/sync_bookmarks/
 diff --git a/components/sync_bookmarks/bookmark_model_merger.cc b/components/sync_bookmarks/bookmark_model_merger.cc
 --- a/components/sync_bookmarks/bookmark_model_merger.cc
 +++ b/components/sync_bookmarks/bookmark_model_merger.cc
-@@ -624,7 +624,7 @@ void BookmarkModelMerger::ProcessLocalCreation(
+@@ -622,7 +622,7 @@ void BookmarkModelMerger::ProcessLocalCreation(
    DCHECK(parent_entity);
  
    // Similar to the directory implementation here:

build/patches/Enable-user-agent-freeze-by-default.patch

@@ -0,0 +1,23 @@
+From: csagan5 <32685696+csagan5@users.noreply.github.com>
+Date: Mon, 10 Feb 2020 23:13:13 +0100
+Subject: Enable user-agent freeze by default
+
+---
+ third_party/blink/common/features.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
+--- a/third_party/blink/common/features.cc
++++ b/third_party/blink/common/features.cc
+@@ -46,7 +46,7 @@ const base::Feature kFreezePurgeMemoryAllPagesFrozen{
+ 
+ // Freezes the user-agent as part of https://github.com/WICG/ua-client-hints.
+ const base::Feature kFreezeUserAgent{"FreezeUserAgent",
+-                                     base::FEATURE_DISABLED_BY_DEFAULT};
++                                     base::FEATURE_ENABLED_BY_DEFAULT};
+ 
+ // When enabled, the compositing of trivial 3D transforms is disabled.
+ const base::Feature kDoNotCompositeTrivial3D{"DoNotCompositeTrivial3D",
+-- 
+2.17.1
+

build/patches/User-Agent-anonymize.patch

@@ -1,59 +0,0 @@
-From: csagan5 <32685696+csagan5@users.noreply.github.com>
-Date: Wed, 21 Mar 2018 14:15:28 +0100
-Subject: User Agent: anonymize
-
-Use a fixed device name and product version with the goal of not
-disclosing the specific build of Bromite.
----
- components/version_info/version_info.cc |  3 ++-
- content/common/user_agent.cc            | 15 ++++-----------
- 2 files changed, 6 insertions(+), 12 deletions(-)
-
-diff --git a/components/version_info/version_info.cc b/components/version_info/version_info.cc
---- a/components/version_info/version_info.cc
-+++ b/components/version_info/version_info.cc
-@@ -16,7 +16,8 @@
- namespace version_info {
- 
- std::string GetProductNameAndVersionForUserAgent() {
--  return "Chrome/" + GetVersionNumber();
-+  // latest stable version
-+  return "Chrome/79.0.3945.136";
- }
- 
- std::string GetProductName() {
-diff --git a/content/common/user_agent.cc b/content/common/user_agent.cc
---- a/content/common/user_agent.cc
-+++ b/content/common/user_agent.cc
-@@ -87,7 +87,7 @@ std::string BuildOSCpuInfo(bool include_android_build_number) {
-       architecture_token = "; Win64; IA64";
-   }
- #elif defined(OS_ANDROID)
--  std::string android_version_str = base::SysInfo::OperatingSystemVersion();
-+  std::string android_version_str = "9.0.0";
-   std::string android_info_str = GetAndroidOSInfo(include_android_build_number);
- #elif defined(OS_POSIX) && !defined(OS_MACOSX)
-   // Should work on any Posix system.
-@@ -159,16 +159,9 @@ std::string BuildUserAgentFromProductAndExtraOSInfo(
- }
- 
- std::string GetAndroidOSInfo(bool include_android_build_number) {
--  std::string android_info_str;
--
--  // Send information about the device.
--  bool semicolon_inserted = false;
--  std::string android_build_codename = base::SysInfo::GetAndroidBuildCodename();
--  std::string android_device_name = base::SysInfo::HardwareModelName();
--  if (!android_device_name.empty() && "REL" == android_build_codename) {
--    android_info_str += "; " + android_device_name;
--    semicolon_inserted = true;
--  }
-+  // Send spoofed information about the device.
-+  std::string android_info_str = "; SM-G955U";
-+  bool semicolon_inserted = true;
- 
-   // Append the build ID.
-   if (base::FeatureList::IsEnabled(kAndroidUserAgentStringContainsBuildId) ||
--- 
-2.17.1
-