Release 77.0.3865.95

.github/ISSUE_TEMPLATE/bug_report.md

@@ -11,13 +11,17 @@ Arch: `arm` or `arm64` or `x86`
 Android version: (example: `9.0`)
 Device model: (example: `SM-G960UZKABST`)
 
+**Is this bug about the SystemWebView?**
+Yes/No
+
 **Is the bug reproducible with latest version?**
 
 Do not report bugs which are not reproducible with latest version
 
-**Can the bug be reproduced with corresponding [Chromium](https://github.com/bromite/chromium/releases) version?**
+**Can the bug be reproduced with corresponding Chromium version?**
 
-If yes then report it upstream on [Chromium issue tracker](https://bugs.chromium.org/p/chromium/issues/list) and do not forget to read [Chromium project bug reporting guidelines](https://www.chromium.org/for-testers/bug-reporting-guidelines) first.
+Please pick the same version of Chromium as Bromite from here: https://github.com/bromite/chromium/releases
+If the bug is reproducible then it might be a configuration issue or an upstream bug. Upstream bugs can be reported on the [Chromium issue tracker](https://bugs.chromium.org/p/chromium/issues/list) and do not forget to read [Chromium project bug reporting guidelines](https://www.chromium.org/for-testers/bug-reporting-guidelines) first.
 
 **Is the bug a crash?**
 
@@ -41,4 +45,4 @@ A clear and concise description of what you expected to happen.
 
 **Screenshots**
 
-If applicable, add screenshots to help explain your problem.
+If applicable, add screenshots to help explain your problem. Otherwise remove this section.

CHANGELOG.md

@@ -1,3 +1,5 @@
+# 77.0.3865.95
+
 # 77.0.3865.81
 * use native subresource filtering instead of Bromite engine
 * introduce Bromite AdBlockUpdate service

README.md

@@ -75,7 +75,7 @@ Yes, since version 69. While the desktop version of Chromium has an option to di
 
 # Features
 
-* baked-in adblock engine
+* native adblock engine
 * remove click-tracking and AMP from search results
 * DNS-over-HTTPS support via Google, Cloudflare, Quad9 and AdGuard servers
 * [proxy configuration page](https://github.com/bromite/bromite/wiki/ProxyConfiguration) with PAC and custom proxy lists support
@@ -143,7 +143,13 @@ The [Bromite main repository](https://github.com/bromite/bromite) contains tags
 Please refer to [official Chromium build documentation](https://www.chromium.org/developers/how-tos/get-the-code) to get started on how to build Chromium; if you can build Chromium for Android, you can build Bromite.
 
 The GN args used to build Bromite are available here: [GN_ARGS](./build/GN_ARGS).
-The patches are to be applied second the order specified in the `patches_list.txt` file (you can use `git am`); the big file `adblock_entries.h` (containing all the AdBlock filters) needs to be copied under `src/net/url_request/`.
+The patches are to be applied second the order specified in the `patches_list.txt` file (you can use `git am`); the big file `adblock_entries.h` (containing all the AdBlock filters) needs to be copied under `src/net/url_request/`. This file is only used for the SystemWebView.
+
+## How to build the filters
+
+See upstream documentation: https://github.com/chromium/chromium/blob/master/components/subresource_filter/FILTER_LIST_GENERATION.md
+
+Bromite uses an unindexed filter file, which is periodically published at https://github.com/bromite/filters
 
 # Credits
 
@@ -153,7 +159,7 @@ The patches are to be applied second the order specified in the `patches_list.tx
 * [GrapheneOS](https://github.com/GrapheneOS) for some security patches
 * [Inox patchset](https://github.com/gcarq/inox-patchset) for some patches (via ungoogled-chromium)
 * [Brave Browser](https://github.com/brave/browser-android-tabs) for some patches
-* nochromo for the original adblock patch
+* nochromo for the original adblock patch, currently used only in the SystemWebView
 * [Vadim Pleshkov](http://vadimpleshkov.me/) for Bromite's logo
 
 # Filters credits

build/patches/Add-a-proxy-configuration-page.patch

@@ -977,7 +977,7 @@ new file mode 100644
 diff --git a/chrome/common/webui_url_constants.cc b/chrome/common/webui_url_constants.cc
 --- a/chrome/common/webui_url_constants.cc
 +++ b/chrome/common/webui_url_constants.cc
-@@ -180,6 +180,8 @@ const char kChromeUINativePhysicalWebDiagnosticsURL[] =
+@@ -185,6 +185,8 @@ const char kChromeUINativePhysicalWebDiagnosticsURL[] =
  const char kChromeUINativeScheme[] = "chrome-native";
  const char kChromeUIOfflineInternalsHost[] = "offline-internals";
  const char kChromeUIPhysicalWebDiagnosticsHost[] = "physical-web-diagnostics";
@@ -986,7 +986,7 @@ diff --git a/chrome/common/webui_url_constants.cc b/chrome/common/webui_url_cons
  const char kChromeUISnippetsInternalsHost[] = "snippets-internals";
  const char kChromeUIWebApksHost[] = "webapks";
  #endif
-@@ -439,6 +441,7 @@ bool IsOSSettingsSubPage(const std::string& sub_page) {
+@@ -444,6 +446,7 @@ bool IsOSSettingsSubPage(const std::string& sub_page) {
        kResetSubPage,
        kSmartLockSettingsSubPage,
        kSmbSharesSubPage,
@@ -994,7 +994,7 @@ diff --git a/chrome/common/webui_url_constants.cc b/chrome/common/webui_url_cons
        kStorageSubPage,
        kStylusSubPage,
        // sync is both an OS and browser sub page, but prefer the OS version
-@@ -538,6 +541,7 @@ const char* const kChromeHostURLs[] = {
+@@ -543,6 +546,7 @@ const char* const kChromeHostURLs[] = {
  #if !defined(OS_ANDROID)
  #if !defined(OS_CHROMEOS)
      kChromeUIAppLauncherPageHost,

build/patches/Allow-playing-audio-in-background.patch

@@ -25,7 +25,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
 diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
 --- a/media/blink/webmediaplayer_impl.cc
 +++ b/media/blink/webmediaplayer_impl.cc
-@@ -959,6 +959,12 @@ bool WebMediaPlayerImpl::HasAudio() const {
+@@ -960,6 +960,12 @@ bool WebMediaPlayerImpl::HasAudio() const {
    return pipeline_metadata_.has_audio;
  }
  
@@ -38,7 +38,7 @@ diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_imp
  void WebMediaPlayerImpl::EnabledAudioTracksChanged(
      const blink::WebVector<blink::WebMediaPlayer::TrackId>& enabledTrackIds) {
    DCHECK(main_task_runner_->BelongsToCurrentThread());
-@@ -3257,7 +3263,11 @@ bool WebMediaPlayerImpl::ShouldPausePlaybackWhenHidden() const {
+@@ -3259,7 +3265,11 @@ bool WebMediaPlayerImpl::ShouldPausePlaybackWhenHidden() const {
    // Audio only stream is allowed to play when in background.
    // TODO: We should check IsBackgroundOptimizationCandidate here. But we need
    // to move the logic of checking video frames out of that function.

build/patches/Bromite-AdBlockUpdaterService.patch

@@ -179,7 +179,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
  #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
  #include "chrome/browser/password_manager/chrome_password_manager_client.h"
-@@ -4085,16 +4083,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
+@@ -4083,16 +4081,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
      content::NavigationHandle* handle) {
    std::vector<std::unique_ptr<content::NavigationThrottle>> throttles;
  
@@ -196,7 +196,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  #if BUILDFLAG(ENABLE_PLUGINS)
    std::unique_ptr<content::NavigationThrottle> flash_url_throttle =
        FlashDownloadInterception::MaybeCreateThrottleFor(handle);
-@@ -4204,12 +4192,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
+@@ -4202,12 +4190,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
    }
  #endif
  

build/patches/Disable-safe-browsing.patch

@@ -11,7 +11,7 @@ Originally based on ungoogled-chromium patch
  chrome/browser/browser_process_impl.cc             | 36 -----------
  chrome/browser/browser_process_impl.h              |  6 --
  .../chrome_browsing_data_remover_delegate.cc       | 40 -------------
- chrome/browser/chrome_content_browser_client.cc    | 56 +----------------
+ chrome/browser/chrome_content_browser_client.cc    | 60 ++-----------------
  .../file_type_policies_component_installer.cc      | 16 +----
  .../download/chrome_download_manager_delegate.cc   | 31 ++++------
  .../download/chrome_download_manager_delegate.h    |  6 ++
@@ -44,7 +44,7 @@ Originally based on ungoogled-chromium patch
  chrome/common/safe_browsing/BUILD.gn               | 15 -----
  chrome/renderer/chrome_content_renderer_client.cc  |  1 -
  components/safe_browsing/features.cc               |  2 +-
- 40 files changed, 104 insertions(+), 497 deletions(-)
+ 40 files changed, 105 insertions(+), 500 deletions(-)
 
 diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
 --- a/chrome/android/chrome_java_sources.gni
@@ -83,7 +83,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareS
 diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
 --- a/chrome/browser/BUILD.gn
 +++ b/chrome/browser/BUILD.gn
-@@ -2952,8 +2952,6 @@ jumbo_split_static_library("browser") {
+@@ -2954,8 +2954,6 @@ jumbo_split_static_library("browser") {
        "download/download_commands.h",
        "download/download_crx_util.cc",
        "download/download_crx_util.h",
@@ -282,15 +282,17 @@ diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.
 diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
 --- a/chrome/browser/chrome_content_browser_client.cc
 +++ b/chrome/browser/chrome_content_browser_client.cc
-@@ -121,7 +121,6 @@
+@@ -119,9 +119,6 @@
+ #include "chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.h"
+ #include "chrome/browser/renderer_preferences_util.h"
  #include "chrome/browser/resource_coordinator/background_tab_navigation_throttle.h"
- #include "chrome/browser/safe_browsing/certificate_reporting_service.h"
- #include "chrome/browser/safe_browsing/certificate_reporting_service_factory.h"
+-#include "chrome/browser/safe_browsing/certificate_reporting_service.h"
+-#include "chrome/browser/safe_browsing/certificate_reporting_service_factory.h"
 -#include "chrome/browser/safe_browsing/safe_browsing_navigation_throttle.h"
  #include "chrome/browser/safe_browsing/safe_browsing_service.h"
  #include "chrome/browser/safe_browsing/ui_manager.h"
  #include "chrome/browser/safe_browsing/url_checker_delegate_impl.h"
-@@ -137,7 +136,7 @@
+@@ -137,7 +134,7 @@
  #include "chrome/browser/speech/tts_message_filter.h"
  #include "chrome/browser/ssl/insecure_sensitive_input_driver_factory.h"
  #include "chrome/browser/ssl/ssl_blocking_page.h"
@@ -299,7 +301,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  #include "chrome/browser/ssl/ssl_client_auth_metrics.h"
  #include "chrome/browser/ssl/ssl_client_certificate_selector.h"
  #include "chrome/browser/ssl/ssl_error_handler.h"
-@@ -909,30 +908,6 @@ void SetApplicationLocaleOnIOThread(const std::string& locale) {
+@@ -909,30 +906,6 @@ void SetApplicationLocaleOnIOThread(const std::string& locale) {
    GetIOThreadApplicationLocale() = locale;
  }
  
@@ -330,7 +332,16 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  #if defined(OS_ANDROID)
  float GetDeviceScaleAdjustment() {
    static const float kMinFSM = 1.05f;
-@@ -2154,7 +2129,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
+@@ -2061,7 +2034,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
+   }
+ #elif defined(OS_POSIX)
+ #if defined(OS_ANDROID)
+-  bool enable_crash_reporter = true;
++  bool enable_crash_reporter = false;
+ #else
+   bool enable_crash_reporter = breakpad::IsCrashReporterEnabled();
+ #endif
+@@ -2154,7 +2127,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
        // Disable client-side phishing detection in the renderer if it is
        // disabled in the Profile preferences or the browser process.
        if (!prefs->GetBoolean(prefs::kSafeBrowsingEnabled) ||
@@ -339,7 +350,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
          command_line->AppendSwitch(
              switches::kDisableClientSidePhishingDetection);
        }
-@@ -3013,9 +2988,6 @@ bool ChromeContentBrowserClient::CanCreateWindow(
+@@ -3013,9 +2986,6 @@ bool ChromeContentBrowserClient::CanCreateWindow(
  
  void ChromeContentBrowserClient::ResourceDispatcherHostCreated() {
    DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -349,7 +360,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  }
  
  content::SpeechRecognitionManagerDelegate*
-@@ -4251,11 +4223,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
+@@ -4251,11 +4221,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
    throttles.push_back(std::make_unique<PolicyBlacklistNavigationThrottle>(
        handle, handle->GetWebContents()->GetBrowserContext()));
  
@@ -361,7 +372,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
    std::unique_ptr<content::NavigationThrottle> https_upgrade_timing_throttle =
        TypedNavigationTimingThrottle::MaybeCreateThrottleFor(handle);
    if (https_upgrade_timing_throttle)
-@@ -4284,11 +4251,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
+@@ -4284,11 +4249,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
        PreviewsLitePageDecider::MaybeCreateThrottleFor(handle);
    if (previews_lite_page_throttle)
      throttles.push_back(std::move(previews_lite_page_throttle));
@@ -373,7 +384,7 @@ diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/ch
  
  #if defined(OS_WIN) || defined(OS_MACOSX) || \
      (defined(OS_LINUX) && !defined(OS_CHROMEOS))
-@@ -5404,19 +5366,7 @@ ChromeContentBrowserClient::GetSafeBrowsingUrlCheckerDelegate(
+@@ -5426,19 +5386,7 @@ ChromeContentBrowserClient::GetSafeBrowsingUrlCheckerDelegate(
      content::ResourceContext* resource_context) {
    DCHECK_CURRENTLY_ON(BrowserThread::IO);