Added explanation for Google Sync

Removed no-more-working (and dubious) patch

CHANGELOG.md

@@ -1,3 +1,10 @@
+# 63.0.3239.46
+* removed search engine geolocation default patch
+
+# 63.0.3239.38
+
+# 63.0.3239.27
+
 # 63.0.3239.24
 * convert AMP search results to regular search results
 
@@ -21,16 +28,16 @@
 * first release with NoChromo adblocking patch
 * Bromite patch: disable NTP remote suggestions
 * added some Inox/Iridium/Ungoogled-Chromium patches, namely:
-** DuckDuckGo search engine
-** disable battery status service
-** disable formatting in OmniBox
-** disable GCM status checks
-** use local fonts instead of fonts from Google servers
-** disable updater pings
-** do not enable Google integrations by default (translation, lookup, etc)
-** disable the ad promo system
-** do not store passwords by default
-** do not fetch Google promotions
-** restore classic NTP
-** only keep cookies until exit
-** block third-party cookies
+   * DuckDuckGo search engine
+   * disable battery status service
+   * disable formatting in OmniBox
+   * disable GCM status checks
+   * use local fonts instead of fonts from Google servers
+   * disable updater pings
+   * do not enable Google integrations by default (translation, lookup, etc)
+   * disable the ad promo system
+   * do not store passwords by default
+   * do not fetch Google promotions
+   * restore classic NTP
+   * only keep cookies until exit
+   * block third-party cookies

README.md

@@ -32,6 +32,12 @@ ETH donations address: `0xf47ff39223d828f99fec5ab53bd068c5c0522042`
 * all codecs included (proprietary, open H.264 etc.)
 * built with official Chrome optimizations
 
+# F.A.Q.
+
+## Does Google Sync work?
+No. You would have to use your own API keys, which I do not know how you could pass via environment variables on Android.
+This is not a limitation of Bromite but of all Chromium-based projects in general, as general public is not allowed to use Google's APIs for free unless when using Chrome.
+
 # Releases
 
 A build server goes through the very lengthy build operation and then new versions are available in this project as [releases](https://github.com/bromite/bromite/releases).

patches/privacy/0019-stop-enabling-search-engine-geolocation-by-default.patch

@@ -1,69 +0,0 @@
-From bc266421a13f4967a3d5b49830c338f59e4f2dd5 Mon Sep 17 00:00:00 2001
-From: Daniel Micay <danielmicay@gmail.com>
-Date: Tue, 1 Aug 2017 20:29:56 -0400
-Subject: [PATCH 19/21] stop enabling search engine geolocation by default
-
----
- .../search_geolocation_service.cc                  | 25 ++++++++++------------
- 1 file changed, 11 insertions(+), 14 deletions(-)
-
-diff --git a/chrome/browser/android/search_geolocation/search_geolocation_service.cc b/chrome/browser/android/search_geolocation/search_geolocation_service.cc
-index 0ed5540c3262..e5721d53c344 100644
---- a/chrome/browser/android/search_geolocation/search_geolocation_service.cc
-+++ b/chrome/browser/android/search_geolocation/search_geolocation_service.cc
-@@ -208,7 +208,14 @@ void SearchGeolocationService::SetDSEGeolocationSetting(bool setting) {
-   pref.setting = setting;
-   SetDSEGeolocationPref(pref);
- 
--  ResetContentSetting();
-+  url::Origin origin = delegate_->GetDSEOrigin();
-+  if (setting) {
-+      host_content_settings_map_->SetContentSettingDefaultScope(
-+          origin.GetURL(), origin.GetURL(), CONTENT_SETTINGS_TYPE_GEOLOCATION,
-+          std::string(), CONTENT_SETTING_ALLOW);
-+  } else {
-+      ResetContentSetting();
-+  }
- }
- 
- url::Origin SearchGeolocationService::GetDSEOriginIfEnabled() {
-@@ -232,11 +239,7 @@ void SearchGeolocationService::OnDSEChanged() {
-   // Remove any geolocation embargo on the URL.
-   PermissionDecisionAutoBlocker::GetForProfile(profile_)->RemoveEmbargoByUrl(
-       delegate_->GetDSEOrigin().GetURL(), CONTENT_SETTINGS_TYPE_GEOLOCATION);
--  if (content_setting == CONTENT_SETTING_BLOCK && pref.setting) {
--    pref.setting = false;
--  } else if (content_setting == CONTENT_SETTING_ALLOW && !pref.setting) {
--    ResetContentSetting();
--  }
-+  pref.setting = content_setting == CONTENT_SETTING_ALLOW;
- 
-   if (new_dse_name != pref.dse_name && pref.setting)
-     SearchGeolocationDisclosureTabHelper::ResetDisclosure(profile_);
-@@ -279,7 +282,7 @@ void SearchGeolocationService::InitializeDSEGeolocationSettingIfNeeded() {
- 
-     PrefValue pref;
-     pref.dse_name = delegate_->GetDSEName();
--    pref.setting = content_setting != CONTENT_SETTING_BLOCK;
-+    pref.setting = content_setting == CONTENT_SETTING_ALLOW;
-     SetDSEGeolocationPref(pref);
- 
-     SearchGeolocationDisclosureTabHelper::ResetDisclosure(profile_);
-@@ -289,13 +292,7 @@ void SearchGeolocationService::InitializeDSEGeolocationSettingIfNeeded() {
- void SearchGeolocationService::EnsureDSEGeolocationSettingIsValid() {
-   PrefValue pref = GetDSEGeolocationPref();
-   ContentSetting content_setting = GetCurrentContentSetting();
--  bool new_setting = pref.setting;
--
--  if (pref.setting && content_setting == CONTENT_SETTING_BLOCK) {
--    new_setting = false;
--  } else if (!pref.setting && content_setting == CONTENT_SETTING_ALLOW) {
--    new_setting = true;
--  }
-+  bool new_setting = content_setting == CONTENT_SETTING_ALLOW;
- 
-   if (pref.setting != new_setting) {
-     pref.setting = new_setting;
--- 
-2.14.2
-