#712 Adds a setting for blocking the toolbar hiding

2024-05-22 16:58:09 +02:00
parent feccf71b01
commit eee1d0f59d
1 changed files with 64 additions and 0 deletions
@@ -0,0 +1,64 @@
+From: uazo <uazo@users.noreply.github.com>
+Date: Wed, 22 May 2024 07:41:34 +0000
+Subject: Android Toolbar Scroll Ablation setting
+
+Adds a setting for blocking the toolbar hiding
+
+need: Add-cromite-flags-support.patch
+License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
+---
+ .../Toolbar-Scroll-Ablation-flag.grdp                |  9 +++++++++
+ .../java/res/xml/accessibility_preferences.xml       |  6 ++++++
+ .../about_flags_cc/Toolbar-Scroll-Ablation-flag.inc  | 12 ++++++++++++
+ 3 files changed, 27 insertions(+)
+ create mode 100644 chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Toolbar-Scroll-Ablation-flag.grdp
+ create mode 100644 cromite_flags/chrome/browser/about_flags_cc/Toolbar-Scroll-Ablation-flag.inc
+
+diff --git a/chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Toolbar-Scroll-Ablation-flag.grdp b/chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Toolbar-Scroll-Ablation-flag.grdp
+new file mode 100644
+--- /dev/null
+++ b/chrome/browser/ui/android/strings/cromite_android_chrome_strings_grd/Toolbar-Scroll-Ablation-flag.grdp
+@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<grit-part>
+    <message name="IDS_LOCK_TOOLBAR_TITLE" desc="Text for 'Always show toolbar' settings option.">
+        Always show toolbar
+    </message>
+    <message name="IDS_LOCK_TOOLBAR_SUMMARY" desc="Summary text for 'Always show toolbar' settings option.">
+        Blocks the toolbar's hiding
+    </message>
+</grit-part>
+diff --git a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
+--- a/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
+++ b/components/browser_ui/accessibility/android/java/res/xml/accessibility_preferences.xml
+@@ -73,6 +73,12 @@ found in the LICENSE file.
+         android:key="disable_toolbar_swipeup"
+         android:title="@string/disable_toolbar_swipe_up" />
+ 
+    <org.chromium.components.browser_ui.settings.ChromeSwitchPreference
+        android:title="@string/lock_toolbar_title"
+        android:summary="@string/lock_toolbar_summary"
+        app:featureName="android-toolbar-scroll-ablation"
+        app:needRestart="true" />
+
+     <PreferenceCategory
+         android:key="customize_selecton_popup_section"
+         android:title="@string/customize_selecton_popup_title" />
+diff --git a/cromite_flags/chrome/browser/about_flags_cc/Toolbar-Scroll-Ablation-flag.inc b/cromite_flags/chrome/browser/about_flags_cc/Toolbar-Scroll-Ablation-flag.inc
+new file mode 100644
+--- /dev/null
+++ b/cromite_flags/chrome/browser/about_flags_cc/Toolbar-Scroll-Ablation-flag.inc
+@@ -0,0 +1,12 @@
+#if BUILDFLAG(IS_ANDROID)
+
+#ifdef FLAG_SECTION
+
+    {"android-toolbar-scroll-ablation",
+     "Android Toolbar Scroll Ablation",
+     "Always shows the toolbar", kOsAndroid,
+     FEATURE_VALUE_TYPE(chrome::android::kAndroidToolbarScrollAblation)},
+
+#endif
+
+#endif
+--