Disable privacy issues in password manager: editing of flags moved to a separate file (cromite_flags)
This commit is contained in:
@@ -2,6 +2,7 @@ From: uazo <uazo@users.noreply.github.com>
|
||||
Date: Tue, 14 Mar 2023 15:59:38 +0000
|
||||
Subject: Disable privacy issues in password manager
|
||||
|
||||
Need: Add-cromite-flags-support.patch
|
||||
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
---
|
||||
chrome/android/java/AndroidManifest.xml | 9 ---------
|
||||
@@ -11,10 +12,11 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
||||
.../affiliations/core/browser/affiliation_backend.cc | 1 +
|
||||
.../core/browser/affiliation_service_impl.cc | 4 ++++
|
||||
components/affiliations/core/browser/facet_manager.cc | 4 ++++
|
||||
.../core/browser/features/password_features.cc | 4 ++++
|
||||
.../leak_detection/leak_detection_check_factory_impl.cc | 5 +++++
|
||||
.../browser/leak_detection/leak_detection_check_impl.cc | 3 +--
|
||||
10 files changed, 22 insertions(+), 14 deletions(-)
|
||||
.../Disable-privacy-issues-in-password-manager.inc | 3 +++
|
||||
10 files changed, 21 insertions(+), 14 deletions(-)
|
||||
create mode 100644 cromite_flags/components/password_manager/core/browser/features/password_features_cc/Disable-privacy-issues-in-password-manager.inc
|
||||
|
||||
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
|
||||
--- a/chrome/android/java/AndroidManifest.xml
|
||||
@@ -110,18 +112,6 @@ diff --git a/components/affiliations/core/browser/facet_manager.cc b/components/
|
||||
if (IsCachedDataFresh()) {
|
||||
AffiliatedFacetsWithUpdateTime affiliation;
|
||||
if (!backend_->ReadAffiliationsAndBrandingFromDatabase(facet_uri_,
|
||||
diff --git a/components/password_manager/core/browser/features/password_features.cc b/components/password_manager/core/browser/features/password_features.cc
|
||||
--- a/components/password_manager/core/browser/features/password_features.cc
|
||||
+++ b/components/password_manager/core/browser/features/password_features.cc
|
||||
@@ -206,4 +206,8 @@ BASE_FEATURE(kUsernameFirstFlowWithIntermediateValuesVoting,
|
||||
"UsernameFirstFlowWithIntermediateValuesVoting",
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
+SET_CROMITE_FEATURE_ENABLED(kFillOnAccountSelect);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableReceiverService);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableSenderService);
|
||||
+
|
||||
} // namespace password_manager::features
|
||||
diff --git a/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc b/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc
|
||||
--- a/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc
|
||||
+++ b/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc
|
||||
@@ -150,4 +140,12 @@ diff --git a/components/password_manager/core/browser/leak_detection/leak_detect
|
||||
}
|
||||
|
||||
void LeakDetectionCheckImpl::Start(LeakDetectionInitiator initiator,
|
||||
diff --git a/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Disable-privacy-issues-in-password-manager.inc b/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Disable-privacy-issues-in-password-manager.inc
|
||||
new file mode 100644
|
||||
--- /dev/null
|
||||
+++ b/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Disable-privacy-issues-in-password-manager.inc
|
||||
@@ -0,0 +1,3 @@
|
||||
+SET_CROMITE_FEATURE_ENABLED(kFillOnAccountSelect);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableReceiverService);
|
||||
+SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableSenderService);
|
||||
--
|
||||
|
||||
Reference in New Issue
Block a user