8db2d30fab
The issues is that TimeZoneData is being loaded with LoaderManager on every fragment's onCreate(). At the same time this fragment has onActivityResult() handler that accesses TimeZoneData and relies on the fact that it has been already initialized prior this call. So when you enable "Don't keep activities" mode, the TimeZoneSettings fragment [1] that holds TimeZoneData is immediately destroyed after launching time zone picker fragment [2] (which result [1] waits for), and when android calls onActivityResult() for [1] (after time zone has been picked in [2]), Android has to recreate [1] from scratch. So you get onCreate() called and immidiately after that onActivityResult() called, and at this point we get the crash, because the loader hasn't finished yet and onActivityResult() tries to access uninitialized mTimeZoneData. This CL fixes this crash issue by postponing mTimeZoneData.lookupCountryTimeZones call until mTimeZoneData is loaded by loader. It is done through saving data intent in onActivityResult() and calling onZonePickerRequestResult() when time zone data is loaded. Bug: 112351583 Test: m Settings droid successfully builds, manual testing with "Don't keep activities" mode enabled Change-Id: Id30d36dc17a0de96ba871f9d0f4a2686479d0eeb