Files
app_Settings/src/com/android/settings/applications/InstalledAppDetailsTop.java
Chaohui Wang 88e20ec62e Fix SpaActivity launched twice for App Info
This happens when shouldShowTwoPaneDeepLink() return true, the
InstalledAppDetailsTop onCreate() is called twice.

Only try start spa when the activity is not finishing to fix.

Bug: 236346018
Test: Manually with Settings
Change-Id: I4b09fba0733a6451a2ba6fd90960f9151692a2ad
2023-03-26 22:39:20 +09:00

59 lines
2.0 KiB
Java

/*
* Copyright (C) 2010 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.applications;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.util.FeatureFlagUtils;
import com.android.settings.SettingsActivity;
import com.android.settings.applications.appinfo.AppInfoDashboardFragment;
import com.android.settings.spa.SpaActivity;
import com.android.settings.spa.app.appinfo.AppInfoSettingsProvider;
public class InstalledAppDetailsTop extends SettingsActivity {
@Override
protected void onCreate(Bundle savedState) {
super.onCreate(savedState);
if (isFinishing() ||
!FeatureFlagUtils.isEnabled(this, FeatureFlagUtils.SETTINGS_ENABLE_SPA)) {
return;
}
Uri data = super.getIntent().getData();
if (data != null) {
String packageName = data.getSchemeSpecificPart();
String route = AppInfoSettingsProvider.INSTANCE.getRoute(packageName, getUserId());
SpaActivity.startSpaActivity(this, route);
}
finish();
}
@Override
public Intent getIntent() {
Intent modIntent = new Intent(super.getIntent());
modIntent.putExtra(EXTRA_SHOW_FRAGMENT, AppInfoDashboardFragment.class.getName());
return modIntent;
}
@Override
protected boolean isValidFragment(String fragmentName) {
return AppInfoDashboardFragment.class.getName().equals(fragmentName);
}
}