Files
app_Settings/src/com/android/settings/wfd/WifiDisplayPreferenceController.java
hoffc 99e33291d3 Settings: fix unexpected routing selection
setRouterGroupId in WifiDisplayPreferenceController will result in unexpected routing selection in MediaRouter, which will lead to WFD scanning not be triggered when entering WFD settings page if there is one remembered WFD device exists before reboot.

Remove the set group id call.

Bug: 351110755

Change-Id: I0d434543338d9896116541963f31e4669d877ea8
2024-07-04 09:02:23 +00:00

112 lines
3.7 KiB
Java

/*
* Copyright (C) 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License
*/
package com.android.settings.wfd;
import android.content.Context;
import android.media.MediaRouter;
import android.media.MediaRouter.RouteInfo;
import android.text.TextUtils;
import androidx.preference.Preference;
import androidx.preference.PreferenceScreen;
import com.android.settings.R;
import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart;
import com.android.settingslib.core.lifecycle.events.OnStop;
public class WifiDisplayPreferenceController extends BasePreferenceController implements
LifecycleObserver, OnStart, OnStop {
private final MediaRouter mRouter;
private Preference mPreference;
private final MediaRouter.Callback mRouterCallback = new MediaRouter.SimpleCallback() {
@Override
public void onRouteSelected(MediaRouter router, int type, RouteInfo info) {
refreshSummary(mPreference);
}
@Override
public void onRouteUnselected(MediaRouter router, int type, RouteInfo info) {
refreshSummary(mPreference);
}
@Override
public void onRouteAdded(MediaRouter router, RouteInfo info) {
refreshSummary(mPreference);
}
@Override
public void onRouteRemoved(MediaRouter router, RouteInfo info) {
refreshSummary(mPreference);
}
@Override
public void onRouteChanged(MediaRouter router, RouteInfo info) {
refreshSummary(mPreference);
}
};
public WifiDisplayPreferenceController(Context context, String key) {
super(context, key);
mRouter = context.getSystemService(MediaRouter.class);
}
@Override
public int getAvailabilityStatus() {
return WifiDisplaySettings.isAvailable(mContext) ? AVAILABLE : UNSUPPORTED_ON_DEVICE;
}
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = screen.findPreference(getPreferenceKey());
}
@Override
public CharSequence getSummary() {
CharSequence summary = mContext.getString(R.string.disconnected);
final int routeCount = mRouter.getRouteCount();
for (int i = 0; i < routeCount; i++) {
final MediaRouter.RouteInfo route = mRouter.getRouteAt(i);
if (route.matchesTypes(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY)
&& route.isSelected() && !route.isConnecting()) {
CharSequence status = route.getStatus();
if (!TextUtils.isEmpty(status)) {
summary = status;
} else {
summary = mContext.getString(R.string.wifi_display_status_connected);
}
break;
}
}
return summary;
}
@Override
public void onStart() {
mRouter.addCallback(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY, mRouterCallback);
}
@Override
public void onStop() {
mRouter.removeCallback(mRouterCallback);
}
}