Linda Tseng
f99fb5cf55
Merge "Add entry animation to Settings Panels." into qt-dev am: 71df263db9
...
am: 668055d8e5
2019-04-16 15:19:56 -07:00
Linda Tseng
668055d8e5
Merge "Add entry animation to Settings Panels." into qt-dev
...
am: 71df263db9
2019-04-16 13:51:55 -07:00
Lei Yu
a595b19f79
Merge "Disable Mobile settings in one condition." into qt-dev am: 421ca22a58
...
am: c53b29300a
2019-04-16 13:46:49 -07:00
Salvador Martinez
1a9366230e
Merge "Change dark theme screen to toggle" into qt-dev am: 3b8a0b82bf
...
am: 5e44955e57
2019-04-16 13:31:50 -07:00
Yi-Ling Chuang
3ae9c00186
Merge "Hide filter spinner when data is loading." into qt-dev am: 03c461b3ee
...
am: 95a850bc64
2019-04-16 13:22:55 -07:00
Fan Zhang
d0bcf2b452
Merge "Revert "Fix voice access issue on home page"" into qt-dev am: b298e2ae6c
...
am: ca374718ca
2019-04-16 12:55:11 -07:00
Sean Stout
710cc3f503
Merge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev am: 5a8b2cf1dc
...
am: 6760508e5e
2019-04-16 12:39:56 -07:00
Lei Yu
c53b29300a
Merge "Disable Mobile settings in one condition." into qt-dev
...
am: 421ca22a58
2019-04-16 12:24:50 -07:00
Salvador Martinez
5e44955e57
Merge "Change dark theme screen to toggle" into qt-dev
...
am: 3b8a0b82bf
2019-04-16 12:15:34 -07:00
Yi-Ling Chuang
95a850bc64
Merge "Hide filter spinner when data is loading." into qt-dev
...
am: 03c461b3ee
2019-04-16 12:07:59 -07:00
Fan Zhang
ca374718ca
Merge "Revert "Fix voice access issue on home page"" into qt-dev
...
am: b298e2ae6c
2019-04-16 11:59:52 -07:00
Linda Tseng
71df263db9
Merge "Add entry animation to Settings Panels." into qt-dev
2019-04-16 18:57:47 +00:00
Fan Zhang
d88b0be3da
Merge "Use android:attr for display font preview layout background" into qt-dev am: 75691d29ef
...
am: 9a5481d749
2019-04-16 11:29:35 -07:00
TreeHugger Robot
421ca22a58
Merge "Disable Mobile settings in one condition." into qt-dev
2019-04-16 18:20:11 +00:00
Sean Stout
6760508e5e
Merge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev
...
am: 5a8b2cf1dc
2019-04-16 11:19:11 -07:00
TreeHugger Robot
3b8a0b82bf
Merge "Change dark theme screen to toggle" into qt-dev
2019-04-16 18:16:54 +00:00
Yanting Yang
d264cd1f78
Merge "Clean up NotificationChannelSlice" into qt-dev am: 1fa45975eb
...
am: 18e0119391
2019-04-16 11:12:28 -07:00
TreeHugger Robot
03c461b3ee
Merge "Hide filter spinner when data is loading." into qt-dev
2019-04-16 18:07:24 +00:00
TreeHugger Robot
b298e2ae6c
Merge "Revert "Fix voice access issue on home page"" into qt-dev
2019-04-16 18:02:26 +00:00
Raff Tsai
26bc6a9137
Merge "Tint battery fix icon" into qt-dev am: 77c56714ed
...
am: fbab258c8b
2019-04-16 10:53:05 -07:00
Fan Zhang
9a5481d749
Merge "Use android:attr for display font preview layout background" into qt-dev
...
am: 75691d29ef
2019-04-16 10:48:48 -07:00
Sean Stout
5a8b2cf1dc
Merge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev
2019-04-16 17:47:29 +00:00
Yanting Yang
18e0119391
Merge "Clean up NotificationChannelSlice" into qt-dev
...
am: 1fa45975eb
2019-04-16 10:25:53 -07:00
Raff Tsai
fbab258c8b
Merge "Tint battery fix icon" into qt-dev
...
am: 77c56714ed
2019-04-16 10:13:51 -07:00
TreeHugger Robot
75691d29ef
Merge "Use android:attr for display font preview layout background" into qt-dev
2019-04-16 17:05:43 +00:00
TreeHugger Robot
1fa45975eb
Merge "Clean up NotificationChannelSlice" into qt-dev
2019-04-16 16:31:22 +00:00
Matthew Fritze
b6fdd25c23
Add entry animation to Settings Panels.
...
Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.
This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)
When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.
Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.
Hence, we decide to do the following:
If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.
If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.
In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.
When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out. Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.
The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.
Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159
Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
2019-04-16 16:29:04 +00:00
Fan Zhang
22f3944432
Revert "Fix voice access issue on home page"
...
This reverts commit 0f3049d4b7
2019-04-16 09:27:49 -07:00
TreeHugger Robot
77c56714ed
Merge "Tint battery fix icon" into qt-dev
2019-04-16 16:25:34 +00:00
Fan Zhang
4c0cf18c4d
Merge "Correct the state when prevent ringing page is launched." into qt-dev am: 957da73a7d
...
am: 7f7b9e7736
2019-04-16 08:45:18 -07:00
Fan Zhang
2be848029b
Merge "Update switchbar background color in disabled state." into qt-dev am: cae16fa07b
...
am: 60fd2efb96
2019-04-16 08:43:59 -07:00
Amin Shaikh
f1cf5a684f
Merge "Create TintDrawable in Settings." into qt-dev am: c4e7cf594c
...
am: 900d8c9e12
2019-04-16 08:38:38 -07:00
Fan Zhang
7f7b9e7736
Merge "Correct the state when prevent ringing page is launched." into qt-dev
...
am: 957da73a7d
2019-04-16 08:33:30 -07:00
Fan Zhang
60fd2efb96
Merge "Update switchbar background color in disabled state." into qt-dev
...
am: cae16fa07b
2019-04-16 08:32:38 -07:00
Amin Shaikh
900d8c9e12
Merge "Create TintDrawable in Settings." into qt-dev
...
am: c4e7cf594c
2019-04-16 08:28:24 -07:00
Fan Zhang
957da73a7d
Merge "Correct the state when prevent ringing page is launched." into qt-dev
2019-04-16 15:22:26 +00:00
Fan Zhang
cae16fa07b
Merge "Update switchbar background color in disabled state." into qt-dev
2019-04-16 15:19:25 +00:00
TreeHugger Robot
c4e7cf594c
Merge "Create TintDrawable in Settings." into qt-dev
2019-04-16 15:16:26 +00:00
Yanting Yang
ce3359f4d4
Clean up NotificationChannelSlice
...
- Remove unused variable.
- Change function interface.
Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632
2019-04-16 23:08:40 +08:00
Lei Yu
4ee2e00c18
Merge "Add remote volume slider conditionally." into qt-dev am: ee6825fd5b
...
am: 65628c28a9
2019-04-16 06:15:00 -07:00
Lei Yu
65628c28a9
Merge "Add remote volume slider conditionally." into qt-dev
...
am: ee6825fd5b
2019-04-16 05:58:13 -07:00
TreeHugger Robot
ee6825fd5b
Merge "Add remote volume slider conditionally." into qt-dev
2019-04-16 12:46:55 +00:00
Chandan Nath
1e89e94ad8
Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev am: 2ec2c6330e
...
am: 552c951808
2019-04-16 04:51:48 -07:00
Chandan Nath
552c951808
Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev
...
am: 2ec2c6330e
2019-04-16 04:41:54 -07:00
Chandan Nath
2ec2c6330e
Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev
2019-04-16 11:21:10 +00:00
Raff Tsai
006582b48e
Tint battery fix icon
...
Fixes: 129492004
Test: manual
Change-Id: I161284619bc47e342d78f1507ae291f7c23ad3ff
2019-04-16 17:05:52 +08:00
Yi-Ling Chuang
9a7ead8962
Hide filter spinner when data is loading.
...
When the filter spinner is initialized, set GONE to its visibility.
Only make it visible after network cycle data finishes loading to
avoid presenting an empty filter spinner.
Fixes: 130397929
Test: robotests
Change-Id: I740fdad35ec82bc0be386c24e53348917bf6bfba
2019-04-16 16:53:32 +08:00
Antony Sargent
70c15513d0
Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev am: 01b633275a
...
am: eb16066b90
2019-04-16 01:44:44 -07:00
Antony Sargent
eb16066b90
Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev
...
am: 01b633275a
2019-04-16 01:40:47 -07:00
TreeHugger Robot
01b633275a
Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev
2019-04-16 08:30:30 +00:00
