Commit Graph

50529 Commits

Author SHA1 Message Date
Lucas Lin
f32823bc6d Merge "Modify dialog message for partial connectivity" 2019-03-21 02:34:03 +00:00
Yanting Yang
e2914e0845 Merge "Improve notification slice string on home page" 2019-03-21 02:04:22 +00:00
Clown SHEN
f5d2552b7a Merge "Add new string for toast to notify user Wi-Fi not in range" 2019-03-21 00:43:37 +00:00
TreeHugger Robot
9bbff3da37 Merge "Update system dashboard pref summary" 2019-03-21 00:21:24 +00:00
Lei Yu
24c3c577c8 Merge "Don't close db for singleton db manager" 2019-03-20 22:15:56 +00:00
Fan Zhang
0eca452b17 Update system dashboard pref summary
Fixes: 127350259
Test: visual
Change-Id: I4e7ff67af6df94d6a030096156f6485f375e8a2e
2019-03-20 13:29:41 -07:00
TreeHugger Robot
a2ef6e5c33 Merge "Pass the location permission not group to MANAGE_APP_PERMISSION." 2019-03-20 19:03:31 +00:00
TreeHugger Robot
c48cdcd5f9 Merge "Make BT icon colorful" 2019-03-20 18:51:28 +00:00
jackqdyulei
da7b0d44bc Don't close db for singleton db manager
To fix db bug and application will close it finally.

Bug: 128924561
Test: Build
Change-Id: I172882825612f1d317ae4b634bc4d5899338bed8
2019-03-20 11:02:04 -07:00
TreeHugger Robot
7d7eb8b509 Merge "Fix NPE in constructor" 2019-03-20 17:06:17 +00:00
Joel Galenson
73f089333b Pass the location permission not group to MANAGE_APP_PERMISSION.
I changed the API to support passing in a permission.

Test: Click on entry and open its permission toggle screen.
Test: atest RecentLocationAccessPreferenceControllerTest
Change-Id: I0f789c9e2a05f4b5b03efab6a7dcdb218e565b52
2019-03-20 09:32:50 -07:00
Matthew Fritze
e435b062a0 Fix NPE in constructor
Move getActivity() call and fetching of metrics feature provider into
onCreateView rathre than the Constructor of the fragment (where Activity
is not yet created).

Test: manual
Test: existing robotests
Fixes: 128808444
Change-Id: I88586b0ca3ebda60f8933041322541cc5911de68
2019-03-20 08:29:23 -07:00
Yanting Yang
aed7ad5a43 Improve notification slice string on home page
Add ContextualNotificationChannelSlice to show more clear sub title on
notification slice.

Fixes: 128641319
Test: visual, robotests
Change-Id: I650102f4cde7d8d397c7a501ba9ee76c401ba9db
2019-03-20 22:25:59 +08:00
clownshen
a9aa6d1821 Add new string for toast to notify user Wi-Fi not in range
Bug: 126503889
Test: build passed
Change-Id: Ide2d733d72c2b31fcaa302d0ddb742b92fac6d7e
2019-03-20 07:12:32 +00:00
Kevin Chyn
cd829aced1 Merge "Show confirmation dialog for removing enrollment" 2019-03-20 07:01:52 +00:00
TreeHugger Robot
08d9835b8e Merge "Update About phone icon background color" 2019-03-20 06:51:25 +00:00
TreeHugger Robot
1029b976f4 Merge "Update enrollment intro" 2019-03-20 06:28:33 +00:00
Yanting Yang
522b634f98 Update About phone icon background color
Fixes:120810263
Test: visual
Change-Id: I8b91a0ef7ba66ff0f4fbd84c765119266119a4a6
2019-03-20 12:52:18 +08:00
Cosmo Hsieh
64df6a3073 Merge "[Network Connection] Implement new UI changing" 2019-03-20 04:34:25 +00:00
Kevin Chyn
e00f7e029f Show confirmation dialog for removing enrollment
Fixes: 123605413
Test: builds

Change-Id: I9e918977909bcf461a29eb36f157c3a261c6dcc4
2019-03-19 21:22:15 -07:00
TreeHugger Robot
cee1ddc5ac Merge "Fix sticky battery saver toggle" 2019-03-20 04:20:21 +00:00
TreeHugger Robot
88dd31287c Merge "Store the application context statically in FeatureFactory" 2019-03-20 04:09:31 +00:00
TreeHugger Robot
85c5d73145 Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment" 2019-03-20 04:07:02 +00:00
lucaslin
7335c594be Modify dialog message for partial connectivity
In some networks, network validation may only get success
result for http probe but fail result for https probe.
For this kind of network, it may still work at some websites
or apps, but user didn't know about that. In order to fix this
issue, we will check if network has partial connectivity and
notify user to make a choice if they want to use this partial
connectivity or not.

Bug: 113450764
Bug: 128489091
Test: 1. Build pass.
      2. make -j44 RunSettingsRoboTests
      ROBOTEST_FILTER=WifiDetailPreferenceControllerTest
      3. Change captive_portal_https_url to https://invalid.com
      to simulate partial connectivity.

Change-Id: I0e87f6f2ede173f45a7b6fcf842b4f9a83d8efa1
2019-03-20 11:41:21 +08:00
Kevin Chyn
f25830b9cc Update enrollment intro
1) Toggles resources between normal and accessibility enrollment
2) Add footer for more detail text

Fixes: 127514618
Bug: 111548033

Test: Builds

Change-Id: Ib0c47f04abc5ce9abbd8b27ef5782d1874379f16
2019-03-19 19:19:23 -07:00
Arc Wang
d0ceb83c95 Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.

Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.

Bug: 124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
2019-03-20 10:06:40 +08:00
Arc Wang
e4359a9eee Merge "Fix Wi-Fi Easy Connect buttons UI defects" 2019-03-20 01:53:24 +00:00
Fan Zhang
e230d19810 Merge "Make a public activity for zen access details." 2019-03-19 23:52:17 +00:00
Fan Zhang
e366f02712 Make a public activity for zen access details.
Bug: 128547723
Test: manual
Change-Id: I0546cbb37c2be50bff44396fa2874d9eb294813c
2019-03-19 23:52:06 +00:00
Fan Zhang
b24514189a Store the application context statically in FeatureFactory
It stores the application context in a static class, and will be
destoryed when application stops.

Bug: 124701288
Test: robo
Change-Id: I4678072f3f38ae682be6ba075c85e63c49f8febe
2019-03-19 16:07:25 -07:00
TreeHugger Robot
6ce76c0035 Merge "Sound + Output Switcher on Volume Slice" 2019-03-19 22:49:04 +00:00
TreeHugger Robot
df31ff0ef3 Merge "Enlarge the height of collapsing button" 2019-03-19 22:36:30 +00:00
Salvador Martinez
cbd35ab0d5 Fix sticky battery saver toggle
It was persisting to settings secure instead of settings global.

Test: robotests pass
Bug: 128929858
Change-Id: I8c5bcc875d71096e70f1a70ec84e85d46c3abe43
2019-03-19 15:20:51 -07:00
Yohei Yukawa
2f8e02fdbe Finalize text of per-profile IME settings
This is a follow up CL to a recent CL [1], which updated text in the
Settings app as follows:
 * "Keyboard & inputs" to "Keyboards"
 * "Input assistance" to "Tools"

For consystency, this CL updates the header text for the work-profile
specific enties in Languages & input from
  Work profile input & assistance
to
  Work profile keyboards & tools.

Other than that, there is no user-visible behavior change.

 [1]: Idbf1e3a8b0c7116271e424548ef37340199eaea2
      5b27d18e38

Bug: 124049901
Fix: 123314089
Test: Manually verified as follows.
  1. Build and flash an AOSP build
  2. Install Test DPC
  3. Open Settings -> System -> Languages & input
  4. Make sure that the new category header for work-profile specific
     entries is now shown as "Work profile keyboards & tools"
Change-Id: Ib6470debe9be29ec0985cf1e3eb31d232c6b3880
2019-03-19 14:15:37 -07:00
Mill Chen
8ac550c912 Merge "Add Grayscale conditional" 2019-03-19 20:47:56 +00:00
Mill Chen
12f9b2a73b Enlarge the height of collapsing button
To improve the accessibility of Settings, we make the height of
collapsing button set to 48dp.

Fixes: 128896511
Test: rebuild
Change-Id: I341196802d6d488a8adb88501901e761bc188f7b
2019-03-19 13:17:09 -07:00
jackqdyulei
7fb5e75752 Make BT icon colorful
Add new method to get rainbow bt icon and also refactor
AdaptiveHomepageIcon:
1. Rename
2. Add ConstantState

Bug: 126425211
Test: RunSettingsRoboTests

Change-Id: Idb8aaf253d0d9e2ab33d8852f093e6689ebadde4
2019-03-19 12:22:38 -07:00
TreeHugger Robot
cd9ef2abbd Merge "Remove wake from Settings gestures.xml" 2019-03-19 18:20:38 +00:00
Lei Yu
e87fe284b6 Merge "Add circle background outline to unthethered icon" 2019-03-19 17:46:17 +00:00
Clown SHEN
9187906493 Merge "Display more information on network detail page" 2019-03-19 17:37:26 +00:00
Fan Zhang
83f85b0a1f Merge "Stop using framework internal layout for timezone header." 2019-03-19 17:18:42 +00:00
Fan Zhang
5d2e0fc10f Stop using framework internal layout for timezone header.
The framework version header has deviated from supportlib version long
ago, and we shouldn't hack our theme to make this layout work. Instead
we now have a custom layout compatible to settings theme.

Fixes: 128833223
Test: visual
Change-Id: I83087352240de183b0639daf844bd7f90e02056a
2019-03-19 10:17:46 -07:00
Fan Zhang
3099c47904 Merge "Update strings of notification channel slice" 2019-03-19 17:14:56 +00:00
Fan Zhang
01bb0f9bcb Merge "Create a page to manage dnd permission for individual app" 2019-03-19 17:14:07 +00:00
Beverly
19f8d244e6 Remove wake from Settings gestures.xml
Test: manual
Bug: 127955764
Change-Id: Icea129fe5a7b1dbb0bc5ff799c99907a278396df
2019-03-19 10:56:07 -04:00
TreeHugger Robot
f5e2bfee28 Merge "Log latency and timeout occurrence for contextual cards." 2019-03-19 13:25:25 +00:00
Yanting Yang
d3ae430150 Update strings of notification channel slice
Bug:128641319
Test: manual
Change-Id: Ia5f5ee770a28c0720526e60ffdb48fb2bd3de13f
2019-03-19 19:56:17 +08:00
TreeHugger Robot
dc7683b3a4 Merge "Update OWNERS for backup settings" 2019-03-19 11:48:40 +00:00
Yi-Ling Chuang
620d6aeccb Log latency and timeout occurrence for contextual cards.
Fixes: 124492762
Test: rebuild
Change-Id: I552adf7e6d76e8576a790e83792d067ed5716dc2
2019-03-19 18:31:01 +08:00
Arc Wang
baf002d61a Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
   ButtonPreference's naming and design look like a general purpose UI
   component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
   'preference_access_point' to fix UI alignment problems.

Bug: 126964552
Bug: 125434239
Bug: 126762937

Test: manual test
      atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
2019-03-19 16:27:04 +08:00