Commit Graph

145881 Commits

Author SHA1 Message Date
Rex Hoffman
b47f76cb7c Merge "Removing Dead Flag Test: CI Bug: 386652866" into main am: ccf197b366 am: 9b18787489
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3434134

Change-Id: I93f2d70019643bb3b1b2d28a9dcf9108e9468ce0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 12:55:43 -08:00
Menghan Li
4cbdc3f598 fix(ReduceBrightColorsPreferenceController) Different feature configs
This change updates the tests for ReduceBrightColorsPreferenceController
to account for different combinations of feature flags and
configurations, specifically related to the "Even Dimmer" flag and the
availability of Reduce Bright Colors.

The updated tests ensure that the preference controller correctly
determines its availability based on these factors, improving test
coverage and reliability. This addresses inconsistencies between the
code and test cases, ensuring accurate behavior across various device
configurations.

Bug: 387071233
Test: atest ReduceBrightColorsPreferenceControllerTest
Flag: com.android.server.display.feature.flags.even_dimmer
Change-Id: Ie565ce996c7d4f49e194b119b32bf01a6508393e
2025-01-08 20:47:14 +00:00
Rex Hoffman
9b18787489 Merge "Removing Dead Flag Test: CI Bug: 386652866" into main am: ccf197b366
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3434134

Change-Id: Ic4e6ff898dd4811bb41dd0b71a7d78b9b50fe1ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 12:31:12 -08:00
Rex Hoffman
ccf197b366 Merge "Removing Dead Flag Test: CI Bug: 386652866" into main 2025-01-08 12:17:27 -08:00
Lucas Silva
9c4dba40b4 Add posturing dream trigger to Settings UI
Adds ability for users to select posturing as the trigger for when
dreams will be shown.

Bug: 383208131
Test: locally - mp droid and verified posturing option is displayed in
Settings
Flag: android.service.dreams.allow_dream_when_postured

Change-Id: Iae69b9e488181b1e2af7474e3e9879a92b51274c
2025-01-08 14:59:58 -05:00
Weng Su
cd9af665c3 [Catalyst] Add back Wi-Fi switch metrics
- The original Wi-Fi switch metrics is recorded by WifiEnabler.

- Since the design of Catalyst removes WifiEnabler, the metrics needs to be added to Catalyst preference.

NO_IFTTT=Catalyst only

Bug: 388547699
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiSwitchPreferenceTest

Change-Id: I8819e8f660784b8b04c7958b65f4792b5d4d0919
2025-01-09 03:37:06 +08:00
Treehugger Robot
be203ea17d Merge "Fix NPE on modes page when schedule has no days" into main 2025-01-08 11:17:09 -08:00
Matías Hernández
5098df9b6c Fix NPE on modes page when schedule has no days
Fixes: 387088843
Test: atest ZenModeTriggerUpdatePreferenceControllerTest
Flag: EXEMPT trivial bugfix
Change-Id: I3b845784f5923521d7f3f6cae9d6d27a21f55361
2025-01-08 19:14:40 +01:00
Jiaming Liu
f4be314b3f Merge "[AE] Enable AE Split for phones supporting display port" into main 2025-01-08 09:20:08 -08:00
Jason Chang
3e1e855094 Update Fingerprint adding button with expressive design
Flag: EXEMPT flag by System prop (SettingsThemeHelper.isExpressiveTheme)

Bug: 388260897

Test: build and manually check the UI and its behaviors.
Change-Id: I1c6d859f78305d0f14476e12a5bb4e1b0258d06e
2025-01-08 17:03:14 +00:00
Harry Cutts
fb0b459cf0 Touchpad: add @NonNull annotations to controller constructors
...and to some of the preference controller base classes, too, since I
had to work those out anyway.

Bug: 245989146
Test: m
Flag: EXEMPT unable to flag this kind of change
Change-Id: I32ba2b6b8c05c1379b4d921350050979b1866805
2025-01-08 16:36:43 +00:00
Harry Cutts
0e4edf9527 Touchpad: mark MetricsFeatureProviders final
(Fixing some warnings from Android Studio)

Bug: 245989146
Test: m
Flag: EXEMPT refactor
Change-Id: I3f473d281e8a22d108a52e56e6e53ca056e4a829
2025-01-08 16:33:35 +00:00
Harry Cutts
cc30711d59 Merge "Touchpad: replace references to "trackpad" with "touchpad"" into main 2025-01-08 07:39:51 -08:00
Treehugger Robot
e28dcd02bc Merge "Fix sim status details not updated after sim hotswap" into main am: e9bc1949a9 am: 066efe6c55
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3431560

Change-Id: I176e94c9f718a14d5e4593471fadb1b1ef186dba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 04:21:29 -08:00
Harry Cutts
ae3e005ff9 Touchpad: fix some NullAway warnings
Change I930e9fc85e09e03da3513e5f8443077fa8ea91b0 triggered some NullAway
warnings that are unrelated to the change, but some are trivial to fix,
for example by replacing member variables with local ones.

At the same time, add some `@NonNull` annotations to overriding methods
on Android Studio's recommendation.

Test: check touchpad gesture tutorial and pointer speed settings work
Test: $ atest SettingsRoboTests:com.android.settings.inputmethod
Bug: 245989146
Flag: EXEMPT refactor
Change-Id: I717eb2a2d68a46dce8ebaa95bef1183d09380f51
2025-01-08 11:53:14 +00:00
Harry Cutts
509fd17515 Touchpad: replace references to "trackpad" with "touchpad"
When we first added the touchpad settings we hadn't settled on whether
to refer to them as "touchpads" or "trackpads" yet. We've since settled
on "touchpad", but that's left us with some Settings code referring to
one and some to the other. Let's standardize on "touchpad" since that's
consistent with user-facing strings and the rest of the input codebase.

This CL doesn't change string identifiers, as I believe that would cause
them to get different Translation Console IDs and thus be retranslated.

Bug: 245989146
Test: m
Test: check strings and icons are still displayed correctly in the
      touchpad settings and tutorial, and that settings toggles and the
      tutorial still work
Test: atest SettingsRoboTests
Flag: EXEMPT refactor
Change-Id: I930e9fc85e09e03da3513e5f8443077fa8ea91b0
2025-01-08 11:52:45 +00:00
Treehugger Robot
066efe6c55 Merge "Fix sim status details not updated after sim hotswap" into main am: e9bc1949a9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3431560

Change-Id: I7cdc3dfb7051d2c5fdae20deb8617c09620284cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 03:44:52 -08:00
Treehugger Robot
e9bc1949a9 Merge "Fix sim status details not updated after sim hotswap" into main 2025-01-08 03:15:55 -08:00
Treehugger Robot
32f8eff7a9 Merge "Add notifications toggle to Settings > Date and Time" into main 2025-01-08 02:01:34 -08:00
Haijie Hong
fd4c6d100d Merge "Add audio sharing entrypoint in device details" into main 2025-01-07 22:32:29 -08:00
YK Hung
172245983c Merge "Create UI lifecycle aware executor factory." into main 2025-01-07 21:45:18 -08:00
Treehugger Robot
457e700ec4 Merge "Check the permission of the callingUid instead of the calling package" into main 2025-01-07 21:09:14 -08:00
Haijie Hong
cdcf50e3d2 Add audio sharing entrypoint in device details
BUG: 383935069
Test: local tested
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ib90422d262eba84c3a308d8e4c5652d8c5f96808
2025-01-08 13:03:12 +08:00
Zaiyue Xue
ecb9bccc46 Create UI lifecycle aware executor factory.
The executor factory can bind with an UI page life cycle and could
auto-shutdown when the onStop().

Bug: 384795117
Test: manual
Flag: EXEMPT bug fix
Change-Id: Ibd2538fa2def86b08d3874a44f23ae2450483a6e
2025-01-08 11:58:17 +08:00
hoffc
39d16d7bfb Fix sim status details not updated after sim hotswap
Telephony callback may be removed in onPause during sim hotswap, but they are not re-registered in onResume for sub info still null.

Listen sub info change and re-register telephony callback when need.

Test: function test pass and SimStatusDialogControllerTest unit test pass.

Change-Id: I17e60c9e3441fc593107048494f830408c37ae61
Bug: 384643359
2025-01-08 11:53:26 +08:00
Alyssa Ketpreechasawat
f480cdd56f Remove ModuleInfo#isHidden Usage from the source code.
ModuleInfo#isHidden is used for getting hidden module status from
ModuleMetadata package (Mainline). It was set to hide Mainline modules'
Apk to show in the Settings UI and this has caused the issue as it
disallowed the user to toggle permissions where it was needed. Thus, we
decided to deprecate the usage of ModuleInfo#isHidden (see
go/aml-hidden-modules-permissions).

Bug: 379056868
Test: unittest
Test: check behavior before/after enable flags
Flag: android.content.pm.remove_hidden_module_usage
Change-Id: I670c95350e3c21db9f74f37b675aba1b23c67a61
2025-01-07 19:39:31 -08:00
Jacky Wang
35087de733 [Catalyst] Clean up GetPreferenceGraphRequest.includeValue
Bug: 332201912
Flag: com.android.settingslib.flags.settings_catalyst
Test: N/A
Change-Id: I069fd48aa4522abaeae6df4f0550f988c1ce85b6
2025-01-08 10:06:33 +08:00
Wenyu Zhang
83046e7ff9 Merge "a11y: Plumb autoclick cursor area size settings to PrefController" into main 2025-01-07 17:39:23 -08:00
Wenyu Zhang
6052ab619f a11y: Plumb autoclick cursor area size settings to PrefController
Screen recording: http://go/scrcast/NTk0ODczOTE4MDAzNjA5Nnw0ZGNhMzVmYS0wYg

Bug: b/383901288
Test: ToggleAutoclickCursorAreaSizeControllerTest
Change-Id: I745ef71d035d379e06a747f085ef9b0fef60d968
Flag: com.android.server.accessibility.enable_autoclick_indicator
2025-01-07 23:37:39 +00:00
Rex Hoffman
f4290c1d03 Removing Dead Flag
Test: CI
Bug: 386652866

Change-Id: Ib8a48063738f6362342957b39451a7c352a9a9d5
2025-01-07 14:01:21 -08:00
Lorenzo Lucena Maguire
fbf2a46140 Merge "Support Double Tap Power to open camera via config resource" into main 2025-01-07 12:06:03 -08:00
Wenyu Zhang
9ed3b4fb77 Merge "a11y: Fix Android Lint" into main 2025-01-07 10:26:39 -08:00
Johannes Gallmann
ed8348e161 Merge "Clean up predictive_back_system_anims flag" into main 2025-01-07 08:32:25 -08:00
Kasia Krejszeff
4c9ced02b6 Merge "Remove nested ScrollView in the PrivateSpaceEducation screen." into main 2025-01-07 08:10:34 -08:00
Wenyu Zhang
6e89c83c9d a11y: Fix Android Lint
Add NonNull annotation. Fix Android Lint in http://ag/31174874.

Bug: b/383901288
Change-Id: Ibe296525ebdc298b3b23b8df51bd58218e20b777
Test: ToggleAutoclickCursorAreaSizeControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
2025-01-07 07:27:46 -08:00
Kasia Krejszeff
e0036fc8b2 Remove nested ScrollView in the PrivateSpaceEducation screen.
It is not needed for the scrolling to work -- GlifLayout from the SUW
library generates a ScrollView. Additional ScrollView causes Talkback to
interpret it as a separate item and read out contents of its all
children. See b/379256039.

Video before: https://drive.google.com/file/d/1H3k5AxlIdgAA15PHUQ9tVq5AechziA4Z/view?usp=sharing&resourcekey=0-ozeQsQSS5jubL0pZ5FAZHA
Video after: https://drive.google.com/file/d/1W_ODgQhbQS6Xf_57A4TcYeJbqMJxYF16/view?usp=sharing&resourcekey=0-zQ0_p3qlIxpBL3rB5SC4vQ

In the before video, talkback is highlighting and (the green frames) and reading out the whole "How it works" section in addition to each element separately. After the fix it only highlights elements separately.

Bug: 379256039
Test: Manually testesd and presubmit.
Flag: EXEMPT bugfix
Change-Id: Idf6772b8772c54c1907d3a12617fcd03451af41b
2025-01-07 14:52:20 +00:00
Alex Stetson
5a594828d7 Allow system services to be optional
Some Android systems may not have certain system services (particularly the VirtualMachineManager). If this is the case, disable the preference rather than requiring the service and crashing the Settings app.

Bug: 388221800
Change-Id: I761054caebe3e846f5c6c76e2818662aad2cb511
Test: manual
Flag: NONE bugfix
2025-01-07 06:42:39 -08:00
Zoey Chen
5f63dd0fdb [Settings] Refactor: Add App language layout
Bug: 388199937
Test: manual
Flag: EXEMPT refactor
Change-Id: I4062bfe0e882a40fb55fbf0b2164b558fe83328b
2025-01-07 03:18:49 -08:00
Shaowei Shen
d44314f253 Merge "[Touchpad and Mouse] Sync strings and prefs" into main 2025-01-07 01:57:29 -08:00
Shaowei Shen
4166f1b7bd Merge "[Physical Keyboard] Add Metrics event for keyboard relates pages" into main 2025-01-07 01:42:25 -08:00
Yuri Ufimtsev
5716bd85f9 Merge "Allow to open Content Protection settings externally" into main 2025-01-07 00:58:53 -08:00
Ze Li
60e13c7928 Merge "[Temp bonding] Hide rename button from device details page for temp bond device" into main 2025-01-07 00:49:02 -08:00
Angela Wang
a6c383eced Remove flag enable_hearing_aid_preset_control
Flag: EXEMPT remove flag
Bug: 388175226
Test: atest BluetoothDetailsHearingDeviceControllerTest
Change-Id: I97b633f32794feb86e5a940448270ed74ed26387
2025-01-07 08:45:14 +00:00
shaoweishen
929056c377 [Touchpad and Mouse] Sync strings and prefs
Sync texts and preferences arrangement in
Touchpad and Mouse related pages.

Bug: 377602364
Test: atest SettingsRoboTests
Flag: com.android.settings.keyboard.keyboard_and_touchpad_a11y_new_page_enabled
Change-Id: I64179cc1a6ab1080160923c2d7d861537991ef97
2025-01-07 08:35:46 +00:00
Treehugger Robot
4371fa05ed Merge "[Thread] update the link for "Learn More about Thread"" into main am: b2a5ee5b76 am: 64eec09358
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3438420

Change-Id: I7993fb4a6cf4f3b8b76276595a87d2e5a981adae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-06 23:37:02 -08:00
Treehugger Robot
64eec09358 Merge "[Thread] update the link for "Learn More about Thread"" into main am: b2a5ee5b76
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3438420

Change-Id: Ie7c1fe6415a528acff18a1130e0b53b5f337ffb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-06 23:12:39 -08:00
Ze Li
205c81ed3a [Temp bonding] Hide rename button from device details page for temp bond device
Test: com.android.settings.bluetooth.AdvancedBluetoothDetailsHeaderControllerTest
Bug: 362859132
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Change-Id: I22d54c322029c606425c8f48b091ad1b53e100de
2025-01-07 15:00:32 +08:00
Treehugger Robot
b2a5ee5b76 Merge "[Thread] update the link for "Learn More about Thread"" into main 2025-01-06 22:42:26 -08:00
Kangping Dong
cc22175481 [Thread] update the link for "Learn More about Thread"
The latest link to the help center doc is finalized in b/387356147

Bug: 387356147
Change-Id: Ia3caf2dc78b4cd41d9d046cb072268ac63cdd65e
2025-01-07 13:35:44 +08:00
Chelsea Hao
0f6baa17c2 Merge "Fix play/pause button." into main 2025-01-06 21:24:15 -08:00