PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Touchpad: add @NonNull annotations to controller constructors

Browse Source 
...and to some of the preference controller base classes, too, since I
had to work those out anyway.

Bug: 245989146
Test: m
Flag: EXEMPT unable to flag this kind of change
Change-Id: I32ba2b6b8c05c1379b4d921350050979b1866805
This commit is contained in:
Harry Cutts
2025-01-08 16:11:47 +00:00
parent 0e4edf9527
commit fb0b459cf0
10 changed files with 30 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/core/BasePreferenceController.java
View File

@@ -29,6 +29,7 @@ import android.provider.SettingsSlicesContract;
import android.text.TextUtils;
import android.util.Log;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.preference.Preference;
import androidx.preference.PreferenceScreen;
@@ -194,7 +195,7 @@ public abstract class BasePreferenceController extends AbstractPreferenceControl
}
}
public BasePreferenceController(Context context, String preferenceKey) {
public BasePreferenceController(@NonNull Context context, @NonNull String preferenceKey) {
super(context);
mPreferenceKey = preferenceKey;
mPrefVisibility = true;

3
src/com/android/settings/core/SliderPreferenceController.java
View File

@@ -16,6 +16,7 @@ package com.android.settings.core;
import android.content.Context;
import androidx.annotation.NonNull;
import androidx.preference.Preference;
import androidx.slice.builders.SliceAction;
@@ -24,7 +25,7 @@ import com.android.settings.slices.SliceData;
public abstract class SliderPreferenceController extends BasePreferenceController implements
Preference.OnPreferenceChangeListener {
public SliderPreferenceController(Context context, String preferenceKey) {
public SliderPreferenceController(@NonNull Context context, @NonNull String preferenceKey) {
super(context, preferenceKey);
}

5
src/com/android/settings/core/TogglePreferenceController.java
View File

@@ -15,13 +15,14 @@ package com.android.settings.core;
import android.content.Context;
import androidx.annotation.NonNull;
import androidx.preference.Preference;
import androidx.preference.PreferenceScreen;
import androidx.preference.TwoStatePreference;
import com.android.settings.onboarding.OnboardingFeatureProvider;
import com.android.settings.overlay.FeatureFactory;
import com.android.settings.slices.SliceData;
import com.android.settings.onboarding.OnboardingFeatureProvider;
import com.android.settings.widget.TwoStateButtonPreference;
import com.android.settingslib.PrimarySwitchPreference;
import com.android.settingslib.core.instrumentation.SettingsJankMonitor;
@@ -37,7 +38,7 @@ public abstract class TogglePreferenceController extends BasePreferenceControlle
private static final String TAG = "TogglePrefController";
public TogglePreferenceController(Context context, String preferenceKey) {
public TogglePreferenceController(@NonNull Context context, @NonNull String preferenceKey) {
super(context, preferenceKey);
}

5
src/com/android/settings/inputmethod/TouchpadGesturesDisabledFooterPreferenceController.java
View File

@@ -19,11 +19,14 @@ package com.android.settings.inputmethod;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import com.android.settings.core.BasePreferenceController;
public class TouchpadGesturesDisabledFooterPreferenceController extends BasePreferenceController {
public TouchpadGesturesDisabledFooterPreferenceController(Context context, String key) {
public TouchpadGesturesDisabledFooterPreferenceController(@NonNull Context context,
@NonNull String key) {
super(context, key);
}

4
src/com/android/settings/inputmethod/TouchpadGesturesTutorialButtonPreferenceController.java
View File

@@ -24,6 +24,7 @@ import android.content.Intent;
import android.hardware.input.InputSettings;
import android.os.UserHandle;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.fragment.app.Fragment;
import androidx.preference.PreferenceScreen;
@@ -44,7 +45,8 @@ public class TouchpadGesturesTutorialButtonPreferenceController extends BasePref
private @Nullable Fragment mParent;
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadGesturesTutorialButtonPreferenceController(Context context, String key) {
public TouchpadGesturesTutorialButtonPreferenceController(@NonNull Context context,
@NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}

3
src/com/android/settings/inputmethod/TouchpadPointerSpeedPreferenceController.java
View File

@@ -20,6 +20,7 @@ import android.app.settings.SettingsEnums;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import androidx.preference.PreferenceScreen;
import com.android.settings.core.SliderPreferenceController;
@@ -31,7 +32,7 @@ public class TouchpadPointerSpeedPreferenceController extends SliderPreferenceCo
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadPointerSpeedPreferenceController(Context context, String key) {
public TouchpadPointerSpeedPreferenceController(@NonNull Context context, @NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}

5
src/com/android/settings/inputmethod/TouchpadReverseScrollingPreferenceController.java
View File

@@ -20,6 +20,8 @@ import android.app.settings.SettingsEnums;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController;
import com.android.settings.overlay.FeatureFactory;
@@ -29,7 +31,8 @@ public class TouchpadReverseScrollingPreferenceController extends TogglePreferen
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadReverseScrollingPreferenceController(Context context, String key) {
public TouchpadReverseScrollingPreferenceController(@NonNull Context context,
@NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}

5
src/com/android/settings/inputmethod/TouchpadRightClickZonePreferenceController.java
View File

@@ -20,6 +20,8 @@ import android.app.settings.SettingsEnums;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController;
import com.android.settings.overlay.FeatureFactory;
@@ -29,7 +31,8 @@ public class TouchpadRightClickZonePreferenceController extends TogglePreference
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadRightClickZonePreferenceController(Context context, String key) {
public TouchpadRightClickZonePreferenceController(@NonNull Context context,
@NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}

4
src/com/android/settings/inputmethod/TouchpadTapDraggingPreferenceController.java
View File

@@ -20,6 +20,8 @@ import android.app.settings.SettingsEnums;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController;
import com.android.settings.overlay.FeatureFactory;
@@ -29,7 +31,7 @@ public class TouchpadTapDraggingPreferenceController extends TogglePreferenceCon
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadTapDraggingPreferenceController(Context context, String key) {
public TouchpadTapDraggingPreferenceController(@NonNull Context context, @NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}

4
src/com/android/settings/inputmethod/TouchpadTapToClickPreferenceController.java
View File

@@ -20,6 +20,8 @@ import android.app.settings.SettingsEnums;
import android.content.Context;
import android.hardware.input.InputSettings;
import androidx.annotation.NonNull;
import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController;
import com.android.settings.overlay.FeatureFactory;
@@ -29,7 +31,7 @@ public class TouchpadTapToClickPreferenceController extends TogglePreferenceCont
private final MetricsFeatureProvider mMetricsFeatureProvider;
public TouchpadTapToClickPreferenceController(Context context, String key) {
public TouchpadTapToClickPreferenceController(@NonNull Context context, @NonNull String key) {
super(context, key);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
}