Commit Graph

42484 Commits

Author SHA1 Message Date
Doris Ling
e679e9b1b4 Fixes crash from selecting uninstalled app info from recents.
- when the package is uninstalled, also remove it from the recent tasks
- move retrieveAppEntry() from onCreate() to getPreferenceControllers()
so that if the package info is invalid, do not create any controllers,
as the activity will be finished anyway.

Change-Id: Ibbfa16e3d1f941a0a200e78ec73a06ca8511f82b
Fixes: 72656345
Test: make RunSettingsRoboTests
2018-02-01 14:37:25 -08:00
TreeHugger Robot
b832f737c3 Merge "Remove suggestion UI v1 codes." 2018-01-31 21:15:18 +00:00
Fan Zhang
74731f9fa6 Merge "Misc fixes for account/users fragments" 2018-01-31 21:13:31 +00:00
TreeHugger Robot
295a55b2fd Merge "AR/FR: Keyboard challenge takes precedence." 2018-01-31 19:42:03 +00:00
Doris Ling
a5d0c3e36e Remove suggestion UI v1 codes.
- remove the check for feature flag for suggestion UI v2 and switch to
use the v2 codes.
- remove all code related to v1 of suggestion UI

Fixes: 70573674
Test: make RunSettingsRoboTests

Change-Id: I99ab318c1c0192508a9c5e9e708e86319120d55b
2018-01-31 10:59:40 -08:00
Fan Zhang
dc2a3528d5 Misc fixes for account/users fragments
- Hide add user button when it's not functional
- Display "No accounts added" under accounts setting when there is no account.

Change-Id: Iefede9939d206eb3064fa22bdcfbcb1e826f29ab
Fixes: 72643060
Test: robotest
Test: 72713118
2018-01-31 10:55:40 -08:00
Julia Reynolds
07c2cdee1f Merge "Notification settings updates" 2018-01-31 17:09:51 +00:00
TreeHugger Robot
54e304b897 Merge "Fix homepage icon margin" 2018-01-31 03:18:29 +00:00
Carlos Valdivia
4b34dad4cd AR/FR: Keyboard challenge takes precedence.
Tested manually by:
(1) Setting up a gmail account.
(2) Setting up a screen pattern.
(3) Going to Settings > System > Reset Options > Factory Wipe
(4) Hit the Erase button.
(5) Enter pattern into the Screenlock prompt.
(6) Notice the Google credential confirmation screen.

Prior to this change we would skip (5) if there was a Google account on
the device.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=andorid.settings.MasterClear
Bug: 72694056

Change-Id: Ie07c678ecbc8361e8e1792f82efdfb1261db49fb
2018-01-30 18:39:45 -08:00
TreeHugger Robot
ac1fc5c9b7 Merge "Re-add isSuggestionEnabled check" 2018-01-31 01:11:52 +00:00
Fan Zhang
d186874b35 Fix homepage icon margin
Change-Id: Ie9a7be625bb51336ef4eda05d24c61ec9cc264e8
Fixes: 69314641
Test: visual
2018-01-30 15:54:48 -08:00
Fan Zhang
0ec6b02fe4 Re-add isSuggestionEnabled check
It was accidentally removed previously

Test: robotest
Change-Id: I5b7707e746d6b825d835a007727b29c9a81a7fc1
2018-01-30 15:41:33 -08:00
TreeHugger Robot
10cdf29b53 Merge "Center align suggestion tile action button." 2018-01-30 22:44:27 +00:00
TreeHugger Robot
818b37d337 Merge "Add a few UI tests" 2018-01-30 22:01:25 +00:00
Julia Reynolds
4f3b556388 Notification settings updates
- Footer preferences were too dim
- Fix text and target on recently sent apps
- Make 'behavior' a dialog
- reorder settings on apps page

Change-Id: Idf8056bc77ead89fe2025bbde3346861e23a3c8d
Fixes: 72652526
Fixes: 72651810
Fixes: 72652024
Bug: 72651953
Test: make RunSettingsRoboTests
2018-01-30 16:59:12 -05:00
TreeHugger Robot
3b04494ac6 Merge "Change automatic brightness summary to absolute brightness." 2018-01-30 21:39:16 +00:00
Doris Ling
1fcd60c4b6 Center align suggestion tile action button.
Bug: 70573674
Test: visual
Change-Id: I9be36cb0f1c35c2062f01d03e01e0a74cb39f3a0
2018-01-30 12:50:17 -08:00
Fan Zhang
9a465f3f7f Add a few UI tests
- Verify storage setting display items
- Battery

Test: atest
Change-Id: Ia892e0e3265aa8bebda74df26dd67e6b12f5cb67
Fixes: 72461383
2018-01-30 12:12:58 -08:00
TreeHugger Robot
5dda7faac0 Merge "Remove app info page v1 related codes." 2018-01-30 19:57:48 +00:00
TreeHugger Robot
85fd529cc4 Merge "Remve menu item in battery settings" 2018-01-30 19:04:26 +00:00
TreeHugger Robot
e0bc26d6dd Merge "Use the correct prebuilts for lifecycles." 2018-01-30 18:50:45 +00:00
TreeHugger Robot
4b1f25ada4 Merge "Add UI tests for new time zone picker" 2018-01-30 12:04:25 +00:00
TreeHugger Robot
7ad6c403e2 Merge "Update summary for fingerprint unlock suggestion." 2018-01-30 06:54:53 +00:00
TreeHugger Robot
acd313e644 Merge "Move force stop button into option menu." 2018-01-30 06:30:20 +00:00
TreeHugger Robot
0be5e81526 Merge "Update suggestion card UI." 2018-01-30 03:55:28 +00:00
TreeHugger Robot
d3ee4e260d Merge "Dismiss suggestion when close button is clicked." 2018-01-30 01:26:23 +00:00
Doris Ling
ce55d7c6a1 Remove app info page v1 related codes.
- change to use AppInfoDashboardFragment completely
- remove InstalledAppDetails and the corresponding tests

Change-Id: I8cbdf71cadc8b5743929abbafe91185e5e39b6b2
Fixes: 69384089
Test: make RunSettingsRoboTests
2018-01-29 17:14:32 -08:00
TreeHugger Robot
18277f1b5e Merge "Add search keyword for ambient display" 2018-01-30 01:07:18 +00:00
Doris Ling
c04163a76e Update suggestion card UI.
- adjust suggestion card width and padding
- tint icon if it is from settings package.

Bug: 72330968
Test: visual
Change-Id: I4b82d51b3013ad0656d297305e0000958b71e94d
2018-01-29 16:39:31 -08:00
Doris Ling
c0b7fa0ad4 Update summary for fingerprint unlock suggestion.
- replicate the summary string for the fingerprint unlock suggestions
for different product variation.

Bug: 70573674
Test: rebuild
Change-Id: Ib85fbe1ddbf5f2f500743cabf5f219e5e48f61e4
2018-01-29 16:03:45 -08:00
Doris Ling
604a3d2248 Move force stop button into option menu.
- only show 1 button in the app info page
- move all handling for the force stop button from
AppActionButtonPreferenceController to a new option menu controller

Bug: 71778950
Test: make RunSettingsRoboTests
Change-Id: Iaa2c9784162a5f1acaaf9e11e3ce988945b40538
2018-01-29 15:44:23 -08:00
Victor Chang
fbf05e93d6 Add UI tests for new time zone picker
- Test selecting 2 time zones in picker
- Device.wait could return null object and cause NPE.
  Add helper function throw UiObjectNotFoundException with selector info

Bug: 62255208
Test: atest SettingsUITests:ZonePickerSettingsTest
Change-Id: Id0439dde25240cf2d3ee834043d1726a2c738d1a
2018-01-29 23:33:04 +00:00
TreeHugger Robot
75c2ca96f1 Merge "Remove security settings v1 code" 2018-01-29 23:25:09 +00:00
Fan Zhang
26ba7cef8f Add search keyword for ambient display
Change-Id: I725e734e656bf01d4d9a354d01d10717b724d848
Fixes: 71892510
Test: rebuild
2018-01-29 14:42:36 -08:00
TreeHugger Robot
f92b2773d3 Merge "Move AccessPointPreference.generateApKey." 2018-01-29 22:40:43 +00:00
TreeHugger Robot
7078e342fe Merge "Fix shortcut icon in launcher" 2018-01-29 22:19:43 +00:00
Sudheer Shanka
67ddb0ae00 Merge "Add policy transparency for metered data related settings." 2018-01-29 22:01:35 +00:00
Doris Ling
0e32252111 Dismiss suggestion when close button is clicked.
- add handling to the suggestion card to dismiss the suggestion when
the close button is clicked.

Bug: 70573674
Test: make RunSettingsRoboTests
Change-Id: I8155efc326242abde753a633009e2579a9b3aa9b
2018-01-29 13:20:32 -08:00
Fan Zhang
73dc479ab5 Remove security settings v1 code
Change-Id: I958ed1588009b91f64cd8ecb98208e72a891903e
Fixes: 32953042
Test: robotests
2018-01-29 13:17:05 -08:00
TreeHugger Robot
35a7f0d642 Merge "Fix settings ui tests in abvt suite" 2018-01-29 20:58:35 +00:00
Fan Zhang
409eab14de Fix shortcut icon in launcher
When building icon for shortcut, check if the icon is LayerDrawable.
- If yes, only take the second layer (foreground).

Also move the class to shortcut package

Change-Id: I3513dbeb6509f11aa70ab3230d441e268ca9356d
Fixes: 72553870
Test: atest
2018-01-29 11:39:48 -08:00
Jin Dong
1ac7202238 Merge "Fix memory leak of DataSaverPreference" am: 7a65c7f279 am: 64ee868ff3
am: b9af110c03

Change-Id: I07aae53bbf708317cc4ca60926c27c22d37c2179
2018-01-29 19:11:40 +00:00
Jin Dong
b9af110c03 Merge "Fix memory leak of DataSaverPreference" am: 7a65c7f279
am: 64ee868ff3

Change-Id: Ieda87ec6f8958d11b36cc48fab83233c687a254f
2018-01-29 19:10:00 +00:00
Jin Dong
64ee868ff3 Merge "Fix memory leak of DataSaverPreference"
am: 7a65c7f279

Change-Id: If0cc15cc83afde74a2cd694924fe5af8cf124c8b
2018-01-29 19:07:25 +00:00
Treehugger Robot
7a65c7f279 Merge "Fix memory leak of DataSaverPreference" 2018-01-29 19:03:33 +00:00
Fan Zhang
7576e726f9 Fix settings ui tests in abvt suite
Change-Id: I77a262c473b2dfe09c3dabf8e07525fa17815b35
Fixes: 72608407
Test: atest
2018-01-29 10:56:42 -08:00
TreeHugger Robot
7245bbb3d5 Merge "Readd needed string" 2018-01-29 18:23:45 +00:00
Michael Wright
30b66159aa Change automatic brightness summary to absolute brightness.
The brightness slider now always represents the absolute brightness,
including when adaptive brightness is enabled. This changes the summary
of the brightness setting to reflect that.

Bug: 72627086
Test: ROBOTEST_FILTER=BrightnessLevelPreferenceControllerTest m -j RunSettingsRoboTests
Change-Id: I76eed8aa9ee88fe6b70e30d54bfc0d18d1141377
2018-01-29 16:52:47 +00:00
Jin Dong
484087c181 Fix memory leak of DataSaverPreference
When DataSaverPreference is shown repeatedly, memory leak happens
since DataSaverBackend.Listener is not removed on onDetached().

TEST: Repeat enter and exit "Data usage" for
several times and check if the count of activity
is not increasing.

Bug: 72581115
Change-Id: Ic4a72de049bb87f1e522fe46dd0fb4bb58ed65a5
2018-01-29 16:32:45 +09:00
TreeHugger Robot
9024b4eb15 Merge "Display a list of account types as account setting summary" 2018-01-28 21:16:17 +00:00