Commit Graph

12707 Commits

Author SHA1 Message Date
Jeff Sharkey
dba5623a0b am c3e8fd25: am e0388230: am 14136c7c: Merge "Settings: Fix the memory leak in Settings"
* commit 'c3e8fd25997a70155497358d077e6c8fec6fe981':
  Settings: Fix the memory leak in Settings
2014-02-21 17:28:39 +00:00
Jeff Sharkey
c3e8fd2599 am e0388230: am 14136c7c: Merge "Settings: Fix the memory leak in Settings"
* commit 'e0388230768168af31c26507b5889985daa93169':
  Settings: Fix the memory leak in Settings
2014-02-21 17:26:29 +00:00
Jeff Sharkey
e038823076 am 14136c7c: Merge "Settings: Fix the memory leak in Settings"
* commit '14136c7cdfee7525a97cfee6eec038994668b6a5':
  Settings: Fix the memory leak in Settings
2014-02-21 17:21:48 +00:00
Jeff Sharkey
14136c7cdf Merge "Settings: Fix the memory leak in Settings" 2014-02-21 17:17:22 +00:00
Fabrice Di Meglio
351adbf35c Merge "Fix bug #13058470 Cannot add account -- Settings app crashes" 2014-02-21 00:22:16 +00:00
Fabrice Di Meglio
74309ea53a Fix bug #13058470 Cannot add account -- Settings app crashes
- revert back to an Activity instead of a fragment. This
is a straight reverse of the changes introduced for trying
to have a Fragment.

Basically ChooseAccountActivity was previously an Activity for
choosing an account type. If the list of account types was containing
only one item, then the ChooseAccountActivity was just a pass thru
and was falling back to the only account authority available.

In the current reported bug, this was happening by disabling the
Email app and thus having only the GoogleAuthenticator as an
Authority.

Then in the onCreate() the ChooseAccountFragment was seeing that
there was only one account authenticator and issuing a BACK button
press. Too bad, this was done into a non finished Fragment transaction
and leading to a crash.

All in all, we NEED to have an Activity and cannot use a Fragment
in that case.

Change-Id: I4a867a25fe9580929ec50a6775105adac1f88c52
2014-02-20 16:21:14 -08:00
Baligh Uddin
ef49311b77 am 8db86bc9: (-s ours) am 1bb55f55: (-s ours) am a9d878ef: (-s ours) am af03def3: (-s ours) am 63a354ee: (-s ours) am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit '8db86bc9bc7265d067da92c22e54be98e42b833f':
  Import translations. DO NOT MERGE
2014-02-20 23:15:41 +00:00
Baligh Uddin
8db86bc9bc am 1bb55f55: (-s ours) am a9d878ef: (-s ours) am af03def3: (-s ours) am 63a354ee: (-s ours) am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit '1bb55f555fce1e83bcdc9d154dc6ff714b2a029b':
  Import translations. DO NOT MERGE
2014-02-20 21:09:39 +00:00
Baligh Uddin
1bb55f555f am a9d878ef: (-s ours) am af03def3: (-s ours) am 63a354ee: (-s ours) am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit 'a9d878ef67f54c878cef0868767ed8e9a5b8c063':
  Import translations. DO NOT MERGE
2014-02-20 21:06:07 +00:00
Baligh Uddin
a9d878ef67 am af03def3: (-s ours) am 63a354ee: (-s ours) am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit 'af03def380ca594838ef6caff4f8c23dc78e821c':
  Import translations. DO NOT MERGE
2014-02-20 21:02:54 +00:00
Baligh Uddin
af03def380 am 63a354ee: (-s ours) am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit '63a354ee094f3e71773cbdd29359b5c28df2b9f0':
  Import translations. DO NOT MERGE
2014-02-20 20:59:28 +00:00
Baligh Uddin
63a354ee09 am d83484db: (-s ours) Import translations. DO NOT MERGE
* commit 'd83484dba0749e01cf80a85cd0d2648a79f9fdf4':
  Import translations. DO NOT MERGE
2014-02-20 20:56:19 +00:00
Baligh Uddin
b52368fe37 Import translations. DO NOT MERGE
Change-Id: Idd6939c2d6ea42d687057848503456b4829bb0d6
Auto-generated-cl: translation import
2014-02-20 07:35:16 -08:00
Baligh Uddin
d83484dba0 Import translations. DO NOT MERGE
Change-Id: I96d7cdea504fe320dc1768f1e0dbae23d5901fbd
Auto-generated-cl: translation import
2014-02-20 07:23:08 -08:00
Fabrice Di Meglio
e611b8590d Merge "Fix bug #13084552 Correct list of accounts are not shown when tapping ...on type of accounts(corporate,google etc.,) in Settings under Accounts section" 2014-02-19 22:18:15 +00:00
Fabrice Di Meglio
61a77ab51d Fix bug #13084552 Correct list of accounts are not shown when tapping
...on type of accounts(corporate,google etc.,) in Settings under Accounts section

- allow Account Type (corporate and the others...) entries to work.

Basically as they are sharing the same fragment we could only hit it
only once (and the first hit was winning).

Change-Id: I16683fc7342564a8ed1a4853a576166ab4d91df9
2014-02-19 14:14:03 -08:00
Fabrice Di Meglio
9a7124e8ac Merge "Fix bug #12993929 Screen orientation change replaces wifi password dialog with Add network dialog" 2014-02-19 22:12:38 +00:00
Fabrice Di Meglio
f7398fceac Merge "Fix bug #13027956 For restricted user launching Settings app from all apps drawer ...by default opens wifi setting screen" 2014-02-19 03:46:17 +00:00
Fabrice Di Meglio
2858b790ad Fix bug #13027956 For restricted user launching Settings app from all apps drawer
...by default opens wifi setting screen

- add the Dashboard to the list of restricted fragments

Change-Id: I7787ed7c9f2a53ea1047b6ab860ded50e4e5d840
2014-02-18 19:35:08 -08:00
Fabrice Di Meglio
377dd62bd7 Fix bug #12993929 Screen orientation change replaces wifi password dialog with Add network dialog
- use the correct Fragment manager: it should be the child's one

Change-Id: I286b276bc6c5180b7c0e458d8562938671d493c8
2014-02-18 18:24:30 -08:00
rich cannings
4ecd8d4d9a Update verify apps summary string
Bug: 12836511
Change-Id: I7c198efc03b403f2dfede47648487875bc9b2f82
2014-02-18 16:47:50 -08:00
rich cannings
13ae78a5a7 Update verify apps summary string
Bug: 12836511
Change-Id: Ibce824bcef3e3c9a3f9ea69ed4b8425663bbdb12
2014-02-18 14:00:50 -08:00
Fabrice Di Meglio
86a2556aa7 Merge "Improve titles" 2014-02-18 21:37:46 +00:00
Baligh Uddin
5015e0f13b Merge "Import translations. DO NOT MERGE" 2014-02-18 04:40:49 +00:00
Baligh Uddin
9342f0a7c6 Import translations. DO NOT MERGE
Change-Id: Ifc5a92d261269d729bb216c2acda566ba8091eec
Auto-generated-cl: translation import
2014-02-17 15:54:58 -08:00
Alan Viverette
bc02ced9fb Set caption preview font size in dips
Change-Id: I9844b6f927b557b46f23c6211b5be47647002ab8
2014-02-17 13:34:37 -08:00
Fabrice Di Meglio
b05f1d0081 Merge "Crash in Settings observed while changing the device orientation after renamed tablet" 2014-02-14 23:59:47 +00:00
Fabrice Di Meglio
ce930c15ae Crash in Settings observed while changing the device orientation after renamed tablet
There was a fundamental flow in the BT code. Basically BluetoothSettings is using
a singleton BluetoothDiscoverableEnabler.

BluetoothDiscoverableEnabler is keeping (thru its constructor) a reference on a Context
for registering/unregistering some broadcast receiver. BUMMER! When you change orientation
(or more generally the device Configuration), your Context is no more the same!

Hence the crash as we were  trying to unregister a Receiver on a Context that is no more valid.

Fix that issue by passing an updated Context to the BluetoothDiscoverableEnabler.resume() API.

Bug #12991455
Change-Id: I77db15d2b59b6dd973907e26f9e6bb022202a8b5
2014-02-14 23:53:44 +00:00
Fabrice Di Meglio
4aca90c2da Merge "Code cleaning for Printing Settings" 2014-02-14 23:50:23 +00:00
Paul Lawrence
b643627651 Merge "Support default, pattern, pin and password encryption types" 2014-02-14 15:25:25 +00:00
Fabrice Di Meglio
5c2d723723 Code cleaning for Printing Settings
- remove non needed code

Change-Id: I18a3992d66721dbeba6870aa2834e1c717640a15
2014-02-13 19:00:38 -08:00
Fabrice Di Meglio
c169ee6fdc Improve titles
- makes titles consistent with what is shown into the Drawer and
defined into the PreferenceScreen files

Change-Id: I6077d947b3afcc63bfbe9c78b973709778064f9b
2014-02-13 18:55:15 -08:00
Baligh Uddin
ba8b9bec61 Merge "Import translations. DO NOT MERGE" 2014-02-13 05:19:03 +00:00
Fabrice Di Meglio
a7ad619af4 Fix bug #12991557 User taken to previously closed setting option
- fix behavior when we are closing the Drawer. Now will not trigger twice the same action
- fix selection in the Drawer for "Add Account": it basically should never be selected
as it is more like a button
- fix also Titles stack when launching an Intent
- remove some dead code

Change-Id: I196ad9fcd0599703f2abb902b088fbda9b4690a0
2014-02-12 16:37:04 -08:00
Fabrice Di Meglio
de40d9ed2f Merge "Fix title when changing from portrait to landscape configuration" 2014-02-12 22:46:51 +00:00
Baligh Uddin
2b2b4960b8 Import translations. DO NOT MERGE
Change-Id: I42687df26965ff4f23fc5ed2db2e93d300aba609
Auto-generated-cl: translation import
2014-02-12 12:46:26 -08:00
Fabrice Di Meglio
5529d29f6c Fix title when changing from portrait to landscape configuration
- save the titles stack during onSaveInstanceState(...)
- set it back when creating the activity if there is a savedInstanceState
and restore the title to the last item in the stack

Change-Id: Ic6c2714f5474275c9f55cc4d6c70d14f6a8cd993
2014-02-12 12:38:07 -08:00
Fabrice Di Meglio
e6c9a5da01 Fix bug #12979102 Menu (Reset to default) and Add icon missing in APNs
- revert the changes on the ApnSettings to be again an Activity...

Change-Id: I7a12e25456f0a0df0f7618183f49fd8db10a5441
2014-02-11 19:03:27 -08:00
Fabrice Di Meglio
710e309951 Fix bug #12978671 RTE while tapping on Access points
- revert back to a PreferenceActivity

Change-Id: Ie79b46908c9d8dcf3c2b77bd0999341c7e72050e
2014-02-11 18:27:38 -08:00
Fabrice Di Meglio
6502720566 Code cleaning
- remove duplicate reference to current header (mCurHeader) in favor of mCurrentHeader
- clean onSaveInstanceState()

Change-Id: Ia9322471f0b0d13d51e105c8fd625774d8867fdc
2014-02-11 15:27:00 -08:00
Fabrice Di Meglio
a16bd76d45 Merge "Fix bug #12957032 Stability-Sys: Java crash in com.android.settings: java.lang.NullPointerException: ...Attempt to invoke virtual method 'boolean android.os.Handler.sendEmptyMessage(int)' on a null object reference" 2014-02-11 21:50:18 +00:00
Fabrice Di Meglio
7ce7c40dac Fix bug #12957228 Java crash in com.android.settings: java.lang.IllegalStateException:
...Can not perform this action after onSaveInstanceState

- prevent a click on the Drawer's Headers when the App is paused / finished
- register / unregister the DrawerListener when needed

Change-Id: Ia270ef27b23c66d55565bbb73d4f6a6531b742d2
2014-02-11 13:31:39 -08:00
Baligh Uddin
ef2b359b48 Merge "Import translations. DO NOT MERGE" 2014-02-11 21:23:28 +00:00
Fabrice Di Meglio
edf696774e Merge "There are several painful issues with the initial CL. Doing a revert for now and will rework this." 2014-02-11 19:52:06 +00:00
Fabrice Di Meglio
10afdb82ac There are several painful issues with the initial CL. Doing a revert for now and will rework this.
Revert "Fix bug #12939786 BACK should go back into the Fragments BackStack and finally to Overview ...and then exit the Settings App"

This reverts commit 4cc95a53c2.

Change-Id: Iaa21d4771d0b004eff3d8e68b91b546a633d8f23
2014-02-11 19:50:56 +00:00
Paul Lawrence
b05f39d186 Support default, pattern, pin and password encryption types
Use plumbing provided by dependant change to bring up correct dialog
at boot time.

Needs matching framework changes from
 https://googleplex-android-review.googlesource.com/#/c/412885/

Bug: 8769627
Change-Id: Ib04a2875e051a7cccca035fadb25978dfec22491
2014-02-11 10:27:58 -08:00
Fabrice Di Meglio
002b29fafc Fix bug #12957032 Stability-Sys: Java crash in com.android.settings: java.lang.NullPointerException:
...Attempt to invoke virtual method 'boolean android.os.Handler.sendEmptyMessage(int)' on a null object reference

- prevent NPE by checking the nullity of the Handler reference
- remove dead code
- rename mHandler to sHandler as it is a static

Change-Id: I7f4101f860f24b0cd49a4656971e9b54e55c1286
2014-02-10 17:39:01 -08:00
Fabrice Di Meglio
1ffab228a4 Merge "Fix bug #12939786 BACK should go back into the Fragments BackStack and finally to Overview ...and then exit the Settings App" 2014-02-11 00:33:22 +00:00
Fabrice Di Meglio
768201371d Fix bug #12910315 RTE while entering *#*#INFO#*#* command from Dialer
- revert back to PreferenceActivity

Change-Id: I8724886dd9649d649f7cd4730f738fb47727c056
2014-02-10 16:27:24 -08:00
Fabrice Di Meglio
4cc95a53c2 Fix bug #12939786 BACK should go back into the Fragments BackStack and finally to Overview
...and then exit the Settings App

- fix the way we manage the Fragment BackStack
- revert back ChooseLockGeneric to be a PreferenceActivity

Change-Id: I3c366b4be606e2e211facd0299b9a2de5cc6ea79
2014-02-10 16:07:50 -08:00