Commit Graph

44309 Commits

Author SHA1 Message Date
TreeHugger Robot
d24c9e4a80 Merge "Grey the previously connected device preference" into pi-dev 2018-05-18 03:21:57 +00:00
hughchen
980b718989 Grey the previously connected device preference
* Add PreviouslyConnectedDevicePreferenceController to handle the preference should be
  enable or disable.
  Example: If there are no previously connected devices disable the preference otherwise
  enable it.
* Add PreviouslyConnectedDevicePreferenceControllerTest
  1. Verify the callback can be registered and unregistered
  2. Verify the preference is enable when there
     have more than 1 previously connected device
  3. Verify the preference is disable when there
     have no previously connected device

Bug: 78250052
Test: make -j50 RunSettingsRoboTests
Change-Id: I31b5d416aaf907c3bbf1cb61de6e7401463e3df7
Merged-In: I31b5d416aaf907c3bbf1cb61de6e7401463e3df7
2018-05-18 02:16:23 +00:00
TreeHugger Robot
ad031a0a4d Merge "Update condition title text color." into pi-dev 2018-05-18 01:59:24 +00:00
Doris Ling
1b242d24ca Merge "Adjust Lock screen message for better accessibility." into pi-dev 2018-05-18 01:23:00 +00:00
TreeHugger Robot
a07b1f83a8 Merge "Fix tethering summary when airplane mode is off" into pi-dev 2018-05-18 00:49:50 +00:00
TreeHugger Robot
e2d14d409e Merge "Adjust wifi dialog for better accessibility" into pi-dev 2018-05-18 00:12:44 +00:00
TreeHugger Robot
2200308554 Merge "Misc style updates to fix some GAR issues" into pi-dev 2018-05-18 00:09:44 +00:00
Doris Ling
3d5556c6f8 Update condition title text color.
- change from color accent to text color primary.

Change-Id: I9aae199a1d98772125526468aa80f9f423b106c0
Fixes: 79700374
Test: visual
2018-05-17 16:34:37 -07:00
Lei Yu
e7dd4197b0 Adjust wifi dialog for better accessibility
For some items, change the minHeight to 48dp. Also update text size
a little bit to fit the new height.

Change-Id: I87d3067c29d0d87eff6eadc4332984171e9fe4b6
Fixes: 79722015
Test: Build
2018-05-17 16:05:09 -07:00
Fan Zhang
36e61e191a Misc style updates to fix some GAR issues
- Increase tap target height for add wifi dialog entries.
- Increase tap height for vpn editor fields
- Tap target area for switchbar toggle

Change-Id: I0d0e350dd4236cd4fe73fa190fb79ca50de2da60
Fixes: 79871635
Fixes: 79887410
Test: visual
2018-05-17 15:03:18 -07:00
Doris Ling
3500784e82 Adjust Lock screen message for better accessibility.
- increase text height to 48dp

Change-Id: Ie3ab56eeed453bb7b131458a3966534a0bf68871
Fixes: 79711251
Test: visual
2018-05-17 14:45:18 -07:00
Lei Yu
4fec12cbbf Fix tethering summary when airplane mode is off
When airplane mode is off, fall back to default summary
(tether off summary). It should be fine because once tether
state get updated again, it will go through original listener
to update the summary.

Change-Id: Iba9b56f452e72365ea964d841ee156a2625c0ae1
Fixes: 79721162
Test: RunSettingsRoboTests
2018-05-17 14:38:22 -07:00
Andrew Sapperstein
96294df2f0 Merge "Make the night display suggestion depend on a flag." into pi-dev 2018-05-17 20:40:21 +00:00
TreeHugger Robot
7e6d495cec Merge "Hook up slice deep links" into pi-dev 2018-05-17 20:15:39 +00:00
TreeHugger Robot
1fe4512596 Merge "Do not perform device index before device provision." into pi-dev 2018-05-17 19:41:43 +00:00
Rubin Xu
ef088843ae Merge "Setting should handle android.settings.SYNC_SETTINGS from managed profile" into pi-dev 2018-05-17 18:57:46 +00:00
Daniel Nishi
4e9d52791b Make the night display suggestion depend on a flag.
This allows it to be enabled/disabled on certain devices.

Change-Id: I7b73bb866b05b92588e15ef7ffc2834cdde041ce
Fixes: 78601616
Test: Settings robotest
2018-05-17 10:29:59 -07:00
Matthew Fritze
46aa586610 Add Wifi Slice
Add a custom Wifi Slice to the Settings Slice Provider.
It needs a custom Slice because of the complicated listener logic
in the MasterSwitchPreferenceController, which makes it hard to
work-in synchronous set/get logic.

The one-off Slice requires extra changes, including:
- Including it in getDescendants
- Handling changes to wifi by the framework

This is the first change that uses SettingsLib's broadcast relay,
which allows settings to (un)register IntentFilters to a Uri,
allowing Settings Slices affected by the framework (quicksettings,
connectivity related, volume, etc) to be updated without action
on the Slice.

Fixes: 70622039
Fixes: 67997332
Test: robotests
Change-Id: Ia76738dd6baacd5522d52df2c61ebad86a600282
Merged-In: Ibfe4736beecb833e3f6bb871b2eb5228a5fd3a34
2018-05-17 09:58:19 -07:00
Rubin Xu
71560fcba1 Setting should handle android.settings.SYNC_SETTINGS from managed profile
When android.settings.SYNC_SETTINGS is fired from a managed profile, Settings
should handle it properly and displays the UI to manage accounts in the profile.
Since Settings uses a unified page to display both personal and work accounts,
it should redirect the intent to the UserAndAccountDashboardActivity in user 0

Bug: 79561138
Test: adb shell am start -a android.settings.SYNC_SETTINGS --user 10
      verifies the UI is showing work accounts

Change-Id: Ib82a04ad0ec72d58d60569e38538c5dbd6181bf0
2018-05-17 14:55:58 +01:00
TreeHugger Robot
24bbc4bfe1 Merge "Get rid of divider above ringtone selector" into pi-dev 2018-05-17 13:34:34 +00:00
TreeHugger Robot
667cbc5846 Merge "Add “Rename device” on Bluetooth screen" into pi-dev 2018-05-17 09:08:30 +00:00
TreeHugger Robot
273faa216e Merge "Bluetooth and NFC added back to Connection preferences" into pi-dev 2018-05-17 09:06:18 +00:00
hughchen
b6ac12eed4 Update DialogFragment UI when BT device is add/remove/rename
* Add AudioSwitchCallback() in AudioSwitchPreferenceController.
  This callback is used to notify SoudSettings to update the dialogFragment UI.
* Add UpdatableListPreferenceDialogFragment that updates the available
  options when dialog is shown
* Add test to verify the adapter count when
  onListPreferenceUpdated() is called.

Bug: 77783217
Test: make -j50 RunSettingsRoboTests
Change-Id: I8cac1b30ec50df026f4b7722dd1cd2f69e77a4cb
Merged-In: I8cac1b30ec50df026f4b7722dd1cd2f69e77a4cb
2018-05-17 07:40:52 +00:00
TreeHugger Robot
0cf2e41bf8 Merge changes from topic "pi-telephonydebugmenu" into pi-dev
* changes:
  [Telephony Debug Menu] Add Link Capacity Estimate
  [Telephony Debug Menu] Add Physical Channel Config
  [Telephony Debug Menu] LTE BW and Serving CellInfo
2018-05-17 04:45:41 +00:00
TreeHugger Robot
3feb2f87ff Merge "Update method isSmartBatteryEnabled()" into pi-dev 2018-05-17 02:43:22 +00:00
TreeHugger Robot
cd28a977ca Merge "Convert Magnify controller to TogglePrefController" into pi-dev 2018-05-17 00:43:04 +00:00
TreeHugger Robot
d0888e9e5b Merge "Clean-up settings slices" into pi-dev 2018-05-17 00:26:32 +00:00
TreeHugger Robot
0226c4d39d Merge "Darken the secondary text on storage items." into pi-dev 2018-05-17 00:13:05 +00:00
Andreas Terzis
6eb1d9ed90 Merge "Increase the char limit of carrier_and_update_now_text to 34." into pi-dev 2018-05-16 23:44:35 +00:00
TreeHugger Robot
9a93a1dbe9 Merge "Moves Swipe Up overlay from Settings app to android.internal" into pi-dev 2018-05-16 23:38:31 +00:00
TreeHugger Robot
d924894652 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev 2018-05-16 23:28:28 +00:00
TreeHugger Robot
e7f321c3c0 Merge "Set slice summary text to screentitle first" into pi-dev 2018-05-16 22:51:55 +00:00
Nathan Harold
f10ea32d55 [Telephony Debug Menu] Add Link Capacity Estimate
Register for the Link capacity estimate for the
cellular default data connection and report it
in the debug menu.

Bug: 78791811
Test: manual
Change-Id: I73d945dfa192873936107902e0de6d58fc69059b
2018-05-16 15:44:27 -07:00
Nathan Harold
433ca4427c [Telephony Debug Menu] Add Physical Channel Config
Add a field to display the PhyChanConfig and register
for this event as part of the PhoneStateListener.

Bug: 78791811
Test: manual
Change-Id: Ic038aa65655f8efa98bf1d6388e7c61761d2eb4a
2018-05-16 15:44:24 -07:00
Nathan Harold
6e16fdf399 [Telephony Debug Menu] LTE BW and Serving CellInfo
Add debug menu support for the serving cell status
indication and the LTE bandwidth in the CellInfo
display.

Bug: 78791811
Test: manual
Change-Id: Ic51858131af671317431e0970bdcaeebcb460931
2018-05-16 15:40:59 -07:00
Daniel Nishi
e5a006f61b Darken the secondary text on storage items.
This darkens the X.XX GB text on the storage items to improve the
contrast between the text and the background color.

Bug: 79754437
Test: Manual
Change-Id: Icc44a97d810cd1aea22438f38e5e97ddb7b8e43d
2018-05-16 15:34:34 -07:00
Nitin Shivpure
1b0afb9d1c Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak
Usecase:
1.) Make sure BT is turned off.
2.) Go to Settings -> Network & Internet
3.) Press back  from Network & Internet.
4.) Repeat above step 2000 times

Expected Result:
No ANR/Crashed should be seen.

Observed Result:
ServiceConnection leak is happening & android setting app get crashed.

Root cause: TetherPreferenceController tries to get
pan Proxy object, when BT is oFF, which is leaking one
service connection each time

Fix: getProfileProxy for Pan must only be called, when BT is
      turned on.

Test: lifeCycle_onCreate_shouldNotInitBluetoothPanWhenBluetoothOff

Bug: 79561076
Change-Id: I85208f48ce4dded94020cb156fcdb98b2cc873f9
(cherry picked from commit 31bcf6225cdabee4f810d4fe55ea32d0d43a9c5c)
(cherry picked from commit 31c799305b480e56bd083a48c6acca11572ebe16)
2018-05-16 15:22:56 -07:00
TreeHugger Robot
e3319d0449 Merge "Move app setting link from Entity header to pref controller" into pi-dev 2018-05-16 20:51:17 +00:00
Fan Zhang
4b04ba5903 Do not perform device index before device provision.
Bug: 79841744
Test: robotests
Change-Id: I74243b6f31364220156e91fe63b56138a0240714
2018-05-16 13:26:24 -07:00
Fan Zhang
cac18e12ac Move app setting link from Entity header to pref controller
Change-Id: I13a27486a9c9b4c4fb358715d678473e63c1b624
Merged-In: I13a27486a9c9b4c4fb358715d678473e63c1b624
Fixes: 79688822
Test: robotest
2018-05-16 19:56:33 +00:00
Andreas Terzis
251bcbec13 Increase the char limit of carrier_and_update_now_text to 34.
The translation of the carrier_and_update_now_text field
in some European languages requires 34 characters. To
accomodate these requirements increase the character
limit from 30 to 34.

Bug: 76443102
Test: manual
Change-Id: I61c95fc6c30bd98d6b418047ae7cc1f2423a12e0
2018-05-16 12:35:25 -07:00
TreeHugger Robot
a0f9241400 Merge "Support Vibrate for calls in Settings Slices" into pi-dev 2018-05-16 18:48:14 +00:00
Beverly
3f42a23816 Get rid of divider above ringtone selector
Change-Id: I939d1ab061fb55853fbc0505b8d9025715b9df97
Fixes: 79480349
Test: manual
2018-05-16 14:28:15 -04:00
TreeHugger Robot
46338558e1 Merge "Change string from "Add device" to "Pair new device"" into pi-dev 2018-05-16 17:32:38 +00:00
hughchen
52feedf354 Bluetooth and NFC added back to Connection preferences
* Bluetooth and NFC added back to "Connection preferences"

Bug: 79299421
Test: make -j50 RunSettingsRoboTests
Change-Id: I8f4c389c28c7cc752f198be2b59b28b6e9af2c90
Merged-In: I8f4c389c28c7cc752f198be2b59b28b6e9af2c90
2018-05-16 17:03:31 +00:00
Joshua Mccloskey
d819dbacb6 Merge "Fixed accessibility bug in choose_lock_pattern_common.xml where title was not always read" into pi-dev 2018-05-16 16:49:14 +00:00
hjchangliao
a92271c26d Convert Magnify controller to TogglePrefController
Convert below to TogglePreferenceController:
MagnificationNavbarPreferenceController
(Magnify with Button)
MagnificationGesturesPreferenceController
(Magnify with triple-tap)

The two controllers share the same fragment,
Add static method for set/get state in fragment,
And use them in controllers and fragment.

Change-Id: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Merged-In: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Fixes: 67997698
Fixes: 67997726
Test: make RunSettingsRoboTests
2018-05-16 16:45:47 +00:00
Matthew Fritze
7d565e97a3 Clean-up settings slices
- Set TTL to Infinity
- Set color of each slice to color accent

Change-Id: I7de4530880725ba3282602135bdc1fa85d786905
Fixes: 79780418
Test: robotests
2018-05-16 08:20:05 -07:00
Matthew Fritze
f9c13fc305 Set slice summary text to screentitle first
To improve context on search surfaces where the
setting may be ambiguous, we set the screentitle
as the summary text as the top priority. If there is
no screentitle or the it matches the title, then we
try to use the controller summary. If the controller
summary is not valid, then we show nothing.

Bug: 79780762
Test: robotests
Change-Id: If4f7f8d4a072125604ede14e3df2afd667fa24b7
2018-05-16 08:13:22 -07:00
TreeHugger Robot
b7b355a1c5 Merge "DO NOT MERGE Update zen onboarding" into pi-dev 2018-05-16 13:24:39 +00:00