Commit Graph

19035 Commits

Author SHA1 Message Date
Liefu Liu
121036ee7e Merge "Minor UI string change in Contacts Storage Setting." into main 2025-02-04 08:35:56 -08:00
Jacky Wang
2e265d4a7a [Catalyst] Introduce SettingsContract file
The new file contains all contract constants for external usages (e.g.
slice, external Get/Set API). Also reuse existing constants in
SettingsSlicesContract.

NO_IFTTT=Catalyst only

Bug: 388061003
Flag: EXEMPT refactor
Test: atest
Change-Id: I449b7b6cf82e1e102f2c96a21835191605f09943
2025-02-04 18:24:46 +08:00
Treehugger Robot
1ecacd8a5a Merge "Add one more param to isChargingOptimizationMode() for flexibility" into main 2025-02-04 01:01:51 -08:00
Jacky Wang
402e5bb38b Fix IntentReceiver leaked on Sound & vibration
The root cause is that PreferenceController migrated to Catalyst will be
removed by DashboardFragment and VolumeSeekBarPreferenceController
onPause() is not invoked.

NO_IFTTT=Controller only

Fix: 386162594
Flag: EXEMPT bugfix
Test: atest&manual
Change-Id: I13f8588c8259ed4ddb9895ffc60e209c99c05269
2025-02-04 15:08:38 +08:00
Jacky Wang
a7fa6efe8f Get rid of VolumeSeekBarPreferenceController.setCallback
Set the callback to VolumeSeekBarPreference directly and simplify
SoundSettings.

Bug: 386162594
Flag: EXEMPT refactor
Test: atest&manual
Change-Id: Ic114c15c236da9f3ea3754408adbfa9c841befd0
2025-02-04 15:08:38 +08:00
Yiling Chuang
ab6b7758c1 Add one more param to isChargingOptimizationMode() for flexibility
Adds a new param about the charging policy to see if it's currently under CHARGING_POLICY_ADAPTIVE_LONGLIFE for more flexibility to check whether the charging optimization mode is enabled.

Bug: 391270019
Flag: EXEMPT bugfix
Test: atest SettingsRoboTests
Change-Id: Ie773d9a2a13d1a37ac9fd5940f10a100eccf77ca
2025-02-04 03:53:51 +00:00
Treehugger Robot
2117499c9e Merge "Fix NPE issue in Internet Settings" into main 2025-02-03 19:50:56 -08:00
Shawn Lin
d6e99d3783 Merge "Provide a way to customize biometric SafetySourceIssue" into main 2025-02-03 18:18:37 -08:00
Yining Liu
4b43425394 Merge "Fix the test failures for the new lock screen notifications settings page" into main 2025-02-03 14:20:44 -08:00
Liefu Liu
27f16da565 Minor UI string change in Contacts Storage Setting.
Bug: 394114508
Test: atest ContactsStorageSettingTest
Flag: EXEMPTED

	modified:   res/values/strings.xml
	modified:   tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java

Change-Id: I2246f6a71116acd7d3ae256133ed1fea77c8ebab
2025-02-03 11:54:11 -08:00
Matthew DeVore
e8143a07a4 Allow pane height to shrink when setting topology
A recent CL added a feature to prevent the pane height from shrinking to
stop widgets from moving around. This is actually not a great experience
because a temporary state can keep the pane height very tall and
increase scrolling.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352648432
Test: change topology to be vertically shorter and verify the pane height shrinks
Change-Id: Ic48bfecea083a45c702c8719e3c93ceba55ae872
2025-02-03 13:37:16 -06:00
Treehugger Robot
a5e3d39db8 Merge "Disable ENABLE_DESKTOP_MODE_THROUGH_DEV_OPTION" into main 2025-02-03 04:42:10 -08:00
Weng Su
19bc8e0b86 Fix NPE issue in Internet Settings
- Ignore onWifiEntriesChanged callback when Activity does not exist

Bug: 389552565
Flag: EXEMPT bugfix
Test: Manual testing
atest -c NetworkProviderSettingsTest

Change-Id: I031043616f7c38d4bb27aa81ae3a0a0a32991c62
2025-02-03 18:40:47 +08:00
Shawn Lin
7c3559d37f Provide a way to customize biometric SafetySourceIssue
Add a new FeatureProvider for biometrics in FeatureFactory to provide a way to customize biometric SafetySourceIssue

Bug: 370940762
Test: m Settings
Test: m SettingsGoogle
Test: m SettingsSpaUnitTests
Test: m SettingsRoboTests
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: I4d11f3d3522ce5ac2f975cca7c041339f3ea6031
2025-02-02 18:46:25 -08:00
Treehugger Robot
e8afedea91 Merge "Desktop Experience needs the device to be eligible" into main 2025-02-01 04:56:13 -08:00
Pierre Barbier de Reuille
a85577054b Desktop Experience needs the device to be eligible
The Desktop Experience is only available (and therefore the freeform on
secondary display disabled) if the device is eligible for Desktop Mode.
Correcting the test to make it correct.

Fix: 393547201
Test: atest DesktopModeSecondaryDisplayPreferenceControllerTest
Flag: EXEMPT (bug fix)
Change-Id: I36a031487d8a6f6d681a2cb46a1fa50e47d870cc
2025-02-01 11:31:47 +00:00
Pierre Barbier de Reuille
2bd95dfc4d Disable ENABLE_DESKTOP_MODE_THROUGH_DEV_OPTION
To avoid issues controlling when desktop mode is enabled or not.

Bug: 393404767
Test: atest DesktopModePreferenceControllerTest
Flag: EXEMPT (bug fix)
Change-Id: I67643f3fe5994dfa901b259d5c49e89f19a9210c
2025-01-31 23:37:18 +00:00
Yining Liu
3e0623bd7e Fix the test failures for the new lock screen notifications settings page
Fix the old tests that fail when the new lock screen notifications
settings page flag is enabled.

Fix: 393631085
Flag: com.android.server.notification.notification_lock_screen_settings
Test: LockscreenNotificationMinimalismPreferenceControllerTest,
RedactNotificationPreferenceControllerTest,
ShowOnlyUnseenNotificationsOnLockscreenPreferenceControllerTest

Change-Id: I427ce675721c6d4df6451deebfcb6e4c06c72c37
2025-01-31 15:28:19 -08:00
Zhou Liu
8dc9b53328 Merge "Create "Change PIN" settings UI" into main 2025-01-31 14:13:12 -08:00
Zhou Liu
827d662460 Create "Change PIN" settings UI
Test: atest SupervisionChangePinPreferenceTest
Test: manually on real device
Bug: 393193125
Flag: android.app.supervision.flags.enable_supervision_settings_screen
Change-Id: I9a9af5d502c45a7710bcb73455eae9a828f0f721
2025-01-31 20:26:53 +00:00
Matthew DeVore
a23e3cb774 Simplify pane sizing and scaling algorithm
Simplify the scaling parameters and algorithm and reduce vertical
padding.

Originally a maxBlockRatio was specified at .12, which would have
caused a block length to typically be 2560 * 0.12 = 307. However, this
fails to account for smaller displays and high-DPI displays which have
smaller dip dimensions. So instead choose a maximum edge length of
256dp, which I have found to give good results on a laptop device
and a high DPI tablet, and which does not assume typical sizing for
configured displays, and still accomplishes the purpose of limiting
scrolling and dragging size.

Using the aspect ratio of the display bounds in setting the height
frequently caused a very large amount of padding, and limiting based on
the max block height only reduced it slightly. Now we set the vertical
height based on the minEdgeLength. This length is considered the
smallest size that can be comfortably interacted with, and we use it to
give ballpark ideal padding size.

Note that the unit test cases have increased pane height but in
practice (real-world pane width and constraints) this change seems to
decrease the pane height in general.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display, or with two external displays of smallish logical size
Change-Id: Id189892c88a1e833c1f54b0e5447a15f92e3310f
2025-01-30 20:37:03 +00:00
Riley Jones
6e12194015 Merge "Disabling elements on the A11y Shortcut setting subpage" into main 2025-01-28 13:24:42 -08:00
Matthew DeVore
ec58402c03 Merge "Apply display density to topology pane scaling" into main 2025-01-28 11:39:34 -08:00
Zhou Liu
56170c3f53 Merge "Create "Manage PIN" settings UI menu" into main 2025-01-28 10:48:39 -08:00
Matthew DeVore
e22d46aa9b Apply display density to topology pane scaling
Account for high DPI screens in topology pane scaling.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display
Change-Id: I192fccd402c20e00beacdb5ad55eed406252eb93
2025-01-28 17:24:05 +00:00
Yvonne Jiang
bf54835a94 Merge "Add handling for main Supervision settings toggle." into main 2025-01-28 08:23:39 -08:00
Yvonne Jiang
4f74b50b3a Add handling for main Supervision settings toggle.
This change introduces the basic behavior for the main toggle switch to
enable supervision. There is currently no PIN setup dialog when the
toggle is clicked. That will be added as a follow-up.

Intake bug: b/379312924

Change-Id: I75d6b2de1a7234c6da26fcdcf1d933eed3106a8c
Test: atest SupervisionMainSwitchPreferenceTest
Bug: 392694561
Flag: android.app.supervision.flags.enable_supervision_settings_screen
2025-01-28 02:35:14 -08:00
William Leshner
5035bede60 Merge "Add "Hub Mode" settings to mobile settings." into main 2025-01-27 20:28:02 -08:00
Zhou Liu
82356f6e93 Create "Manage PIN" settings UI menu
Test: atest SupervisionPinManagementScreenTest
Test: manually on real device
Bug: 390186179
Flag: android.app.supervision.flags.enable_supervision_settings_screen
Change-Id: Ib53dce2a32fe9551e8877145a61c8834505d389d
2025-01-28 01:12:22 +00:00
Treehugger Robot
532bd7f19e Merge "Add initial settings for summarization" into main 2025-01-27 07:04:49 -08:00
Julia Reynolds
50e720b03b Add initial settings for summarization
Test: SummarizationGlobalPreferenceControllerTest
Test: SummarizationPreferenceControllerTest
Flag: android.app.nm_summarization
Bug: 390415383
Change-Id: I773d69c707ae5f902860196fb44821ede15261f5
2025-01-27 05:54:01 -08:00
Nikhil Nayunigari
3db5f484ce Merge changes from topic "Ethernet Settings" into main
* changes:
  Adding EthernetInterfaceTracker to support EthernetSettings
  Adding middleware to support EthernetSettings
2025-01-25 18:05:21 -08:00
Nikhil Nayunigari
4d662c5bde Adding EthernetInterfaceTracker to support EthernetSettings
This class is part of the middleware and will be used to be notified
when an EthernetInterface is added or removed.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests: com.android.settings.network.EthernetInterfaceTrackerTest
Change-Id: If3a1f4d7a96b301cd47ffbea55864bcc780cd1e0
2025-01-25 13:01:35 -08:00
Nikhil Nayunigari
6d2152fb10 Adding middleware to support EthernetSettings
Adds EthernetInterface class and its unit tests. This class encapsulates
all operations performed on an EthernetInterface. EthernetManager and
ConnectivityManager are its dependencies to execute operations.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:com.android.settings.network.EthernetInterfaceTest

Change-Id: I640a607c8d9705a10dc4c4c609e036a1afa6b5f7
2025-01-25 19:18:50 +00:00
Treehugger Robot
fe44ea6c87 Merge "Add the new Desktop Experience dev options" into main 2025-01-24 16:27:43 -08:00
Matthew DeVore
50cee5bf76 Merge "Show border highlight when dragging display" into main 2025-01-24 14:37:12 -08:00
Matthew DeVore
1fb8fb0b4f Show border highlight when dragging display
In the process of adding highlight we use an extra feature of
LayerDrawable to add insets so that we can add padding without changing
the actual dimensions or position of the DisplayBlock Views.

To make it easier to keep the values consistent and to aid in conversion
between px and dp, use dimen values to store padding and highlight
metrics.

Bug: b/352650922
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: atest DisplayTopologyPreferenceTest.kt
Change-Id: I51ff2ce4a086e84a0c529346f8ede90430090b11
2025-01-23 23:26:53 -06:00
Yiyi Shen
09c8f4fabb Merge "[Audiosharing] add profile service listener when BT just on" into main 2025-01-23 18:23:17 -08:00
Riley Jones
94621548c1 Disabling elements on the A11y Shortcut setting subpage
Elements on the subpage get disabled if there are no enabled shortcut targets for the relevant type.
In the case of A11y button, the items on its fragment become unsearchable when the setting is disabled.

Test: Manually verify conditions described above & in bug
Bug: 349180207
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Id39e2eda6c9d1de4cdbfcbc22b8a1f443e2822d9
2025-01-24 00:59:25 +00:00
Pierre Barbier de Reuille
8a42cd7171 Add the new Desktop Experience dev options
This option, when available, replaces the enable freeform ones.

Bug: 390625230
Bug: 389092752
Test: atest DesktopExperiencePreferenceControllerTest
Test: atest DesktopModeSecondaryDisplayPreferenceControllerTest
Test: atest DesktopModePreferenceControllerTest
Test: atest FreeformWindowsPreferenceControllerTest
Flag: com.android.window.flags.show_desktop_experience_dev_option
Change-Id: Ib2eaa99fab1fbcae6ed9afa997cfe92676a75c70
2025-01-23 11:01:11 +00:00
Jacky Wang
7a24cd61ac [Catalyst] Migrate WifiCallingScreen to parameterized screen
Bug: 388420844
Bug: 372732219
Flag: com.android.settings.flags.catalyst_wifi_calling
Test: devtool
Change-Id: I322001acc453eae0d69761f7a585c6f33087ef6a
2025-01-23 17:16:41 +08:00
Yiyi Shen
e9b6016b8d [Audiosharing] add profile service listener when BT just on
If receive BT on while profile service not ready, add profile service
listener and do things, e.g. update preference, when all relative
profile services connected.

Test: atest
Bug: 305620450
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ie56ed70190285785f1750a7cbbb16029b566fcbe
2025-01-23 15:36:48 +08:00
Chelsea Hao
f956509b8c Merge "Show qr code in "Share your audio" dialog" into main 2025-01-22 23:35:39 -08:00
chelseahao
b6ba9c3bbc Show qr code in "Share your audio" dialog
Test: atest
Bug: 381775542
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I6fe339beb50803989d4110fca681e609d2d600c1
2025-01-23 14:23:38 +08:00
Riley Jones
9707e4039f Merge "Cleanup of deprecated A11y settings functions" into main 2025-01-22 10:41:05 -08:00
Will Leshner
f5a840c417 Add "Hub Mode" settings to mobile settings.
Bug: 389782624
Test: atest CommunalPreferenceControllerTest
WhenToDreamPreferenceControllerTest
Flag: com.android.settings.flags.enable_hub_mode_settings_on_mobile

Change-Id: Ic823b43e094722e467bcca5c16fc480af11e2d9e
2025-01-22 10:12:31 -08:00
Vitor Carvalho
4c9232dda4 Merge "Fix ActionDisabledByAdminDialogHelperTest by setting a mock SupervisionManager as system service." into main 2025-01-22 10:07:22 -08:00
Vitor Carvalho
e866c91b84 Fix ActionDisabledByAdminDialogHelperTest by setting a mock SupervisionManager as system service.
A shadow of DPM is automatically added as system service by Robolectric infra. Since SupervisionManager is new, it doesn't have that.

We will consider changing Robolectric to do the same thing when SupervisionManager becomes more stable.

Flag: TEST_ONLY
Bug: 382034839
Test: atest ActionDisabledByAdminDialogHelperTest
Change-Id: I389938df10ce97c563511473b0aeaee52225f419
2025-01-22 16:53:16 +00:00
Chung Tang
bb094b877c Merge "Accommodate BATT protocol modifications." into main 2025-01-22 02:58:57 -08:00
Yiyi Shen
a618a8a241 Merge "[Audiosharing] Move entry preference out of group category" into main 2025-01-22 01:09:08 -08:00