Commit Graph

40654 Commits

Author SHA1 Message Date
Fan Zhang
cbc4218b9b Format data usage and data limit consistently.
The usage formatter's format flag is change to match data limt flag.

Change-Id: I37d3c8c7bc67a918c793f4799e060010d269834d
Fixes: 63581756
Test: robotests
2017-10-11 15:01:10 -07:00
Fan Zhang
da2fadf607 Update suggestion (with button) card's title textAppearance
Bug: 65065268
Test: visual
Change-Id: I41c7494b935b6465fc99a5fe5dec3d501364f017
2017-10-10 18:17:28 -07:00
Fan Zhang
f63ad8f5f8 Refactor status page to DashboardFragment
Change-Id: I7ebf1e39de5b5ac852e375873d6445c4ef9c8c0a
Fixes: 65492237
Test: robotests
2017-10-10 15:51:35 -07:00
TreeHugger Robot
0f3bb0447f Merge "Convert more of StatusFragment to PreferenceControllers" 2017-10-10 21:04:21 +00:00
Jeffrey Huang
f12d7270de Merge "Introduce LogdSizePreferenceControllerV2" 2017-10-10 20:43:24 +00:00
TreeHugger Robot
9249707fc9 Merge "Fix Settings crash when activity is null" 2017-10-10 20:35:48 +00:00
TreeHugger Robot
d2b2d2ae0f Merge "Alphabetically sort special access setting menus." 2017-10-10 18:48:48 +00:00
songkailun
c96eeb279e Fix Settings crash when activity is null
in ManageApplications, if getActivity is null, it will cause crash
because in HelpUtils#prepareHelpMenuItem it will call activity's
getString method.

Test: manual
Change-Id: I4c9cf985e94192a936d195ea4279ec1d0f22eb10
Signed-off-by: songkailun <songkailun@xiaomi.com>
2017-10-10 11:33:14 -07:00
TreeHugger Robot
747215614b Merge "Adds a Util.setSafeIcon() function used to avoid crashes." 2017-10-10 17:39:31 +00:00
Felipe Leme
bd88450183 Adds a Util.setSafeIcon() function used to avoid crashes.
There are many places on Settings that loads an icon provided by an application,
and if the icon is too big it crashes Settings.

This CL creates a helper method used to set an icon in a safe way, and
uses it in a few places (but most likely not all of them).

Bug: 65739885
Test: manual verification with an app providing a 2MB png

Change-Id: Iae2becb6d0ec8893328d9ef1de618f9bd12fa4a0
2017-10-10 08:56:56 -07:00
TreeHugger Robot
68468aa892 Merge "Add left padding to misc pages" 2017-10-10 00:06:14 +00:00
TreeHugger Robot
67430754f0 Merge "Move summary_empty string to settingslib" 2017-10-09 23:34:59 +00:00
jeffreyhuang
cafce68bc2 Introduce LogdSizePreferenceControllerV2
- Create new LogdSizePreferenceControllerV2
 - Deprecate LogdSizePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I4bc03ee8481d01e553b8a4df9f9ec03b53d4eee4
2017-10-09 16:29:15 -07:00
TreeHugger Robot
b1224431fa Merge "Hide default webview app icon in developer options" 2017-10-09 23:26:23 +00:00
TreeHugger Robot
ba7cc4e935 Merge "[Settings]Crashed when 3rd-party app call ZenModeScheduleRuleSettings directly" 2017-10-09 22:54:07 +00:00
Kevin Chyn
0f0ae3426e Merge "Fingerprint enrolling icon should not overlap text" 2017-10-09 22:25:29 +00:00
Fan Zhang
4bc914386b Alphabetically sort special access setting menus.
Change-Id: I8e2a0a37995438edf12367dd27b6d7a65fb704c7
Fixes: 36077121
Test: visual
2017-10-09 15:18:15 -07:00
Fan Zhang
a0450c78eb Add left padding to misc pages
Change-Id: I6349672e92d170564212679d58cdbfe9991005a2
Fixes: 36459450
Test: visual
2017-10-09 15:11:42 -07:00
Fan Zhang
d77ba003bd Hide default webview app icon in developer options
Change-Id: I165d0a079f247a7162b0b94f9c52a343563aa527
Fixes: 65267538
Test: robotests
2017-10-09 14:28:27 -07:00
liurong
20965328db [Settings]Crashed when 3rd-party app call ZenModeScheduleRuleSettings directly
Fix the issue that some 3rd-party apps call ZenModeScheduleRuleSettings directly
without set the extra ConditionProviderService.EXTRA_RULE_ID. It will raise the
exception and make settings crash.

Test: 1. Install the app "QuickShortcutMaker"
      2. Following the steps descripted in the issue:
         https://issuetracker.google.com/issues/37977351
      3. make ROBOTEST_FILTER="(ZenModeScheduleRuleSettingsTest)" RunSettingsRoboTests

Change-Id: Ia7de0e691eef6d0da26e629ff0c6af7006757623
Signed-off-by: liurong <liurong@xiaomi.com>
2017-10-09 14:12:17 -07:00
Jeffrey Huang
e2fc925bb3 Merge changes from topics "RefactorDevControllers", "MoveDevOptionPrefCtrl"
* changes:
  Refactor AdbPreferenceController
  Move DevOptionsPrefCtrl to SettingsLib
2017-10-09 21:09:54 +00:00
Fan Zhang
52e39240e8 Move summary_empty string to settingslib
Bug: 65612375
Test: rebuild
Change-Id: Ib55e66c02267b9419e92885973e0d9e3287959b7
2017-10-09 13:53:45 -07:00
Kevin Chyn
caa78af159 Fingerprint enrolling icon should not overlap text
Fixes: 67369609

Test: manual test of enrolling with combinations of multi-window
      and text/display sizes

Change-Id: I163af87c69a51b0c91778611afa9e80960231c6a
2017-10-09 12:03:31 -07:00
jeffreyhuang
fe537c8d84 Refactor AdbPreferenceController
- Refactor AdbPreferenceController to use
 AbstractEnableAdbPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If34e2968ff8900276023e12f89d9cc86468adf7a
2017-10-09 11:50:29 -07:00
Tony Mantler
b35a19bce8 Convert more of StatusFragment to PreferenceControllers
Bug: 67410808
Test: RunSettingsRoboTests
Change-Id: Ia79d89d3d3b70bf7af950daa3e588db3f7f597e2
2017-10-09 11:15:58 -07:00
jeffreyhuang
37df3d6d1f Move DevOptionsPrefCtrl to SettingsLib
- Move DeveloperOptionsPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie434d479d8d3f7527ffce54f241ac2e090e0fc44
2017-10-09 10:17:44 -07:00
Bill Yi
b51efdb511 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev am: 6ed9a78922 -s ours
am: e81904ece6  -s ours

Change-Id: Ic638e56f8f312068875245a2074c20c4b25206d5
2017-10-08 07:01:44 +00:00
Bill Yi
e81904ece6 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev
am: 6ed9a78922  -s ours

Change-Id: I1d35b06b119081d46680035c32858572a8acad35
2017-10-08 06:59:18 +00:00
TreeHugger Robot
6ed9a78922 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev 2017-10-08 06:57:28 +00:00
TreeHugger Robot
792ea68baa Merge "Import translations. DO NOT MERGE" 2017-10-08 06:43:56 +00:00
Bill Yi
dbbd311c50 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: I8e31d776f5036724722d7578be51651b5199e419
2017-10-07 19:13:23 -07:00
Bill Yi
ebb2044916 Import translations. DO NOT MERGE
Change-Id: I0867e4dddbb04ecc548a800d511d59aeb1ec7ca7
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
2017-10-07 18:49:24 -07:00
Andrew Sapperstein
52211db347 Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev am: 8bd54d4592
am: 95ebdd359d  -s ours

Change-Id: I21baaf3035fc4efcd9498ed28368da579e24b3f0
2017-10-07 17:10:12 +00:00
Andrew Sapperstein
95ebdd359d Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev
am: 8bd54d4592

Change-Id: If099f1d66dcb83817d5b6c3e22d4ca3e550d5e71
2017-10-07 17:06:15 +00:00
TreeHugger Robot
8bd54d4592 Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev 2017-10-07 17:03:32 +00:00
Andrew Sapperstein
f59cbb143c Update wakeup anomaly to exclude blacklisted wakeups.
Also disables all anomalies out of the box.

Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.

Change-Id: I038ca966aed5a030853b4786bc201397bf4f9b70
Merged-In: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
2017-10-06 21:01:21 -07:00
TreeHugger Robot
88a2ed1954 Merge "Update wakeup anomaly to exclude blacklisted wakeups." 2017-10-07 00:08:25 +00:00
Andrew Sapperstein
e063427d0b Update wakeup anomaly to exclude blacklisted wakeups.
Also disables all anomalies out of the box.

Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.

Change-Id: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
2017-10-06 15:10:38 -07:00
TreeHugger Robot
e02079b12f Merge "Fix a grammar issue in string" 2017-10-06 20:51:33 +00:00
Eric Schwarzenbach
e567432b35 Merge "Fix "Add Network" button on SavedAccessPoints page." into oc-mr1-dev am: 85d5d62716
am: 47e2bad574  -s ours

Change-Id: Iebd83628f4aaac64b18e18434c84304f89076e09
2017-10-06 20:02:43 +00:00
Eric Schwarzenbach
47e2bad574 Merge "Fix "Add Network" button on SavedAccessPoints page." into oc-mr1-dev
am: 85d5d62716

Change-Id: I1cf1ab0db44816d6fe00bcde1df4da5be006119e
2017-10-06 19:19:27 +00:00
TreeHugger Robot
85d5d62716 Merge "Fix "Add Network" button on SavedAccessPoints page." into oc-mr1-dev 2017-10-06 19:10:57 +00:00
TreeHugger Robot
aa410eba1d Merge "Log cleanup: remove unnecessary logging for suggestions" 2017-10-06 18:45:58 +00:00
Fan Zhang
4f4f91ee28 Fix a grammar issue in string
Change-Id: I7ecaefc69d57d07061c6f01359ea6680b64633c3
Fixes: 67415408
Test: visual
2017-10-06 11:39:44 -07:00
Doris Ling
f9d25494ad Add space around the data usage warning spinner. am: de603ea469
am: f6094b6964

Change-Id: Id38553ad316a99eba4d04654629cbe4741dec2e3
2017-10-06 17:28:04 +00:00
Doris Ling
f6094b6964 Add space around the data usage warning spinner.
am: de603ea469

Change-Id: I95d0b90b7bc44a06ee6d30ec173cfcbf1496cd1f
2017-10-06 17:25:29 +00:00
Jeffrey Huang
58b41c4051 Merge "Introduce SelectUsbConfigPreferenceController" 2017-10-06 16:40:21 +00:00
TreeHugger Robot
80fd58e3b6 Merge "Support suggestion UI card with a button." 2017-10-06 03:46:21 +00:00
Fan Zhang
13ce220807 Log cleanup: remove unnecessary logging for suggestions
- Remove show_suggestion logging in DashboardAdapater. Showing
  suggestion is logged inside SuggestionAdapter during onBind.
- Remove hide_suggestion logging. It's not used by anyone.
- Move SuggestionLogHelper into SuggestionFeatureProvider

Bug: 65065268
Test: robotests
Change-Id: I1e7929d739b79527d2ae01c25177676f6be6ddff
2017-10-05 18:23:57 -07:00
jeffreyhuang
33b8f3e6f8 Introduce SelectUsbConfigPreferenceController
- Create new SelectUsbConfigController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I8d6b4eb2e8a90adb7f8bdf4aeec0f5929e8165b2
2017-10-05 17:05:56 -07:00