Commit Graph

4445 Commits

Author SHA1 Message Date
Edgar Wang
610538e10b Merge "Enable hyphenation on most of preference." into tm-dev 2022-05-30 04:00:19 +00:00
Chaohui Wang
bd369cfee5 Fix Conversation page flickers
In this page, 3 conversation lists are implemented by the
ConversationListPreferenceController, these lists updates its contents
in updateState(), which is after the preference screen view created.
So when the first time this page is showed, animations of added contents
will be shown.

The improvement is when the first time, update the list in the
onCreate(), which is called before view creation, instead of the
updateState().

And also do the same thing for RecentConversationsPreferenceController.

Also, to reduce latency,
1. Because currently there are duplicated calls in
NoConversationsPreferenceController to check whether conversations are
exists or not, by removing the duplicated calls and reuse the result
from other controllers, the latency could be reduced.
2. Currently, there are seperated api calls, the
mBackend.getConversations(false) in AllConversationsPreferenceController
and the mBackend.getConversations(true) in
PriorityConversationsPreferenceController, use one
mBackend.getConversations(false) in ConversationListSettings to improve,
this does not change the behavior because the result is filtered in
matchesFilter() both before and after.
3. Currently, we sort conversations first then filter them, change to
filter first then sort to reduce latency.

Fix: 215073227
Test: visual check & robo tests
Change-Id: I028a7fabbbf64cf5627e6615372282a36eb784e5
2022-05-25 10:43:16 +08:00
Binyi Wu
26e5e919c8 Prevent keyboard from blocking the input box for WiFi configuration page.
Bug: 223980567
Test: manual
Change-Id: I2b95b065394e2395396ff71b00bd949ac824dac3
2022-05-24 12:50:41 +08:00
Edgar Wang
353ce6f4e9 Enable hyphenation on most of preference.
Bug: 217659992
Bug: 231924943
Test: manual
Change-Id: I1039fbc6c0573c8ce533594a039579b4c8b00e52
2022-05-24 04:27:43 +00:00
Jason Chiu
44aab7c55f Merge "Refine the homepage app bar layout" into tm-dev 2022-05-16 02:01:20 +00:00
Zoey Chen
8045522453 Merge "[Le Audio] Move BT QR code scanner from Settingslibs to Settings" into tm-dev 2022-05-13 10:27:42 +00:00
Jason Chiu
8847c3186a Refine the homepage app bar layout
- Polish the app bar mask on homepage
- Move the Suggestion card to the position below the search box

Fix: 224435133
Fix: 230284145
Test: robotest, visual

Change-Id: I0a4fd86230fb773a28ca1d9799f3c631a81a11cb
2022-05-13 09:37:00 +00:00
Bonian Chen
5c71853bd9 [Settings] Expand scrollable area of Wifi calling UI
1. Replace InstrumentedDialogFragment by SettingsPreferenceFragment.
   Enable the capability of shirnking the size of title.
2. Move switch bar into Preference.
   Enlarge scrollable area within this UI page.

Bug: 224661026
Test: local
Change-Id: I6e0a491721e9f93858c389593b2bb891f6fa8f8d
2022-05-13 09:18:32 +08:00
Zoey Chen
4b345980c3 [Le Audio] Move BT QR code scanner from Settingslibs to Settings
Systemui memory regression, so we have to move the qr code activity back to Settings

Bug: 228031398
Test: manual
Change-Id: Ic30291e6d752c6c770c40e1329d9f95ceec8cca6
2022-05-12 15:23:22 +00:00
Chaohui Wang
1107c1c220 Merge "Fix Voice Access scroll down in the Add network" into tm-dev 2022-05-10 04:15:07 +00:00
Chaohui Wang
fe0c66dc78 Merge "Improve Talkback for user select dialog" into tm-dev 2022-05-09 03:56:33 +00:00
Milton Wu
887d590e85 Merge "Update SUW biometric string product" into tm-dev 2022-05-07 01:27:27 +00:00
Milton Wu
2cb52b2353 Update SUW biometric string product
Fingerprint strings for SUW is not consider product. Update string to
use 3 different products. They are tablet, device, and default.

Bug: 228021544
Test: Check SUW fingerprint string in tabet and phone
Change-Id: I728f52360e0c7e4972190caf47bea75a64f873ec
2022-05-06 09:59:26 +08:00
Jonathan Scott
b7f4f56cad Add missing settings strings.
Also re-enable and fix tests.

Test: manual
Fixes: 226183482
Fixes: 218799125
Fixes: 219375624

Change-Id: I9605f1f4e2e834baf63e015e96639567c5481b5f
2022-05-05 09:12:59 +00:00
Chaohui Wang
7e47784da1 Fix Voice Access scroll down in the Add network
Use single NestedScrollView instead of ScrollView + NestedScrollView.

This also improve the scroll experience when the accessibility service
is off.

Bug: 216573764
Test: manual test when Voice Access on
Change-Id: I9395c1749c9f49086a979057f7ea2f0cda857993
2022-05-05 16:31:08 +08:00
SongFerngWang
1709c80eff [LE broadcast sink] Add the source list in boradcast sink UI.
Add the source list in boradcast sink UI.
Add the password dialog.

hsv link1: https://hsv.googleplex.com/6256032201310208
hsv link2: https://hsv.googleplex.com/5934966820044800
hsv link3: https://hsv.googleplex.com/6238095344140288
Bug: 228258236
Test: manual test

Change-Id: I698c2f7aba9baa9f143a98629b8796eda57fb379
2022-05-05 06:00:45 +00:00
Chaohui Wang
22cda47705 Merge "Fix a11y label for LE Audio Battery" into tm-dev 2022-05-04 08:28:00 +00:00
Chaohui Wang
122d28ea09 Merge "Fix first item not a11y focusable in SimListDialog" into tm-dev 2022-05-04 06:37:25 +00:00
Chaohui Wang
ca4920090f Fix a11y label for LE Audio Battery
Before fix, "Left" & "Right" are in the same LinearLayout, not grouped
with battery info.

After fix, "Left" & "100% battery" are grouped together.

Bug: 229042138
Test: manual test when Talkback enabled
Change-Id: Ieb35ef992f62040f14ed878515d63f6edb2559f6
2022-05-04 14:17:26 +08:00
PETER LIANG
3ba4d5876d Merge "Fix that ripple effect of level buttons for adjusting font/display size doesn't fit the shape." into tm-dev 2022-05-04 04:10:05 +00:00
Chaohui Wang
cf81f94e3b Improve Talkback for user select dialog
Before this fix,
Both the list item and button are focusable by Talkback, and the list
item one is ok ("Personal, one of two."), the button one is read as
"Unlabeled".

After this fix,
Only the button is focusable by Talkback, read as "Personal, in list, 2
items."

Also test to make sure Switch Access not break.

Bug: 174626616
Test: manual test when Talkback / Switch Access enabled
Change-Id: I72765c1bcbb75e544d5829b21c3e2baf4355be1f
2022-05-03 19:02:21 +08:00
Chaohui Wang
91fd88a519 Fix first item not a11y focusable in SimListDialog
The root cause is there is a logic to get LayoutParams from parent, but
set to child, which cause some chaos.

This dialog can be started with
`adb shell am start -n com.android.settings/.sim.SimDialogActivity --ei
dialog_type 0`

Bug: 227418839
Test: manual test when Talkback enabled
Change-Id: Ia1014dea49cb5cf372afe5bb50972277309c7f63
2022-05-01 09:28:20 +08:00
Peter_Liang
2bb9cac5f0 Fix that ripple effect of level buttons for adjusting font/display size doesn't fit the shape.
Root cause: Ripple effect of lower view was clipped by the upper layout.

Solution: Add the android:clipChildren="false" into the upper layout.

Bug: 230564860
Test: manual test
Change-Id: Iaa764ced9e33a7a2acd5cc0401e5014184c49cdb
2022-04-30 14:45:01 +08:00
Edgar Wang
963f1a0051 Revert "Update data_usage_bytes_editor spinner background"
This reverts commit 18f8850521.

Reason for revert: the sysmptom fixed in SettingsSpinner side now.

Test: visual verify on the latest build
Change-Id: I683172a72597deaeb40b8facb6bd0a6cce2b9231
2022-04-28 20:46:00 +08:00
Kweku Adams
d7189cc7ce Make final factors configurable.
1. Add configuration support for the ongoing rewards (that are normally
   less than 1 ARC).
2. Fix key/configuration of instant rewards
3. Fix UI string issue

Bug: 158300259
Bug: 189850067
Bug: 191876714
Bug: 191877052
Test: Use UI to change factors. Check Settings via adb and TARE dumpsys
Change-Id: I571e188faa6915ea74826b725c9883a825ab152a
2022-04-27 17:57:01 +00:00
TreeHugger Robot
9fd4377ddb Merge "Make the checkbox item large enough to click." into tm-dev 2022-04-27 13:51:14 +00:00
Sunny Shao
d790fa2800 Fix collapsing toolbar can't collapse problem
- Use the NestedScrollView instead of ScrollView.

Fixes: 216276444
Test: manual test
Change-Id: I3872bcc2f165ba8cf55f1782aa76f59adde5d3aa
2022-04-27 15:51:45 +08:00
Angela Wang
11dc02d115 Make the checkbox item large enough to click.
When checkbox display contents in a single line, the clickable area is
less than 48dp and making it hard to click. Setting the minimum height to 48dp can ensure the clickable area is large enough.

Bug: 226538268
Test: manual test
Change-Id: I341455bc98415bfe9292ff5ba4cf6c2153d487d7
2022-04-27 06:30:59 +00:00
Chaohui Wang
f250493787 Update Personal / work selection UI.
Implement the new-look by using AlertDialog's
custom title and custom view.
Using the RecyclerView so we can display profile
horizontally.

Bug: 174626616
Test: manual & robolectric
Change-Id: I9f5a7685d9217fc62e01799ad73f9b9a3ddbf19a
2022-04-25 19:12:38 +08:00
Peter_Liang
7f67e278ca Fine-tune the location and style of the reset button in the “Display size and text” page.
Bug: 222419452
Test: manual test
Change-Id: I9099f13c715ce29cce8d52f6ca9cc47a4fa22306
2022-04-21 17:09:10 +08:00
PETER LIANG
e774a70cba Merge "Prevent cutting the thumb of the LabeledSeekBarPreference from different themes." into tm-dev 2022-04-21 01:35:25 +00:00
Bill Lin
426f8a58e1 Merge "Set IME_FLAG_NO_EXTRACT_UI for ImeAwareEditText" into tm-dev 2022-04-20 06:17:35 +00:00
Peter_Liang
3954a79773 Prevent cutting the thumb of the LabeledSeekBarPreference from different themes.
Add the attribute “clipChildren” as false to avoid cutting.

Bug: 219415822
Test: manual test
Change-Id: I0c565896279111e65600d1b41c576106a8de7136
2022-04-20 13:18:56 +08:00
lbill
6a45659d7b Set IME_FLAG_NO_EXTRACT_UI for ImeAwareEditText
Without IME_FLAG_NO_EXTRACT_UI, device launch ChooseLockPassword
in some cases, mPasswordEntry will go to extrac UI which is
not compliance UI/UX design.

Test: make and check visual of com.android.settings.password
      ChooseLockPassword & SetupChooseLockPassword activities.
Bug: 222219535
Change-Id: I19777954b5edbc9064a8e930b84d2b4e8337c34a
2022-04-20 09:22:14 +08:00
Bill Lin
dc9df4db50 Merge "Remove redundant margin from SudContentFrame" into tm-dev 2022-04-20 01:15:18 +00:00
Bill Lin
f5496a99cd Remove redundant margin from SudContentFrame
Test: make and diff screen
Bug: 229197953
Change-Id: I8d4de113ba69ee72b0eb36ad95ae395afa6eab11
2022-04-18 17:47:50 +08:00
Edgar Wang
4dc79d92f0 Merge "Adjust the padding between profile tab and app filter spinner" into tm-dev 2022-04-18 06:45:02 +00:00
Edgar Wang
ca7f11d965 Adjust the padding between profile tab and app filter spinner
Bug: 223952727
Test: visual
Change-Id: I88411d554975953d29a24a88b6cf948f7f6d7ac8
2022-04-18 12:48:35 +08:00
TreeHugger Robot
36414eab28 Merge "Remove singeLine attribute in the usage chart divider" into tm-dev 2022-04-15 11:47:55 +00:00
ykhung
e431df2036 Remove singeLine attribute in the usage chart divider
Remove the android:singleLine attribute in the expand divider layout to support other language to avoid the content is truncated.
old screenshot: https://screenshot.googleplex.com/7JCnrQAXJM8zjMM

Bug: 229265247
Test: N/A
Change-Id: I9038e69a9ab035b4e0599ca20e11fbccd471f76f
2022-04-15 07:00:57 +00:00
Chaohui Wang
3ce806d870 Fix scrolling position not kept in Trusted Credentials
For example when changing display states.

Save view states to solve this issue.
 - Save current tab. (System / User)
 - Save group expanded state. (Personal / Work)
 - Save scrolling position of each group.

Also updated to ViewPager2 and updated the styles.

Bug: 204839552
Test: manual
Change-Id: Ibeda50b50e7dfd2ba071b75fe2aa88ef560f4c88
2022-04-15 10:12:36 +08:00
Lucas Silva
b31dbbb1cf Merge "Add hyphenation to customize button text." into tm-dev 2022-04-14 17:39:13 +00:00
TreeHugger Robot
37c2ac2c6a Merge "Add 2 pixels to top of Advanced Options component" into tm-dev 2022-04-14 16:28:11 +00:00
Lucas Silva
1ccbf8b7d5 Add hyphenation to customize button text.
In some languages, customize may be a long word which doesn't fit in a
single line and should be hyphenated.

Bug: 228329886
Test: locally on device
Change-Id: Ibf647fc4c18b3eb927f2b6f6ca018f2b38e6f7b1
2022-04-14 14:48:14 +00:00
tom hsu
5281736004 [Panlingual] Add a description for per app language.
- This is to notify some app may not support to user.

Bug: 228415129
Test: local
Change-Id: I6205e0b5fdb3ee42a22ae4995c99e9d8dc5e0a2d
2022-04-14 06:47:13 +00:00
Weng Su
fe4fcb4019 Add 2 pixels to top of Advanced Options component
- Hide the edges of text appearing as a quick fix suggested by the UX
  team.

- See the result screenshot in b/218307103#comment18

Bug: 218307103
Test: manual test by pixel device
Change-Id: I11bfdf57ff4d57786e40f49ad747a35efe2bb207
2022-04-14 03:37:06 +08:00
Julia Reynolds
b28925ad48 Merge "Fix some history issues" into tm-dev 2022-04-12 17:39:55 +00:00
Julia Reynolds
4d46dddbe7 Fix some history issues
- Work profile notifs not showing
- Work profile icon is too big

Fixes: 228397748
atest: manually view work profile notifs in history
Change-Id: I76f7ad37bcfcf4ee7c909516f456920b7e19c541
2022-04-12 11:14:30 -04:00
Betty Chang
6ebed73fbe Merge "[LE Audio] Broadcast Sink UI" into tm-dev 2022-04-11 13:57:52 +00:00
changbetty
a56e198c61 [LE Audio] Broadcast Sink UI
- Add dialog for Broadcast and find broadcast source

 - Add Activity for find broadcast source

Bug: 228274114
Test: Manual test
Change-Id: I830efc3514fc42aaa4e53f491ed3a7459bd9bb41
2022-04-11 08:15:10 +00:00