PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix first item not a11y focusable in SimListDialog

Browse Source 
The root cause is there is a logic to get LayoutParams from parent, but
set to child, which cause some chaos.

This dialog can be started with
`adb shell am start -n com.android.settings/.sim.SimDialogActivity --ei
dialog_type 0`

Bug: 227418839
Test: manual test when Talkback enabled
Change-Id: Ia1014dea49cb5cf372afe5bb50972277309c7f63
This commit is contained in:
Chaohui Wang
2022-05-01 09:26:27 +08:00
parent 8f463f5c88
commit 91fd88a519
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
res/layout/sim_confirm_dialog_multiple_enabled_profiles_supported.xml
View File

@@ -38,6 +38,8 @@
android:background="@drawable/sim_confirm_dialog_rounded_bg"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/sims_select_margin_top"
android:layout_marginBottom="@dimen/sims_select_margin_bottom"
android:visibility="gone"/>
<LinearLayout

10
src/com/android/settings/sim/SimListDialogFragment.java
View File

@@ -216,16 +216,6 @@ public class SimListDialogFragment extends SimDialogFragment {
final TextView title = convertView.findViewById(R.id.title);
final TextView summary = convertView.findViewById(R.id.summary);
ViewGroup.MarginLayoutParams lp =
(ViewGroup.MarginLayoutParams) parent.getLayoutParams();
if (lp != null) {
lp.setMargins(0, mContext.getResources().getDimensionPixelSize(
R.dimen.sims_select_margin_top), 0,
mContext.getResources().getDimensionPixelSize(
R.dimen.sims_select_margin_bottom));
convertView.setLayoutParams(lp);
}
if (sub == null) {
if (position == 0) {
title.setText(R.string.sim_calls_ask_first_prefs_title);