Commit Graph

44631 Commits

Author SHA1 Message Date
Fan Zhang
c7e36d940d Merge "Use proper icon size for default app prefs." into pi-dev am: 968dcaf41a
am: d45b7cbe40

Change-Id: I0f77ebaeb861fd4a15ec31abb1d6728b5dde1788
2018-04-09 12:45:56 -07:00
HJ ChangLiao
47a64c8c33 [automerger skipped] Merge "GesturesSettingPreferenceController to Toggle" into pi-dev am: 283ac08e86
am: c10ae96139  -s ours

Change-Id: I4b0047ab04c86adac1d75e2c34184c85d3c9c3db
2018-04-09 12:27:07 -07:00
Fan Zhang
d45b7cbe40 Merge "Use proper icon size for default app prefs." into pi-dev
am: 968dcaf41a

Change-Id: I75b3068f415b6d1908e9579ca42a35049425a255
2018-04-09 12:27:02 -07:00
Julia Reynolds
65fe2137d8 Merge "Reorder visual effect fields" into pi-dev am: b90e5aff53
am: 2b5d069d4b

Change-Id: I1e0eac8dfb3f9dde02c29b540af381e45fb10eec
2018-04-09 12:18:36 -07:00
HJ ChangLiao
c10ae96139 Merge "GesturesSettingPreferenceController to Toggle" into pi-dev
am: 283ac08e86

Change-Id: Iff2c0533984a32dbe58e264e85d4ef9380218469
2018-04-09 12:14:53 -07:00
Julia Reynolds
2b5d069d4b Merge "Reorder visual effect fields" into pi-dev
am: b90e5aff53

Change-Id: If43d9c0cee3fc4749e73d0c51efbfbcc80b5998e
2018-04-09 12:10:53 -07:00
Daniel Nishi
df2b3c6d18 Merge "Fix a crash in Storage Settings." into pi-dev am: 4264653952
am: 2e9e429741

Change-Id: If6c37a67c623875735dd90bd8fbc4abfbf5f629d
2018-04-09 12:06:46 -07:00
TreeHugger Robot
968dcaf41a Merge "Use proper icon size for default app prefs." into pi-dev 2018-04-09 19:04:22 +00:00
TreeHugger Robot
283ac08e86 Merge "GesturesSettingPreferenceController to Toggle" into pi-dev 2018-04-09 18:59:44 +00:00
Daniel Nishi
2e9e429741 Merge "Fix a crash in Storage Settings." into pi-dev
am: 4264653952

Change-Id: I49f9ac9c51278265b09bc734d22d732cf1b29ba5
2018-04-09 11:54:44 -07:00
TreeHugger Robot
b90e5aff53 Merge "Reorder visual effect fields" into pi-dev 2018-04-09 18:52:25 +00:00
TreeHugger Robot
4264653952 Merge "Fix a crash in Storage Settings." into pi-dev 2018-04-09 18:40:40 +00:00
Andrew Sapperstein
3dcf1a1e27 Merge "Delete unused query_hint_text string." into pi-dev am: 39d634da53
am: 6b3fbf29bf

Change-Id: I0f70d0b7a23b45788258e32c0769f56e8f4f6dcc
2018-04-09 11:19:43 -07:00
Andrew Sapperstein
26815d38ca Merge "Update inherited actionBarStyle to DeviceDefault." into pi-dev am: fcca962bb7
am: 9acdb356a6

Change-Id: Ie146eb142ea319aabe5ee0d001387540ffd44e52
2018-04-09 11:11:51 -07:00
Andrew Sapperstein
6b3fbf29bf Merge "Delete unused query_hint_text string." into pi-dev
am: 39d634da53

Change-Id: I70b98e3541ab25e4f621f7c4fedfd1255f0b0765
2018-04-09 11:00:59 -07:00
Andrew Sapperstein
9acdb356a6 Merge "Update inherited actionBarStyle to DeviceDefault." into pi-dev
am: fcca962bb7

Change-Id: I6971138729925fb53c661c8cdbe66faa149ae382
2018-04-09 10:52:00 -07:00
Lei Yu
be52a5312a Merge "Add NullPtrCheck when smearing in settings" into pi-dev am: c2ec26b4ac
am: f26e2fda76

Change-Id: I71949412d9b4cf5890833a03a00cd903d0fc5784
2018-04-09 10:42:25 -07:00
TreeHugger Robot
39d634da53 Merge "Delete unused query_hint_text string." into pi-dev 2018-04-09 17:33:50 +00:00
TreeHugger Robot
fcca962bb7 Merge "Update inherited actionBarStyle to DeviceDefault." into pi-dev 2018-04-09 17:33:21 +00:00
Lei Yu
f26e2fda76 Merge "Add NullPtrCheck when smearing in settings" into pi-dev
am: c2ec26b4ac

Change-Id: Icf0eb026ed251b2b0f34ac8e522c37d21667fa15
2018-04-09 10:31:45 -07:00
Fan Zhang
e0d2140256 Use proper icon size for default app prefs.
Change-Id: Ib48c7a546fcd3a3a9e32b7a65cbdadd54721f252
Fixes: 77726902
Test: robotests
2018-04-09 10:29:58 -07:00
Daniel Nishi
f5ba67dc40 Fix a crash in Storage Settings.
This prevents a NullPtrException when the DonutView attempts to shrink
the percentage sign. By gracefully falling back when we don't understand
the percentage sign, we can avoid a crash.

Change-Id: I0b0770ce4b51eb30817dc556636f86476f4cd1bf
Fixes: 77653937
Test: Robotest -- screenshot attached
2018-04-09 10:21:50 -07:00
Lei Yu
c2ec26b4ac Merge "Add NullPtrCheck when smearing in settings" into pi-dev 2018-04-09 17:09:22 +00:00
TreeHugger Robot
00b336bcfb Merge "GesturesSettingPreferenceController to Toggle" 2018-04-09 16:46:57 +00:00
Julia Reynolds
9c3e2f6ceb Reorder visual effect fields
Bug: 77657376
Test: RunSettingsRoboTests
Change-Id: I9f5be8f173d8d987d419f6d444d76d2abe175b4e
2018-04-09 10:18:29 -04:00
Victor Chang
25c0c763e7 Merge "Remove the feature flag and dead code for the old time zone picker" 2018-04-09 12:30:02 +00:00
HJ ChangLiao
3c4c3fc5c7 GesturesSettingPreferenceController to Toggle
Convert GesturesSettingPreferenceController to
TogglePreferenceController,
All of its children need follow the change,
add setter and robotest for them:
AssistGestureSettingsPreferenceController
DoubleTapPowerPreferenceController
DoubleTapScreenPreferenceController
DoubleTwistPreferenceController
PickupGesturePreferenceController
SwipeToNotificationPreferenceController

Change-Id: I792b2d370eea828bf345fb2b1cc3eac260eb66f4
Merged-In: I792b2d370eea828bf345fb2b1cc3eac260eb66f4
Fixes: 74913806
Fixes: 67998110
Fixes: 67998098
Fixes: 67998048
Fixes: 67998069
Fixes: 67997452
Test: make RunSettingsRoboTests
2018-04-09 09:08:41 +00:00
HJ ChangLiao
22f53c0274 GesturesSettingPreferenceController to Toggle
Convert GesturesSettingPreferenceController to
TogglePreferenceController,
All of its children need follow the change,
add setter and robotest for them:
AssistGestureSettingsPreferenceController
DoubleTapPowerPreferenceController
DoubleTapScreenPreferenceController
DoubleTwistPreferenceController
PickupGesturePreferenceController
SwipeToNotificationPreferenceController

Change-Id: I792b2d370eea828bf345fb2b1cc3eac260eb66f4
Fixes: 74913806
Fixes: 67998110
Fixes: 67998098
Fixes: 67998048
Fixes: 67998069
Fixes: 67997452
Test: make RunSettingsRoboTests
2018-04-09 15:27:32 +08:00
John Li
9914ef7635 Move these radio buttons to the left am: 2df5a0b322
am: 5dca83ce24

Change-Id: Ia3ec5eda8cfb59f2d2d97de9d369c180d438490c
2018-04-08 22:45:07 -07:00
John Li
5dca83ce24 Move these radio buttons to the left
am: 2df5a0b322

Change-Id: Ie2513c98c3eac7d9dca7ad64e5a799eacc0799da
2018-04-08 22:39:53 -07:00
John Li
2df5a0b322 Move these radio buttons to the left
Assign new single layout to RadioButtonPreference for w/ or w/o icon
and call setIconSpaceReserved(false) in RadioButtonPreference's
constructor. In case of having icon, calling setIcon() can make
icon_frame visible.

Bug: 70850017
Test: m -j56 SettingsRoboTests RunSettingsRoboTests
Change-Id: I8b35f75b6d8114a5e4c69ec1a3287c55e764ffe0
2018-04-09 12:10:59 +08:00
Erik Kline
d77ac78c37 Display Private DNS status in preference summary am: 85c34077d3
am: 3d5592ad31

Change-Id: I57bbe57fedd650440ca107fd89a51fd0885beadd
2018-04-08 17:11:27 -07:00
Erik Kline
3d5592ad31 Display Private DNS status in preference summary
am: 85c34077d3

Change-Id: I396b196f8f5d6d6b168f168851c828795b2fb5b2
2018-04-08 17:06:39 -07:00
Erik Kline
85c34077d3 Display Private DNS status in preference summary
Also: fix a bug where the actual current mode is not read correctly
from settings on initialization.

Test: as follows
    - built, flashed, booted
    - manual test behaves as expected
    - make -j50 RunSettingsRoboTests ROBOTEST_FILTER=PrivateDnsModeDialogPreferenceTest passes
    - make -j50 RunSettingsRoboTests ROBOTEST_FILTER=PrivateDnsPreferenceControllerTest passes
Bug: 34953048
Bug: 64133961
Change-Id: I0b845b3894a47b837abf5de273d1ada642ef5a23
2018-04-08 15:50:58 -07:00
Andrew Sapperstein
823cd12415 Update inherited actionBarStyle to DeviceDefault.
Was using a Material style. Now it's using the DeviceDefault one that
Theme.DeviceDefault.Settings uses.

Bug: 69314526
Test: visual inspection
Change-Id: I5ce1bbb51a8d067fce226ff4a41fdea64106156a
2018-04-08 12:33:27 -07:00
Andrew Sapperstein
4bd3007865 Delete unused query_hint_text string.
Change-Id: If6378768255c7cac290f914620115bff04c6b281
Fixes: 77772047
Test: compiles
2018-04-08 11:15:03 -07:00
Erik Kline
ef12e2f84e Merge "Fix test expectations for NetworkCallbacks" into pi-dev am: 47c2eebc85
am: 3d6d43663e

Change-Id: Id4f7d846ac723b807ba60e2fbb2ac73ece88bae1
2018-04-06 22:30:15 -07:00
Erik Kline
3d6d43663e Merge "Fix test expectations for NetworkCallbacks" into pi-dev
am: 47c2eebc85

Change-Id: Id9ad03e3df258d4e65a0ee9875499554be7c5cd2
2018-04-06 22:19:21 -07:00
TreeHugger Robot
47c2eebc85 Merge "Fix test expectations for NetworkCallbacks" into pi-dev 2018-04-07 05:06:53 +00:00
Fan Zhang
5bb34f2782 [automerger skipped] Merge "Create help link placeholder for Wifi Direct settings." into pi-dev am: aeb33b72b3
am: 8d3068bf3b  -s ours

Change-Id: I63362a1dc28911c90d52a1e8069783ed4cc1967c
2018-04-06 18:20:23 -07:00
Fan Zhang
8d3068bf3b Merge "Create help link placeholder for Wifi Direct settings." into pi-dev
am: aeb33b72b3

Change-Id: I92c91bfcda90f55312572fa928c04f7ff6f2a70b
2018-04-06 18:12:21 -07:00
TreeHugger Robot
aeb33b72b3 Merge "Create help link placeholder for Wifi Direct settings." into pi-dev 2018-04-07 01:04:52 +00:00
Doris Ling
ac2b789826 Merge "Adjust alignment for suggestion icon." into pi-dev am: 2d925f45b2
am: 137dcb6998

Change-Id: I8b4d9f6c29ea07092f95683d5b076ed0b9046d02
2018-04-06 16:37:03 -07:00
Bill Yi
abdcff575f [automerger skipped] Merge "Import translations. DO NOT MERGE" into pi-dev am: cd986c2c38 -s ours
am: 11c27313e6  -s ours

Change-Id: I9655a38f71906d39ac0b7a05b74f46f87ad8aae1
2018-04-06 16:34:49 -07:00
Matthew Fritze
67bf80c9ab Merge "Prioritize dynamic summaries" into pi-dev am: c29aec4bde
am: bd4ba55cac

Change-Id: I6aaa0f91e91fd0cfe19578935a539393c289d63e
2018-04-06 16:27:35 -07:00
Doris Ling
137dcb6998 Merge "Adjust alignment for suggestion icon." into pi-dev
am: 2d925f45b2

Change-Id: Id29c00047d3a3261f1ef567c56499e44e0973db6
2018-04-06 16:11:48 -07:00
Fan Zhang
0cd2ccfe30 Create help link placeholder for Wifi Direct settings.
Change-Id: Ia22259d191d2663d7ef63438c680826d3fd590fb
Merged-In: Ia22259d191d2663d7ef63438c680826d3fd590fb
Fixes: 70854725
Test: robotests
2018-04-06 23:06:36 +00:00
Doris Ling
2d925f45b2 Merge "Adjust alignment for suggestion icon." into pi-dev 2018-04-06 23:00:30 +00:00
TreeHugger Robot
0391597948 Merge "Create help link placeholder for Wifi Direct settings." 2018-04-06 22:58:31 +00:00
Lei Yu
c5f5b18b22 Add NullPtrCheck when smearing in settings
This only happens in new device with broken power_profile.xml, in
which it doesn't have screen power model.

This CL catches the null pointer crash and log it.

Change-Id: Iac23e3a8fc51385bdb22979c4b59000319f6fd49
Fixes: 74617269
Test: RunSettingsRoboTests
2018-04-06 15:57:44 -07:00