Commit Graph

141419 Commits

Author SHA1 Message Date
Treehugger Robot
aa8b66f3ad Merge "Avoid flakiness SLO" into main 2024-10-23 08:13:58 +00:00
Treehugger Robot
e56d23c121 Merge "Remove dependencies on the 1-variant fallback" into main 2024-10-23 02:06:03 +00:00
Cole Faust
66c5be9fdf Remove dependencies on the 1-variant fallback
When adding a dependencies, if the variants don't match, but the
dependency only has 1 variant anyways, soong will always use that
variant. This makes it hard to add new variants to soong, because the
1-variant fallback stops being used and you start getting missing
variant errors. Make changes to bp files such that all dependencies
correctly specify the variant to use.

Bug: 372091092
Flag: EXEMPT refactor
Test: m nothing
Change-Id: I8487eff4de7349c922901160f55717e7d3296650
2024-10-22 16:30:59 -07:00
Treehugger Robot
c3ea626cd3 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-22 09:51:08 +00:00
hoffc
a9002d157c Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Do not call scan callback if network select activity is finishing or destroyed.

Test: build pass and run NetworkSelectSettingsTest unit test pass.

Bug: 372123288
Change-Id: I28307490c75fe04d54dcf1637f33f4b9ba1fe635
2024-10-22 06:25:37 +00:00
Pechetty Sravani (xWF)
0583090e98 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main 2024-10-21 09:49:30 +00:00
Pechetty Sravani (xWF)
bd44c86041 Revert "Fix force close for updating UI after activity destroyed."
This reverts commit 2545f06558.

Reason for revert: DroidMonitor created revert due  to b/374650528.Will be verified through ABTD for standard investigation.

Change-Id: Ifa3f061b7954dc2b5780b768fefb9358c597fdc0
2024-10-21 06:18:31 +00:00
Treehugger Robot
b083196e76 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-21 04:11:01 +00:00
Treehugger Robot
f233e50766 Merge "Fix BatterySaverScheduleRadioButtonsControllerTest" into main 2024-10-20 11:57:37 +00:00
YK Hung
cb2e1bdabb Fix BatterySaverScheduleRadioButtonsControllerTest
Test was failing because it was not setting the EXTRA_LOW_POWER_WARNING_ACKNOWLEDGED setting.

Change-Id: Id9e95c0240908dafbaa791e7f4f4b9ded9d39d9b
Test: atest BatterySaverScheduleRadioButtonsControllerTest
Bug: 370883745
Fix: 370883745
Flag: EXEMPT for simple bug fix
2024-10-20 02:11:54 +00:00
tomhsu
3f4cf24ad3 Avoid flakiness SLO
Flag: EXEMPT bugfix
Fix: b/365673174
Test: atest pass
Change-Id: If27c4ca7f8dfd1a0670962b5dba1c42303caccce
2024-10-18 07:16:36 +00:00
Jaewan Kim
fcc6b6ce7c Merge "Enable Linux terminal app via developer settings" into main 2024-10-16 23:23:29 +00:00
Jaewan Kim
591d4fd932 Enable Linux terminal app via developer settings
Bug: 369246712
Test: `atest SettingsRoboTests`, try toggle the option, \
  and try search with 'Linux'.
Flag: RELEASE_AVF_SUPPORT_CUSTOM_VM_WITH_PARAVIRTUALIZED_DEVICES
Change-Id: Ibdcf00de04f09fe5b03ba53857904945354ed844
2024-10-16 15:49:12 +00:00
Treehugger Robot
71c59bae9c Merge "Add MaterialComponents.DayNight to SearchBarStyle" into main 2024-10-16 06:51:55 +00:00
Robin Vinterbladh
dc419524c5 Add MaterialComponents.DayNight to SearchBarStyle
When opening the Settings app or changing colors in ThemePicker
there are tons of warnings with UnsupportedOperationException in
the log. These logs are related to the
LayoutInflater attempting to inflate a MaterialCardView and
TypedArray#getColor where it expects the colors to be either an integer
color or a color state list. This happens every time you re-start
Settings.

To enable layout inflater finding colors for Settings we add a
MaterialComponents theme to SearchBarStyle, this makes sure that
TypedArray#getColor gets an integer color instead of relying on
framework to solve this.

Flag: NA
Bug: 363970601
Test: manual, open Settings and check the logs
Change-Id: I728c1537537bb4d32af6006800de93e64facfa8e
2024-10-16 01:05:12 +00:00
Tom Hsu
ec571901be Merge "Avoid test flaky" into main 2024-10-14 04:13:25 +00:00
Tom Hsu
9832fe9281 Avoid test flaky
flag: EXEMPT bugfix
fix: 365673174
Test: atest passed
Change-Id: Id7c3747eafff3410ab899716d0c6e35eb405c76e
Merged-In: Id1290e6979fdafa93ded6f50e49d6b3464a80b50
2024-10-11 05:15:14 +00:00
hoffc
2545f06558 Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Directly return if network select activity is finishing or destroyed when handling network scan callback.

Bug: 372123288
Change-Id: Ia8c89569761b66da58cafd0140ceda29ac7d678c
2024-10-08 17:29:45 +08:00
Paul Duffin
e61c03648d Merge "Fully qualify @attr reference to android.R field" into main 2024-10-08 08:31:47 +00:00
Treehugger Robot
28f83ffab0 Merge "Fixes for errorprone update" into main 2024-10-07 20:25:20 +00:00
Cole Faust
b237fe7e6a Fixes for errorprone update
When updating errorprone from 2.23.0 -> 2.32.0, more issues are found.

Bug: 253827323
Flag: EXEMPT refactor
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Iebb442f5e616861d1f2a2e2dc56a8ac72b18cb95
2024-10-07 11:27:07 -07:00
Paul Duffin
ad48f03f53 Fully qualify @attr reference to android.R field
Currently, Metalava has some special handling of '@attr ref R.<field>`
references to make sure that they are fully qualified, i.e.
`@attr ref android.R.<field>`. That special handling complicates
Metalava and is blocking some flagged API work so will be removed.
Before that can be done, the existing incorrect documentation needs to
be cleaned up.

This change cleans up those cases in this repo.

Bug: 371997321
Test: Run `m offline-sdk-docs` before and after to make sure that
      there are no differences.
Flag: DOCS_ONLY
Change-Id: Ic97f01b90193d058d65e6d3c6d0a04ce5e55d7c7
2024-10-07 17:10:02 +01:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
Treehugger Robot
12f2e1cf4f Merge "Use hasScrollAction in ApnEditPageProviderTest" into main 2024-09-26 10:54:50 +00:00
Treehugger Robot
6a4fb45e38 Merge "Protect the Settings application from potential null pointer exceptions." into main 2024-09-26 10:30:43 +00:00
Chaohui Wang
bb1cadb916 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0b530fd405eb95dfedf51bc55bc24bd7d446ead8)
Merged-In: I0a50e7665d9049e089b5a0877f17d1f736ee3332
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-26 10:20:38 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Treehugger Robot
fdbd2d1090 Merge "Fix errorprone issues" into main 2024-09-17 21:38:22 +00:00
Cole Faust
784411fc25 Fix errorprone issues
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I9975c8689c9d673d0b676c60d68ccec1953470f8
Merged-In: Ia0e16b8be5284d13bed4366cbee0f92748bf2f85
2024-09-17 14:08:00 -07:00
Bill Yi
feee29caf8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-11 22:30:21 +00:00
Bill Yi
110375b901 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-11 22:30:21 +00:00
Bill Yi
ce0fa685e4 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-11 22:30:21 +00:00
Bill Yi
65d9c39a51 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If28bc3a57b9e98862b7f7fd5bc57167171e6009d
2024-09-11 12:07:00 -07:00
Bill Yi
905e347339 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9205a5ec80240c5ca11946c6e03b4b0e11769c83
2024-09-11 12:05:13 -07:00
Bill Yi
730b913bc6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I40a62c487bc7916eac67a878a59ce68a2139c694
2024-09-11 12:03:50 -07:00
Treehugger Robot
eb2e9e4776 Merge "Fix errorprone issues" into main 2024-09-11 18:08:19 +00:00
Treehugger Robot
dd578b8274 Merge "Make java_sdk_library dependencies explicit" into main 2024-09-11 17:58:59 +00:00
Jihoon Kang
4ae6ead8d6 Make java_sdk_library dependencies explicit
modules should specify the submodule of java_sdk_library that the module
actually depends on

Test: CI
Bug: 358613520
Merged-In: I78dec317d4e74275287e3a5b7f5ffe2b10db05ab
Change-Id: I78dec317d4e74275287e3a5b7f5ffe2b10db05ab
2024-09-10 22:43:05 +00:00
Chun-Wei Wang
88bbe8fe1d Merge "Support alternate button" into main 2024-09-09 14:18:11 +00:00
Xin Li
3efb972a55 Merge "Merge 24Q3 to AOSP main" into main 2024-09-07 01:12:23 +00:00
Cole Faust
9b89e3d643 Fix errorprone issues
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: Ib0a0335aa04b36924adcbfecc830b7392c0e5bec
2024-09-06 13:34:50 -07:00
Xin Li
b3356e7c02 Merge 24Q3 to AOSP main
Bug: 357762254
Merged-In: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
Change-Id: I26d001b3394eca422bbfd66e36f4456d898e7500
2024-09-05 17:02:57 -07:00
Treehugger Robot
96fcc4903b Merge "bluetooth: Refactor BT Audio Codec list" into main am: 7c9f1454da
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241342

Change-Id: I87e97131d3361224aa898838bf6c04308d95bd28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-28 07:23:17 +00:00
Treehugger Robot
7c9f1454da Merge "bluetooth: Refactor BT Audio Codec list" into main 2024-08-28 07:12:30 +00:00
Jakub Rotkiewicz (xWF)
51cac72d94 Merge "bluetooth: Fix Mono/Stereo selection with new codec list" into main am: c640aeeec9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241341

Change-Id: I08cbe0634d9c4926af2d9ac927e81960d966f5bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-27 20:42:02 +00:00
Jakub Rotkiewicz (xWF)
ab1a9a73e9 Merge "bluetooth: remove debug logs guard" into main am: 8b780a831e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241340

Change-Id: Ied02c723be359d7d2873313a05ea9d6c178cd5e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-27 20:41:40 +00:00
Jakub Rotkiewicz (xWF)
c640aeeec9 Merge "bluetooth: Fix Mono/Stereo selection with new codec list" into main 2024-08-27 20:25:46 +00:00
Jakub Rotkiewicz (xWF)
8b780a831e Merge "bluetooth: remove debug logs guard" into main 2024-08-27 20:25:31 +00:00
Jakub Rotkiewicz
97b113a660 bluetooth: Refactor BT Audio Codec list
* Show only selectable codecs to the user
* Removed redundant 'abstract' layer
* Disable codec selection when BluetoothA2dp, active device unavailable
  or HD Audio disabled.

Bug: 329809288
Bug: 346490998
Flag: EXEMPT - refactor
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.BluetoothCodecListPreferenceControllerTest
Merged-In: I56ebfeaf2cfa22ec253db897d7b7e96d1f8eee61
Change-Id: I23714715d9257479f5eac1a172ba1804da7e64e3
2024-08-27 20:15:01 +00:00