Commit Graph

57097 Commits

Author SHA1 Message Date
Sunny Shao
56b7acd49e Fix the NPE in the ScreenPinningSettings
- move mFooterPreference and others init before the SwitchBar

Fixes: 144407413
Test: manual test
Change-Id: I80d86942f35d16e0460c5fa48bb127932d2086a1
2019-11-13 20:35:56 +08:00
Tsung-Mao Fang
6a2d48d158 Ignore all failed test cases
Test: Run all robo test
Bug: 144405844
Bug: 144407418
Bug: 144407438
Fix: 144406422
Bug: 144405885
Bug: 144408475

Change-Id: Ia94636632106206b062d35b2ca53a028d0cbc35d
2019-11-13 20:31:01 +08:00
Alex Johnston
37d975b02f Merge "Fix broken preference controller test" 2019-11-13 11:54:11 +00:00
Yi-Ling Chuang
e786ce000e Fix non responding slice toggling
The issue happens when users are toggling slices. Sometimes the toggle
doesn't work as expected because the pending intent of the toggle action
seems to be canceled for some reasons.

Hence, we replace FLAG_CANCEL_CURRENT with FLAG_UPDATE_CURRENT to
prevent from getting PendingIntent.CancelExcpetion from SliceActionView
when toggling slices.

This change only applies on those auto converted Slices.

Bug: 140719905
Test: toggle slices in Settings Search and NGA
Change-Id: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
Merged-In: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
(cherry picked from commit ddf6cefcac)
2019-11-13 10:30:26 +00:00
Alex Johnston
aa62e5e482 Fix broken preference controller test
This bug was introduced with the work to change certificate installation.
The CA, User and Wi-Fi certificate preferences should always be available
which is why the negative test was failing.

Bug: 144257985
Test: atest com.android.settings.security
Change-Id: Ib4a1880c3b21fa10c77568bc053b67ce4a0bbf85
2019-11-13 10:21:33 +00:00
Raff Tsai
988a912237 Modify preference_list_fragment to support tabLayout
- Remove buttonBar because it is only used in PublicVolumeSettings
- Add tabLayout in preference_list_fragment.xml

Bug: 141601408
Test: manual
Change-Id: Ieb84ccf2e685a03abec7b07cb8f9f4b64ee475e0
2019-11-13 17:37:59 +08:00
Bonian Chen
bb53dd5f93 [Settings] Remove access to getSimOperator() API
Replace getSimOperator() by having SubscriptionInfo
from getAccessibleSubscriptionInfo().

Bug: 144263441
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=ApnEditorTest

Change-Id: I25cc9dc0912564b8d6f8b23b53f3eb20a51eea32
2019-11-13 17:33:08 +08:00
TreeHugger Robot
3af21959b5 Merge "Remove redundant code" 2019-11-13 06:58:46 +00:00
Bonian Chen
63f837e6dc Merge "[Settings] Replace getSimCount() API" 2019-11-13 06:45:55 +00:00
James Mattis
33379b361b Swap param order in registerSoftApCallback
Moving executor to be the first argument in registerSoftApCallback.

Bug: 144379300
Test: Manually on pixel 3

Change-Id: I5563c1059cc04014a0fd909e2508f7bf497d708e
2019-11-12 22:26:33 -08:00
TreeHugger Robot
e75f77d753 Merge "Don't use Lambda when register callback" 2019-11-13 05:08:01 +00:00
Tsung-Mao Fang
31dd22cc4c Remove redundant code
Don't need to define onResume and onPause again.

Test: Rebuild
Change-Id: I470ced021d1ffab13659335b54db0b01b5766940
2019-11-13 12:36:43 +08:00
hughchen
e487b00157 Don't use Lambda when register callback
This CL before, the lambda callback is different it cause
callback didn't unregister.
If you re-enter bluetooth detail page many times,
onDeviceAttributesChanged() will be called many times cause UI not
smooth.

This CL remove the lambda callback and show the UI when device
connected.

Fixes: 141583252
Test: Manual
Change-Id: Icd3e84b2d461d9b949f080269dfa2bb5b5d5cb73
2019-11-13 11:55:32 +08:00
David Su
6d2c28f22a Rename WifiSsid.NONE to WifiManager.UNKNOWN_SSID
Bug: 144311098
Test: compiles
Change-Id: Id75f4f9223142f5184db54a4d380a2967f28469e
2019-11-12 18:56:09 -08:00
Kevin Chang
673b5393a7 [automerger skipped] Merge "Add accessibility timeout video and illustration" am: 1595fc8fc8 am: 95d21e0d44
am: ec6fad2ca2 -s ours
am skip reason: change_id I0e4ba60c934191afbcaddb81e6d07d37244dce64 with SHA1 6838ae7c0b is in history

Change-Id: Idf6348e4304012a6d9ab9911f3cb79229e195093
2019-11-12 17:15:01 -08:00
Kevin Chang
ec6fad2ca2 Merge "Add accessibility timeout video and illustration" am: 1595fc8fc8
am: 95d21e0d44

Change-Id: I888cae4271d525f7cd9a02b9ffb494544409a5c9
2019-11-12 17:11:33 -08:00
Kevin Chang
95d21e0d44 Merge "Add accessibility timeout video and illustration"
am: 1595fc8fc8

Change-Id: Ib1c19cfd318de968cb426e9fb09eb4e4d674a70b
2019-11-12 17:06:59 -08:00
Raff Tsai
d43163d429 Merge "Add a feature flag for controller loading enhancement" 2019-11-13 00:57:50 +00:00
Raff Tsai
a12aa853a7 Merge "Fix PendingIntent CanceledException exception" 2019-11-13 00:55:27 +00:00
Raff Tsai
a19e37a02d Merge "change screen pinning settings UI" 2019-11-13 00:54:42 +00:00
Kevin Chang
1595fc8fc8 Merge "Add accessibility timeout video and illustration" 2019-11-13 00:53:49 +00:00
Sunny Shao
a4d2ab80fa Add a feature flag for controller loading enhancement
Bug: 137558156
Test: manual test
Change-Id: I4f2988ea889735e66bc227bb814707c5b01b770b
2019-11-13 08:47:43 +08:00
Dianne Hackborn
cdbc0dfa6a Rework platform version to hide codenames.
The public platform version no longer can be a codename, it is
always the most recently released platform.  A new build property
and API provides either the offical version or the current codename
as appropriate.  This will avoid breaking apps that look at the
platform version while development is under a codename.

Bug:  143175463
Test: manual
Change-Id: I711ca20c4c8ce389697e940696051a336f5fd808
2019-11-12 15:55:59 -08:00
Bernardo Rufino
f529543d54 Merge "Ignore "package:<package>" in MANAGE_OVERLAY_PERMISSION intent" 2019-11-12 10:03:25 +00:00
Raff Tsai
a1678dade1 Add dynamic injection item to site map
- That will make injection able to build site map

Bug: 143116297
Test: manual
Change-Id: Ic07280519bb7f904a3e80e172b6cb8785b94616f
2019-11-12 17:06:36 +08:00
Jason Chiu
48a0ff4304 Fix Settings creating too many threads unexpectedly
Limit the number of threads by using the shared thread pool in
ThreadUtils.

Bug: 143434413
Test: manual
Change-Id: I4afe1f641a11e218616772c1d5446efcc99cd1cc
Merged-In: I4afe1f641a11e218616772c1d5446efcc99cd1cc
(cherry picked from commit 3e4c47dbc0)
2019-11-12 08:24:10 +00:00
Raff Tsai
d785e78594 Fix PendingIntent CanceledException exception
- b/142107748 has more context

Fixes: 143267879
Test: manual
Change-Id: I3a5446febc09006fd07986c13e0a150cf89e84fd
2019-11-12 16:13:39 +08:00
James Mattis
03d65cee36 Support for hotspot client visibility.
Adding support for visibility into clients that connect to an active hotspot.

Bug: 137309578
Test: Tested manually on a Pixel 3.
Change-Id: Ife4bb5ca7bbcf075683cb0a233f2b5716ccd51d9
Merged-In: Ife4bb5ca7bbcf075683cb0a233f2b5716ccd51d9
2019-11-11 22:30:45 -08:00
Raff Tsai
cd216b1de3 Merge "Sync lastest lifecycle interface" 2019-11-12 03:41:06 +00:00
Raff Tsai
72a65094fc change screen pinning settings UI
Fixes: 144306573
Test: manual
Change-Id: I7c80a17f90ed84e7245fe26c985aa3fe2e71cc8d
2019-11-12 11:33:51 +08:00
TreeHugger Robot
eb3eb1fdb3 Merge "Update text on notification on/off toggles for clarity" 2019-11-11 19:24:42 +00:00
Julia Reynolds
f356ced8d7 Remove filtering from "recent sent" notifs preference
The 'has a launch intent' filter was inherited from 'recent apps'
preference but an app doesn't need a launch intent in order to
send notifications. Also, the next screen didn't apply the filter
so the data wouldn't always match up.

Also make the preferencecontroller more robust to failure.

Test: manual, trigger a notification from a non-launchable app
and makes sure it appears in the list
Fixes: 141380329
Fixes: 142956641

Change-Id: Icf3abead82c572bbffe6e06ecf51a8e02c11c982
2019-11-11 17:38:23 +00:00
Julia Reynolds
78b4505d6e Update text on notification on/off toggles for clarity
Test: manual
Fixes: 141011559
Change-Id: I06b8519bb5a80496d84889f8c5264bff098ebefd
2019-11-11 17:37:45 +00:00
Raff Tsai
16a81eb3f6 Sync lastest lifecycle interface
Bug: 142938506
Test: rebuild
Change-Id: I6a8d75e5a3ba8564cfb400a88d6582c962c965ee
2019-11-11 16:19:07 +08:00
Bonian Chen
31367d7a72 [Settings] Replace getSimCount() API
Change design of monitor change in Settings.Global.MOBILE_DATA and
Settings.Global.DATA_ROAMING in order to avoid from accessing
getSimCount().

Bug: 144251589
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=RoamingPreferenceControllerTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest

Change-Id: I965a0c07c7c9ef5897b33809bae6a7921977db18
2019-11-11 15:27:30 +08:00
Bonian Chen
bfe25c3b29 Merge "[Settings] Apply proxy design to data usage" 2019-11-11 06:33:31 +00:00
Bonian Chen
5e65da0c2f [Settings] Apply proxy design to data usage
Enable proxy to subscription manager in data usage UI.

Bug: 141833767
Test: manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=BillingCyclePreferenceTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=CellDataPreferenceTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageListTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageUtilsTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileDataEnabledListenerTest

Change-Id: Id119738dc16ece8767c088b9a0794997e4b0334f
2019-11-11 13:03:03 +08:00
Bill Yi
be658e94f7 Import translations. DO NOT MERGE
Change-Id: Id91fd596039e71d8e677fa03f66521fd019fa245
Auto-generated-cl: translation import
2019-11-10 01:07:23 -08:00
David Su
d4f077f1e2 Settings: Clean up WifiManager APIs
Promoting WifiManager#registerSoftApCallback() and
WifiManager#registerNetworkRequestMatchCallback()
to @SystemApi.

Changed method signatures to conform to API guidelines.

Also removed dead code: WifiManager#getWifiState()
never returns WifiManager#ERROR.
Remove reference to it, since it is an @hide API.

Bug: 143970861
Test: compiles
Change-Id: If4294d106f0acb5c67b5eab1f6f99bc52efc10f2
2019-11-09 14:54:15 -08:00
Bill Yi
8cac391fb2 [automerger skipped] Import translations. DO NOT MERGE am: 8134971f00 -s ours
am: 9d83dbcd08 -s ours
am skip reason: subject contains skip directive

Change-Id: I577e8bacc6a7778ac741d5a539c3df06589891e3
2019-11-09 07:55:28 -08:00
Bill Yi
9d83dbcd08 [automerger skipped] Import translations. DO NOT MERGE
am: 8134971f00 -s ours
am skip reason: subject contains skip directive

Change-Id: I138449ceec7c49f369cb04853365b071f32e8a64
2019-11-09 07:48:14 -08:00
Bill Yi
8134971f00 Import translations. DO NOT MERGE
Change-Id: I5b9dc323282c81680df423e4df855f9f25e3c028
Auto-generated-cl: translation import
2019-11-08 23:40:50 -08:00
Bernardo Rufino
897a0e0470 Ignore "package:<package>" in MANAGE_OVERLAY_PERMISSION intent
Before this change, intents with action = MANAGE_OVERLAY_PERMISSION and data =
URI "package:<package>" would redirect the user to the specific app screen with
the toggle to grant SYSTEM_ALERT_WINDOW (SAW) permission.

This makes it too easy for malicious apps to fool the user into enabling
it and we know that exist malware attempts to do so.

This CL redirects that intent to the screen that list all the apps
requesting SAW permission, introducing some friction for the user, which
hopefully will allow more time for consideration.

This is consistent with how other access permission intents work.

Test: Working on CTS
Test: adb shell am start -a
      android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:<package>
      goes to list of apps screen
Test: adb shell am start -a android.settings.action.MANAGE_OVERLAY_PERMISSION
      also goes there
Bug: 135920175

Change-Id: I02fb842106602dab7fc285d0741edb58432ac7ad
2019-11-08 16:55:19 +00:00
James Mattis
4a18957c2d SoftApCallback using executor vs handler
Updating classes to support making SoftApCallback methods available to @SystemAPI including
the API for registration of a SoftApCallback which includes a change to
now use executor vs handler.

Bug: 143564153
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherPreferenceControllerTest
Also tested manually on a Hawk.

Change-Id: I952ad10dd88b7d97b3cd86b269b8f67b00b1fa15
2019-11-08 08:44:35 -08:00
Jay Aliomer
b499cc5643 Merge "Don't disable DND permission settings for apps that have disabled NLS" 2019-11-08 16:38:12 +00:00
Jay Aliomer
8754d40124 Don't disable DND permission settings for apps that have disabled NLS
ZenAccessController.getPackagesRequestingNotificationPolicyAccess
was including disabled packages.
We change this behavior to exclude any disabled package

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.applications.specialaccess.zenaccess.ZenAccessControllerTest"
Change-Id: I354b8f0bdbf602d1f35233d5003ce09f01df3cb2
Fix: 141318822
2019-11-08 16:21:15 +00:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
TreeHugger Robot
f9b41559b6 Merge "Use the getBidiFormattedPhoneNumber to replace getFormattedPhoneNumber" 2019-11-08 11:47:21 +00:00
Kevin Chang
6915e6a551 Add accessibility timeout video and illustration
Add the new assets of accessibility timeout.

Bug: 143861394
Test: Visual
Change-Id: I0e4ba60c934191afbcaddb81e6d07d37244dce64
Merged-In: I0e4ba60c934191afbcaddb81e6d07d37244dce64
2019-11-08 19:47:02 +08:00
Sunny Shao
f0771bdbc2 [automerger skipped] Fix the MMS messages toggle preference not working am: b377713547
am: ac3b465e96 -s ours
am skip reason: change_id Ida65d04b095b7d2556fa5bdd93be7a67cba77206 with SHA1 054e0eab87 is in history

Change-Id: I8fbd43096c78d21848e8d7856e44b9590d95f576
2019-11-08 03:01:27 -08:00