Commit Graph

51775 Commits

Author SHA1 Message Date
tmfang
a5be87fad5 Fix overlapping problem in display size screen.
All screen in Settings set clipToPadding to false by default,
so we see this side effect on display size screen.

To fix it, we set clipToPadding and clipChidren to true.

Fixes: 132905691
Test: visual
Change-Id: I58752c0ba7bd033cde97ff6047513a50ab933ae9
2019-05-17 12:04:43 +08:00
Kevin Chang
d0c5f2d443 Merge "Change string of switchbar and installed service category title" into qt-dev 2019-05-15 02:13:09 +00:00
Salvador Martinez
ba5964d99d Merge "Fix dark theme and battery saver interaction" into qt-dev 2019-05-15 01:33:08 +00:00
Lei Yu
6b2030a17a Merge "Use NetworkTemplate to query data" into qt-dev 2019-05-15 00:27:23 +00:00
TreeHugger Robot
17521d0ac7 Merge "Revert "Revert "Make subsettings display edge-to-edge""" into qt-dev 2019-05-15 00:01:30 +00:00
Salvador Martinez
ee5f79edbd Fix dark theme and battery saver interaction
In settings we weren't properly taking into account battery saver
enabled dark theme. This CL makes it so that when battery saver
on we disable the toggle until battery saver is off since
you can't change dark theme in battery saver. Additionally it
adds a message indicating why the toggle was disabled so the
user doesn't get confused.

Test: robotests
Bug: 131913864
Change-Id: I855e429a666098c837650852d1e1355477afa13d
2019-05-14 14:08:24 -07:00
Fan Zhang
b4b7725937 Revert "Revert "Make subsettings display edge-to-edge""
This reverts commit 9e98b8cf0f.

We have to set clipToPadding false on scrollView to make it extend below
navbar. But the side effect is it stops clipping to padding. So it
overlaps with sibling views. In this case anything pinned on top of
screen (switchbar, pinned header for most UIs, and preview indicator for
font size page).

To fix them:
1. in preview pages, just revert back to clipTo*. Their UI doesn't scroll
   so it they don't need to special clip flag to begin with.
2. For pinned to top headers, we need to change the "z-order" by setting
   elevation and make sure background is not transparent.

Fixes: 132182711
Fixes: 132672399
Test: visually on normal screen, font size scree, wifi main setting UI,
      wifi data usage screen

Reason for revert: Rollforward with fix.

Change-Id: Ib6f7c4167b9a680a336f2a7310d82340094d3aac
2019-05-14 13:48:12 -07:00
Joshua Mccloskey
5513a9bdd1 Merge "Increased char limit for translations" into qt-dev 2019-05-14 19:13:11 +00:00
Joshua Mccloskey
b2f19c55b5 Merge "Fixed talkback issue" into qt-dev 2019-05-14 19:09:37 +00:00
Fan Zhang
9a51ede665 Merge "Revert "Make subsettings display edge-to-edge"" into qt-dev 2019-05-14 17:17:26 +00:00
Fan Zhang
9e98b8cf0f Revert "Make subsettings display edge-to-edge"
This reverts commit c2a85a374d.

Bug: 132672399
Bug: 132182711
Test: n/a

Reason for revert: b/132672399

Change-Id: Icb34ae5b16b7a32215fe2c1a5f0d0d028c91b2ca
2019-05-14 16:31:08 +00:00
TreeHugger Robot
ae6f6ab00a Merge "[OWE] Support OWE in transition mode" into qt-dev 2019-05-14 13:57:05 +00:00
Cn Chen
421a05a6a9 Merge "Font size page support light theme in deferred setup" into qt-dev 2019-05-14 07:18:03 +00:00
cnchen
3eee5cf02e Font size page support light theme in deferred setup
Bug:124470158
Test: atest & manually test
Change-Id: I41e1e98a9a64e516a294c4a94c8b5f335434078f
Merged-In: I41e1e98a9a64e516a294c4a94c8b5f335434078f
2019-05-14 14:01:14 +08:00
Kevin Chyn
9a252aa6b5 Merge "Update button string to "Start"" into qt-dev 2019-05-14 05:49:05 +00:00
TreeHugger Robot
8bc21da216 Merge "Remove On/Off subtext next to the Wi-Fi toggle" into qt-dev 2019-05-14 04:44:27 +00:00
Kevin Chang
7eddb0e4dc Change string of switchbar and installed service category title
Bug: 122897712
Test: Visual
Change-Id: I4e15ebc8b91c58d24aadb7e665c6692ebcd627a8
2019-05-14 11:47:19 +08:00
Andy Chou
e553afa7f3 Merge "Fix IMEI information can't display without pSIM inserted" into qt-dev 2019-05-14 03:32:26 +00:00
joshmccloskey
7e470bf806 Increased char limit for translations
Test: It builds.
Bug: 132638233
Change-Id: Ie7deaf82471c832351af9f25f7b4725b65f3c66a
2019-05-13 19:29:24 -07:00
joshmccloskey
a336a7c9f1 Fixed talkback issue
Test: It builds
Fixes: 132635400
Change-Id: I6b3d42561d848a2fdc0f366a96bf3284e5a757fe
2019-05-13 18:24:51 -07:00
Kevin Chyn
200dd1b8b3 Update button string to "Start"
Fixes: 132648319

Test: Builds
Change-Id: I05fa1a8d4d24d5ebef95588df64442718bf42c99
2019-05-13 18:23:22 -07:00
Mehdi Alizadeh
e575fc44f5 Merge "Refactors the System Navigation settings page" into qt-dev 2019-05-14 01:08:22 +00:00
TreeHugger Robot
1ffae41f4e Merge "Add check KEY_HIDE_CARRIER_NETWORK_SETTINGS_BOOL" into qt-dev 2019-05-14 00:54:58 +00:00
Kevin Chyn
cb38ac25a6 Merge "Revert "Corrected flow for accessibility."" into qt-dev 2019-05-14 00:48:49 +00:00
Kevin Chyn
0c37f27355 Revert "Corrected flow for accessibility."
This reverts commit b9cb83e4c6.

Reason for revert: broke build

Bug: 132635400

Change-Id: I15d4db26e3dd9172894354a39be13acc69642090
2019-05-14 00:47:08 +00:00
TreeHugger Robot
987c97c5e1 Merge "Reduced next button enabled delay to 8 seconds" into qt-dev 2019-05-14 00:46:25 +00:00
TreeHugger Robot
27de8ae098 Merge "Strings for "Data during calls" preference" into qt-dev 2019-05-14 00:19:07 +00:00
TreeHugger Robot
3d6bacc731 Merge "Revert recent location apps to pre-Q behavior" into qt-dev 2019-05-14 00:07:28 +00:00
Mehdi Alizadeh
485b3ad655 Merge "Update strings for System Navigation settings page" into qt-dev 2019-05-14 00:07:25 +00:00
TreeHugger Robot
66db1f95e0 Merge "Make subsettings display edge-to-edge" into qt-dev 2019-05-14 00:05:47 +00:00
TreeHugger Robot
3f845f8dd9 Merge "Fix robolectric test error" into qt-dev 2019-05-14 00:04:59 +00:00
TreeHugger Robot
872dc6b4bd Merge "Corrected flow for accessibility." into qt-dev 2019-05-13 23:39:45 +00:00
Raff Tsai
9c115f3f08 Fix robolectric test error
Fixes: 132575837
Test: make RunSettingsRoboTests
Change-Id: I5238a3789f5308a489298fadae772b8b9343ddb5
Merged-In: I5238a3789f5308a489298fadae772b8b9343ddb5
(cherry picked from commit 3c337d5659)
2019-05-13 23:02:30 +00:00
Lei Yu
85398a503e Add check KEY_HIDE_CARRIER_NETWORK_SETTINGS_BOOL
If it is true, then hide:
1. Network Select settings
2. Apn settings

Fixes: 131709441
Test: RunSettingsRoboTests
Change-Id: I203cda570564a41c5bb54a3ad9e60c7f35c0d30c
2019-05-13 15:56:17 -07:00
Hai Shalom
98aa52dbec [OWE] Support OWE in transition mode
Support OWE in transition mode for devices with OWE support
and devices without OWE support. Scan results will return a
new type of network for OWE in transition networks on devices
that support OWE, and Open for devices that don't support OWE.
Handle the case where Open network is manually added to a device
that supports OWE.

Bug: 132139642
Test: Device with OWE: Connect to Open, OWE-Transition, OWE networks
Test: Device without OWE: Connect to Open, OWE-Transition
Test: Manually create Open network, connect to OWE-Transition
Change-Id: I1a584ccbfec8507803c527ea13933cff6f699ccb
2019-05-13 15:37:44 -07:00
Lifu Tang
166b54c0f6 Revert recent location apps to pre-Q behavior
- List recent location request instead of location access
- Show in list view instead of app list widget
- Add overflow menu to "see all" page to show/hide system apps

Bug: 124015107
Test: build, flash, and test manually
Change-Id: I78df6d4b13ddf774013e8d819cf343ce012e6b0b
2019-05-13 15:24:09 -07:00
Joshua Mccloskey
ff5fb3f2d4 Merge "Re-enable continue button for accessibility flow" into qt-dev 2019-05-13 22:05:36 +00:00
joshmccloskey
b9cb83e4c6 Corrected flow for accessibility.
Fixes: 132635400
Test: Manual.
Change-Id: Ied01b76d273b35e01f83a0a744ca2768d02380c5
2019-05-13 14:49:19 -07:00
joshmccloskey
51243e30b0 Reduced next button enabled delay to 8 seconds
Test: It builds.
Bug: 132636805
Change-Id: I6250f842e86c2ab809be803b599a994af6f25af3
2019-05-13 14:42:37 -07:00
Mehdi Alizadeh
36f32a46ca Refactors the System Navigation settings page
Bug: 130915285
Bug: 128855215
Bug: 127718810
Bug: 129115299
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: If11e1fe4bf150d2dd9578f731e71abf6b74f5d90
2019-05-13 14:31:20 -07:00
Mehdi Alizadeh
815ed755c3 Update strings for System Navigation settings page
Bug: 130437843
Bug: 128522050
Test: Manual test to verify the right strings in settings app
Change-Id: Id6e589d896be34c98fded3b3fff897840e9d3f4f
2019-05-13 14:31:20 -07:00
TreeHugger Robot
9141f02f94 Merge "Fix crash on panel rotation" into qt-dev 2019-05-13 21:13:14 +00:00
Antony Sargent
7d8f015151 Strings for "Data during calls" preference
In some dual-SIM cases, when you have an active voice call using a SIM
that isn't the default one for mobile data, you may not get data
connectivity at all (from any other SIM) due to technical limitations in
the telephony stack. This preference will allow the user to leave data
off for a SIM, but opt in to have data become active only during calls.

Bug: 132114205
Test: n/a
Change-Id: I3e7cdaedd8b685e0fe65221d94f5b426bc95942e
2019-05-13 14:03:48 -07:00
Lei Yu
22a9f539e9 Use NetworkTemplate to query data
So virtual carrier can get correct data with merged subscriberIds

Bug: 120566366
Test: RunSettingsLibRoboTests
Change-Id: I02abed77dffb55ef49fe0c4142f6f5b4a42ebe52
2019-05-13 13:04:46 -07:00
lindatseng
943d649f73 Fix crash on panel rotation
Should force PanelFragment creation on rotation change.

Change-Id: If2ccae7dbc4278103c95621743570b37113746f7
Fix: 132587339
Test: Manual
2019-05-13 19:48:59 +00:00
TreeHugger Robot
6a3eb31763 Merge "Fix automatically directing the user to the captive portal in Wi-Fi Slice" into qt-dev 2019-05-13 18:58:44 +00:00
Mady Mellor
240b227e1f Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev 2019-05-13 18:18:31 +00:00
Fan Zhang
c2a85a374d Make subsettings display edge-to-edge
Fixes: 132182711
Test: visual
Change-Id: I3b0635cba359f74d463c2360323d80c5c9533228
2019-05-13 10:07:13 -07:00
andychou
9ac6d81177 Fix IMEI information can't display without pSIM inserted
When no SIM, we can't get active subscription info.
So current code will not create TelephonyManager and cause IMEI not
retrieved.
Create TelephonyManager with default if no subscription info.

Bug: 132215720
Test: test with SIM and without SIM to check SIM status UI and atest ImeiInfoDialogControllerTest pass
Change-Id: Iaeb932ea66a6bee77136251941cca657984e456f
2019-05-14 00:55:47 +08:00
Zhi An Ng
516bdc20fb Merge "Update string description in SAW unsupported screen" into qt-dev 2019-05-13 16:52:22 +00:00