Commit Graph

18216 Commits

Author SHA1 Message Date
Treehugger Robot
b0b3269725 Merge "Stops hiding a11y services with the same package+label as an activity." into main 2024-08-22 00:03:59 +00:00
Haijie Hong
91536001ba Merge "Clean up legacy bluetooth setting flags" into main 2024-08-21 05:45:25 +00:00
Quang Luong
d1f3e77793 Merge "Fix NetworkProviderSettingsTest#onWifiEntriesChanged" into main 2024-08-20 23:58:25 +00:00
Matías Hernández
ef4792c811 Merge "Flip the INTERRUPTION_FILTER_ALL switch" into main 2024-08-20 14:06:17 +00:00
Matías Hernández
7424c4c246 Merge "Use the prebuilt manual DND mode from TestModeBuilder in tests" into main 2024-08-20 12:22:38 +00:00
Haijie Hong
fa56fb9bbf Merge "Add device details more settings page" into main 2024-08-20 09:43:30 +00:00
Haijie Hong
15a9f1437d Clean up legacy bluetooth setting flags
BUG: 359415806
Test: atest SettingsRoboTests
Flag: EXEMPT clean up
Change-Id: I7c47d80e61cfb0e3b473106e0784cc96ba639452
2024-08-20 15:38:32 +08:00
Haijie Hong
7cd4a3987f Add device details more settings page
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ia9eff049e73e039ac5d0fb26096ab4e9add60315
2024-08-19 23:41:16 +08:00
Matías Hernández
c5c158ab38 Use the prebuilt manual DND mode from TestModeBuilder in tests
Instead of unnecessarily creating them by hand. This also allows restricting the visibility of the ZenMode constructors (which should only be instantiated by ZenModesBackend in production code).

Bug: 360817586
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: Id5a232a5a0ffc7bc09652fc4b6e6dd2a6383a2ae
2024-08-19 15:16:56 +02:00
Abdelrahman Awadalla
528abd92dd Merge "Adding methods to enable Touchpad Visualizer option" into main 2024-08-19 12:52:19 +00:00
Abdelrahman Awadalla
5ef762b2b0 Adding methods to enable Touchpad Visualizer option
Adding methods to enable the Touchpad Visualizer option based on both the feature flag and the value of the settings toggle.

Test: atest TouchpadVisualizerPreferenceControllerTest
Test: Enable the flag and enable the "Show touchpad input" in developer
      options and trace the logs in TouchpadInputMapper.
Bug: 359801523
Flag: com.android.hardware.input.touchpad_visualizer
Change-Id: I1c51bc617e907081043cea3e6bab1c719f4d2df9
2024-08-19 11:07:34 +00:00
Quang Anh Luong
d49a056641 Fix NetworkProviderSettingsTest#onWifiEntriesChanged
Fix onWifiEntriesChanged_shouldChangeNextButtonState() to use the
updated onWifiEntriesChanged(int reason) callback method.

Flag: EXEMPT test fix

Bug: 313585353
Test: atest NetworkProviderSettingsTest
Change-Id: If2bcb2ee654aef519c48dd310442750fc30c9c05
2024-08-19 06:27:06 +00:00
Matías Hernández
7883588653 Flip the INTERRUPTION_FILTER_ALL switch
Instead of "Limit what can notify you", title is now "Allow all notifications" and its behavior is reversed (switch ON hides people/apps/other).

Fixes: 360359116
Test: atest InterruptionFilterPreferenceControllerTest + manual
Flag: android.app.modes_ui
Change-Id: Ibb5334889662ec3aa778cd74c51506718ab0ebc7
2024-08-16 16:45:54 +00:00
Matías Hernández
0a5c7530ed Merge "Fix several issues related to CircularIconsPreference" into main 2024-08-16 16:44:24 +00:00
Matías Hernández
b676ca3a62 Fix several issues related to CircularIconsPreference
* Sometimes would cause an unending stream of accessibility events (particularly if starting off-screen). This would break TalkBack and anything that depends on UiAutomator (although the system itself took it like a champ).
* Sometimes would not load images (because the ViewTreeObserver would never fire onGlobalLayout after being added because measured width was 0, even though a new width was calculated later).
* Would not recalculate the number of icons that fit if the width changes after the first layout.

Combining ViewHolders with waiting for measuring and/or ViewTreeObservers was always a wonky approach, even though it should've worked in theory. This should be more robust.

Also fixes the unwanted animation on mode screen load related to the absence of the header name being applied a tad too late.

Fixes: 359948417
Fixes: 360072876
Fixes: 360328804
Test: atest SettingsRoboTests + manual + adb shell uiautomator events
Flag: android.app.modes_ui
Change-Id: I7e5dfbdab220d1ebc1c68e5e87ce544ee86b6a65
2024-08-16 16:20:38 +02:00
Joseph Vincent
044d97ddf9 Merge "Removing TODO from test" into main 2024-08-16 13:13:33 +00:00
Xinyi Mao
eb1fc8415b Merge "Migrate Spinner on Battery Usage to settingsLib Spinner widget." into main 2024-08-16 07:21:07 +00:00
mxyyiyi
05e857de6a Migrate Spinner on Battery Usage to settingsLib Spinner widget.
Bug: 359429437
Test: visual
Test: atest BatteryUsageBreakdownControllerTest
Flag: EXEMPT bug fix
Change-Id: I71bd1f31db302d407603c71d1a1163ed22fafed8
2024-08-16 13:40:07 +08:00
Treehugger Robot
4c7e923250 Merge "fix(Color correction): Display default value in slider to match the radio button" into main 2024-08-15 21:40:41 +00:00
Isaac Chai
23258c2b10 fix(Color correction): Display default value in slider to match the radio button
The default value for display in the radio buttons were hard-coded and was not
being reflected to the slider correctly.

Bug: 359379399
Test: locally tested + unit tests added
Flag: com.android.server.accessibility.enable_color_correction_saturation

Change-Id: I95bd0ae1d32561dbbf6b4e87efe70595c9566de8
2024-08-15 19:53:13 +00:00
Matías Hernández
e7c670ea27 Merge "Fix refresh of "apps that can interrupt" segment" into main 2024-08-15 18:53:55 +00:00
Matías Hernández
195c698cdf Fix refresh of "apps that can interrupt" segment
Switching from Priority Apps to None would still show the icons of the priority apps. There were several minor things wrong:
* We were keeping the AppSession when a mode switches from "priority apps" to "none", and because onResume always fires the callback, we were loading the icons.
* Even when deactivating the session, its own onResume lifecycle listener was still firing one extra time, before we had a chance to deactivate it.

Also two minor improvements to CircularIconsPreference:
* Update mLoadedIcons when we early exit due to mIconSet having no items. Mostly for testing, since the icons wouldn't be visible anyway.
* Use notifyChanged() when we get a measured view, instead of holding a reference to the view. Technically the previous code violated the "shouldn't keep references to views outside of onBindViewHolder" (although I didn't see this having an effect in practice).

Fixes: 360077747
Test: atest ZenModeAppsLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I6d4b7a344542da46f5ebfcd0774f1af27ed113ac
2024-08-15 17:40:36 +02:00
Tetiana Meronyk
c8c5ac7be1 Merge "Read new value of admin status on UserCapabilities update" into main 2024-08-15 15:10:46 +00:00
Alexander Roederer
84cb2f6a02 Merge "Adds Zen metrics categories" into main 2024-08-15 14:39:45 +00:00
Haijie Hong
04f1fea990 Merge "Implement Spatial audio toggle domain layer" into main 2024-08-15 10:54:48 +00:00
Haijie Hong
e3702e9b14 Merge "Rearrange bluetooth device details fragment according to config" into main 2024-08-15 08:13:11 +00:00
Treehugger Robot
b9972035bb Merge "Avoid launching details settings after WifiEntry is forgotten" into main 2024-08-15 05:44:24 +00:00
Weng Su
a6861564b5 Avoid launching details settings after WifiEntry is forgotten
- Don't launch details settings if WifiEntry isn't saved

Bug: 359584817
Flag: EXEMPT bugfix
Test: Manual testing
atest -c NetworkProviderSettingsTest

Change-Id: Iff1c37b64adef6d136d2aaa6a0a946c22af38193
2024-08-15 12:06:11 +08:00
Treehugger Robot
d3fc95aa14 Merge "Update icon picker options, sort order, and descriptions" into main 2024-08-15 01:40:07 +00:00
Treehugger Robot
b3d4b76c69 Merge "Add mandatory biometric prompt to platform surfaces (5/N)" into main 2024-08-15 01:11:42 +00:00
Daniel Norman
c38fd822ba Stops hiding a11y services with the same package+label as an activity.
Bug: 353700779
Test: atest AccessibilitySettings, ensure new test passes
Test: revert AccessibilitySettings.java change, ensure new test fails
Test: Install poc APKs from the bug, observe issue not reproducible
Flag: NONE security fix
Change-Id: Ie680e80169aa734f2559fe50ef06e4d1eae46779
2024-08-14 22:48:06 +00:00
Alexander Roederer
64593a873a Adds Zen metrics categories
Assigns metrics categories to all modes pages under
ZenModesListFragment. Includes new metrics categories where appropriate.

Bug: 332937635
Test: Build and flash
Flag: android.app.modes_ui
Change-Id: Ic19862ec194b40eae294d3c30240fe3f51304665
2024-08-14 20:27:13 +00:00
Matías Hernández
e1dbcfcdb8 Update icon picker options, sort order, and descriptions
Final icon list is ready!

Bug: 359171199
Test: atest IconOptionsProviderImplTest + manual
Flag: android.app.modes_ui
Change-Id: Ia46558fa320bbcc44d19fdda81b14773851a6060
2024-08-14 18:18:19 +00:00
Tetiana Meronyk
56446fa3b8 Read new value of admin status on UserCapabilities update
Before multiple admins were introduced, only main user could be an admin and that status was not modifiable. But now it can be updated for non-main admins of the device. So it is important to refresh this value to keep it up to date.

Bug: 359466920
Test: atest UserCapabilitiesTest
Flag: EXEMPT bugfix_only
Change-Id: If39ad24b10daf6886f402926b3bab23b50201c98
2024-08-14 15:44:35 +00:00
Haijie Hong
df2915bd4e Merge "Add owners for bluetooth settings test folder" into main am: 55834fff02 am: 61a2efc807
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3216259

Change-Id: Idd4a63bea7da0801e963d605d17b751643d1a9d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-14 10:48:35 +00:00
Haijie Hong
61a2efc807 Merge "Add owners for bluetooth settings test folder" into main am: 55834fff02
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3216259

Change-Id: I4835d1b33e1593892054224dec33ea79e64187dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-14 10:32:20 +00:00
Haijie Hong
6f38de4932 Add owners for bluetooth settings test folder
Change-Id: I1503db974eb271890486581d173c1bde8457f7df
2024-08-14 09:42:21 +00:00
Haijie Hong
c1b24f0a9e Implement Spatial audio toggle domain layer
BUG: 343317785
Test: atest SpatialAudioInteractorTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ic73e56a1ca41f9fa58d5219666478a7edc55059d
2024-08-14 17:23:14 +08:00
Haijie Hong
41f7c222b6 Rearrange bluetooth device details fragment according to config
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I440f85b2c402920e851915ff56fa7b3f5356e807
2024-08-14 16:06:15 +08:00
josephpv
2f4c6f7b7a Removing TODO from test
In controller test, simulating profile with hideIndQuietMode set to true
in by mocking AppEntry is not possible. updateAppList() method is
assumed to already receive a filtered list of apps based on the
profile's quiet mode status which is called from onRebuildComplete().

Corresponding filters for this page has test in the underlying settingsLib ApplicationsStateTest file

Bug: 26013153
Test: Manual
Flag: EXEMPT only test file
Change-Id: I09ea3b279c40e0ee4806a80646a5dfcd3d3f784b
2024-08-13 22:34:22 +00:00
Yuri Lin
21ef302524 Merge "Add images for interstitial pages." into main 2024-08-13 22:25:40 +00:00
Yuri Lin
24ba675fe4 Add images for interstitial pages.
This change removes the custom rounding of corners, as the provided images already have rounded corners.

Bug: 332730534
Test: manual (light & dark mode, various font/display sizes)
Flag: android.app.modes_ui
Change-Id: I71d0707554e5bc638add6a2907874e18e833da08
2024-08-13 16:46:05 -04:00
Diya Bera
92ea474b86 Add mandatory biometric prompt to platform surfaces (5/N)
1. For biometric settings, request biometric prompt only after
   successful credential verification and no auth request after
   enrollment

2. Differentiate between mandatory biometrics ineffective error and
   other biometric errors

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 358176202
Bug: 358179610
Test: atest UtilsTest DevelopmentSettingsDashboardFragmentTest MainClearTest BuildNumberPreferenceControllerTest CombinedBiometricProfileSettingsTest
Change-Id: I778dd5403dd5ab64d8cc39bd88b22c4d39182e94
2024-08-13 04:21:37 +00:00
Xin Li
20fb15ea4b Merge "Merge 24Q3 (ab/AP3A.240905.001) to aosp-main-future" into aosp-main-future 2024-08-12 17:14:32 +00:00
Alina Zaidi
156798b168 [dev_option] Dismiss reboot dialog on screen rotation.
Bug: 356273849
Test: mp droid and locally checked that there are no errors and crashes
Flag: EXEMPT minor fix
Change-Id: Id60b304788bfb79fee13858c8e7bc30261f8e1c7
2024-08-12 16:09:03 +00:00
Haijie Hong
2a01b356ae Merge "Move rename button next to the device name" into main 2024-08-12 08:18:32 +00:00
Treehugger Robot
0373a46e81 Merge "Hide new Hotspot preferences if feature is disabled" into main 2024-08-12 04:55:54 +00:00
Haijie Hong
c2ed6d3242 Move rename button next to the device name
BUG: 343317785
Test: atest GeneralBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I87f030ca48d3edac13759fe51499b7e400dbb795
2024-08-12 12:31:45 +08:00
Weng Su
675b817c49 Hide new Hotspot preferences if feature is disabled
- Hide new "Security" preference

- Hide new "Speed and compatibility" preference

Bug: 356898105
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I734959ed511929bfcc9a314770a4acdf9a7e0b99
2024-08-12 05:49:02 +08:00
Jason Hsu
c98fd48306 Merge "Flash Notifications color dialog crashs if configuration changes" into main 2024-08-10 08:03:32 +00:00