Commit Graph

146199 Commits

Author SHA1 Message Date
Matthew DeVore
a23e3cb774 Simplify pane sizing and scaling algorithm
Simplify the scaling parameters and algorithm and reduce vertical
padding.

Originally a maxBlockRatio was specified at .12, which would have
caused a block length to typically be 2560 * 0.12 = 307. However, this
fails to account for smaller displays and high-DPI displays which have
smaller dip dimensions. So instead choose a maximum edge length of
256dp, which I have found to give good results on a laptop device
and a high DPI tablet, and which does not assume typical sizing for
configured displays, and still accomplishes the purpose of limiting
scrolling and dragging size.

Using the aspect ratio of the display bounds in setting the height
frequently caused a very large amount of padding, and limiting based on
the max block height only reduced it slightly. Now we set the vertical
height based on the minEdgeLength. This length is considered the
smallest size that can be comfortably interacted with, and we use it to
give ballpark ideal padding size.

Note that the unit test cases have increased pane height but in
practice (real-world pane width and constraints) this change seems to
decrease the pane height in general.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display, or with two external displays of smallish logical size
Change-Id: Id189892c88a1e833c1f54b0e5447a15f92e3310f
2025-01-30 20:37:03 +00:00
Jack Yu
5161aff82e Merge "Cleaned up the flag enable_identifier_disclosure_transparency" into main 2025-01-28 18:09:37 -08:00
Riley Jones
6e12194015 Merge "Disabling elements on the A11y Shortcut setting subpage" into main 2025-01-28 13:24:42 -08:00
Matthew DeVore
ec58402c03 Merge "Apply display density to topology pane scaling" into main 2025-01-28 11:39:34 -08:00
Bill Yi
4170e612ee Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-28 11:19:31 -08:00
Bill Yi
eccd02caf6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-28 11:19:31 -08:00
Bill Yi
caffee522f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-28 11:19:31 -08:00
Zhou Liu
56170c3f53 Merge "Create "Manage PIN" settings UI menu" into main 2025-01-28 10:48:39 -08:00
Matthew DeVore
e22d46aa9b Apply display density to topology pane scaling
Account for high DPI screens in topology pane scaling.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display
Change-Id: I192fccd402c20e00beacdb5ad55eed406252eb93
2025-01-28 17:24:05 +00:00
Yvonne Jiang
bf54835a94 Merge "Add handling for main Supervision settings toggle." into main 2025-01-28 08:23:39 -08:00
Yvonne Jiang
4f74b50b3a Add handling for main Supervision settings toggle.
This change introduces the basic behavior for the main toggle switch to
enable supervision. There is currently no PIN setup dialog when the
toggle is clicked. That will be added as a follow-up.

Intake bug: b/379312924

Change-Id: I75d6b2de1a7234c6da26fcdcf1d933eed3106a8c
Test: atest SupervisionMainSwitchPreferenceTest
Bug: 392694561
Flag: android.app.supervision.flags.enable_supervision_settings_screen
2025-01-28 02:35:14 -08:00
William Leshner
5035bede60 Merge "Add "Hub Mode" settings to mobile settings." into main 2025-01-27 20:28:02 -08:00
Chris Antol
5267b2c3e3 Merge "Update permission for accessing Brightness Level" into main 2025-01-27 17:59:48 -08:00
Zhou Liu
82356f6e93 Create "Manage PIN" settings UI menu
Test: atest SupervisionPinManagementScreenTest
Test: manually on real device
Bug: 390186179
Flag: android.app.supervision.flags.enable_supervision_settings_screen
Change-Id: Ib53dce2a32fe9551e8877145a61c8834505d389d
2025-01-28 01:12:22 +00:00
Bill Yi
155731f7bd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia200fb7fe94f59bfa1792af3c58472fc538a93a5
2025-01-27 14:36:52 -08:00
Bill Yi
e83d5c846c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id318dd89a29ac9cacdc0128a6fbb532424c2b30b
2025-01-27 14:34:45 -08:00
Bill Yi
5f462a6ffd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia43eb13bc7f08a77cf1731fe5bbf6b50f3e849bf
2025-01-27 14:33:07 -08:00
Jack Yu
506c3e04e3 Cleaned up the flag enable_identifier_disclosure_transparency
Cleaned up the 24Q3 flag enable_identifier_disclosure_transparency

Bug: 276752426
Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Flag: EXEMPT removing flag
Change-Id: Id3355ef2416f75df8ca43cc4d261583e92c17fba
2025-01-27 14:14:45 -08:00
Matthew DeVore
96d615ad18 Merge "Avoid removeall calls for external display" into main 2025-01-27 13:36:22 -08:00
Chris Antol
5015b5c549 Update permission for accessing Brightness Level
Bug: 388372939
Flag: com.android.settings.flags.catalyst_display_settings_screen
Test: atest PreferenceServiceTest
NO_IFTTT=Not applicable to preference controller

Change-Id: I7126ca56eb19fd113ad64eed1417651758711f3f
2025-01-27 13:30:24 -08:00
Michael Checo
3c357edc9f Merge "Reference correct controller in mouse pointer speed slider" into main 2025-01-27 10:37:27 -08:00
Michael Checo
09fa6131cb Reference correct controller in mouse pointer speed slider
Bug: 392153750
Test: Verified on DUT
Flag: EXEMPT refactor
Change-Id: I13351720e441483ab373e81198c3f113fbd41ea1
2025-01-27 10:37:05 -08:00
Oleg Blinnikov
38355abb6f Avoid removeall calls for external display
Change-Id: I7af509bc0bd559b9ad7c9d7e182b443a4db8d220
Test: atest ExternalDisplayPreferenceFragmentTest
Test: manual
Bug: 388545356
Bug: 384741618
Flag: EXEMPT bugfix
2025-01-27 11:52:40 -06:00
Treehugger Robot
ff58281ac6 Merge "Quick fix to Modes Special Access page titles" into main 2025-01-27 08:44:09 -08:00
Matías Hernández
df3e6a1572 Quick fix to Modes Special Access page titles
Fixes: 392594926
Test: manual
Flag: EXEMPT Minor fix
Change-Id: Id5294c41a3c515ce9ae7fef768c1693ade0f8191
2025-01-27 16:41:01 +01:00
Treehugger Robot
532bd7f19e Merge "Add initial settings for summarization" into main 2025-01-27 07:04:49 -08:00
Julia Reynolds
50e720b03b Add initial settings for summarization
Test: SummarizationGlobalPreferenceControllerTest
Test: SummarizationPreferenceControllerTest
Flag: android.app.nm_summarization
Bug: 390415383
Change-Id: I773d69c707ae5f902860196fb44821ede15261f5
2025-01-27 05:54:01 -08:00
Vitor Carvalho
3aaf114753 Merge "Update ParentalControlsUtils to call the new internal API that is aware of SupervisionManager, introduced in ag/31120568." into main 2025-01-27 04:03:47 -08:00
Nikhil Nayunigari
3db5f484ce Merge changes from topic "Ethernet Settings" into main
* changes:
  Adding EthernetInterfaceTracker to support EthernetSettings
  Adding middleware to support EthernetSettings
2025-01-25 18:05:21 -08:00
Nikhil Nayunigari
4d662c5bde Adding EthernetInterfaceTracker to support EthernetSettings
This class is part of the middleware and will be used to be notified
when an EthernetInterface is added or removed.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests: com.android.settings.network.EthernetInterfaceTrackerTest
Change-Id: If3a1f4d7a96b301cd47ffbea55864bcc780cd1e0
2025-01-25 13:01:35 -08:00
Nikhil Nayunigari
6d2152fb10 Adding middleware to support EthernetSettings
Adds EthernetInterface class and its unit tests. This class encapsulates
all operations performed on an EthernetInterface. EthernetManager and
ConnectivityManager are its dependencies to execute operations.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:com.android.settings.network.EthernetInterfaceTest

Change-Id: I640a607c8d9705a10dc4c4c609e036a1afa6b5f7
2025-01-25 19:18:50 +00:00
Treehugger Robot
61e7f37b22 Merge "Unrestrict granted ECM setting for A11Y" into main 2025-01-24 18:12:10 -08:00
Yuhan Yang
b2944f3e0e Merge "Add metric for mouse scrolling setting changes" into main 2025-01-24 16:51:36 -08:00
Treehugger Robot
fe44ea6c87 Merge "Add the new Desktop Experience dev options" into main 2025-01-24 16:27:43 -08:00
Pawan Wagh
192da620e6 Merge "Updating the notification ID " into main am: 9d451341a0 am: 8102d256b4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3453239

Change-Id: I57a0fbc3fac166c9b6fa38ff0b888b6243145a81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 15:41:12 -08:00
Pawan Wagh
8102d256b4 Merge "Updating the notification ID " into main am: 9d451341a0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3453239

Change-Id: Ia18d8a66806956ca6260672b77c56cb0900d7279
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 15:28:38 -08:00
Pawan Wagh
9d451341a0 Merge "Updating the notification ID " into main 2025-01-24 15:21:49 -08:00
Matthew DeVore
50cee5bf76 Merge "Show border highlight when dragging display" into main 2025-01-24 14:37:12 -08:00
Matthew DeVore
3a40af147e Merge "Use correct Settings API to set mirror/extend" into main 2025-01-24 10:50:02 -08:00
Marzia Favaro
271fb3ea63 Merge "UserAspectRatioManager call AtivityRecord#canBeUniversalResizeable" into main 2025-01-24 02:46:03 -08:00
Justin Yun
1cf3f07163 [automerger skipped] Merge "Revert "Replace system_ext container with system"" into main am: faa8f0e399 am: badb14fdb1 -s ours
am skip reason: Merged-In I8f52d5f86e6ffaccd624846fbe1ba0a8fc842af6 with SHA-1 1337a88d11 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3463347

Change-Id: I7eb2d23e6c01d6b91a61319c16eebb194388eb08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 02:18:31 -08:00
Justin Yun
badb14fdb1 Merge "Revert "Replace system_ext container with system"" into main am: faa8f0e399
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3463347

Change-Id: I319bce0a062165a630c5ed391ad9305eaac511e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 02:05:44 -08:00
Justin Yun
faa8f0e399 Merge "Revert "Replace system_ext container with system"" into main 2025-01-24 01:49:56 -08:00
Justin Yun
207466d3c1 settings_connectivity_flags is used from system_ext app
As a system_ext app is using the flags, the flags must be in the
system_ext container instead of the system container.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I46123b93909acc1e1b2e84ac4fe7898ed5243fc5
2025-01-24 16:23:38 +09:00
Justin Yun
e0c046c187 Revert "Replace system_ext container with system"
This reverts commit 6e1b274f03.

A system partition cannot have the aconfigs of other partitions.
Revive the system_ext container for system_ext aconfigs.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1337a88d112b005f897b3745b5475cf7d4764db7)
Merged-In: I8f52d5f86e6ffaccd624846fbe1ba0a8fc842af6

Change-Id: I8f52d5f86e6ffaccd624846fbe1ba0a8fc842af6
2025-01-24 15:53:28 +09:00
Matthew DeVore
1fb8fb0b4f Show border highlight when dragging display
In the process of adding highlight we use an extra feature of
LayerDrawable to add insets so that we can add padding without changing
the actual dimensions or position of the DisplayBlock Views.

To make it easier to keep the values consistent and to aid in conversion
between px and dp, use dimen values to store padding and highlight
metrics.

Bug: b/352650922
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: atest DisplayTopologyPreferenceTest.kt
Change-Id: I51ff2ce4a086e84a0c529346f8ede90430090b11
2025-01-23 23:26:53 -06:00
Yiyi Shen
09c8f4fabb Merge "[Audiosharing] add profile service listener when BT just on" into main 2025-01-23 18:23:17 -08:00
Riley Jones
94621548c1 Disabling elements on the A11y Shortcut setting subpage
Elements on the subpage get disabled if there are no enabled shortcut targets for the relevant type.
In the case of A11y button, the items on its fragment become unsearchable when the setting is disabled.

Test: Manually verify conditions described above & in bug
Bug: 349180207
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Id39e2eda6c9d1de4cdbfcbc22b8a1f443e2822d9
2025-01-24 00:59:25 +00:00
Matthew DeVore
dac774edab Use correct Settings API to set mirror/extend
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/366056921
Test: build and SQ
Change-Id: I93ed7159e5ea746fc2d5939fa07e6053803cfc95
2025-01-23 22:00:45 +00:00
Daniel Norman
7e6cc163d9 Merge "Includes new HCT-Migration-Notification entrypoint in a11y stats logs." into main 2025-01-23 10:08:58 -08:00