Commit Graph

141457 Commits

Author SHA1 Message Date
Treehugger Robot
9c83e100ab Merge "Update state when disabling and enabing develop option" into main am: 0fad6810fe
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2700555

Change-Id: I83b11771e2aa0ec07c03c3030705fba56da6b2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-11-07 19:56:09 +00:00
Treehugger Robot
0fad6810fe Merge "Update state when disabling and enabing develop option" into main 2024-11-07 19:14:23 +00:00
alisa.li
fe199d2656 Update state when disabling and enabing develop option
When not support a2dp offload, the a2dp offload preference is shown in grey, but a2dp offload preference will be set enabled when enabing develop option

Bug:295109808
Test: manual
Change-Id: I7e1d073ff9ef6b68b5f1d9faa1dac459a70d7afc
2024-11-07 10:41:57 +00:00
Treehugger Robot
059f600c5e Merge "fix crash in setting time zone" into main am: 15f88ddc70
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3079352

Change-Id: I010e5c40db4a9eae81df7cb579d5c311c5dd0887
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-11-05 01:02:33 +00:00
Treehugger Robot
15f88ddc70 Merge "fix crash in setting time zone" into main 2024-11-05 00:31:21 +00:00
Treehugger Robot
f5e3b586cb Merge "Avoid flakiness SLO" into main am: aa8b66f3ad
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3310581

Change-Id: I2e906f76248880a2fe2cb1ea36bf6a9783730080
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-23 08:36:25 +00:00
Treehugger Robot
aa8b66f3ad Merge "Avoid flakiness SLO" into main 2024-10-23 08:13:58 +00:00
Treehugger Robot
1dd30843d0 Merge "Remove dependencies on the 1-variant fallback" into main am: e56d23c121
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3317680

Change-Id: I561bf2f17934bcd53afa64048507a35125d8b4f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-23 02:43:14 +00:00
Treehugger Robot
e56d23c121 Merge "Remove dependencies on the 1-variant fallback" into main 2024-10-23 02:06:03 +00:00
Cole Faust
66c5be9fdf Remove dependencies on the 1-variant fallback
When adding a dependencies, if the variants don't match, but the
dependency only has 1 variant anyways, soong will always use that
variant. This makes it hard to add new variants to soong, because the
1-variant fallback stops being used and you start getting missing
variant errors. Make changes to bp files such that all dependencies
correctly specify the variant to use.

Bug: 372091092
Flag: EXEMPT refactor
Test: m nothing
Change-Id: I8487eff4de7349c922901160f55717e7d3296650
2024-10-22 16:30:59 -07:00
Treehugger Robot
5c3479b265 Merge "Fix force close for updating UI after activity destroyed." into main am: c3ea626cd3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3316490

Change-Id: I9b59483a1496a04d459cf1d6ea01598b39c691e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-22 10:12:50 +00:00
Treehugger Robot
c3ea626cd3 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-22 09:51:08 +00:00
hoffc
a9002d157c Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Do not call scan callback if network select activity is finishing or destroyed.

Test: build pass and run NetworkSelectSettingsTest unit test pass.

Bug: 372123288
Change-Id: I28307490c75fe04d54dcf1637f33f4b9ba1fe635
2024-10-22 06:25:37 +00:00
Pechetty Sravani (xWF)
4e2320c2c0 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main am: 0583090e98
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3313692

Change-Id: I3bb7106ca76e045a7b12f7084d4b8cb0cff61dfa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-21 10:13:36 +00:00
Pechetty Sravani (xWF)
0583090e98 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main 2024-10-21 09:49:30 +00:00
Pechetty Sravani (xWF)
bd44c86041 Revert "Fix force close for updating UI after activity destroyed."
This reverts commit 2545f06558.

Reason for revert: DroidMonitor created revert due  to b/374650528.Will be verified through ABTD for standard investigation.

Change-Id: Ifa3f061b7954dc2b5780b768fefb9358c597fdc0
2024-10-21 06:18:31 +00:00
Treehugger Robot
bc05a87483 Merge "Fix force close for updating UI after activity destroyed." into main am: b083196e76
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3298551

Change-Id: I62dbde335827b519cafd50f643db2228c06da457
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-21 04:28:32 +00:00
Treehugger Robot
b083196e76 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-21 04:11:01 +00:00
Treehugger Robot
9dd4394163 Merge "Fix BatterySaverScheduleRadioButtonsControllerTest" into main am: f233e50766
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3313119

Change-Id: I520953f9b2c6e5307fb87aa3eba09e7264851a08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-20 12:28:31 +00:00
Treehugger Robot
f233e50766 Merge "Fix BatterySaverScheduleRadioButtonsControllerTest" into main 2024-10-20 11:57:37 +00:00
YK Hung
cb2e1bdabb Fix BatterySaverScheduleRadioButtonsControllerTest
Test was failing because it was not setting the EXTRA_LOW_POWER_WARNING_ACKNOWLEDGED setting.

Change-Id: Id9e95c0240908dafbaa791e7f4f4b9ded9d39d9b
Test: atest BatterySaverScheduleRadioButtonsControllerTest
Bug: 370883745
Fix: 370883745
Flag: EXEMPT for simple bug fix
2024-10-20 02:11:54 +00:00
tomhsu
3f4cf24ad3 Avoid flakiness SLO
Flag: EXEMPT bugfix
Fix: b/365673174
Test: atest pass
Change-Id: If27c4ca7f8dfd1a0670962b5dba1c42303caccce
2024-10-18 07:16:36 +00:00
Jaewan Kim
49be3eebd5 Merge "Enable Linux terminal app via developer settings" into main am: fcc6b6ce7c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3293590

Change-Id: I6ba801b4ac147769d2a3fda75f4aa819d8e2239d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-16 23:43:23 +00:00
Jaewan Kim
fcc6b6ce7c Merge "Enable Linux terminal app via developer settings" into main 2024-10-16 23:23:29 +00:00
Jaewan Kim
591d4fd932 Enable Linux terminal app via developer settings
Bug: 369246712
Test: `atest SettingsRoboTests`, try toggle the option, \
  and try search with 'Linux'.
Flag: RELEASE_AVF_SUPPORT_CUSTOM_VM_WITH_PARAVIRTUALIZED_DEVICES
Change-Id: Ibdcf00de04f09fe5b03ba53857904945354ed844
2024-10-16 15:49:12 +00:00
Treehugger Robot
fa97f902d7 Merge "Add MaterialComponents.DayNight to SearchBarStyle" into main am: 71c59bae9c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3252493

Change-Id: I4f85371e9ebe33b896192e4f47e033dee1592a30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-16 07:07:04 +00:00
Treehugger Robot
71c59bae9c Merge "Add MaterialComponents.DayNight to SearchBarStyle" into main 2024-10-16 06:51:55 +00:00
Robin Vinterbladh
dc419524c5 Add MaterialComponents.DayNight to SearchBarStyle
When opening the Settings app or changing colors in ThemePicker
there are tons of warnings with UnsupportedOperationException in
the log. These logs are related to the
LayoutInflater attempting to inflate a MaterialCardView and
TypedArray#getColor where it expects the colors to be either an integer
color or a color state list. This happens every time you re-start
Settings.

To enable layout inflater finding colors for Settings we add a
MaterialComponents theme to SearchBarStyle, this makes sure that
TypedArray#getColor gets an integer color instead of relying on
framework to solve this.

Flag: NA
Bug: 363970601
Test: manual, open Settings and check the logs
Change-Id: I728c1537537bb4d32af6006800de93e64facfa8e
2024-10-16 01:05:12 +00:00
Tom Hsu
60d85b9363 Merge "Avoid test flaky" into main am: ec571901be
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3304564

Change-Id: Id61fef14f799f141304afba7cb2f9cd3fde7e0a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-14 04:28:08 +00:00
Tom Hsu
ec571901be Merge "Avoid test flaky" into main 2024-10-14 04:13:25 +00:00
Tom Hsu
9832fe9281 Avoid test flaky
flag: EXEMPT bugfix
fix: 365673174
Test: atest passed
Change-Id: Id7c3747eafff3410ab899716d0c6e35eb405c76e
Merged-In: Id1290e6979fdafa93ded6f50e49d6b3464a80b50
2024-10-11 05:15:14 +00:00
hoffc
2545f06558 Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Directly return if network select activity is finishing or destroyed when handling network scan callback.

Bug: 372123288
Change-Id: Ia8c89569761b66da58cafd0140ceda29ac7d678c
2024-10-08 17:29:45 +08:00
Paul Duffin
aea2622b91 Merge "Fully qualify @attr reference to android.R field" into main am: e61c03648d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3296753

Change-Id: Ic25c2d5d5e0c2ba9a9da492f2bb5be1f1b2bb458
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-08 09:00:55 +00:00
Paul Duffin
e61c03648d Merge "Fully qualify @attr reference to android.R field" into main 2024-10-08 08:31:47 +00:00
Treehugger Robot
3c2d44c3ff Merge "Fixes for errorprone update" into main am: 28f83ffab0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3297590

Change-Id: If54aa111229245173d625b445cf9e1f10182196d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-07 20:40:21 +00:00
Treehugger Robot
28f83ffab0 Merge "Fixes for errorprone update" into main 2024-10-07 20:25:20 +00:00
Cole Faust
b237fe7e6a Fixes for errorprone update
When updating errorprone from 2.23.0 -> 2.32.0, more issues are found.

Bug: 253827323
Flag: EXEMPT refactor
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Iebb442f5e616861d1f2a2e2dc56a8ac72b18cb95
2024-10-07 11:27:07 -07:00
Paul Duffin
ad48f03f53 Fully qualify @attr reference to android.R field
Currently, Metalava has some special handling of '@attr ref R.<field>`
references to make sure that they are fully qualified, i.e.
`@attr ref android.R.<field>`. That special handling complicates
Metalava and is blocking some flagged API work so will be removed.
Before that can be done, the existing incorrect documentation needs to
be cleaned up.

This change cleans up those cases in this repo.

Bug: 371997321
Test: Run `m offline-sdk-docs` before and after to make sure that
      there are no differences.
Flag: DOCS_ONLY
Change-Id: Ic97f01b90193d058d65e6d3c6d0a04ce5e55d7c7
2024-10-07 17:10:02 +01:00
Treehugger Robot
2c3fbda054 Merge "Add a check to ensure that intent data is available before proceeding." into main am: 9a0ba22e79
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3278732

Change-Id: I9964a5759041f686bfe905e10e013ff663c666b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-27 10:13:07 +00:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
Treehugger Robot
5c3c9cbdeb Merge "Use hasScrollAction in ApnEditPageProviderTest" into main am: 12f2e1cf4f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3283218

Change-Id: I1d66aa2b883c0b8d6375b99b23fda25535820c01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 11:13:22 +00:00
Treehugger Robot
12f2e1cf4f Merge "Use hasScrollAction in ApnEditPageProviderTest" into main 2024-09-26 10:54:50 +00:00
Treehugger Robot
840f5a573d Merge "Protect the Settings application from potential null pointer exceptions." into main am: 6a4fb45e38
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3282054

Change-Id: I1c6daaf44b7be4aeaa65fce50711d7e75f511e6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 10:47:30 +00:00
Treehugger Robot
6a4fb45e38 Merge "Protect the Settings application from potential null pointer exceptions." into main 2024-09-26 10:30:43 +00:00
Chaohui Wang
bb1cadb916 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0b530fd405eb95dfedf51bc55bc24bd7d446ead8)
Merged-In: I0a50e7665d9049e089b5a0877f17d1f736ee3332
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-26 10:20:38 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Treehugger Robot
6b7becf63e Merge "Fix errorprone issues" into main am: fdbd2d1090
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3269750

Change-Id: Ic329c9b9a82ee8e16b6c94264b3bc6001d98caac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-17 21:59:11 +00:00
Treehugger Robot
fdbd2d1090 Merge "Fix errorprone issues" into main 2024-09-17 21:38:22 +00:00
Cole Faust
784411fc25 Fix errorprone issues
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I9975c8689c9d673d0b676c60d68ccec1953470f8
Merged-In: Ia0e16b8be5284d13bed4366cbee0f92748bf2f85
2024-09-17 14:08:00 -07:00