Commit Graph

48379 Commits

Author SHA1 Message Date
Antony Sargent
95f34b43f4 Check accounts in all profiles on account detail dashboard
In cl/5074783 I fixed a problem with account deletion where the account
didn't appear to be deleted even when it was. Part of that fix broke the
ability to make changes to work profile accounts - this CL fixes that by
making sure not to early exit the account detail dashboard unless we've
checked the accounts owned by all profiles for the user.

Bug: 117965642
Test: make -j40 RunSettingsRoboTests
Change-Id: Id034418beb4aec8bd4d10191b4924509d27e55d4
2018-11-06 21:21:04 +00:00
Fan Zhang
92792ee806 Merge "Added card_dismissed field into cards table" 2018-11-06 18:44:56 +00:00
Fan Zhang
6454bfdd2c Merge "Make ContextualCardLoader do entire loading upon fragment's onStart()" 2018-11-06 17:27:50 +00:00
Bill Yi
64c7317eef [automerger skipped] Import translations. DO NOT MERGE am: 222dca5b7c -s ours
am: b7d0d2cf2d  -s ours

Change-Id: I429ed1f39a1bdbd319971c0c79a6944d477f576e
2018-11-06 07:11:46 -08:00
Bill Yi
b7d0d2cf2d [automerger skipped] Import translations. DO NOT MERGE
am: 222dca5b7c  -s ours

Change-Id: I36cfe2ffff510c8e4d3d96bf4f463d21ef00b24a
2018-11-06 07:07:33 -08:00
Sunny Shao
647d3e3047 Added card_dismissed field into cards table
Added card_dismissed field to keep user dismissal behavior and filter it when cards loaded

Bug: 113783548
Test: manual test
Change-Id: I27549eca95c2e49fcc92fa59a5c02da73814a522
2018-11-06 20:59:46 +08:00
Bill Yi
222dca5b7c Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ie15195c81e11f67f4bd72be18c6af0d273666ceb
2018-11-06 04:15:12 -08:00
Emily Chuang
f519e3ffe5 Make ContextualCardLoader do entire loading upon fragment's onStart()
For dismissal mechanism, we will have to get information about those
dismissed cards that are stored in Card DB with flag "dismiss" to filter
them out. Currently we only do the entire loading in fragment's
onCreate(), so only when the fragment is recreated users can get the new
data. Now we are changing it to onStart() and make the loader restart so
we are able to show the latest cards.

Change-Id: I4c0be297232f026b46feb8084084816e1acc8f11
Fixes: 119090460
Bug: 113783548
Test: visual
2018-11-06 19:56:42 +08:00
Stanley Wang
5d2a3d23e7 Merge "Architecture review of Copyable Slice" 2018-11-06 05:00:05 +00:00
Stanley Wang
51c9404182 Architecture review of Copyable Slice
Design doc: https://drive.google.com/open?id=1NJPd_282H4195HUGJH5cGJO_Jrcz1Vl6AAw_VQOtGq0

Fixes: 	118398321
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.slice

Change-Id: Ic6762e58698a994d16a5de1778b4035ae430a256
2018-11-06 11:01:17 +08:00
TreeHugger Robot
1d436aade2 Merge changes from topic "refactor-security-location"
* changes:
  Rename title of Security page
  Move LocationSettings to top level page.
2018-11-06 02:01:17 +00:00
TreeHugger Robot
998eaa0585 Merge "Enforce all the SliceBackgroundWorkers being singletons at syntax level" 2018-11-06 00:55:54 +00:00
TreeHugger Robot
4e8e8ca844 Merge "Clarify notification dots/icons strings" 2018-11-05 22:29:31 +00:00
Jason Chiu
a68f81540e Enforce all the SliceBackgroundWorkers being singletons at syntax level
- Create workers via reflection in SliceBackgroundWorker
- Store the workers in a static container and release then at shutdown()

Fixes: 118228009
Test: robolectric
Change-Id: I564277d3a12b2d7d3b50cef091bdfedb3397c145
2018-11-05 21:41:30 +00:00
TreeHugger Robot
9fb79cbe16 Merge "Remove the unnecessary preferenceCategory" 2018-11-05 19:55:55 +00:00
Beverly Tai
7ebb059ea5 Merge "Set modified=true when user changes zen rule name" 2018-11-05 18:58:39 +00:00
Vadim Tryshev
b9cc394a0e Merge "Using intent action for DWB properties exposed as an API" 2018-11-05 18:42:29 +00:00
Lei Yu
152081e7b0 Merge "Add null check for carrierConfig" 2018-11-05 18:29:56 +00:00
Rakesh Iyer
a2837815b5 Merge "Disable controls during playback." 2018-11-05 17:44:29 +00:00
Beverly
0c0f54f48f Clarify notification dots/icons strings
In the Custom Notification DND options, clarify
what notification dots and notification icons are by
adding more information in the strings

Test: manual
Change-Id: I54ef19d46e54ec10da7179fd142043e3a3af0a40
Fixes: 112188372
2018-11-05 10:55:07 -05:00
Sunny Shao
201f1f6146 Merge "Added the icon displayed on no account in search bar" 2018-11-05 05:31:03 +00:00
tmfang
91988d018e Rename title of Security page
Since "Location" was moved to top level,
title shouldn't be "Security&Location"

Bug: 116628158
Test: visual
Change-Id: I9065cae15c014d8826b5473e590177d400666180
2018-11-05 11:28:23 +08:00
tmfang
54a5d37190 Move LocationSettings to top level page.
- Create some location icons for different scenario.
- Remove Location in Security page.
- Move Location Setting to top level page.

Test: robotest, visual
Bug: 116628158
Change-Id: I3f57ef49a396877bfbeaefea7dc4f4051e0ccc65
2018-11-05 11:24:41 +08:00
Sunny Shao
6dc1cc2a77 Added the icon displayed on no account in search bar
Mofidied the search_bar layout and added this icon in the right side of the search_bar.
Added the hasAccount api in AvatarViewMixin and display this icon when there is no any account in device.
Added the test case of the AvatarViewMixin.

Bug: 117509285
Test: robotest
Change-Id: I6ceaa457af4fb20acd0211ca840df5b530c47e0f
2018-11-05 10:52:11 +08:00
Emily Chuang
7d1fc0d3db Update the layout of contextual cards.
Fixes: 118849830
Test: visual
Change-Id: Ia3f7f155271a22f4f6214fad861475442c23c2f6
2018-11-05 10:49:19 +08:00
TreeHugger Robot
c9b56254a6 Merge "Update show4GForLTE config" 2018-11-03 07:10:34 +00:00
TreeHugger Robot
d717790c64 Merge "Clean up useless layout" 2018-11-03 06:28:19 +00:00
Bill Yi
a53c36f606 [automerger skipped] Import translations. DO NOT MERGE am: 935509aa3d -s ours
am: fe385f4a14  -s ours

Change-Id: I0ef2cfa586b4f2ac083de597c1a2770e4e7d4715
2018-11-02 21:59:49 -07:00
Bill Yi
fe385f4a14 [automerger skipped] Import translations. DO NOT MERGE
am: 935509aa3d  -s ours

Change-Id: I6d5663483003b55aaa03856e41adf086d888eec0
2018-11-02 21:26:36 -07:00
Bill Yi
935509aa3d Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ic830e9dc65c715010b562f0148821899114de819
2018-11-02 15:27:05 -07:00
jackqdyulei
9588d2af14 Update show4GForLTE config
Get it from CarrierConfigManager instead of config in systemui package.
Also remove unused CdmaOptions

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Iac47a60e51f68047b8f800dbdcf0efbcd432a015
2018-11-02 14:28:36 -07:00
jackqdyulei
ef79de6ad9 Remove the unnecessary preferenceCategory
In talkback, it counts the untitled preferenceCategory as an visiable
item. This CL remove unnecessary cateogry and add divider line manually.

Bug: 118796245
Test: RunSettingsRoboTests

Change-Id: I77151fdce671cf91322b3c1badc06a3b7861dcc0
2018-11-02 13:24:14 -07:00
Rakesh Iyer
f4627bb608 Disable controls during playback.
The controls were enabled during playback earlier,
however changing them did nothing to the current
playout. Disable them during playout and re-enable
them once playout is done.

Bug: 77976922
Test: Repro case in linked bug.
Change-Id: I0fbe1c97e794fccc49172ee7542018aeef956c8f
2018-11-02 12:34:52 -07:00
jackqdyulei
16c5d77df8 Add null check for carrierConfig
Since it may return null when Crash happens in CarrierConfigManager

Bug: 118402844
Test: RunSettingsRoboTests
Change-Id: I9db0f1a873b3e24936b021989f6716369569b17b
2018-11-02 11:25:37 -07:00
Eugene Susla
cabbb1a522 Merge "Add developer option for sms access kill switch" 2018-11-02 18:18:51 +00:00
Fan Zhang
2d2b594935 Merge "Remove db restriction for category column." 2018-11-02 18:00:11 +00:00
Beverly
8228c6ee02 Set modified=true when user changes zen rule name
Test: make RunSettingsRoboTests -j40
Bug: 118789422
Change-Id: I3df3ce4c86a100c2c1287e3650d7fb331d5fa71c
2018-11-02 13:43:17 -04:00
Fan Zhang
a923a4113a Merge "Clean up ConditionalCards" 2018-11-02 16:43:50 +00:00
tmfang
fb84503d64 Clean up useless layout
There is no any reference to this layout

Bug: 116340579
Test: robotest

Change-Id: I1ec97c6e30cb9e39a2a366dbe7f7b52f49390936
2018-11-02 13:43:14 +08:00
Raff Tsai
71945ff5be Merge "Add Category for contextual cards" 2018-11-02 02:56:21 +00:00
Cosmo Hsieh
c842290974 Merge "Implement NetworkRequestDialog architecture" 2018-11-02 01:39:47 +00:00
Kenny Root
f316ab8de6 Merge "Track change to add ADB service" 2018-11-02 00:43:05 +00:00
Kevin Chyn
0e11b18cf0 Merge changes from topic "biometric-cc"
* changes:
  3/n: Make CDCA transparent and add BiometricPrompt
  2/n: Add comments to launchConfirmationActivity parameters
  1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
2018-11-02 00:37:24 +00:00
TreeHugger Robot
887564b114 Merge "Dnd settings pages redesign (round 1)" 2018-11-01 23:47:36 +00:00
Fan Zhang
7775f67053 Remove db restriction for category column.
SettingsIntelligence should be able to extend support to more categories
without changing Settings.

Bug: 118708391
Test: rebuild
Change-Id: I420394f718bb3712e94040fb3e3c4f66cca629af
2018-11-01 16:31:13 -07:00
Kevin Chyn
b3ee23154d 3/n: Make CDCA transparent and add BiometricPrompt
ConfirmDeviceCredentials now uses BiometricPrompt instead of
FingerprintManager

Bug: 111461540

Test: FRP does not display BiometricPrompt (as expected)
      adb shell settings put global device_provisioned 0 && adb shell am start -a android.app.action.CONFIRM_FRP_CREDENTIAL
Test: Using KeyguardManager API to launch, all corner cases seem OK
Test: Tested with work profile + one lock enabled/disabled, seems OK
Test: Enroll normal FP but not work FP, BiometricPromptDemo for both works
      OK
Test: Test CC on work version of BPD, then BP on normal version of BPD,
      both accept correct FP's (no regression from P)

Change-Id: Iacdaf76ab76971850212dc79513bfa3f4b89eb9a
2018-11-01 15:14:04 -07:00
TreeHugger Robot
0af2ade371 Merge "Remove "See more" from wifi/bluetooth slices" 2018-11-01 21:59:45 +00:00
Fan Zhang
b739e7cd7f Clean up ConditionalCards
Use ConditionalContextualCard directly.

Change-Id: If2e51cdd2cbed27b0094bbb9be06ee9a67f328ec
Fixes: 114307767
Test: robotests
2018-11-01 14:25:53 -07:00
Kevin Chyn
80ecfd95bc 2/n: Add comments to launchConfirmationActivity parameters
Bug: 111461540

Test: builds
Change-Id: I9b2cd9ee472bc67604664671ba022e8589269ee1
2018-11-01 14:11:57 -07:00
Kevin Chyn
e5a016e076 1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
CDC is going to use BiometricPrompt instead. This change
removes FingerprintManager from CDC. BiometricPrompt
will show before pin/pattern/pass is shown.

Bug: 111461540

Test: modified BiometricPromptDemo to use
      KeyguardManager#createConfirmDeviceCredentialIntent,
Test: Fingerprint is gone from CDC, rotation works
Test: atest SettingsRoboTests

Change-Id: I9ce2aad71961af8a0d5ee636600e2fbdb6154e47
2018-11-01 14:11:57 -07:00