Kevin Chyn
7b0867c6d3
4/n: Remove challenge from choose/confirm, use new path
...
Biometric enrollment will not request a Gatekeeper HAT during
initial credential setup or credential confirmation anymore.
Instead, it is broken down into the following steps now.
Bug: 161765592
1) Request credential setup / confirmation to return a
Gatekeeper Password
2) Biometric enrollment will generate a challenge
3) Biometric enrollment will request LockSettingsService to
verify(GatekeeperPassword, challenge), and upon verification,
the Gatekeeper HAT will be returned.
Since both LockSettingsService and Biometric enroll/settings
make use of biometric challenges, this allows us to make the
challenge ownership/lifecycle clear (vs. previously, where
LockSettingsService has no idea who the challenge belongs to).
Exempt-From-Owner-Approval:For files not owned by our team,
(StorageWizard), this change is just a method rename
Test: RunSettingsRoboTests
Run the following on face/fingerprint devices
Test: Remove credential
adb shell am start -a android.app.action.SET_NEW_PASSWORD
Set up credential + fingerprint
Test: Remove credential,
adb shell am start -a android.settings.FINGERPRINT_SETTINGS
This tests the ChooseLock* logic in FingerprintSettings
Test: Set up credential,
adb shell am start -a android.settings.FINGERPRINT_SETTINGS
This tests the ConfirmLock* logic in FingerprintSettings
Test: Remove device credential, enroll fingerprint/face. Succeeds.
This tests the ChooseLock* returning SP path from
BiometricEnrollIntro
Test: With credential and fingerprint/face enrolled, go to
fingerprint/face settings and enroll. This tests the
ConfirmLock* path in Fingerprint/FaceSettings
Test: Remove device credential, enroll credential-only, enroll
fingerprint/face separately. Succeeds. This tests the
ConfirmLock* returning SP path in BiometricEnrollIntro
Test: In SUW, set up credential, then biometric. This tests
the ChooseLock* path in SUW
Test: In SUW, set up credential, go back, then set up biometric.
This tests the ConfirmLock* path in SUW
Change-Id: Idf6fcb43f7497323d089eb9c37125294e7a7f5dc
2020-08-07 12:49:15 -07:00
Kevin Chyn
e67a0afc41
3/n: verifyCredential no longer returns RequestThrottledException
...
Bug: 161765592
Test: Accept/Reject/Lockout on the following
1) Owner profile
2) Managed profile with separate challenge
3) Managed profile with unified challenge
Change-Id: Ia7b670a29e9e8ee1fe65bd09965a454601a06871
2020-08-07 12:17:41 -07:00
Kevin Chyn
fbc2ec831f
2/n: Add setRequestGatekeeperPassword to ChooseLockSettingsHelper
...
This change adds the plumbing on Settings side for ConfirmLock*.
ChooseLock* will be done in a follow-up CL. The changes in this CL
are not invoked by any code path yet. This will also be integrated
in a follow-up CL.
Bug: 161765592
Perform the following with a local change to use
ChooseLockSettingsHelper#setRequestGatekeeperPassword(true)
Test: GK PW is received when setRequestGatekeeperPassword(true)
Test: GK PW + Challenge sent to GK, GK verifies and caller receives
GK HAT successfully
Change-Id: Ibd809784b5599343f34836bc5f3e709627b7f22a
2020-08-07 12:17:41 -07:00
Automerger Merge Worker
c8b21a36e2
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours am: 352259e384
-s ours" into rvc-qpr-dev-plus-aosp am: 0fe2efd3be
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: I3d61d71a409a6fffc0304164c3ad5967e695c5bd
2020-08-07 15:24:32 +00:00
TreeHugger Robot
327d75efb5
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours am: 203bb3924e
-s ours am: ae418fc5e8
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: I56d83cb788910b770357377315bbda6d411a0bfa
2020-08-07 15:24:05 +00:00
Automerger Merge Worker
0fe2efd3be
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours am: 352259e384
-s ours" into rvc-qpr-dev-plus-aosp
2020-08-07 15:11:01 +00:00
TreeHugger Robot
9f783aa73b
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours am: 352259e384
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: Ifc5daff87a690f0593f4beee30e0c5faed8460a8
2020-08-07 15:10:56 +00:00
TreeHugger Robot
ae418fc5e8
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours am: 203bb3924e
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: Ia3396b7edb5cf9599ca36236139f4737668025bc
2020-08-07 15:10:53 +00:00
TreeHugger Robot
352259e384
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: Ica5ba9d21d38210c1cb7ec597f314736fd34707d
2020-08-07 15:01:31 +00:00
TreeHugger Robot
203bb3924e
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev am: 1da29b3f77
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12331170
Change-Id: Ia45d69e65757280f755404f1209c12ac5b17ba59
2020-08-07 15:01:27 +00:00
TreeHugger Robot
26fb956d9f
Merge "Import translations. DO NOT MERGE ANYWHERE"
2020-08-07 14:54:19 +00:00
TreeHugger Robot
39561de47b
Merge "Import translations. DO NOT MERGE ANYWHERE"
2020-08-07 14:51:49 +00:00
TreeHugger Robot
1da29b3f77
Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-d1-dev
2020-08-07 14:45:54 +00:00
TreeHugger Robot
2acae9df4a
Merge "[Wi-Fi] Support multi-SIM for SIM dependent EAP methods" into rvc-qpr-dev am: edd587c2a6
am: 48d768b00c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12167384
Change-Id: I559cee4b76432f72cab16b926ad7d8a2f87abedc
2020-08-07 12:04:56 +00:00
TreeHugger Robot
fc455e6e50
Merge "Update strings for swipe bottom to notification preference"
2020-08-07 11:50:21 +00:00
TreeHugger Robot
48d768b00c
Merge "[Wi-Fi] Support multi-SIM for SIM dependent EAP methods" into rvc-qpr-dev am: edd587c2a6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12167384
Change-Id: I41175eb59b2cea6dfeb97d1413ab6c4846ddb844
2020-08-07 11:49:39 +00:00
TreeHugger Robot
edd587c2a6
Merge "[Wi-Fi] Support multi-SIM for SIM dependent EAP methods" into rvc-qpr-dev
2020-08-07 11:37:27 +00:00
Arc Wang
a09422d6d9
Merge "[adb-wireless] Allow users copy 'IP address & Port' in Wireless debugging"
2020-08-07 09:05:56 +00:00
The Android Open Source Project
7b6716fca6
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ic6ae316705dbbaeae8fdc65d64073c19a07fbd04
2020-08-07 01:47:32 -07:00
The Android Open Source Project
917147963d
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ia9859f2efde98900bf6e743cef2a39fe1232cb5e
2020-08-07 01:00:57 -07:00
Bonian Chen
ed454ae6cb
[automerger skipped] Merge "Remove the second network scan." am: 99a7c3ef00
am: 7f567d422b
-s ours am: 6343b81231
-s ours am: e6ba59fc7b
-s ours am: d29596e18a
-s ours
...
am skip reason: Change-Id If593fc4a4dd463bbc178b4864ad0ba01bb421b09 with SHA-1 b7f98f7667
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393365
Change-Id: If19e68d5130eecbf744f1f88e10efefb7746f89b
2020-08-07 07:58:50 +00:00
Bonian Chen
9292ad91c9
[automerger skipped] Merge "The text on toast should be changed when remains 1 time for SIM lock input" am: 37a0c3873f
am: 4d01040160
-s ours am: f1dbf2bd5e
-s ours am: e3cb875f3f
-s ours am: d455229ab9
-s ours
...
am skip reason: Change-Id If4b53bbbc6b51582bc0837abf4497d9a75ebbaad with SHA-1 9c69ded434
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393239
Change-Id: I96a3800fbcf561a92f43d690fd1397b280d647e5
2020-08-07 07:58:30 +00:00
Bonian Chen
d29596e18a
[automerger skipped] Merge "Remove the second network scan." am: 99a7c3ef00
am: 7f567d422b
-s ours am: 6343b81231
-s ours am: e6ba59fc7b
-s ours
...
am skip reason: Change-Id If593fc4a4dd463bbc178b4864ad0ba01bb421b09 with SHA-1 b7f98f7667
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393365
Change-Id: I21d38488fb8258df484cbe3b1db177bd436d00cc
2020-08-07 07:45:43 +00:00
Bonian Chen
d455229ab9
[automerger skipped] Merge "The text on toast should be changed when remains 1 time for SIM lock input" am: 37a0c3873f
am: 4d01040160
-s ours am: f1dbf2bd5e
-s ours am: e3cb875f3f
-s ours
...
am skip reason: Change-Id If4b53bbbc6b51582bc0837abf4497d9a75ebbaad with SHA-1 9c69ded434
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393239
Change-Id: If9768b2782276ae7fafca08a0e44175556101129
2020-08-07 07:45:34 +00:00
Bonian Chen
e6ba59fc7b
[automerger skipped] Merge "Remove the second network scan." am: 99a7c3ef00
am: 7f567d422b
-s ours am: 6343b81231
-s ours
...
am skip reason: Change-Id If593fc4a4dd463bbc178b4864ad0ba01bb421b09 with SHA-1 b7f98f7667
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393365
Change-Id: Ie22e3768e0b311d7b27e02740271e51ee951895b
2020-08-07 07:37:09 +00:00
Bonian Chen
e3cb875f3f
[automerger skipped] Merge "The text on toast should be changed when remains 1 time for SIM lock input" am: 37a0c3873f
am: 4d01040160
-s ours am: f1dbf2bd5e
-s ours
...
am skip reason: Change-Id If4b53bbbc6b51582bc0837abf4497d9a75ebbaad with SHA-1 9c69ded434
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393239
Change-Id: I861eaf0ca9e26c3793169399f287cfc6351e312b
2020-08-07 07:37:01 +00:00
Bonian Chen
31c03589c3
[automerger skipped] Merge "Add NR Global to the logic to check if it is Global" am: 64c40305b4
am: 9a5a1eabb6
-s ours am: c753471a4d
-s ours am: f9aea105d9
-s ours am: aecd813846
-s ours
...
am skip reason: Change-Id I4d84c6669d6385bef5d75fca4cd6f2ff17533b6e with SHA-1 ff11f200c8
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393367
Change-Id: If0165edb086778132de6c66adaaa010c82a11c38
2020-08-07 07:36:57 +00:00
Bonian Chen
6343b81231
[automerger skipped] Merge "Remove the second network scan." am: 99a7c3ef00
am: 7f567d422b
-s ours
...
am skip reason: Change-Id If593fc4a4dd463bbc178b4864ad0ba01bb421b09 with SHA-1 b7f98f7667
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393365
Change-Id: I242f384a9374e8d0b8c7a4121839140ab1d174fc
2020-08-07 07:26:44 +00:00
Bonian Chen
aecd813846
[automerger skipped] Merge "Add NR Global to the logic to check if it is Global" am: 64c40305b4
am: 9a5a1eabb6
-s ours am: c753471a4d
-s ours am: f9aea105d9
-s ours
...
am skip reason: Change-Id I4d84c6669d6385bef5d75fca4cd6f2ff17533b6e with SHA-1 ff11f200c8
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393367
Change-Id: If8d71349cd40c8c8f0490a8ea0c2bda429ea1304
2020-08-07 07:26:32 +00:00
Bonian Chen
f1dbf2bd5e
[automerger skipped] Merge "The text on toast should be changed when remains 1 time for SIM lock input" am: 37a0c3873f
am: 4d01040160
-s ours
...
am skip reason: Change-Id If4b53bbbc6b51582bc0837abf4497d9a75ebbaad with SHA-1 9c69ded434
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393239
Change-Id: Ie88640e9331b88eb45be68242ee9cdbfb5d752a7
2020-08-07 07:26:31 +00:00
Bonian Chen
7f567d422b
Merge "Remove the second network scan." am: 99a7c3ef00
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393365
Change-Id: I84fd87b8ce8f116ba291159c2cf8e39198d05c2b
2020-08-07 07:16:37 +00:00
Bonian Chen
4d01040160
Merge "The text on toast should be changed when remains 1 time for SIM lock input" am: 37a0c3873f
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393239
Change-Id: I5b928212912c02f46f2e1d1edcd95cb8b45c5499
2020-08-07 07:16:25 +00:00
Bonian Chen
f9aea105d9
[automerger skipped] Merge "Add NR Global to the logic to check if it is Global" am: 64c40305b4
am: 9a5a1eabb6
-s ours am: c753471a4d
-s ours
...
am skip reason: Change-Id I4d84c6669d6385bef5d75fca4cd6f2ff17533b6e with SHA-1 ff11f200c8
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393367
Change-Id: Idbc41dca5d8479be2ef7d4573c4ffd756eb1162b
2020-08-07 07:16:20 +00:00
Bonian Chen
99a7c3ef00
Merge "Remove the second network scan."
2020-08-07 07:06:31 +00:00
Bonian Chen
37a0c3873f
Merge "The text on toast should be changed when remains 1 time for SIM lock input"
2020-08-07 07:04:36 +00:00
Bonian Chen
c753471a4d
[automerger skipped] Merge "Add NR Global to the logic to check if it is Global" am: 64c40305b4
am: 9a5a1eabb6
-s ours
...
am skip reason: Change-Id I4d84c6669d6385bef5d75fca4cd6f2ff17533b6e with SHA-1 ff11f200c8
is in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393367
Change-Id: I90e103ef95b51c2f8736fa95b81d0259e8d7f51a
2020-08-07 07:04:08 +00:00
Bonian Chen
9a5a1eabb6
Merge "Add NR Global to the logic to check if it is Global" am: 64c40305b4
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1393367
Change-Id: I079dd54dd80f39853861f7a27ec9ac24404cc494
2020-08-07 06:54:41 +00:00
Automerger Merge Worker
09a3772e4c
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: ad4bd4cb82
-s ours" into rvc-d1-dev-plus-aosp am: b9d1376ec0
-s ours am: 2ca8a4d3bb
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: Ie3a1e62eedd227cfdf3561b02cc9f9e9ac27dda1
2020-08-07 06:49:20 +00:00
Automerger Merge Worker
8403739a5a
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours am: 62da4cd15c
-s ours" into rvc-qpr-dev-plus-aosp am: a7a753e5ed
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I45c3a45aab4f0d42887a4f55ec37f1614757127a
2020-08-07 06:49:14 +00:00
TreeHugger Robot
080517d5ae
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours am: 33b59d400c
-s ours am: 39ba1e0c8d
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: Ie0b1635a6c159d5dfd69330f4ba0d2ac1116c0a9
2020-08-07 06:49:06 +00:00
Bonian Chen
64c40305b4
Merge "Add NR Global to the logic to check if it is Global"
2020-08-07 06:42:10 +00:00
Automerger Merge Worker
2ca8a4d3bb
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: ad4bd4cb82
-s ours" into rvc-d1-dev-plus-aosp am: b9d1376ec0
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I500efcff95216f165fa89b5a868da335eaaa7543
2020-08-07 06:39:11 +00:00
Automerger Merge Worker
a7a753e5ed
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours am: 62da4cd15c
-s ours" into rvc-qpr-dev-plus-aosp
2020-08-07 06:38:59 +00:00
TreeHugger Robot
f0c2f5bfe6
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours am: 62da4cd15c
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I7562c799b4a582c2303972d5c000fa3dbc3efa50
2020-08-07 06:38:54 +00:00
TreeHugger Robot
39ba1e0c8d
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours am: 33b59d400c
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I5a3b8551756ac0a495c3bc85ffd29d48fa78ca4b
2020-08-07 06:38:47 +00:00
Automerger Merge Worker
b9d1376ec0
Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: ad4bd4cb82
-s ours" into rvc-d1-dev-plus-aosp
2020-08-07 06:30:00 +00:00
TreeHugger Robot
62da4cd15c
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I2ea0f2e14c9260da002a38008011b0b5caf45aac
2020-08-07 06:29:58 +00:00
TreeHugger Robot
6346c7bb6a
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: ad4bd4cb82
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: I0db72980918e2023eec9f0518b7892faecd7e971
2020-08-07 06:29:56 +00:00
TreeHugger Robot
33b59d400c
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-dev am: 37a3d091ba
-s ours am: 27f7aae886
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12329706
Change-Id: Icb1c4448cf88e7cbec93af2ec14265d8ad26b49f
2020-08-07 06:29:50 +00:00
Tsung-Mao Fang
d042a9f2d3
The text on toast should be changed when remains 1 time for SIM lock input
...
The behavior of getQuantityString() is different according to language, it gets both "other" and "one" string if English is system language. But it always gets "other" string if non-English, then the "other" string of wrong_pin_code is shown even if remains 1 time of SIM lock input.
In order to change the string in any language, we add new string for remains 1 time.
Test: Rebuild rom
Fix: 71783850
Merged-In: If4b53bbbc6b51582bc0837abf4497d9a75ebbaad
Change-Id: I1c069333b19399b727e10ed4a6c9483cc1bc44a6
2020-08-07 06:19:07 +00:00