Commit Graph

121676 Commits

Author SHA1 Message Date
TreeHugger Robot
8cd3c56e80 Merge "Enlarges the size of the screen flash color buttons in Flash Notifications" into udc-dev am: 82bb3b8381
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22248254

Change-Id: I6ccd6c581752d979872cbf9538d59a2d69783348
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 10:12:55 +00:00
TreeHugger Robot
82bb3b8381 Merge "Enlarges the size of the screen flash color buttons in Flash Notifications" into udc-dev 2023-03-27 10:06:21 +00:00
Bhavuk Jain
faac0c0b56 Merge "Fixed tests based on return value of PIN length" into udc-dev am: 3635ddb279
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22287122

Change-Id: Ie177a8344eb1b6a576dcf7d7b8a84b60e3132d94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 09:57:35 +00:00
Bhavuk Jain
3635ddb279 Merge "Fixed tests based on return value of PIN length" into udc-dev 2023-03-27 09:32:15 +00:00
Zoey Chen
ace00b7d00 Merge "[Settings] Hide package name if needed" into udc-dev am: 26810aa0c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22221905

Change-Id: I24b8b36cc1c02f77b35da674561e9e7ad7ef558b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 09:05:03 +00:00
Zoey Chen
26810aa0c5 Merge "[Settings] Hide package name if needed" into udc-dev 2023-03-27 08:44:37 +00:00
Angela Wang
a41640b76a Enlarges the size of the screen flash color buttons in Flash Notifications
The size of the screen flash color buttons are now 38dp x 38dp and it's recommended to make the height of these touch targets 48dp or larger.

Bug: 275265260
Test: runs Accessibility Scanner and checks the suggestions are gone
Change-Id: Ie2bef1a0ff976750f6258f7af3f28953c48b994f
2023-03-27 08:13:19 +00:00
Angela Wang
79588ff434 Changes screen flash color selected ring color in Flash Notifications
There's an outer ring to show that the screen flash color is selected and it's black in both light and dark themes.

When selecting screen flash color in the dark theme, it's not obvious which color is selected because the indicated ring is black which is similar to the dark background. Changing it to white in the dark theme for better user experience.

Bug: 275283917
Test: checks UI manually
Change-Id: I714597d99dfb74c5ce0ddef3995fd19688feacdf
2023-03-27 08:11:36 +00:00
Bhavuk Jain
e08f8a466d Fixed tests based on return value of PIN length
This CL aims at fixing the tests in Settings due to the fact that
earlier PIN length was being returned as a long whereas now it's being
returned as an integer now.

Bug: b/267222046
Test: atest AutoPinConfirmPreferenceControllerTest
Change-Id: Iee28557e25a411c2ce6a6245afaafb890b753261
2023-03-27 07:03:46 +00:00
Jason Chiu
5310c40640 Refine permission check process of 2-pane deep link
- Check the deep link activity instance before rediercting to the
  internal activity for the managed profile invocation so the caller
  can't bypass the permission check.
- Get the referrer as the caller so that onNewIntent can recognize the
  new caller and check if it has a permission to open the target page.

Test: robotest & manual
Bug: 268193384
Bug: 272437506
Change-Id: Ie69742983fb74ee2316b7aad16461db95ed927c2
2023-03-27 11:59:07 +08:00
ykhung
64a947c04d Add includeProcessStateData() to include process data am: 89c6471454
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252151

Change-Id: I17be66d1277db3125526c0267f23d3baa25367f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 03:51:26 +00:00
Ken Lin
d8c6dd4fe8 Correct the resolution illustration at the setting page
Replace xml with wrong description with correct one

Bug: 272650243
Test: check Setting -> Display -> Screen resolution
Change-Id: I878356800e965b19bb9064615d220212b35cca08
2023-03-27 02:49:25 +00:00
ykhung
89c6471454 Add includeProcessStateData() to include process data
Add includeProcessStateData() into the `BatteryUsageStatsQuery` build as  described in the b/274562089

Fix: 274562089
Test: presubmit & manual
Change-Id: I7be7424a6d2037c851134488033ec98667343a05
2023-03-27 01:47:36 +00:00
Chaohui Wang
88e20ec62e Fix SpaActivity launched twice for App Info
This happens when shouldShowTwoPaneDeepLink() return true, the
InstalledAppDetailsTop onCreate() is called twice.

Only try start spa when the activity is not finishing to fix.

Bug: 236346018
Test: Manually with Settings
Change-Id: I4b09fba0733a6451a2ba6fd90960f9151692a2ad
2023-03-26 22:39:20 +09:00
ykhung
22592b3dd3 Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND for battery usage am: 3bc2805914
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252150

Change-Id: I8813c8b8de165713d587f7c13f8fa710f6b32ab2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 04:58:44 +00:00
ykhung
3bc2805914 Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND for battery usage
Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND action since Settings
is not store updatable, and it will reboot every time while updating. Originally, it is used on the store updatable extension engine.

Test: presubmit
Bug: 258576047
Change-Id: I9f2d58e3a822c4e4ebe182b03ace1b30f97d2340
2023-03-26 03:10:28 +00:00
TreeHugger Robot
f2296c4846 Merge "Record important battery usage event into SharedPreference for dump()" into udc-dev am: 0d3818fb0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252148

Change-Id: If27c5faf51860008e6e1a86c4bd3011a5441ced7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 03:09:18 +00:00
TreeHugger Robot
0d3818fb0a Merge "Record important battery usage event into SharedPreference for dump()" into udc-dev 2023-03-26 02:38:55 +00:00
ykhung
1f3cf084c8 Record important battery usage event into SharedPreference for dump()
Fix: 268300677
Test: presubmit
Change-Id: If03106c265b984bc2608528bdf45386973e3a14f
2023-03-26 01:24:50 +08:00
TreeHugger Robot
eb9cd39080 Merge "Added "Speed and Compatibility" Settings page" into udc-dev am: df292224e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22164165

Change-Id: I85b0bbbdf3d2d64a549e0bfbe4553e95a9268e36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-25 08:35:04 +00:00
Jason Hsu
158aea7eed Merge "Check whether support telephony for hearing device call routing" into udc-dev am: 5c01d725a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22164163

Change-Id: I3b8b4fe4dedb2abed5a6cae476ea78ac7076bac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-25 08:33:55 +00:00
TreeHugger Robot
df292224e2 Merge "Added "Speed and Compatibility" Settings page" into udc-dev 2023-03-25 08:01:30 +00:00
Jason Hsu
5c01d725a2 Merge "Check whether support telephony for hearing device call routing" into udc-dev 2023-03-25 07:41:44 +00:00
Betty Chang
b7073086ab [automerger skipped] Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975 am: df94418ec6 -s ours am: 5face72c87 -s ours
am skip reason: Merged-In If9e666df7b987e0dbe3d550ac0af03b9d79230de with SHA-1 3512374f62 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: I8cd83952c79327051320168e5c8c51a7e43100fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 17:13:05 +00:00
Becca Hughes
994e9395eb Fix ordering on work profile
Test: on device
Bug: 274126565
Change-Id: I137369fc9a2b5fbb2e200b6c906e11a9dea3a847
2023-03-24 16:42:26 +00:00
Betty Chang
5face72c87 [automerger skipped] Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975 am: df94418ec6 -s ours
am skip reason: Merged-In If9e666df7b987e0dbe3d550ac0af03b9d79230de with SHA-1 3512374f62 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: Ia878da405a0c4c5ad8487d467ebd9b3e6556f43d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 16:25:10 +00:00
Betty Chang
df94418ec6 Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: Ia05fb646720a4b0aeee71047f1aa9cecd519a6eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 15:56:20 +00:00
Betty Chang
6ac664c975 Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: I141e9cbef78ea7e192047d07e054f8810b376219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 15:26:58 +00:00
Betty Chang
cc7da9e61d Merge "To fix the footer link is not clickable in the Bluetooth Settings" 2023-03-24 15:01:48 +00:00
Zoey Chen
515c943e15 [Settings] NPE when finish MobileNetworkSettings am: 6929616581
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252145

Change-Id: I2aab326575b8ad36f33001550a6f6b09c4ca7b11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 14:58:42 +00:00
Zoey Chen
7beb190e9c [Settings] Hide package name if needed
Bug: 273167633
Test: local test
Change-Id: I237d8f5821080283465a6cf72ad7505a55a6bb81
2023-03-24 14:00:31 +00:00
Zoey Chen
6929616581 [Settings] NPE when finish MobileNetworkSettings
Add NPE protection when finish

Bug: 271524675
Test: local test
Change-Id: I74bb54f2e591534b411589c150ce0bd993c2e6dd
2023-03-24 13:08:29 +00:00
Vania Januar
8c6699906a Fix broken test for stylus button Settings.
Test was not negated when the Settings was renamed.

Test: StylusDevicesControllerTest
Bug: 267595764
Change-Id: Ic369d0fefe3f23a9489fe49eff8329e755988178
2023-03-24 12:18:42 +00:00
Vania Januar
6e7d77a4bf Use the correct SettingsEnum for the USI device details page.
Bug: 261988317
Test: just an enum
Change-Id: I2d7820446f723c2a9d084f6913a7d675d83c31eb
2023-03-24 11:28:32 +00:00
Matías Hernández
005a382091 Prevent guest users from toggling "hide silent notifications"
This is a global setting, not per user, and shouldn't be modifiable by a guest. It can still be toggled by other, "normal" users, for the same global effect.

Fixes: 260570341
Test: atest
Change-Id: Id6e1803b5364f3b50bdbc14af0468979c96b5638
2023-03-24 12:15:58 +01:00
changbetty
d31f12eb4e To fix the footer link is not clickable in the Bluetooth Settings
- Links are not allowed in footer preference title now. So follow the
   Wi-Fi UX design to add the string "Change". Let the user to click and
   go to the Bluetooth scanninng settings

Bug: 265167737
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=BluetoothSwitchPreferenceControllerTest

Change-Id: If9e666df7b987e0dbe3d550ac0af03b9d79230de
Merged-In: If9e666df7b987e0dbe3d550ac0af03b9d79230de
2023-03-24 09:23:27 +00:00
Yanting Yang
1888c8511c Merge "Remove unnecessary indexes for Location services" into udc-dev am: d1d2374b89
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22221742

Change-Id: Icd95ed324f3fe31197c0961fa5031b12ee5318d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 08:09:11 +00:00
TreeHugger Robot
6c5e56e736 Merge "Imporve UI of system langauge list" into udc-dev am: e2eb822266
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22200382

Change-Id: I8e1d7460fff0447c5ad5529cae588f23cf46adfd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 08:07:51 +00:00
Yanting Yang
d1d2374b89 Merge "Remove unnecessary indexes for Location services" into udc-dev 2023-03-24 07:42:02 +00:00
Yanting Yang
5b95f6384b Remove unnecessary indexes for Location services
Remove the indexes from LocationServicesForWork since it is only used
in the two tabs scenario. Should not provide its entry in Settings
Search to launch it independently.

Bug: 265056058
Test: manual
Change-Id: I495c6e9c913acb1da3fd759f0d2e12fc7d935389
2023-03-24 15:39:24 +08:00
TreeHugger Robot
e2eb822266 Merge "Imporve UI of system langauge list" into udc-dev 2023-03-24 07:37:05 +00:00
Treehugger Robot
07d355dcba Merge "Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously connected on the same device" am: ca3aa2a557 am: 9526a60e6b am: 9145d7e6ce am: caea0d9aff
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2375795

Change-Id: Idc887c5bbfb7881d812d2d3415e85f72f0cbc1df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 03:26:39 +00:00
Treehugger Robot
caea0d9aff Merge "Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously connected on the same device" am: ca3aa2a557 am: 9526a60e6b am: 9145d7e6ce
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2375795

Change-Id: Ic7ad166567137761143322e108fd66854caa9edc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 02:54:13 +00:00
Treehugger Robot
9145d7e6ce Merge "Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously connected on the same device" am: ca3aa2a557 am: 9526a60e6b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2375795

Change-Id: I0eac72eb5e473771f4792916fb5ae2211aae1e42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 02:24:11 +00:00
Treehugger Robot
9526a60e6b Merge "Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously connected on the same device" am: ca3aa2a557
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2375795

Change-Id: Ic2fb8afdd80cd3892aeccb45fafec6b65de1e68f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 01:55:21 +00:00
Treehugger Robot
ca3aa2a557 Merge "Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously connected on the same device" 2023-03-24 01:24:50 +00:00
Rahul Sabnis
b1e25950b8 Clean up Settings to allow a2dp, hfp, and le audio to be simultaneously
connected on the same device

Removes the classic audio toggles for dual mode audio devices.

Bug: 257881495
Test: Manual
Change-Id: Ie6794b4d904c74a7c5137ad141172c10188a99f9
2023-03-23 16:51:49 -07:00
Bill Yi
02009efec2 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 9850976bf3 -s ours am: 3fd3c68bc9 -s ours am: e0c151f401 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22203763

Change-Id: If40857846ae4833a221f5fb2bdff01451617940d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 20:13:23 +00:00
Bill Yi
1dbb0068e0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5fb9d8914e -s ours am: b9446778d8 -s ours am: f58ee3f5f1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22203763

Change-Id: Id83ac3d55a381d87f464b0c28e1909116171b120
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 20:12:43 +00:00
William Loh
84b6862b46 Merge "Keep same behavior after initiatingPackageName change" into udc-dev am: 6e5e43829b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22212986

Change-Id: I859465aa15851d7028f724d1a014c10c3f54550b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 20:07:45 +00:00