Commit Graph

61601 Commits

Author SHA1 Message Date
Julia Reynolds
68e09db264 Guard against NPE am: 663cc934d9
Change-Id: I56317984b7803128829f77889dccd4d69601bad9
2020-05-19 21:02:18 +00:00
Julia Reynolds
7e17205035 Map local context menu to the correct item am: a1c0269027
Change-Id: Ibaa8644feff3c098b1a384c7dfb645d0fb30d5c0
2020-05-19 17:45:07 +00:00
Julia Reynolds
663cc934d9 Guard against NPE
Test: manual, launching screen from locked lock screen
Fixes: 153569405
Change-Id: Idb546f58623792d94a43ca6659f7498de3beec94
2020-05-19 12:29:24 -04:00
Julia Reynolds
a1c0269027 Map local context menu to the correct item
Since the position of the item might have changed
if ohter items were deleted

Test: manual: delete item 0/2, item 2/2, then 1/2
Fixes: 156716919
Change-Id: I989a064d3a3f89b5c2692d5a687d759c842e080c
2020-05-19 11:22:31 -04:00
Treehugger Robot
045783bd37 Merge "Preserve icon for "manage space"" am: c39b3dfd76 am: d71f2b3f1a
Change-Id: I6b0b1a56980191bc551ba409bfce8e104ca2706a
2020-05-19 12:12:16 +00:00
Treehugger Robot
d71f2b3f1a Merge "Preserve icon for "manage space"" am: c39b3dfd76
Change-Id: Ic24c59d88117a9e0a6f61e2c1b0e2726a1546487
2020-05-19 11:58:13 +00:00
Treehugger Robot
c39b3dfd76 Merge "Preserve icon for "manage space"" 2020-05-19 11:42:46 +00:00
Zoey Chen
2f10922368 [automerger skipped] Merge "[Settings] Code refactor" am: f4d59078fb am: 6622ff7181 -s ours
am skip reason: Change-Id I3fa9dcc630b7612c1af3300024dee4f8deb6b308 with SHA-1 0065f2e460 is in history

Change-Id: I6776bff1f5791d40772c489b40a9ef5160fdf7c9
2020-05-19 10:29:13 +00:00
Zoey Chen
6622ff7181 Merge "[Settings] Code refactor" am: f4d59078fb
Change-Id: I65a011ca26c574d53d7ae3c2551fe6aa44f9c861
2020-05-19 10:15:33 +00:00
Zoey Chen
f4d59078fb Merge "[Settings] Code refactor" 2020-05-19 09:51:16 +00:00
Bonian Chen
e9911c28cf [Settings] Code refactor
Code refactor.

Bug: 141833767
Test: manual
Merged-In: I3fa9dcc630b7612c1af3300024dee4f8deb6b308
Change-Id: I3fa9dcc630b7612c1af3300024dee4f8deb6b308
2020-05-19 16:48:11 +08:00
Zoey Chen
040cd610f6 [automerger skipped] Merge "[Settings] Code refactor for availability session" am: d7dbfe04ca am: 2673571d28 -s ours
am skip reason: Change-Id Ia4982bc4036abbcff5ee1a4bba69bdf6f70ad657 with SHA-1 7ea8e7ef1e is in history

Change-Id: I66d84fc6e8f8afb58f4aa6ca098accc8c8805f3c
2020-05-19 08:41:48 +00:00
Zoey Chen
2673571d28 Merge "[Settings] Code refactor for availability session" am: d7dbfe04ca
Change-Id: I1d486a18f7b0a9b7eb79ac3d28ebbdc0cdfa88c9
2020-05-19 08:23:13 +00:00
Zoey Chen
d7dbfe04ca Merge "[Settings] Code refactor for availability session" 2020-05-19 08:04:42 +00:00
Mehdi Alizadeh
bbcc3cd0c4 Reads back inset scale value from config.xml instead of hardcoded values am: a5eb615038
Change-Id: I244a5a5bc04eba2e1812e3aa77dfce00ebfa4098
2020-05-19 03:59:47 +00:00
Zoey Chen
9794be17c1 [automerger skipped] Merge "Improve the performance of displaying preference." am: f0322ab48e am: 9cc7978d0a -s ours
am skip reason: Change-Id Ia13a75a3821bb6c17d0dfeffb5043f47b60adf61 with SHA-1 84587b1aa3 is in history

Change-Id: Ic06c42e81cea117038bd4fd015ca8712e582e228
2020-05-19 03:46:31 +00:00
Bonian Chen
cede995c5d [Settings] Code refactor for availability session
Code refactor for session design of availability status config.

Bug: 141833767
Test: manual
Merged-In: Ia4982bc4036abbcff5ee1a4bba69bdf6f70ad657
Change-Id: Ia4982bc4036abbcff5ee1a4bba69bdf6f70ad657
2020-05-19 11:41:59 +08:00
Zoey Chen
9cc7978d0a Merge "Improve the performance of displaying preference." am: f0322ab48e
Change-Id: I27fdfb879d8081ebd949f57799f10daa2d0f8c2d
2020-05-19 03:22:10 +00:00
Zoey Chen
f0322ab48e Merge "Improve the performance of displaying preference." 2020-05-19 03:03:26 +00:00
Mehdi Alizadeh
a5eb615038 Reads back inset scale value from config.xml instead of hardcoded values
Bug: 152364314
Test: Manual
Change-Id: Ie8de080a26bda3b63c6a5ee726e7adce2d3859f7
2020-05-18 23:51:48 +00:00
Peter_Liang
facc126a0c Refine the banner view for accessibility features. am: f78e7f5976
Change-Id: I483922226b74d748dd11fa8d820b3ae2a03d9855
2020-05-18 13:45:16 +00:00
Peter_Liang
f78e7f5976 Refine the banner view for accessibility features.
1. Replace the video with the gif for Magnification.
2. Replace the static image with the gif for Color Inversion.

Bug: 153293657
Bug: 155946967
Test: manual test & robo test
Change-Id: Ic51c0ec45c10a7fd2b9f1ffb63865ebc764846ba
Merged-In: Ic51c0ec45c10a7fd2b9f1ffb63865ebc764846ba
2020-05-18 19:04:28 +08:00
Jason Hsu
c4e55b86cc Merge "Change to use CaseMap.toTitle in shortcut type summary to handle different locale." into rvc-dev am: 966f0527ac
Change-Id: Id4ba1da4d1b18b3d30fca1da1d2897ad017ebdef
2020-05-18 09:51:00 +00:00
Jason Hsu
966f0527ac Merge "Change to use CaseMap.toTitle in shortcut type summary to handle different locale." into rvc-dev 2020-05-18 09:37:25 +00:00
TreeHugger Robot
1f21e1b6f9 Merge "Add bottom padding of profile group on Bluetooth detail page" into rvc-dev am: 3370e0304f
Change-Id: I811c45543d62207490f1e3db5a5af1bbb06c2e82
2020-05-18 09:12:19 +00:00
Zoey Chen
e78a15299f [automerger skipped] Merge "[Settings] Avoid rendering hidden preferences" am: b4b612a8e3 am: ad9b5c3b56 -s ours
am skip reason: Change-Id I00c6f827a0b7b7cec6a6fd8c809b94ca1dce88bb with SHA-1 1b9bda3b05 is in history

Change-Id: Id0cc568b7496bfa80a7d70a109ad3ea65ce5103d
2020-05-18 09:11:51 +00:00
Zoey Chen
ad9b5c3b56 Merge "[Settings] Avoid rendering hidden preferences" am: b4b612a8e3
Change-Id: I75cf82d73c30583c5e7983e90af50da43246abfc
2020-05-18 08:58:01 +00:00
TreeHugger Robot
3370e0304f Merge "Add bottom padding of profile group on Bluetooth detail page" into rvc-dev 2020-05-18 08:54:39 +00:00
zoey chen
20d88eb2a8 Improve the performance of displaying preference.
- Set a variable to record the status then replace getAvailabilityStatus() with it.

Test: manual test, use command to run MobileNetworkSettings and record it.
Bug: 154061428
Merged-In: Ia13a75a3821bb6c17d0dfeffb5043f47b60adf61
Change-Id: Ia13a75a3821bb6c17d0dfeffb5043f47b60adf61
2020-05-18 16:51:13 +08:00
Zoey Chen
b4b612a8e3 Merge "[Settings] Avoid rendering hidden preferences" 2020-05-18 08:38:05 +00:00
jasonwshsu
43eb71bceb Change to use CaseMap.toTitle in shortcut type summary to handle different locale.
Bug: 153850193
Test: manual test
Change-Id: I6b4583d0b42a0019dfae9442536f6ed752ccc409
Merged-In: I6b4583d0b42a0019dfae9442536f6ed752ccc409
2020-05-18 08:21:06 +00:00
TreeHugger Robot
69e12a0f05 Merge "[Wi-Fi] Expose AP Band outside of the Advanced section" into rvc-dev am: 62b9032b8c
Change-Id: I7fc5cf34086826e5421a9a3cc7a5a1fe88521269
2020-05-18 06:28:44 +00:00
TreeHugger Robot
62b9032b8c Merge "[Wi-Fi] Expose AP Band outside of the Advanced section" into rvc-dev 2020-05-18 06:13:35 +00:00
tim peng
51e997cfd8 Merge "Output switcher shows the device list by an incorrect package name" into rvc-dev am: 0581bd7f1c
Change-Id: I2a1d02417f787535ae64a72b7ea5c0da5014c41f
2020-05-18 05:26:52 +00:00
tim peng
9c01aac31e Merge ""Play null on" displayed under media volume" into rvc-dev am: 9a9ce2b2fa
Change-Id: I888d2c83f9b169a88212e71994faa160089d8e42
2020-05-18 05:26:50 +00:00
TreeHugger Robot
61b8d3ea22 Merge "Remove duplicate search result when search "Calls" and "Messages"." into rvc-dev am: 1a420ce0cf
Change-Id: If0dcdfdfe1623b0acea16d1caea5c927fe7dcd9d
2020-05-18 05:25:57 +00:00
tim peng
0581bd7f1c Merge "Output switcher shows the device list by an incorrect package name" into rvc-dev 2020-05-18 05:22:50 +00:00
tim peng
9a9ce2b2fa Merge ""Play null on" displayed under media volume" into rvc-dev 2020-05-18 05:22:50 +00:00
hughchen
1df322225b Add bottom padding of profile group on Bluetooth detail page
- This CL add a bottom padding preference to make UI consistency.
- Update test case

Bug: 146522686
Test: make -j42 RunSettingsRoboTests
Change-Id: I525d8a3b71535972755de92924a3c04768f68e63
2020-05-18 13:17:15 +08:00
TreeHugger Robot
1a420ce0cf Merge "Remove duplicate search result when search "Calls" and "Messages"." into rvc-dev 2020-05-18 05:09:35 +00:00
TreeHugger Robot
e8182cc341 Merge "Remove duplicate search result of "Assistant apps"" into rvc-dev am: 3b61a1a313
Change-Id: Ic4c180df9a6017bfbff3e743ea16d3a5b6c6ac90
2020-05-18 04:11:30 +00:00
TreeHugger Robot
3db10d5c6d Merge "Update string to keep On-screen keyboard naming consistent" into rvc-dev am: d02752c847
Change-Id: I49c9c4117e95a6b5a68d8646b2199b9f766c438a
2020-05-18 04:11:23 +00:00
TreeHugger Robot
3b61a1a313 Merge "Remove duplicate search result of "Assistant apps"" into rvc-dev 2020-05-18 04:04:31 +00:00
Edgar Wang
f0ca8d4309 Remove duplicate search result of "Assistant apps"
since even if user want to find "Default Assistant apps" preference,
user still can find it when search the screen title or direct enter
permission cotroller page.

Bug: 155849417
Test: manual
Change-Id: I10628ac24e13eca99611cf14cf17e89b1d072c85
2020-05-18 04:02:52 +00:00
TreeHugger Robot
d02752c847 Merge "Update string to keep On-screen keyboard naming consistent" into rvc-dev 2020-05-18 04:00:11 +00:00
TreeHugger Robot
18b095ee68 Merge "Close Settings page when cross-profile appop is granted" into rvc-dev am: 1b240b646d
Change-Id: Ia6e4fc35be4c951897e67d162e5767c197c2b66b
2020-05-18 03:38:21 +00:00
TreeHugger Robot
1b240b646d Merge "Close Settings page when cross-profile appop is granted" into rvc-dev 2020-05-18 03:25:24 +00:00
Stanley Wang
85eb26c1c1 Merge "Fix the search result "Free up space" doesn't work." into rvc-dev am: df9f721033
Change-Id: I794413d31a573c157fa6388ac4a3a621c4b96aa2
2020-05-18 03:19:59 +00:00
Bonian Chen
cc6a88bf6c [Settings] Avoid rendering hidden preferences
Under dashboards with expand button, preferences are renderred even
not been expanded.
Avoid from rendering un-expanded preference can improve the performance
of dashboard display.

Bug: 141833767
Test: manual
Merged-In: I00c6f827a0b7b7cec6a6fd8c809b94ca1dce88bb
Change-Id: I00c6f827a0b7b7cec6a6fd8c809b94ca1dce88bb
2020-05-18 03:17:09 +00:00
Arc Wang
b347128bbf [Wi-Fi] Expose AP Band outside of the Advanced section
Design change for UX improvement.

Bug: 156629343
Test: manual visual
Change-Id: I4ff89eec472de699d1fa723d8369ad99b78a83a3
2020-05-18 11:13:47 +08:00