Commit Graph

60923 Commits

Author SHA1 Message Date
tim peng
634dc7f8a3 Merge "Refine layout for output switcher panel" into rvc-dev am: 7874c0fdc4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11596546

Change-Id: I77f3b9a35e760c1c8f1f1839d979940d67501fed
2020-06-15 01:29:16 +00:00
tim peng
7874c0fdc4 Merge "Refine layout for output switcher panel" into rvc-dev 2020-06-15 01:14:57 +00:00
Jason Chiu
4f2cd6ab5f Merge "Improve BT slice card loading performance" into rvc-dev am: 85f03668a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833854

Change-Id: Ic338f8e2106ef256cbef1b7a93feaeba31fb7a0f
2020-06-14 17:30:15 +00:00
Jason Chiu
85f03668a5 Merge "Improve BT slice card loading performance" into rvc-dev 2020-06-14 17:14:11 +00:00
TreeHugger Robot
6ccd5339fa [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 4b25f3f159 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11854964

Change-Id: I125b53a89f8a3dddb24a50bd02f549a700d7c41b
2020-06-13 00:30:59 +00:00
TreeHugger Robot
2718f1d42b Merge "Explicitly request focus after button pressed" into rvc-dev am: d9a246c49e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11851989

Change-Id: I3c25415f84b9c59b5a59d9979ab383c0572ca17a
2020-06-13 00:30:52 +00:00
TreeHugger Robot
4b25f3f159 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-13 00:26:09 +00:00
TreeHugger Robot
d9a246c49e Merge "Explicitly request focus after button pressed" into rvc-dev 2020-06-13 00:19:44 +00:00
Bill Yi
23e3832fe0 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I4248ba5dd6eddcba4c94f9b25e6ef46ffec387c6
2020-06-12 15:02:57 -07:00
Kevin Chyn
4b59ce96e2 Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev am: 5c4334276f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11838911

Change-Id: I7541fb18e9be1624220bd61929736452fdb342a7
2020-06-12 20:08:39 +00:00
Kevin Chyn
5c4334276f Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev 2020-06-12 19:56:01 +00:00
Beverly
258fd7c03b Explicitly request focus after button pressed
Don't use focusableInTouchMode, it was causing focus/clickability issues
when the device wasn't in touch mode.

Test: manually tap button (tap works first try)
Test: turn on talkback and toggle buttons, also try toggling QS tile
while on the Settings page - doesn't reannounce state
Fixes: 158717450
Change-Id: I785d0200dd61235aa3308a8588f9ee998e7cb6e5
2020-06-12 16:01:50 +00:00
Jason Chiu
72a9dc4c8b Merge "Fix Slice not pinned error" into rvc-dev am: 8cbee49d28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833849

Change-Id: I1d64558f189ca6b14d71cc71e574dae5dd21146d
2020-06-12 11:43:59 +00:00
Jason Chiu
8cbee49d28 Merge "Fix Slice not pinned error" into rvc-dev 2020-06-12 11:31:23 +00:00
Tim Peng
9bdeef43fd Refine layout for output switcher panel
1. only make the output switcher tall enough to show 6.5 devices
2. enlarge album art to 52*52 and keep same size on group panel
3. reduce panel header top padding
4. enlarge slice first item top padding
5. update slider bar right padding
6. update panel height
7. align slice title item left with panel title icon
8. enlarge slice end item right padding

Bug: 156045699
Test: manual test
Change-Id: I51321d98ef483665689b7e258d6071df76382759
2020-06-12 15:15:00 +08:00
TreeHugger Robot
1d02b72826 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 05103c79d1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844686

Change-Id: I73b81a96482fb4423f628ec878df55dd2022bb0b
2020-06-12 05:10:58 +00:00
tim peng
a4642718b4 Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev am: c21406a0a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818502

Change-Id: I7cd8987d1472b308e4a918316e4877044c48816d
2020-06-12 05:10:53 +00:00
TreeHugger Robot
05103c79d1 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-12 05:09:30 +00:00
tim peng
c21406a0a2 Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev 2020-06-12 04:58:04 +00:00
Bill Yi
a891edabdb Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Ibb02d904bcceffdd07fb13dec9b62e72e89ea32d
2020-06-12 03:50:41 +00:00
Tim Peng
27b0ef6eb3 Output switcher panel requires large title icon for Slice slider style
-Add "VIEW_TYPE_SLIDER_LARGE_ICON" to be a new panel type which would enlarge its title icon
-Set "VIEW_TYPE_SLIDER_LARGE_ICON" to MediaOutputPanel and MediaOutputGroupPanel
-Extend slider style and add customized icon size
-Add test cases

Bug: 157208551
Test: make -j42 RunSettingsRoboTests
Change-Id: I9b4de4aa552e8b26e766411f7eff93ea1a2d1910
2020-06-12 11:22:17 +08:00
Chen Xu
0bc52c8262 Merge "rename "Emergency Alert" to "Public Warning" per IT requirements" into rvc-dev am: 6ebe9ae0ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11814763

Change-Id: I31840ef2c88776cfb3ee930e8757ef32ddaf2a2a
2020-06-12 02:41:11 +00:00
TreeHugger Robot
e26dfb6d10 Merge "Unicode-wrap app names for default apps summary." into rvc-dev am: 6791e1c09b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844071

Change-Id: I7940ffb602a06eb0fa379d8879458dbc5bbc7fa7
2020-06-12 02:41:05 +00:00
Chen Xu
6ebe9ae0ff Merge "rename "Emergency Alert" to "Public Warning" per IT requirements" into rvc-dev 2020-06-12 02:29:17 +00:00
TreeHugger Robot
6791e1c09b Merge "Unicode-wrap app names for default apps summary." into rvc-dev 2020-06-12 02:28:48 +00:00
Hai Zhang
3f511d8ca9 Unicode-wrap app names for default apps summary.
This was done for permissions summary inside PermissionController, so
also do it in Settings.

Bug: 153804329
Test: manually confirm that the summary matches what linguist
      suggested after fix
Change-Id: I650fbed4488abfd871adafba5afb1ae9a2995c62
2020-06-11 16:54:25 -07:00
Jason Chiu
f7afded1d1 Fix Slice not pinned error
Slices should be pinned before being bound. The original design calls
registerSliceCallback() to pin a slice, and then calls bindSlice() and
passes the result to the callback directly. When the callback is
called, it executes unregisterSliceCallback() and unpins the slice.

However, registerSliceCallback() starts to observe the slice change and
then rebind it in an AsyncTask. If the slice is updating via its
background worker and the timing of the binding overlaps the callback
execution, it's possible to bind the slice right after unpinning it and
causes the error.

The solution is to remove the callback mechanism, and just to pin, bind
and unpin the slice directly.

Fixes: 157387583
Test: robotest
Change-Id: I8748dd3038a3662599935f07420d07cf254a4073
2020-06-12 04:14:46 +08:00
Kevin Chyn
895ddf239a BiometricFragment should commitAllowingStateLoss
This is a terminal case for both authentication as well as the
activity itself, so this should be safe.

Fixes: 158635014

Test: Builds
Change-Id: Ieef1ab305e6518dbc0ae34ad59d52da82895972a
2020-06-11 12:59:05 -07:00
TreeHugger Robot
b3d6b850d8 Merge "Don't pass channel info for the bubble app page" into rvc-dev am: d6081039c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11636410

Change-Id: Ie8c439579425ec493d3ca6c16ca74b317c70a2ad
2020-06-11 17:36:52 +00:00
Joshua Duong
0da2a4d896 Merge "[adbwifi] Handle tls port changes." into rvc-dev am: 63facb88bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11828521

Change-Id: I340c00f28a9e9b1e6c7e23c8a28d6e19044c266b
2020-06-11 17:36:41 +00:00
TreeHugger Robot
d6081039c6 Merge "Don't pass channel info for the bubble app page" into rvc-dev 2020-06-11 17:23:56 +00:00
Joshua Duong
63facb88bd Merge "[adbwifi] Handle tls port changes." into rvc-dev 2020-06-11 17:23:00 +00:00
Chen Xu
dd3324a326 rename "Emergency Alert" to "Public Warning" per IT requirements
Follow Italy Government requirements to rename setting string for
emergency alerts

Bug: 158094274
Test: Manual
Change-Id: Id969d0f6f9c0282ef3c122ef3ea04a64646024fe
2020-06-11 10:10:05 -07:00
Mady Mellor
87e16f416f Don't pass channel info for the bubble app page
Fixes: 157485149
Test: make SettingsUnitTests; adb shell am instrument etc
Change-Id: If8d9b446ed056996cda91fcc5e92c7077ff3ea5d
2020-06-11 08:33:45 -07:00
TreeHugger Robot
9c7fee15c7 Merge "Add a new SettingsCategoryPreference style" into rvc-dev am: ae1ed2508a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818499

Change-Id: I2053f3304efdd472c0440de069299053da1b3784
2020-06-11 11:32:15 +00:00
TreeHugger Robot
ae1ed2508a Merge "Add a new SettingsCategoryPreference style" into rvc-dev 2020-06-11 11:16:55 +00:00
Jason Chiu
3c3f362125 Improve BT slice card loading performance
The bottleneck is getting LocalBluetoothManager the first time.
1. Initialize LocalBluetoothManager earlier and asynchronously.
2. Don't block in slice's constructor and getSlice().
  - Initialize the bt updaters until the manager is ready.
  - Just show a header if the manager is not ready yet.

Fixes: 157702021
Test: robotest
Change-Id: I427df55f259b45ba4c37557b22e09dcc24079e93
2020-06-11 18:39:29 +08:00
András Klöczl
57389b767a Merge "Change user setup prompt dialog showing logic" into rvc-dev am: f8754b4deb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11686951

Change-Id: I00ae9d5fef112d54898f1e6f2984c04576eace6d
2020-06-11 09:01:39 +00:00
András Klöczl
f8754b4deb Merge "Change user setup prompt dialog showing logic" into rvc-dev 2020-06-11 08:47:07 +00:00
tim peng
595ee309dc Merge "Apply RangeBuilder amination for media transferring" into rvc-dev am: 359d3ac829
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/10987459

Change-Id: Ib04fed2f3e59acfa995d1b084acee347d30af858
2020-06-11 06:09:54 +00:00
tim peng
359d3ac829 Merge "Apply RangeBuilder amination for media transferring" into rvc-dev 2020-06-11 05:55:21 +00:00
Joshua Duong
76d2afb832 [adbwifi] Handle tls port changes.
Events such as adbd restarts can change the connection port. We need
to update the UI accordingly.

Bug: 158219145

Test: Manual.
1) Enable wireless debugging in Settings and validate port in UI via
> adb shell su 0 netstat -plnt | grep LISTEN
2) Restart adbd: > adb root
3) validate port again (may have changed)

Change-Id: I93339a6a258fbf69fa3f45186863a01126d279ce
2020-06-10 16:56:29 -07:00
TreeHugger Robot
3d34745bed Merge "Import translations. DO NOT MERGE" into mainline-prod 2020-06-10 22:05:37 +00:00
TreeHugger Robot
4ea9ef21fe Merge "Import translations. DO NOT MERGE" into mainline-prod 2020-06-10 21:12:42 +00:00
TreeHugger Robot
2cc88db927 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 005686ff69 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11824339

Change-Id: I732232d8df1c21e837c56cbd10166d992fd79683
2020-06-10 20:44:37 +00:00
TreeHugger Robot
1ad61de8e0 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: f77400c5a2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11817981

Change-Id: I41883d8bace67e319133624566c8dfa0fa7fe349
2020-06-10 20:44:31 +00:00
TreeHugger Robot
005686ff69 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-10 20:28:39 +00:00
TreeHugger Robot
f77400c5a2 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-10 20:26:24 +00:00
Bill Yi
47ee699c6b Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Ic4a3a9d8b81c0512788ca40b3a28900de0680856
2020-06-10 18:17:40 +00:00
Bill Yi
6cf65538b2 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Ic608181e33931fdde5423eb6c5e298c363c594c9
2020-06-10 17:02:10 +00:00