Commit Graph

85320 Commits

Author SHA1 Message Date
Jason Chiu
50bfe197b7 Merge "Disable animations of deep link homepages to reduce the shortcut flicker" into sc-v2-dev 2021-12-03 07:01:16 +00:00
Alex Johnston
86cee74361 Merge "Add non system overlay flag to InstallCaCertificateWarning" into sc-v2-dev 2021-12-02 15:34:01 +00:00
Jason Hsu
5c90a9c225 Merge "Align the "Open activity" UI style with usual accessibility service "Use service"" into sc-v2-dev 2021-12-02 11:01:49 +00:00
TreeHugger Robot
d355d7f123 Merge "Fix the background color of CollapsingToolbarLayout" into sc-v2-dev 2021-12-02 07:19:45 +00:00
Mill Chen
3825bff021 Fix the background color of CollapsingToolbarLayout
The wrong background color of CollapsingToolbarLayout appears in some
pages like "All apps" page or "Password and accounts" page. This symptom
can be observed in these pages when the work profile is enabled and the
line count of title is 1.

This issue is caused by updating the title of the page many times. In
these pages that have the tab view, the structure of the page differs
from a general setting page. The title of the page is coming from
BaseActivity, ProfileSelectFragment, PersonalFragment and WorkFragment,
in which the page that has the issue has an empty string from
ProfileSelectFragment. That is causing the CollapsingTollbarLayout has
the different line count during the process of setting the title.

Since the pages that have the tab view are different from the general
pages in Settings, the title should be set separately for those pages.
Adding a method to get the title resource ID so the page extending from
ProfileSelectFragment can set its title.

Bug: 192914660
Test: visual test and manual test
1) Enable work profile
2) Navigate to All apps page
3) The page should have the correct background color in the
CollapsingToolbarLayout

Change-Id: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
Merged-In: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
2021-12-02 13:40:45 +08:00
Joshua Mccloskey
506c6b804f Merge "Fixed face enroll intro button issue" into sc-v2-dev 2021-12-01 23:08:49 +00:00
TreeHugger Robot
d51b41d4ec Merge "Updated udfps strings" into sc-v2-dev 2021-12-01 19:58:50 +00:00
Bill Yi
4844909fbe [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 8e754d6891 -s ours am: 7946a90b42 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16356908

Change-Id: I31222683be6f79243f3ba10c325192ad7528d21d
2021-12-01 17:19:19 +00:00
Bill Yi
887f2b7e02 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 1b3c701077 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16357024

Change-Id: I176834d8b4dd5c41bb9514a5d998699d202652a3
2021-12-01 17:18:27 +00:00
Bill Yi
7946a90b42 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 8e754d6891 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16356908

Change-Id: I6bda0cb874bb45735cda3852876ace5d8eef1635
2021-12-01 17:18:20 +00:00
Joshua Mccloskey
1ca42ffc79 Merge "Disable setting if sensor is convenience." into sc-v2-dev 2021-12-01 17:09:50 +00:00
TreeHugger Robot
83fede5908 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-12-01 16:59:42 +00:00
Tsung-Mao Fang
395ea90b83 Update background color for two-pane mode
Update background color for status bar and
homepage background programically.
Also, we update the backgroud color for highlight items.

Test: Rebuilt apk and see the screen.
Bug: 195293058
Change-Id: Id100f8c9c7fc02c43420afcca07a703a14ec2312
2021-12-01 16:39:09 +08:00
Joshua Mccloskey
756fa20e1c Fixed face enroll intro button issue
Fixed an issue where sometimes after completing face authentication the
more & agree buttons would display instead of the done button.

1. Enter SUW
2. Complete face authentication flow
3. Go to next step (finishing the Biometric flow)
4. Press the back button
5. Observe that the text now says "Done"

Fixes: 205203673
Test: Verified button text is changed as expected during SUW.
Change-Id: I5cfad265f9b27669dcad64e5872750695b1b5bdc
2021-11-30 09:29:13 -08:00
Alex Johnston
2f193c8157 Add non system overlay flag to InstallCaCertificateWarning
Bug: 196969991
Test: Manual testing with Settings
Change-Id: Ia9dc251c853526b2ce66c9f8ff595d496b7f1bc4
2021-11-30 16:28:31 +00:00
Zoey Chen
1df187a439 Merge "[Settings] Should show carrier network if airplane mode is on" into sc-v2-dev 2021-11-30 08:33:50 +00:00
Zoey Chen
8b1ecea060 [Settings] Should show carrier network if airplane mode is on
https://hsv.googleplex.com/6007361661566976

Test: atest SubscriptionsPreferenceControllerTest
Bug: 206990845
Change-Id: Id39b662f33b201a8e4ce53c34c3007eca9a40edf
2021-11-30 12:10:28 +08:00
Joe Bolinger
076dc5ee1b Merge "Remove face auth from setup wizard when configured as a convenience." into sc-v2-dev 2021-11-29 23:15:15 +00:00
Bill Yi
12a5d03d9f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic0a4b094fdd4f7898eb3726ba17b23a3563acb2a
2021-11-29 08:56:17 +00:00
Bill Yi
1b3c701077 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic270445cc1d57212de38787fab18a2d7ce937cca
2021-11-29 08:52:04 +00:00
Bill Yi
8e754d6891 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If3e347bcbdb1bda52690caa9ead4a9c913c8e990
2021-11-29 08:48:23 +00:00
Bonian Chen
1026e410f4 Merge "[Settings] Move display of VPN version into summary text" into sc-v2-dev 2021-11-29 06:05:40 +00:00
TreeHugger Robot
cd8a01d2fd Merge "Fix overlapped problem in SuW two panes mode" into sc-v2-dev 2021-11-29 05:37:34 +00:00
Sunny Shao
644a2b9bc6 Fix overlapped problem in SuW two panes mode
- The previous preview page will overlap the right pane in RTL language.
- The root cause is the false value of the clipToPadding and
  clipChildren.
- Use the TTheme.DeviceDefault.Settings.

Fixes: 204955818
Test: manual test
Change-Id: I75c7f419cf93ebe9c4e9e3cb24835163a6b01e11
2021-11-26 17:20:50 +08:00
Charles Chen
a8c97980a6 Fix different behaviors of deeplink in one/two pane
Test: manual - Reproducible steps mentioned in bug
fixes: 207740082
Change-Id: I1163e38c177307ccac8798eb649271d0466ab1c8
2021-11-26 07:54:42 +00:00
Bonian Chen
14e76c3233 [Settings] Move display of VPN version into summary text
Move the display of version text within VPN into summary part of the
display, and limit the height of summary area.

Bug: 205460459
Test: local
Change-Id: I666b9db356feeebf04e3be688897c2d9110a5275
(cherry picked from commit 144f295d7a)
2021-11-26 05:53:46 +00:00
Tsung-Mao Fang
17423d1682 Fix abnormal behavior on avatar account page
Prior to this cl, if user opens settings app
in single-pane first and navigates to
the avatar account page, then rotate the device,
user observed the account page was still shown
with full screen.

Because we didn't register correct split rule,
it causes the abormal behavior on two-pane mode.
In order to register correct rule,  we also need
to assign correct component name while opening the
account page.

Bug: 207609699
Test: Rebuilt apk and verify the behavior
Change-Id: I31def684c033c1d0c20870284826c6713a31b43d
2021-11-25 04:19:14 +00:00
Sergey Serokurov
045983a6d2 Merge "Fix truncated string in bubbles setting screen" into sc-v2-dev 2021-11-25 02:44:34 +00:00
Sergey Serokurov
258f5d8f26 Fix truncated string in bubbles setting screen
Bug: 187217715
Test: Manual, screenshot after the fix at https://screenshot.googleplex.com/4DjWc6AZTE6e75N
Change-Id: Ib683a9500cefed0d79192866e691257380a72a92
2021-11-24 16:17:31 -08:00
TreeHugger Robot
aee951dcb0 Merge "UI refinement of highlighted menu entry for large screen" into sc-v2-dev 2021-11-24 18:16:37 +00:00
Joe Bolinger
710622d818 Merge "Prevent scrolling when interacting with confirm pattern prompt." into sc-v2-dev 2021-11-24 17:48:07 +00:00
TreeHugger Robot
9928e585a6 Merge "Fix talkback issue on Subsettings" into sc-v2-dev 2021-11-24 09:54:34 +00:00
Joe Bolinger
ebbb5c277e Prevent scrolling when interacting with confirm pattern prompt.
This uses the same fix as related commit e55568a7ba

Fix: 207325277
Test: manual (set pattern via settings in dual pane mode)
Change-Id: Ic56829df23442df45d47d60ea5b8319e4ab58931
2021-11-23 21:37:46 +00:00
TreeHugger Robot
ee18babe99 Merge "Fix abnormal behavior on search page" into sc-v2-dev 2021-11-23 09:38:20 +00:00
Jernej Virag
6e82d4019d Merge "Add animation graphic to Long Press Power settings screen." into sc-v2-dev 2021-11-23 08:35:38 +00:00
Tsung-Mao Fang
0e03b12d60 Fix abnormal behavior on search page
Prior to this cl, if user opens settings app
in single-pane first and navigates to
the search page, then rotate the device,
user observed the search page was still shown
with full screen.

Because we didn't register correct split rule,
it causes the abormal behavior on two-pane mode.
In order to register correct rule,  we also need
to assign correct component name while opening the
search page.

Fix: 206896763
Test: Rebuilt apk and verify the behavior
Change-Id: I7343467aa716d71da63f2ad0a034dc6c1b7fd415
2021-11-23 16:32:32 +08:00
jasonwshsu
a8442468ad Align the "Open activity" UI style with usual accessibility service "Use service"
Root Cause: "Open activity" Preference is not part of the widget SettingsMainSwitchBarPreference, so its UI style did not be inherited.

Solution: "Open activity" has different concept from switch bar, we need to manual set its bacground to comply with the SettingsLib style.

Bug: 207067203
Test: manual test
Change-Id: I66f63f6952e5c4770509febc0e53eca6dc6eedb9
2021-11-23 15:13:39 +08:00
Yi-Ling Chuang
488211c752 Make fingerprint registration flow full screen
Since the fingerprint registration sometimes has a hardware dependency,
to bring a better UX, make the flow full screen on large screen devices.

Bug: 197717071
Test: Try to register a new fingerprint and see the pages are full
screen.

Change-Id: I5dcb720a8b6a58bd9fc67ecae35f730c20a2c4d3
2021-11-23 11:39:43 +08:00
Tsung-Mao Fang
e260ebe157 Fix talkback issue on Subsettings
Set window title for activity, so it won't announce
"Settings" again.

Test: Run the talkback and do not observe issue
Fix: 200749911
Change-Id: Ied973916bdd43562424b97eadea2b3a413c712ec
2021-11-23 11:35:09 +08:00
Joe Bolinger
d00fd7f362 Remove face auth from setup wizard when configured as a convenience.
Fix: 206867696
Test: manual (enroll via SUW with/without unicorn)
Change-Id: I41bf7488cf30ffe3e0d09282e923347c7f5938df
2021-11-23 00:59:31 +00:00
Joshua Mccloskey
e711b3277e Disable setting if sensor is convenience.
This change disables the FaceSettings Confirmation setting if a
sensor is convenience. This is due to the fact that convenience strength
sensors can't be used by BiometricPrompt (so this setting has no
effect.)

Test: Verified this setting shows depending on whether or not the sensor
is convenience or not.
Fixes: 204137656

Change-Id: I88daf9f12b76d06697275161385f463fb88e0f3a
2021-11-22 13:49:17 -08:00
Jason Chiu
90eef24080 UI refinement of highlighted menu entry for large screen
- Add a new highlight background drawable
- Add two homepage specific preferences for the new layout design

Fix: 207079684
Test: visual
Change-Id: I20c80da090a03129bffa845d443ee5d1ad13b97b
2021-11-22 12:36:05 +08:00
Jason Hsu
37ec371fb9 Merge "Remove the 'new' word for accessibility gesture tutorial dialog" into sc-v2-dev 2021-11-22 03:57:40 +00:00
TreeHugger Robot
4e78e0923f Merge "Redesign homepage layout for two-pane mode." into sc-v2-dev 2021-11-22 02:28:27 +00:00
jasonwshsu
7259d14324 Remove the 'new' word for accessibility gesture tutorial dialog
Root Cause: We merge back accessibility gesture feature into sc-v2, but
the tutorial dialog is still the original content.

Solution: Since it is not the new feature anymore, we just want to
introduce the feature, so remove the 'new' word.

Bug: 204850690
Test: manual test
Change-Id: I38aff0cee6779153066e414e654611fa83d0a533
2021-11-19 17:06:59 +08:00
Jason Chiu
bb46bb79bf Disable animations of deep link homepages to reduce the shortcut flicker
Bug: 203744424
Test: manual
Change-Id: I7806d732be99425e98db615474bdd83e42dc072e
2021-11-19 12:44:41 +08:00
Joshua Mccloskey
7c0111b0f1 Updated udfps strings
Test: Verified during enrollment that strings are correct
Fixes: 199192320
Change-Id: I9d1dd8e9be6c4d714f24dcea3c6d6de7f218dd26
2021-11-18 16:36:26 -08:00
Kevin Han
83a8b76ec2 Merge "Unhibernate an app when a user exempts it" into sc-v2-dev 2021-11-18 21:37:46 +00:00
TreeHugger Robot
03b049e8cd [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: ebd2e1f662 -s ours am: 9adb10d6fc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16294832

Change-Id: I5df51725bdc32edb3d2fa43b0cf48e86b5d85517
2021-11-18 19:22:38 +00:00
TreeHugger Robot
20a56f067a Merge changes from topic "presubmit-am-54d98b71e97148f688d58b0d364066e1" into sc-qpr1-dev am: 6cae0edae1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16294832

Change-Id: Ib799378b91a9cdb1219caef564a86f2e4b8e4867
2021-11-18 19:22:33 +00:00