Chaohui Wang
4b8e64c294
Merge "Fix SeekBarPreference selectable test" into tm-dev am: 02314870c7
am: 39bd94e1e5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18578961
Change-Id: Ie8392d6d732af7c1197d3cd5ab76900cca836c80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 11:26:53 +00:00
Chaohui Wang
39bd94e1e5
Merge "Fix SeekBarPreference selectable test" into tm-dev am: 02314870c7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18578961
Change-Id: I4c87be62cf59f3fea0c17c3fb6f5564b0cfa75e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 11:07:31 +00:00
Chaohui Wang
02314870c7
Merge "Fix SeekBarPreference selectable test" into tm-dev
2022-05-25 10:50:48 +00:00
Automerger Merge Worker
934a230278
Merge "Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev am: 87f8135959
am: 1e410610d8" into tm-d1-dev-plus-aosp
2022-05-25 09:50:04 +00:00
Chaohui Wang
79351944b8
Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev am: 87f8135959
am: 635c506a92
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18591472
Change-Id: I804b3ccb98427f3104086a7b237913aba4011bd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 09:49:59 +00:00
Chaohui Wang
3374e43ff7
Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev am: 87f8135959
am: 1e410610d8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18591472
Change-Id: I4d6613dc32980d8958191cd0aa128716430ca407
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 09:49:59 +00:00
Chaohui Wang
635c506a92
Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev am: 87f8135959
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18591472
Change-Id: Id62102e910aa81346a986551244fb689c74aa0cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 09:32:46 +00:00
Chaohui Wang
1e410610d8
Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev am: 87f8135959
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18591472
Change-Id: I6a8942f58c25a773719f4db05a6d44b50a491ccb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 09:31:14 +00:00
Chaohui Wang
87f8135959
Merge "Clean up lifecycle in MobileNetworkSettings" into tm-dev
2022-05-25 09:13:44 +00:00
Chaohui Wang
968f30a470
Fix SeekBarPreference selectable test
...
SeekBarPreference is set to unselectable in change
Ie5d819088dc3c435005ddd00e232b2f6992b234a
Update the test accordingly.
Bug: 230553896
Test: robotest
Change-Id: Ia024b81e3f8e3808b0bb1e48c41a84d0ececaa85
2022-05-25 16:58:08 +08:00
Weng Su
410f9d3e6a
Merge "Refine carrier Wi-Fi functions" into tm-dev am: 750376ec40
am: 676498649e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18558087
Change-Id: I5cc5bfae5e99aec94011c8bb56a8cae9714f3d22
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 08:30:19 +00:00
Weng Su
3146d2259d
Merge "Refine carrier Wi-Fi functions" into tm-dev am: 750376ec40
am: 395c675770
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18558087
Change-Id: I65e7ce206f05c3dbdb871b5b793514f758f5ef93
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 08:30:01 +00:00
Weng Su
676498649e
Merge "Refine carrier Wi-Fi functions" into tm-dev am: 750376ec40
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18558087
Change-Id: I5fc1cd3176b7ba042d32e46e2fd94b2b3331c707
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 08:11:40 +00:00
Weng Su
395c675770
Merge "Refine carrier Wi-Fi functions" into tm-dev am: 750376ec40
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18558087
Change-Id: I2d1d5c15f39a86c93322e07f2f0cf17869a0d41d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 08:09:54 +00:00
Weng Su
750376ec40
Merge "Refine carrier Wi-Fi functions" into tm-dev
2022-05-25 07:50:35 +00:00
Chaohui Wang
866b79c245
Clean up lifecycle in MobileNetworkSettings
...
To avoid double registering, which prevent potential issues and could
improve latency.
Since DashboardFragment already supported register lifecycle
automatically for the controllers bound by XML which implements
androidx.lifecycle.Lifecycle, so doing a cleanup to prevent register
lifecycle event manually (doubling).
Bug: 149338098
Test: temporarily add logging to make sure the lifecycle method is
called and only called once
Change-Id: I4dbc36414991ef6b599be61aa77ff0dc8c52468c
2022-05-25 13:46:55 +08:00
Daniel Chapin
82ed2bc190
Merge "Fix crash for DefaultSubscriptionController" into tm-dev am: fa878f2f26
am: 61ffcb9b61
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18573290
Change-Id: I7a9feb3c1ca919dd615ca6475c32e1086ba353fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 01:11:33 +00:00
Daniel Chapin
3a1eb1da63
Merge "Fix crash for DefaultSubscriptionController" into tm-dev am: fa878f2f26
am: 1c432c5a1e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18573290
Change-Id: I3651532bb9ec4d60c4cf1b51ebd4447d8728fe04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 01:11:20 +00:00
Daniel Chapin
1c432c5a1e
Merge "Fix crash for DefaultSubscriptionController" into tm-dev am: fa878f2f26
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18573290
Change-Id: I6f97b69e20648341043bbdfff4e8d28ca62b7d73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 00:43:16 +00:00
Daniel Chapin
61ffcb9b61
Merge "Fix crash for DefaultSubscriptionController" into tm-dev am: fa878f2f26
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18573290
Change-Id: Id94e14072b159e13ae5d42f3c6aded5c8fae8404
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 00:41:38 +00:00
Daniel Chapin
fa878f2f26
Merge "Fix crash for DefaultSubscriptionController" into tm-dev
2022-05-25 00:22:04 +00:00
Chaohui Wang
2e34038233
Fix crash for DefaultSubscriptionController
...
setSummaryProvider() is used instead of setSummary() in
Ia24d88817c99db7ed3fc264dbc9c10e0a09d8a39, but there is still a place
using the setSummary(), mixing these two will lead to crash.
Change it to setSummaryProvider() to prevent crash.
Fix: 233295254
Fix: 233712251
Test: manual
Change-Id: I4627545711b848009c3bd7179f0368ff82e62697
2022-05-24 16:51:51 +00:00
TreeHugger Robot
84c8dd38e6
Merge "Fix can't start injected item problem" into tm-dev am: 74c324b70f
am: 19589d5bb4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18570252
Change-Id: I7e94225cdf291655074e87a2bef8b70b3d65a8fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 13:37:56 +00:00
TreeHugger Robot
d8216ec3d5
Merge "Fix can't start injected item problem" into tm-dev am: 74c324b70f
am: 0dc5eff113
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18570252
Change-Id: Ica7fc11c05ff72f5fd8ba566cf2be39e77225c8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 13:37:46 +00:00
TreeHugger Robot
0dc5eff113
Merge "Fix can't start injected item problem" into tm-dev am: 74c324b70f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18570252
Change-Id: Ie33b331b8facb0d59287bf445dd93bee1054cbe5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 13:03:03 +00:00
TreeHugger Robot
19589d5bb4
Merge "Fix can't start injected item problem" into tm-dev am: 74c324b70f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18570252
Change-Id: Ie40e649eb7e9ffd0859a0bd3af839bc7d647146f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 13:01:26 +00:00
Edgar Wang
356ddd45ac
Merge "Fix talkback speak "double tap to activate" on LabeledSeekBarPreference" into tm-dev am: 4c07e2b865
am: 9b81fec6a0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18475669
Change-Id: I17f8d143eaedb2f9e2303d1c1460132e53cb6abc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 12:54:03 +00:00
Edgar Wang
73f218bd81
Merge "Fix talkback speak "double tap to activate" on LabeledSeekBarPreference" into tm-dev am: 4c07e2b865
am: 0c461ec850
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18475669
Change-Id: I33097744676c47efd61fe8eb242cddf0a9843e11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 12:45:28 +00:00
TreeHugger Robot
74c324b70f
Merge "Fix can't start injected item problem" into tm-dev
2022-05-24 12:41:46 +00:00
Edgar Wang
9b81fec6a0
Merge "Fix talkback speak "double tap to activate" on LabeledSeekBarPreference" into tm-dev am: 4c07e2b865
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18475669
Change-Id: I93c94eee39fa5ea786632b04498ba99eecc02eec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 12:29:09 +00:00
Edgar Wang
0c461ec850
Merge "Fix talkback speak "double tap to activate" on LabeledSeekBarPreference" into tm-dev am: 4c07e2b865
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18475669
Change-Id: I38b97fd064bfaddde409a6c9bffc5a10d4dc9e05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 12:27:34 +00:00
Edgar Wang
4c07e2b865
Merge "Fix talkback speak "double tap to activate" on LabeledSeekBarPreference" into tm-dev
2022-05-24 12:07:41 +00:00
Victor Chang
330934cfb5
Merge "Reland "Don't use framework strings for formatting file sizes"" am: ba69fd0d3f
am: d5ab7dc729
am: 5aada33242
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2096605
Change-Id: I7208109922af4f7e2bf7aa67e4ee599164eff16c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 11:29:37 +00:00
Victor Chang
5aada33242
Merge "Reland "Don't use framework strings for formatting file sizes"" am: ba69fd0d3f
am: d5ab7dc729
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2096605
Change-Id: I8b616af8d02a6d984d7dbec2b50087242958dd40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 11:20:54 +00:00
Victor Chang
d5ab7dc729
Merge "Reland "Don't use framework strings for formatting file sizes"" am: ba69fd0d3f
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2096605
Change-Id: Ib0ad04ef4c225fbc449abed9913381d6c8d3a138
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 10:53:20 +00:00
Victor Chang
ba69fd0d3f
Merge "Reland "Don't use framework strings for formatting file sizes""
2022-05-24 10:04:46 +00:00
Binyi Wu
311e40ce4b
Merge "Prevent keyboard from blocking the input box for WiFi configuration page." into tm-dev am: 8fd6873250
am: 2331e4b511
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18556457
Change-Id: I50ed51405f483c4072aa20a72208ca06be119ffd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 09:44:32 +00:00
Binyi Wu
7c5f75c221
Merge "Prevent keyboard from blocking the input box for WiFi configuration page." into tm-dev am: 8fd6873250
am: 3ea7d18309
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18556457
Change-Id: I6e8a23ab2074f976b646ac46cefee5e8fd725fbf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 09:44:08 +00:00
Binyi Wu
2331e4b511
Merge "Prevent keyboard from blocking the input box for WiFi configuration page." into tm-dev am: 8fd6873250
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18556457
Change-Id: I513978e2c436055ac1269fd4795d11c48b0ddef3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 09:17:12 +00:00
Binyi Wu
3ea7d18309
Merge "Prevent keyboard from blocking the input box for WiFi configuration page." into tm-dev am: 8fd6873250
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18556457
Change-Id: Ice082991ab8157716aa910ee15ad2c7fa8096086
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 09:15:28 +00:00
Binyi Wu
8fd6873250
Merge "Prevent keyboard from blocking the input box for WiFi configuration page." into tm-dev
2022-05-24 08:32:03 +00:00
Arc Wang
03d8d11914
Fix can't start injected item problem
...
Should set highlight Preference key after
isDuplicateClick to ensure clicked Preference
key & highlight Preference are different and
then isDuplicateClick returns a correct value.
Bug: 233553587
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.dashboard
manual
1. Click all left pane items and see if there is any launch problem.
2. Check if duplicate click check works.
Change-Id: Ic6394b96896fd3a0fb926707565f63beff74a27b
2022-05-24 07:13:35 +00:00
TreeHugger Robot
c468b7f873
Merge "[VolumePanel] Add Hearable control slice in VolumePanel" into tm-dev am: d9174aa3cc
am: 62050f266a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18490664
Change-Id: I9582436cffe9ddfc18e2b803e79262effe0192bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 05:14:11 +00:00
TreeHugger Robot
eb9df278da
Merge "[VolumePanel] Add Hearable control slice in VolumePanel" into tm-dev am: d9174aa3cc
am: 9ba22d2ec9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18490664
Change-Id: I3498483e5e73d28151b5ac151ca05b2f375f9333
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 05:14:06 +00:00
Edgar Wang
2b0d9cfc5d
Fix talkback speak "double tap to activate" on LabeledSeekBarPreference
...
- SeekBarPreference should be unselectable
- remove unnecessary handling of Summary
- set currect Title color when preference is enabled and unselectable
Bug: 230553896
Test: robotest
Change-Id: Ie5d819088dc3c435005ddd00e232b2f6992b234a
2022-05-24 05:08:16 +00:00
Binyi Wu
26e5e919c8
Prevent keyboard from blocking the input box for WiFi configuration page.
...
Bug: 223980567
Test: manual
Change-Id: I2b95b065394e2395396ff71b00bd949ac824dac3
2022-05-24 12:50:41 +08:00
TreeHugger Robot
9ba22d2ec9
Merge "[VolumePanel] Add Hearable control slice in VolumePanel" into tm-dev am: d9174aa3cc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18490664
Change-Id: I05b01fbce6e6e1dc51cd5bdad2d9fdd0a80bb068
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 04:42:47 +00:00
TreeHugger Robot
62050f266a
Merge "[VolumePanel] Add Hearable control slice in VolumePanel" into tm-dev am: d9174aa3cc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18490664
Change-Id: I062ee27af956efba4246b377f797bf11df9b43de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 04:42:12 +00:00
TreeHugger Robot
020ac9fb19
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev am: 0a367dea1d
-s ours am: 17093f454c
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18519367
Change-Id: I09d9455cc2b417845eac29b6e453c6f220618a99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 04:04:55 +00:00
Bill Yi
fd2febf4bc
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f9b665e302
-s ours am: 410d895879
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18519367
Change-Id: Ida8ee47cf088bb8f90ef77e766757f562e9084dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 04:04:41 +00:00