The visible symptom of this problem is that when deleting an account, if
a screen lock is set, after confirming the removal and entering the
credentials, you end up back on the account details for the page and it
looks like the deletion failed (even though it didn't).
There were two problems here:
-We were expecting the AccountDetailDashboardFragment to be in a resumed
state at the end of the confirmation dialog, but it wasn't if we had
launched the activity to have the user enter their screen lock
credentials. In the past trying to finish an activity that wasn't in
resumed state seemed to have generated a crash (b/6494527), but that
isn't the case anymore from some tests I ran.
-The AccountDetailDashboardFragment doesn't check in onResume that the
account still exists.
This CL fixes the bug in 2 ways - we'll always try to finish the
AccountDetailDashboardFragment if the account removal succeeded, and
when AccountDetailDashboardFragment's onResume is called we'll always
check for the account existence. Either approach would be sufficient on
its own.
Change-Id: Iaa65e97fca5dfc8b1251968142e47315e3b590c2
Fixes: 112845988
Test: make RunSettingsRoboTests
When hearing aid device has been set active, we shouldn't invoke
1. a2dpProfile.setActiveDevice()
2. hfpProfile.setActiveDevice()
Change-Id: Ie13dea041dd98d0cb9d913e1f28574b300095db9
Merged-In: Ie13dea041dd98d0cb9d913e1f28574b300095db9
Fixes: 113625278
Test: RunSettingsRoboTests
1. Remove all the internal dependencies and add TODO
2. Use the API in SettingsFragment for progressbar
Bug: 114749736
Test: Build
Change-Id: If2f57dd24528ae1aac6a1fe84d4a40db237ae7da
This is a clean copy except:
1. Fix issues in strings.xml to make it pass pre-upload check
a) add "CHAR_LIMIT"
b) Update special character
Future CL will remove compile error and make it compatible with
settings.
Bug: 114749736
Test: Build
Change-Id: I8fe28ff1358f94334ff9663a4404628ae0eff9af
Considers subId when reading carrier config values
KEY_READ_ONLY_APN_TYPES_STRING_ARRAY and
KEY_READ_ONLY_APN_FIELDS_STRING_ARRAY.
This ensures that the APN will be editable or non-editable correctly
when using dual sim.
Bug: 112929355
Test: Manual
Change-Id: I2186dd5e1f71ca5361309a7314f84cf4fa2d3937
The mode of sliceView is set to MODE_SHORTCUT accidentally
in the previous commit. Set it back to MODE_LARGE.
Change-Id: I1ae8e895fc0172d2d93fc19c54803d56040379da
Fixes: 115709730
Test: robotests
Many contextual cards will be built as slices, so we need a controller
and a renderer for them.
Change-Id: I3816db09ba0181399810652fb18fbe11ce273267
Fixes: 115709730
Test: robotests
I made it visible by default by accident.
Test: Looked at Settings > Security & locations > Screen pinning
Change-Id: I8ff6dc72e292ba76550edaeeac4d53ef4bd39505
Fixes: 116109852
