Commit Graph

134074 Commits

Author SHA1 Message Date
Colin Cross
400d13123c Fix more kotlin nullable errors in Settings
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I2923b3552aaee75a2c5b1ebd9c7fbee882fe4cae
2023-08-22 15:24:08 -07:00
Anvesh Renikindi
b8f03ec8f6 [automerger skipped] Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main am: 1937711c8a am: e75ae19e0f -s ours am: 19688da90e -s ours am: 9517e0e202 -s ours am: f92b2ab6d1 -s ours
am skip reason: Merged-In Idbfa244921957be2bba3cd02e5e873e81e8807d8 with SHA-1 05514d0f4d is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2717673

Change-Id: Iba1f58b2f965429a4da280222e028b159d217a8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 18:44:38 +00:00
Anvesh Renikindi
f92b2ab6d1 [automerger skipped] Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main am: 1937711c8a am: e75ae19e0f -s ours am: 19688da90e -s ours am: 9517e0e202 -s ours
am skip reason: Merged-In Idbfa244921957be2bba3cd02e5e873e81e8807d8 with SHA-1 05514d0f4d is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2717673

Change-Id: Ic749bb0f4e66e8cf0d7828901bf2a71ea12750f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 17:59:49 +00:00
Anvesh Renikindi
9517e0e202 [automerger skipped] Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main am: 1937711c8a am: e75ae19e0f -s ours am: 19688da90e -s ours
am skip reason: Merged-In Idbfa244921957be2bba3cd02e5e873e81e8807d8 with SHA-1 05514d0f4d is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2717673

Change-Id: I3602f95128bce1e01ab19e4b47e01687d7c8ac71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 17:31:22 +00:00
Anvesh Renikindi
19688da90e [automerger skipped] Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main am: 1937711c8a am: e75ae19e0f -s ours
am skip reason: Merged-In Idbfa244921957be2bba3cd02e5e873e81e8807d8 with SHA-1 05514d0f4d is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2717673

Change-Id: I4a111c6475a2a01fe40dedacd0073ed074c455c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 16:54:55 +00:00
Anvesh Renikindi
e75ae19e0f Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main am: 1937711c8a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2717673

Change-Id: I902d13988333ad9782e9882a6b939b2f195832ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 16:16:37 +00:00
Treehugger Robot
0c0cefa07d [automerger skipped] Merge "Add Instant hotspot preference" into udc-qpr-dev am: 67d5cb42e9 am: eafc4034d3 -s ours
am skip reason: Merged-In I343599e6127d9b1cb4af661dcc80a8683589c7b8 with SHA-1 63321a1a83 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24483137

Change-Id: Ifc7db0bffafafdf26cdec78dad8164a93dcb5b7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 15:39:53 +00:00
Anvesh Renikindi
1937711c8a Merge "Change nullability of inheriting function of PinPrivacyPreferenceController" into main 2023-08-22 15:25:19 +00:00
Treehugger Robot
eafc4034d3 Merge "Add Instant hotspot preference" into udc-qpr-dev am: 67d5cb42e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24483137

Change-Id: I345ec2843e47be6ba23b64807eb1b23ad479738a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-22 15:00:02 +00:00
Treehugger Robot
67d5cb42e9 Merge "Add Instant hotspot preference" into udc-qpr-dev 2023-08-22 14:36:05 +00:00
Chaohui Wang
adc24bca63 Merge "Clean up unused Lifecycle" into main 2023-08-22 10:36:32 +00:00
Chaohui Wang
cdbe5f350d Clean up unused Lifecycle
From DataUsageSummaryPreferenceController.

Bug: 295260929
Test: m RunSettingsRoboTests
Change-Id: I4f1d33d7878a80e10aae908df32cff052762fd62
2023-08-22 14:21:03 +08:00
Treehugger Robot
47c6c86015 Merge "Add Instant hotspot preference" into main 2023-08-22 04:25:10 +00:00
Austin Delgado
e7377fc73c Merge "Fix talkback not announcing requirement in ChooseLock" into udc-qpr-dev am: fdb53691b1 am: 7f18843856
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24502371

Change-Id: I78f52d9f6a248cc9b0bb8461d97a63190a454f7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 23:26:25 +00:00
Austin Delgado
7f18843856 Merge "Fix talkback not announcing requirement in ChooseLock" into udc-qpr-dev am: fdb53691b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24502371

Change-Id: Iaf8dfaf0764bc7d50c462dcfbf2b802fa2f60785
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:48:04 +00:00
Austin Delgado
fdb53691b1 Merge "Fix talkback not announcing requirement in ChooseLock" into udc-qpr-dev 2023-08-21 22:28:52 +00:00
Austin Delgado
5a4105b324 Fix talkback not announcing requirement in ChooseLock
Fix: 281955512
Test: Manual, verify talkback reads out password requirement on 17th digit
Change-Id: Ia274af9cc515d3ac9d344bd41d008ab5b4dbcabd
2023-08-21 13:33:49 -07:00
Treehugger Robot
675445314a [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours am: 60576c7278 -s ours am: cb61bf5909 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I1e145f7083519fde49018684768d7560ca14c954
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:29:22 +00:00
Bill Yi
74aa510bd0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours am: 3fbec94efd -s ours am: 206a0916b1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Ifa12f6b6c55638d4801e4482d45b48dddee51a62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:29:19 +00:00
Treehugger Robot
65e9a2206f [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours am: c1a9f3b899 -s ours am: 29e93d4241 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I7a753c196a1d57fc0997b4b4f458b7a809deab26
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:28:05 +00:00
Bill Yi
648c8b8dc4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours am: 9627696277 -s ours am: 022231ddfb -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Id6d8cfc75493033b38ed1f2bca8997280719aa7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:28:03 +00:00
Treehugger Robot
66263ddea7 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: ced1f0f311 -s ours am: 4b343ece13 -s ours am: 1d562cda45 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I7e377546936512e7af7cefa80cd4ccb6d48f47a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:25:47 +00:00
Bill Yi
b7c331a070 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: bb043fa69a -s ours am: c259f9189b -s ours am: d84e7d955d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I8567d7eadd4bdba5629d87e1b7eeafe2ef27200a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:25:42 +00:00
Treehugger Robot
cb61bf5909 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours am: 60576c7278 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Ic2f1cae8125c0e01b7696a9ee3731985219a648b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:21:35 +00:00
Bill Yi
206a0916b1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours am: 3fbec94efd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Iaa5d28846696851cddebb4374e620dd88c33fd31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:21:31 +00:00
Treehugger Robot
29e93d4241 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours am: c1a9f3b899 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Idcece623d0a3a058f9f12021fcecf8e062e05c8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:16:38 +00:00
Bill Yi
022231ddfb [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours am: 9627696277 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Icf186a242aba79a0b3ae0fc3d797e9749689529f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:16:32 +00:00
Treehugger Robot
c1a9f3b899 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Icec8d0e0f417da0f480689e328c5ea89718217c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:50:09 +00:00
Bill Yi
9627696277 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Iec3486257c3b84741f2260925d86e6dfd338e4b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:50:05 +00:00
Treehugger Robot
1d562cda45 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: ced1f0f311 -s ours am: 4b343ece13 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I62494fbf49eb5508d90fe21f52687e19115c505d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:45:09 +00:00
Bill Yi
d84e7d955d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: bb043fa69a -s ours am: c259f9189b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I3896d92494c875958a3e7298d8364983c72666c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:45:05 +00:00
Treehugger Robot
60576c7278 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: 113ac8d105 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I756267739c15c4c6a4f022fd74c9cc805fc44cc7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:44:15 +00:00
Bill Yi
3fbec94efd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: 99073e56cc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Ic27c81951e5d36e37571225bdc1071e8dff71c05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:44:11 +00:00
Treehugger Robot
4b343ece13 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: ced1f0f311 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Ic3d6b7af6a753a5c1317fb06fe13ca91987be35f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:18:54 +00:00
Bill Yi
c259f9189b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: bb043fa69a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I28caee0961f5593b64b79ac68572c3ba7e8b16ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:18:52 +00:00
Treehugger Robot
1b3d9dafc6 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours am: c34cae32c2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I7f47d69b7e26dc1c64c6bc6706cecbf3f9f88768
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:18:12 +00:00
Bill Yi
0232b3f150 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours am: d6d94306c4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I84a879c1b6e7fabc8ddb924c43aad71ca6f90cb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 18:18:07 +00:00
Treehugger Robot
113ac8d105 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I5180ce7f5bd3564f9e80ce4ef51259526e7f94a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:38:29 +00:00
Bill Yi
99073e56cc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Iaff959abd8c1eadac9f5a570202fb5eee0895ebc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:38:26 +00:00
Treehugger Robot
c34cae32c2 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I589a6145adad69b5041f0dddab5f9caa03848fcb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:36:45 +00:00
Bill Yi
d6d94306c4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Ib573dc85293cb08ca66fa6073885421b124f32e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:36:41 +00:00
Treehugger Robot
ced1f0f311 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 44e242075a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: Idfc84ae81d74aa5a5a7358b720d1b7e00740cb12
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:36:15 +00:00
Bill Yi
bb043fa69a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 75987a1856 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24485648

Change-Id: I403572a913f7a7c5a985bc779a71f816fd47d157
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:36:10 +00:00
Vlad Popa
0134421059 Merge "Do not show SA preference for device that do not support it" into main 2023-08-21 16:49:21 +00:00
Treehugger Robot
44e242075a Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-08-21 16:43:37 +00:00
Weng Su
27b3821313 Add Instant hotspot preference
- Add Instant hotspot preference to Wi-Fi hotspot settings

- Wait onServiceConnected callback and then getSettingsState

- Use the PendingIntent provided by SharedConnectivitySettingsState to launch Instant hotspot settings

Bug: 268550769
Test: manual test
atest -c WifiTetherSettingsTest
atest -c WifiTetherViewModelTest \
         SharedConnectivityRepositoryTest

Merged-In: I343599e6127d9b1cb4af661dcc80a8683589c7b8
Change-Id: I343599e6127d9b1cb4af661dcc80a8683589c7b8
2023-08-21 12:21:25 +00:00
Treehugger Robot
e10d0237c2 Merge "Use Mockito Kotlin" into main 2023-08-21 11:26:14 +00:00
Weng Su
63321a1a83 Add Instant hotspot preference
- Add Instant hotspot preference to Wi-Fi hotspot settings

- Wait onServiceConnected callback and then getSettingsState

- Use the PendingIntent provided by SharedConnectivitySettingsState to launch Instant hotspot settings

Bug: 268550769
Test: manual test
atest -c WifiTetherSettingsTest
atest -c WifiTetherViewModelTest \
         SharedConnectivityRepositoryTest

Change-Id: I343599e6127d9b1cb4af661dcc80a8683589c7b8
2023-08-21 11:14:04 +00:00
Treehugger Robot
8cfb640bf3 Merge "Add UI metrics logging for battery tips card." into main 2023-08-21 09:21:49 +00:00
Chaohui Wang
8647256269 Use Mockito Kotlin
Which has better support for Kotlin unit test.

Bug: 289155281
Test: unit test
Change-Id: Ic98ba7e66c124e8398ad01d3bca7ee3a771b06c4
2023-08-21 17:01:52 +08:00